Priority of HTB class on 10GbE

Hello, Have been using htb with 1Gbe nic for traffic control of three classes of traffic with priority 1,2 & 3, the configuration worked perfectly. The ceil of higher priority traffic gets filled before that of lower priority. " tc qdisc del dev enp1s0f1 root # This line sets a HTB qdisc on

Re: [PATCH 4.9.0-rc5] AR9300 calibration problems with antenna selected

I would prefer that you didn't submit this. I recently tried to select a single antenna on AR9300 and it works for 30 seconds only. The subsequent calibration makes the RX signal level to drop from the usual -30/-40 dBm to -70/-80 dBm, and the transmission practically stops. With the

Re: Synopsys Ethernet QoS Driver

On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: > On Fri, Nov 18, 2016 at 02:20:27PM +, Joao Pinto wrote: >> For now we are interesting in improving the synopsys QoS driver under >> /nect/ethernet/synopsys. For now the driver structure consists of a single >> file >>

RE: [net-next] rtnl: fix the loop index update error in rtnl_dump_ifinfo()

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Sunday, November 20, 2016 11:15 AM > To: zhangshen...@cmss.chinamobile.com > Cc: netdev@vger.kernel.org; d...@cumulusnetworks.com > Subject: Re: [net-next] rtnl: fix the loop index update error in >

Re: [PATCH net-next] bridge: add igmpv3 and mldv2 query support

2016-11-18 18:31 GMT+08:00 Nikolay Aleksandrov : > On 18/11/16 11:09, Nikolay Aleksandrov wrote: >> >> On 18/11/16 11:04, Nikolay Aleksandrov wrote: >>> >>> (+CC Roopa) >>> Hi Hangbin, >>> This patch is not correct, you should not use the net device IGMP config >>> in

Re: [PATCH v2 net-next 0/6] Fixes for the MV88e6xxx interrupt code

From: Andrew Lunn Date: Sun, 20 Nov 2016 20:14:13 +0100 > The interrupt code was never tested with a board who's probing > resulted in an -EPROBE_DEFFERED. So the clean up paths never got > tested. I now do have -EPROBE_DEFFERED, and things break badly during > cleanup. These are

[PATCH net 1/1] net: l2tp: Treat NET_XMIT_CN as success in l2tp_eth_dev_xmit

From: Gao Feng The tc could return NET_XMIT_CN as one congestion notification, but it does not mean the packe is lost. Other modules like ipvlan, macvlan, and others treat NET_XMIT_CN as success too. So l2tp_eth_dev_xmit should add the NET_XMIT_CN check. Signed-off-by: Gao

Re: [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source

On Mon, Nov 21, 2016 at 8:26 AM, wrote: > From: Gao Feng > > The function macvlan_forward_source_one has already checked the flag > IFF_UP, so needn't check it outside in macvlan_forward_source too. > > Signed-off-by: Gao Feng > ---

[PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully

From: Gao Feng The tc could return NET_XMIT_CN as one congestion notification, but it does not mean the packe is lost. Other modules like ipvlan, macvlan, and others treat NET_XMIT_CN as success too. So batman-adv should add the NET_XMIT_CN check. Signed-off-by: Gao Feng

[PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source

From: Gao Feng The function macvlan_forward_source_one has already checked the flag IFF_UP, so needn't check it outside in macvlan_forward_source too. Signed-off-by: Gao Feng --- v2: Remove the IFF_UP check in macvlan_forward_source instead of

Re: [RFC PATCH v2 2/2] macb: Enable 1588 support in SAMA5D2 platform.

On Fri, Nov 18, 2016 at 03:21:52PM +0100, Andrei Pistirica wrote: > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index d975882..eb66b76 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -697,6 +697,8

Re: [RFC PATCH v2 1/2] macb: Add 1588 support in Cadence GEM.

On Fri, Nov 18, 2016 at 03:21:51PM +0100, Andrei Pistirica wrote: > +#ifdef CONFIG_MACB_USE_HWSTAMP > +void macb_ptp_init(struct net_device *ndev); > +#else > +void macb_ptp_init(struct net_device *ndev) { } static inline ^^^ > +#endif > +void macb_ptp_init(struct net_device *ndev) > +{ > +

Re: [RFC PATCH v2 1/2] macb: Add 1588 support in Cadence GEM.

On Fri, Nov 18, 2016 at 03:21:51PM +0100, Andrei Pistirica wrote: > - Frequency adjustment is not directly supported by this IP. This statement still makes no sense. Doesn't the following text... > addend is the initial value ns increment and similarly addendesub. > The ppb (parts per

[PATCH v2 net-next 2/6] net: dsa: mv88e6xxx: Fix unconditional irq freeing

Trying to remove an IRQ domain that was not created results in an Opps. Add the necessary checks that the irqs were created before freeing them. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-)

[PATCH v2 net-next 0/6] Fixes for the MV88e6xxx interrupt code

The interrupt code was never tested with a board who's probing resulted in an -EPROBE_DEFFERED. So the clean up paths never got tested. I now do have -EPROBE_DEFFERED, and things break badly during cleanup. These are the fixes. This is fixing code in net-next. v2: Fix typo pointed out by David

[PATCH v2 net-next 6/6] net: dsa: mv88e6xxx: Hold the mutex while freeing g1 interrupts

Freeing interrupts requires switch register access to mask the interrupts. Hence we must hold the register mutex. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 net-next 3/6] net: dsa: mv88e6xxx: Mask g1 interrupts and free interrupt

Fix the g1 interrupt free code such that is masks any further interrupts, and then releases the interrupt. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c

[PATCH v2 net-next 1/6] net: dsa: mv88e6xxx: Fix typos when removing g1 interrupts

Simple typos, s/g2/g1/ Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index d6d9d66b81ce..6aa81d2d8f63 100644 ---

[PATCH v2 net-next 5/6] net: dsa: mv88e6xxx: Fix releasing for the global2 interrupts

It is not possible to use devm_request_threaded_irq() because we have two stacked interrupt controllers in one device. The lower interrupt controller cannot be removed until the upper is fully removed. This happens too late with the devm API, resulting in error messages about removing a domain

[PATCH v2 net-next 4/6] net: dsa: mv88e6xxx: Fix cleanup on error for g1 interrupt setup

On error, remask the interrupts, release all maps, and remove the domain. This cannot be done using the mv88e6xxx_g1_irq_free() because some of these actions are not idempotent. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 31 ---

Re: [PATCH net 07/18] net/ena: refactor ena_get_stats64 to be atomic context safe

hub.com/0day-ci/linux/commits/Netanel-Belgazal/Update-ENA-driver-to-version-1-1-2/20161120-165649 > config: i386-randconfig-x009-201647 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree >

Re: [PATCH net 00/18] Update ENA driver to version 1.1.2

Hi David, Sorry for not being clear on my first patch set. Those changes introduce some bug fixes, new features and some cleanups that matching the driver to the upstream standard. Bug Fixes: *net/ena: remove RFS support from device feature list *net/ena: fix queues number calculation

[PATCH v2] ethernet: stmmac: make DWMAC_STM32 depend on it's associated SoC

There's not much point, except compile test, enabling the stmmac platform drivers unless the STM32 SoC is enabled. It's not useful without it. Signed-off-by: Peter Robinson --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source_one

On Sun, 2016-11-20 at 19:21 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > The condition check "dev->flags & IFF_UP" is duplicated in > macvlan_forward_source_one, because its caller macvlan_forward_source > has already checked this flag. > > Signed-off-by: Gao Feng

Re: [PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

On 11/20/2016 08:08 AM, Timur Tabi wrote: > On Mon, Nov 14, 2016 at 12:35 PM, Florian Fainelli > wrote: >> if (!(drv->features & (SUPPORTED_Pause | SUPPORTED_AsymPause)) >> phydev->supported |= SUPPORTED_Pause | SUPPORTED_AsymPause; > > How about, if either bit

Re: [PATCH v2 net-next] mlx4: avoid unnecessary dirtying of critical fields

On Sun, 2016-11-20 at 09:24 -0800, Eric Dumazet wrote: > /* Current cpu is not according to smp_irq_affinity - > - * probably affinity changed. need to stop this NAPI > - * poll, and restart it on the right CPU > + * probably affinity changed.

[PATCH v2 net-next] mlx4: avoid unnecessary dirtying of critical fields

From: Eric Dumazet While stressing a 40Gbit mlx4 NIC with busy polling, I found false sharing in mlx4 driver that can be easily avoided. This patch brings an additional 7 % performance improvement in UDP_RR workload. 1) If we received no frame during one

Re: [PATCH net-next] mlx4: avoid unnecessary dirtying of critical fields

On Sun, 2016-11-20 at 17:14 +0200, Tariq Toukan wrote: > Hi Eric, > > Thanks for your patch. > > On 18/11/2016 10:15 PM, Eric Dumazet wrote: > > + > > + AVG_PERF_COUNTER(priv->pstats.rx_coal_avg, polled); > Keep this perf stats update out of the if block. This perf stat would be

Re: [PATCH] [v2] net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause

On Mon, Nov 14, 2016 at 12:35 PM, Florian Fainelli wrote: > if (!(drv->features & (SUPPORTED_Pause | SUPPORTED_AsymPause)) > phydev->supported |= SUPPORTED_Pause | SUPPORTED_AsymPause; How about, if either bit is set in drv->features, then assume the phy driver

Re: [PATCH net-next] mlx4: avoid unnecessary dirtying of critical fields

Hi Eric, Thanks for your patch. On 18/11/2016 10:15 PM, Eric Dumazet wrote: From: Eric Dumazet While stressing a 40Gbit mlx4 NIC with busy polling, I found false sharing in mlx4 driver that can be easily avoided. This patch brings an additional 7 % performance

Re: [PATCH net 00/18] Update ENA driver to version 1.1.2

From: Netanel Belgazal Date: Sun, 20 Nov 2016 10:45:29 +0200 > Update Amazon's Elastic Network Adapter (ENA) driver version from 1.0.2 to > 1.1.2 This is insufficient. You must explain what this patch series is doing, how it is doing it, and why it is doing it that

Re: net/sctp: BUG: KASAN: stack-out-of-bounds in memcmp

On Sat, Nov 12, 2016 at 6:12 PM, Baozeng Ding wrote: > > > On 2016/11/10 13:48, Xin Long wrote: >> On Sat, Oct 15, 2016 at 4:28 PM, Baozeng Ding wrote: >>> Hello Xin Long, >>> >>> On 2016/10/14 19:13, Xin Long wrote: On Sat, Aug 20, 2016 at 3:51 PM,

[PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source_one

From: Gao Feng The condition check "dev->flags & IFF_UP" is duplicated in macvlan_forward_source_one, because its caller macvlan_forward_source has already checked this flag. Signed-off-by: Gao Feng --- drivers/net/macvlan.c | 3 --- 1 file changed,

STRICTLY CONFIDENTIAL

I have important transaction for you as next of kin to claim US$18.37m Mail me on my private email: chimwia...@gmail.com so I can send you more details Thanks Mr.Chim Wai Kim MOVE TO INBOX=== DISCLAIMER: This email and any files it contains are confidential

Re: [PATCH net 07/18] net/ena: refactor ena_get_stats64 to be atomic context safe

Hi Netanel, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Netanel-Belgazal/Update-ENA-driver-to-version-1-1-2/20161120-165649 config: i386-randconfig-x009-201647 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce

QUICK LOAN OFFER

Do You Need A Loan Of Any Kind ? If Yes Email Now For More Info Contact us on: skyfinance...@gmail.com --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

[PATCH net 14/18] net/ena: add IPv6 extended protocols to ena_admin_flow_hash_proto

We intend to use those fields in the future. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_admin_defs.h

[PATCH net 09/18] net/ena: change condition for host attribute configuration

Move the host info config to be the first admin command that is executed. This change require the driver to remove the 'feature check' from host info configuration flow. The check is removed since the supported features bitmask field is retrieved only after calling ENA_ADMIN_DEVICE_ATTRIBUTES

[PATCH net 00/18] Update ENA driver to version 1.1.2

Update Amazon's Elastic Network Adapter (ENA) driver version from 1.0.2 to 1.1.2 Netanel Belgazal (18): net/ena: remove RFS support from device feature list net/ena: fix queues number calculation net/ena: use napi_schedule_irqoff when possible net/ena: reduce the severity of ena printouts

[PATCH net 11/18] net/ena: fix potential access to freed memory during device reset

If the ena driver detects that the device is not behave as expected, it tries to reset the device. The reset flow calls ena_down, which will frees all the resources the driver allocates and then it will reset the device. This flow can cause memory corruption if the device is still writes to the

[PATCH net 13/18] net/ena: remove redundant logic in napi callback for busy poll mode

sk_busy_loop can call the napi callback few million times a sec. For each call there is unmask interrupt. We want to reduce the number of unmasks. Add an atomic variable that will tell the napi handler if it was called from irq context or not. Unmask the interrupt only from irq context. A

[PATCH net 15/18] net/ena: remove affinity hint from the driver

To allow irqbalance to better distribute the napi handler, remove the smp affinity hint from the driver. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH net 01/18] net/ena: remove RFS support from device feature list

Remove NETIF_F_NTUPLE from netdev->features. The ENA device driver does not support RFS acceleration. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH net 02/18] net/ena: fix queues number calculation

The ENA driver tries to open a queue per vCPU. To determine how many vCPUs the instance have it uses num_possible_cpus while it should have use num_online_cpus instead. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file

[PATCH net 04/18] net/ena: reduce the severity of ena printouts

Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 27 +-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 14 +++--- 2 files changed, 28 insertions(+), 13 deletions(-) diff --git

[PATCH net 05/18] net/ena: add hardware hints capability to the driver

The ENA device can update the ena driver about the desire timeouts. The hardware hints are transmitted as Asynchronous event to the driver. In case the device does not support this capability, the driver will use its own defines. Signed-off-by: Netanel Belgazal ---

[PATCH net 07/18] net/ena: refactor ena_get_stats64 to be atomic context safe

ndo_get_stat64 can be called from atomic context. However the current implementation sends an admin command to retrieve the statistics from the device. This admin commands uses sleep. Refactor the implementation of ena_get_stats64 to take the {rx,tx}bytes/cnt from the driver's inner counters and

[PATCH net 03/18] net/ena: use napi_schedule_irqoff when possible

Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 8815217..e3acf76

[PATCH net 12/18] net/ena: refactor skb allocation

To increase readability, refactor skb allocation to dedicated function This change does not impact the performance since the compiler optimize the code and elimitate the if condition. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c |

[PATCH net 08/18] net/ena: change sizeof() argument to be the type pointer

Instead of using: memset(ptr, 0x0, sizeof(struct ...)) use: memset(ptr, 0x0, sizeor(*ptr)) Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH net 18/18] net/ena: change driver's default timeouts and increase driver version

Driver version was increased to 1.1.2 Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++-- drivers/net/ethernet/amazon/ena/ena_netdev.h | 9 + 2 files changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH net 06/18] net/ena: fix ethtool RSS flow configuration

ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power of two values. Signed-off-by: Netanel Belgazal ---

[PATCH net 10/18] net/ena: use READ_ONCE to access completion descriptors

Completion descriptors are accessed from the driver and from the device. To avoid reading the old value, use READ_ONCE macro. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.h | 1 + drivers/net/ethernet/amazon/ena/ena_eth_com.c | 8

[PATCH net 17/18] net/ena: fix NULL dereference when removing the driver after device reset faild

If for some reason the device stop responding and the device reset failed to recover the device, the mmio register read datastructure will not be reinitialized. On driver removal, the driver will also tries to reset the device but this time the mmio data structure will be NULL. To solve this

[PATCH net 16/18] net/ena: fix error handling when probe fails

When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + 1 file changed, 1