Re: [PATCH iproute2 2/2] tc/act_tunnel: Introduce ip tunnel action

On Mon, Nov 21, 2016 at 11:50:03PM +, Rosen, Rami wrote: > Hi, Amir, > > Following are three minor comments: > > Seems that TCA_TUNNEL_KEY_PAD used anywhere: I assume you ment that it is _NOT_ used anywhere: This attribute type is used in the kernel side only - for padding 64bit attributes.

Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

On Mon, Nov 21, 2016 at 8:30 PM, YUAN Linyu wrote: > I think there are newbie include me still use ifconfig utility. > So when I check this code, it can be optimized. > Working on Linux kernel is always welcome. But I don't think this can convince DaveM to take

Re: [PATCH] mac80211: Remove unused 'struct rate_control_ref' variable

On Mon, 2016-11-21 at 22:54 -0800, Kirtika Ruchandani wrote: > Commit 3b17fbf87d5d introduced sta_get_expected_throughput() > leaving variable 'struct rate_control_ref* ref' set but unused. > Compiling with W=1 gives the following warning, fix it. > > net/mac80211/sta_info.c: In function

[Patch net] net: revert "net: l2tp: Treat NET_XMIT_CN as success in l2tp_eth_dev_xmit"

This reverts commit 7c6ae610a1f0, because l2tp_xmit_skb() never returns NET_XMIT_CN, it ignores the return value of l2tp_xmit_core(). Cc: Gao Feng Signed-off-by: Cong Wang --- net/l2tp/l2tp_eth.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] bnxt_en: Fix a VXLAN vs GENEVE issue

On Mon, Nov 21, 2016 at 9:14 PM, Christophe JAILLET wrote: > Knowing that: > #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_VXLAN(0x1UL << 0) > #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_GENEVE (0x5UL << 0) > and that

[PATCH] mac80211: Remove unused 'struct rate_control_ref' variable

Commit 3b17fbf87d5d introduced sta_get_expected_throughput() leaving variable 'struct rate_control_ref* ref' set but unused. Compiling with W=1 gives the following warning, fix it. net/mac80211/sta_info.c: In function ‘sta_set_sinfo’: net/mac80211/sta_info.c:2052:27: warning: variable ‘ref’ set

Re: [PATCH net 1/1] net: l2tp: Treat NET_XMIT_CN as success in l2tp_eth_dev_xmit

Hi Cong, On Tue, Nov 22, 2016 at 1:29 PM, Cong Wang wrote: > On Sun, Nov 20, 2016 at 4:56 PM, wrote: >> From: Gao Feng >> >> The tc could return NET_XMIT_CN as one congestion notification, but >> it does not mean the packe is

[PATCH] ipv6:ipv6_pinfo dereferenced after NULL check

From: Rohit Thapliyal np checked for NULL and then dereferenced. It should be modified for NULL case. Signed-off-by: Rohit Thapliyal Signed-off-by: Manjeet Pawar --- net/ipv6/ip6_output.c | 9 + 1 file changed,

Re: [mm PATCH v3 21/23] mm: Add support for releasing multiple instances of a page

On Mon, 21 Nov 2016 08:21:39 -0800 Alexander Duyck wrote: > >> + __free_pages_ok(page, order); > >> + } > >> +} > >> +EXPORT_SYMBOL(__page_frag_drain); > > > > It's an exported-to-modules library function. It should be documented, > > please?

[net] rtnetlink: fix the wrong minimal dump size getting from rtnl_calcit()

For RT netlink, calcit() function should return the minimal size for netlink dump message. This will make sure that dump message for every network device can be stored. Currently, rtnl_calcit() function doesn't account the size of header of netlink message, this patch will fix it. Signed-off-by:

[PATCH] mac80211: Remove unused 'rates_idx' variable

Commit f027c2aca0cf introduced 'rates_idx' in ieee80211_tx_status_noskb but did not use it. Compiling with W=1 gives the following warning, fix it. mac80211/status.c: In function ‘ieee80211_tx_status_noskb’: mac80211/status.c:636:6: warning: variable ‘rates_idx’ set but not used

[PATCH] mac80211: Remove unused 'struct ieee80211_rx_status' ptr

Commit 554891e63a29 introduced 'struct ieee80211_rx_status' in ieee80211_rx_h_defragment but did not use it. Compiling with W=1 gives the following warning, fix it. net/mac80211/rx.c: In function ‘ieee80211_rx_h_defragment’: net/mac80211/rx.c:1911:30: warning: variable ‘status’ set but not used

Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy eee-disable-advert option documentation

Le 21/11/2016 à 08:47, Andrew Lunn a écrit : >> What I did not realize when doing this patch for the realtek driver is >> that there is already 6 valid modes defined in the kernel >> >> #define MDIO_EEE_100TX MDIO_AN_EEE_ADV_100TX /* >> 100TX EEE cap */ >> #define MDIO_EEE_1000T

DEAR FRIEND.

Dear Friend, I am Mr.Daouda Ali the head of file department of Bank of Africa(B.O.A) here in Burkina Faso / Ouagadougou. In my department we discover an abandoned sum of (US$18 million US Dollars) in an account that belongs to one of our foreign customer who died along with his family in plane

Re: [PATCH net 1/1] net: l2tp: Treat NET_XMIT_CN as success in l2tp_eth_dev_xmit

On Sun, Nov 20, 2016 at 4:56 PM, wrote: > From: Gao Feng > > The tc could return NET_XMIT_CN as one congestion notification, but > it does not mean the packe is lost. Other modules like ipvlan, > macvlan, and others treat NET_XMIT_CN as success too. > So

Re: [PATCH net 1/1] net sched filters: pass netlink message flags in event notification

On Thu, Nov 17, 2016 at 1:02 PM, Cong Wang wrote: > On Wed, Nov 16, 2016 at 2:16 PM, Roman Mashak wrote: >> Userland client should be able to read an event, and reflect it back to >> the kernel, therefore it needs to extract complete set of netlink

[PATCH] bnxt_en: Fix a VXLAN vs GENEVE issue

Knowing that: #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_VXLAN(0x1UL << 0) #define TUNNEL_DST_PORT_FREE_REQ_TUNNEL_TYPE_GENEVE (0x5UL << 0) and that 'bnxt_hwrm_tunnel_dst_port_alloc()' is only called with one of these 2 constants, the

Re: [RFC PATCH net v2 1/3] net: phy: add an option to disable EEE advertisement

Hi Jerome, On 21 November 2016 at 21:05, Jerome Brunet wrote: > This patch adds an option to disable EEE advertisement in the generic PHY > by providing a mask of prohibited modes corresponding to the value found in > the MDIO_AN_EEE_ADV register. > > On some platforms, PHY

RE: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

I think there are newbie include me still use ifconfig utility. So when I check this code, it can be optimized. > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Cong Wang > Sent: Tuesday, November 22, 2016 12:20 PM > To: YUAN

Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

On Tue, Nov 15, 2016 at 7:57 PM, YUAN Linyu wrote: > No, this patch will not change dev->name, > It's care about ifa->ifa_label. >> - if (colon) >> - memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ); >> -

[PATCH] netdevice.h: fix kernel-doc warning

From: Randy Dunlap Fix kernel-doc warning in (missing ':'): ..//include/linux/netdevice.h:1904: warning: No description found for parameter 'prio_tc_map[TC_BITMASK + 1]' Signed-off-by: Randy Dunlap --- include/linux/netdevice.h |2 +- 1

[PATCH net 1/1] driver: macvlan: Check if need rollback multicast setting in macvlan_open

From: Gao Feng When dev_set_promiscuity failed in macvlan_open, it always invokes dev_set_allmulti without checking if necessary. Now check the IFF_ALLMULTI flag firstly before rollback the multicast setting in the error handler. Signed-off-by: Gao Feng ---

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

On Mon, Nov 21, 2016 at 04:31:18PM -0700, Jason Gunthorpe wrote: + ida_init(_vnic_ctrl_ida); + idr_init(_vnic_idr); + + rc = bus_register(_vnic_bus); >>> >>>Why on earth do we need this? Didn't I give you enough grief for the >>>psm stuff and now you want to

Re: [PATCH ethtool v3 2/2] Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift

On 11/17/2016 04:08 AM, Allan W. Nielsen wrote: > From: Raju Lakkaraju > > Add ethtool get and set tunable to access PHY drivers. > > Ethtool Help: ethtool -h for PHY tunables > ethtool --set-phy-tunable DEVNAME Set PHY tunable > [

Re: linux-next: build warnings after merge of the net-next tree

+Thomas, Gregory, On 11/21/2016 05:22 PM, Stephen Rothwell wrote: [snip] > > Introduced by commit > > a0627f776a45 ("net: marvell: Allow drivers to be built with COMPILE_TEST") > > "a few warnings" is a matter of perception. :-( Thomas, based on our IRC conversation, do you already have

linux-next: build warnings after merge of the net-next tree

Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_bm_construct': drivers/net/ethernet/marvell/mvneta_bm.c:103:16: warning: cast from pointer to integer of different size

Re: [PATCH ethtool v3 1/2] ethtool-copy.h:sync with net

On 11/17/2016 04:07 AM, Allan W. Nielsen wrote: > From: Raju Lakkaraju > > This covers kernel changes upto: > > commit f5a4732f85613b3fb43f8bc33a017e3db3b3605a > Author: Raju Lakkaraju > Date: Wed Nov 9 16:33:09 2016 +0530 > >

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c between commit: ba1ffd74df74 ("stmmac: fix PTP support for GMAC4") from the net tree and commit: 38ddc59d65b6 ("net: stmmac: replace all pr_xxx by their netdev_xxx

RE: [PATCH iproute2 2/2] tc/act_tunnel: Introduce ip tunnel action

Hi, Amir, Following are three minor comments: Seems that TCA_TUNNEL_KEY_PAD used anywhere: + TCA_TUNNEL_KEY_PAD, + __TCA_TUNNEL_KEY_MAX, +}; Should be "and destination IP 11.11.0.2" instead of "and destination IP 11.11.0.1": +Tunnel ID (for example VNI in VXLAN tunnel) .TP .B

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

On Mon, Nov 21, 2016 at 03:26:29PM -0800, Vishwanathapura, Niranjana wrote: > I did not see any example IB mad agent outside drivers/inifiniband > folder. You can be the first. > I did see some netdev drivers outside the net/ folder (like ipoib and > drivers/infiniband/hw/nes/). It is very

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

On Mon, Nov 21, 2016 at 02:39:30PM -0700, Jason Gunthorpe wrote: On Mon, Nov 21, 2016 at 01:30:17PM -0800, Vishwanathapura, Niranjana wrote: On Sat, Nov 19, 2016 at 12:04:45PM -0700, Jason Gunthorpe wrote: >On Fri, Nov 18, 2016 at 02:42:10PM -0800, Vishwanathapura, Niranjana wrote: >>+HFI-VNIC

Re: [net-next PATCH v2 1/5] net: virtio dynamically disable/enable LRO

On Sat, Nov 19, 2016 at 06:49:34PM -0800, John Fastabend wrote: > This adds support for dynamically setting the LRO feature flag. The > message to control guest features in the backend uses the > CTRL_GUEST_OFFLOADS msg type. > > Signed-off-by: John Fastabend > --- >

Re: [net-next PATCH v2 3/5] virtio_net: Add XDP support

On Sat, Nov 19, 2016 at 06:50:33PM -0800, John Fastabend wrote: > From: Shrijeet Mukherjee > > This adds XDP support to virtio_net. Some requirements must be > met for XDP to be enabled depending on the mode. First it will > only be supported with LRO disabled so that data is

Re: [net-next PATCH v2 4/5] virtio_net: add dedicated XDP transmit queues

On Sat, Nov 19, 2016 at 06:51:04PM -0800, John Fastabend wrote: > XDP requires using isolated transmit queues to avoid interference > with normal networking stack (BQL, NETDEV_TX_BUSY, etc). This patch > adds a XDP queue per cpu when a XDP program is loaded and does not > expose the queues to the

[PATCH 1/2] net: qcom/emac: move phy init code to separate files

The internal PHY of the EMAC differs on each SOC, and the list will only continue to grow. By separating the code into individual files, we can add support for more SOCs more cleanly. Note: The internal PHY is also sometimes called the SGMII device. We also stop referring to the various PHY

[PATCH 0/2] net: qcom/emac: simplify support for different SOCs

On SOCs that have the Qualcomm EMAC network controller, the internal PHY block is always different. Sometimes the differences are small, sometimes it might be a completely different IP. Either way, using version numbers to differentiate them and putting all of the init code in one file does not

[PATCH 2/2] net: qcom/emac: add support for the Qualcomm Technologies QDF2400

The QDF2432 and the QDF2400 have slightly different internal PHYs, so there are some programming differences. Some of the registers in the QDF2400 have moved, and some registers require different values during initialization. Because of the differences, the internal PHY on the QDF2400 has a new

Re: [PATCH net] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

Hi, On 21.11.2016 18:10, Erik Nordmark wrote: > On 11/16/16 10:49 PM, Hannes Frederic Sowa wrote: >> I thought about even removing the sysctl altogether and enable enhanced >> DAD by default. ;) >> >> I am in favor of enabling it by default. >> >> But given that there could be broken

[PATCHv2 net-next 00/11] Start adding support for mv88e6390

This is the first patchset implementing support for the mv88e6390 family. This is a new generation of switch devices and has numerous incompatible changes to the registers. These patches allow the switch to the detected during probe, and makes the statistics unit work. These patches are

[PATCHv2 net-next 01/11] net: dsa: mv88e6xxx: Take switch out of reset before probe

The switch needs to be taken out of reset before we can read its ID register on the MDIO bus. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 8 1 file changed, 4 insertions(+), 4

[PATCHv2 net-next 07/11] net: dsa: mv88e6xxx: Add mv88e6390 statistics unit init

The statistics unit on the mv88e6390 needs the histogram mode to be configured in a different register compared to other devices. Add an ops to do this. Signed-off-by: Andrew Lunn v2: Rename to mv88e6390_g1_stats_set_histogram Move into global1.c ---

[PATCHv2 net-next 08/11] net: dsa: mv88e6xxx: Add stats_get_sset_count|string to ops structure

Different families have different sets of statistics. Abstract this using a stats_get_sset_count and stats_get_strings op. Each stat has a bitmap, and the ops implementer uses a bit map mask to count the statistics which apply for the family, or return the list of strings. Signed-off-by: Andrew

[PATCHv2 net-next 09/11] net: dsa: mv88e6xxx: Add stats_get_stats to ops structure

Different families have different sets of statistics. Abstract this using a stats_get_stats op. The mv88e6390 needs a different implementation, which will be added later. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 83

[PATCHv2 net-next 10/11] net: dsa: mv88e6xxx: Implement mv88e6390 get_stats

The mv88e6390 uses a different bit to select between bank0 and bank1 of the statistics. So implement an ops function for this, and pass the selector bit to the generic stats read function. Also, the histogram selection has moved for the mv88e6390, so abstract its selection as well. Signed-off-by:

[PATCHv2 net-next 11/11] net: dsa: mv88e6xxx: Move g1 stats code in global1.[ch]

Move the stats functions which access global 1 registers into global1.c. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c| 54 +++-- drivers/net/dsa/mv88e6xxx/global1.c | 33 ++-

[PATCHv2 net-next 04/11] net: dsa: mv88e6xxx: Abstract stats_snapshot into ops structure

Taking a stats snapshot differs between same families. Abstract this into an ops member. At the same time, move the code into global1.[ch], since the registers are in the global1 range. Signed-off-by: Andrew Lunn --- v2: Move code into global1.c ---

[PATCHv2 net-next 05/11] net: dsa: mv88e6xxx: Add comment about family a device belongs to

Knowing the family of device belongs to helps with picking the ops implementation which is appropriate to the device. So add a comment to each structure of ops. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 24 1 file changed, 24

[PATCHv2 net-next 06/11] net: dsa: mv88e6xxx: Add mv88e6390 stats snapshot operation

The MV88E6390 has a control register for what the histogram statistics actually contain. This means the stat_snapshot method should not set this information. So implement the 6390 stats_snapshot function without these bits. Signed-off-by: Andrew Lunn --- v2: Move the snapshot

[PATCHv2 net-next 03/11] net: dsa: mv88e6xxx: Add the mv88e6390 family

With the devices added to the tables, the probe will recognize the switch. This however is not sufficient to make it work properly, other changes are needed because of incompatibilities. Signed-off-by: Andrew Lunn --- v2: Change the compatible to 'marvell,mv88e6190' Add _ops

[PATCHv2 net-next 02/11] net: dsa: mv88e6xxx: Fix unused variable warning by using variable

_mv88e6xxx_stats_wait() did not check the return value from mv88e6xxx_g1_read(), so the compiler complained about set but unused err. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 3 +++ 1

Re: [PATCH net-next] udp: avoid one cache line miss in recvmsg()

On Mon, 2016-11-21 at 14:01 -0800, Eric Dumazet wrote: > Tested-by: Paolo Abeni > > Thanks Paolo > > Note that udp6_recvmsg() hits the 3rd cache line of skb to access > skb->protocol : > > is_udp4 = (skb->protocol == htons(ETH_P_IP)); > > We might some trick to avoid this

Re: [PATCH net-next] udp: avoid one cache line miss in recvmsg()

On Mon, 2016-11-21 at 22:36 +0100, Paolo Abeni wrote: > Nice catch, thank you Eric! > > This gives up to 8% speed-up in my performance test (wire speed udp flood > with small packets) > > Tested-by: Paolo Abeni Thanks Paolo Note that udp6_recvmsg() hits the 3rd cache line

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

On Mon, Nov 21, 2016 at 01:30:17PM -0800, Vishwanathapura, Niranjana wrote: > On Sat, Nov 19, 2016 at 12:04:45PM -0700, Jason Gunthorpe wrote: > >On Fri, Nov 18, 2016 at 02:42:10PM -0800, Vishwanathapura, Niranjana wrote: > >>+HFI-VNIC DRIVER > >>+M: Dennis Dalessandro

Re: [PATCH net-next] udp: avoid one cache line miss in recvmsg()

On Fri, 2016-11-18 at 17:18 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > UDP_SKB_CB(skb)->partial_cov is located at offset 66 in skb, > requesting a cold cache line being read in cpu cache. > > We can avoid this cache line miss for UDP sockets, > as partial_cov has a

Re: [RFC 02/10] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) Bus driver

On Sat, Nov 19, 2016 at 12:04:45PM -0700, Jason Gunthorpe wrote: On Fri, Nov 18, 2016 at 02:42:10PM -0800, Vishwanathapura, Niranjana wrote: +HFI-VNIC DRIVER +M: Dennis Dalessandro +M: Niranjana Vishwanathapura +L:

[stable 4.4.y] ppp: defer netns reference release for ppp channel

Please apply the following patch to linux-stable 4.4.y: commit 205e1e255c479f3fd77446415706463b282f94e4 ppp: defer netns reference release for ppp channel This is already present in 4.8.y and fixes an issue with ppp channels that would otherwise cause a BUG() in ppp_pernet while a global ppp

Re: [PATCH] net: ieee802154: constify ieee802154_ops structures

From: Bhumika Goyal Date: Tue, 22 Nov 2016 02:00:14 +0530 > Declare the structure ieee802154_ops as const as it is only passed as an > argument to the function ieee802154_alloc_hw. This argument is of type > const struct ieee802154_ops *, so ieee80254_ops structures having

Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __E1000_DOWN

On 11/17/2016 6:31 AM, Neftin, Sasha wrote: On 11/13/2016 10:34 AM, Neftin, Sasha wrote: On 11/11/2016 12:35 AM, Baicar, Tyler wrote: Hello Sasha, On 11/9/2016 11:19 PM, Neftin, Sasha wrote: On 11/9/2016 11:41 PM, Tyler Baicar wrote: Move IRQ free code so that it will happen regardless of

Re: [PATCH] net: ieee802154: constify ieee802154_ops structures

Hello. On 21/11/16 21:30, Bhumika Goyal wrote: Declare the structure ieee802154_ops as const as it is only passed as an argument to the function ieee802154_alloc_hw. This argument is of type const struct ieee802154_ops *, so ieee80254_ops structures having this property can be declared as

Re: [PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

On Thu, Nov 17, 2016 at 7:59 AM, Jiri Benc wrote: > On Thu, 17 Nov 2016 10:17:01 +, David Laight wrote: >> Worse than arbitrary, it adds 4 bytes of pad on 64bit systems. > > It does not, this is not a struct. > right. After looking at the assembly code, it is clear that GCC

[PATCH] net: ieee802154: constify ieee802154_ops structures

Declare the structure ieee802154_ops as const as it is only passed as an argument to the function ieee802154_alloc_hw. This argument is of type const struct ieee802154_ops *, so ieee80254_ops structures having this property can be declared as const. Done using Coccinelle: @r1 disable

RE: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > Sent: Monday, November 21, 2016 5:14 PM > To: Salil Mehta > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun; > mehta.salil@gmail.com;

[RFC net-next 3/3] net: dsa: b53: Remove CPU port specific VLAN programming

Now that DSA calls into the switch driver to program the CPU port's VLAN attributes, we can get rid of the code that dealt with adding/removing the CPU port to a downstream facing port VLAN membership. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c |

[RFC net-next 1/3] net: bridge: Allow bridge master device to configure switch CPU port

An use case which is currently not possible with Linux bridges on top of network switches is to configure the CPU port of the switch (inherently presented to the user with a bridge master device) independently from its downstream ports, with a different set of VLAN properties. The reason as to why

[RFC net-next 2/3] net: dsa: Propagate VLAN add/del to CPU port(s)

Now that the bridge layer can call into switchdev to signal programming requests targeting the bridge master device itself, allow the switch drivers to implement separate programming of downstream and upstream/management ports. Signed-off-by: Vivien Didelot

[RFC net-next 0/3] net: bridge: Allow CPU port configuration

Hi all, This patch series allows using the bridge master interface to configure an Ethernet switch port's CPU/management port with different VLAN attributes than those of the bridge downstream ports/members. Jiri, Ido, Andrew, Vivien, please review the impact on mlxsw and mv88e6xxx, I tested

Re: [PATCH net-next v3 0/4] geneve: Use LWT more effectively.

From: Pravin B Shelar Date: Mon, 21 Nov 2016 11:02:57 -0800 > Following patch series make use of geneve LWT code path for > geneve netdev type of device. > This allows us to simplify geneve module without changing any > functionality. > > v2-v3: > Rebase against latest

[PATCH net-next v3 3/4] geneve: Remove redundant socket checks.

Geneve already has check for device socket in route lookup function. So no need to check it in xmit function. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/geneve.c

Re: [PATCH net-next v2 0/4] geneve: Use LWT more effectively.

On Mon, Nov 21, 2016 at 8:28 AM, David Miller wrote: > From: Pravin B Shelar > Date: Fri, 18 Nov 2016 18:10:07 -0800 > >> Following patch series make use of geneve LWT code path for >> geneve netdev type of device. >> This allows us to simplify geneve

[PATCH net-next v3 2/4] geneve: Merge ipv4 and ipv6 geneve_build_skb()

There are minimal difference in building Geneve header between ipv4 and ipv6 geneve tunnels. Following patch refactors code to unify it. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 100 ++- 1 file changed, 26

[PATCH net-next v3 1/4] geneve: Unify LWT and netdev handling.

Current geneve implementation has two separate cases to handle. 1. netdev xmit 2. LWT xmit. In case of netdev, geneve configuration is stored in various struct geneve_dev members. For example geneve_addr, ttl, tos, label, flags, dst_cache, etc. For LWT ip_tunnel_info is passed to the device in

[PATCH net-next v3 4/4] geneve: Optimize geneve device lookup.

Rather than comparing 64-bit tunnel-id, compare tunnel vni which is 24-bit id. This also save conversion from vni to tunnel id on each tunnel packet receive. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 17 + 1 file changed, 13 insertions(+), 4

[PATCH net-next v3 0/4] geneve: Use LWT more effectively.

Following patch series make use of geneve LWT code path for geneve netdev type of device. This allows us to simplify geneve module without changing any functionality. v2-v3: Rebase against latest net-next. v1-v2: Fix warning reported by kbuild test robot. Pravin B Shelar (4): geneve: Unify

[GIT] Networking

1) Clear congestion control state when changing algorithms on an existing socket, from Florian Westphal. 2) Fix register bit values in altr_tse_pcs portion of stmmac driver, from Jia Jie Ho. 3) Fix PTP handling in stammc driver for GMAC4, from Giuseppe CAVALLARO. 4) Fix udplite

Re: [PATCH] VSOCK: add loopback to virtio_transport

From: "Jorgen S. Hansen" Date: Mon, 21 Nov 2016 12:40:33 + > That should make it on par with the VMCI transport. Please do not top-post.

Re: [PATCH v2 next 0/2] tcp: make undo_cwnd mandatory for congestion modules

From: Florian Westphal Date: Mon, 21 Nov 2016 14:18:36 +0100 > highspeed, illinois, scalable, veno and yeah congestion control algorithms > don't provide a 'cwnd_undo' function. This makes the stack default to a > 'reno undo' which doubles cwnd. However, the ssthresh

Re: [PATCH net-next 0/2] bridge: add support for IGMPv3 and MLDv2 querier

From: Nikolay Aleksandrov Date: Mon, 21 Nov 2016 13:03:23 +0100 > This patch-set adds support for IGMPv3 and MLDv2 querier in the bridge. > Two new options which can be toggled via netlink and sysfs are added that > control the version per-bridge: >

Re: [PATCH net] tcp: zero ca_priv area when switching cc algorithms

From: Florian Westphal Date: Mon, 21 Nov 2016 10:08:37 +0100 > We need to zero out the private data area when application switches > connection to different algorithm (TCP_CONGESTION setsockopt). > > When congestion ops get assigned at connect time everything is already > zeroed

Re: [PATCH] VSOCK: add loopback to virtio_transport

Hi Stefan, That should make it on par with the VMCI transport. Thanks, Jørgen From: Stefan Hajnoczi Sent: Thursday, November 17, 2016 4:49 PM To: netdev@vger.kernel.org Cc: cav...@redhat.com; Claudio Imbrenda; Jorgen S. Hansen;

Re: [PATCH net 1/1] net: l2tp: Treat NET_XMIT_CN as success in l2tp_eth_dev_xmit

From: f...@ikuai8.com Date: Mon, 21 Nov 2016 08:56:21 +0800 > From: Gao Feng > > The tc could return NET_XMIT_CN as one congestion notification, but > it does not mean the packe is lost. Other modules like ipvlan, > macvlan, and others treat NET_XMIT_CN as success too. >

Re: Netperf UDP issue with connected sockets

On Mon, 2016-11-21 at 17:03 +0100, Jesper Dangaard Brouer wrote: > On Thu, 17 Nov 2016 10:51:23 -0800 > Eric Dumazet wrote: > > > On Thu, 2016-11-17 at 19:30 +0100, Jesper Dangaard Brouer wrote: > > > > > The point is I can see a socket Send-Q forming, thus we do know

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

On Mon, Nov 21, 2016 at 04:12:38PM +, Salil Mehta wrote: > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, November 16, 2016 8:36 AM > > To: Salil Mehta > > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun; > > mehta.salil@gmail.com;

Re: [PATCH net] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

On 11/16/16 10:49 PM, Hannes Frederic Sowa wrote: I thought about even removing the sysctl altogether and enable enhanced DAD by default. ;) I am in favor of enabling it by default. But given that there could be broken implementations out there, we should give users a choice and provide. OK,

Re: [PATCH net-next 1/1] driver: macvlan: Remove duplicated IFF_UP condition check in macvlan_forward_source

From: f...@ikuai8.com Date: Mon, 21 Nov 2016 08:26:38 +0800 > From: Gao Feng > > The function macvlan_forward_source_one has already checked the flag > IFF_UP, so needn't check it outside in macvlan_forward_source too. > > Signed-off-by: Gao Feng >

[PATCH] net: phy: micrel: fix KSZ8041FTL supported value

Fix setting of SUPPORTED_FIBRE bit as it was not present in features of KSZ8041. Signed-off-by: Kirill Esipov --- drivers/net/phy/micrel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index

Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy eee-disable-advert option documentation

> What I did not realize when doing this patch for the realtek driver is > that there is already 6 valid modes defined in the kernel > > #define MDIO_EEE_100TXMDIO_AN_EEE_ADV_100TX /* > 100TX EEE cap */ > #define MDIO_EEE_1000TMDIO_AN_EEE_ADV_1000T /* > 1000T

Re: [PATCH v2] ethernet: stmmac: make DWMAC_STM32 depend on it's associated SoC

From: Peter Robinson Date: Sun, 20 Nov 2016 17:22:38 + > There's not much point, except compile test, enabling the stmmac > platform drivers unless the STM32 SoC is enabled. It's not > useful without it. > > Signed-off-by: Peter Robinson

Re: [PATCH v2 net-next] mlx4: avoid unnecessary dirtying of critical fields

From: Eric Dumazet Date: Sun, 20 Nov 2016 09:24:36 -0800 > From: Eric Dumazet > > While stressing a 40Gbit mlx4 NIC with busy polling, I found false > sharing in mlx4 driver that can be easily avoided. > > This patch brings an additional 7 %

Re: [PATCH net-next v2 0/4] geneve: Use LWT more effectively.

From: Pravin B Shelar Date: Fri, 18 Nov 2016 18:10:07 -0800 > Following patch series make use of geneve LWT code path for > geneve netdev type of device. > This allows us to simplify geneve module. > > v1-v2: > Fix warning reported by kbuild test robot. This doesn't apply

Re: [PATCH net-next] udp: avoid one cache line miss in recvmsg()

From: Eric Dumazet Date: Fri, 18 Nov 2016 17:18:03 -0800 > From: Eric Dumazet > > UDP_SKB_CB(skb)->partial_cov is located at offset 66 in skb, > requesting a cold cache line being read in cpu cache. > > We can avoid this cache line miss for UDP

Re: [PATCH net-next] bnx2: use READ_ONCE() instead of barrier()

From: Eric Dumazet Date: Sat, 19 Nov 2016 14:57:11 -0800 > From: Eric Dumazet > > barrier() is a big hammer compared to READ_ONCE(), > and requires comments explaining what is protected. > > READ_ONCE() is more precise and compiler should generate

Re: [PATCH net-next v3 0/4] Couple of BPF refcount fixes for mlx5

From: Daniel Borkmann Date: Sat, 19 Nov 2016 01:44:59 +0100 > Various mlx5 bugs on eBPF refcount handling found during review. > Last patch in series adds a __must_check to BPF helpers to make > sure we won't run into it again w/o compiler complaining first. Series

Re: [PATCH net 07/18] net/ena: refactor ena_get_stats64 to be atomic context safe

Hi Netanel, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Netanel-Belgazal/Update-ENA-driver-to-version-1-1-2/20161120-165649 config: i386-randconfig-h1-11212236 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: #

Re: [mm PATCH v3 21/23] mm: Add support for releasing multiple instances of a page

On Fri, Nov 18, 2016 at 3:27 PM, Andrew Morton wrote: > On Thu, 10 Nov 2016 06:36:06 -0500 Alexander Duyck > wrote: > >> This patch adds a function that allows us to batch free a page that has >> multiple references outstanding.

Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy eee-disable-advert option documentation

On Mon, 2016-11-21 at 17:01 +0100, Andrew Lunn wrote: > On Mon, Nov 21, 2016 at 04:35:23PM +0100, Jerome Brunet wrote: > > > > Signed-off-by: Jerome Brunet > > --- > >  Documentation/devicetree/bindings/net/phy.txt | 5 + > >  1 file changed, 5 insertions(+) > > > >

RE: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

> -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Wednesday, November 16, 2016 8:36 AM > To: Salil Mehta > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun; > mehta.salil@gmail.com; linux-r...@vger.kernel.org; > netdev@vger.kernel.org;

Re: Synopsys Ethernet QoS Driver

On 21-11-2016 15:43, Lars Persson wrote: > > >> 21 nov. 2016 kl. 16:06 skrev Joao Pinto : >> >>> On 21-11-2016 14:25, Giuseppe CAVALLARO wrote: On 11/21/2016 2:28 PM, Lars Persson wrote: > 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO

Re: Netperf UDP issue with connected sockets

On Thu, 17 Nov 2016 10:51:23 -0800 Eric Dumazet wrote: > On Thu, 2016-11-17 at 19:30 +0100, Jesper Dangaard Brouer wrote: > > > The point is I can see a socket Send-Q forming, thus we do know the > > application have something to send. Thus, and possibility for > >

Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy eee-disable-advert option documentation

On Mon, Nov 21, 2016 at 04:35:23PM +0100, Jerome Brunet wrote: > Signed-off-by: Jerome Brunet > --- > Documentation/devicetree/bindings/net/phy.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/phy.txt >

Re: [net-next PATCH v2 4/5] virtio_net: add dedicated XDP transmit queues

On 16-11-21 03:45 AM, Daniel Borkmann wrote: > On 11/20/2016 03:51 AM, John Fastabend wrote: >> XDP requires using isolated transmit queues to avoid interference >> with normal networking stack (BQL, NETDEV_TX_BUSY, etc). This patch >> adds a XDP queue per cpu when a XDP program is loaded and does

  1   2   >