Re: commit : ppp: add rtnetlink device creation support - breaks netcf on my machine.

2016-12-05 Thread Brad Campbell
On 06/12/16 01:53, Guillaume Nault wrote: Probably not a mistake on your side. I've started looking at netcf' source code, but haven't found anything that could explain your issue. It'd really help if you could provide steps to reproduce the bug. Further to my message this morning, I started

[PATCHv2 net] team: team_port_add should check link_up before enable port

2016-12-05 Thread Xin Long
Now when users add a nic to team dev, the option 'enable' of the port is true by default, as team_port_enable enables it after dev_open in team_port_add. But even if the port_dev has no carrier, like it's cable was unpluged, the port is still enabled. It leads to that team dev couldn't work well i

[PATCH] net: return value of skb_linearize should be handled in Linux kernel

2016-12-05 Thread Zhouyi Zhou
kmalloc_reserve may fail to allocate memory inside skb_linearize, which means skb_linearize's return value should not be ignored. Following patch correct the uses of skb_linearize. Compiled in x86_64 Signed-off-by: Zhouyi Zhou --- drivers/infiniband/hw/nes/nes_nic.c | 5 +++-- drive

Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Gao Feng
Hi Eric, On Tue, Dec 6, 2016 at 2:53 PM, Eric Dumazet wrote: > On Tue, 2016-12-06 at 14:31 +0800, Gao Feng wrote: > >> Because I don't fully hold the ipvlan codes now, I am afraid of that >> there is someone which may get the port address when >> ipvlan_port_destroy. So the original ipvlan_port_d

Re: [PATCH net] team: team_port_add should check link_up before enable port

2016-12-05 Thread Xin Long
On Sat, Dec 3, 2016 at 10:57 PM, Marcelo Ricardo Leitner wrote: > On Sat, Dec 03, 2016 at 09:42:11PM +0800, Xin Long wrote: >> Now when users add a nic to team dev, the option 'enable' of the port >> is true by default, as team_port_enable enables it after dev_open in >> team_port_add. >> >> But e

Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Eric Dumazet
On Tue, 2016-12-06 at 14:31 +0800, Gao Feng wrote: > Because I don't fully hold the ipvlan codes now, I am afraid of that > there is someone which may get the port address when > ipvlan_port_destroy. So the original ipvlan_port_destroy uses the > kfree_rcu to avoid it. > > I am sure there is unne

Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Gao Feng
Hi Eric, On Tue, Dec 6, 2016 at 2:25 PM, Eric Dumazet wrote: > On Tue, 2016-12-06 at 12:29 +0800, f...@ikuai8.com wrote: >> From: Gao Feng >> >> There is no one which may reference the "port" in ipvlan_port_create >> when netdev_rx_handler_register failed. So it could free it directly >> with kf

[patch net v4] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
Commit 80cca775cdc4 ("net: fec: cache statistics while device is down") introduced unconditional statistics-related actions. However, when driver is compiled with CONFIG_M5272, staticsics-related definitions do not exist, which results into build errors. Fix that by adding explicit handling of !d

Re: [PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread Eric Dumazet
On Tue, 2016-12-06 at 12:29 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > There is no one which may reference the "port" in ipvlan_port_create > when netdev_rx_handler_register failed. So it could free it directly > with kfree instead of kfree_rcu. > > Signed-off-by: Gao Feng > --- > driv

Re: [PATCH net v2] ipv6: Allow IPv4-mapped address as next-hop

2016-12-05 Thread Erik Nordmark
On 12/5/16 11:52 AM, David Miller wrote: From: Erik Nordmark Date: Sat, 3 Dec 2016 20:57:09 -0800 Made kernel accept IPv6 routes with IPv4-mapped address as next-hop. It is possible to configure IP interfaces with IPv4-mapped addresses, and one can add IPv6 routes for IPv4-mapped destination

Re: [flamebait] xdp Was: Re: bpf bounded loops. Was: [flamebait] xdp

2016-12-05 Thread Alexei Starovoitov
On Mon, Dec 05, 2016 at 09:08:36PM -0800, Tom Herbert wrote: > On Mon, Dec 5, 2016 at 7:05 PM, Alexei Starovoitov > wrote: > > On Sun, Dec 04, 2016 at 05:05:28PM +0100, Hannes Frederic Sowa wrote: > >> > >> If one of those eBPF verifiers only accepts a certain number of INSN, as > >> fundamental a

[PATCH net] be2net: Add DEVSEC privilege to SET_HSW_CONFIG command.

2016-12-05 Thread Suresh Reddy
From: Venkat Duvvuru OPCODE_COMMON_GET_FN_PRIVILEGES is returning only DEVSEC privilege (Unrestricted Administrative Privilege) for Lancer NIC functions. So, driver is failing SET_HSW_CONFIG command, as DEVSEC privilege was not set in the privilege bitmap. This patch fixes the problem by setting

Re: [flamebait] xdp Was: Re: bpf bounded loops. Was: [flamebait] xdp

2016-12-05 Thread Tom Herbert
On Mon, Dec 5, 2016 at 7:05 PM, Alexei Starovoitov wrote: > On Sun, Dec 04, 2016 at 05:05:28PM +0100, Hannes Frederic Sowa wrote: >> >> If one of those eBPF verifiers only accepts a certain number of INSN, as >> fundamental as backwards jumps, we might end up with two compiler? > > two compilers?

[PATCH net-next 1/1] driver: ipvlan: Free the port memory directly with kfree instead of kfree_rcu

2016-12-05 Thread fgao
From: Gao Feng There is no one which may reference the "port" in ipvlan_port_create when netdev_rx_handler_register failed. So it could free it directly with kfree instead of kfree_rcu. Signed-off-by: Gao Feng --- drivers/net/ipvlan/ipvlan_main.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: "af_unix: conditionally use freezable blocking calls in read" is wrong

2016-12-05 Thread Cong Wang
On Sun, Dec 4, 2016 at 7:52 PM, Al Viro wrote: > On Sun, Dec 04, 2016 at 09:42:14PM -0500, David Miller wrote: >> > I've run into that converting AF_UNIX to generic_file_splice_read(); >> > I can kludge around that ("freezable unless ->msg_iter is ITER_PIPE"), but >> > that only delays trouble

Re: [flamebait] xdp Was: Re: bpf bounded loops. Was: [flamebait] xdp

2016-12-05 Thread Alexei Starovoitov
On Sun, Dec 04, 2016 at 05:05:28PM +0100, Hannes Frederic Sowa wrote: > > If one of those eBPF verifiers only accepts a certain number of INSN, as > fundamental as backwards jumps, we might end up with two compiler? two compilers? We already have five. There is gcc bpf backend (unmaintained) and n

Re: [PATCH] virtio-net: Fix DMA-from-the-stack in virtnet_set_mac_address()

2016-12-05 Thread Michael S. Tsirkin
On Mon, Dec 05, 2016 at 06:10:58PM -0800, Andy Lutomirski wrote: > With CONFIG_VMAP_STACK=y, virtnet_set_mac_address() can be passed a > pointer to the stack and it will OOPS. Copy the address to the heap > to prevent the crash. > > Cc: Michael S. Tsirkin > Cc: Jason Wang > Cc: Laura Abbott >

Re: [PATCH] virtio-net: Fix DMA-from-the-stack in virtnet_set_mac_address()

2016-12-05 Thread Jason Wang
On 2016年12月06日 10:10, Andy Lutomirski wrote: With CONFIG_VMAP_STACK=y, virtnet_set_mac_address() can be passed a pointer to the stack and it will OOPS. Copy the address to the heap to prevent the crash. Cc: Michael S. Tsirkin Cc: Jason Wang Cc: Laura Abbott Reported-by: zbys...@in.waw.pl S

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-12-05 Thread Serge E. Hallyn
On Mon, Dec 05, 2016 at 04:36:51PM -0800, Andy Lutomirski wrote: > On Mon, Dec 5, 2016 at 4:28 PM, John Stultz wrote: > > On Tue, Nov 22, 2016 at 4:57 PM, John Stultz wrote: > >> On Tue, Nov 8, 2016 at 4:12 PM, Andy Lutomirski > >> wrote: > >>> On Tue, Nov 8, 2016 at 4:03 PM, Alexei Starovoitov

Re: [PATCH next] Revert "dctcp: update cwnd on congestion event"

2016-12-05 Thread Neal Cardwell
On Mon, Dec 5, 2016 at 6:23 PM, Florian Westphal wrote: > Neal Cardwell says: > If I am reading the code correctly, then I would have two concerns: > 1) Has that been tested? That seems like an extremely dramatic > decrease in cwnd. For example, if the cwnd is 80, and there are 40 > ACKs

[PATCH] virtio-net: Fix DMA-from-the-stack in virtnet_set_mac_address()

2016-12-05 Thread Andy Lutomirski
With CONFIG_VMAP_STACK=y, virtnet_set_mac_address() can be passed a pointer to the stack and it will OOPS. Copy the address to the heap to prevent the crash. Cc: Michael S. Tsirkin Cc: Jason Wang Cc: Laura Abbott Reported-by: zbys...@in.waw.pl Signed-off-by: Andy Lutomirski --- Very lightly

[PATCH] net: ethernet: ti: cpsw: fix early budget split

2016-12-05 Thread Ivan Khoronzhuk
The budget split function requires the phy speed to be known. While ndo open a phy speed identification is postponed till the moment link is up. Hence, move it to appropriate callback, when link is up. Reported-by: Grygorii Strashko Fixes: 8feb0a196507 ("net: ethernet: ti: cpsw: split tx budget a

[PATCH] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links

2016-12-05 Thread Alexandru Gagniuc
Support for setting the RGMII_IDMODE bit was added in commit: "drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay" However, that commit did not add the symmetrical clearing of the bit by way of setting it in "mask". Add it here. Note that the documentation marks clearing thi

Re: commit : ppp: add rtnetlink device creation support - breaks netcf on my machine.

2016-12-05 Thread Brad Campbell
On 06/12/16 01:53, Guillaume Nault wrote: Can you send a minimal configuration file that triggers the bug? I've set up a virtual machine (Linux 4.7.0, netcf 0.2.8 backported from Debian Sid), but couldn't reproduce the issue so far. Ok I reproduced this in a VM. I used the stock Debian 7 inst

[PATCH iproute2 -net-next] bpf: add initial support for attaching xdp progs

2016-12-05 Thread Daniel Borkmann
Now that we made the BPF loader generic as a library, reuse it for loading XDP programs as well. This basically adds a minimal start of a facility for iproute2 to load XDP programs. There currently only exists the xdp1_user.c sample code in the kernel tree that sets up netlink directly and an iovis

[PATCH iproute2 -net-next] bpf: check for owner_prog_type and notify users when differ

2016-12-05 Thread Daniel Borkmann
Kernel commit 21116b7068b9 ("bpf: add owner_prog_type and accounted mem to array map's fdinfo") added support for telling the owner prog type in case of prog arrays. Give a notification to the user when they differ, and the program eventually fails to load. Signed-off-by: Daniel Borkmann Acked-by

Re: [net-next][PATCH 02/18] RDS: mark few internal functions static to make sparse build happy

2016-12-05 Thread Santosh Shilimkar
On 12/5/2016 1:45 AM, Sergei Shtylyov wrote: Hello! On 12/5/2016 9:57 AM, Santosh Shilimkar wrote: [...] -void rds_walk_conn_path_info(struct socket *sock, unsigned int len, +static void rds_walk_conn_path_info(struct socket *sock, unsigned int len, struct rds_info_iterator

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-05 Thread Ben Pfaff
On Mon, Dec 05, 2016 at 11:52:47PM +0100, Michał Mirosław wrote: > On Mon, Dec 05, 2016 at 10:55:45AM -0800, Ben Pfaff wrote: > > On Mon, Dec 05, 2016 at 06:24:36PM +0100, Michał Mirosław wrote: > > > On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > > > > On Sat, Dec 03, 2016 at 10:22:2

Re: [patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread David Miller
From: Nikita Yushchenko Date: Mon, 5 Dec 2016 20:41:01 +0300 > Commit 4dfb80d18d05 ("net: fec: cache statistics while device is down") > introduced unconditional statistics-related actions. I do not see this commit in any of my trees: [davem@localhost net-next]$ git describe 4dfb80d18d05 fatal

Re: [PATCH net-next 4/7] liquidio CN23XX: VF scatter gather lists

2016-12-05 Thread David Miller
From: Raghu Vatsavayi Date: Mon, 5 Dec 2016 01:15:15 -0800 > + kfree((void *)lio->glist); > + kfree((void *)lio->glist_lock); > +} ... > + if (!lio->glist) { > + kfree((void *)lio->glist_lock); > + return 1; > + } These void casts are unnecessary, please

Re: [v3 PATCH] netlink: Do not schedule work from sk_destruct

2016-12-05 Thread David Miller
From: Herbert Xu Date: Mon, 5 Dec 2016 15:28:21 +0800 > It is wrong to schedule a work from sk_destruct using the socket > as the memory reserve because the socket will be freed immediately > after the return from sk_destruct. > > Instead we should do the deferral prior to sk_free. > > This pat

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-12-05 Thread Andy Lutomirski
On Mon, Dec 5, 2016 at 4:28 PM, John Stultz wrote: > On Tue, Nov 22, 2016 at 4:57 PM, John Stultz wrote: >> On Tue, Nov 8, 2016 at 4:12 PM, Andy Lutomirski wrote: >>> On Tue, Nov 8, 2016 at 4:03 PM, Alexei Starovoitov >>> wrote: On Tue, Nov 08, 2016 at 03:51:40PM -0800, Andy Lutomirski wro

Re: [RESEND][PATCH v4] cgroup: Use CAP_SYS_RESOURCE to allow a process to migrate other tasks between cgroups

2016-12-05 Thread John Stultz
On Tue, Nov 22, 2016 at 4:57 PM, John Stultz wrote: > On Tue, Nov 8, 2016 at 4:12 PM, Andy Lutomirski wrote: >> On Tue, Nov 8, 2016 at 4:03 PM, Alexei Starovoitov >> wrote: >>> On Tue, Nov 08, 2016 at 03:51:40PM -0800, Andy Lutomirski wrote: I hate to say it, but I think I may see a pr

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Florian Westphal
Willem de Bruijn wrote: > While we're discussing the patch, another question, about revisions: I > tested both modified and original iptables binaries on both standard > and modified kernels. It all works as expected, except for the case > where both binaries are used on a single kernel. For insta

Oops with CONFIG_VMAP_STCK and bond device + virtio-net

2016-12-05 Thread Laura Abbott
Hi, Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1401612 In qemu with two virtio-net interfaces: $ ip l ... 5: ens14: mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ether 52:54:00:e9:64:41 brd ff:ff:ff:ff:ff:ff 6: ens15: mtu 1500 qdisc noop

Re: wl1251 & mac address & calibration data

2016-12-05 Thread Tony Lindgren
> > You could use kexec to pass the fixed DT. > > > > A. > > IIRC it was broken for N900/omap3, no idea if somebody fixed it. FYI, at least in next-20161205 kexec works on omap3 for me. Regards, Tony

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Willem de Bruijn
On Mon, Dec 5, 2016 at 6:29 PM, Willem de Bruijn wrote: > On Mon, Dec 5, 2016 at 6:22 PM, Pablo Neira Ayuso wrote: >> On Mon, Dec 05, 2016 at 06:06:05PM -0500, Willem de Bruijn wrote: >> [...] >>> Eric also suggests a private variable to avoid being subject to >>> changes to PATH_MAX. Then we can

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Willem de Bruijn
On Mon, Dec 5, 2016 at 6:22 PM, Pablo Neira Ayuso wrote: > On Mon, Dec 05, 2016 at 06:06:05PM -0500, Willem de Bruijn wrote: > [...] >> Eric also suggests a private variable to avoid being subject to >> changes to PATH_MAX. Then we can indeed also choose an arbitrary lower >> length than current P

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Pablo Neira Ayuso
On Mon, Dec 05, 2016 at 06:06:05PM -0500, Willem de Bruijn wrote: [...] > Eric also suggests a private variable to avoid being subject to > changes to PATH_MAX. Then we can indeed also choose an arbitrary lower > length than current PATH_MAX. Good. > FWIW, there is a workaround for users with dee

[PATCH next] Revert "dctcp: update cwnd on congestion event"

2016-12-05 Thread Florian Westphal
Neal Cardwell says: If I am reading the code correctly, then I would have two concerns: 1) Has that been tested? That seems like an extremely dramatic decrease in cwnd. For example, if the cwnd is 80, and there are 40 ACKs, and half the ACKs are ECE marked, then my back-of-the-envelope

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Lino Sanfilippo
> > You mean stmmac_xmit()? Thats also softirq AFAICT, its the TX softirq > > Regards, > Lino > > Hmm. netdevices.txt says: ndo_start_xmit: ... Context: Process with BHs disabled or BH (timer), will be called with interrupts disabled by netconsole.

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Willem de Bruijn
On Mon, Dec 5, 2016 at 6:00 PM, Pablo Neira Ayuso wrote: > On Mon, Dec 05, 2016 at 11:34:15PM +0100, Pablo Neira Ayuso wrote: >> On Mon, Dec 05, 2016 at 10:30:01PM +0100, Florian Westphal wrote: >> > Eric Dumazet wrote: >> > > On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: >> > > > Fr

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Pablo Neira Ayuso
On Mon, Dec 05, 2016 at 02:59:09PM -0800, Eric Dumazet wrote: > On Mon, 2016-12-05 at 23:40 +0100, Florian Westphal wrote: > > > Fair enough, I have no objections to the patch. > > An additional question is about PATH_MAX : > > Is it guaranteed to stay at 4096 forever ? > > To be safe, maybe we

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Willem de Bruijn
On Mon, Dec 5, 2016 at 5:55 PM, Daniel Borkmann wrote: > Hi Willem, > > On 12/05/2016 09:28 PM, Willem de Bruijn wrote: >> >> From: Willem de Bruijn >> >> Add support for attaching an eBPF object by file descriptor. >> >> The iptables binary can be called with a path to an elf object or a >> pinn

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Pablo Neira Ayuso
On Mon, Dec 05, 2016 at 11:34:15PM +0100, Pablo Neira Ayuso wrote: > On Mon, Dec 05, 2016 at 10:30:01PM +0100, Florian Westphal wrote: > > Eric Dumazet wrote: > > > On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: > > > > From: Willem de Bruijn > > > > > > > > Add support for attaching

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Eric Dumazet
On Mon, 2016-12-05 at 23:40 +0100, Florian Westphal wrote: > Fair enough, I have no objections to the patch. An additional question is about PATH_MAX : Is it guaranteed to stay at 4096 forever ? To be safe, maybe we should use a constant of our own.

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Daniel Borkmann
Hi Willem, On 12/05/2016 09:28 PM, Willem de Bruijn wrote: From: Willem de Bruijn Add support for attaching an eBPF object by file descriptor. The iptables binary can be called with a path to an elf object or a pinned bpf object. Also pass the mode and path to the kernel to be able to return

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Lino Sanfilippo
On 05.12.2016 23:40, Pavel Machek wrote: > On Mon 2016-12-05 23:37:09, Lino Sanfilippo wrote: >> Hi Pavel, >> >> On 05.12.2016 23:02, Pavel Machek wrote: >> > >> > we need spin_lock_bh at minimum, as we are locking user context >> > against timer. >> > >> > Best regards, >> >

Re: [ovs-dev] [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-05 Thread Michał Mirosław
On Mon, Dec 05, 2016 at 10:55:45AM -0800, Ben Pfaff wrote: > On Mon, Dec 05, 2016 at 06:24:36PM +0100, Michał Mirosław wrote: > > On Sat, Dec 03, 2016 at 03:27:30PM -0800, Ben Pfaff wrote: > > > On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote: > > > > This All-in-one patch removes a

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Mon, Dec 05, 2016 at 10:30:01PM +0100, Florian Westphal wrote: > > Eric Dumazet wrote: > > > On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: > > > > From: Willem de Bruijn > > > > > > > > Add support for attaching an eBPF object by file descriptor. > > >

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Pavel Machek
On Mon 2016-12-05 23:37:09, Lino Sanfilippo wrote: > Hi Pavel, > > On 05.12.2016 23:02, Pavel Machek wrote: > > > > we need spin_lock_bh at minimum, as we are locking user context > > against timer. > > > > Best regards, > > Pav

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Lino Sanfilippo
Hi Pavel, On 05.12.2016 23:02, Pavel Machek wrote: > > we need spin_lock_bh at minimum, as we are locking user context > against timer. > > Best regards, > Pavel > I was referring to stmmac_tx_clean() which AFAICS is only ca

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Pablo Neira Ayuso
On Mon, Dec 05, 2016 at 10:30:01PM +0100, Florian Westphal wrote: > Eric Dumazet wrote: > > On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: > > > From: Willem de Bruijn > > > > > > Add support for attaching an eBPF object by file descriptor. > > > > > > The iptables binary can be cal

[PATCH v3 net-next v3 2/4] net: dsa: mv88e6xxx: add helper to hardware reset

2016-12-05 Thread Vivien Didelot
Add an helper to toggle the eventual GPIO connected to the reset pin. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/driver

[PATCH v3 net-next v3 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Vivien Didelot
Some Marvell chips can enable/disable the PPU on demand. This is needed to access the PHY registers when there is no indirection mechanism. Add two new ppu_enable and ppu_disable ops to describe this and finally get rid of the MV88E6XXX_FLAG_PPU* flags. Signed-off-by: Vivien Didelot --- drivers

[PATCH v3 net-next v3 3/4] net: dsa: mv88e6xxx: add a soft reset operation

2016-12-05 Thread Vivien Didelot
Marvell chips have different way to issue a software reset. Old chips (such as 88E6060) have a reset bit in an ATU control register. Newer chips moved this bit in a Global control register. Chips with controllable PPU should reset the PPU when resetting the switch. Add a new reset operation to i

[PATCH v3 net-next v3 0/4] net: dsa: mv88e6xxx: rework reset and PPU code

2016-12-05 Thread Vivien Didelot
Old Marvell chips (like 88E6060) don't have a PHY Polling Unit (PPU). Next chips (like 88E6185) have a PPU, which has exclusive access to the PHY registers, thus must be disabled before access. Newer chips (like 88E6352) have an indirect mechanism to access the PHY registers whenever, thus loose

[PATCH v3 net-next v3 1/4] net: dsa: mv88e6xxx: add helper to disable ports

2016-12-05 Thread Vivien Didelot
Before resetting a switch, the ports should be set to the Disabled state and the transmit queues should be drained. Add an helper to explicit that. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 34 +++--- 1 file change

Re: [Intel-wired-lan] [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-05 Thread tndave
On 12/05/2016 01:54 PM, Alexander Duyck wrote: On Mon, Dec 5, 2016 at 9:07 AM, Tushar Dave wrote: Unlike previous generation NIC (e.g. ixgbe) i40e doesn't seem to have standard CSR where PCIe relaxed ordering can be set. Without PCIe relax ordering enabled, i40e performance is significantly l

Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Vivien Didelot
Stefan Eichenberger writes: > Hi Vivien, > > On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: >> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { >> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, >> .g1_set_egress_port = mv88e6095_g1_set_egress_por

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

2016-12-05 Thread Pavel Machek
Hi! > > > > Actually, I was wrong. irqlock protection is needed, since > > stmmac_tx_clean() is called from timer, and that's interrupt context, > > as you can confirm using BUG_ON(in_interrupt()); > > > > in_interrupt() can mean both softirq and hardirq context. In this case it > means softirq

[PATCH v4 net-next 2/2] MAINTAINERS: add entry for slicoss ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add myself as maintainer for the slicoss ethernet driver. Signed-off-by: Lino Sanfilippo --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6781a3f..bb9af28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,11 @@ T: git git://linuxtv.

[PATCH v4 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-12-05 Thread Lino Sanfilippo
Add driver for Alacritech gigabit ethernet cards with SLIC (session-layer interface control) technology. The driver provides basic support without SLIC for the following devices: - Mojave cards (single port PCI Gigabit) both copper and fiber - Oasis cards (single and dual port PCI-x Gigabit) coppe

Gigabit ethernet driver for Alacritechs SLIC devices (v4)

2016-12-05 Thread Lino Sanfilippo
Hi, this is the forth version of the slicoss gigabit ethernet driver (which is a rework of the driver from Alacritech which can currently be found under drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and Kalahari cards, for both copper and fiber. If this code is accepte

Kernel panic in netfilter 4.8.10 probably on conntrack -L

2016-12-05 Thread Denys Fedoryshchenko
Hi! I have quite loaded NAT server (approx 17Gbps of traffic) where periodic "conntrack -L" might trigger once per day kernel panic. I am not definitely sure it is triggered exactly at running tool, or just by enabling events. Here is panic message: [221287.380762] general protection fault:

Re: [Intel-wired-lan] [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-05 Thread Alexander Duyck
On Mon, Dec 5, 2016 at 9:07 AM, Tushar Dave wrote: > Unlike previous generation NIC (e.g. ixgbe) i40e doesn't seem to have > standard CSR where PCIe relaxed ordering can be set. Without PCIe relax > ordering enabled, i40e performance is significantly low on SPARC. > > This patch sets PCIe relax or

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Florian Westphal
Eric Dumazet wrote: > On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > Add support for attaching an eBPF object by file descriptor. > > > > The iptables binary can be called with a path to an elf object or a > > pinned bpf object. Also pass the mode

Re: [PATCH v2 net-next v2 3/4] net: dsa: mv88e6xxx: add a soft reset operation

2016-12-05 Thread Stefan Eichenberger
Hi Vivien On Mon, Dec 05, 2016 at 11:27:02AM -0500, Vivien Didelot wrote: > static const struct mv88e6xxx_ops mv88e6097_ops = { > @@ -3285,6 +3266,7 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { > .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, > .g1_set_egress_port = mv88e6095

Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Eric Dumazet
On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add support for attaching an eBPF object by file descriptor. > > The iptables binary can be called with a path to an elf object or a > pinned bpf object. Also pass the mode and path to the kernel to be > able

Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations

2016-12-05 Thread Stefan Eichenberger
Hi Vivien, On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: > @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { > .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, > .g1_set_egress_port = mv88e6095_g1_set_egress_port, > .mgmt_rsvd2cpu = mv88e609

Re: [PATCH 0/5] cpsw: add per channel shaper configuration

2016-12-05 Thread Ivan Khoronzhuk
On Mon, Dec 05, 2016 at 02:33:40PM -0600, Grygorii Strashko wrote: > Hi Ivan, > > On 11/29/2016 09:00 AM, Ivan Khoronzhuk wrote: > > This series is intended to allow user to set rate for per channel > > shapers at cpdma level. This patchset doesn't have impact on performance. > > The rate can be s

[PATCH net v4] tcp: warn on bogus MSS and try to amend it

2016-12-05 Thread Marcelo Ricardo Leitner
There have been some reports lately about TCP connection stalls caused by NIC drivers that aren't setting gso_size on aggregated packets on rx path. This causes TCP to assume that the MSS is actually the size of the aggregated packet, which is invalid. Although the proper fix is to be done at each

Re: [PATCH net] net: ep93xx_eth: Do not crash unloading module

2016-12-05 Thread David Miller
From: Florian Fainelli Date: Sun, 4 Dec 2016 19:22:05 -0800 > When we unload the ep93xx_eth, whether we have opened the network > interface or not, we will either hit a kernel paging request error, or a > simple NULL pointer de-reference because: > > - if ep93xx_open has been called, we have cr

Re: [PATCH] net: calxeda: xgmac: use new api ethtool_{get|set}_link_ksettings

2016-12-05 Thread David Miller
From: Philippe Reynes Date: Sun, 4 Dec 2016 23:37:53 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 0/5] cpsw: add per channel shaper configuration

2016-12-05 Thread Grygorii Strashko
Hi Ivan, On 11/29/2016 09:00 AM, Ivan Khoronzhuk wrote: > This series is intended to allow user to set rate for per channel > shapers at cpdma level. This patchset doesn't have impact on performance. > The rate can be set with: > > echo 100 > /sys/class/net/ethX/queues/tx-0/tx_maxrate > > Tested

Re: [PATCH net-next 0/3] Minor BPF cleanups and digest

2016-12-05 Thread David Miller
From: Daniel Borkmann Date: Sun, 4 Dec 2016 23:19:38 +0100 > First two patches are minor cleanups, and the third one adds > a prog digest. For details, please see individual patches. > After this one, I have a set with tracepoint support that makes > use of this facility as well. Series applied

Re: [PATCH net-next 0/3] net: ethoc: Misc improvements

2016-12-05 Thread David Miller
From: Florian Fainelli Date: Sun, 4 Dec 2016 12:40:27 -0800 > This patch series fixes/improves a few things: > > - implement a proper PHYLIB adjust_link callback to set the duplex mode > accordingly > - do not open code the fetching of a MAC address in OF/DT environments > - demote an error m

[PATCH nf-next] netfilter: xt_bpf: support ebpf

2016-12-05 Thread Willem de Bruijn
From: Willem de Bruijn Add support for attaching an eBPF object by file descriptor. The iptables binary can be called with a path to an elf object or a pinned bpf object. Also pass the mode and path to the kernel to be able to return it later for iptables dump and save. Signed-off-by: Willem de

Re: [PATCH v3 net-next] net_sched: gen_estimator: complete rewrite of rate estimators

2016-12-05 Thread David Miller
From: Eric Dumazet Date: Sun, 04 Dec 2016 09:48:16 -0800 > From: Eric Dumazet > > 1) Old code was hard to maintain, due to complex lock chains. >(We probably will be able to remove some kfree_rcu() in callers) > > 2) Using a single timer to update all estimators does not scale. > > 3) Cod

Re: [net PATCH 2/2] ipv4: Drop suffix update from resize code

2016-12-05 Thread Robert Shearman
On 05/12/16 17:28, David Miller wrote: From: Robert Shearman Date: Mon, 5 Dec 2016 15:05:18 + On 01/12/16 12:27, Alexander Duyck wrote: It has been reported that update_suffix can be expensive when it is called on a large node in which most of the suffix lengths are the same. The time re

Re: [PATCH V3 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-05 Thread kbuild test robot
Hi Salil, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Salil-Mehta/net-hns-Fix-to-conditionally-convey-RX-checksum-flag-to-stack/20161206-022948 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reprod

Re: [PATCH net 0/2] bnx2x: fixes series

2016-12-05 Thread David Miller
From: Yuval Mintz Date: Sun, 4 Dec 2016 15:30:16 +0200 > Two unrelated fixes for bnx2x - the first one is nice-to-have, > while the other fixes fatal behaviour in older adapters. > > Please consider applying them to `net'. Series applied, thanks.

[PATCH v4 05/13] net: ethernet: ti: cpts: fix registration order

2016-12-05 Thread Grygorii Strashko
The ptp clock registered before spinlock, which is protecting it, and before timecounter and cyclecounter initialization in cpts_register(). So, ensure that ptp clock is registered the last, after everything else is done. Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/n

Re: [PATCH net-next] net/sched: cls_flower: Set the filter Hardware device for all use-cases

2016-12-05 Thread David Miller
From: Hadar Hen Zion Date: Sun, 4 Dec 2016 15:25:19 +0200 > Check if the returned device from tcf_exts_get_dev function supports tc > offload and in case the rule can't be offloaded, set the filter hw_dev > parameter to the original device given by the user. > > The filter hw_device parameter s

[PATCH v4 02/13] net: ethernet: ti: allow cpts to be built separately

2016-12-05 Thread Grygorii Strashko
TI CPTS IP is used as part of TI OMAP CPSW driver, but it's also present as part of NETCP on TI Keystone 2 SoCs. So, It's required to enable build of CPTS for both this drivers and this can be achieved by allowing CPTS to be built separately. Hence, allow cpts to be built separately and convert it

Re: [PATCH net 1/6] net/mlx5: Verify module parameters

2016-12-05 Thread David Miller
From: Saeed Mahameed Date: Sun, 4 Dec 2016 12:56:11 +0200 > +static uint prof_sel = MLX5_DEFAULT_PROF; Please do not use type shorthands such as "uint", always expand fully "unsigned int". Thanks.

Re: [mm PATCH 0/3] Page fragment updates

2016-12-05 Thread Andrew Morton
On Mon, 5 Dec 2016 09:01:12 -0800 Alexander Duyck wrote: > On Tue, Nov 29, 2016 at 10:23 AM, Alexander Duyck > wrote: > > This patch series takes care of a few cleanups for the page fragments API. > > > > ... > > It's been about a week since I submitted this series. Just wanted to > check in

[PATCH v4 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-05 Thread Grygorii Strashko
It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v4: - fixed build error in patch "net: ethernet: ti: cpts: clean up event list if event pool is empty" - rebased on top of net-next Chang

[PATCH v4 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-12-05 Thread Grygorii Strashko
The cyclecounter mult and shift values can be calculated based on the CPTS rfclk frequency and timekeepnig framework provides required algos and API's. Hence, calc mult and shift basing on CPTS rfclk frequency if both cpts_clock_shift and cpts_clock_mult properties are not provided in DT (the basi

[PATCH v4 10/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-12-05 Thread Grygorii Strashko
Move DT properties parsing into CPTS driver to simplify CPSW code and CPTS driver porting on other SoC in the future (like Keystone 2) - with this change it will not be required to add the same DT parsing code in Keystone 2 NETCP driver. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/

[PATCH v4 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed()

2016-12-05 Thread Grygorii Strashko
Switch to readl/writel_relaxed() APIs, because this is recommended API and the CPTS IP is reused on Keystone 2 SoCs where LE/BE modes are supported. Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v4 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts

2016-12-05 Thread Grygorii Strashko
This will provide more flexibility in changing CPTS internals and also required for further changes. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 28 +++- drivers/net/ethernet/ti/cpts.h | 39 +++ 2 files changed

[PATCH v4 11/13] clocksource: export the clocks_calc_mult_shift to use by timestamp code

2016-12-05 Thread Grygorii Strashko
From: Murali Karicheri The CPSW CPTS driver is capable of doing timestamping on tx/rx packets and requires to know mult and shift factors for timestamp conversion from raw value to nanoseconds (ptp clock). Now these mult and shift factors are calculated manually and provided through DT, which mak

[PATCH v4 06/13] net: ethernet: ti: cpts: disable cpts when unregistered

2016-12-05 Thread Grygorii Strashko
The cpts now is left enabled after unregistration. Hence, disable it in cpts_unregister(). Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/

[PATCH v4 07/13] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-12-05 Thread Grygorii Strashko
From: WingMan Kwok When a CPTS user does not exit gracefully by disabling cpts timestamping and leaving a joined multicast group, the system continues to receive and timestamps the ptp packets which eventually occupy all the event list entries. When this happns, the added code tries to remove so

[PATCH v4 13/13] net: ethernet: ti: cpts: fix overflow check period

2016-12-05 Thread Grygorii Strashko
The CPTS drivers uses 8sec period for overflow checking with assumption that CPTS retclk will not exceed 500MHz. But that's not true on some TI platforms (Kesytone 2). As result, it is possible that CPTS counter will overflow more than once between two readings. Hence, fix it by selecting overflow

[PATCH v4 09/13] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-12-05 Thread Grygorii Strashko
The current implementation CPTS initialization and deinitialization (represented by cpts_register/unregister()) does too many static initialization from .ndo_open(), which is reasonable to do once at probe time instead, and also require caller to allocate memory for struct cpts, which is internal f

[PATCH v4 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister

2016-12-05 Thread Grygorii Strashko
There are two issues with TI CPTS code which are reproducible when TI CPSW ethX device passes few up/down iterations: - cpts refclk prepare counter continuously incremented after each up/down iteration; - devm_clk_get(dev, "cpts") is called many times. Hence, fix these issues by using clk_disable_

[PATCH v4 08/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs

2016-12-05 Thread Grygorii Strashko
CPTS module and IRQs are always enabled when CPTS is registered, before starting overflow check work, and disabled during deregistration, when overflow check work has been canceled already. So, It doesn't require to (re)enable CPTS module and IRQs in cpts_overflow_check(). Signed-off-by: Grygorii

Re: [PATCH 1/1] net: ethernet: qlogic: set error code on failure

2016-12-05 Thread David Miller
From: "Mintz, Yuval" Date: Sun, 4 Dec 2016 07:29:58 + >> From: Pan Bian >> >> When calling dma_mapping_error(), the value of return variable rc is 0. >> And when the call returns an unexpected value, rc is not set to a negative >> errno. Thus, it will return 0 on the error path, and its cal

  1   2   3   >