[PATCH] vhost: introduce O(1) vq metadata cache

2016-12-13 Thread Jason Wang
When device IOTLB is enabled, all address translations were stored in interval tree. O(lgN) searching time could be slow for virtqueue metadata (avail, used and descriptors) since they were accessed much often than other addresses. So this patch introduces an O(1) array which points to the

[Query] Delayed vxlan socket creation?

2016-12-13 Thread Du, Fan
Hi I'm interested to one Docker issue[1] which looks like related to kernel vxlan socket creation as described in the thread. From my limited knowledge here, socket creation is synchronous , and after the *socket* syscall, the sock handle will be valid and ready to linkup. Somehow I'm not

Re: [PATCH iproute2 -net-next] lwt: BPF support for LWT

2016-12-13 Thread Thomas Graf
On 13 December 2016 at 00:41, Stephen Hemminger wrote: > I went ahead and fixed these. Thanks for fixing it up Stephen.

[PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

2016-12-13 Thread Bartosz Folta
There are hardware PCI implementations of Cadence GEM network controller. This patch will allow to use such hardware with reuse of existing Platform Driver. Signed-off-by: Bartosz Folta --- Changed in v3: Fixed dependencies in Kconfig. --- Changed in v2: Respin to net-next.

Re: [RFC PATCH v3] audit: use proper refcount locking on audit_sock

2016-12-13 Thread Cong Wang
On Tue, Dec 13, 2016 at 8:00 PM, Richard Guy Briggs wrote: > On 2016-12-13 16:19, Cong Wang wrote: >> On Tue, Dec 13, 2016 at 7:03 AM, Richard Guy Briggs wrote: >> > @@ -1283,8 +1299,10 @@ static void __net_exit audit_net_exit(struct net >> > *net) >> > { >> >

Re: [PATCH v3 net-next 1/3] openvswitch: Add a missing break statement.

2016-12-13 Thread Pravin Shelar
On Tue, Nov 29, 2016 at 3:30 PM, Jarno Rajahalme wrote: > Add a break statement to prevent fall-through from > OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL. Without the break > actions setting ethernet addresses fail to validate with log messages > complaining about invalid tunnel

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-13 Thread Wei Xu
On 2016年12月14日 03:44, Theodore Ts'o wrote: Jason's patch fixed the issue, so I think we have the proper fix, but to answer your questions: On Wed, Dec 14, 2016 at 01:46:44AM +0800, Wei Xu wrote: Q1: Which distribution are you using for the GCE instance? The test appliance is based on Debian

Re: netlink: GPF in sock_sndtimeo

2016-12-13 Thread Richard Guy Briggs
On 2016-12-13 16:17, Cong Wang wrote: > On Tue, Dec 13, 2016 at 2:52 AM, Richard Guy Briggs wrote: > > It is actually the audit_pid and audit_nlk_portid that I care about > > more. The audit daemon could vanish or close the socket while the > > kernel sock to which it was

Re: stmmac driver...

2016-12-13 Thread Jie Deng
Hi Peppe, On 2016/12/12 22:17, Giuseppe CAVALLARO wrote: > Hi David > > On 12/7/2016 7:06 PM, David Miller wrote: >> >> Giuseppe and Alexandre, >> >> There are a lot of patches and discussions happening around the stammc >> driver lately and both of you are listed as the maintainers. >> >> I

[PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-13 Thread Jason A. Donenfeld
SipHash is a 64-bit keyed hash function that is actually a cryptographically secure PRF, like HMAC. Except SipHash is super fast, and is meant to be used as a hashtable keyed lookup function. SipHash isn't just some new trendy hash function. It's been around for a while, and there really isn't

[PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

2016-12-13 Thread Jason A. Donenfeld
This gives a clear speed and security improvement. Siphash is both faster and is more solid crypto than the aging MD5. Rather than manually filling MD5 buffers, we simply create a layout by a simple anonymous struct, for which gcc generates rather efficient code. Signed-off-by: Jason A.

Re: [RFC PATCH v3] audit: use proper refcount locking on audit_sock

2016-12-13 Thread Richard Guy Briggs
On 2016-12-13 16:19, Cong Wang wrote: > On Tue, Dec 13, 2016 at 7:03 AM, Richard Guy Briggs wrote: > > @@ -1283,8 +1299,10 @@ static void __net_exit audit_net_exit(struct net > > *net) > > { > > struct audit_net *aunet = net_generic(net, audit_net_id); > >

[PATCH v2 4/4] random: use siphash24 instead of md5 for get_random_int/long

2016-12-13 Thread Jason A. Donenfeld
This duplicates the current algorithm for get_random_int/long, but uses siphash24 instead. This comes with several benefits. It's certainly faster and more cryptographically secure than MD5. This patch also hashes the pid, entropy, and timestamp as fixed width fields, in order to increase

[PATCH v2 2/4] siphash: add convenience functions for jhash converts

2016-12-13 Thread Jason A. Donenfeld
Many jhash users currently rely on the Nwords functions. In order to make transitions to siphash fit something people already know about, we provide analog functions here. This also winds up being nice for the networking stack, where hashing 32-bit fields is common. Signed-off-by: Jason A.

[PATCH 4/3] random: use siphash24 instead of md5 for get_random_int/long

2016-12-13 Thread Jason A. Donenfeld
This duplicates the current algorithm for get_random_int/long, but uses siphash24 instead. This comes with several benefits. It's certainly faster and more cryptographically secure than MD5. This patch also hashes the pid, entropy, and timestamp as fixed width fields, in order to increase

Re: [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-13 Thread Alexei Starovoitov
On Tue, Dec 13, 2016 at 6:03 PM, Michał Mirosław wrote: > On Tue, Dec 13, 2016 at 05:21:18PM -0800, Stephen Hemminger wrote: >> On Sat, 3 Dec 2016 10:22:28 +0100 (CET) >> Michał Mirosław wrote: >> > This All-in-one patch removes abuse of VLAN

Re: [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-13 Thread Michał Mirosław
On Tue, Dec 13, 2016 at 05:21:18PM -0800, Stephen Hemminger wrote: > On Sat, 3 Dec 2016 10:22:28 +0100 (CET) > Michał Mirosław wrote: > > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > > intact through linux networking stack. > > > >

Re: [PATCH net-next 00/27] Remove VLAN CFI bit abuse

2016-12-13 Thread Michał Mirosław
On Tue, Dec 13, 2016 at 05:16:26PM -0800, Stephen Hemminger wrote: > On Tue, 13 Dec 2016 01:12:32 +0100 (CET) > Michał Mirosław wrote: > > This series removes an abuse of VLAN CFI bit in Linux networking stack. > > Currently Linux always clears the bit on outgoing traffic

Re: [PATCH net-next] net: remove abuse of VLAN DEI/CFI bit

2016-12-13 Thread Stephen Hemminger
On Sat, 3 Dec 2016 10:22:28 +0100 (CET) Michał Mirosław wrote: > This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed > intact through linux networking stack. > > Signed-off-by: Michał Mirosław > --- > > Dear

Re: [PATCH net-next 00/27] Remove VLAN CFI bit abuse

2016-12-13 Thread Stephen Hemminger
On Tue, 13 Dec 2016 01:12:32 +0100 (CET) Michał Mirosław wrote: > Dear NetDevs > > This series removes an abuse of VLAN CFI bit in Linux networking stack. > Currently Linux always clears the bit on outgoing traffic and presents > it cleared to userspace (even via

[PATCH 1/3] siphash: add cryptographically secure hashtable function

2016-12-13 Thread Jason A. Donenfeld
SipHash is a 64-bit keyed hash function that is actually a cryptographically secure PRF, like HMAC. Except SipHash is super fast, and is meant to be used as a hashtable keyed lookup function. SipHash isn't just some new trendy hash function. It's been around for a while, and there really isn't

Re: [PATCH net-next 13/27] bridge: use __vlan_hwaccel helpers

2016-12-13 Thread Toshiaki Makita
On 2016/12/14 0:11, Michał Mirosław wrote: > On Tue, Dec 13, 2016 at 03:59:46PM +0300, Sergei Shtylyov wrote: >> Hello! >> >> On 12/13/2016 3:12 AM, Michał Mirosław wrote: >> >>> This removes assumption than vlan_tci != 0 when tag is present. >>> >>> Signed-off-by: Michał Mirosław

Re: netlink: GPF in sock_sndtimeo

2016-12-13 Thread Cong Wang
On Tue, Dec 13, 2016 at 2:52 AM, Richard Guy Briggs wrote: > It is actually the audit_pid and audit_nlk_portid that I care about > more. The audit daemon could vanish or close the socket while the > kernel sock to which it was attached is still quite valid. Accessing > the set

[PATCH 2/3] siphash: add convenience functions for jhash converts

2016-12-13 Thread Jason A. Donenfeld
Many jhash users currently rely on the Nwords functions. In order to make transitions to siphash fit something people already know about, we provide analog functions here. This also winds up being nice for the networking stack, where hashing 32-bit fields is common. Signed-off-by: Jason A.

Re: [RFC PATCH v3] audit: use proper refcount locking on audit_sock

2016-12-13 Thread Cong Wang
On Tue, Dec 13, 2016 at 7:03 AM, Richard Guy Briggs wrote: > @@ -1283,8 +1299,10 @@ static void __net_exit audit_net_exit(struct net *net) > { > struct audit_net *aunet = net_generic(net, audit_net_id); > struct sock *sock = aunet->nlsk; > +

[PATCH 3/3] secure_seq: use fast siphash instead of slow md5

2016-12-13 Thread Jason A. Donenfeld
This gives a clear speed and security improvement. Rather than manually filling MD5 buffers, we simply create a layout by a simple anonymous struct, for which gcc generates rather efficient code. Signed-off-by: Jason A. Donenfeld --- net/core/secure_seq.c | 153

[PATCH net] ibmveth: calculate gso_segs for large packets

2016-12-13 Thread Thomas Falcon
Include calculations to compute the number of segments that comprise an aggregated large packet. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmveth.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] [v2] net: qcom/emac: don't try to claim clocks on ACPI systems

2016-12-13 Thread Florian Fainelli
On 12/13/2016 03:49 PM, Timur Tabi wrote: > On ACPI systems, clocks are not available to drivers directly. They are > handled exclusively by ACPI and/or firmware, so there is no clock driver. > Calls to clk_get() always fail, so we should not even attempt to claim > any clocks on ACPI systems.

[PATCH] [v2] net: qcom/emac: don't try to claim clocks on ACPI systems

2016-12-13 Thread Timur Tabi
On ACPI systems, clocks are not available to drivers directly. They are handled exclusively by ACPI and/or firmware, so there is no clock driver. Calls to clk_get() always fail, so we should not even attempt to claim any clocks on ACPI systems. Signed-off-by: Timur Tabi

Re: Soft lockup in inet_put_port on 4.6

2016-12-13 Thread Tom Herbert
On Tue, Dec 13, 2016 at 3:03 PM, Craig Gallek wrote: > On Tue, Dec 13, 2016 at 3:51 PM, Tom Herbert wrote: >> I think there may be some suspicious code in inet_csk_get_port. At >> tb_found there is: >> >> if (((tb->fastreuse > 0 &&

[PATCH iproute2] Fix compile warning in get_addr_1

2016-12-13 Thread David Ahern
A recent cleanup causes a compile warning on Debian jessie: CC utils.o utils.c: In function ‘get_addr_1’: utils.c:486:21: warning: passing argument 1 of ‘ll_addr_a2n’ from incompatible pointer type len = ll_addr_a2n(>data, sizeof(addr->data), name); ^ In file

Re: Soft lockup in inet_put_port on 4.6

2016-12-13 Thread Craig Gallek
On Tue, Dec 13, 2016 at 3:51 PM, Tom Herbert wrote: > I think there may be some suspicious code in inet_csk_get_port. At > tb_found there is: > > if (((tb->fastreuse > 0 && reuse) || > (tb->fastreuseport > 0 && >

Re: [PATCH] net: qcom/emac: don't try to claim clocks on ACPI systems

2016-12-13 Thread Timur Tabi
On 12/13/2016 04:02 PM, Florian Fainelli wrote: No strong feelings either, it just seems easier and safer to move the check down in the function and make it return success rather than potentially affecting the error path within the caller of emac_clks_phase{1,2}_init here. I suppose that makes

Re: [PATCH] net: qcom/emac: don't try to claim clocks on ACPI systems

2016-12-13 Thread Florian Fainelli
On 12/13/2016 01:54 PM, Timur Tabi wrote: > On 12/13/2016 03:46 PM, Florian Fainelli wrote: >> Is there a reason why the check is not moved down inwo >> emac_clks_phase{1,2}_init functions? Do you anticipate other >> ACPI-related changes in the future that would warrant having this check >> moved

Re: [PATCH] net: qcom/emac: don't try to claim clocks on ACPI systems

2016-12-13 Thread Timur Tabi
On 12/13/2016 03:46 PM, Florian Fainelli wrote: Is there a reason why the check is not moved down inwo emac_clks_phase{1,2}_init functions? Do you anticipate other ACPI-related changes in the future that would warrant having this check moved at a higher level? No, this is the last ACPI-related

Re: [PATCH] net: qcom/emac: don't try to claim clocks on ACPI systems

2016-12-13 Thread Florian Fainelli
On 12/13/2016 11:55 AM, Timur Tabi wrote: > On ACPI systems, clocks are not available to drivers directly. They are > handled exclusively by ACPI and/or firmware, so there is no clock driver. > Calls to clk_get() always fail, so we should not even attempt to claim > any clocks on ACPI systems. >

Re: sctp: suspicious rcu_dereference_check() usage in sctp_epaddr_lookup_transport

2016-12-13 Thread Marcelo Ricardo Leitner
On Tue, Dec 13, 2016 at 07:07:01PM +0100, Dmitry Vyukov wrote: > Hello, > > I am getting the following reports while running syzkaller fuzzer: > > [ INFO: suspicious RCU usage. ] > 4.9.0+ #85 Not tainted > --- > ./include/linux/rhashtable.h:572 suspicious

RE: [Intel-wired-lan] [PATCH net v2] igb: re-assign hw address pointer on reset after PCI error

2016-12-13 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Guilherme G. Piccoli > Sent: Thursday, November 10, 2016 10:47 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; gpicc...@linux.vnet.ibm.com > Subject: [Intel-wired-lan] [PATCH net v2]

Re: Soft lockup in inet_put_port on 4.6

2016-12-13 Thread Tom Herbert
I think there may be some suspicious code in inet_csk_get_port. At tb_found there is: if (((tb->fastreuse > 0 && reuse) || (tb->fastreuseport > 0 && !rcu_access_pointer(sk->sk_reuseport_cb) && sk->sk_reuseport &&

Re: [RFC PATCH v3] audit: use proper refcount locking on audit_sock

2016-12-13 Thread Paul Moore
On Tue, Dec 13, 2016 at 10:03 AM, Richard Guy Briggs wrote: > Resetting audit_sock appears to be racy. > > audit_sock was being copied and dereferenced without using a refcount on > the source sock. > > Bump the refcount on the underlying sock when we store a refrence in >

[PATCH iproute2 1/1] tc: pass correct conversion specifier to print 'unsigned int' action index.

2016-12-13 Thread Roman Mashak
Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/m_bpf.c | 2 +- tc/m_connmark.c | 2 +- tc/m_csum.c | 3 ++- tc/m_gact.c | 3 ++- tc/m_ife.c | 2 +- tc/m_ipt.c | 2 +- tc/m_mirred.c | 3 ++- tc/m_pedit.c| 2 +-

Re: bpf debug info

2016-12-13 Thread Daniel Borkmann
On 12/13/2016 08:38 PM, Alexei Starovoitov wrote: On Tue, Nov 29, 2016 at 9:01 AM, Alexei Starovoitov wrote: If I try to run samples/bpf/test_cls_bpf.sh the verifier will complain: R0=imm0,min_value=0,max_value=0 R1=pkt(id=0,off=0,r=42) R2=pkt_end 112: (0f) r4 +=

[PATCH] net: qcom/emac: don't try to claim clocks on ACPI systems

2016-12-13 Thread Timur Tabi
On ACPI systems, clocks are not available to drivers directly. They are handled exclusively by ACPI and/or firmware, so there is no clock driver. Calls to clk_get() always fail, so we should not even attempt to claim any clocks on ACPI systems. Signed-off-by: Timur Tabi

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-13 Thread John Fastabend
On 16-12-13 11:53 AM, David Miller wrote: > From: John Fastabend > Date: Tue, 13 Dec 2016 09:43:59 -0800 > >> What does "zero-copy send packet-pages to the application/socket that >> requested this" mean? At the moment on x86 page-flipping appears to be >> more

Re: [PATCH net-next] netlink: revert broken, broken "2-clause nla_ok()"

2016-12-13 Thread David Miller
From: Alexey Dobriyan Date: Tue, 13 Dec 2016 22:30:15 +0300 > Commit 4f7df337fe79bba1e4c2d525525d63b5ba186bbd > "netlink: 2-clause nla_ok()" is BROKEN. > > First clause tests if "->nla_len" could even be accessed at all, > it can not possibly be omitted. > > Signed-off-by:

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-13 Thread David Miller
From: John Fastabend Date: Tue, 13 Dec 2016 09:43:59 -0800 > What does "zero-copy send packet-pages to the application/socket that > requested this" mean? At the moment on x86 page-flipping appears to be > more expensive than memcpy (I can post some data shortly) and

Re: bpf debug info

2016-12-13 Thread Alexei Starovoitov
On Tue, Nov 29, 2016 at 9:01 AM, Alexei Starovoitov wrote: >> >If I try to run samples/bpf/test_cls_bpf.sh the verifier will complain: >> >R0=imm0,min_value=0,max_value=0 R1=pkt(id=0,off=0,r=42) R2=pkt_end >> >112: (0f) r4 += r3 >> >113: (0f) r1 += r4 >> >114: (b7)

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-13 Thread Theodore Ts'o
Jason's patch fixed the issue, so I think we have the proper fix, but to answer your questions: On Wed, Dec 14, 2016 at 01:46:44AM +0800, Wei Xu wrote: > > Q1: > Which distribution are you using for the GCE instance? The test appliance is based on Debian Jessie. > Q2: > Are you running xfs

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-13 Thread Hannes Frederic Sowa
On 13.12.2016 17:10, Jesper Dangaard Brouer wrote: >> What is bad about RDMA is that it is a separate kernel subsystem. >> What I would like to see is a deeper integration with the network >> stack so that memory regions can be registred with a network socket >> and work requests then can be

Re: [iproute2 v3 net-next 0/8] Add support for vrf helper

2016-12-13 Thread Stephen Hemminger
On Sun, 11 Dec 2016 16:53:07 -0800 David Ahern wrote: > This series adds support to iproute2 to run a command against a specific > VRF. The user semantics are similar to 'ip netns'. > > The 'ip vrf' subcommand supports 3 usages: > > 1. Run a command against a given

Re: [PATCH iproute2 1/2] tc/cls_flower: Add dest UDP port to tunnel params

2016-12-13 Thread Stephen Hemminger
On Tue, 13 Dec 2016 10:07:46 +0200 Hadar Hen Zion wrote: > Enhance IP tunnel parameters by adding destination UDP port. > > Signed-off-by: Hadar Hen Zion > Reviewed-by: Roi Dayan Both applied, thanks.

Re: [PATCH iproute2 V2 1/2] tc: flower: Fix typo and style in flower man page

2016-12-13 Thread Stephen Hemminger
On Tue, 13 Dec 2016 14:39:01 +0200 Roi Dayan wrote: > Replace vlan_eth_type with vlan_ethtype. > > Fixes: 745d91726006 ("tc: flower: Introduce vlan support") > Signed-off-by: Roi Dayan > Reviewed-by: Hadar Hen Zion Both applied,

sctp: suspicious rcu_dereference_check() usage in sctp_epaddr_lookup_transport

2016-12-13 Thread Dmitry Vyukov
Hello, I am getting the following reports while running syzkaller fuzzer: [ INFO: suspicious RCU usage. ] 4.9.0+ #85 Not tainted --- ./include/linux/rhashtable.h:572 suspicious rcu_dereference_check() usage! other info that might help us debug this:

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-13 Thread John Fastabend
On 16-12-13 08:10 AM, Jesper Dangaard Brouer wrote: > > On Mon, 12 Dec 2016 12:06:59 -0600 (CST) Christoph Lameter > wrote: >> On Mon, 12 Dec 2016, Jesper Dangaard Brouer wrote: >> >>> Hmmm. If you can rely on hardware setup to give you steering and >>> dedicated access to the

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-13 Thread Wei Xu
On 2016年12月13日 07:33, Theodore Ts'o wrote: Hi, I was doing a last minute regression test of the ext4 tree before sending a pull request to Linus, which I do using gce-xfstests[1], and I found that using networking was broken on GCE on linux-next. I was using next-20161209, and after bisecting

Re: [PATCH iproute2 -net-next] lwt: BPF support for LWT

2016-12-13 Thread Stephen Hemminger
On Mon, 12 Dec 2016 01:14:35 +0100 Daniel Borkmann wrote: > + > +static int lwt_parse_bpf(struct rtattr *rta, size_t len, int *argcp, char > ***argvp, > + int attr, const enum bpf_prog_type bpf_type) Please break long lines like this. > + > + /*

RE: [PATCH net-next 07/27] gianfar: remove use of VLAN_TAG_PRESENT

2016-12-13 Thread Claudiu Manoil
>-Original Message- >From: Michał Mirosław [mailto:mirq-li...@rere.qmqm.pl] >Sent: Tuesday, December 13, 2016 2:13 AM >To: netdev@vger.kernel.org >Cc: Claudiu Manoil >Subject: [PATCH net-next 07/27] gianfar: remove use of VLAN_TAG_PRESENT > >Signed-off-by:

Re: [PATCH] kcm: fix spelling mistake in Kconfig, "connectons"

2016-12-13 Thread Colin Ian King
On 13/12/16 17:30, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake "connectons" to "connections" in > Kconfig text. > > Signed-off-by: Colin Ian King > --- > net/kcm/Kconfig | 2 +- > 1 file changed, 1

[PATCH] kcm: fix spelling mistake in Kconfig, "connectons"

2016-12-13 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake "connectons" to "connections" in Kconfig text. Signed-off-by: Colin Ian King --- net/kcm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/kcm/Kconfig

[PATCH net-next] netlink: revert broken, broken "2-clause nla_ok()"

2016-12-13 Thread Alexey Dobriyan
Commit 4f7df337fe79bba1e4c2d525525d63b5ba186bbd "netlink: 2-clause nla_ok()" is BROKEN. First clause tests if "->nla_len" could even be accessed at all, it can not possibly be omitted. Signed-off-by: Alexey Dobriyan --- include/net/netlink.h |3 ++- 1 file changed, 2

Re: [PATCH] net: mvpp2: fix dma unmapping of TX buffers for fragments

2016-12-13 Thread Marcin Wojtas
Hi Thomas, Reviewed-by: Marcin Wojtas Best regards, Marcin 2016-12-13 17:53 GMT+01:00 Thomas Petazzoni : > Since commit 71ce391dfb784 ("net: mvpp2: enable proper per-CPU TX > buffers unmapping"), we are not correctly DMA unmapping TX

[PATCH] net: mvpp2: fix dma unmapping of TX buffers for fragments

2016-12-13 Thread Thomas Petazzoni
Since commit 71ce391dfb784 ("net: mvpp2: enable proper per-CPU TX buffers unmapping"), we are not correctly DMA unmapping TX buffers for fragments. Indeed, the mvpp2_txq_inc_put() function only stores in the txq_cpu->tx_buffs[] array the physical address of the buffer to be DMA-unmapped when skb

Re: [PATCH] ARM: add cmpxchg64 helper for ARMv7-M

2016-12-13 Thread Russell King - ARM Linux
On Sat, Dec 10, 2016 at 01:32:34PM +0100, Pablo Neira Ayuso wrote: > Hi Arnd, > > On Sat, Dec 10, 2016 at 11:36:34AM +0100, Arnd Bergmann wrote: > > A change to the netfilter code in net-next introduced the first caller of > > cmpxchg64 that can get built on ARMv7-M, leading to an error from the

Re: [PATCH V2 18/22] bnxt_re: Support for DCB

2016-12-13 Thread Jason Gunthorpe
On Tue, Dec 13, 2016 at 11:55:55AM +0530, Selvin Xavier wrote: > v1 eth_type is not defined. All vendor drivers have their own definition. Send a cleanup patch? Jason

Re: double free issue, mvpp2 driver, armada375 modules

2016-12-13 Thread Thomas Petazzoni
Hello, On Mon, 2 May 2016 11:46:46 +0200, Raphael G wrote: > enclosed the kernel panic we obtain after boot with a slightly patched > upstream kernel (4.5.2). > > (as well as the patchset applied to the upstream kernel, so that you can > know which code we are talking about. Too bad we cannot

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-13 Thread Christoph Lameter
On Tue, 13 Dec 2016, Jesper Dangaard Brouer wrote: > This is the early demux problem. With the push-mode of registering > memory, you need hardware steering support, for zero-copy support, as > the software step happens after DMA engine have written into the memory. Right. But we could fall

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-13 Thread Niklas Söderlund
Hi Geert, Thanks for feedback and testing! On 2016-12-13 14:03:52 +0100, Geert Uytterhoeven wrote: > CC linux-pm I think you forgot to CC linux-pm :-) > > On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund > wrote: > > Add generic functionality to

Re: Designing a safe RX-zero-copy Memory Model for Networking

2016-12-13 Thread Jesper Dangaard Brouer
On Mon, 12 Dec 2016 12:06:59 -0600 (CST) Christoph Lameter wrote: > On Mon, 12 Dec 2016, Jesper Dangaard Brouer wrote: > > > Hmmm. If you can rely on hardware setup to give you steering and > > dedicated access to the RX rings. In those cases, I guess, the "push" > > model

Re: [PATCH net v3] ibmveth: set correct gso_size and gso_type

2016-12-13 Thread Thomas Falcon
On 12/10/2016 02:56 PM, David Miller wrote: > From: Thomas Falcon > Date: Sat, 10 Dec 2016 12:39:48 -0600 > >> v3: include a check for non-zero mss when calculating gso_segs >> >> v2: calculate gso_segs after Eric Dumazet's comments on the earlier patch >> and

Re: [PATCH net] virtio-net: correctly enable multiqueue

2016-12-13 Thread David Miller
From: Jason Wang Date: Tue, 13 Dec 2016 14:23:05 +0800 > Commit 4490001029012539937ff02778fe6180613fa949 ("virtio-net: enable > multiqueue by default") blindly set the affinity instead of queues > during probe which can cause a mismatch of #queues between guest and > host.

[PATCH/replace net-next 17/27] OVS: remove use of VLAN_TAG_PRESENT

2016-12-13 Thread Michał Mirosław
This is a minimal change to allow removing of VLAN_TAG_PRESENT. It leaves OVS unable to use CFI bit, as fixing this would need a deeper surgery involving userspace interface. Signed-off-by: Michał Mirosław --- net/openvswitch/actions.c | 13 +

Re: [PATCH v2 2/2] net: rfkill: Add rfkill-any LED trigger

2016-12-13 Thread Johannes Berg
On Thu, 2016-12-08 at 08:30 +0100, Michał Kępień wrote: > Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill- > any, > which may be useful on laptops with a single "radio LED" and multiple > radio transmitters.  The trigger is meant to turn a LED on whenever > there is at least

Re: [PATCH v2 1/2] net: rfkill: Cleanup error handling in rfkill_init()

2016-12-13 Thread Johannes Berg
On Thu, 2016-12-08 at 08:30 +0100, Michał Kępień wrote: > Use a separate label per error condition in rfkill_init() to make it > a bit cleaner and easier to extend. applied. johannes

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

2016-12-13 Thread Andrew Lunn
> Another interesting thing is that fdb dump operation is slow > too. The more entries you have the slower it gets. We have > implemented caching with timing there as well (I have not submitted > such patch yet), which makes fdb dump much more pleasant in user > space, the operation happens

Re: [PATCH net-next 17/27] OVS: remove assumptions about VLAN_TAG_PRESENT bit

2016-12-13 Thread Michał Mirosław
On Tue, Dec 13, 2016 at 11:40:10AM +0100, Jiri Benc wrote: > On Tue, 13 Dec 2016 01:12:38 +0100 (CET), Michał Mirosław wrote: > > @@ -850,20 +848,11 @@ static int validate_vlan_from_nlattrs(const struct > > sw_flow_match *match, > > return -EINVAL; > > } > > > > - if

Re: [PATCH net-next 13/27] bridge: use __vlan_hwaccel helpers

2016-12-13 Thread Michał Mirosław
On Tue, Dec 13, 2016 at 03:59:46PM +0300, Sergei Shtylyov wrote: > Hello! > > On 12/13/2016 3:12 AM, Michał Mirosław wrote: > > > This removes assumption than vlan_tci != 0 when tag is present. > > > > Signed-off-by: Michał Mirosław > > --- > >

[RFC PATCH v3] audit: use proper refcount locking on audit_sock

2016-12-13 Thread Richard Guy Briggs
Resetting audit_sock appears to be racy. audit_sock was being copied and dereferenced without using a refcount on the source sock. Bump the refcount on the underlying sock when we store a refrence in audit_sock and release it when we reset audit_sock. audit_sock modification needs the

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

2016-12-13 Thread Richard Guy Briggs
On 2016-12-13 00:10, Richard Guy Briggs wrote: > On 2016-12-12 15:18, Paul Moore wrote: > > On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > > > Resetting audit_sock appears to be racy. > > > > > > audit_sock was being copied and dereferenced without using a refcount

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

2016-12-13 Thread Richard Guy Briggs
On 2016-12-12 15:58, Cong Wang wrote: > On Mon, Dec 12, 2016 at 2:03 AM, Richard Guy Briggs wrote: > > Resetting audit_sock appears to be racy. > > > > audit_sock was being copied and dereferenced without using a refcount on > > the source sock. > > > > Bump the refcount on the

Re: mlx5: net_device.addr_list_lock usage before initialization

2016-12-13 Thread Saeed Mahameed
On Tue, Dec 13, 2016 at 3:22 PM, Sebastian Ott wrote: > Hi, > > I ran into the following lockdep complaint: > > [7.059561] INFO: trying to register non-static key. > [7.059566] the code is fine but needs lockdep annotation. > [7.059570] turning off the

RE: [PATCH 3/3] netns: fix net_generic() "id - 1" bloat

2016-12-13 Thread David Laight
From: Alexey Dobriyan > Sent: 13 December 2016 14:23 ... > Well, the point of the patch is to save .text, so might as well save > as much as possible. Any form other than "ptr[id]" is going > to be either bigger or bigger and slower and "ptr" should be the first field. You've not read and

ATENCIÓN;

2016-12-13 Thread Administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

[v1] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

2016-12-13 Thread Arvind Yadav
Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. This error check will avoid NULL pointer dereference. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 6 ++ 1 file changed, 6

Re: Soft lockup in tc_classify

2016-12-13 Thread Shahar Klein
On 12/12/2016 9:07 PM, Cong Wang wrote: On Mon, Dec 12, 2016 at 8:04 AM, Shahar Klein wrote: On 12/12/2016 3:28 PM, Daniel Borkmann wrote: Hi Shahar, On 12/12/2016 10:43 AM, Shahar Klein wrote: Hi All, sorry for the spam, the first time was sent with html part

Re: [PATCH 3/3] netns: fix net_generic() "id - 1" bloat

2016-12-13 Thread Alexey Dobriyan
On Wed, Dec 7, 2016 at 1:49 PM, David Laight wrote: > From: Alexey Dobriyan >> Sent: 05 December 2016 14:48 >> On Mon, Dec 5, 2016 at 3:49 PM, David Laight wrote: >> > From: Alexey Dobriyan >> >> Sent: 02 December 2016 01:22 >> >> net_generic()

Re: [PATCH net] virtio-net: correctly enable multiqueue

2016-12-13 Thread Michael S. Tsirkin
On Tue, Dec 13, 2016 at 02:23:05PM +0800, Jason Wang wrote: > Commit 4490001029012539937ff02778fe6180613fa949 ("virtio-net: enable > multiqueue by default") blindly set the affinity instead of queues > during probe which can cause a mismatch of #queues between guest and > host. This patch fixes it

mlx5: net_device.addr_list_lock usage before initialization

2016-12-13 Thread Sebastian Ott
Hi, I ran into the following lockdep complaint: [7.059561] INFO: trying to register non-static key. [7.059566] the code is fine but needs lockdep annotation. [7.059570] turning off the locking correctness validator. [7.059579] CPU: 6 PID: 6 Comm: kworker/u32:0 Not tainted

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

2016-12-13 Thread Geert Uytterhoeven
CC linux-pm On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund wrote: > Add generic functionality to support Wake-on-Lan using MagicPacket which > are supported by at least a few versions of sh_eth. Only add > functionality for WoL, no specific sh_eth

Re: [PATCH net-next 13/27] bridge: use __vlan_hwaccel helpers

2016-12-13 Thread Sergei Shtylyov
Hello! On 12/13/2016 3:12 AM, Michał Mirosław wrote: This removes assumption than vlan_tci != 0 when tag is present. Signed-off-by: Michał Mirosław --- net/bridge/br_netfilter_hooks.c | 14 -- net/bridge/br_private.h | 2 +- net/bridge/br_vlan.c

Re: Synopsys Ethernet QoS

2016-12-13 Thread Joao Pinto
Às 12:50 PM de 12/13/2016, Lars Persson escreveu: > >> 13 dec. 2016 kl. 13:31 skrev Niklas Cassel : >> >> >> >>> On 12/13/2016 12:49 PM, Joao Pinto wrote: >>> Hi Niklas, >>> >>> Às 4:25 PM de 12/12/2016, Niklas Cassel escreveu: > On 12/12/2016 11:19 AM, Joao Pinto

Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices

2016-12-13 Thread Geert Uytterhoeven
On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund wrote: > Tested on Gen2 r8a7791/Koelsch. > > Signed-off-by: Niklas Söderlund Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCHv2 3/5] sh_eth: enable wake-on-lan for r8a7740/armadillo

2016-12-13 Thread Geert Uytterhoeven
On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund wrote: > Geert Uytterhoeven reported WoL worked on his Armadillo board. > > Signed-off-by: Niklas Söderlund Tested-by: Geert Uytterhoeven

Re: Synopsys Ethernet QoS

2016-12-13 Thread Lars Persson
> 13 dec. 2016 kl. 13:31 skrev Niklas Cassel : > > > >> On 12/13/2016 12:49 PM, Joao Pinto wrote: >> Hi Niklas, >> >> Às 4:25 PM de 12/12/2016, Niklas Cassel escreveu: >>> On 12/12/2016 11:19 AM, Joao Pinto wrote: Hi, Às 1:44 AM de 12/10/2016,

[PATCH iproute2 V2 1/2] tc: flower: Fix typo and style in flower man page

2016-12-13 Thread Roi Dayan
Replace vlan_eth_type with vlan_ethtype. Fixes: 745d91726006 ("tc: flower: Introduce vlan support") Signed-off-by: Roi Dayan Reviewed-by: Hadar Hen Zion --- man/man8/tc-flower.8 | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH iproute2 V2 2/2] tc: tunnel_key: Add tc-tunnel_key man page to Makefile

2016-12-13 Thread Roi Dayan
To be installed with the other man pages. Fixes: d57639a475a9 ("tc/act_tunnel: Introduce ip tunnel action") Signed-off-by: Roi Dayan Reviewed-by: Amir Vadai --- man/man8/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/man/man8/Makefile

[PATCH iproute2 V2 0/2] Man pages fixes

2016-12-13 Thread Roi Dayan
Hi, The 2 patches are man page related only. First fixes a typo and second adding missing man page to the Makefile. Thanks, Roi v2: - style fix in flower man page Roi Dayan (2): tc: flower: Fix typo and style in flower man page tc: tunnel_key: Add tc-tunnel_key man page to Makefile

Re: Synopsys Ethernet QoS

2016-12-13 Thread Niklas Cassel
On 12/13/2016 12:49 PM, Joao Pinto wrote: > Hi Niklas, > > Às 4:25 PM de 12/12/2016, Niklas Cassel escreveu: >> >> On 12/12/2016 11:19 AM, Joao Pinto wrote: >>> Hi, >>> >>> Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: Le 12/09/16 à 16:16, Andy Shevchenko a écrit : > On Sat, Dec

Re: Synopsys Ethernet QoS

2016-12-13 Thread Joao Pinto
Hi Niklas, Às 4:25 PM de 12/12/2016, Niklas Cassel escreveu: > > > On 12/12/2016 11:19 AM, Joao Pinto wrote: >> Hi, >> >> Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: >>> Le 12/09/16 à 16:16, Andy Shevchenko a écrit : On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli

Re: [PATCHv2 4/5] sh_eth: enable wake-on-lan for sh7743

2016-12-13 Thread Geert Uytterhoeven
On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund wrote: > This is based on public datasheet for sh7743 which shows it have the sh7734 (also in the one-line summary) it has > same behavior and registers for WoL as other versions of sh_eth.

Re: netlink: GPF in sock_sndtimeo

2016-12-13 Thread Richard Guy Briggs
On 2016-12-12 16:10, Cong Wang wrote: > On Mon, Dec 12, 2016 at 2:02 AM, Richard Guy Briggs wrote: > > On 2016-12-09 20:13, Cong Wang wrote: > >> Netlink notifier can safely be converted to blocking one, I will send > >> a patch. > > > > I had a quick look at how that might

  1   2   >