RE: [PATCH] qed: fix memory leak of a qed_spq_entry on error failure paths

> From: Colin Ian King > > A qed_spq_entry entry is allocated by qed_sp_init_request but is not kfree'd > if an error occurs, causing a memory leak. Fix this by kfree'ing it and also > setting *pp_ent to NULL to be safe. > > Found with static analysis by CoverityScan,

Re: [PATCH net] ipvlan: fix crash

From: Mahesh Bandewar Date: Sat, 17 Dec 2016 18:16:19 -0800 > diff --git a/drivers/net/ipvlan/ipvlan_core.c > b/drivers/net/ipvlan/ipvlan_core.c > index b4e990743e1d..4294fc1f5564 100644 > --- a/drivers/net/ipvlan/ipvlan_core.c > +++ b/drivers/net/ipvlan/ipvlan_core.c > @@

[GIT] Networking

1) Revert bogus nla_ok() change, from Alexey Dobriyan. 2) Various bpf validator fixes from Daniel Borkmann. 3) Add some necessary SET_NETDEV_DEV() calls to hsis_femac and hip04 drivers, from Dongpo Li. 4) Several ethtool ksettings conversions from Philippe Reynes. 5) Fix bugs in inet port

Re: [PATCH] net: mv643xx_eth: fix build failure

From: Sudip Mukherjee Date: Sat, 17 Dec 2016 00:45:05 + > The build of sparc allmodconfig fails with the error: > "of_irq_to_resource" [drivers/net/ethernet/marvell/mv643xx_eth.ko] > undefined! > > of_irq_to_resource() is defined when CONFIG_OF_IRQ is

Re: [PATCH] isdn: Constify some function parameters

From: Kees Cook Date: Fri, 16 Dec 2016 13:40:47 -0800 > From: Emese Revfy > > The coming initify gcc plugin expects const pointer types, and caught > some __printf arguments that weren't const yet. This fixes those. > > Signed-off-by: Emese Revfy

Re: [patch net] mlxsw: spectrum: Mark split ports as such

From: Jiri Pirko Date: Fri, 16 Dec 2016 19:29:03 +0100 > From: Ido Schimmel > > When a port is split we should mark it as such, as otherwise the split > ports aren't renamed correctly (e.g. sw1p3 -> sw1p3s1) and the unsplit > operation fails: > > $

Re: [PATCH] cgroup: Fix CGROUP_BPF config

From: Andy Lutomirski Date: Fri, 16 Dec 2016 08:33:45 -0800 > CGROUP_BPF depended on SOCK_CGROUP_DATA which can't be manually > enabled, making it rather challenging to turn CGROUP_BPF on. > > Signed-off-by: Andy Lutomirski Applied, thanks.

Re: pull-request: mac80211 2016-12-16

From: Johannes Berg Date: Fri, 16 Dec 2016 13:39:56 +0100 > Since you seem to be updating net, I thought I'd send you a few fixes. > These aren't really all that important though, so if you want to let > them wait for a bit I can live with that. > > Please pull and

Re: [PATCH net] qed: fix old-style function definition

From: Arnd Bergmann Date: Fri, 16 Dec 2016 09:47:41 +0100 > The newly added file causes a harmless warning, with "make W=1": > > drivers/net/ethernet/qlogic/qed/qed_iscsi.c: In function 'qed_get_iscsi_ops': > drivers/net/ethernet/qlogic/qed/qed_iscsi.c:1268:29: warning: old-style

Re: [PATCH] net: ipv6: check route protocol when deleting routes

From: Mantas Mikulėnas Date: Fri, 16 Dec 2016 10:30:59 +0200 > The protocol field is checked when deleting IPv4 routes, but ignored for > IPv6, which causes problems with routing daemons accidentally deleting > externally set routes (observed by multiple bird6 users). > >

Re: [PATCH v3 net] r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected

From: Manuel Bessler Date: Thu, 15 Dec 2016 22:55:00 -0500 > 'ifconfig eth0 down' makes r6040_close() trigger: > INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected > > Fixed by moving calls to phy_stop(), napi_disable(), netif_stop_queue() > to outside of the

Re: [patch net-next] irda: w83977af_ir: cleanup an indent issue

From: Dan Carpenter Date: Mon, 12 Dec 2016 14:21:34 +0300 > In commit 99d8d2159d7c ("irda: w83977af_ir: Neaten logging"), we > accidentally added an extra tab to these lines. > > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Thu, 15 Dec 2016 00:12:53 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: chelsio: cxgb3: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 12 Dec 2016 00:27:49 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: chelsio: cxgb2: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 11 Dec 2016 22:47:50 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: cirrus: ep93xx: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 12 Dec 2016 23:28:33 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: davicom: dm9000: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Wed, 14 Dec 2016 10:01:58 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH net v2 0/3] Couple of BPF fixes

From: Daniel Borkmann Date: Sun, 18 Dec 2016 01:52:56 +0100 > This set contains three BPF fixes for net, one that addresses the > complaint from Geert wrt static allocations, and the other is a fix > wrt mem accounting that I found recently during testing and there's >

[PATCH net] ipvlan: fix crash

From: Mahesh Bandewar [ cut here ] kernel BUG at include/linux/skbuff.h:1737! Call Trace: [] dev_forward_skb+0x92/0xd0 [] ipvlan_process_multicast+0x395/0x4c0 [ipvlan] [] ? ipvlan_process_multicast+0xd7/0x4c0 [ipvlan] [] ?

[PATCH net v2 0/3] Couple of BPF fixes

This set contains three BPF fixes for net, one that addresses the complaint from Geert wrt static allocations, and the other is a fix wrt mem accounting that I found recently during testing and there's still one more fix on the map value marking. Thanks! v1 -> v2: - Patch 1 as is. - Fixed

[PATCH net v2 2/3] bpf: fix overflow in prog accounting

Commit aaac3ba95e4c ("bpf: charge user for creation of BPF maps and programs") made a wrong assumption of charging against prog->pages. Unlike map->pages, prog->pages are still subject to change when we need to expand the program through bpf_prog_realloc(). This can for example happen during

[PATCH net v2 3/3] bpf: fix mark_reg_unknown_value for spilled regs on map value marking

Martin reported a verifier issue that hit the BUG_ON() for his test case in the mark_reg_unknown_value() function: [ 202.861380] kernel BUG at kernel/bpf/verifier.c:467! [...] [ 203.291109] Call Trace: [ 203.296501] [] mark_map_reg+0x45/0x50 [ 203.308225] []

[PATCH net v2 1/3] bpf: dynamically allocate digest scratch buffer

Geert rightfully complained that 7bd509e311f4 ("bpf: add prog_digest and expose it via fdinfo/netlink") added a too large allocation of variable 'raw' from bss section, and should instead be done dynamically: # ./scripts/bloat-o-meter kernel/bpf/core.o.1 kernel/bpf/core.o.2 add/remove: 3/0

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

Pavel Machek : [...] > Won't this up/down the interface, in a way userspace can observe? It won't up/down the interface as it doesn't exactly mimic what the network code does (there's more than rtnl_lock). For the same reason it's broken if it races with the transmit path: it can

Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function

On Thu, 15 Dec 2016, Jason A. Donenfeld wrote: > > I'd still drop the "24" unless you really think we're going to have > > multiple variants coming into the kernel. > > Okay. I don't have a problem with this, unless anybody has some reason > to the contrary. What if the 2/4-round version falls

[PATCH] net: wireless: marvell: libertas: constify cfg80211_ops structures

cfg80211_ops structures are only passed as an argument to the function wiphy_new. This argument is of type const, so cfg80211_ops strutures having this property can be declared as const. Done using Coccinelle @r1 disable optional_qualifier @ identifier i; position p; @@ static struct cfg80211_ops

[PATCH] net: wireless: ath: wil6210: constify cfg80211_ops structures

cfg80211_ops structures are only passed as an argument to the function wiphy_new. This argument is of type const, so cfg80211_ops strutures having this property can be declared as const. Done using Coccinelle @r1 disable optional_qualifier @ identifier i; position p; @@ static struct cfg80211_ops

Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices

On 12/14/2016 04:37 PM, Sergei Shtylyov wrote: Tested on Gen2 r8a7791/Koelsch. Signed-off-by: Niklas Söderlund --- drivers/net/ethernet/renesas/sh_eth.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

Hello! On 12/12/2016 07:09 PM, Niklas Söderlund wrote: Not the complete review yet, just some superficial comments. Add generic functionality to support Wake-on-Lan using MagicPacket which LAN. are supported by at least a few versions of sh_eth. Only add functionality for WoL, no

Re: [PATCH] net: use designated initializers

On Sat, Dec 17, 2016 at 8:57 AM, David Miller wrote: > From: Kees Cook > Date: Fri, 16 Dec 2016 16:58:58 -0800 > >> Prepare to mark sensitive kernel structures for randomization by making >> sure they're using designated initializers. These were

Re: [TSN RFC v2 0/9] TSN driver for the kernel

On Sat, Dec 17, 2016 at 10:05:54AM +0100, Henrik Austad wrote: > I'm sending out a new set now because, what I have works _fairly_ well for > testing and a way to see what you can do with AVB. Using spotify to play > music on random machines is quite entertaining. You have missed the point

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

On Sat, Dec 17, 2016 at 11:26 AM, Mickaël Salaün wrote: > > On 17/12/2016 19:18, Andy Lutomirski wrote: >> Hi all- >> >> I apologize for being rather late with this. I didn't realize that >> cgroup-bpf was going to be submitted for Linux 4.10, and I didn't see >> it on the

probably serious conntrack/netfilter panic, 4.8.14, timers and intel turbo

Hi, I posted recently several netfilter related crashes, didn't got any answers, one of them started to happen quite often on loaded NAT (17Gbps), so after trying endless ways to make it stable, i found out that in backtrace i can often see timers, and this bug probably appearing on older

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

On 17/12/2016 19:18, Andy Lutomirski wrote: > Hi all- > > I apologize for being rather late with this. I didn't realize that > cgroup-bpf was going to be submitted for Linux 4.10, and I didn't see > it on the linux-api list, so I missed the discussion. > > I think that the inet ingress, egress

[PATCH] rtlwifi: rtl8192ee: New firmware from Realtek

From: Troy Tan Recent testing by Realtek found bugs in both the driver and firmware for the RTL8192EE chips. Signed-off-by: Troy Tan Signed-off-by: Larry Finger --- WHENCE | 5 -

[PATCH net-next v4 2/2] net: stmmac: dwmac-meson8b: make the RGMII TX delay configurable

Prior to this patch we were using a hardcoded RGMII TX clock delay of 2ns (= 1/4 cycle of the 125MHz RGMII TX clock). This value works for many boards, but unfortunately not for all (due to the way the actual circuit is designed, sometimes because the TX delay is enabled in the PHY, etc.). Making

[PATCH net-next v4 1/2] net: dt-bindings: add RGMII TX delay configuration to meson8b-dwmac

This allows configuring the RGMII TX clock delay. The RGMII clock is generated by underlying hardware of the the Meson 8b / GXBB DWMAC glue. The configuration depends on the actual hardware (no delay may be needed due to the design of the actual circuit, the PHY might add this delay, etc.).

[PATCH net-next v4 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle (= 2ns) TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but there are some others where TX traffic is simply broken. There are probably multiple reasons why it's

Potential issues (security and otherwise) with the current cgroup-bpf API

Hi all- I apologize for being rather late with this. I didn't realize that cgroup-bpf was going to be submitted for Linux 4.10, and I didn't see it on the linux-api list, so I missed the discussion. I think that the inet ingress, egress etc filters are a neat feature, but I think the API has

Re: Synopsys Ethernet QoS

Hi! > >> So if there is a long time before handling interrupts, > >> I guess that it makes sense that one stream could > >> get an advantage in the net scheduler. > >> > >> If I find the time, and if no one beats me to it, I will try to replace > >> the normal timers with HR timers + a smaller

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

On Thu 2016-12-15 23:33:22, Lino Sanfilippo wrote: > On 15.12.2016 22:32, Lino Sanfilippo wrote: > > > Ah ok. Then maybe priv->hw->dma->stop_tx() does not do the job correctly > > (stop the > > tx path properly) and the HW is still active on the tx path while the tx > > buffers are > > freed.

Re: [PATCH 0/2] GTP tunneling fixes for net

From: Pablo Neira Ayuso Date: Thu, 15 Dec 2016 22:35:51 +0100 > The following patchset contains two GTP tunneling fixes for your net > tree, they are: > > 1) Offset to IPv4 header in gtp_check_src_ms_ipv4() is incorrect, thus >this function always succeeds and therefore

Re: [PATCH] WAN: use designated initializers

From: Kees Cook Date: Fri, 16 Dec 2016 16:59:18 -0800 > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer

Re: [PATCH] bna: use designated initializers

From: Kees Cook Date: Fri, 16 Dec 2016 17:00:54 -0800 > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer

Re: [PATCH] isdn/gigaset: use designated initializers

From: Kees Cook Date: Fri, 16 Dec 2016 16:58:06 -0800 > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer

Re: [PATCH] net/x25: use designated initializers

From: Kees Cook Date: Fri, 16 Dec 2016 17:03:39 -0800 > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer

Re: [PATCH] net: use designated initializers

From: Kees Cook Date: Fri, 16 Dec 2016 16:58:58 -0800 > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer

Re: [PATCH] isdn: use designated initializers

From: Kees Cook Date: Fri, 16 Dec 2016 17:01:42 -0800 > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer

Re: [PATCH] ATM: use designated initializers

From: Kees Cook Date: Fri, 16 Dec 2016 16:58:43 -0800 > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer

Re: [net-next PATCH v6 0/5] XDP for virtio_net

From: "Michael S. Tsirkin" Date: Fri, 16 Dec 2016 22:48:14 +0200 > On Fri, Dec 16, 2016 at 01:20:02PM -0500, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Fri, 16 Dec 2016 01:17:44 +0200 >> >> > OK, I think we can queue this for -next. >> > >> >

Re: ipv6: handle -EFAULT from skb_copy_bits

On Sat, Dec 17, 2016 at 10:41:20AM -0500, David Miller wrote: > From: Dave Jones > Date: Wed, 14 Dec 2016 10:47:29 -0500 > > > It seems to be possible to craft a packet for sendmsg that triggers > > the -EFAULT path in skb_copy_bits resulting in a BUG_ON that looks

Re: [PATCH] net: mvpp2: fix dma unmapping of TX buffers for fragments

From: Thomas Petazzoni Date: Sat, 17 Dec 2016 16:26:58 +0100 > Yes, I was thinking of moving towards a single array, as it's indeed > crazy to have three arrays for that. However, since it's a fix going > into stable, I also wanted to keep it as

Re: [PATCH net] sctp: sctp_transport_lookup_process should rcu_read_unlock when transport is null

From: Xin Long Date: Thu, 15 Dec 2016 23:05:52 +0800 > Prior to this patch, sctp_transport_lookup_process didn't rcu_read_unlock > when it failed to find a transport by sctp_addrs_lookup_transport. > > This patch is to fix it by moving up rcu_read_unlock right before

Re: [PATCH net] sctp: sctp_epaddr_lookup_transport should be protected by rcu_read_lock

From: Xin Long Date: Thu, 15 Dec 2016 23:00:55 +0800 > Since commit 7fda702f9315 ("sctp: use new rhlist interface on sctp transport > rhashtable"), sctp has changed to use rhlist_lookup to look up transport, but > rhlist_lookup doesn't call rcu_read_lock inside, unlike >

Re: [PATCH net 0/3] dpaa_eth: a couple of fixes

From: Madalin Bucur Date: Thu, 15 Dec 2016 15:13:03 +0200 > This patch set introduces big endian accessors in the dpaa_eth driver > making sure accesses to the QBMan HW are correct on little endian > platforms. Removing a redundant Kconfig dependency on FSL_SOC. > Adding

Re: [PATCH 2/5] irda: irnet: Move linux/miscdevice.h include

From: Corentin Labbe Date: Thu, 15 Dec 2016 11:42:47 +0100 > The only use of miscdevice is irda_ppp so no need to include > linux/miscdevice.h for all irda files. > This patch move the linux/miscdevice.h include to irnet_ppp.h > > Signed-off-by: Corentin Labbe

Re: [PATCH 3/5] irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h

From: Corentin Labbe Date: Thu, 15 Dec 2016 11:42:48 +0100 > This patch move the define for IRNET_MINOR to include/linux/miscdevice.h > It is better that all minor number definitions are in the same place. > > Signed-off-by: Corentin Labbe

Re: [PATCH 1/5] irda: irproc.c: Remove unneeded linux/miscdevice.h include

From: Corentin Labbe Date: Thu, 15 Dec 2016 11:42:46 +0100 > irproc.c does not use any miscdevice so this patch remove this > unnecessary inclusion. > > Signed-off-by: Corentin Labbe Applied.

Re: [PATCH 4/5] irda: irnet: Remove unused IRNET_MAJOR define

From: Corentin Labbe Date: Thu, 15 Dec 2016 11:42:49 +0100 > The IRNET_MAJOR define is not used, so this patch remove it. > > Signed-off-by: Corentin Labbe Applied.

Re: [PATCH 5/5] irda: irnet: add member name to the miscdevice declaration

From: Corentin Labbe Date: Thu, 15 Dec 2016 11:42:50 +0100 > Since the struct miscdevice have many members, it is dangerous to init > it without members name relying only on member order. > > This patch add member name to the init declaration. > > Signed-off-by:

Re: [kernel-hardening] Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

> As far as half-siphash is concerned, it occurs to me that the main > problem will be those users who need to guarantee that output can't be > guessed over a long period of time. For example, if you have a > long-running process, then the output needs to remain unguessable over > potentially

Re: [PATCH] bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu

From: Daniel Mack Date: Thu, 15 Dec 2016 10:53:21 +0100 > The member 'effective' in 'struct cgroup_bpf' is protected by RCU. > Annotate it accordingly to squelch a sparse warning. > > Signed-off-by: Daniel Mack Applied.

Re: [PATCH net-next 0/2] inet: Fixes for inet_csk_get_port and soreusport

From: Tom Herbert Date: Wed, 14 Dec 2016 16:54:14 -0800 > This patch set fixes a couple of issues I noticed while debugging our > softlockup issue in inet_csk_get_port. > > - Don't allow jump into port scan in inet_csk_get_port if function > was called with non-zero port

Re: [PATCH net] bpf, test_verifier: fix a test case error result on unprivileged

From: Daniel Borkmann Date: Thu, 15 Dec 2016 01:39:10 +0100 > Running ./test_verifier as unprivileged lets 1 out of 98 tests fail: > > [...] > #71 unpriv: check that printk is disallowed FAIL > Unexpected error message! > 0: (7a) *(u64 *)(r10 -8) = 0 > 1: (bf) r1

Re: [PATCH net] bpf: fix regression on verifier pruning wrt map lookups

From: Daniel Borkmann Date: Thu, 15 Dec 2016 01:30:06 +0100 > Commit 57a09bf0a416 ("bpf: Detect identical PTR_TO_MAP_VALUE_OR_NULL > registers") introduced a regression where existing programs stopped > loading due to reaching the verifier's maximum complexity limit, >

Re: [PATCH net] net: vrf: Drop conntrack data after pass through VRF device on Tx

From: David Ahern Date: Wed, 14 Dec 2016 14:31:11 -0800 > Locally originated traffic in a VRF fails in the presence of a POSTROUTING > rule. For example, > > $ iptables -t nat -A POSTROUTING -s 11.1.1.0/24 -j MASQUERADE > $ ping -I red -c1 11.1.1.3 > ping:

Re: [PATCH net] net: vrf: Fix NAT within a VRF

From: David Ahern Date: Wed, 14 Dec 2016 11:06:18 -0800 > Connection tracking with VRF is broken because the pass through the VRF > device drops the connection tracking info. Removing the call to nf_reset > allows DNAT and MASQUERADE to work across interfaces within a

Re: [PATCH net 0/2] net/sched: cls_flower: Fix mask handling

From: Paul Blakey Date: Wed, 14 Dec 2016 19:00:56 +0200 > The series fix how the mask is being handled. I guess this is reasonable, series applied, thanks.

Re: [kernel-hardening] Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

On Fri, Dec 16, 2016 at 09:15:03PM -0500, George Spelvin wrote: > >> - Ted, Andy Lutorminski and I will try to figure out a construction of > >> get_random_long() that we all like. We don't have to find the most optimal solution right away; we can approach this incrementally, after all. So

Re: ipv6: handle -EFAULT from skb_copy_bits

From: Dave Jones Date: Wed, 14 Dec 2016 10:47:29 -0500 > It seems to be possible to craft a packet for sendmsg that triggers > the -EFAULT path in skb_copy_bits resulting in a BUG_ON that looks like: > > RIP: 0010:[] [] rawv6_sendmsg+0xc30/0xc40 > RSP:

Re: [PATCH] net: mvpp2: fix dma unmapping of TX buffers for fragments

Hello, On Sat, 17 Dec 2016 10:20:57 -0500 (EST), David Miller wrote: > You're really destroying cache locality, and making things overly > complicated, by having two arrays. Actually this is now the third in > this structure alone. That's crazy. > > Just have one array for the TX ring

Re: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

From: Bartosz Folta Date: Wed, 14 Dec 2016 06:39:15 + > There are hardware PCI implementations of Cadence GEM network > controller. This patch will allow to use such hardware with reuse of > existing Platform Driver. > > Signed-off-by: Bartosz Folta

Re: [PATCH net] ibmveth: calculate gso_segs for large packets

From: Thomas Falcon Date: Tue, 13 Dec 2016 18:15:09 -0600 > Include calculations to compute the number of segments > that comprise an aggregated large packet. > > Signed-off-by: Thomas Falcon Applied.

Re: [PATCH] [v2] net: qcom/emac: don't try to claim clocks on ACPI systems

From: Timur Tabi Date: Tue, 13 Dec 2016 17:49:02 -0600 > On ACPI systems, clocks are not available to drivers directly. They are > handled exclusively by ACPI and/or firmware, so there is no clock driver. > Calls to clk_get() always fail, so we should not even attempt to

Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

To follow up on my comments that your benchmark results were peculiar, here's my benchmark code. It just computes the hash of all n*(n+1)/2 possible non-empty substrings of a buffer of n (called "max" below) bytes. "cpb" is "cycles per byte". (The average length is (n+2)/3, c.f.

Re: [PATCH] net: mvpp2: fix dma unmapping of TX buffers for fragments

From: Thomas Petazzoni Date: Tue, 13 Dec 2016 17:53:15 +0100 > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index 1026c45..d168b13 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++

Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

> diff --git a/lib/test_siphash.c b/lib/test_siphash.c > new file mode 100644 > index ..93549e4e22c5 > --- /dev/null > +++ b/lib/test_siphash.c > @@ -0,0 +1,83 @@ > +/* Test cases for siphash.c > + * > + * Copyright (C) 2016 Jason A. Donenfeld . All Rights > Reserved.

DO YOU NEED A LOAN??

LOAN

Re: Soft lockup in inet_put_port on 4.6

> On Dec 17, 2016, at 6:09 AM, Hannes Frederic Sowa > wrote: > >> On 16.12.2016 23:50, Josef Bacik wrote: >>> On Fri, Dec 16, 2016 at 5:18 PM, Tom Herbert wrote: On Fri, Dec 16, 2016 at 2:08 PM, Josef Bacik wrote: > On

Re: [PATCH v5 1/4] siphash: add cryptographically secure PRF

BTW, here's some SipHash code I wrote for Linux a while ago. My target application was ext4 directory hashing, resulting in different implementation choices, although I still think that a rolled-up implementation like this is reasonable. Reducing I-cache impact speeds up the calling code. One

Re: Soft lockup in inet_put_port on 4.6

On 16.12.2016 23:50, Josef Bacik wrote: > On Fri, Dec 16, 2016 at 5:18 PM, Tom Herbert wrote: >> On Fri, Dec 16, 2016 at 2:08 PM, Josef Bacik wrote: >>> On Fri, Dec 16, 2016 at 10:21 AM, Josef Bacik wrote: On Fri, Dec 16, 2016 at

mlx4: Bug in XDP_TX + 16 rx-queues

Hi All, I have been debugging with XDP_TX and 16 rx-queues. 1) When 16 rx-queues is used and an XDP prog is doing XDP_TX, it seems that the packet cannot be XDP_TX out if the pkt is received from some particular CPUs (/rx-queues). 2) If 8 rx-queues is used, it does not have problem. 3) The 16

Re: [PATCH net 2/2] bpf: fix overflow in prog accounting

On 12/17/2016 03:52 AM, kbuild test robot wrote: Hi Daniel, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Daniel-Borkmann/bpf-dynamically-allocate-digest-scratch-buffer/20161217-090046 config: sparc-defconfig (attached as .config) compiler: sparc-linux

Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list

On Wed, Aug 24, 2016 at 6:38 PM, Neil Horman wrote: > On Wed, Aug 24, 2016 at 01:14:27PM +0800, Xin Long wrote: >> >> > Ah, I see what you're doing. Ok, this makes some sense, at least on >> >> > the receive >> >> > side, when you get a cookie unpacked and modify the

Re: [TSN RFC v2 0/9] TSN driver for the kernel

Hi Richard, On Fri, Dec 16, 2016 at 11:05:30PM +0100, Richard Cochran wrote: > On Fri, Dec 16, 2016 at 06:59:04PM +0100, hen...@austad.us wrote: > > The driver is directed via ConfigFS as we need userspace to handle > > stream-reservation (MSRP), discovery and enumeration (IEEE 1722.1) and > >

Re: [TSN RFC v2 5/9] Add TSN header for the driver

On Fri, Dec 16, 2016 at 11:09:38PM +0100, Richard Cochran wrote: > On Fri, Dec 16, 2016 at 06:59:09PM +0100, hen...@austad.us wrote: > > +/* > > + * List of current subtype fields in the common header of AVTPDU > > + * > > + * Note: AVTPDU is a remnant of the standards from when it was AVB. > > +

Re: [PATCH 1/2] bpf: do not use KMALLOC_SHIFT_MAX

On Fri 16-12-16 16:28:21, Alexei Starovoitov wrote: > On Sat, Dec 17, 2016 at 12:39:17AM +0100, Michal Hocko wrote: > > On Fri 16-12-16 15:23:42, Alexei Starovoitov wrote: > > > On Fri, Dec 16, 2016 at 11:02:35PM +0100, Michal Hocko wrote: > > > > On Fri 16-12-16 10:02:10, Alexei Starovoitov