Re: Soft lockup in tc_classify

2016-12-20 Thread Cong Wang
On Tue, Dec 20, 2016 at 10:44 PM, Shahar Klein wrote: > > Tried it with same results This piece is pretty interesting: [ 408.554689] DEBUGG:SK thread-2853[cpu-1] setting tp_created to 1 tp=94b5b02805a0 back=94b9ea932060 [ 408.574258] DEBUGG:SK thread-2853[cpu-1]

Re: HalfSipHash Acceptable Usage

2016-12-20 Thread George Spelvin
Eric Dumazet wrote: > On Tue, 2016-12-20 at 22:28 -0500, George Spelvin wrote: >> Cycles per byte on 1024 bytes of data: >> Pentium Core 2 Ivy >> 4 Duo Bridge >> SipHash-2-4 38.9 8.3 5.8 >> HalfSipHash-2-4 12.7 4.5

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-20 Thread Cong Wang
On Tue, Dec 20, 2016 at 2:12 PM, Dave Jones wrote: > fd = socket(AF_INET6, SOCK_RAW, 7); > > setsockopt(fd, SOL_IPV6, IPV6_CHECKSUM, , 4); > setsockopt(fd, SOL_IPV6, IPV6_DSTOPTS, , LEN); > Interesting, you set the checksum offset to be 0, but the

Re: HalfSipHash Acceptable Usage

2016-12-20 Thread Eric Dumazet
On Tue, 2016-12-20 at 22:28 -0500, George Spelvin wrote: > > I do not see why SipHash, if faster than MD5 and more secure, would be a > > problem. > > Because on 32-bit x86, it's slower. > > Cycles per byte on 1024 bytes of data: > Pentium Core 2 Ivy >

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2016-12-20 Thread Alexei Starovoitov
On Tue, Dec 20, 2016 at 10:49:25AM -0800, Andy Lutomirski wrote: > >> FWIW, everywhere I say ioctl(), the bpf() syscall would be okay, too. > >> It doesn't make a semantic difference, except that I dislike > >> BPF_PROG_DETACH because that particular command isn't BPF-specific at > >> all. > > > >

Re: HalfSipHash Acceptable Usage

2016-12-20 Thread George Spelvin
> I do not see why SipHash, if faster than MD5 and more secure, would be a > problem. Because on 32-bit x86, it's slower. Cycles per byte on 1024 bytes of data: Pentium Core 2 Ivy 4 Duo Bridge SipHash-2-4 38.9 8.3 5.8

Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV()

2016-12-20 Thread David Miller
From: Florian Fainelli Date: Tue, 20 Dec 2016 17:02:37 -0800 > On 12/14/2016 05:13 PM, Florian Fainelli wrote: >> The Octeon driver calls into PHYLIB which now checks for >> net_device->dev.parent, so make sure we do set it before calling into >> any MDIO/PHYLIB related

Re: [PATCH net-next 1/1] driver: ipvlan: Define common functions to decrease duplicated codes used to add or del IP address

2016-12-20 Thread Gao Feng
On Wed, Dec 21, 2016 at 2:30 AM, David Miller wrote: > From: f...@ikuai8.com > Date: Mon, 19 Dec 2016 09:24:05 +0800 > >> It is sent again because the first email is sent during net-next closing. > > It is still closed, and will not open again for at least one week. Thanks

Re: [PATCH] phy: check if parent device is NULL

2016-12-20 Thread Ruslan Babayev
Yes, I saw that with the staging Octeon driver. Your patch works for me too. Thanks Florian! On Tue, Dec 20, 2016 at 4:33 PM, Florian Fainelli wrote: > On 12/20/2016 03:51 PM, Ruslan Babayev wrote: >> Fixes a crash observed on Octeon. >> >> Signed-off-by: Ruslan Babayev

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:16:31AM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry > > The TRF7970A has configuration options for supporting hardware designs > with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, > using a fixed regulator binding, for

Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf

2016-12-20 Thread Alexander Duyck
I find it curious that only the last 4 bytes have data in them. I'm wondering if the NIC/driver in the Windows/Nessus system is interpreting the 4 byte CRC on the end of the frame as padding instead of stripping it. Is there any chance you could capture the entire frame instead of just the

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:13:23AM -0500, Geoff Lansberry wrote: > On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring wrote: > > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > >> From: Geoff Lansberry > >> > >> --- > >>

Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf

2016-12-20 Thread Weilong Chen
Thanks for you explanation, it's very professional. My test is like this: The Nessus is deployed on a windows server, the peer is a X86_64 linux host which run several VMs on it. The nic is Intel 82599 and SRIOV is enabled. VFs are passthroughed to the VMs. No DPDK. The Nessus server send

Re: [PATCH] staging: octeon: Call SET_NETDEV_DEV()

2016-12-20 Thread Florian Fainelli
On 12/14/2016 05:13 PM, Florian Fainelli wrote: > The Octeon driver calls into PHYLIB which now checks for > net_device->dev.parent, so make sure we do set it before calling into > any MDIO/PHYLIB related function. > > Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a >

Re: [PATCH] phy: check if parent device is NULL

2016-12-20 Thread Florian Fainelli
On 12/20/2016 03:51 PM, Ruslan Babayev wrote: > Fixes a crash observed on Octeon. > > Signed-off-by: Ruslan Babayev > Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a > different owner") Assuming you saw this with the staging Octeon driver, a fix

Re: [PATCH net-next 00/10] netcp: enhancements and minor fixes

2016-12-20 Thread David Miller
The net-next tree is not open, do not resubmit this series until it is open again. Thanks.

Re: HalfSipHash Acceptable Usage

2016-12-20 Thread Eric Dumazet
On Tue, 2016-12-20 at 16:36 -0500, Theodore Ts'o wrote: > On Mon, Dec 19, 2016 at 06:32:44PM +0100, Jason A. Donenfeld wrote: > > 1) Anything that requires actual long-term security will use > > SipHash2-4, with the 64-bit output and the 128-bit key. This includes > > things like TCP sequence

[PATCH] phy: check if parent device is NULL

2016-12-20 Thread Ruslan Babayev
Fixes a crash observed on Octeon. Signed-off-by: Ruslan Babayev Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a different owner") --- drivers/net/phy/phy_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: HalfSipHash Acceptable Usage

2016-12-20 Thread George Spelvin
Theodore Ts'o wrote: > On Mon, Dec 19, 2016 at 06:32:44PM +0100, Jason A. Donenfeld wrote: >> 1) Anything that requires actual long-term security will use >> SipHash2-4, with the 64-bit output and the 128-bit key. This includes >> things like TCP sequence numbers. This seems pretty uncontroversial

[PATCH] net: qcom/emac: add ethtool support

2016-12-20 Thread Timur Tabi
Add support for some ethtool methods: get/set link settings, get/set message level, get statistics, get link status, and restart autonegotiation. Signed-off-by: Timur Tabi --- drivers/net/ethernet/qualcomm/emac/Makefile | 2 +-

[PATCH v5] net: dummy: Introduce dummy virtual functions

2016-12-20 Thread Phil Sutter
The idea for this was born when testing VF support in iproute2 which was impeded by hardware requirements. In fact, not every VF-capable hardware driver implements all netdev ops, so testing the interface is still hard to do even with a well-sorted hardware shelf. To overcome this and allow for

[PATCH 2/2] net: sfc: falcon: use new api ethtool_{get|set}_link_ksettings

2016-12-20 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sfc/falcon/efx.c |2 +- drivers/net/ethernet/sfc/falcon/ethtool.c | 35 ---

[PATCH 1/2] net: mdio: add mdio45_ethtool_ksettings_get

2016-12-20 Thread Philippe Reynes
There is a function in mdio for the old ethtool api gset. We add a new function mdio45_ethtool_ksettings_get for the new ethtool api glinksettings. Signed-off-by: Philippe Reynes --- drivers/net/mdio.c | 178 ++

[PATCH net-next 06/10] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY

2016-12-20 Thread Murali Karicheri
Currently to parse phy-handle, driver doesn't check if the interface is MAC to PHY. This patch add this check for all MAC to PHY interface types supported by the driver. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori ---

[PATCH net-next 00/10] netcp: enhancements and minor fixes

2016-12-20 Thread Murali Karicheri
This series is for net-next. This propagates enhancements and minor bug fixes from internal version of the driver to keep the upstream in sync. Please review and apply if this looks good. Tested on all of K2HK/E/L boards. Thanks Murali Karicheri Michael Scherban (1): net: netcp: store network

[PATCH net-next 02/10] net: netcp: ethss: add support of 10gbe pcsr link status

2016-12-20 Thread Murali Karicheri
From: WingMan Kwok The 10GBASE-R Physical Coding Sublayer (PCS-R) module provides functionality of a physical coding sublayer (PCS) on data being transferred between a demuxed XGMII and SerDes supporting a 16 or 32 bit interface. From the driver point of view, whether a ethernet

[PATCH net-next 05/10] net: netcp: store network statistics in 64 bits

2016-12-20 Thread Murali Karicheri
From: Michael Scherban Previously the network statistics were stored in 32 bit variable which can cause some stats to roll over after several minutes of high traffic. This implements 64 bit storage so larger numbers can be stored. Signed-off-by: Michael Scherban

[PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap

2016-12-20 Thread Murali Karicheri
From: WingMan Kwok 10gbe phy driver needs to access the 10gbe subsystem control register during phy initialization. To facilitate the shared access of the subsystem register region between the 10gbe Ethernet driver and the phy driver, this patch adds support of the subsystem

[PATCH net-next 07/10] net: netcp: use hw capability to remove FCS word from rx packets

2016-12-20 Thread Murali Karicheri
Some of the newer Ethernet switch hw (such as that on k2e/l/g) can strip the Etherenet FCS from packet at the port 0 egress of the switch. So use this capability instead of doing it in software. Signed-off-by: Murali Karicheri Signed-off-by: Sekhar Nori ---

[PATCH net-next 03/10] net: netcp: extract eflag from desc for rx_hook handling

2016-12-20 Thread Murali Karicheri
Extract the eflag bits from the received desc and pass it down the rx_hook chain to be available for netcp modules. Also the psdata and epib data has to be inspected by the netcp modules. So the desc can be freed only after returning from the rx_hook. So move knav_pool_desc_put() after the rx_hook

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-20 Thread Dave Jones
On Tue, Dec 20, 2016 at 11:31:38AM -0800, Cong Wang wrote: > On Tue, Dec 20, 2016 at 10:17 AM, Dave Jones wrote: > > On Mon, Dec 19, 2016 at 08:36:23PM -0500, David Miller wrote: > > > From: Dave Jones > > > Date: Mon, 19 Dec 2016 19:40:13

[PATCH net-next 04/10] net: netcp: remove the redundant memmov()

2016-12-20 Thread Murali Karicheri
The psdata is populated with command data by netcp modules to the tail of the buffer and set_words() copy the same to the front of the psdata. So remove the redundant memmov function call. Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_core.c | 6 +++---

[PATCH net-next 09/10] net: netcp: ale: use ale_status to size the ale table

2016-12-20 Thread Murali Karicheri
ALE h/w on newer version of NetCP (K2E/L/G) does provide a ALE_STATUS register for the size of the ALE Table implemented in h/w. Currently for example we set ALE Table size to 1024 for NetCP ALE on K2E even though the ALE Status/Documentation shows it has 8192 entries. So take advantage of this

[PATCH net-next 08/10] net: netcp: ale: update to support unknown vlan controls for NU switch

2016-12-20 Thread Murali Karicheri
In NU Ethernet switch used on some of the Keystone SoCs, there is separate UNKNOWNVLAN register for membership, unreg mcast flood, reg mcast flood and force untag egress bits in ALE. So control for these fields require different address offset, shift and size of field. As this ALE has the same

[PATCH net-next 10/10] net: netcp: ale: add proper ale entry mask bits for netcp switch ALE

2016-12-20 Thread Murali Karicheri
For NetCP NU Switch ALE, some of the mask bits are different than defaults used in the driver. Add a new macro DEFINE_ALE_FIELD1 that use a configurable mask bits and use it in the driver. These bits are set to correct values by using the new variables added to cpsw_ale structure and re-used in

Re: HalfSipHash Acceptable Usage

2016-12-20 Thread Theodore Ts'o
On Mon, Dec 19, 2016 at 06:32:44PM +0100, Jason A. Donenfeld wrote: > 1) Anything that requires actual long-term security will use > SipHash2-4, with the 64-bit output and the 128-bit key. This includes > things like TCP sequence numbers. This seems pretty uncontroversial to > me. Seem okay to

[GIT] Networking

2016-12-20 Thread David Miller
1) Use rb_entry() instead of hardcoded container_of(), from Geliang Tang. 2) Use correct memory barriers in stammac driver, from Pavel Machek. 3) Fix assoc bind address handling in SCTP, from Xin Long. 4) Make the length check for UFO handling consistent between __ip_append_data() and

[ANNOUNCE] nftables 0.7 release

2016-12-20 Thread Pablo Neira Ayuso
Hi! The Netfilter project proudly presents: nftables 0.7 This release contains many accumulated bug fixes and new features available up to the (upcoming) Linux 4.10-rc1 kernel release. * Facilitate migration from iptables to nftables: At compilation time, you have to pass this

[PATCH 3/5 net-next] inet: don't check for bind conflicts twice when searching for a port

2016-12-20 Thread Josef Bacik
This is just wasted time, we've already found a tb that doesn't have a bind conflict, and we don't drop the head lock so scanning again isn't going to give us a different answer. Instead move the tb->reuse setting logic outside of the found_tb path and put it in the success: path. Then make it

[PATCH 5/5 net-next] inet: reset tb->fastreuseport when adding a reuseport sk

2016-12-20 Thread Josef Bacik
If we have non reuseport sockets on a tb we will set tb->fastreuseport to 0 and never set it again. Which means that in the future if we end up adding a bunch of reuseport sk's to that tb we'll have to do the expensive scan every time. Instead add a sock_common to the tb so we know what reuseport

[PATCH 4/5 net-next] inet: split inet_csk_get_port into two functions

2016-12-20 Thread Josef Bacik
inet_csk_get_port does two different things, it either scans for an open port, or it tries to see if the specified port is available for use. Since these two operations have different rules and are basically independent lets split them into two different functions to make them both more readable.

[PATCH 2/5 net-next] inet: kill smallest_size and smallest_port

2016-12-20 Thread Josef Bacik
In inet_csk_get_port we seem to be using smallest_port to figure out where the best place to look for a SO_REUSEPORT sk that matches with an existing set of SO_REUSEPORT's. However if we get to the logic if (smallest_size != -1) { port = smallest_port; goto have_port; } we will

[PATCH 1/5 net-next] inet: replace ->bind_conflict with ->rcv_saddr_equal

2016-12-20 Thread Josef Bacik
The only difference between inet6_csk_bind_conflict and inet_csk_bind_conflict is how they check the rcv_saddr. Since we want to be able to check the saddr in other places just drop the protocol specific ->bind_conflict and replace it with ->rcv_saddr_equal, then make inet_csk_bind_conflict the

[RFC][PATCH 0/5 net-next] Rework inet_csk_get_port

2016-12-20 Thread Josef Bacik
At some point recently the guys working on our load balancer added the ability to use SO_REUSEPORT. When they restarted their app with this option enabled they immediately hit a softlockup on what appeared to be the inet_bind_bucket->lock. Eventually what all of our debugging and discussion led

Re: nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 02:13:52PM -0500, Justin Bronder wrote: > On 20/12/16 11:59 -0700, Mark Greer wrote: > > On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > > > From: Jaret Cantu > > > > > > Repeated polling attempts cause a NULL dereference error

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-20 Thread Dave Jones
On Tue, Dec 20, 2016 at 01:28:13PM -0500, David Miller wrote: > This has to do with the SKB buffer layout and geometry, not whether > the packet is "fragmented" in the protocol sense. > > So no, this isn't a criteria for packets being filtered out by this > point. > > Can you try to

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-20 Thread Cong Wang
On Tue, Dec 20, 2016 at 10:17 AM, Dave Jones wrote: > On Mon, Dec 19, 2016 at 08:36:23PM -0500, David Miller wrote: > > From: Dave Jones > > Date: Mon, 19 Dec 2016 19:40:13 -0500 > > > > > On Mon, Dec 19, 2016 at 07:31:44PM -0500, Dave Jones

Re: [PATCH net] be2net: Increase skb headroom size to 256 bytes

2016-12-20 Thread David Miller
From: Suresh Reddy Date: Tue, 20 Dec 2016 10:14:30 -0500 > From: Kalesh A P > > The driver currently allocates 128 bytes of skb headroom. > This was found to be insufficient with some configurations > like Geneve tunnels, which

Re: [mm PATCH 0/3] Page fragment updates

2016-12-20 Thread Alexander Duyck
On Mon, Dec 5, 2016 at 12:11 PM, Andrew Morton wrote: > On Mon, 5 Dec 2016 09:01:12 -0800 Alexander Duyck > wrote: > >> On Tue, Nov 29, 2016 at 10:23 AM, Alexander Duyck >> wrote: >> > This patch series takes care

Re: [PATCH] net_sched: sch_netem: use rb_entry()

2016-12-20 Thread David Miller
From: Geliang Tang Date: Tue, 20 Dec 2016 22:02:16 +0800 > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] net_sched: sch_fq: use rb_entry()

2016-12-20 Thread David Miller
From: Geliang Tang Date: Tue, 20 Dec 2016 22:02:15 +0800 > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] net/mlx5: use rb_entry()

2016-12-20 Thread David Miller
From: Geliang Tang Date: Tue, 20 Dec 2016 22:02:14 +0800 > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] RDS: use rb_entry()

2016-12-20 Thread David Miller
From: Geliang Tang Date: Tue, 20 Dec 2016 22:02:18 +0800 > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] ethernet: sfc: Add Kconfig entry for vendor Solarflare

2016-12-20 Thread David Miller
From: Tobias Klauser Date: Tue, 20 Dec 2016 14:38:26 +0100 > Since commit > > 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new > sfc-falcon driver") > > there are two drivers for Solarflare devices, but both still show up > directly beneath "Ethernet

Re: [GIT PULL 00/29] perf/core improvements and fixes

2016-12-20 Thread Ingo Molnar
-12-12 21:58:13 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tags/perf-core-for-mingo-20161220 > > for you to fetch changes up to 9899694a7f67714216665b87318eb367e2c5c901: >

Re: nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Justin Bronder
On 20/12/16 11:59 -0700, Mark Greer wrote: > On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > > From: Jaret Cantu > > > > Repeated polling attempts cause a NULL dereference error to occur. > > This is because the state of the trf7970a is currently

Re: [PATCH 0/2] net: hix5hd2_gmac: keep the compatible string not changed

2016-12-20 Thread David Miller
From: Dongpo Li Date: Tue, 20 Dec 2016 10:09:27 +0800 > This patch series fix the patch: > d0fb6ba75dc0 ("net: hix5hd2_gmac: add generic compatible string") > > The SoC hix5hd2 compatible string has the suffix "-gmac" and > we should not change its compatible string. >

Re: [PATCH net 2/2] net: netcp: ethss: fix 10gbe host port tx pri map configuration

2016-12-20 Thread David Miller
From: Murali Karicheri Date: Mon, 19 Dec 2016 17:55:57 -0500 > From: WingMan Kwok > > This patch adds the missing 10gbe host port tx priority map > configurations. > > Signed-off-by: WingMan Kwok > Signed-off-by: Murali Karicheri

Re: [PATCH net] openvswitch: Add a missing break statement.

2016-12-20 Thread David Miller
From: Jarno Rajahalme Date: Mon, 19 Dec 2016 17:06:33 -0800 > Add a break statement to prevent fall-through from > OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL. Without the break > actions setting ethernet addresses fail to validate with log messages > complaining about invalid

Re: [PATCH net 1/2] net: netcp: ethss: fix errors in ethtool ops

2016-12-20 Thread David Miller
From: Murali Karicheri Date: Mon, 19 Dec 2016 17:55:56 -0500 > From: WingMan Kwok > > In ethtool ops, it needs to retrieve the corresponding > ethss module (gbe or xgbe) from the net_device structure. > Prior to this patch, the retrieving procedure only >

Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the state of the trf7970a is currently reading but > another request has been made to send a

Re: [PATCH net v4 0/4] fsl/fman: fixes for ARM

2016-12-20 Thread David Miller
From: Madalin Bucur Date: Mon, 19 Dec 2016 22:42:42 +0200 > The patch set fixes advertised speeds for QSGMII interfaces, disables > A007273 erratum workaround on non-PowerPC platforms where it does not > apply, enables compilation on ARM64 and addresses a probing issue on

Re: Soft lockup in tc_classify

2016-12-20 Thread Shahar Klein
On 12/19/2016 7:58 PM, Cong Wang wrote: Hello, On Mon, Dec 19, 2016 at 8:39 AM, Shahar Klein wrote: On 12/13/2016 12:51 AM, Cong Wang wrote: On Mon, Dec 12, 2016 at 1:18 PM, Or Gerlitz wrote: On Mon, Dec 12, 2016 at 3:28 PM, Daniel Borkmann

Re: [PATCH net 0/3] Fix integration of eee-broken-modes

2016-12-20 Thread David Miller
From: Jerome Brunet Date: Mon, 19 Dec 2016 16:05:35 +0100 > The purpose of this series is to fix the integration of the ethernet phy > property "eee-broken-modes" [0] > > The v3 of this series has been merged, missing a fix (error reported by > kbuild robot) available in

Re: [PATCH perf/core REBASE 3/5] tools lib bpf: Add bpf_prog_{attach,detach}

2016-12-20 Thread Joe Stringer
On 20 December 2016 at 06:32, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 20, 2016 at 11:18:51AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Dec 14, 2016 at 02:43:40PM -0800, Joe Stringer escreveu: >> > Commit d8c5b17f2bc0 ("samples: bpf: add userspace example for

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2016-12-20 Thread Andy Lutomirski
On Tue, Dec 20, 2016 at 10:36 AM, Daniel Mack wrote: > Hi, > > On 12/20/2016 06:23 PM, Andy Lutomirski wrote: >> On Tue, Dec 20, 2016 at 2:21 AM, Daniel Mack wrote: > >> To clarify, since this thread has gotten excessively long and twisted, >> I think it's

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Geoff Lansberry
On Tue, Dec 20, 2016 at 1:11 PM, Mark Greer wrote: > Hi Geoff. > > Please put the version in your subjects when submitting anything but the > initial version of a patch (e.g., [PATCH v2 1/3]). > > Which series do you want reviewed? > > Mark > -- Sorry about the double

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2016-12-20 Thread Daniel Mack
Hi, On 12/20/2016 06:23 PM, Andy Lutomirski wrote: > On Tue, Dec 20, 2016 at 2:21 AM, Daniel Mack wrote: > To clarify, since this thread has gotten excessively long and twisted, > I think it's important that, for hooks attached to a cgroup, you be > able to tell in a generic

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 01:29:13PM -0500, Geoff Lansberry wrote: > On Tue, Dec 20, 2016 at 1:11 PM, Mark Greer wrote: > > Hi Geoff. > > > > Please put the version in your subjects when submitting anything but the > > initial version of a patch (e.g., [PATCH v2 1/3]). > > >

Re: mlx4: Bug in XDP_TX + 16 rx-queues

2016-12-20 Thread Martin KaFai Lau
On Tue, Dec 20, 2016 at 02:02:05PM +0200, Tariq Toukan wrote: > Thanks Martin, nice catch! > > > On 20/12/2016 1:37 AM, Martin KaFai Lau wrote: > >Hi Tariq, > > > >On Sat, Dec 17, 2016 at 02:18:03AM -0800, Martin KaFai Lau wrote: > >>Hi All, > >> > >>I have been debugging with XDP_TX and 16

Re: [PATCH net-next 1/1] driver: ipvlan: Define common functions to decrease duplicated codes used to add or del IP address

2016-12-20 Thread David Miller
From: f...@ikuai8.com Date: Mon, 19 Dec 2016 09:24:05 +0800 > It is sent again because the first email is sent during net-next closing. It is still closed, and will not open again for at least one week.

Re: kernel/bpf/verifier.c: 4 * possible unintended fallthrough ?

2016-12-20 Thread Josef Bacik
On Tue, Dec 20, 2016 at 11:34 AM, David Binderman wrote: Hello there, From: Alexei Starovoitov I've tried 4.9 and 5.2 and don't see this warning. As expected - I used a development version of gcc. Latest released version is 6.2 Is this

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-20 Thread David Miller
From: Dave Jones Date: Tue, 20 Dec 2016 13:17:28 -0500 > On Mon, Dec 19, 2016 at 08:36:23PM -0500, David Miller wrote: > > From: Dave Jones > > Date: Mon, 19 Dec 2016 19:40:13 -0500 > > > > > On Mon, Dec 19, 2016 at 07:31:44PM -0500, Dave

Re: ipv6: handle -EFAULT from skb_copy_bits

2016-12-20 Thread Dave Jones
On Mon, Dec 19, 2016 at 08:36:23PM -0500, David Miller wrote: > From: Dave Jones > Date: Mon, 19 Dec 2016 19:40:13 -0500 > > > On Mon, Dec 19, 2016 at 07:31:44PM -0500, Dave Jones wrote: > > > > > Unfortunately, this made no difference. I spent some time today

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Mark Greer
Hi Geoff. Please put the version in your subjects when submitting anything but the initial version of a patch (e.g., [PATCH v2 1/3]). Which series do you want reviewed? Mark --

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Jones Desougi
On 2016-12-20 17:16, Geoff Lansberry wrote: > From: Geoff Lansberry > > The TRF7970A has configuration options to support hardware designs > which use a 27.12MHz clock. This commit adds a device tree option > 'clock-frequency' to support configuring the this chip for default >

Re: [PATCH] ethernet: sfc: Add Kconfig entry for vendor Solarflare

2016-12-20 Thread Edward Cree
On 20/12/16 13:38, Tobias Klauser wrote: > Since commit > > 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new > sfc-falcon driver") > > there are two drivers for Solarflare devices, but both still show up > directly beneath "Ethernet driver support" in the Kconfig. Follow the

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2016-12-20 Thread Andy Lutomirski
On Tue, Dec 20, 2016 at 2:21 AM, Daniel Mack wrote: > Hi, > > On 12/20/2016 04:50 AM, Andy Lutomirski wrote: >> You mean BPF_CGROUP_RUN_PROG_INET_SOCK(sk)? There is nothing bpf >> specfic about the hook except that the name of this macro has "BPF" in >> it. There is nothing

Re: wl1251 & mac address & calibration data

2016-12-20 Thread Tony Lindgren
* Kalle Valo [161220 09:12]: > Tony Lindgren writes: > > > * Kalle Valo [161220 03:47]: > >> Arend Van Spriel writes: > >> > >> > On 18-12-2016 13:09, Pali Rohár wrote: > >> > > >> >> File

Re: wl1251 & mac address & calibration data

2016-12-20 Thread Kalle Valo
Tony Lindgren writes: > * Kalle Valo [161220 03:47]: >> Arend Van Spriel writes: >> >> > On 18-12-2016 13:09, Pali Rohár wrote: >> > >> >> File wl1251-nvs.bin is provided by linux-firmware package and contains >> >>

[PATCH 19/29] samples/bpf: Make samples more libbpf-centric

2016-12-20 Thread Arnaldo Carvalho de Melo
From: Joe Stringer Switch all of the sample code to use the function names from tools/lib/bpf so that they're consistent with that, and to declare their own log buffers. This allow the next commit to be purely devoted to getting rid of the duplicate library in samples/bpf.

[PATCH v3] stmmac: enable rx queues

2016-12-20 Thread Joao Pinto
When the hardware is synthesized with multiple queues, all queues are disabled for default. This patch adds the rx queues configuration. This patch was successfully tested in a Synopsys QoS Reference design. Signed-off-by: Joao Pinto --- changes v2 -> v3 (Seraphin Bonnaffe):

Re: wl1251 & mac address & calibration data

2016-12-20 Thread Pali Rohár
On Tuesday 20 December 2016 17:56:58 Tony Lindgren wrote: > * Kalle Valo [161220 03:47]: > > Arend Van Spriel writes: > > > On 18-12-2016 13:09, Pali Rohár wrote: > > >> File wl1251-nvs.bin is provided by linux-firmware package and > > >>

[PATCH 25/29] samples/bpf: Switch over to libbpf

2016-12-20 Thread Arnaldo Carvalho de Melo
From: Joe Stringer Now that libbpf under tools/lib/bpf/* is synced with the version from samples/bpf, we can get rid most of the libbpf library here. Committer notes: Built it in a docker fedora rawhide container and ran it in the f25 host, seems to work just like it did before

[GIT PULL 00/29] perf/core improvements and fixes

2016-12-20 Thread Arnaldo Carvalho de Melo
-20161220 for you to fetch changes up to 9899694a7f67714216665b87318eb367e2c5c901: samples/bpf: Move open_raw_sock to separate header (2016-12-20 12:00:40 -0300) perf/core improvements and fixes: New features: - Introduce 'perf

Re: [PATCH v2] stmmac: enable rx queues

2016-12-20 Thread Joao Pinto
Às 4:51 PM de 12/20/2016, Seraphin BONNAFFE escreveu: > Hi Joao, > > Please find two more comments below. > > Regards, > Séraphin > > > On 12/20/2016 05:27 PM, Joao Pinto wrote: >> When the hardware is synthesized with multiple queues, all queues are >> disabled for default. This patch adds

Re: wl1251 & mac address & calibration data

2016-12-20 Thread Tony Lindgren
* Kalle Valo [161220 03:47]: > Arend Van Spriel writes: > > > On 18-12-2016 13:09, Pali Rohár wrote: > > > >> File wl1251-nvs.bin is provided by linux-firmware package and contains > >> default data which should be overriden by model specific

Re: [PATCH v2] stmmac: enable rx queues

2016-12-20 Thread Seraphin BONNAFFE
Hi Joao, Please find two more comments below. Regards, Séraphin On 12/20/2016 05:27 PM, Joao Pinto wrote: When the hardware is synthesized with multiple queues, all queues are disabled for default. This patch adds the rx queues configuration. This patch was successfully tested in a Synopsys

RE: [RFC PATCH net-next v4 2/2] macb: Enable 1588 support in SAMA5Dx platforms.

2016-12-20 Thread Rafal Ozieblo
From: Andrei Pistirica [mailto:andrei.pistir...@microchip.com] Sent: 14 grudnia 2016 13:56 > This patch does the following: > > - Enable HW time stamp for the following platforms: SAMA5D2, SAMA5D3 and >

Re: Which ethtool methods should I implement?

2016-12-20 Thread Timur Tabi
On 12/19/2016 07:40 PM, Florian Fainelli wrote: Ideally, everything that is supported by your HW, but I would with the basic essential stuff that you would need in case someone reports problems with your driver like: - statistics (MAC for sure) and PHY (if possible), -S - ability to restart

Re: [PATCH] net_sched: sch_fq: use rb_entry()

2016-12-20 Thread Eric Dumazet
On Tue, 2016-12-20 at 22:02 +0800, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang > --- > net/sched/sch_fq.c | 14 +++--- > 1 file changed, 7 insertions(+), 7

Re: [PATCH net-next] ixgbevf: fix 'Etherleak' in ixgbevf

2016-12-20 Thread Alexander Duyck
The limit of 17 is just based on the hardware. Specifically the olinfo field in the Tx descriptor has a minimum length of 17 has a requirement. The hardware itself is supposed to be capable of padding short frames that are supposed to be transmitted. The drivers are supposed to pad short frames

Re: [PATCH] RDS: use rb_entry()

2016-12-20 Thread Santosh Shilimkar
On 12/20/2016 6:02 AM, Geliang Tang wrote: To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- Looks fine. Acked-by: Santosh Shilimkar

[PATCH v2] stmmac: enable rx queues

2016-12-20 Thread Joao Pinto
When the hardware is synthesized with multiple queues, all queues are disabled for default. This patch adds the rx queues configuration. This patch was successfully tested in a Synopsys QoS Reference design. Signed-off-by: Joao Pinto --- changes v1 -> v2 (Niklas Cassel and

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Geoff Lansberry
From: Geoff Lansberry The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz clock. ---

Re: kernel/bpf/verifier.c: 4 * possible unintended fallthrough ?

2016-12-20 Thread Alexei Starovoitov
On Tue, Dec 20, 2016 at 3:20 AM, David Binderman wrote: > Hello there, > > I just tried to compile kernel-4.9 with a recent development > version of gcc. It said > > kernel/bpf/verifier.c:1907:23: warning: this statement may fall through > [-Wimplicit-fallthrough=] >

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Geoff Lansberry
On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring wrote: > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: >> From: Geoff Lansberry >> >> --- >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ >> drivers/nfc/trf7970a.c

Re: [PATCH v2 3/3] arm64: dts: marvell: Add ethernet switch definition for the ESPRESSObin

2016-12-20 Thread Andrew Lunn
> >>+ mdio { > >>+ #address-cells = <1>; > >>+ #size-cells = <0>; > >>+ reg = <1>; > > > >what is this reg value for? > > > > Andrew > > > > It was required to avoid a warning thrown by the mdio subsystem Do you remember what

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Geoff Lansberry
From: Geoff Lansberry The TRF7970A has configuration options for supporting hardware designs with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, using a fixed regulator binding, for setting the io voltage to match the hardware configuration. If no option is

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Geoff Lansberry
From: Jaret Cantu Repeated polling attempts cause a NULL dereference error to occur. This is because the state of the trf7970a is currently reading but another request has been made to send a command before it has finished. The solution is to properly kill the waiting

  1   2   >