Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-17 Thread Greg KH
On Mon, Jan 16, 2017 at 12:01:02PM -0800, Florian Fainelli wrote: > On 01/15/2017 11:16 AM, Andrew Lunn wrote: > >>> What exactly is the relationship between these devices (a ascii-art tree > >>> or sysfs tree output might be nice) so I can try to understand what is > >>> going on here. > > > >

[PATCH net-next V5 3/3] tun: rx batching

2017-01-17 Thread Jason Wang
We can only process 1 packet at one time during sendmsg(). This often lead bad cache utilization under heavy load. So this patch tries to do some batching during rx before submitting them to host network stack. This is done through accepting MSG_MORE as a hint from sendmsg() caller, if it was set,

[PATCH net-next V5 2/3] vhost_net: tx batching

2017-01-17 Thread Jason Wang
This patch tries to utilize tuntap rx batching by peeking the tx virtqueue during transmission, if there's more available buffers in the virtqueue, set MSG_MORE flag for a hint for backend (e.g tuntap) to batch the packets. Reviewed-by: Stefan Hajnoczi Signed-off-by: Jason

[PATCH net-next V5 1/3] vhost: better detection of available buffers

2017-01-17 Thread Jason Wang
This patch tries to do several tweaks on vhost_vq_avail_empty() for a better performance: - check cached avail index first which could avoid userspace memory access. - using unlikely() for the failure of userspace access - check vq->last_avail_idx instead of cached avail index as the last step.

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Greg Kroah-Hartman
On Tue, Jan 17, 2017 at 03:21:47PM -0800, Florian Fainelli wrote: > Add a helper function to lookup a device reference given a class name. > This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and > make it more generic. > > Signed-off-by: Florian Fainelli >

[PATCH net-next V5 0/3] vhost_net tx batching

2017-01-17 Thread Jason Wang
Hi: This series tries to implement tx batching support for vhost. This was done by using MSG_MORE as a hint for under layer socket. The backend (e.g tap) can then batch the packets temporarily in a list and submit it all once the number of bacthed exceeds a limitation. Tests shows obvious

[PATCH iproute2 net-next] iplink: bridge_slave: add support for IFLA_BRPORT_FLUSH

2017-01-17 Thread Hangbin Liu
This patch implements support for the IFLA_BRPORT_FLUSH attribute in iproute2 so it can flush bridge slave's fdb dynamic entries. Signed-off-by: Hangbin Liu --- ip/iplink_bridge_slave.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCHv2 iproute2 net-next 1/5] iplink: bridge: add support for IFLA_BR_FDB_FLUSH

2017-01-17 Thread Hangbin Liu
This patch implements support for the IFLA_BR_FDB_FLUSH attribute in iproute2 so it can flush bridge fdb dynamic entries. Reviewed-by: Nikolay Aleksandrov Signed-off-by: Hangbin Liu --- ip/iplink_bridge.c | 5 - 1 file changed, 4

[PATCHv2 iproute2 net-next 4/5] iplink: bridge: add support for IFLA_BR_MCAST_IGMP_VERSION

2017-01-17 Thread Hangbin Liu
This patch implements support for the IFLA_BR_MCAST_IGMP_VERSION attribute in iproute2 so it can change the mcast igmp version. Reviewed-by: Nikolay Aleksandrov Signed-off-by: Hangbin Liu --- ip/iplink_bridge.c | 13 + 1 file

[PATCHv2 iproute2 net-next 0/5] add latest bridge netlink options

2017-01-17 Thread Hangbin Liu
Add the bridge netlink attributes added to kernel recently. v2: rename vlan/mcast_state to vlan/mcast_stats_enabled as suggested by Nikolay. The previous name has different meaning and will mislead people. I will post a separate patch for IFLA_BRPORT_FLUSH support. Hangbin Liu (5): iplink:

[PATCHv2 iproute2 net-next 5/5] iplink: bridge: add support for IFLA_BR_MCAST_MLD_VERSION

2017-01-17 Thread Hangbin Liu
This patch implements support for the IFLA_BR_MCAST_MLD_VERSION attribute in iproute2 so it can change the mcast mld version. Reviewed-by: Nikolay Aleksandrov Signed-off-by: Hangbin Liu --- ip/iplink_bridge.c | 13 + 1 file

[PATCHv2 iproute2 net-next 3/5] iplink: bridge: add support for IFLA_BR_MCAST_STATS_ENABLED

2017-01-17 Thread Hangbin Liu
This patch implements support for the IFLA_BR_MCAST_STATS_ENABLED attribute in iproute2 so it can enable/disable mcast stats accounting. Signed-off-by: Hangbin Liu --- ip/iplink_bridge.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ip/iplink_bridge.c

[PATCHv2 iproute2 net-next 2/5] iplink: bridge: add support for IFLA_BR_VLAN_STATS_ENABLED

2017-01-17 Thread Hangbin Liu
This patch implements support for the IFLA_BR_VLAN_STATS_ENABLED attribute in iproute2 so it can enable/disable vlan stats accounting. Signed-off-by: Hangbin Liu --- ip/iplink_bridge.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ip/iplink_bridge.c

[PATCH net-next v2] net/mlx5e: Support bpf_xdp_adjust_head()

2017-01-17 Thread Martin KaFai Lau
This patch adds bpf_xdp_adjust_head() support to mlx5e. 1. rx_headroom is added to struct mlx5e_rq. It uses an existing 4 byte hole in the struct. 2. The adjusted data length is checked against MLX5E_XDP_MIN_INLINE and MLX5E_SW2HW_MTU(rq->netdev->mtu). 3. The macro MLX5E_SW2HW_MTU is moved

Re: [PATCH net-next v2] bridge: multicast to unicast

2017-01-17 Thread kbuild test robot
Hi Felix, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Linus-L-ssing/bridge-multicast-to-unicast/20170118-120345 config: x86_64-rhel-7.2 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-17 Thread Leon Romanovsky
On Tue, Jan 17, 2017 at 11:27:20AM -0800, Vishwanathapura, Niranjana wrote: > Thanks Jason for the valuable inputs. > > Here is the new generic interface. > > Overview: > Bottom driver defines net_device_ops. The upper driver can override it. > For example, upper driver can implement ndo_open()

RE: [PATCH v2] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Andy Duan
From: Eric Dumazet Sent: Wednesday, January 18, 2017 1:02 PM >To: Yuusuke Ashiduka >Cc: Andy Duan ; netdev@vger.kernel.org >Subject: Re: [PATCH v2] net: fec: Fixed panic problem with non-tso > >On Wed, 2017-01-18 at 13:11

Re: [PATCH v2] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Eric Dumazet
On Wed, 2017-01-18 at 13:11 +0900, Yuusuke Ashiduka wrote: > If highmem and 2GB or more of memory are valid, > "this_frag-> page.p" indicates the highmem area, > so the result of page_address() is NULL and panic occurs. > > This commit fixes this by using the skb_frag_dma_map() helper, > which

[PATCH net-next] mlx4: support __GFP_MEMALLOC for rx

2017-01-17 Thread Eric Dumazet
From: Eric Dumazet Commit 04aeb56a1732 ("net/mlx4_en: allocate non 0-order pages for RX ring with __GFP_NOMEMALLOC") added code that appears to be not needed at that time, since mlx4 never used __GFP_MEMALLOC allocations anyway. As using memory reserves is a must in some

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Eric Dumazet
On Tue, 2017-01-17 at 20:21 -0800, Eric Dumazet wrote: > On Wed, 2017-01-18 at 03:12 +, Ashizuka, Yuusuke wrote: > > > indeed. > > > > In the case of TSO with i.MX6 system (highmem enabled) with 2GB memory, > > "this_frag->page.p" did not become highmem area. > > (We confirmed by

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Eric Dumazet
On Wed, 2017-01-18 at 03:12 +, Ashizuka, Yuusuke wrote: > indeed. > > In the case of TSO with i.MX6 system (highmem enabled) with 2GB memory, > "this_frag->page.p" did not become highmem area. > (We confirmed by transferring about 100MB of files) > > However, in the case of non-tso on an

[PATCH v2] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Yuusuke Ashiduka
If highmem and 2GB or more of memory are valid, "this_frag-> page.p" indicates the highmem area, so the result of page_address() is NULL and panic occurs. This commit fixes this by using the skb_frag_dma_map() helper, which takes care of mapping the skb fragment properly. Additionally, the type

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-17 Thread Jason Wang
On 2017年01月18日 02:27, Michael S. Tsirkin wrote: On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf Neugebauer wrote: This patch part reverts fd2a0437dc33 and e858fae2b0b8 which introduced a subtle change in how the virtio_net flags are derived from the SKBs ip_summed field. With the above

Re: [net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-17 Thread Jason Wang
On 2017年01月18日 06:22, John Fastabend wrote: +static int virtnet_reset(struct virtnet_info *vi) +{ + struct virtio_device *dev = vi->vdev; + int ret; + + virtio_config_disable(dev); + dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; +

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Ashizuka, Yuusuke
> -Original Message- > From: Andy Duan [mailto:fugang.d...@nxp.com] > Sent: Tuesday, January 17, 2017 8:02 PM > To: Ashizuka, Yuusuke/芦塚 雄介 > Cc: netdev@vger.kernel.org > Subject: RE: [PATCH] net: fec: Fixed panic problem with non-tso > > From: Yuusuke Ashiduka

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-17 Thread Ashizuka, Yuusuke
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, January 18, 2017 5:45 AM > To: Ashizuka, Yuusuke/芦塚 雄介 > Cc: fugang.d...@nxp.com; netdev@vger.kernel.org > Subject: Re: [PATCH] net: fec: Fixed panic problem with non-tso > > From: Yuusuke Ashiduka

[PATCH net] bnxt_en: Fix "uninitialized variable" bug in TPA code path.

2017-01-17 Thread Michael Chan
In the TPA GRO code path, initialize the tcp_opt_len variable to 0 so that it will be correct for packets without TCP timestamps. The bug caused the SKB fields to be incorrectly set up for packets without TCP timestamps, leading to these packets being rejected by the stack. Reported-by: Andy

Re: [PATCH] net: ethernet: stmmac: add ARP management

2017-01-17 Thread kbuild test robot
Hi Christophe, [auto build test WARNING on net-next/master] [also build test WARNING on next-20170117] [cannot apply to v4.10-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christophe

[PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0]

2017-01-17 Thread Vivien Didelot
Now that the DSA Ethernet switches are true Linux devices, the CPU switch is not necessarily the first one. If its address is higher than the second switch on the same MDIO bus, its index will be 1, not 0. Avoid any confusion by using dst->cpu_switch instead of dst->ds[0]. Signed-off-by: Vivien

[PATCH net-next 1/2] net: dsa: store CPU switch structure in the tree

2017-01-17 Thread Vivien Didelot
Store a dsa_switch pointer to the CPU switch in the tree instead of only its index. This avoids the need to initialize it to -1. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 8 net/dsa/dsa.c | 7 +++ net/dsa/dsa2.c| 5 ++--- 3

Re: [PATCH 3/4] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-17 Thread Ivan Khoronzhuk
On Thu, Jan 12, 2017 at 11:34:47AM -0600, Grygorii Strashko wrote: Hi Grygorii, Sorry for late reply. > > > On 01/10/2017 07:56 PM, Ivan Khoronzhuk wrote: > > On Mon, Jan 09, 2017 at 11:25:38AM -0600, Grygorii Strashko wrote: > >> > >> > >> On 01/08/2017 10:41 AM, Ivan Khoronzhuk wrote: > >>>

Re: [PATCH v3 net-next] net:add one common config ARCH_WANT_RELAX_ORDER to support relax ordering

2017-01-17 Thread Alexander Duyck
On Tue, Jan 17, 2017 at 4:50 PM, Mao Wenan wrote: > Relax ordering(RO) is one feature of 82599 NIC, to enable this feature can > enhance the performance for some cpu architecure, such as SPARC and so on. > Currently it only supports one special cpu architecture(SPARC) in

RE: GOOD NEWS

2017-01-17 Thread Khokhar, Kashif
A donation was made to you . Contact ( antoiaxjohn...@yahoo.com ) for details...

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

2017-01-17 Thread Florian Fainelli
On 01/17/2017 04:14 PM, Russell King - ARM Linux wrote: > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the include itself

Re: [PATCH RFC] net: dsa: remove unnecessary phy.h include

2017-01-17 Thread Vivien Didelot
Hi Russell, Russell King - ARM Linux writes: > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the

RE: [PATCH v2 net-next] net:add one common config ARCH_WANT_RELAX_ORDER to support relax ordering.

2017-01-17 Thread maowenan
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, January 18, 2017 3:28 AM > To: David Miller > Cc: maowenan; Netdev; Jeff Kirsher > Subject: Re: [PATCH v2 net-next] net:add one common config > ARCH_WANT_RELAX_ORDER to support relax

Re: [PATCHv2 5/7] TAP: Extending tap device create/destroy APIs

2017-01-17 Thread Andy Shevchenko
On Wed, Jan 18, 2017 at 2:03 AM, Sainath Grandhi wrote: > Extending tap APIs get/free_minor and create/destroy_cdev to handle more than > one > type of virtual interface. > Yes, looks better now. FWIW: Reviewed-by: Andy Shevchenko >

[PATCH v3 net-next] net:add one common config ARCH_WANT_RELAX_ORDER to support relax ordering

2017-01-17 Thread Mao Wenan
Relax ordering(RO) is one feature of 82599 NIC, to enable this feature can enhance the performance for some cpu architecure, such as SPARC and so on. Currently it only supports one special cpu architecture(SPARC) in 82599 driver to enable RO feature, this is not very common for other cpu

Darlehen angebot 3 %

2017-01-17 Thread Frau SCHMIDT
Sehr geehrte Damen und Herren, Haben Sie Interesse über einer finanziellen Darlehen zu 3%??? kontaktieren Sie mich für mehr Details und Bedingungen. ich kann all jenen helfen, wer ein Darlehen benötigen. Ich kann Ihnen biete ein darlehen in hohe von 10.000.000 Euro Meine mail:

linux-next: build warnings after merge of the net-next tree

2017-01-17 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced these warnings: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'init_one': drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:4646:9: warning: unused variable 'port_vec'

[PATCH] net: ethernet: ti: davinci_cpdma: correct check on NULL in set rate

2017-01-17 Thread Ivan Khoronzhuk
Check "ch" on NULL first, then get ctlr. Signed-off-by: Ivan Khoronzhuk --- Based on net-next/master drivers/net/ethernet/ti/davinci_cpdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c

[PATCH net] net: phy: bcm63xx: Utilize correct config_intr function

2017-01-17 Thread Florian Fainelli
From: Daniel Gonzalez Cabanelas Commit a1cba5613edf ("net: phy: Add Broadcom phy library for common interfaces") make the BCM63xx PHY driver utilize bcm_phy_config_intr() which would appear to do the right thing, except that it does not write to the MII_BCM63XX_IR register but

[PATCH RFC] net: dsa: remove unnecessary phy.h include

2017-01-17 Thread Russell King - ARM Linux
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
On 01/17/2017 04:07 PM, Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 2:04 AM, Florian Fainelli > wrote: >> On 01/17/2017 04:00 PM, Andy Shevchenko wrote: >>> On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli >>> wrote: On 01/17/2017 03:34

[PATCHv2 1/7] TAP: Refactoring macvtap.c

2017-01-17 Thread Sainath Grandhi
macvtap module has code for tap/queue management and link management. This patch splits the code into macvtap_main.c for link management and tap.c for tap/queue management. Functionality in tap.c can be re-used for implementing tap on other virtual interfaces. Signed-off-by: Sainath Grandhi

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Andy Shevchenko
On Wed, Jan 18, 2017 at 2:04 AM, Florian Fainelli wrote: > On 01/17/2017 04:00 PM, Andy Shevchenko wrote: >> On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli >> wrote: >>> On 01/17/2017 03:34 PM, Andy Shevchenko wrote: On Wed, Jan 18, 2017 at

[PATCHv2 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-01-17 Thread Sainath Grandhi
Tap character devices can be implemented on other virtual interfaces like ipvlan, similar to macvtap. Source code for tap functionality in macvtap can be re-used for this purpose. This patch series splits macvtap source into two modules, macvtap and tap. This patch series also includes a patch

[PATCHv2 4/7] TAP: Abstract type of virtual interface from tap implementation

2017-01-17 Thread Sainath Grandhi
macvlan object is re-structured to hold tap related elements in a separate entity, tap_dev. Upon NETDEV_REGISTER device_event, tap_dev is registered with idr and fetched again on tap_open. Few of the tap functions are modified to accepted tap_dev as argument. tap_dev object includes callbacks to

[PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

2017-01-17 Thread Sainath Grandhi
This patch adds a tap character device driver that is based on the IP-VLAN network interface, called ipvtap. An ipvtap device can be created in the same way as an ipvlan device, using 'type ipvtap', and then accessed using the tap user space interface. Signed-off-by: Sainath Grandhi

[PATCHv2 3/7] TAP: Tap character device creation/destroy API

2017-01-17 Thread Sainath Grandhi
This patch provides tap device create/destroy APIs in tap.c. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 29 +++-- drivers/net/tap.c | 63 ++ include/linux/if_tap.h | 5 +++-

[PATCHv2 2/7] TAP: Renaming tap related APIs, data structures, macros

2017-01-17 Thread Sainath Grandhi
Renaming tap related APIs, data structures and macros in tap.c from macvtap_.* to tap_.* Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 18 +-- drivers/net/tap.c | 332 ++--- drivers/vhost/net.c

[PATCHv2 6/7] TAP: tap as an independent module

2017-01-17 Thread Sainath Grandhi
This patch makes tap a separate module for other types of virtual interfaces, for example, ipvlan to use. Signed-off-by: Sainath Grandhi --- drivers/net/Kconfig | 15 +++ drivers/net/Makefile | 3 +--

[PATCHv2 5/7] TAP: Extending tap device create/destroy APIs

2017-01-17 Thread Sainath Grandhi
Extending tap APIs get/free_minor and create/destroy_cdev to handle more than one type of virtual interface. Signed-off-by: Sainath Grandhi --- drivers/net/macvtap_main.c | 6 +-- drivers/net/tap.c | 98 +++---

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
On 01/17/2017 04:00 PM, Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli > wrote: >> On 01/17/2017 03:34 PM, Andy Shevchenko wrote: >>> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli >>> wrote: > +static int

Recall: [PATCHv2 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-01-17 Thread Grandhi, Sainath
Grandhi, Sainath would like to recall the message, "[PATCHv2 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces".

[PATCHv2 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

2017-01-17 Thread Sainath Grandhi
Tap character devices can be implemented on other virtual interfaces like ipvlan, similar to macvtap. Source code for tap functionality in macvtap can be re-used for this purpose. This patch series splits macvtap source into two modules, macvtap and tap. This patch series also includes a patch

Re: Getting a handle on all these new NIC features

2017-01-17 Thread Florian Fainelli
On 01/17/2017 02:05 PM, Tom Herbert wrote: > I realize that backports of a driver is not a specific concern of the > Linux kernel, but nevertheless this is a real problem and a fact of > life for many users. Rebasing the full kernel is still a major effort > and it seems the best we could ever do

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Andy Shevchenko
On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli wrote: > On 01/17/2017 03:34 PM, Andy Shevchenko wrote: >> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli >> wrote: >>> +static int device_class_name_match(struct device *dev, void *class) >> >>

RE: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-17 Thread Grandhi, Sainath
Please find reply inline. > -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Friday, January 06, 2017 3:21 PM > To: Grandhi, Sainath > Cc: netdev ; David S. Miller > ;

[PATCH net-next 1/2] net: ipv6: remove nowait arg to rt6_fill_node

2017-01-17 Thread David Ahern
All callers of rt6_fill_node pass 0 for nowait arg. Remove the arg and simplify rt6_fill_node accordingly. rt6_fill_node passes the nowait of 0 to ip6mr_get_route. Remove the nowait arg from it as well. Signed-off-by: David Ahern --- include/linux/mroute6.h | 2 +-

[PATCH net-next 2/2] net: ipv6: remove prefix arg to rt6_fill_node

2017-01-17 Thread David Ahern
The prefix arg to rt6_fill_node is non-0 in only 1 path - rt6_dump_route where a user is requesting a prefix only dump. Simplify rt6_fill_node by removing the prefix arg and moving the prefix check to rt6_dump_route. Signed-off-by: David Ahern --- net/ipv6/route.c | 27

[PATCH net-next 0/2] net: ipv6: simplify rt6_fill_node

2017-01-17 Thread David Ahern
Remove a couple of unnecessary input arguments to rt6_fill_node. David Ahern (2): net: ipv6: remove nowait arg to rt6_fill_node net: ipv6: remove prefix arg to rt6_fill_node include/linux/mroute6.h | 2 +- net/ipv6/ip6mr.c| 9 ++--- net/ipv6/route.c| 46

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
On 01/17/2017 03:34 PM, Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli > wrote: >> Add a helper function to lookup a device reference given a class name. >> This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and >> make it more

RE: [PATCHv1 7/7] IPVTAP: IP-VLAN based tap driver

2017-01-17 Thread Grandhi, Sainath
> -Original Message- > From: Mahesh Bandewar (महेश बंडेवार) > [mailto:mahe...@google.com] > Sent: Friday, January 06, 2017 3:47 PM > To: Grandhi, Sainath > Cc: linux-netdev ; David Miller > ; mah...@bandewar.net;

RE: [PATCHv1 7/7] IPVTAP: IP-VLAN based tap driver

2017-01-17 Thread Grandhi, Sainath
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Friday, January 06, 2017 3:14 PM > To: Grandhi, Sainath > Cc: netdev@vger.kernel.org; da...@davemloft.net; > mah...@bandewar.net; linux-ker...@vger.kernel.org > Subject: Re:

Re: Getting a handle on all these new NIC features

2017-01-17 Thread Saeed Mahameed
On Wed, Jan 18, 2017 at 12:05 AM, Tom Herbert wrote: > There was some discussion about the problems of dealing with the > explosion of NIC features in the mlx directory restructuring proposal, > but I think the is a deeper issue here that should be discussed. > > It's hard

[PATCH net-next] lwtunnel: remove device arg to lwtunnel_build_state

2017-01-17 Thread David Ahern
Nothing about lwt state requires a device reference, so remove the input argument. Signed-off-by: David Ahern --- include/net/lwtunnel.h| 6 +++--- net/core/lwt_bpf.c| 2 +- net/core/lwtunnel.c | 4 ++-- net/ipv4/fib_semantics.c | 22

[PATCH net-next v4 06/10] net: dsa: Migrate to device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
Now that the base device driver code provides an identical implementation of dev_find_class() utilize device_find_in_class_name() instead of our own version of it. Signed-off-by: Florian Fainelli --- net/dsa/dsa.c | 22 ++ 1 file changed, 2

[PATCH net-next v4 02/10] net: dsa: Make most functions take a dsa_port argument

2017-01-17 Thread Florian Fainelli
In preparation for allowing platform data, and therefore no valid device_node pointer, make most DSA functions takes a pointer to a dsa_port structure whenever possible. While at it, introduce a dsa_port_is_valid() helper function which checks whether port->dn is NULL or not at the moment.

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Andy Shevchenko
On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli wrote: > Add a helper function to lookup a device reference given a class name. > This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and > make it more generic. > +static int device_class_name_match(struct

[PATCH net-next v4 07/10] net: Relocate dev_to_net_device() into net/core/dev.c

2017-01-17 Thread Florian Fainelli
dev_to_net_device() is moved from net/dsa/dsa.c to net/core/dev.c since it going to be used by net/dsa/dsa2.c and the namespace of the function justifies making it available to other users potentially. We also rename it to device_to_net_device() to better illustrate what it does since it is not

[PATCH net-next v4 04/10] net: dsa: Move ports assignment closer to error checking

2017-01-17 Thread Florian Fainelli
Move the assignment of ports in _dsa_register_switch() closer to where it is checked, no functional change. Re-order declarations to be preserve the inverted christmas tree style. Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH net-next v4 03/10] net: dsa: Suffix function manipulating device_node with _dn

2017-01-17 Thread Florian Fainelli
Make it clear that these functions take a device_node structure pointer Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index 6e3675220fef..04ab62251fe3

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-01-17 Thread Timur Tabi
On 10/24/2016 05:40 AM, Zefir Kurtisi wrote: As a result, if you ever see a warning '803x_aneg_done: SGMII link is not ok' you will end up having an Ethernet link up but won't get any data through. This should not happen, if it does, please contact the module maintainer. I am now seeing this:

[PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
Add a helper function to lookup a device reference given a class name. This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and make it more generic. Signed-off-by: Florian Fainelli --- drivers/base/core.c| 31 +++

[PATCH net-next v4 08/10] net: dsa: Add support for platform data

2017-01-17 Thread Florian Fainelli
Allow drivers to use the new DSA API with platform data. Most of the code in net/dsa/dsa2.c does not rely so much on device_nodes and can get the same information from platform_data instead. We purposely do not support distributed configurations with platform data, so drivers should be providing

[PATCH net-next v4 09/10] net: phy: Allow pre-declaration of MDIO devices

2017-01-17 Thread Florian Fainelli
Allow board support code to collect pre-declarations for MDIO devices by registering them with mdiobus_register_board_info(). SPI and I2C buses have a similar feature, we were missing this for MDIO devices, but this is particularly useful for e.g: MDIO-connected switches which need to provide

[PATCH net-next v4 10/10] ARM: orion: Register DSA switch as a MDIO device

2017-01-17 Thread Florian Fainelli
Utilize the ability to pass board specific MDIO bus information towards a particular MDIO device thus allowing us to provide the per-port switch layout to the Marvell 88E6XXX switch driver. Since we would end-up with conflicting registration paths, do not register the "dsa" platform device

[PATCH net-next v4 00/10] net: dsa: Support for pdata in dsa2

2017-01-17 Thread Florian Fainelli
Hi all, This is not exactly new, and was sent before, although back then, I did not have an user of the pre-declared MDIO board information, but now we do. Note that I have additional changes queued up to have b53 register platform data for MIPS bcm47xx and bcm63xx. Yes I know that we should

[PATCH net-next v4 01/10] net: dsa: Pass device pointer to dsa_register_switch

2017-01-17 Thread Florian Fainelli
In preparation for allowing dsa_register_switch() to be supplied with device/platform data, pass down a struct device pointer instead of a struct device_node. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 2 +- drivers/net/dsa/mv88e6xxx/chip.c |

Re: 52bd2d62ce6758d811edcbd2256eb9ea7f6a56cb fixing crashes? -> 4.4 stable?

2017-01-17 Thread Greg
On Tue, 2017-01-17 at 22:48 +0100, Nikola Ciprich wrote: > Dear netdev developers, > > I'd like to ask for a consultation regarding 4.4 kernel crashes. > we're using intel X540-AT2 10g controllers (onboard ones, on supermicro > boards) and we've noticed, then when using openvswitch, system very

Re: [PATCH net] lwtunnel: fix autoload of lwt modules

2017-01-17 Thread David Ahern
On 1/17/17 1:54 PM, David Miller wrote: > From: David Ahern > Date: Tue, 17 Jan 2017 13:46:22 -0700 > >> In short seems like removing the dev + the current patch dropping >> the lock fixes the current deadlock problem and should be fine. > > What about the state

Re: [PATCH] net: ethernet: stmmac: add ARP management

2017-01-17 Thread Andy Shevchenko
On Tue, Jan 17, 2017 at 6:56 PM, Christophe Roullier wrote: > +static int dwmac4_arp_enable(struct mac_device_info *hw) > +{ > + void __iomem *ioaddr = hw->pcsr; __iomem *config = hw->pcsr + GMAC_CONFIG; > + u32 value = readl(ioaddr + GMAC_CONFIG); > + >

RE: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

2017-01-17 Thread Grandhi, Sainath
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Friday, January 06, 2017 3:16 PM > To: Grandhi, Sainath > Cc: netdev@vger.kernel.org; da...@davemloft.net; > mah...@bandewar.net; linux-ker...@vger.kernel.org > Subject: Re:

[PATCH net v2] lwtunnel: fix autoload of lwt modules

2017-01-17 Thread David Ahern
Trying to add an mpls encap route when the MPLS modules are not loaded hangs. For example: CONFIG_MPLS=y CONFIG_NET_MPLS_GSO=m CONFIG_MPLS_ROUTING=m CONFIG_MPLS_IPTUNNEL=m $ ip route add 10.10.10.10/32 encap mpls 100 via inet 10.100.1.2 The ip command hangs: root 880

[net PATCH v5 5/6] virtio_net: refactor freeze/restore logic into virtnet reset logic

2017-01-17 Thread John Fastabend
For XDP we will need to reset the queues to allow for buffer headroom to be configured. In order to do this we need to essentially run the freeze()/restore() code path. Unfortunately the locking requirements between the freeze/restore and reset paths are different however so we can not simply

[net PATCH v5 6/6] virtio_net: XDP support for adjust_head

2017-01-17 Thread John Fastabend
Add support for XDP adjust head by allocating a 256B header region that XDP programs can grow into. This is only enabled when a XDP program is loaded. In order to ensure that we do not have to unwind queue headroom push queue setup below bpf_prog_add. It reads better to do a prog ref unwind vs

[net PATCH v5 4/6] virtio_net: remove duplicate queue pair binding in XDP

2017-01-17 Thread John Fastabend
Factor out qp assignment. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 6de0cbe..922ca66 100644 ---

[PATCH] Revert "net: qcom/emac: configure the external phy to allow pause frames"

2017-01-17 Thread Timur Tabi
This reverts commit 3e884493448131179a5b7cae1ddca1028ffaecc8. With commit 529ed1275263 ("net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause"), phylib now handles automatically enabling pause frame support in the PHY, and the MAC driver should follow suit. Since the EMAC driver driver

[net PATCH v5 0/6] virtio_net XDP fixes and adjust_header support

2017-01-17 Thread John Fastabend
This has a fix to handle small buffer free logic correctly and then also adds adjust head support. I pushed adjust head at net (even though its rc3) to avoid having to push another exception case into virtio_net to catch if the program uses adjust_head and then block it. If there are any strong

[net PATCH v5 3/6] virtio_net: factor out xdp handler for readability

2017-01-17 Thread John Fastabend
At this point the do_xdp_prog is mostly if/else branches handling the different modes of virtio_net. So remove it and handle running the program in the per mode handlers. Signed-off-by: John Fastabend --- drivers/net/virtio_net.c | 75

[net PATCH v5 2/6] virtio_net: wrap rtnl_lock in test for calling with lock already held

2017-01-17 Thread John Fastabend
For XDP use case and to allow ethtool reset tests it is useful to be able to use reset paths from contexts where rtnl lock is already held. This requries updating virtnet_set_queues and free_receive_bufs the two places where rtnl_lock is taken in virtio_net. To do this we use the following

[net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive

2017-01-17 Thread John Fastabend
In the small buffer case during driver unload we currently use put_page instead of dev_kfree_skb. Resolve this by adding a check for virtnet mode when checking XDP queue type. Also name the function so that the code reads correctly to match the additional check. Fixes: bb91accf2733 ("virtio-net:

Getting a handle on all these new NIC features

2017-01-17 Thread Tom Herbert
There was some discussion about the problems of dealing with the explosion of NIC features in the mlx directory restructuring proposal, but I think the is a deeper issue here that should be discussed. It's hard not to notice that there has been quite a proliferation of NIC features in several

52bd2d62ce6758d811edcbd2256eb9ea7f6a56cb fixing crashes? -> 4.4 stable?

2017-01-17 Thread Nikola Ciprich
Dear netdev developers, I'd like to ask for a consultation regarding 4.4 kernel crashes. we're using intel X540-AT2 10g controllers (onboard ones, on supermicro boards) and we've noticed, then when using openvswitch, system very quickly crashes on 4.4.x kernels we're usign. 4.5 is fine though.

Re: fs, net: deadlock between bind/splice on af_unix

2017-01-17 Thread Cong Wang
On Mon, Jan 16, 2017 at 1:32 AM, Dmitry Vyukov wrote: > On Fri, Dec 9, 2016 at 7:41 AM, Al Viro wrote: >> On Thu, Dec 08, 2016 at 10:32:00PM -0800, Cong Wang wrote: >> >>> > Why do we do autobind there, anyway, and why is it conditional on >>> >

Re: [PATCH net] lwtunnel: fix autoload of lwt modules

2017-01-17 Thread David Miller
From: David Ahern Date: Tue, 17 Jan 2017 13:46:22 -0700 > In short seems like removing the dev + the current patch dropping > the lock fixes the current deadlock problem and should be fine. What about the state recorded by fib_get_nhs() and similar? There is a mapping

Re: [PATCH net-next] tcp: accept RST for rcv_nxt - 1 after receiving a FIN

2017-01-17 Thread David Miller
From: Jason Baron Date: Tue, 17 Jan 2017 13:37:19 -0500 > From: Jason Baron > > Using a Mac OSX box as a client connecting to a Linux server, we have found > that when certain applications (such as 'ab'), are abruptly terminated > (via ^C), a FIN is sent

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-17 Thread Andy Lutomirski
On Tue, Jan 17, 2017 at 5:58 AM, Michal Hocko wrote: > On Tue 17-01-17 14:32:04, Peter Zijlstra wrote: >> On Tue, Jan 17, 2017 at 02:03:03PM +0100, Michal Hocko wrote: >> > On Sun 15-01-17 20:19:01, Tejun Heo wrote: >> > [...] >> > > So, what's proposed is a proper part of bpf.

Re: [PATCH] net: ethoc: Make needlessly global struct ethtool_ops static

2017-01-17 Thread David Miller
From: Tobias Klauser Date: Tue, 17 Jan 2017 15:01:08 +0100 > Make the needlessly global struct ethtool_ops ethoc_ethtool_ops static > to fix a sparse warning. > > Signed-off-by: Tobias Klauser Applied, thanks.

  1   2   3   >