[PATCH v1] net: phy: micrel: add KSZ8795 ethernet switch

2017-01-22 Thread Sean Nyekjaer
This is add support for the PHYs in the KSZ8795 5port managed switch. It will allow to detect the link between the switch and the soc and uses the same read_status functions as the KSZ8873MLL switch. This ethernet switch have unfortunately the same phy id as KSZ8051. Signed-off-by: Sean Nyekjaer

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jiri Pirko
Sun, Jan 22, 2017 at 09:25:50PM CET, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Introduce optional 128-bit action cookie. >Like all other cookie schemes in the networking world (eg in protocols >like http or existing kernel fib protocol field, etc) the idea is to save >user state that whe

Re: [PATCH 2/3] sh_eth: add missing EESIPR bits

2017-01-22 Thread Geert Uytterhoeven
On Sun, Jan 22, 2017 at 8:18 PM, Sergei Shtylyov wrote: > Renesas SH77{34|63} manuals describe more EESIPR bits than the current > driver. Declare the new bits with the end goal of using the bit names > instead of the bare numbers for the 'sh_eth_cpu_data::eesipr_value' > initializers... > > Si

Re: [PATCH 1/3] sh_eth: rename EESIPR bits

2017-01-22 Thread Geert Uytterhoeven
Hi Sergei, On Sun, Jan 22, 2017 at 8:18 PM, Sergei Shtylyov wrote: > Since the commit b0ca2a21f769 ("sh_eth: Add support of SH7763 to sh_eth") > the *enum* declaring the EESIPR bits (interrupt mask) went out of sync with > the *enum* declaring the EESR bits (interrupt status) WRT bit naming a

Re: [PATCH] net: phy: micrel: add KSZ8795 ethernet switch

2017-01-22 Thread Sean Nyekjær
On 2017-01-20 15:17, Andrew Lunn wrote: On Fri, Jan 20, 2017 at 01:50:49PM +0100, Sean Nyekjaer wrote: This ethernet switch have unfortunately the same phy id as KSZ8051. Hi Sean Please could you explain some more. You are adding PHY support here, not switch support. So is this to enable the

[PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread Jisheng Zhang
From: Jingju Hou From: Jingju Hou The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou Signed-off-by: Jisheng Zhang --- since v3: - really fix the build error since v2,v1: - using phy_dev member in struct net_device - add commi

[PATCH net] r8152: don't execute runtime suspend if the tx is not empty

2017-01-22 Thread Hayes Wang
Runtime suspend shouldn't be executed if the tx queue is not empty, because the device is not idle. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 0e99af0..e1466b

Re: [PATCH] net: stmicro: fix LS field mask in EEE configuration

2017-01-22 Thread Rayagond Kokatanur
Acked-by:Rayagond Kokatanur On Fri, Jan 20, 2017 at 9:30 PM, Joao Pinto wrote: > This patch fixes the LS mask when setting EEE timer. > LS field is 10 bits long and not 11 as currently. > > Signed-off-by: Joao Pinto > Reported-By: Rayagond Kokatanur > --- > drivers/net/ethernet/stmicro/stmmac

Re: [PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface

2017-01-22 Thread Florian Fainelli
On 01/22/2017 01:16 PM, Andrew Lunn wrote: > Remove the wrong !, otherwise we get false positives about having > multiple CPU interfaces. > > Fixes: b22de490869d ("net: dsa: store CPU switch structure in the tree") > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next 0/2] net: couple mdio_module_driver changes

2017-01-22 Thread Florian Fainelli
Hi David, Small patch series fixing a comment for mdio_module_driver and finally utilizing it in b53_mdio. Thanks! Florian Fainelli (2): net: phy: Fix typo for MDIO module boilerplate comment net: dsa: b53: Utilize mdio_module_driver drivers/net/dsa/b53/b53_mdio.c | 13 + inclu

[PATCH net-next 1/2] net: phy: Fix typo for MDIO module boilerplate comment

2017-01-22 Thread Florian Fainelli
The module boilerplate macro is named mdio_module_driver and not module_mdio_driver, fix that. Fixes: a9049e0c513c ("mdio: Add support for mdio drivers.") Signed-off-by: Florian Fainelli --- include/linux/mdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/md

[PATCH net-next 2/2] net: dsa: b53: Utilize mdio_module_driver

2017-01-22 Thread Florian Fainelli
Eliminate a bit of boilerplate code. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_mdio.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/dsa/b53/b53_mdio.c b/drivers/net/dsa/b53/b53_mdio.c index 477a16b5660a..fa7556f5d4fb 100644 --- a/

Re: [PATCH net-next] net: ipv6: ignore null_entry on route dumps

2017-01-22 Thread David Miller
David, please slow down. How is the NULL entry getting selected to be dumped and passed down here in the first place? The problem seems to be higher up in the chain here, don't just special case check for this in rt6_dump_route(). Thanks.

[PATCH net-next] net: ipv6: ignore null_entry on route dumps

2017-01-22 Thread David Ahern
lkp-robot reported a BUG: [ 10.151226] BUG: unable to handle kernel NULL pointer dereference at 0198 [ 10.152525] IP: rt6_fill_node+0x164/0x4b8 [ 10.153307] *pdpt = 12ee5001 *pde = [ 10.153309] [ 10.154492] Oops: [#1] [ 10.154987] CPU: 0 PID: 909 Comm:

RE: [PATCH v3 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread YUAN Linyu
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Jingju Hou > Sent: Monday, January 23, 2017 12:11 PM > To: da...@davemloft.net > Cc: jszh...@marvell.com; thomas.petazz...@free-electrons.com; > netdev@vger.kernel.org; Jingju Ho

Re: [PATCH net-next] net: ipv6: Check that idev is non-NULL in rt6_fill_node

2017-01-22 Thread David Ahern
On 1/22/17 9:32 PM, David Miller wrote: > From: David Ahern > Date: Sun, 22 Jan 2017 20:08:00 -0800 > >> The ipv6 route dump code passes ip6_null_entry to rt6_fill_node. > > Doesn't this fact cause you to take a pause? yes, it did. > > I can't see a legitimate reason to dump the null entry, i

Re: [PATCH net-next] net: ipv6: Check that idev is non-NULL in rt6_fill_node

2017-01-22 Thread David Miller
From: David Ahern Date: Sun, 22 Jan 2017 20:08:00 -0800 > The ipv6 route dump code passes ip6_null_entry to rt6_fill_node. Doesn't this fact cause you to take a pause? I can't see a legitimate reason to dump the null entry, it's a marker rather than a real entry.

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-22 Thread Alexei Starovoitov
On Thu, Jan 19, 2017 at 08:04:59PM -0800, Andy Lutomirski wrote: > On Thu, Jan 19, 2017 at 6:39 PM, Alexei Starovoitov > wrote: > > On Wed, Jan 18, 2017 at 06:29:22PM -0800, Andy Lutomirski wrote: > >> I think it could work by making a single socket cgroup controller that > >> handles all cgroup t

Re: [PATCH v3 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread David Miller
From: Jingju Hou Date: Mon, 23 Jan 2017 12:11:18 +0800 > The mvneta itself does not support WOL, but the PHY might. > So pass the calls to the PHY > > Signed-off-by: Jingju Hou > --- > Since v2: > - it should be phydev member not phy_dev > > drivers/net/ethernet/marvell/mvneta.c | 21

Re: [PATCHv2 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread David Miller
The same build error exists in all submissions of your patch. At this point you must absolutely reproduce this build failure yourself, and stop submitting this patch until you can test that the build failure is fixed.

[PATCH v3 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread Jingju Hou
The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou --- Since v2: - it should be phydev member not phy_dev drivers/net/ethernet/marvell/mvneta.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/e

[PATCH net-next] net: ipv6: Check that idev is non-NULL in rt6_fill_node

2017-01-22 Thread David Ahern
lkp-robot reported a BUG: [ 10.151226] BUG: unable to handle kernel NULL pointer dereference at 0198 [ 10.152525] IP: rt6_fill_node+0x164/0x4b8 [ 10.153307] *pdpt = 12ee5001 *pde = [ 10.153309] [ 10.154492] Oops: [#1] [ 10.154987] CPU: 0 PID: 909 Comm:

Re: [PATCHv2 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread kbuild test robot
Hi Jingju, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jingju-Hou/net-mvneta-implement-set_wol-and-get_wol/20170123-105218 config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.ker

Re: [PATCHv2 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread kbuild test robot
Hi Jingju, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jingju-Hou/net-mvneta-implement-set_wol-and-get_wol/20170123-105218 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 6.2.0 reproduce: wget https://git.ker

EPOLLERR on memory mapped netlink socket

2017-01-22 Thread prashantkumar dhotre
Hi experts, I am new to netlink sockets. In my app , I am getting EPOLLERR in epoll_wait() on netlink socket continuously. epoll just notifies that there is a read event on socket (it does not tell if it is read or epollerr). What could be cause of this and what EPOLLERR on memory mapped netlink s

Re: [PATCH v2 net-next] net: phy: marvell: Add Wake from LAN support for 88E1510 PHY

2017-01-22 Thread Jisheng Zhang
On Mon, 23 Jan 2017 10:58:15 +0800 wrote: > This is test on BG4CT platform with 88E1518 marvell PHY. > > Signed-off-by: Jingju Hou Reviewed-by: Jisheng Zhang > --- > Since v1: > - add some commit messages > > drivers/net/phy/marvell.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --gi

Re: [PATCH] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread Jisheng Zhang
Hi Jingju, On Mon, 23 Jan 2017 10:43:08 +0800 wrote: > The mvneta itself does not support WOL, but the PHY might. > So pass the calls to the PHY > > Signed-off-by: Jingju Hou > --- > Since v1: > - using phy_dev member in struct net_device I noticed that you send a new v2 patch. So this patch s

[PATCH v2 net-next] net: phy: marvell: Add Wake from LAN support for 88E1510 PHY

2017-01-22 Thread Jingju Hou
This is test on BG4CT platform with 88E1518 marvell PHY. Signed-off-by: Jingju Hou --- Since v1: - add some commit messages drivers/net/phy/marvell.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 0b78210..ed0d235 100644 --- a/d

Re: [PATCHv2 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread Jisheng Zhang
On Mon, 23 Jan 2017 10:44:07 +0800 Jingju Hou wrote: > The mvneta itself does not support WOL, but the PHY might. > So pass the calls to the PHY > > Signed-off-by: Jingju Hou Reviewed-by: Jisheng Zhang > --- > Since v1: > - using phy_dev member in struct net_device > > drivers/net/ethernet

[PATCHv2 net-next] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread Jingju Hou
The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou --- Since v1: - using phy_dev member in struct net_device drivers/net/ethernet/marvell/mvneta.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/ne

[PATCH] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread Jingju Hou
The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou --- Since v1: - using phy_dev member in struct net_device drivers/net/ethernet/marvell/mvneta.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/ne

Re: [RESEND PATCH net] macsec: fix validation failed in asynchronous operation.

2017-01-22 Thread Ryder Lee
Sorry for forgetting to explain it. The original patch was incomplete, but I sent it out by mistake... So please ignore it. On Sun, 2017-01-22 at 16:44 -0500, David Miller wrote: > Why are you resending this? > > The original posting on Jan 20th made it to the mailing list and is queued > up i

[lkp-robot] [net] a1a22c1206: BUG:unable_to_handle_kernel

2017-01-22 Thread kernel test robot
FYI, we noticed the following commit: commit: a1a22c12060e4b9c52f45d4b3460f614e00162a2 ("net: ipv6: Keep nexthop of multipath route on admin down") https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master in testcase: trinity with following parameters: runtime: 300s t

[PATCHv2 perf/core 3/7] tools lib bpf: Add set/is helpers for all prog types

2017-01-22 Thread Joe Stringer
These bpf_prog_types were exposed in the uapi but there were no corresponding functions to set these types for programs in libbpf. Signed-off-by: Joe Stringer Acked-by: Wang Nan --- v2: Add ack. --- tools/lib/bpf/libbpf.c | 5 + tools/lib/bpf/libbpf.h | 10 ++ 2 files changed, 15 i

[PATCHv2 perf/core 1/7] tools lib bpf: Fix map offsets in relocation

2017-01-22 Thread Joe Stringer
Commit 4708bbda5cb2 ("tools lib bpf: Fix maps resolution") attempted to fix map resolution by identifying the number of symbols that point to maps, and using this number to resolve each of the maps. However, during relocation the original definition of the map size was still in use. For up to two

[PATCHv2 perf/core 0/7] Libbpf improvements

2017-01-22 Thread Joe Stringer
Patch 1 fixes an issue when using drastically different BPF map definitions inside ELFs from a client using libbpf, vs the map definition libbpf uses. Patches 2-4 add some simple, useful helper functions for setting prog type and retrieving libbpf errors without depending on kernel headers from us

[PATCHv2 perf/core 2/7] tools lib bpf: Define prog_type fns with macro

2017-01-22 Thread Joe Stringer
Turning this into a macro allows future prog types to be added with a single line per type. Signed-off-by: Joe Stringer Acked-by: Wang Nan --- v2: Add ack. --- tools/lib/bpf/libbpf.c | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/

[PATCHv2 perf/core 5/7] tools lib bpf: Add bpf_program__pin()

2017-01-22 Thread Joe Stringer
Add a new API to pin a BPF program to the filesystem. The user can specify the path full path within a BPF filesystem to pin the program. Programs with multiple instances are pinned as 'foo', 'foo_1', 'foo_2', and so on. Signed-off-by: Joe Stringer --- v2: Don't automount BPF filesystem Split

[PATCHv2 perf/core 4/7] tools lib bpf: Add libbpf_get_error()

2017-01-22 Thread Joe Stringer
This function will turn a libbpf pointer into a standard error code (or 0 if the pointer is valid). This also allows removal of the dependency on linux/err.h in the public header file, which causes problems in userspace programs built against libbpf. Signed-off-by: Joe Stringer Acked-by: Wang Nan

[PATCHv2 perf/core 7/7] tools lib bpf: Add bpf_object__pin()

2017-01-22 Thread Joe Stringer
Add a new API to pin a BPF object to the filesystem. The user can specify the path full path within a BPF filesystem to pin the object. Programs will be pinned under a subdirectory 'progs', and maps will be pinned under a subdirectory 'maps'. For example, with the directory '/sys/fs/bpf/foo': /sys

[PATCHv2 perf/core 6/7] tools lib bpf: Add bpf_map__pin()

2017-01-22 Thread Joe Stringer
Add a new API to pin a BPF map to the filesystem. The user can specify the path full path within a BPF filesystem to pin the map. Signed-off-by: Joe Stringer --- v2: Don't automount BPF filesystem Split program, map, object pinning into separate APIs and separate patches. --- tools/lib/b

RE: [RFC PATCH net-next 4/5] bridge: vlan lwt and dst_metadata netlink support

2017-01-22 Thread Rosen, Rami
Hi, Roopa, Two minor comments: The parameter br is not used in the br_add_vlan_tunnel_info() method, it should be removed: +static int br_add_vlan_tunnel_info(struct net_bridge *br, + struct net_bridge_port *p, int cmd, + u16 vid

Re: [PATCH v4 3/3] samples/bpf: add lpm-trie benchmark

2017-01-22 Thread Alexei Starovoitov
On Sat, Jan 21, 2017 at 05:26:13PM +0100, Daniel Mack wrote: > From: David Herrmann > > Extend the map_perf_test_{user,kern}.c infrastructure to stress test > lpm-trie lookups. We hook into the kprobe on sys_gettid() and measure > the latency depending on trie size and lookup count. > > On my In

Re: [patch] samples/bpf: silence shift wrapping warning

2017-01-22 Thread Alexei Starovoitov
On Sat, Jan 21, 2017 at 07:51:43AM +0300, Dan Carpenter wrote: > max_key is a value in the 0-63 range, so on 32 bit systems the shift > could wrap. > > Signed-off-by: Dan Carpenter Looks fine. I think 'net-next' is ok. Acked-by: Alexei Starovoitov > diff --git a/samples/bpf/lwt_len_hist_user.

Re: [PATCH v4 2/3] bpf: Add tests for the lpm trie map

2017-01-22 Thread Alexei Starovoitov
On Sat, Jan 21, 2017 at 05:26:12PM +0100, Daniel Mack wrote: > From: David Herrmann > > The first part of this program runs randomized tests against the > lpm-bpf-map. It implements a "Trivial Longest Prefix Match" (tlpm) > based on simple, linear, single linked lists. The implementation > should

Re: [PATCH v4 1/3] bpf: add a longest prefix match trie map implementation

2017-01-22 Thread Alexei Starovoitov
On Sat, Jan 21, 2017 at 05:26:11PM +0100, Daniel Mack wrote: > This trie implements a longest prefix match algorithm that can be used > to match IP addresses to a stored set of ranges. > > Internally, data is stored in an unbalanced trie of nodes that has a > maximum height of n, where n is the pr

[PATCH net-next v5 2/2] net: stmmac: dwmac-meson8b: make the RGMII TX delay configurable

2017-01-22 Thread Martin Blumenstingl
Prior to this patch we were using a hardcoded RGMII TX clock delay of 2ns (= 1/4 cycle of the 125MHz RGMII TX clock). This value works for many boards, but unfortunately not for all (due to the way the actual circuit is designed, sometimes because the TX delay is enabled in the PHY, etc.). Making t

[PATCH net-next v5 1/2] net: dt-bindings: add RGMII TX delay configuration to meson8b-dwmac

2017-01-22 Thread Martin Blumenstingl
This allows configuring the RGMII TX clock delay. The RGMII clock is generated by underlying hardware of the the Meson 8b / GXBB DWMAC glue. The configuration depends on the actual hardware (no delay may be needed due to the design of the actual circuit, the PHY might add this delay, etc.). Signed

[PATCH net-next v5 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

2017-01-22 Thread Martin Blumenstingl
Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle (= 2ns) TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but there are some others where TX traffic is simply broken. There are probably multiple reasons why it's w

Re: [PATCH net-next 0/7] net: dsa: bcm_sf2: Add support for BCM7278

2017-01-22 Thread David Miller
From: Florian Fainelli Date: Fri, 20 Jan 2017 12:36:27 -0800 > This patch series adds support for the Broadcom BCM7278 integrated switch > which is a successor of the BCM7445 switch. We have a little bit of > register shuffling going on, which is why most of the functional changes > are to deal w

Re: [PATCH net-next 0/2] net: systemport: Add support for SYSTEMPORT lite

2017-01-22 Thread David Miller
From: Florian Fainelli Date: Fri, 20 Jan 2017 11:08:25 -0800 > This patch series adds support for SYSTEMPORT Lite which is an evolution > of the existing SYSTEMPORT adapter. > > The two generations are largely identical as far as the transmit/receive > path are concerned, and there were just a f

Re: [RESEND PATCH net] macsec: fix validation failed in asynchronous operation.

2017-01-22 Thread David Miller
Why are you resending this? The original posting on Jan 20th made it to the mailing list and is queued up in patchwork just fine. Also, regardless of the reason, a "RESEND" patch should always contain an explanation of why it needs to be resent. So that the maintainer doesn't need to ask questi

Re: [PATCH net v1 0/2] amd-xgbe: AMD XGBE driver fixes 2017-01-20

2017-01-22 Thread David Miller
From: Tom Lendacky Date: Fri, 20 Jan 2017 12:13:52 -0600 > This patch series addresses some issues in the AMD XGBE driver. > > The following fixes are included in this driver update series: > > - Add a fix for a version of the hardware that uses different register > offset values for a device

Re: [PATCH net-next] ipv6: add NUMA awareness to seg6_hmac_init_algo()

2017-01-22 Thread David Miller
From: Eric Dumazet Date: Fri, 20 Jan 2017 08:08:56 -0800 > From: Eric Dumazet > > Since we allocate per cpu storage, let's also use NUMA hints. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH] net: stmicro: fix LS field mask in EEE configuration

2017-01-22 Thread David Miller
From: Joao Pinto Date: Fri, 20 Jan 2017 16:00:26 + > This patch fixes the LS mask when setting EEE timer. > LS field is 10 bits long and not 11 as currently. > > Signed-off-by: Joao Pinto > Reported-By: Rayagond Kokatanur Please indicate the appropriate target tree of your patch in the su

Re: [PATCH] net/mlx4: use rb_entry()

2017-01-22 Thread David Miller
From: Leon Romanovsky Date: Sun, 22 Jan 2017 09:48:39 +0200 > I don't understand completely the rationale behind this conversion. > rb_entry == container_of, why do we need another name for it? Because it's an annotation. Either you agree that the macro exists and it should be used in every spo

Re: [PATCH] 6lowpan: use rb_entry()

2017-01-22 Thread David Miller
From: Geliang Tang Date: Fri, 20 Jan 2017 22:36:53 +0800 > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] net/mlx4: use rb_entry()

2017-01-22 Thread David Miller
From: Geliang Tang Date: Fri, 20 Jan 2017 22:36:57 +0800 > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang Applied.

[PATCH net-next] net: dsa: Fix inverted test for multiple CPU interface

2017-01-22 Thread Andrew Lunn
Remove the wrong !, otherwise we get false positives about having multiple CPU interfaces. Fixes: b22de490869d ("net: dsa: store CPU switch structure in the tree") Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net

[PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel _should not_ intepret

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
On 17-01-22 02:32 PM, Jiri Pirko wrote: Sun, Jan 22, 2017 at 07:57:17PM CET, j...@mojatatu.com wrote: On 17-01-22 01:13 PM, Florian Fainelli wrote: + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], +GFP_KERNEL); +

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jiri Pirko
Sun, Jan 22, 2017 at 07:57:17PM CET, j...@mojatatu.com wrote: >On 17-01-22 01:13 PM, Florian Fainelli wrote: >> >> > >> >> > + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], >> > + GFP_KERNEL); >> > + if (!a->act_cookie->data) { >

[PATCH 3/3] sh_eth: stop using bare numbers for EESIPR values

2017-01-22 Thread Sergei Shtylyov
Now that we have almost all EESIPR bits declared (and those that are still not are most probably reserved anyway) we can at last replace the bare numbers used for 'sh_eth_cpu_data::eesipr_value' initializers with the bit names ORed together... Signed-off-by: Sergei Shtylyov --- drivers/net/

[PATCH 2/3] sh_eth: add missing EESIPR bits

2017-01-22 Thread Sergei Shtylyov
Renesas SH77{34|63} manuals describe more EESIPR bits than the current driver. Declare the new bits with the end goal of using the bit names instead of the bare numbers for the 'sh_eth_cpu_data::eesipr_value' initializers... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_

[PATCH 1/3] sh_eth: rename EESIPR bits

2017-01-22 Thread Sergei Shtylyov
Since the commit b0ca2a21f769 ("sh_eth: Add support of SH7763 to sh_eth") the *enum* declaring the EESIPR bits (interrupt mask) went out of sync with the *enum* declaring the EESR bits (interrupt status) WRT bit naming and formatting. I'd like to restore the consistency by using EESIPR as the b

[PATCH 0/3] sh_eth: E-DMAC interrupt mask cleanups

2017-01-22 Thread Sergei Shtylyov
Hello. Here's a set of 3 patches against DaveM's 'net-next.git' repo. The main goal of this set is to stop using the bare numbers for the E-DMAC interrupt masks. [1/3] sh_eth: rename EESIPR bits [2/3] sh_eth: add missing EESIPR bits [3/3] sh_eth: stop using bare numbers for EESIPR values MBR,

Re: [PATCH] net/mlx4: use rb_entry()

2017-01-22 Thread Leon Romanovsky
On Sun, Jan 22, 2017 at 10:42:25PM +0800, Geliang Tang wrote: > On Sun, Jan 22, 2017 at 09:48:39AM +0200, Leon Romanovsky wrote: > > On Fri, Jan 20, 2017 at 10:36:57PM +0800, Geliang Tang wrote: > > > To make the code clearer, use rb_entry() instead of container_of() to > > > deal with rbtree. > >

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
On 17-01-22 01:13 PM, Florian Fainelli wrote: + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], +GFP_KERNEL); + if (!a->act_cookie->data) { + err = -ENOMEM; + tcf_ha

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-22 Thread Tom Herbert
On Sat, Jan 21, 2017 at 11:12 AM, kernel netdev wrote: > > > Den 21. jan. 2017 7.10 PM skrev "Tom Herbert" : > > On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed > wrote: >> On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet >> wrote: >>> From: Eric Dumazet >>> >>> A driver using dev_alloc_page() mu

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Florian Fainelli
On 01/22/2017 04:51 AM, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > Introduce optional 128-bit action cookie. > Like all other cookie schemes in the networking world (eg in protocols > like http or existing kernel fib protocol field, etc) the idea is to save > user state that when retr

Re: [PATCH net] net/mlx5e: Do not recycle pages from emergency reserve

2017-01-22 Thread Tom Herbert
On Sat, Jan 21, 2017 at 12:31 PM, Saeed Mahameed wrote: > On Sat, Jan 21, 2017 at 9:12 PM, kernel netdev wrote: >> >> >> Den 21. jan. 2017 7.10 PM skrev "Tom Herbert" : >> >> On Thu, Jan 19, 2017 at 11:14 AM, Saeed Mahameed >> wrote: >>> On Thu, Jan 19, 2017 at 9:03 AM, Eric Dumazet >>> wrote:

Re: [PATCH] Documentation: net: phy: improve explanation when to specify the PHY ID

2017-01-22 Thread Andrew Lunn
On Sun, Jan 22, 2017 at 05:41:32PM +0100, Martin Blumenstingl wrote: > The old description basically read like "ethernet-phy-id." can > be specified when you know the actual PHY ID. However, specifying this > has a side-effect: it forces Linux to bind to a certain PHY driver (the > one that

Re: [PATCH] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread Andrew Lunn
On Sun, Jan 22, 2017 at 06:06:30PM +0800, Jingju Hou wrote: > Signed-off-by: Jingju Hou Hi Jingju Please include a real comment here. Something like: The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY. It also looks like you are patching an old kernel. Netw

[PATCH] Documentation: net: phy: improve explanation when to specify the PHY ID

2017-01-22 Thread Martin Blumenstingl
The old description basically read like "ethernet-phy-id." can be specified when you know the actual PHY ID. However, specifying this has a side-effect: it forces Linux to bind to a certain PHY driver (the one that matches the ID given in the compatible string), ignoring the ID which is rep

RE: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics

2017-01-22 Thread Nogah Frankel
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, January 19, 2017 9:11 PM > To: Roopa Prabhu > Cc: Nogah Frankel ; netdev@vger.kernel.org; > roszenr...@gmail.com; Jiri Pirko ; Ido Schimmel > ; Elad Raz ; Yotam Gigi > ; Or Gerlitz > Subj

Re: [RFC PATCH net-next 4/5] bridge: vlan lwt and dst_metadata netlink support

2017-01-22 Thread Roopa Prabhu
On 1/22/17, 4:05 AM, Nikolay Aleksandrov wrote: > On 21/01/17 06:46, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch adds support to attach per vlan tunnel info dst >> metadata. This enables bridge driver to map vlan to tunnel_info >> at ingress and egress >> >> The initial use case is

Re: [RFC PATCH net-next 5/5] bridge: vlan lwt dst_metadata hooks in ingress and egress paths

2017-01-22 Thread Roopa Prabhu
On 1/22/17, 4:15 AM, Nikolay Aleksandrov wrote: > On 21/01/17 06:46, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> - ingress hook: >> - if port is a lwt tunnel port, use tunnel info in >> attached dst_metadata to map it to a local vlan >> - egress hook: >> - if port is a lwt tunnel

Re: [RFC PATCH net-next 2/5] vxlan: make COLLECT_METADATA mode bridge friendly

2017-01-22 Thread Roopa Prabhu
On 1/22/17, 3:40 AM, Nikolay Aleksandrov wrote: > On 21/01/17 06:46, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch series makes vxlan COLLECT_METADATA mode bridge >> and layer2 network friendly. Vxlan COLLECT_METADATA mode today >> solves the per-vni netdev scalability problem in l3 n

Re: [PATCH] net/mlx4: use rb_entry()

2017-01-22 Thread Geliang Tang
On Sun, Jan 22, 2017 at 09:48:39AM +0200, Leon Romanovsky wrote: > On Fri, Jan 20, 2017 at 10:36:57PM +0800, Geliang Tang wrote: > > To make the code clearer, use rb_entry() instead of container_of() to > > deal with rbtree. > > > > Signed-off-by: Geliang Tang > > --- > > drivers/net/ethernet/mel

Re: [patch net-next 2/4] net/sched: Introduce sample tc action

2017-01-22 Thread Roman Mashak
Jiri Pirko writes: > From: Yotam Gigi > > This action allows the user to sample traffic matched by tc classifier. > The sampling consists of choosing packets randomly and sampling them using > the psample module. The user can configure the psample group number, the > sampling rate and the packet

[PATCH iproute2 1/1] tc: distinguish Add/Replace action operations.

2017-01-22 Thread Roman Mashak
Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/m_action.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tc/m_action.c b/tc/m_action.c index bb19df8..05ef07e 100644 --- a/tc/m_action.c +++ b/tc/m_action.c @@ -365,12 +365,18 @@ int print_actio

RE: [patch net-next 2/4] net/sched: Introduce sample tc action

2017-01-22 Thread Yotam Gigi
>-Original Message- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Sunday, January 22, 2017 3:17 PM >To: Jiri Pirko ; netdev@vger.kernel.org >Cc: da...@davemloft.net; Yotam Gigi ; Ido Schimmel >; Elad Raz ; Nogah Frankel >; Or Gerlitz ; >geert+rene...@glider.be; step...@networkpl

Re: [net, 6/6] net: korina: version bump

2017-01-22 Thread Felix Fietkau
On 2017-01-22 13:10, Roman Yeryomin wrote: > On 17 January 2017 at 21:19, Roman Yeryomin wrote: >> On 17 January 2017 at 20:55, Felix Fietkau wrote: >>> On 2017-01-17 18:33, Roman Yeryomin wrote: Signed-off-by: Roman Yeryomin --- drivers/net/ethernet/korina.c | 4 ++-- 1 fil

Re: [patch net-next 1/4] net: Introduce psample, a new genetlink channel for packet sampling

2017-01-22 Thread Jamal Hadi Salim
On 17-01-22 06:44 AM, Jiri Pirko wrote: From: Yotam Gigi Add a general way for kernel modules to sample packets, without being tied to any specific subsystem. This netlink channel can be used by tc, iptables, etc. and allow to standardize packet sampling in the kernel. For every sampled packet

Re: [patch net-next 2/4] net/sched: Introduce sample tc action

2017-01-22 Thread Jamal Hadi Salim
On 17-01-22 06:44 AM, Jiri Pirko wrote: diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c new file mode 100644 index 000..24e20e4 --- /dev/null +++ b/net/sched/act_sample.c @@ -0,0 +1,274 @@ +/* + * net/sched/act_sample.c - Packet samplig tc action typo: "Sampling" +static in

Re: [PATCH net-next v5 0/1] Add support for tc cookies

2017-01-22 Thread Jamal Hadi Salim
I removed people's reviewed/Acked because i changed the data structure per Daniel's suggestions. cheers, jamal On 17-01-22 07:51 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Changes in V5: - kill the stylistic changes - Adopt a new structure with length-valuepointer representation - r

[PATCH net-next v5 1/1] net sched actions: Add support for user cookies

2017-01-22 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel _should not_ intepret

[PATCH net-next v5 0/1] Add support for tc cookies

2017-01-22 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Changes in V5: - kill the stylistic changes - Adopt a new structure with length-valuepointer representation - rename some things Changes in v4: - move stylistic changes out into a separate patch (and add more stylistic changes) Changes in v3: - use TC_ prefix for

Re: [PATCH net 1/1] net sched actions: fix refcnt when GETing of action after bind

2017-01-22 Thread Jamal Hadi Salim
On 17-01-20 01:20 AM, Cong Wang wrote: On Wed, Jan 18, 2017 at 3:33 AM, Jamal Hadi Salim wrote: On 17-01-17 01:17 PM, Cong Wang wrote: I did. The issue there (after your original patch) was destroy() would decrement the refcount to zero and a GET was essentially translated to a DEL. Increm

Re: [RFC PATCH net-next 5/5] bridge: vlan lwt dst_metadata hooks in ingress and egress paths

2017-01-22 Thread Nikolay Aleksandrov
On 21/01/17 06:46, Roopa Prabhu wrote: > From: Roopa Prabhu > > - ingress hook: > - if port is a lwt tunnel port, use tunnel info in > attached dst_metadata to map it to a local vlan > - egress hook: > - if port is a lwt tunnel port, use tunnel info attached to > vlan to set d

Re: [RFC PATCH net-next 4/5] bridge: vlan lwt and dst_metadata netlink support

2017-01-22 Thread Nikolay Aleksandrov
On 21/01/17 06:46, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds support to attach per vlan tunnel info dst > metadata. This enables bridge driver to map vlan to tunnel_info > at ingress and egress > > The initial use case is vlan to vni bridging, but the api is generic > to exten

Re: [net, 6/6] net: korina: version bump

2017-01-22 Thread Roman Yeryomin
On 17 January 2017 at 21:19, Roman Yeryomin wrote: > On 17 January 2017 at 20:55, Felix Fietkau wrote: >> On 2017-01-17 18:33, Roman Yeryomin wrote: >>> Signed-off-by: Roman Yeryomin >>> --- >>> drivers/net/ethernet/korina.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>>

Re: [patch net-next 4/4] mlxsw: spectrum: Add packet sample offloading support

2017-01-22 Thread Ido Schimmel
On Sun, Jan 22, 2017 at 12:44:47PM +0100, Jiri Pirko wrote: > From: Yotam Gigi > > Using the MPSC register, add the functions that configure port-based > packet sampling in hardware and the necessary datatypes in the > mlxsw_sp_port struct. In addition, add the necessary trap for sampled > packet

[patch net-next 4/4] mlxsw: spectrum: Add packet sample offloading support

2017-01-22 Thread Jiri Pirko
From: Yotam Gigi Using the MPSC register, add the functions that configure port-based packet sampling in hardware and the necessary datatypes in the mlxsw_sp_port struct. In addition, add the necessary trap for sampled packets and integrate with matchall offloading to allow offloading of the samp

[patch net-next 2/4] net/sched: Introduce sample tc action

2017-01-22 Thread Jiri Pirko
From: Yotam Gigi This action allows the user to sample traffic matched by tc classifier. The sampling consists of choosing packets randomly and sampling them using the psample module. The user can configure the psample group number, the sampling rate and the packet's truncation (to save kernel-us

[patch net-next 3/4] mlxsw: reg: add the Monitoring Packet Sampling Configuration Register

2017-01-22 Thread Jiri Pirko
From: Yotam Gigi The MPSC register allows to configure ingress packet sampling on specific port of the mlxsw device. The sampled packets are then trapped via PKT_SAMPLE trap. Signed-off-by: Yotam Gigi Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/

[patch net-next 1/4] net: Introduce psample, a new genetlink channel for packet sampling

2017-01-22 Thread Jiri Pirko
From: Yotam Gigi Add a general way for kernel modules to sample packets, without being tied to any specific subsystem. This netlink channel can be used by tc, iptables, etc. and allow to standardize packet sampling in the kernel. For every sampled packet, the psample module adds the following me

[patch net-next 0/4] Add support for offloading packet-sampling

2017-01-22 Thread Jiri Pirko
From: Jiri Pirko Yotam says: The first patch introduces the psample module, a netlink channel dedicated to packet sampling implemented using generic netlink. This module provides a generic way for kernel modules to sample packets, while not being tied to any specific subsystem like NFLOG. The s

Re: [RFC PATCH net-next 2/5] vxlan: make COLLECT_METADATA mode bridge friendly

2017-01-22 Thread Nikolay Aleksandrov
On 21/01/17 06:46, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch series makes vxlan COLLECT_METADATA mode bridge > and layer2 network friendly. Vxlan COLLECT_METADATA mode today > solves the per-vni netdev scalability problem in l3 networks. > When vxlan collect metadata device particip

Re: [PATCH] net: mvneta: implement .set_wol and .get_wol

2017-01-22 Thread kbuild test robot
-and-get_wol/20170122-181651 config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

  1   2   >