Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

David Miller wrote: > I guess this is fine, but I think you can use one of the two "sk_padding" > bits in struct sock instead of making the structure larger. It shouldn't make the structure larger since there's a hole in the structure: unsigned int

Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

From: David Howells Date: Mon, 06 Mar 2017 15:04:44 + > Fix the general case by: > > (1) Double up all the locking keys used in sockets so that one set are > used if the socket is created by userspace and the other set is used > if the socket is created by

[PATCH 2/5] rds: ib: replace spin_lock_irq with spin_lock_irqsave

It is difficult to make sure the state of the interrupt when this function is called. As such, it is safer to use spin_lock_irqsave than spin_lock_irq. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- net/rds/ib_cm.c |

[PATCH 3/5] rds: ib: remove redundant ib_dealloc_fmr

The function ib_dealloc_fmr will never be called. As such, it should be removed. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- net/rds/ib_fmr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 4/5] rds: ib: add the static type to the function

The function rds_ib_map_fmr is used only in the ib_fmr.c file. As such, the static type is added to limit it in this file. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- net/rds/ib_fmr.c | 5 +++-- net/rds/ib_mr.h |

[PATCH 1/5] rds: ib: drop unnecessary rdma_reject

When rdma_accept fails, rdma_reject is called in it. As such, it is not necessary to execute rdma_reject again. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- net/rds/ib_cm.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 5/5] rds: ib: unmap the scatter/gather list when error

When some errors occur, the scatter/gather list mapped to DMA addresses should be handled. Cc: Joe Jin Cc: Junxiao Bi Signed-off-by: Zhu Yanjun --- net/rds/ib_fmr.c | 26 +++--- 1 file changed, 19

RE: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > >

RE: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

> On 03/08/2017 08:49 AM, Reshetova, Elena wrote: > >> On 03/06/2017 09:21 AM, Elena Reshetova wrote: > >>> refcount_t type and corresponding API should be > >>> used instead of atomic_t when the variable is used as > >>> a reference counter. This allows to avoid accidental > >>> refcounter

Re: [patch net] mlxsw: spectrum_flower: Remove bogus warns in mlxsw_sp_flower_destroy

From: Jiri Pirko Date: Mon, 6 Mar 2017 21:22:09 +0100 > From: Jiri Pirko > > This warnings may be hit even in case they should not - in case user > puts a TC-flower rule which failed to be offloaded. So just remove them. > > Reported-by: Petr Machata

Re: [patch net-next 0/2] mlxsw: cosmetics

From: Jiri Pirko Date: Mon, 6 Mar 2017 21:25:19 +0100 > Couple of cosmetic mlxsw patches Series applied, thanks Jiri.

Re: [PATCH net-next] net: use proper lockdep annotation in __sk_dst_set()

From: Eric Dumazet Date: Mon, 06 Mar 2017 11:23:55 -0800 > From: Eric Dumazet > > __sk_dst_set() must be called while we own the socket. > > We can get proper lockdep coverage using lockdep_sock_is_held() > and rcu_dereference_protected() > >

Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

On Wed, Mar 08, 2017 at 02:40:25PM -0800, Jeff Kirsher wrote: > On Wed, 2017-03-08 at 17:19 +0100, Romain Perier wrote: > > The PCI pool API is deprecated. This commit replaces the PCI pool old > > API by the appropriate function with the DMA pool API. > > > > Signed-off-by: Romain Perier

Re: [PATCH v2] selinux: check for address length in selinux_socket_bind()

From: Alexander Potapenko Date: Mon, 6 Mar 2017 19:46:14 +0100 > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in selinux_socket_bind(): ... > (the line numbers are relative to 4.8-rc6, but the bug persists upstream) > > ,

Re: [PATCH] vrf: Fix use-after-free in vrf_xmit

From: David Ahern Date: Mon, 6 Mar 2017 08:53:04 -0800 > KASAN detected a use-after-free: > > [ 269.467067] BUG: KASAN: use-after-free in vrf_xmit+0x7f1/0x827 [vrf] at > addr 8800350a21c0 > [ 269.467067] Read of size 4 by task ssh/1879 > [ 269.467067] CPU: 1

Re: [patch net-next 0/5] flow dissector improvements

From: Jiri Pirko Date: Mon, 6 Mar 2017 16:39:50 +0100 > This patchset follows-up the discussion about future extensions of flow > dissector and tries to address the mentioned concerns. Some parts are > cut out into sub-functions. Also, the processing of the code (ARP, MPLS) >

Re: [PATCH] net: ibm: emac: fix regression caused by emac_dt_phy_probe()

From: Christian Lamparter Date: Mon, 6 Mar 2017 14:34:27 +0100 > Julian Margetson reported a panic on his SAM460EX with Kernel 4.11-rc1: ... > The problem is caused by emac_dt_phy_probe() returing success (0) > for existing device-trees configurations that do not

Re: [PATCH net] team: use ETH_MAX_MTU as max mtu

From: Jarod Wilson Date: Mon, 6 Mar 2017 08:48:58 -0500 > This restores the ability to set a team device's mtu to anything higher > than 1500. Similar to the reported issue with bonding, the team driver > calls ether_setup(), which sets an initial max_mtu of 1500, while the >

Re: [PATCH] net: toshiba: spider_net: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 5 Mar 2017 23:46:00 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: toshiba: ps3_genic_net: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 5 Mar 2017 23:21:06 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sun: cassini: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sat, 4 Mar 2017 16:16:12 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sun: sunhme: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 5 Mar 2017 22:25:39 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sun: sungem: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sun, 5 Mar 2017 00:04:18 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sun: niu: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sat, 4 Mar 2017 17:50:06 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: smsc: smc911x: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Tue, 28 Feb 2017 23:49:38 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Sat, 4 Mar 2017 12:42:39 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH net-next 0/5] sunvnet: better connection management

From: Shannon Nelson Date: Wed, 8 Mar 2017 15:04:45 -0800 > On 3/6/2017 3:15 PM, Shannon Nelson wrote: >> These patches remove some problems in handling of carrier state >> with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and >> add stats for debug and

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

On Wed, Mar 8, 2017 at 3:55 PM, Laura Abbott wrote: > On 03/08/2017 02:36 PM, Kees Cook wrote: >> On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote: >>> [ 28.474232] rodata_test: test data was not read only >>> [...] >> >> In my tests so far, I've

Re: [PATCH net] dccp/tcp: fix routing redirect race

On Thu, Mar 9, 2017 at 3:40 PM, Eric Dumazet wrote: > On Thu, 2017-03-09 at 14:42 +1100, Jonathan Maxwell wrote: >> Sorry let me resend in plain text mode. >> >> On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote: >> > On Thu, 2017-03-09 at 12:15

Re: [PATCH net] dccp/tcp: fix routing redirect race

On Thu, 2017-03-09 at 14:42 +1100, Jonathan Maxwell wrote: > Sorry let me resend in plain text mode. > > On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote: > > On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote: > >> We have seen a few incidents lately where a dst_enty

EINVAL when using connect() for udp sockets

When debugging https://github.com/daurnimator/lua-http/issues/73 which uses https://github.com/wahern/dns we ran into an issue where modern linux kernels return EINVAL if you try and re-use a udp socket. The issue seems to occur if you go from a local destination ip to a non-local one. >From

Re: [PATCH net] dccp/tcp: fix routing redirect race

Sorry let me resend in plain text mode. On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote: > On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote: >> We have seen a few incidents lately where a dst_enty has been freed >> with a dangling TCP socket reference

Re: [PATCH net] dccp/tcp: fix routing redirect race

On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote: > We have seen a few incidents lately where a dst_enty has been freed > with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that > dst_entry. If the conditions/timings are right a crash then ensues when the > freed dst_entry is

[PATCH] Fix bug while selecting sysfs node size

From: Lev Urusov The driver will not be able to take into account the correct number of device SPI registers if it is not equal to 128. Signed-off-by: Lev Urusov --- drivers/net/phy/spi_ks8995.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH iproute2 master] bpf: test for valid type in bpf_get_work_dir

On Mon, 6 Mar 2017 13:06:00 +0100 Daniel Borkmann wrote: > Jan-Erik reported an assertion in bpf_prog_to_subdir() failed where > type was BPF_PROG_TYPE_UNSPEC, which is only used in bpf_init_env() > to auto-mount and cache the bpf fs mount point. > > Therefore, make sure

Re: [PATCH iproute2 net-next] devlink: Add json and pretty options to help and man

On Mon, 6 Mar 2017 11:06:18 +0200 Roi Dayan wrote: > While at it also fixed missing double dash for long opts. > > Signed-off-by: Roi Dayan Applied to master (for 4.11) this doesn't have to wait until net-next (4.12)

Re: [PATCH] Fix bug while selecting sysfs node size

On 03/08/2017 05:43 PM, Lev Urusov wrote: > From: Lev Urusov > > The driver will not be able to take into account the correct number > of device SPI registers if it is not equal to 128. You would want to fix a couple of things with this patchset, since you are fixing a bug,

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

On Wed, Mar 08, 2017 at 02:43:44PM -0800, Linus Torvalds wrote: On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote: The issue seems to be accessing buff first (can be read or write access) and then doing set_memory_ro() doesn't make it read-only immediately, meaning

[PATCH net] dccp/tcp: fix routing redirect race

We have seen a few incidents lately where a dst_enty has been freed with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that dst_entry. If the conditions/timings are right a crash then ensues when the freed dst_entry is referenced later on. A Common crashing back trace is: #8 []

[PATCH] net: ks8851: Added support for half-duplex SPI

In original driver was implemented support for half- and full-duplex modes, but it was not enabled. Instead of it ks8851_rx_1msg method always returns "true" that means "full-duplex" mode. This patch replaces hard-coded functionality with flexible solution that supports both SPI modes.

HELLO DEAR

Dear Friend, I assume that this message will reach you in good health. My name is Mrs. Aruna Sabbah,the foreign operation manager of the African Development Bank Burkina Faso (ADB) I have the opportunity of transferring the left over funds what of ($25.2Million Dollars) from the account of our

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

On 03/08/2017 02:36 PM, Kees Cook wrote: > On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote: >> [ 28.474232] rodata_test: test data was not read only >> [...] > > In my tests so far, I've never been able to get rodata_test to fail > (Qemu 2.5.0, Ubuntu). I'll retry

Re: [PATCH next 0/5] bonding: winter cleanup

Mahesh Bandewar wrote: >From: Mahesh Bandewar > >Few cleanup patches that I have accumulated over some time now. > >(a) First two patches are basically to move the work-queue initialization >from every ndo_open / bond_open operation to once at the

Re: [PATCH] tun: remove copyright printing

On Wed, 8 Mar 2017 16:46:57 +0100 Corentin Labbe wrote: > Printing copyright does not give any useful information on the boot > process. > Furthermore, the email address printed is obsolete since > commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries") > >

[PATCH net 3/4] bnxt_en: Check if firmware LLDP agent is running.

Set DCB_CAP_DCBX_HOST capability flag only if the firmware LLDP agent is not running. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +

[PATCH net 2/4] bnxt_en: Call bnxt_ulp_stop() during tx timeout.

If we call bnxt_reset_task() due to tx timeout, we should call bnxt_ulp_stop() to inform the RDMA driver about the error and the impending reset. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++- 1 file changed, 7 insertions(+), 1

[PATCH net 4/4] bnxt_en: Ignore 0 value in autoneg supported speed from firmware.

In some situations, the firmware will return 0 for autoneg supported speed. This may happen if the firmware detects no SFP module, for example. The driver should ignore this so that we don't end up with an invalid autoneg setting with nothing advertised. When SFP module is inserted, we'll get

[PATCH net 1/4] bnxt_en: Perform function reset earlier during probe.

The firmware call to do function reset is done too late. It is causing the rings that have been reserved to be freed. In NPAR mode, this bug is causing us to run out of rings. Fixes: 391be5c27364 ("bnxt_en: Implement new scheme to reserve tx rings.") Signed-off-by: Michael Chan

[PATCH net 0/4] bnxt_en: Misc. small fixes.

Fixes include moving the initial function reset, notifying the RDMA driver during tx timeout, setting dcbx_cap properly depending on whether the firmware agent is running or not, and an autoneg related improvement. Michael Chan (4): bnxt_en: Perform function reset earlier during probe.

[PATCH net-next v2] net: ipv6: Add early demux handler for UDP unicast

While running a single stream UDPv6 test, we observed that amount of CPU spent in NET_RX softirq was much greater than UDPv4 for an equivalent receive rate. The test here was run on an ARM64 based Android system. On further analysis with perf, we found that UDPv6 was spending significant time in

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

On 03/08/2017 11:36 PM, Kees Cook wrote: On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote: [ 28.474232] rodata_test: test data was not read only [...] In my tests so far, I've never been able to get rodata_test to fail (Qemu 2.5.0, Ubuntu). I'll retry with your

Re: [PATCH net-next 0/5] sunvnet: better connection management

On 3/6/2017 3:15 PM, Shannon Nelson wrote: These patches remove some problems in handling of carrier state with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and add stats for debug and tracking of point-to-point connections between the ldom VMs. Further testing shows a problem in one

Re: [Intel-wired-lan] Question on ixgbe flow director

On 03/08/2017 01:03 PM, Alexander Duyck wrote: On Wed, Mar 8, 2017 at 11:30 AM, tndave wrote: On 03/08/2017 07:39 AM, Alexander Duyck wrote: On Tue, Mar 7, 2017 at 3:43 PM, tndave wrote: Hi, I have few questions regarding ixgbe flow

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote: > > The issue seems to be accessing buff first (can be read or write access) > and then doing set_memory_ro() doesn't make it read-only immediately, > meaning the subsequent call into probe_kernel_write() will succeed

[PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

The fjes driver is used only by FUJITSU servers and almost of all servers in the world never use it. But currently if ACPI PNP0C02 is defined in the ACPI table, the following message is always shown: "FUJITSU Extended Socket Network Device Driver - version 1.2 - Copyright (c) 2015 FUJITSU

Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

On Wed, 2017-03-08 at 17:19 +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Acked-by: Peter Senna Tschudin

[PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/hyperv/netvsc_drv.c | 39

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote: > [ 28.474232] rodata_test: test data was not read only > [...] In my tests so far, I've never been able to get rodata_test to fail (Qemu 2.5.0, Ubuntu). I'll retry with your .config and see if I can recheck under

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

[ + Kees, Laura, and Dave ] On 03/08/2017 08:25 PM, Linus Torvalds wrote: Adding x86 people too, since this seems to be something off about ARCH_HAS_SET_MEMORY for x86-32. The code seems to be shared between x86-32 and 64, I'm not seeing why set_memory_r[ow]() should fail on one but not the

[PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

When the aquantia device mtu is changed the net_device structure is not updated. As a result the ip command does not properly reflect the mtu change. Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the assignment ndev->mtu = new_mtu; This is not true in the case where

Re: [PATCH net-next 1/1] net: rmnet_data: Initial implementation

Inside the kernel you should use "u32", "u16", "u8", etc. for purely internal things, and for datastructures exported to userspace you should use "__u32", "__u16", "__u8". Furthermore, if the members have specific endianness you should properly use the "__le32", "__le16", "__be32", "__be16" etc.

[PATCH] net: fjes: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/fjes/fjes_ethtool.c | 19

Re: [Intel-wired-lan] Question on ixgbe flow director

On Wed, Mar 8, 2017 at 11:30 AM, tndave wrote: > > > On 03/08/2017 07:39 AM, Alexander Duyck wrote: >> >> On Tue, Mar 7, 2017 at 3:43 PM, tndave >> wrote: >>> >>> Hi, >>> >>> I have few questions regarding ixgbe flow director. As per my >>>

Re: [Intel-wired-lan] Question on ixgbe flow director

On 03/08/2017 07:39 AM, Alexander Duyck wrote: On Tue, Mar 7, 2017 at 3:43 PM, tndave wrote: Hi, I have few questions regarding ixgbe flow director. As per my understanding flow director in ixgbe can work in 2 exclusive ways, a. Using ATR filters - where flow

Re: [PATCH net] bpf: disable broken write protection on i386

On 03/08/2017 07:40 PM, Kees Cook wrote: On Mon, Mar 6, 2017 at 10:11 AM, Kees Cook wrote: On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote: Latter shows that memory protecting the kernel seems not working either on i386 (!). Test suite

[PATCH] net: via: via-velocity: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/via/via-velocity.c | 62

tun offloads bug

Hello! I've found a bug in TUN/TAP driver with offloads - when Qemu is trying to set offloads on tap device, there is no error, but offloads are not appied. The cause of this is that udev in recent systemd is using ethtool to disable offloads. So, udev is setting tun->dev->wanted_features via

Re: [PATCH] fjes: Do not load fjes driver if system does not have extended socket device.

Hi David, On 03/07/2017 04:44 PM, David Miller wrote: From: Yasuaki Ishimatsu Date: Thu, 2 Mar 2017 11:56:44 -0500 + /* fjes_init_module - Driver Registration Routine */ static int __init fjes_init_module(void) { int result; + bool found = false; +

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

On Wed, 2017-03-08 at 12:11 -0700, Subash Abhinov Kasiviswanathan wrote: > On 2017-03-08 11:40, Eric Dumazet wrote: > > Well, this 'optimization' actually hurts when UDP sockets are not > > connected, since this adds an extra cache line miss per incoming > > packet. > > > > (DNS servers for

[PATCH next 0/5] bonding: winter cleanup

From: Mahesh Bandewar Few cleanup patches that I have accumulated over some time now. (a) First two patches are basically to move the work-queue initialization from every ndo_open / bond_open operation to once at the beginning while port creation. Work-queue

Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf

Adding x86 people too, since this seems to be something off about ARCH_HAS_SET_MEMORY for x86-32. The code seems to be shared between x86-32 and 64, I'm not seeing why set_memory_r[ow]() should fail on one but not the other. Considering that it seems to be flaky even on 32-bit, maybe it's

Re: [PATCH net-next 3/8] net: stmicro: configure tx queue weight

From: Joao Pinto Date: Wed, 8 Mar 2017 11:03:10 + > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index af57f8d..df3b1ee 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++

Re: [PATCH net-next 2/8] net: stmicro: configure mtl rx and tx algorithms

From: Joao Pinto Date: Wed, 8 Mar 2017 11:03:09 + > This patch adds the RX and TX scheduling algorithms programming. > It introduces the multiple queues configuration function > (stmmac_mtl_configuration) in stmmac_main. > > Signed-off-by: Joao Pinto

Re: [PATCH net-next 7/8] net: stmicro: prepare irq_status for mtl

From: Joao Pinto Date: Wed, 8 Mar 2017 11:03:14 + > +static int dwmac4_irq_mtl_status(struct mac_device_info *hw, u32 chan) > +{ > + void __iomem *ioaddr = hw->pcsr; > + u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS); > + int ret = 0; Please

Re: please add some examples to the ip man page

I see. Perhaps on the man page add EXAMPLES See https://www.kernel.org/doc/Documentation/networking/vrf.txt https://www.google.com/search?q=ip+linux+command+usage+examples (I thought the latter would be hopeless, but actually found lots!)

[PATCH next 2/5] bonding: initialize work-queues during creation of bond

From: Mahesh Bandewar Initializing work-queues every time ifup operation performed is unnecessary and can be performed only once when the port is created. Signed-off-by: Mahesh Bandewar --- drivers/net/bonding/bond_main.c | 4 ++-- 1 file changed, 2

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

On 2017-03-08 11:40, Eric Dumazet wrote: Well, this 'optimization' actually hurts when UDP sockets are not connected, since this adds an extra cache line miss per incoming packet. (DNS servers for example) Hi Eric Thanks for your comments. Would it be preferable to disable early demux for

Re: wireless/atmel: remove time_t usage

Alexandre Belloni writes: > Hi, > > On 08/03/2017 at 15:13:40 +, Kalle Valo wrote: >> Alexandre Belloni wrote: >> > last_qual never really holds a time. It only holds jiffies. Make it the >> > same type as jiffies.

[PATCH next 1/5] bonding: restructure arp-monitor

From: Mahesh Bandewar In preparation to move the work-queue initialization to port creation from current port_open phase. Work-queue initialization does not make sense every time we do 'ifup/ifdown'. So moving to port creation phase. Arp monitoring work depends on the

[PATCH next 4/5] bonding: remove "port-moved" state that was never implemented

From: Mahesh Bandewar LACP state-machine defines "port-moved" state when the same ActorSystemID and Port are seen in a LACPDU received on different port. The state is never set since it's not implemented. However the state-machine attempts to clear that state occasionally.

[PATCH next 5/5] bonding: reduce scope of some global variables

From: Mahesh Bandewar Many of the bond param variables are declared global while it's not really necessary for these variables to be global. So moving them to the location these are used. Signed-off-by: Mahesh Bandewar ---

[PATCH next 3/5] bonding: remove hardcoded value

From: Mahesh Bandewar Eliminate hard-coded value and use the default that is set. Signed-off-by: Mahesh Bandewar --- drivers/net/bonding/bond_main.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

While running a single stream UDPv6 test, we observed that amount of CPU spent in NET_RX softirq was much greater than UDPv4 for an equivalent receive rate. The test here was run on an ARM64 based Android system. On further analysis with perf, we found that UDPv6 was spending significant time in

Re: [PATCH net-next] net: ipv6: Add early demux handler for UDP unicast

On Wed, 2017-03-08 at 11:24 -0700, Subash Abhinov Kasiviswanathan wrote: > While running a single stream UDPv6 test, we observed that amount > of CPU spent in NET_RX softirq was much greater than UDPv4 for an > equivalent receive rate. The test here was run on an ARM64 based > Android system. On

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

Re: [PATCH net] bpf: disable broken write protection on i386

On Mon, Mar 6, 2017 at 10:11 AM, Kees Cook wrote: > On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote: >> Latter shows that memory protecting the kernel seems not working either >> on i386 (!). Test suite output: >> >> [...] >> [ 12.692836]

Re: linux-next: build failure after merge of the rcu tree

On Wed, Mar 08, 2017 at 12:16:05PM +1100, Stephen Rothwell wrote: > Hi Paul, > > On Mon, 13 Feb 2017 17:43:24 +1100 Stephen Rothwell > wrote: > > > > On Sun, 12 Feb 2017 20:37:48 -0800 "Paul E. McKenney" > > wrote: > > > > > > I chickened out

Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

On 03/08/2017 08:49 AM, Reshetova, Elena wrote: >> On 03/06/2017 09:21 AM, Elena Reshetova wrote: >>> refcount_t type and corresponding API should be >>> used instead of atomic_t when the variable is used as >>> a reference counter. This allows to avoid accidental >>> refcounter overflows that

Re: [net] netfilter: nat: sctp: fix ICMP packet to be dropped accidently

On Sat, Mar 04, 2017 at 06:00:02PM +0800, Ying Xue wrote: > Regarding RFC 792, the first 64 bits of the original SCTP datagram's > data could be contained in ICMP packet, such as: > > 0 1 2 3 > 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0

[PATCH v2] net: initialize msg.msg_flags in recvfrom

KMSAN reports a use of uninitialized memory in put_cmsg() because msg.msg_flags in recvfrom haven't been initialized properly. The flag values don't affect the result on this path, but it's still a good idea to initialize them explicitly. Signed-off-by: Alexander Potapenko ---

Re: [PATCH net-next] net/socket: use per af lockdep classes for sk queues

On Wed, 2017-03-08 at 17:25 +0100, Paolo Abeni wrote: > - no changes, tested with several different workload > > Suggested-by: Cong Wang > Signed-off-by: Paolo Abeni > --- > net/core/sock.c | 96 >

[PATCH net-next 6/9] nfp: store device pointer for the fastpath

We really only need the device pointer on the fast path, stash it at the beginning of the adapter structure and move pci_dev pointer down. This saves up a few lines of code. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 6

[PATCH net-next 3/9] nfp: implement .ndo_get_phys_port_name()

NSP reports to us port labels. First id is the id of the physical port, the other one tells us which logical interface is it within a split port. Instead of printing them as string keep them in integer format. Compute which interfaces are part of port split. On netdev side use port labels and

[PATCH net-next 2/9] nfp: add support for reporting CRC32 hash function

Some firmware images may reuse CRC32 hardware to compute RXHASH. Make sure we report the correct hash function. Note that we don't support changing functions at runtime. That would also require a few more additions to the way the key is set because different functions have different key sizes.

[PATCH net-next 7/9] nfp: avoid rearming the interrupts when in busy poll

Make use of return code from napi_complete_done() to avoid rearming interrupts when busy polling is on. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 5/9] nfp: reorder variables in nfp_net_tx()

Reorder variables longest to shortest to comply with netdev coding style. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH net-next 1/9] ethtool: add CRC32 as an RSS hash function

CRC32 engines are usually easily available in hardware and generate OK spread for RSS hash. Add CRC32 RSS hash function to ethtool API. Signed-off-by: Jakub Kicinski --- include/linux/ethtool.h | 2 ++ net/core/ethtool.c | 1 + 2 files changed, 3

[PATCH net-next 4/9] nfp: move more ring debug info to debugfs

We already print most of ring configuration including descriptors in debugfs, add the few missing pieces and remove debug prints. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 9 -

[PATCH net-next 8/9] nfp: add metadata format bit

We only need FW version in the first cache line of adapter struct because we need to know the metadata format. To save space add a metadata format bit. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 2 ++

[PATCH net-next 9/9] nfp: prevent theoretical buffer overrun in nfp_eth_read_ports

From: Simon Horman Prevent theoretical buffer overrun by returning an error if the number of entries returned by the firmware does not match those present. Also use a common handling error path. Found by inspection. Signed-off-by: Simon Horman

  1   2   >