Re: [patch -next] net: dwc-xlgmac: fix an error code in xlgmac_alloc_pages()

2017-03-21 Thread Jie Deng
On 2017/3/22 4:42, Dan Carpenter wrote: > The dma_mapping_error() returns true if there is an error but we want > to return -ENOMEM and not 1. > > Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare > Enterprise Ethernet") > Signed-off-by: Dan Carpenter

[PATCH net-next v3] net: Add sysctl to toggle early demux for tcp and udp

2017-03-21 Thread Subash Abhinov Kasiviswanathan
Certain system process significant unconnected UDP workload. It would be preferrable to disable UDP early demux for those systems and enable it for TCP only. By disabling UDP demux, we see these slight gains on an ARM64 system- 782 -> 788Mbps unconnected single stream UDPv4 633 -> 654Mbps

Re: [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing

2017-03-21 Thread Jason Wang
On 2017年03月21日 18:25, Sergei Shtylyov wrote: Hello! On 3/21/2017 7:04 AM, Jason Wang wrote: Signed-off-by: Jason Wang --- include/linux/ptr_ring.h | 65 1 file changed, 65 insertions(+) diff --git

[PATCH net] ipv4: provide stronger user input validation in nl_fib_input()

2017-03-21 Thread Eric Dumazet
From: Eric Dumazet Alexander reported a KMSAN splat caused by reads of uninitialized field (tb_id_in) from user provided struct fib_result_nl It turns out nl_fib_input() sanity tests on user input is a bit wrong : User can pretend nlh->nlmsg_len is big enough, but provide

[PATCH net] bpf: fix hashmap extra_elems logic

2017-03-21 Thread Alexei Starovoitov
In both kmalloc and prealloc mode the bpf_map_update_elem() is using per-cpu extra_elems to do atomic update when the map is full. There are two issues with it. The logic can be misused, since it allows max_entries+num_cpus elements to be present in the map. And alloc_extra_elems() at map creation

[PATCH] netfilter: ipset: print out warnings generated by commands

2017-03-21 Thread Vishwanath Pai
Warnings are only printed out for IPSET_CMD_TEST. The user won't see warnings from other commands. Reviewed-by: Josh Hunt Signed-off-by: Vishwanath Pai --- src/ipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipset.c

[PATCH 1/2] netfilter: ipset: warn users of list:set that parameter 'size' is ignored

2017-03-21 Thread Vishwanath Pai
Since kernel commit 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type"), the parameter 'size' has not been in use and is ignored by the kernel. This is not very apparent to the user. This commit makes 'size' optional and also warns the user if they try to specify it. We also

Re: [PATCH 3/4] flowcache: make struct flow_cache_percpu::hash_rnd_recalc bool

2017-03-21 Thread David Miller
From: Alexey Dobriyan Date: Mon, 20 Mar 2017 01:27:43 +0300 > ->hash_rnd_recalc is only used in boolean context. > > Space savings on x86_64 come from the fact that "MOV rm8, imm8" is > shorter than "MOV rm32, imm32" by at least 3 bytes. > > add/remove: 0/0

Re: [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4

2017-03-21 Thread David Miller
From: Tony Lindgren Date: Sun, 19 Mar 2017 09:19:57 -0700 > This gets qmicli working with the MDM6600 modem. > > Cc: Bjørn Mork > Reviewed-by: Sebastian Reichel > Tested-by: Sebastian Reichel > Signed-off-by: Tony Lindgren

[PATCH 2/2] netfilter: ipset: warn users of list:set that parameter 'size' is ignored

2017-03-21 Thread Vishwanath Pai
Revision 4 warns the users that the parameter 'size' is ignored. The kernel module doesn't need any changes, it will work with both the revisions. Note that this will not restore old behavior before commit 00590fdd5be0 ("netfilter: ipset: Introduce RCU locking in list type") for users of the

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

2017-03-21 Thread Eric Dumazet
On Tue, 2017-03-21 at 16:51 -0700, Kees Cook wrote: > Am I understanding you correctly that you'd want something like: > > refcount.h: > #ifdef UNPROTECTED_REFCOUNT > #define refcount_inc(x) atomic_inc(x) > ... > #else > void refcount_inc(... > ... > #endif > > some/net.c: > #define

Re: [PATCH net-next 0/9] qed: IOV related clenaups

2017-03-21 Thread David Miller
From: Yuval Mintz Date: Sun, 19 Mar 2017 13:08:11 +0200 > This patch series targets IOV functionality [on both PF and VF]. > > Patches #2, #3 and #5 fix flows relating to malicious VFs, either by > upgrading and aligning current safe-guards or by correcing racy flows. >

Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

2017-03-21 Thread David Miller
From: Shuah Khan Date: Mon, 20 Mar 2017 10:37:26 -0600 > On 03/20/2017 09:45 AM, Alexei Starovoitov wrote: >> On Mon, Mar 20, 2017 at 04:31:28PM +0100, Daniel Borkmann wrote: >>> On 03/20/2017 07:03 AM, Zi Shen Lim wrote: Merge of 'linux-kselftest-4.11-rc1': 1.

Re: [PATCH net 2/2] tcp: mark skbs with SCM_TIMESTAMPING_OPT_STATS

2017-03-21 Thread David Miller
From: Soheil Hassas Yeganeh Date: Sat, 18 Mar 2017 17:03:00 -0400 > From: Soheil Hassas Yeganeh > > SOF_TIMESTAMPING_OPT_STATS can be enabled and disabled > while packets are collected on the error queue. > So, checking SOF_TIMESTAMPING_OPT_STATS in

Re: [PATCH net 1/2] tcp: fix SCM_TIMESTAMPING_OPT_STATS for normal skbs

2017-03-21 Thread David Miller
From: Soheil Hassas Yeganeh Date: Sat, 18 Mar 2017 17:02:59 -0400 > From: Soheil Hassas Yeganeh > > __sock_recv_timestamp can be called for both normal skbs (for > receive timestamps) and for skbs on the error queue (for transmit > timestamps). > >

Re: [PATCH net] sctp: out_qlen should be updated when pruning unsent queue

2017-03-21 Thread David Miller
From: Xin Long Date: Sat, 18 Mar 2017 20:03:59 +0800 > This patch is to fix the issue that sctp_prsctp_prune_sent forgot > to update q->out_qlen when removing a chunk from unsent queue. > > Fixes: 8dbdf1f5b09c ("sctp: implement prsctp PRIO policy") > Signed-off-by: Xin

Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport

2017-03-21 Thread David Miller
From: Xin Long Date: Sat, 18 Mar 2017 19:27:23 +0800 > As tp->dst_pending_confirm's value can only be set 0 or 1, this > patch is to change to define it as a bit instead of __u32. > > Signed-off-by: Xin Long Applied.

Re: [PATCH net] sctp: remove temporary variable confirm from sctp_packet_transmit

2017-03-21 Thread David Miller
From: Xin Long Date: Sat, 18 Mar 2017 19:12:22 +0800 > Commit c86a773c7802 ("sctp: add dst_pending_confirm flag") introduced > a temporary variable "confirm" in sctp_packet_transmit. > > But it broke the rule that longer lines should be above shorter ones. > Besides, this

[PATCH v2 net-next 1/4] drivers: net: xgene-v2: Add MDIO support

2017-03-21 Thread Iyappan Subramanian
Added phy management support by using phy abstraction layer APIs. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +- drivers/net/ethernet/apm/xgene-v2/mac.c| 2 +- drivers/net/ethernet/apm/xgene-v2/mac.h| 1 +

[PATCH v2 net-next 0/4] drivers: net: xgene-v2: Add MDIO and ethtool support

2017-03-21 Thread Iyappan Subramanian
This patch set, - adds phy management and ethtool support - fixes ethernet reset - addresses review comments from previous patch set Signed-off-by: Iyappan Subramanian --- v2: Address review comments from v1 - removed mdio_lock, since there is a top level lock

[PATCH v2 net-next 4/4] drivers: net: xgene-v2: misc fixes

2017-03-21 Thread Iyappan Subramanian
Fixed review comments from the previous patch-set. - changed return value check of platform_get_irq() to < 0 - replaced devm_request(free)_irq() calls by request(free)_irq() since they are called from open() and close() - changed sizeof(struct mystruct) to sizeof(*mystruct) - reduced

[PATCH v2 net-next 2/4] drivers: net: xgene-v2: Add ethtool support

2017-03-21 Thread Iyappan Subramanian
Added basic ethtool support. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/Makefile | 2 +- drivers/net/ethernet/apm/xgene-v2/ethtool.c | 121 drivers/net/ethernet/apm/xgene-v2/main.c| 1 +

[PATCH v2 net-next 3/4] drivers: net: xgene-v2: Fix port reset

2017-03-21 Thread Iyappan Subramanian
Fixed port reset sequence by adding ECC init. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene-v2/enet.c | 24 ++-- drivers/net/ethernet/apm/xgene-v2/enet.h | 2 ++ drivers/net/ethernet/apm/xgene-v2/mac.h | 1 - 3 files changed,

[PATCH net-next 13/15] nfp: flush xmit_more on error paths

2017-03-21 Thread Jakub Kicinski
In case of ring full or DMA mapping error remember to flush xmit_more delayed kicks. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH net-next 05/15] nfp: document expected locking in the core

2017-03-21 Thread Jakub Kicinski
Document which fields of nfp_cpp are protected by which locks. Signed-off-by: Jakub Kicinski --- .../ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 33 ++ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 08/15] nfp: don't ignore return value of wait_event_interruptible

2017-03-21 Thread Jakub Kicinski
When signal interrupts waiting for an area to become available we assume success. Pay attention to the return code. Unpack the code a little bit to make it more readable. Signed-off-by: Jakub Kicinski --- .../ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 56

[PATCH net-next 06/15] nfp: lock area cache earlier

2017-03-21 Thread Jakub Kicinski
We shouldn't access area_cache_list without its lock even to check if it's empty. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 01/15] nfp: disallow sharing mutexes on the same machine

2017-03-21 Thread Jakub Kicinski
NFP can be connected to multiple machines via PCI or other buses. Access to hardware resources is arbitrated using locks residing in device memory. Currently nfpcore only respects the mutexes when it comes to inter-host locking, but if we try to acquire the same lock again, on one host - it will

[PATCH net-next 12/15] nfp: remove RX queue pointers

2017-03-21 Thread Jakub Kicinski
NFP6000 doesn't use queue pointers/doorbells for RX, it uses 'done' bit in descriptors. Remove the pointers from data structures. Since we are saving space in rx_ring structure make fields we previously compressed to 16bits word size again. Signed-off-by: Jakub Kicinski

[PATCH net-next 10/15] nfp: fix nfp_cpp_read()/nfp_cpp_write() error paths

2017-03-21 Thread Jakub Kicinski
When acquiring an area fails we can't call function doing both release and free. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_cppcore.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 11/15] nfp: don't use netdev_warn() before netdev is registered

2017-03-21 Thread Jakub Kicinski
Fix warning which was using netdev_warn() instead of dev_warn() to early. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 07/15] nfp: correct return codes when msleep gets interrupted

2017-03-21 Thread Jakub Kicinski
msleep_interruptible() returns time left to wait, not error code. Return ERESTARTSYS when interrupted. While at it correct a comment and make the polling a bit more aggressive. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c

[PATCH net-next 02/15] nfp: fail graciously when someone tries to grab global lock

2017-03-21 Thread Jakub Kicinski
The global device lock is acquired to search the resource table. The lock is actually itself part of the table (entry 0). Therefore if someone asks for resource 0 we would deadlock since double locking is no longer allowed. Currently the driver doesn't try to lock that resource so let's simply

[PATCH net-next 15/15] nfp: disable FW on reconfiguration errors

2017-03-21 Thread Jakub Kicinski
Since we no longer need to keep the FW enabled for .ndo_close() to work we can always stop FW after reconfiguration failure. This seems to make most FWs more resilient to faults (at least in error injection scenarios). Signed-off-by: Jakub Kicinski ---

[PATCH net-next 03/15] nfp: remove cpp mutex cache

2017-03-21 Thread Jakub Kicinski
CPP mutex cache was introduced to work around the fact that the same host could successfully acquire a lock multiple times. It used to collapse multiple users to the same struct nfp_cpp_mutex and track use count. Unfortunately it's racy. Since we now force all nfp_mutex_lock() callers within

[PATCH net-next 04/15] nfp: move mutex code out of nfp_cppcore.c

2017-03-21 Thread Jakub Kicinski
After mutex cache removal we can put the mutex code in a separate source file. This makes it clear it doesn't play with internals of struct nfp_cpp any more. No functional changes. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/Makefile

[PATCH net-next 00/15] nfp: allow concurrency in core and minor fixes

2017-03-21 Thread Jakub Kicinski
Hi! The first 10 patches of this series prepare nfpcore for concurrent accesses. This will be needed by upcoming hwmon and devlink patches. Most locking is already in place, the patches in this series iron out a few bugs. Last 5 patches are fixes and cleanups to the netdev code, including

[PATCH net-next 14/15] nfp: remove defensive checks around ndo_open()/ndo_close()

2017-03-21 Thread Jakub Kicinski
Device open and close handlers check if the device is already in the desired state. Thanks to our reconfig infrastructure this should not be necessary, there doesn't seem to be any code in the driver which depends on it. Signed-off-by: Jakub Kicinski ---

[PATCH net-next 09/15] nfp: fix invalid area detection

2017-03-21 Thread Jakub Kicinski
Core should detect when someone is trying to request an access window which is too large for a given type of access. Otherwise the requester will be put on a wait queue for ever without any error message. Add const qualifiers to clarify that we are only looking at read- -only members in relevant

Re: [PATCH] net: vrf: Reset rt6i_idev in local dst after put

2017-03-21 Thread David Miller
From: David Ahern Date: Fri, 17 Mar 2017 16:07:11 -0700 > The VRF driver takes a reference to the inet6_dev on the VRF device for > its rt6_local dst when handling local traffic through the VRF device as > a loopback. When the device is deleted the driver does a put on

Re: [PATCH] rhashtable: Add rhashtable_lookup_get_insert_fast

2017-03-21 Thread David Miller
From: Andreas Gruenbacher Date: Sat, 18 Mar 2017 00:36:15 +0100 > Add rhashtable_lookup_get_insert_fast for fixed keys, similar to > rhashtable_lookup_get_insert_key for explicit keys. > > Signed-off-by: Andreas Gruenbacher > Acked-by: Herbert Xu

Re: [PATCH net-next] liquidio: fix for vf mac addr command sent to nic firmware

2017-03-21 Thread David Miller
From: Felix Manlunas Date: Fri, 17 Mar 2017 15:43:26 -0700 > From: Rick Farrington > > Change to support host<->firmware command return value. > Fix for vf mac addr state command. > 1. Added support for firmware commands to return a

Re: [PATCH net 0/4] ibmvnic: Initialization fixes and improvements

2017-03-21 Thread David Miller
From: John Allen Date: Fri, 17 Mar 2017 17:13:39 -0500 > These patches resolve issues with the ibmvnic initialization process. Series applied, thanks.

Re: [PATCH net-next] liquidio: add debug error messages to report command timeout

2017-03-21 Thread David Miller
From: Felix Manlunas Date: Fri, 17 Mar 2017 11:23:08 -0700 > From: Rick Farrington > > Add timeout error message in lio_process_ordered_list(). Add host failure > status in existing error message in if_cfg_callback(). > >

Re: [PATCH net-next] liquidio: remove duplicate code

2017-03-21 Thread David Miller
From: Felix Manlunas Date: Fri, 17 Mar 2017 10:50:05 -0700 > From: Satanand Burla > > Remove code duplicated in PF and VF; define that code once only in a common > header file included by PF and VF. > > Signed-off-by: Satanand Burla

Re: [PATCH] bna: integer overflow bug in debugfs

2017-03-21 Thread David Miller
From: Dan Carpenter Date: Fri, 17 Mar 2017 23:52:35 +0300 > We could allocate less memory than intended because we do: > > bnad->regdata = kzalloc(len << 2, GFP_KERNEL); > > The shift can overflow leading to a crash. This is debugfs code so the > impact is very

Re: [PATCH net,stable] qmi_wwan: add Dell DW5811e

2017-03-21 Thread David Miller
From: Bjørn Mork Date: Fri, 17 Mar 2017 17:20:48 +0100 > This is a Dell branded Sierra Wireless EM7455. It is operating in > MBIM mode by default, but can be configured to provide two QMI/RMNET > functions. > > Signed-off-by: Bjørn Mork > --- > Note regarding

Re: [PATCH v2 net-next 0/3] net: stmmac: adding multiple buffers and routing

2017-03-21 Thread David Miller
From: Joao Pinto Date: Fri, 17 Mar 2017 16:11:04 + > As agreed with David Miller, this patch-set is the third and last to enable > multiple queues in stmmac. > > This third one focuses on: > > a) Enable multiple buffering to the driver and queue independent data >

Re: [PATCH net] sch_dsmark: fix invalid skb_cow() usage

2017-03-21 Thread David Miller
From: Eric Dumazet Date: Fri, 17 Mar 2017 08:05:28 -0700 > From: Eric Dumazet > > skb_cow(skb, sizeof(ip header)) is not very helpful in this context. > > First we need to use pskb_may_pull() to make sure the ip header > is in skb linear part, then

Re: [PATCH net-next] net: ethoc: Use ether_addr_copy()

2017-03-21 Thread David Miller
From: Tobias Klauser Date: Fri, 17 Mar 2017 11:52:15 +0100 > Use ether_addr_copy() instead of memcpy() to set netdev->dev_addr (which > is 2-byte aligned). > > Signed-off-by: Tobias Klauser Applied.

Re: [patch net-next 0/2] mlxsw: small driver update

2017-03-21 Thread David Miller
From: Jiri Pirko Date: Fri, 17 Mar 2017 09:37:59 +0100 > From: Jiri Pirko > > Contains two cleanup patches. Series applied, thanks.

Re: [PATCH net-next] r8152: check hw version first

2017-03-21 Thread David Miller
From: Hayes Wang Date: Fri, 17 Mar 2017 11:20:13 +0800 > Check hw version first in probe(). Do nothing if the driver doesn't > support the chip. > > Signed-off-by: Hayes Wang Applied, thanks.

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

2017-03-21 Thread Kees Cook
On Tue, Mar 21, 2017 at 2:23 PM, Eric Dumazet wrote: > On Tue, 2017-03-21 at 13:49 -0700, Kees Cook wrote: > >> Yeah, this is exactly what I'd like to find as well. Just comparing >> cycles between refcount implementations, while interesting, doesn't >> show us real-world

[net-next 1/5] e1000: use new API ethtool_{get|set}_link_ksettings

2017-03-21 Thread Jeff Kirsher
From: Philippe Reynes The ethtool API {get|set}_settings is deprecated. We move this driver to new API {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes Tested-by:

Re: [PATCH v2] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-03-21 Thread Stephen Hemminger
On Tue, 21 Mar 2017 23:28:45 +0100 Linus Lüssing wrote: > However, the IP code drops it in the beginning of ip_input.c/ip_rcv() > as the dnat target did not update the skb->pkt_type. If after > dnat'ing the packet is now destined to us then the skb->pkt_type > needs to

Re: [PATCH net-next 1/4] drivers: net: xgene-v2: Add MDIO support

2017-03-21 Thread Iyappan Subramanian
On Tue, Mar 21, 2017 at 1:35 PM, Andrew Lunn wrote: >> @@ -511,9 +512,9 @@ static int xge_close(struct net_device *ndev) >> { >> struct xge_pdata *pdata = netdev_priv(ndev); >> >> - netif_carrier_off(ndev); >> netif_stop_queue(ndev); >>

[net-next 4/5] igbvf: use new API ethtool_{get|set}_link_ksettings

2017-03-21 Thread Jeff Kirsher
From: Philippe Reynes The ethtool API {get|set}_settings is deprecated. We move this driver to new API {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes Tested-by:

[net-next 5/5] ixgb: use new API ethtool_{get|set}_link_ksettings

2017-03-21 Thread Jeff Kirsher
From: Philippe Reynes The ethtool API {get|set}_settings is deprecated. We move this driver to new API {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes Tested-by:

[net-next 0/5][pull request] Intel Wired LAN Driver Updates 2017-03-21

2017-03-21 Thread Jeff Kirsher
This series contains updates to e1000, e1000e, igb, igbvf and ixgb. This finishes up the work Philippe Reynes did to update the Intel drivers to the new API for ethtool (get|set)_link_ksettings. The following are changes since commit b3407c8e5eb78e4e0b57a97a4dd2e411354b60cd: Cleanup some

Re: [PATCH 01/11] net: usb: usbnet: add new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread David Miller
From: Oliver Neukum Date: Tue, 21 Mar 2017 12:33:03 +0100 > Am Donnerstag, den 16.03.2017, 23:18 +0100 schrieb Philippe Reynes: >> The ethtool api {get|set}_settings is deprecated. >> We add the new api {get|set}_link_ksettings to this driver. >> >> As I don't have the

[net-next 3/5] igb: use new API ethtool_{get|set}_link_ksettings

2017-03-21 Thread Jeff Kirsher
From: Philippe Reynes The ethtool API {get|set}_settings is deprecated. We move this driver to new API {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes Tested-by:

[net-next 2/5] e1000e: use new API ethtool_{get|set}_link_ksettings

2017-03-21 Thread Jeff Kirsher
From: Philippe Reynes The ethtool API {get|set}_settings is deprecated. We move this driver to new API {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes Tested-by:

Re: [PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread David Miller
From: Philippe Reynes Date: Thu, 16 Mar 2017 23:18:46 +0100 > The ethtool api {get|set}_settings is deprecated. On usbnet, it > was often implemented with usbnet_{get|set}_settings. > > In this serie, I add usbnet_{get|set}_link_ksettings > in the first patch, then I update

Re: [PATCH net-next v2] net: Add sysctl to toggle early demux for tcp and udp

2017-03-21 Thread Tom Herbert
On Sat, Mar 18, 2017 at 7:07 PM, Subash Abhinov Kasiviswanathan wrote: >> Less than 1% performance improvement in a benchmark doesn't justify >> the complexity of the patch. Eric's hypothesis was that an unconnected >> UDP socket may show issues because of cache misses in

Re: [PATCH net] net: bcmgenet: remove bcmgenet_internal_phy_setup()

2017-03-21 Thread Florian Fainelli
On 03/21/2017 02:01 PM, Doug Berger wrote: > Commit 6ac3ce8295e6 ("net: bcmgenet: Remove excessive PHY reset") > removed the bcmgenet_mii_reset() function from bcmgenet_power_up() and > bcmgenet_internal_phy_setup() functions. In so doing it broke the reset > of the internal PHY devices used by

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

2017-03-21 Thread David Miller
From: Eric Dumazet Date: Tue, 21 Mar 2017 14:23:09 -0700 > It looks like our suggestion to get kernel builds with atomic_inc() > being exactly an atomic_inc() is not even discussed or implemented. > > Coding this would require less time than running a typical Google

Re: [PATCH] net: unix: properly re-increment inflight counter of GC discarded candidates

2017-03-21 Thread David Miller
From: Andrey Ulanov Date: Tue, 14 Mar 2017 20:16:42 -0700 > Dmitry has reported that a BUG_ON() condition in unix_notinflight() > may be triggered by a simple code that forwards unix socket in an > SCM_RIGHTS message. > That is caused by incorrect unix socket GC

Re: [PATCH net-next] net/8021q: create device with all possible features in wanted_features

2017-03-21 Thread David Miller
From: Andrei Vagin Date: Wed, 15 Mar 2017 17:41:14 -0700 > wanted_features is a set of features which have to be enabled if a > hardware allows that. > > Currently when a vlan device is created, its wanted_features is set to > current features of its base device. > > The

Re: [PATCH] tun: fix inability to set offloads after disabling them via ethtool

2017-03-21 Thread David Miller
From: Yaroslav Isakov Date: Thu, 16 Mar 2017 22:44:10 +0300 > Added missing logic in tun driver, which prevents apps to set > offloads using tun ioctl, if offloads were previously disabled via ethtool > > Signed-off-by: Yaroslav Isakov

Re: [PATCH net-next] net: bcmgenet: Track per TX/RX rings statistics

2017-03-21 Thread David Miller
From: Florian Fainelli Date: Thu, 16 Mar 2017 10:27:08 -0700 > __bcmgenet_tx_reclaim() is currently summing TX bytes/packets in a way > that is not SMP friendly, mutliples CPUs could run > __bcmgenet_tx_reclaim() independently and still update stats->tx_bytes > and

Re: [PATCH net-next v4] net: ipv4: add support for ECMP hash policy choice

2017-03-21 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 16 Mar 2017 15:28:00 +0200 > This patch adds support for ECMP hash policy choice via a new sysctl > called fib_multipath_hash_policy and also adds support for L4 hashes. > The current values for fib_multipath_hash_policy are: > 0

[PATCH v2] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-03-21 Thread Linus Lüssing
When trying to redirect bridged frames to the bridge device itself via the ebtables nat-prerouting chain and the dnat target then this currently fails: The ethernet destination of the frame is dnat'ed to the MAC address of the bridge itself just fine and the correctly altered frame can even be

[PATCH 2] net: virtio_net: use new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- Changelog: v2: - remove comment about the missing hardware, I've tested this change with qemu drivers/net/virtio_net.c | 50

[PATCH net-next] enic: update enic maintainers

2017-03-21 Thread Govindarajulu Varadarajan
update enic maintainers Signed-off-by: Govindarajulu Varadarajan --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d14e42bef72e..5094b78c4acc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3159,7 +3159,6 @@ F:

[PATCH net-next v7 3/3] A Sample of using socket cookie and uid for traffic monitoring

2017-03-21 Thread Chenbo Feng
From: Chenbo Feng Add a sample program to demostrate the possible usage of get_socket_cookie and get_socket_uid helper function. The program will store bytes and packets counting of in/out traffic monitored by iptables and store the stats in a bpf map in per socket base. The

[PATCH net-next v7 0/3] net: core: Two Helper function about socket information

2017-03-21 Thread Chenbo Feng
From: Chenbo Feng Introduce two eBpf helper function to get the socket cookie and socket uid for each packet. The helper function is useful when the *sk field inside sk_buff is not empty. These helper functions can be used on socket and uid based traffic monitoring programs.

[PATCH net-next v7 1/3] Add a helper function to get socket cookie in eBPF

2017-03-21 Thread Chenbo Feng
From: Chenbo Feng Retrieve the socket cookie generated by sock_gen_cookie() from a sk_buff with a known socket. Generates a new cookie if one was not yet set.If the socket pointer inside sk_buff is NULL, 0 is returned. The helper function coud be useful in monitoring per socket

[PATCH net-next v7 2/3] Add a eBPF helper function to retrieve socket uid

2017-03-21 Thread Chenbo Feng
From: Chenbo Feng Returns the owner uid of the socket inside a sk_buff. This is useful to perform per-UID accounting of network traffic or per-UID packet filtering. The socket need to be a fullsock otherwise overflowuid is returned. Signed-off-by: Chenbo Feng

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-03-21 Thread Marcelo Ricardo Leitner
Hi, On Fri, Feb 24, 2017 at 10:14:09AM +, David Laight wrote: > From: Xin Long > > Sent: 24 February 2017 06:44 > ... > > > IIRC sctp_packet_can_append_data() is called for the first queued > > > data chunk in order to decide whether to generate a message that > > > consists only of data

[PATCH] net: virtio_net: use new api ethtool_{get|set}_link_ksettings

2017-03-21 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/virtio_net.c | 50

[PATCH iproute2 v3 1/1] actions: Add support for user cookies

2017-03-21 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved

Re: [PATCH iproute2 v2 1/1] actions: Add support for user cookies

2017-03-21 Thread Jamal Hadi Salim
Ignore - i resent the same version again ;-> Resending .. cheers, jamal On 17-03-21 05:58 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg

IPv6 IGMP issue in v4.4.44 ??

2017-03-21 Thread Murali Karicheri
Hello David, experts, I see an issue with IGMP for IPv6 when I test HSR redundancy network interface. As soon as I set up an HSR interface, I see some IGMP messages (destination mac address: 33 33 00 00 00 02 going over HSR interface to slave interfaces, at the egress where as for IPv6, I see

[PATCH iproute2 v2 1/1] actions: Add support for user cookies

2017-03-21 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved

Re: [PATCH net] r8152: fix the list rx_done may be used without initialization

2017-03-21 Thread David Miller
From: Hayes Wang Date: Tue, 14 Mar 2017 14:15:20 +0800 > The list rx_done would be initialized when the linking on occurs. > Therefore, if a napi is scheduled without any linking on before, > the following kernel panic would happen. > > BUG: unable to handle kernel

Re: [net-next 00/13][pull request] 40GbE Intel Wired LAN Driver Updates 2017-03-20

2017-03-21 Thread David Miller
From: Jeff Kirsher Date: Mon, 20 Mar 2017 16:46:59 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: run_timer_softirq gpf. [smc]

2017-03-21 Thread Thomas Gleixner
On Tue, 21 Mar 2017, Dave Jones wrote: > On Tue, Mar 21, 2017 at 08:25:39PM +0100, Thomas Gleixner wrote: > > > > I just hit this while fuzzing.. > > > > > > general protection fault: [#1] PREEMPT SMP DEBUG_PAGEALLOC > > > CPU: 2 PID: 0 Comm: swapper/2 Not tainted 4.11.0-rc2-think+ #1

Re: [PATCH-v5 0/4] vsock: cancel connect packets when failing to connect

2017-03-21 Thread David Miller
From: Peng Tao Date: Wed, 15 Mar 2017 09:32:13 +0800 > Currently, if a connect call fails on a signal or timeout (e.g., guest is > still > in the process of starting up), we'll just return to caller and leave the > connect > packet queued and they are sent even though the

Re: [PATCH 00/22] Netfilter/IPVS updates for net-next

2017-03-21 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 20 Mar 2017 11:08:28 +0100 > The following patchset contains Netfilter/IPVS updates for your > net-next tree. A couple of new features for nf_tables, and unsorted > cleanups and incremental updates for the Netfilter tree. More >

RE: [net-next 05/13] i40e: rework exit flow of i40e_add_fdir_ethtool

2017-03-21 Thread Keller, Jacob E
> -Original Message- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Tuesday, March 21, 2017 3:11 AM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: Keller, Jacob E ; netdev@vger.kernel.org; >

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

2017-03-21 Thread Eric Dumazet
On Tue, 2017-03-21 at 13:49 -0700, Kees Cook wrote: > Yeah, this is exactly what I'd like to find as well. Just comparing > cycles between refcount implementations, while interesting, doesn't > show us real-world performance changes, which is what we need to > measure. > > Is Eric's "20

Re: [PATCH iproute2 1/1] actions: Add support for user cookies

2017-03-21 Thread Stephen Hemminger
Minor style issues. > + if (*argv && strcmp(*argv, "cookie") == 0) { > + int slen; slen is strlen() and that returns size_t not int. > + > + NEXT_ARG(); > + slen = strlen(*argv); > +

Re: [net-next 00/13][pull request] 1GbE Intel Wired LAN Driver Updates 2017-03-17

2017-03-21 Thread David Miller
From: Jeff Kirsher Date: Fri, 17 Mar 2017 12:58:05 -0700 > This series contains updates to mainly igb, with one fix for ixgbe. Pulled, thanks Jeff.

[PATCH net] net: bcmgenet: remove bcmgenet_internal_phy_setup()

2017-03-21 Thread Doug Berger
Commit 6ac3ce8295e6 ("net: bcmgenet: Remove excessive PHY reset") removed the bcmgenet_mii_reset() function from bcmgenet_power_up() and bcmgenet_internal_phy_setup() functions. In so doing it broke the reset of the internal PHY devices used by the GENETv1-GENETv3 which required this reset before

Hello

2017-03-21 Thread Shri Gandhi
Hello Friend, Compliment of the day, I got your contact information from a reputable business/professional directory of your country which gives me assurance of your legibility as a person. I send you this brief letter to solicit your partnership to transfer ($22,500,000.00 USD) from Reserve

Re: [PATCH 07/17] net: convert sock.sk_refcnt from atomic_t to refcount_t

2017-03-21 Thread Kees Cook
On Mon, Mar 20, 2017 at 6:40 AM, Peter Zijlstra wrote: > On Mon, Mar 20, 2017 at 09:27:13PM +0800, Herbert Xu wrote: >> On Mon, Mar 20, 2017 at 02:23:57PM +0100, Peter Zijlstra wrote: >> > >> > So what bench/setup do you want ran? >> >> You can start by counting how many

Re: [PATCH v2 net-next] net: fix dma operation mode config for older versions

2017-03-21 Thread Thierry Reding
Resending with Sergei's proper email address. On Tue, Mar 21, 2017 at 06:02:36PM +, Joao Pinto wrote: > This patch fixes a bug introduced in: > commit 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple > queues") > > The dma operation mode configuration routine was wrongly

[patch -next] net: dwc-xlgmac: fix an error code in xlgmac_alloc_pages()

2017-03-21 Thread Dan Carpenter
The dma_mapping_error() returns true if there is an error but we want to return -ENOMEM and not 1. Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH v2 net-next] net: fix dma operation mode config for older versions

2017-03-21 Thread Thierry Reding
On Tue, Mar 21, 2017 at 06:00:53PM +, Joao Pinto wrote: > This patch fixes a bug introduced in: > commit 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple > queues") > > The dma operation mode configuration routine was wrongly moved to a > function (stmmac_mtl_configuration)

Re: [PATCH net-next 1/4] drivers: net: xgene-v2: Add MDIO support

2017-03-21 Thread Andrew Lunn
> @@ -511,9 +512,9 @@ static int xge_close(struct net_device *ndev) > { > struct xge_pdata *pdata = netdev_priv(ndev); > > - netif_carrier_off(ndev); > netif_stop_queue(ndev); > xge_mac_disable(pdata); > + phy_stop(ndev->phydev); > > xge_intr_disable(pdata); >

  1   2   3   >