Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

2017-03-22 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 22 Mar 2017 21:55:04 -0600 >> This doesn't build with ipv6 as a module: >> net/built-in.o: In function `proc_tcp_early_demux': >> sysctl_net_ipv4.c:(.text+0x145cfc): undefined reference to >> `tcp_v6_early_demux_configure'

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-03-22 Thread Xin Long
On Thu, Mar 23, 2017 at 1:33 AM, Marcelo Ricardo Leitner wrote: > On Wed, Mar 22, 2017 at 02:07:37PM +, David Laight wrote: >> From: Marcelo Ricardo Leitner [mailto:marcelo.leit...@gmail.com] >> > Sent: 21 March 2017 22:04 >> > Hi, >> ... >> > > > 2. send 1 more

[PATCH net-next 2/2] net: dwc-xlgmac: use dual license

2017-03-22 Thread Jie Deng
The driver "dwc-xlgmac" is dual-licensed. Declare the dual license with MODULE_LICENSE(). Signed-off-by: Jie Deng --- drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 1/2] net: dwc-xlgmac: declaration of dual license in headers

2017-03-22 Thread Jie Deng
The driver "dwc-xlgmac" is dual-licensed. This patch adds declaration of dual license in file headers. Signed-off-by: Jie Deng --- drivers/net/ethernet/synopsys/dwc-xlgmac-common.c | 6 ++ drivers/net/ethernet/synopsys/dwc-xlgmac-desc.c | 6 ++

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

2017-03-22 Thread Subash Abhinov Kasiviswanathan
This doesn't build with ipv6 as a module: net/built-in.o: In function `proc_tcp_early_demux': sysctl_net_ipv4.c:(.text+0x145cfc): undefined reference to `tcp_v6_early_demux_configure' net/built-in.o: In function `proc_udp_early_demux': sysctl_net_ipv4.c:(.text+0x145d4c): undefined reference to

[GIT] Networking

2017-03-22 Thread David Miller
1) Several netfilter fixes from Pablo and the crew: a) Handle fragmented packets properly in netfilter conntrack, from Florian Westphal. b) Fix SCTP ICMP packet handling, from Ying Xue. c) Fix big-endian bug in nftables, from Liping Zhang. d) Fix

Re: [PATCH net-next 1/2] net: dwc-xlgmac: declaration of dual license in headers

2017-03-22 Thread Jie Deng
On 2017/3/23 2:50, David Miller wrote: > From: Jie Deng > Date: Tue, 21 Mar 2017 11:59:04 +0800 > >> This patch adds declaration of dual license in file headers. >> >> Signed-off-by: Jie Deng > My apologies. I applied Arnd's patches. Could you

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

2017-03-22 Thread David Miller
From: David Miller Date: Wed, 22 Mar 2017 19:43:57 -0700 (PDT) > From: Subash Abhinov Kasiviswanathan > Date: Wed, 22 Mar 2017 20:00:41 -0600 > >> Certain system process significant unconnected UDP workload. >> It would be preferrable to disable

Re: [PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

2017-03-22 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 22 Mar 2017 20:00:41 -0600 > Certain system process significant unconnected UDP workload. > It would be preferrable to disable UDP early demux for those systems > and enable it for TCP only. > > By disabling UDP demux, we

Re: [PATCH v2 net] net:ethernet:aquantia: Fix for RX checksum offload.

2017-03-22 Thread David Miller
From: Pavel Belous Date: Thu, 23 Mar 2017 02:20:39 +0300 > From: Pavel Belous > > Since AQC-100/107/108 chips supports hardware checksums for RX we should > indicate this > via NETIF_F_RXCSUM flag. > > v1->v2: 'Signed-off-by' tag added. >

Re: [PATCH net] amd-xgbe: Fix the ECC-related bit position definitions

2017-03-22 Thread David Miller
From: Tom Lendacky Date: Wed, 22 Mar 2017 17:25:27 -0500 > The ECC bit positions that describe whether the ECC interrupt is for > Tx, Rx or descriptor memory and whether the it is a single correctable > or double detected error were defined in incorrectly (reversed

Re: [PATCH net-next 0/9] netvsc: bug fixes and cleanups

2017-03-22 Thread David Miller
From: Stephen Hemminger Date: Wed, 22 Mar 2017 14:50:56 -0700 > These fix NAPI issues and bugs found during testing of shutdown > testing. Series applied, thanks Stephen.

Re: [PATCH net-next] liquidio: fix tx completions in napi poll

2017-03-22 Thread David Miller
From: Felix Manlunas Date: Wed, 22 Mar 2017 11:54:50 -0700 > From: VSR Burru > > If there are no egress packets pending, then don't look for tx completions > in napi poll. Also, fix broken tx queue wakeup logic. > > Signed-off-by:

Re: [PATCH net-next] liquidio: allocate RX buffers in OOM conditions in PF and VF

2017-03-22 Thread David Miller
From: Felix Manlunas Date: Wed, 22 Mar 2017 11:31:13 -0700 > From: Satanand Burla > > Add workqueue that is periodically run to try to allocate RX buffers in OOM > conditions in PF and VF. > > Signed-off-by: Satanand Burla

Re: [PATCH] net: stmmac: dwmac-rk: Add handling for RGMII_ID/RXID/TXID

2017-03-22 Thread David Miller
From: Wadim Egorov Date: Wed, 22 Mar 2017 16:50:22 +0100 > @@ -74,6 +74,10 @@ struct rk_priv_data { > #define GRF_BIT(nr) (BIT(nr) | BIT(nr+16)) > #define GRF_CLR_BIT(nr) (BIT(nr+16)) > > +#define DELAY_ENABLE(soc, tx, rx) \ > + ((tx) ?

Re: [PATCH] net: stmmac: add set_mac to the stmmac_ops

2017-03-22 Thread David Miller
From: Corentin Labbe Date: Wed, 22 Mar 2017 14:29:04 +0100 > @@ -2224,7 +,8 @@ static int stmmac_release(struct net_device *dev) > free_dma_desc_resources(priv); > > /* Disable the MAC Rx/Tx */ > - stmmac_set_mac(priv->ioaddr, false); > + if

Re: EINVAL when using connect() for udp sockets

2017-03-22 Thread Daurnimator
On 9 March 2017 at 14:10, Daurnimator wrote: > When debugging https://github.com/daurnimator/lua-http/issues/73 which > uses https://github.com/wahern/dns we ran into an issue where modern > linux kernels return EINVAL if you try and re-use a udp socket. > The issue seems to

Re: [PATCH] net: vmxnet3: use new api ethtool_{get|set}_link_ksettings

2017-03-22 Thread David Miller
From: Philippe Reynes Date: Wed, 22 Mar 2017 08:27:57 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2] net: virtio_net: use new api ethtool_{get|set}_link_ksettings

2017-03-22 Thread David Miller
From: Philippe Reynes Date: Tue, 21 Mar 2017 23:24:24 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > Changelog: > v2: > - remove comment about

Re: [patch] sfc: cleanup a condition in efx_udp_tunnel_del()

2017-03-22 Thread David Miller
From: Dan Carpenter Date: Wed, 22 Mar 2017 12:10:02 +0300 > Presumably if there is an "add" function, there is also a "del" > function. But it causes a static checker warning because it looks like > a common cut and paste bug. > > Signed-off-by: Dan Carpenter

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-22 Thread David Miller
From: Marcel Holtmann Date: Wed, 22 Mar 2017 20:23:15 +0100 > Hi Dave, > >>> By moving these client drivers to use RPMSG instead of the direct SMD >>> API we can reuse them ontop of the newly added GLINK wire-protocol >>> support found in the 820 and 835 Qualcomm platforms.

Re: [PATCH v2 net-next 0/4] drivers: net: xgene-v2: Add MDIO and ethtool support

2017-03-22 Thread David Miller
From: Iyappan Subramanian Date: Tue, 21 Mar 2017 18:18:01 -0700 > This patch set, > > - adds phy management and ethtool support > - fixes ethernet reset > - addresses review comments from previous patch set > > Signed-off-by: Iyappan Subramanian

[PATCH net-next v4] net: Add sysctl to toggle early demux for tcp and udp

2017-03-22 Thread Subash Abhinov Kasiviswanathan
Certain system process significant unconnected UDP workload. It would be preferrable to disable UDP early demux for those systems and enable it for TCP only. By disabling UDP demux, we see these slight gains on an ARM64 system- 782 -> 788Mbps unconnected single stream UDPv4 633 -> 654Mbps

[PATCH] net: usbnet: support 64bit stats in qmi_wwan driver

2017-03-22 Thread Greg Ungerer
Add support for the net stats64 counters to the usbnet core and then to the qmi_wwan driver. This is a strait forward addition of 64bit counters for RX and TX packets and byte counts. It is done in the same style as for the other net drivers that support stats64. The bulk of the change is to the

[PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

2017-03-22 Thread R. Parameswaran
A new function, kernel_sock_ip_overhead(), is provided to calculate the cumulative overhead imposed by the IP Header and IP options, if any, on a socket's payload. The new function returns an overhead of zero for sockets that do not belong to the IPv4 or IPv6 address families. This is used in the

[PATCH net-next v8 1/3] Add a helper function to get socket cookie in eBPF

2017-03-22 Thread Chenbo Feng
From: Chenbo Feng Retrieve the socket cookie generated by sock_gen_cookie() from a sk_buff with a known socket. Generates a new cookie if one was not yet set.If the socket pointer inside sk_buff is NULL, 0 is returned. The helper function coud be useful in monitoring per socket

[PATCH net-next v8 2/3] Add a eBPF helper function to retrieve socket uid

2017-03-22 Thread Chenbo Feng
From: Chenbo Feng Returns the owner uid of the socket inside a sk_buff. This is useful to perform per-UID accounting of network traffic or per-UID packet filtering. The socket need to be a fullsock otherwise overflowuid is returned. Signed-off-by: Chenbo Feng

[PATCH net-next v8 3/3] A Sample of using socket cookie and uid for traffic monitoring

2017-03-22 Thread Chenbo Feng
From: Chenbo Feng Add a sample program to demostrate the possible usage of get_socket_cookie and get_socket_uid helper function. The program will store bytes and packets counting of in/out traffic monitored by iptables and store the stats in a bpf map in per socket base. The

[PATCH net-next v8 0/3] net: core: Two Helper function about socket information

2017-03-22 Thread Chenbo Feng
From: Chenbo Feng Introduce two eBpf helper function to get the socket cookie and socket uid for each packet. The helper function is useful when the *sk field inside sk_buff is not empty. These helper functions can be used on socket and uid based traffic monitoring programs.

RE: [PATCH net-next] e1000: Omit private ndo_get_stats function

2017-03-22 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Tobias Klauser > Sent: Wednesday, February 15, 2017 3:08 AM > To: netdev@vger.kernel.org > Cc: Kirsher, Jeffrey T ; intel-wired- > l...@lists.osuosl.org; Joe Perches

RE: [PATCH v3 0/2] fjes: Do not load fjes driver

2017-03-22 Thread Izumi, Taku
Tested-by: Taku Izumi > -Original Message- > From: YASUAKI ISHIMATSU [mailto:yasu.isim...@gmail.com] > Sent: Wednesday, March 22, 2017 12:28 AM > To: netdev@vger.kernel.org > Cc: David Miller ; Izumi, Taku/泉 拓 > ;

linux-next: manual merge of the net-next tree with the net tree

2017-03-22 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/broadcom/genet/bcmmii.c between commit: 31739eae738c ("net: bcmgenet: remove bcmgenet_internal_phy_setup()") from the net tree and commit: 421380856d9c ("net: bcmgenet: add support for the

Re: Page allocator order-0 optimizations merged

2017-03-22 Thread Mel Gorman
On Wed, Mar 22, 2017 at 07:39:17PM +0200, Tariq Toukan wrote: > > > > This modification may slow allocations from IRQ context slightly > > > > but the > > > > main gain from the per-cpu allocator is that it scales better for > > > > allocations from multiple contexts. There is an implicit > > > >

[PATCH v2 net] net:ethernet:aquantia: Fix for RX checksum offload.

2017-03-22 Thread Pavel Belous
From: Pavel Belous Since AQC-100/107/108 chips supports hardware checksums for RX we should indicate this via NETIF_F_RXCSUM flag. v1->v2: 'Signed-off-by' tag added. Signed-off-by: Pavel Belous ---

[PATCH net-next v4 0/2] L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.

2017-03-22 Thread R. Parameswaran
Existing L2TP kernel code does not derive the optimal MTU for Ethernet pseudowires and instead leaves this to a userspace L2TP daemon or operator. If an MTU is not specified, the existing kernel code chooses an MTU that does not take account of all tunnel header overheads, which can lead to

race condition in kernel/padata.c

2017-03-22 Thread Jason A. Donenfeld
Hey Steffen, WireGuard makes really heavy use of padata, feeding it units of work from different cores in different contexts all at the same time. For the most part, everything has been fine, but one particular user has consistently run into mysterious bugs. He's using a rather old dual core CPU,

Re: [PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

2017-03-22 Thread Tom Herbert
On Wed, Mar 22, 2017 at 3:59 PM, R. Parameswaran wrote: > > A new function, kernel_sock_ip_overhead(), is provided > to calculate the cumulative overhead imposed by the IP > Header and IP options, if any, on a socket's payload. > The new function returns an overhead of

[PATCH net-next v4 2/2] L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.

2017-03-22 Thread R. Parameswaran
Existing L2TP kernel code does not derive the optimal MTU for Ethernet pseudowires and instead leaves this to a userspace L2TP daemon or operator. If an MTU is not specified, the existing kernel code chooses an MTU that does not take account of all tunnel header overheads, which can lead to

[PATCH net-next v4 1/2] New kernel function to get IP overhead on a socket.

2017-03-22 Thread R. Parameswaran
A new function, kernel_sock_ip_overhead(), is provided to calculate the cumulative overhead imposed by the IP Header and IP options, if any, on a socket's payload. The new function returns an overhead of zero for sockets that do not belong to the IPv4 or IPv6 address families. Signed-off-by: R.

Re: Problem: net: mvneta: auto-negotiation with disconnected network cable

2017-03-22 Thread Stas Sergeev
22.03.2017 16:23, Maxime Morin пишет: Hi all, I work on an embedded platform based on the Marvell Armada 88F6707, that is connected to a Marvell Alaska 88E1512 ethernet transceiver. A defect has appeared recently, and it turns out to be a regression on the network part. There is a complete

Re: [PATCH net] net:ethernet:aquantia: Fix for RX checksum offload.

2017-03-22 Thread David Miller
From: Pavel Belous Date: Wed, 22 Mar 2017 20:21:10 +0300 > From: Pavel Belous > > Since AQC-100/107/08 chips supports hardware checksums for RX we should > indicate > this via NETIF_F_RXCSUM flag. Please resubmit this with a proper

Re: [PATCH net-next 0/4] bpf: Add map-in-map support

2017-03-22 Thread David Miller
From: Martin KaFai Lau Date: Wed, 22 Mar 2017 10:00:31 -0700 > This patchset adds map-in-map support (map->map). > One use case is the (vips -> webservers) in the L4 load balancer so > that different vips can be backed by different set of webservers. > > Please refer to the

Re: [PATCH net] inet: frag: release spinlock before calling icmp_send()

2017-03-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 Mar 2017 08:57:15 -0700 > From: Eric Dumazet > > Dmitry reported a lockdep splat [1] (false positive) that we can fix > by releasing the spinlock before calling icmp_send() from ip_expire() > > This is a false

Re: [PATCH net] tcp: initialize icsk_ack.lrcvtime at session start time

2017-03-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 Mar 2017 08:10:21 -0700 > From: Eric Dumazet > > icsk_ack.lrcvtime has a 0 value at socket creation time. > > tcpi_last_data_recv can have bogus value if no payload is ever received. > > This patch initializes

Re: [PATCH 4.11] genetlink: fix counting regression on ctrl_dumpfamily()

2017-03-22 Thread David Miller
From: Stanislaw Gruszka Date: Wed, 22 Mar 2017 16:08:33 +0100 > Commit 2ae0f17df1cd ("genetlink: use idr to track families") replaced > > if (++n < fams_to_skip) > continue; > into: > > if (n++ < fams_to_skip) > continue; > > This

Re: [PATCH net] socket, bpf: fix sk_filter use after free in sk_clone_lock

2017-03-22 Thread David Miller
From: Daniel Borkmann Date: Wed, 22 Mar 2017 13:08:08 +0100 > In sk_clone_lock(), we create a new socket and inherit most of the > parent's members via sock_copy() which memcpy()'s various sections. > Now, in case the parent socket had a BPF socket filter attached, > then

Re: [PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions

2017-03-22 Thread David Miller
From: Joao Pinto Date: Wed, 22 Mar 2017 11:56:05 + > The dma operation mode configuration routine was wrongly moved to a > function (stmmac_mtl_configuration) that is only executed if the > core version is >= 4.00. > > Fixes: 6deee2221e11 ("net: stmmac: prepare dma

[PATCH net] amd-xgbe: Fix the ECC-related bit position definitions

2017-03-22 Thread Tom Lendacky
The ECC bit positions that describe whether the ECC interrupt is for Tx, Rx or descriptor memory and whether the it is a single correctable or double detected error were defined in incorrectly (reversed order). Fix the bit position definitions for these settings so that the proper ECC handling is

Re: [PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

2017-03-22 Thread Pavel Belous
On 03/23/2017 12:44 AM, Florian Fainelli wrote: On 03/22/2017 02:19 PM, Pavel Belous wrote: From: Pavel Belous The following patchset containg several fixes for aQuantia AQtion driver for net tree: A couple fixes for IPv6 and other fixes. v1->v2: Fix compilation

Re: [PATCH 4.11] genetlink: fix counting regression on ctrl_dumpfamily()

2017-03-22 Thread Johannes Berg
On Wed, 2017-03-22 at 16:08 +0100, Stanislaw Gruszka wrote: > Commit 2ae0f17df1cd ("genetlink: use idr to track families") replaced > > if (++n < fams_to_skip) > continue; > into: > > if (n++ < fams_to_skip) > continue; D'oh. I don't know how that ended

[iproute2 net-next 2/3] ip netconf: Show all address families by default in dumps

2017-03-22 Thread David Ahern
Currently, 'ip netconf' only shows ipv4 and ipv6 netconf settings. If IPv6 is not enabled, the dump ends with RTNETLINK answers: Operation not supported when IPv6 request is attempted. Further, if the mpls_router module is also loaded a separate request is needed to get MPLS settings. To

[iproute2 net-next 3/3] ip netconf: Show all families on dev request

2017-03-22 Thread David Ahern
Currently specifying a device to ip netconf and it dumps only values for IPv4. Change this to dump data for all families unless a specific family is given. Signed-off-by: David Ahern --- ip/ipnetconf.c | 23 +-- 1 file changed, 13 insertions(+), 10

[iproute2 net-next 1/3] netlink: Add flag to suppress print of nlmsg error

2017-03-22 Thread David Ahern
Allow callers of the dump API to handle nlmsg errors (e.g., an unsupported feature). Setting RTNL_HANDLE_F_SUPPRESS_NLERR in the rtnl_handle avoids unnecessary messages to the users in some case. For example, RTNETLINK answers: Operation not supported when probing for support of a new feature.

[iproute2 net-next 0/3] ip netconf improvements

2017-03-22 Thread David Ahern
Currently, ip netconf only shows data for ipv4 and ipv6 for dumps and just ipv4 for device requests. Improve the user experience by using the new kernel patch to dump all address families that have registered. For example, if mpls_router module is loaded then mpls values are displayed along with

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-22 Thread Bjorn Andersson
On Wed 22 Mar 11:44 PDT 2017, David Miller wrote: > From: Bjorn Andersson > Date: Mon, 20 Mar 2017 16:35:42 -0700 > > > By moving these client drivers to use RPMSG instead of the direct SMD > > API we can reuse them ontop of the newly added GLINK wire-protocol > >

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-22 Thread Andy Gross
On Wed, Mar 22, 2017 at 11:44:39AM -0700, David Miller wrote: > From: Bjorn Andersson > Date: Mon, 20 Mar 2017 16:35:42 -0700 > > > By moving these client drivers to use RPMSG instead of the direct SMD > > API we can reuse them ontop of the newly added GLINK

Re: Problem: net: mvneta: auto-negotiation with disconnected network cable

2017-03-22 Thread Stas Sergeev
22.03.2017 16:23, Maxime Morin пишет: Hi all, I work on an embedded platform based on the Marvell Armada 88F6707, that is connected to a Marvell Alaska 88E1512 ethernet transceiver. A defect has appeared recently, and it turns out to be a regression on the network part. There is a complete

Re: [PATCH 3/3] soc: qcom: smd-rpm: Add msm8996 compatibility

2017-03-22 Thread Andy Gross
On Mon, Mar 20, 2017 at 04:35:44PM -0700, Bjorn Andersson wrote: > With the RPM driver transitioned to RPMSG we can reuse the SMD-RPM > driver ontop of GLINK for 8996, without any modifications. > > Signed-off-by: Bjorn Andersson Acked-by: Andy Gross

Re: [PATCH 2/3] soc: qcom: smd: Remove standalone driver

2017-03-22 Thread Andy Gross
On Mon, Mar 20, 2017 at 04:35:43PM -0700, Bjorn Andersson wrote: > Remove the standalone SMD implementation as we have transitioned the > client drivers to use the RPMSG based one. > > Also remove all dependencies on QCOM_SMD from Kconfig files, in order to > keep them selectable in the absence

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-22 Thread Andy Gross
On Mon, Mar 20, 2017 at 04:35:42PM -0700, Bjorn Andersson wrote: > By moving these client drivers to use RPMSG instead of the direct SMD > API we can reuse them ontop of the newly added GLINK wire-protocol > support found in the 820 and 835 Qualcomm platforms. > > As the new (RPMSG-based) and old

[PATCH net-next 5/9] netvsc: uses RCU instead of removal flag

2017-03-22 Thread Stephen Hemminger
It is cleaner to use RCU protected pointer (nvdev_ctx->nvdev) to indicate device is in removed state, rather than having a separate boolean flag. By using the pointer the context can be checked by static checkers and dynamic lockdep. Signed-off-by: Stephen Hemminger ---

[PATCH net-next 7/9] netvsc: remove unnecessary lock on shutdown

2017-03-22 Thread Stephen Hemminger
The channel inbound lock was not being used at all by the netvsc device, but the spin_lock was helpful by providing necessary barrier before waiting. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/rndis_filter.c | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH net-next 6/9] netvsc: use refcount_t for keeping track of sub channels

2017-03-22 Thread Stephen Hemminger
Rather than a lock and variable, use a refcount_t to keep track of the number of sub channels. Don't need to wait for subchannels on device removal since wait was already done in device_add. Also fix the error handling; don't wait forever in case of an error on request to create sub channels.

[PATCH net-next 8/9] netvsc: eliminate unnecessary skb == NULL checks

2017-03-22 Thread Stephen Hemminger
Since there already is a special case goto for control messages (skb == NULL) in netvsc_send, there is no need for later checks in same code path. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH net-next 4/9] netvsc: use RCU to protect inner device structure

2017-03-22 Thread Stephen Hemminger
The netvsc driver has an internal structure (netvsc_device) which is created when device is opened and released when device is closed. And also opened/released when MTU or number of channels change. Since this is referenced in the receive and transmit path, it is safer to use RCU to

[PATCH net-next 9/9] netvsc: fix and cleanup rndis_filter_set_packet_filter

2017-03-22 Thread Stephen Hemminger
Fix warning from unused set_complete variable. And rearrange code to eliminate unnecessary goto's. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/rndis_filter.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

[PATCH net-next 3/9] netvsc: change max channel calculation

2017-03-22 Thread Stephen Hemminger
The default number of maximum channels should be limited to the number of cpus available on the numa node of the primary channel. This also makes sure maximum channels <= num_online_cpus Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 3 +--

[PATCH net-next 1/9] netvsc: fix NAPI performance regression

2017-03-22 Thread Stephen Hemminger
When using NAPI, the single stream performance declined signifcantly because the poll routine was updating host after every burst of packets. This excess signalling caused host throttling. This fix restores the old behavior. Host is only signalled after the ring has been emptied. Signed-off-by:

[PATCH net-next 0/9] netvsc: bug fixes and cleanups

2017-03-22 Thread Stephen Hemminger
These fix NAPI issues and bugs found during testing of shutdown testing. Stephen Hemminger (9): netvsc: fix NAPI performance regression netvsc: handle offline mtu and channel change netvsc: change max channel calculation netvsc: use RCU to protect inner device structure netvsc: uses RCU

Re: [PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

2017-03-22 Thread Florian Fainelli
On 03/22/2017 02:19 PM, Pavel Belous wrote: > From: Pavel Belous > > The following patchset containg several fixes for aQuantia AQtion driver > for net tree: A couple fixes for IPv6 and other fixes. > > v1->v2: Fix compilation error (using HW_ATL_A0_TXD_CTL_CMD_IPV6

Re: [patch] sfc: cleanup a condition in efx_udp_tunnel_del()

2017-03-22 Thread Jarod Wilson
On 2017-03-22 5:10 AM, Dan Carpenter wrote: Presumably if there is an "add" function, there is also a "del" function. But it causes a static checker warning because it looks like a common cut and paste bug. Signed-off-by: Dan Carpenter Agreed, looks like a

Re: [PATCH net-next] net: ipv6: Add sysctl for minimum prefix len acceptable in RIOs.

2017-03-22 Thread David Miller
From: Joel Scherpelz Date: Wed, 22 Mar 2017 18:19:04 +0900 > This commit adds a new sysctl accept_ra_rt_info_min_plen that > defines the minimum acceptable prefix length of Route Information > Options. The new sysctl is intended to be used together with >

[PATCH v2 net 4/5] net:ethernet:aquantia: Fix for LSO with IPv6.

2017-03-22 Thread Pavel Belous
From: Pavel Belous Fix Context Command bit: L3 type = "0" for IPv4, "1" for IPv6. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3 +++ drivers/net/ethernet/aquantia/atlantic/aq_ring.h

[PATCH v2 net 5/5] net:ethernet:aquantia: Reset is_gso flag when EOP reached.

2017-03-22 Thread Pavel Belous
From: Pavel Belous We need to reset is_gso flag when EOP reached (entire LSO packet processed). Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 1 +

[PATCH v2 net 1/5] net:ethernet:aquantia: Remove adapter re-opening when mtu changed.

2017-03-22 Thread Pavel Belous
From: Pavel Belous Closing/opening the adapter is not needed at all. The new mtu settings take effect immediately. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_main.c | 5 - 1 file changed, 5 deletions(-)

[PATCH v2 net 3/5] net:ethernet:aquantia: Missing spinlock initialization.

2017-03-22 Thread Pavel Belous
From: Pavel Belous Fix for missing initialization aq_ring header.lock spinlock. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 net 0/5] net:ethernet:aquantia: Misc fixes for atlantic driver.

2017-03-22 Thread Pavel Belous
From: Pavel Belous The following patchset containg several fixes for aQuantia AQtion driver for net tree: A couple fixes for IPv6 and other fixes. v1->v2: Fix compilation error (using HW_ATL_A0_TXD_CTL_CMD_IPV6 instead HW_ATL_B0_TXD_CTL_CMD_IPV6). Pavel

[PATCH v2 net 2/5] net:ethernet:aquantia: Fix packet type detection (TCP/UDP) for IPv6.

2017-03-22 Thread Pavel Belous
From: Pavel Belous In order for the checksum offloads to work correctly we need to set the packet type bit (TCP/UDP) in the TX context buffer. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 20

Re: [PATCH net-next v3] net: Add sysctl to toggle early demux for tcp and udp

2017-03-22 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Tue, 21 Mar 2017 21:20:10 -0600 > @@ -329,7 +329,7 @@ static int ip_rcv_finish(struct net *net, struct sock > *sk, struct sk_buff *skb) > int protocol = iph->protocol; > > ipprot =

Re: [PATCH net] ipv4: provide stronger user input validation in nl_fib_input()

2017-03-22 Thread David Miller
From: Eric Dumazet Date: Tue, 21 Mar 2017 19:22:28 -0700 > From: Eric Dumazet > > Alexander reported a KMSAN splat caused by reads of uninitialized > field (tb_id_in) from user provided struct fib_result_nl > > It turns out nl_fib_input() sanity

Re: [PATCH net] bpf: fix hashmap extra_elems logic

2017-03-22 Thread David Miller
From: Alexei Starovoitov Date: Tue, 21 Mar 2017 19:05:04 -0700 > In both kmalloc and prealloc mode the bpf_map_update_elem() is using > per-cpu extra_elems to do atomic update when the map is full. > There are two issues with it. The logic can be misused, since it allows >

Re: [PATCH net] net:ethernet:aquantia: Fix for RX checksum offload.

2017-03-22 Thread Jarod Wilson
On 2017-03-22 1:21 PM, Pavel Belous wrote: From: Pavel Belous Since AQC-100/107/08 chips supports hardware checksums for RX we should indicate this via NETIF_F_RXCSUM flag. Looks good, and fixes an lnst netperf test failure. Acked-by: Jarod Wilson

Re: [PATCH net 4/5] net:ethernet:aquantia: Fix for LSO with IPv6.

2017-03-22 Thread Pavel Belous
On 03/22/2017 10:21 PM, David Arcari wrote: Hi, On 03/22/2017 01:06 PM, Pavel Belous wrote: From: Pavel Belous Fix Context Command bit: L3 type = "0" for IPv4, "1" for IPv6. Signed-off-by: Pavel Belous ---

[PATCH] net: phy: handle state correctly in phy_stop_machine

2017-03-22 Thread Zach Brown
From: Nathan Sullivan If the PHY is halted on stop, then do not set the state to PHY_UP. This ensures the phy will be restarted later in phy_start when the machine is started again. Signed-off-by: Nathan Sullivan Signed-off-by: Brad Mouring

Re: [PATCH net-next 00/15] nfp: allow concurrency in core and minor fixes

2017-03-22 Thread David Miller
From: Jakub Kicinski Date: Tue, 21 Mar 2017 17:59:06 -0700 > The first 10 patches of this series prepare nfpcore for concurrent > accesses. This will be needed by upcoming hwmon and devlink patches. > Most locking is already in place, the patches in this series

Re: [PATCH net] net: bcmgenet: remove bcmgenet_internal_phy_setup()

2017-03-22 Thread David Miller
From: Doug Berger Date: Tue, 21 Mar 2017 14:01:06 -0700 > Commit 6ac3ce8295e6 ("net: bcmgenet: Remove excessive PHY reset") > removed the bcmgenet_mii_reset() function from bcmgenet_power_up() and > bcmgenet_internal_phy_setup() functions. In so doing it broke the reset > of

Re: [PATCH net-next] enic: update enic maintainers

2017-03-22 Thread David Miller
From: Govindarajulu Varadarajan Date: Tue, 21 Mar 2017 15:07:48 -0700 > update enic maintainers > > Signed-off-by: Govindarajulu Varadarajan MAINTAINERS updates can always go to 'net' (unless it's for something new in 'net-next') so that's where I've

Re: [PATCH net-next] rtnetlink: Add dump all for netconf

2017-03-22 Thread David Miller
From: David Ahern Date: Tue, 21 Mar 2017 12:22:26 -0700 > Use the rtnl_dump_all to dump all netconf handlers that have been > registered. Allows userspace to send a dump request for PF_UNSPEC > and get all families. > > Cc: Nicolas Dichtel >

Re: [patch -next] net: dwc-xlgmac: fix an error code in xlgmac_alloc_pages()

2017-03-22 Thread David Miller
From: Dan Carpenter Date: Tue, 21 Mar 2017 23:42:27 +0300 > The dma_mapping_error() returns true if there is an error but we want > to return -ENOMEM and not 1. > > Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare > Enterprise Ethernet") >

Re: [PATCH net-next 0/7] Clean up PHY MMD accessors

2017-03-22 Thread David Miller
From: Russell King - ARM Linux Date: Tue, 21 Mar 2017 16:35:55 + > This series cleans up phylib's MMD accessors, so that we have a common > way of accessing the Clause 45 register set. > > The current situation is far from ideal - we have phy_(read|write)_mmd() >

Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before first use

2017-03-22 Thread David Miller
From: Alexander Potapenko Date: Tue, 21 Mar 2017 17:14:27 +0100 > In the case udp_sk(sk)->pending is AF_INET6, udpv6_sendmsg() would > jump to do_append_data, skipping the initialization of sockc.tsflags. > Fix the problem by moving sockc.tsflags initialization earlier. > >

Re: [PATCH v3 0/2] fjes: Do not load fjes driver

2017-03-22 Thread David Miller
From: YASUAKI ISHIMATSU Date: Tue, 21 Mar 2017 11:28:02 -0400 > The fjes driver is used only by FUJITSU servers and almost of all > servers in the world never use it. But currently if ACPI PNP0C02 > is defined in the ACPI table, the following message is always shown: > >

Re: [PATCH net-next 1/4] bpf: Fix and simplifications on inline map lookup

2017-03-22 Thread Daniel Borkmann
On 03/22/2017 06:00 PM, Martin KaFai Lau wrote: Fix in verifier: For the same bpf_map_lookup_elem() instruction (i.e. "call 1"), a broken case is "a different type of map could be used for the same lookup instruction". For example, an array in one case and a hashmap in another. We have to

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-22 Thread Marcel Holtmann
Hi Dave, >> By moving these client drivers to use RPMSG instead of the direct SMD >> API we can reuse them ontop of the newly added GLINK wire-protocol >> support found in the 820 and 835 Qualcomm platforms. >> >> As the new (RPMSG-based) and old SMD implementations are mutually >> exclusive we

[PATCH v1] NFC: Add nfc_dbg() macro

2017-03-22 Thread Andy Shevchenko
In some cases nfc_dbg() is useful. Add such macro to a header. Signed-off-by: Andy Shevchenko --- include/net/nfc/nfc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h index 1a3de8b34ad2..bbdc73a3239d 100644

Re: [PATCH net-next v7 2/3] Add a eBPF helper function to retrieve socket uid

2017-03-22 Thread Alexei Starovoitov
On 3/22/17 5:06 AM, Lorenzo Colitti wrote: On Wed, Mar 22, 2017 at 8:09 PM, Willem de Bruijn wrote: + if (!sk || !sk_fullsock(sk)) + return overflowuid; + kuid = sock_net_uid(sock_net(sk), sk); + return from_kuid_munged(_user_ns,

Re: [PATCH net 4/5] net:ethernet:aquantia: Fix for LSO with IPv6.

2017-03-22 Thread David Arcari
Hi, On 03/22/2017 01:06 PM, Pavel Belous wrote: > From: Pavel Belous > > Fix Context Command bit: L3 type = "0" for IPv4, "1" for IPv6. > > Signed-off-by: Pavel Belous > --- > drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3

[PATCH v1] NFC: netlink: Use error code from nfc_activate_target()

2017-03-22 Thread Andy Shevchenko
It looks like a typo to assign a return code to a variable which is not used. Found due to a compiler warning: net/nfc/netlink.c: In function ‘nfc_genl_activate_target’: net/nfc/netlink.c:903:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] int rc; ^~

Re: [PATCH 3/3] net: stmmac: Use AVB mode by default

2017-03-22 Thread David Miller
From: Thierry Reding Date: Tue, 21 Mar 2017 16:12:11 +0100 > From: Thierry Reding > > Prior to the recent multi-queue changes the driver would configure the > queues to use the AVB mode, but the mode then got switched to DCB. The > hardware still

Re: [PATCH 2/3] net: stmmac: Restore DT backwards-compatibility

2017-03-22 Thread David Miller
From: Thierry Reding Date: Tue, 21 Mar 2017 16:12:10 +0100 > From: Thierry Reding > > Recent changes to support multiple queues in the device tree bindings > resulted in the number of RX and TX queues to be initialized to zero for > device trees

  1   2   3   >