[PATCH v2 net-next 5/6] selftests/bpf: add a test for basic XDP functionality

2017-03-30 Thread Alexei Starovoitov
add C test for xdp_adjust_head(), packet rewrite and map lookups Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/testing/selftests/bpf/Makefile | 2 +-

[PATCH v2 net-next 0/6] bpf: program testing framework

2017-03-30 Thread Alexei Starovoitov
Development and testing of networking bpf programs is quite cumbersome. Especially tricky are XDP programs that attach to real netdevices and program development feels like working on the car engine while the car is in motion. Another problem is ongoing changes to upstream llvm core that can

[PATCH v2 net-next 4/6] selftests/bpf: add a test for overlapping packet range checks

2017-03-30 Thread Alexei Starovoitov
add simple C test case for llvm and verifier range check fix from commit b1977682a385 ("bpf: improve verifier packet range checks") Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau ---

[PATCH v2 net-next 3/6] tools/lib/bpf: expose bpf_program__set_type()

2017-03-30 Thread Alexei Starovoitov
expose bpf_program__set_type() to set program type Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/lib/bpf/libbpf.c | 3 +-- tools/lib/bpf/libbpf.h | 2 ++ 2 files changed, 3 insertions(+), 2

[PATCH v2 net-next 6/6] selftests/bpf: add l4 load balancer test based on sched_cls

2017-03-30 Thread Alexei Starovoitov
this l4lb demo is a comprehensive test case for LLVM codegen and kernel verifier. It's using fully inlined jhash(), complex packet parsing and multiple map lookups of different types to stress llvm and verifier. The map sizes, map population and test vectors are artificial to exercise different

[PATCH v2 net-next 2/6] tools/lib/bpf: add support for BPF_PROG_TEST_RUN command

2017-03-30 Thread Alexei Starovoitov
add support for BPF_PROG_TEST_RUN command to libbpf.a Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h | 24 tools/lib/bpf/bpf.c|

[PATCH v2 net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command

2017-03-30 Thread Alexei Starovoitov
development and testing of networking bpf programs is quite cumbersome. Despite availability of user space bpf interpreters the kernel is the ultimate authority and execution environment. Current test frameworks for TC include creation of netns, veth, qdiscs and use of various packet generators

Re: [PATCH V2 net-next 5/7] tun: support receiving skb through msg_control

2017-03-30 Thread Jason Wang
On 2017年03月30日 23:06, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 03:22:28PM +0800, Jason Wang wrote: This patch makes tun_recvmsg() can receive from skb from its caller through msg_control. Vhost_net will be the first user. Signed-off-by: Jason Wang Do we need to

Re: [PATCH V2 net-next 6/7] tap: support receiving skb from msg_control

2017-03-30 Thread Jason Wang
On 2017年03月30日 23:03, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 03:22:29PM +0800, Jason Wang wrote: This patch makes tap_recvmsg() can receive from skb from its caller through msg_control. Vhost_net will be the first user. Signed-off-by: Jason Wang ---

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-03-30 Thread Jason Wang
On 2017年03月30日 22:32, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote: On 2017年03月30日 04:48, Michael S. Tsirkin wrote: We are going to add more parameters to find_vqs, let's wrap the call so we don't need to tweak all drivers every time. Signed-off-by:

Re: [PATCH V2 net-next 7/7] vhost_net: try batch dequing from skb array

2017-03-30 Thread Jason Wang
On 2017年03月30日 22:21, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 03:22:30PM +0800, Jason Wang wrote: We used to dequeue one skb during recvmsg() from skb_array, this could be inefficient because of the bad cache utilization which cache does this refer to btw? Both icache and dcache

Re: [PATCH V2 net-next 1/7] ptr_ring: introduce batch dequeuing

2017-03-30 Thread Jason Wang
On 2017年03月30日 21:53, Michael S. Tsirkin wrote: On Thu, Mar 30, 2017 at 03:22:24PM +0800, Jason Wang wrote: This patch introduce a batched version of consuming, consumer can dequeue more than one pointers from the ring at a time. We don't care about the reorder of reading here so no need for

[PATCH] treewide: Correct diffrent[iate] and banlance typos

2017-03-30 Thread Joe Perches
Add these misspellings to scripts/spelling.txt too Signed-off-by: Joe Perches --- drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +-

Re: [PATCH net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command

2017-03-30 Thread Wangnan (F)
On 2017/3/31 11:24, Alexei Starovoitov wrote: On 3/30/17 8:12 PM, Wangnan (F) wrote: On 2017/3/31 10:57, Alexei Starovoitov wrote: On 3/30/17 7:53 PM, Wangnan (F) wrote: I suggest using a CONFIG option to enable/disable code in test_run.o to reduce attack plane. attack plane? what

Re: [PATCH net-next] sock: avoid dirtying sk_stamp, if possible

2017-03-30 Thread David Miller
From: Paolo Abeni Date: Thu, 30 Mar 2017 14:03:06 +0200 > sock_recv_ts_and_drops() unconditionally set sk->sk_stamp for > every packet, even if the SOCK_TIMESTAMP flag is not set in the > related socket. > If selinux is enabled, this cause a cache miss for every packet > since

Re: [PATCH 1/2] virtio: allow drivers to validate features

2017-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2017 at 12:39:31PM -0700, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Wed, 29 Mar 2017 20:14:44 +0300 > > > Some drivers can't support all features in all configurations. At the > > moment we blindly set FEATURES_OK and later FAILED. Support this

Re: [PATCH net-next 2/6] tools/lib/bpf: add support for BPF_PROG_TEST_RUN command

2017-03-30 Thread Alexei Starovoitov
On 3/30/17 8:15 PM, Wangnan (F) wrote: - +int bpf_program_test_run(int prog_fd, int repeat, void *data, __u32 size, + void *data_out, __u32 *size_out, __u32 *retval, + __u32 *duration); Please call it bpf_prog_test_run() so it looks uniform with others. sure. will

Re: [PATCH net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command

2017-03-30 Thread Alexei Starovoitov
On 3/30/17 8:12 PM, Wangnan (F) wrote: On 2017/3/31 10:57, Alexei Starovoitov wrote: On 3/30/17 7:53 PM, Wangnan (F) wrote: I suggest using a CONFIG option to enable/disable code in test_run.o to reduce attack plane. attack plane? what attack do you see and how config helps? I think all

Re: [PATCH net-next 2/6] tools/lib/bpf: add support for BPF_PROG_TEST_RUN command

2017-03-30 Thread Wangnan (F)
On 2017/3/31 9:31, Alexei Starovoitov wrote: add support for BPF_PROG_TEST_RUN command to libbpf.a Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h | 24

Re: [PATCH net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command

2017-03-30 Thread Wangnan (F)
On 2017/3/31 10:57, Alexei Starovoitov wrote: On 3/30/17 7:53 PM, Wangnan (F) wrote: I suggest using a CONFIG option to enable/disable code in test_run.o to reduce attack plane. attack plane? what attack do you see and how config helps? I think all testing features are not required to be

Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements

2017-03-30 Thread David Miller
From: Salil Mehta Date: Thu, 30 Mar 2017 16:30:47 +0100 > This patch set introduces various HNS bug fixes, optimizations and code > improvements. There is no way you should do such an expensive calculation for every single transmit packet as you are doing in your

Re: [PATCH net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command

2017-03-30 Thread Alexei Starovoitov
On 3/30/17 7:53 PM, Wangnan (F) wrote: I suggest using a CONFIG option to enable/disable code in test_run.o to reduce attack plane. attack plane? what attack do you see and how config helps?

Re: [PATCH net-next 4/6] tools/lib/bpf: expose bpf_program__set_type()

2017-03-30 Thread Alexei Starovoitov
On 3/30/17 7:48 PM, Wangnan (F) wrote: On 2017/3/31 10:37, Alexei Starovoitov wrote: On 3/30/17 7:33 PM, Wangnan (F) wrote: +void bpf_program__set_type(struct bpf_program *prog, enum bpf_prog_type type); This makes libbpf.h depend on uapi/linux/bpf.h (because of enum bpf_prog_type), which

Re: [PATCH net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command

2017-03-30 Thread Wangnan (F)
On 2017/3/31 9:31, Alexei Starovoitov wrote: development and testing of networking bpf programs is quite cumbersome. Despite availability of user space bpf interpreters the kernel is the ultimate authority and execution environment. Current test frameworks for TC include creation of netns,

hello dear

2017-03-30 Thread terumi barger
Hello nice to meet you my name is Terumi. Your profile really impressed me, send me a message  through my private email address (terumibar...@gmail.com) so that i will tell you more about me and send my pictures to you . I'm looking forward to hear from you.

Re: [PATCH net-next 4/6] tools/lib/bpf: expose bpf_program__set_type()

2017-03-30 Thread Wangnan (F)
On 2017/3/31 10:37, Alexei Starovoitov wrote: On 3/30/17 7:33 PM, Wangnan (F) wrote: +void bpf_program__set_type(struct bpf_program *prog, enum bpf_prog_type type); This makes libbpf.h depend on uapi/linux/bpf.h (because of enum bpf_prog_type), which is not always available. What about

Re: [PATCH net-next v2 5/6] net: mpls: bump maximum number of labels

2017-03-30 Thread kbuild test robot
Hi David, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Ahern/net-mpls-Allow-users-to-configure-more-labels-per-route/20170331-080314 config: x86_64-randconfig-ne0-03310806 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0

Re: [PATCH net-next 4/6] tools/lib/bpf: expose bpf_program__set_type()

2017-03-30 Thread Alexei Starovoitov
On 3/30/17 7:33 PM, Wangnan (F) wrote: +void bpf_program__set_type(struct bpf_program *prog, enum bpf_prog_type type); This makes libbpf.h depend on uapi/linux/bpf.h (because of enum bpf_prog_type), which is not always available. What about defining another enum inside libbpf.h? how about

Re: [PATCH net-next 4/6] tools/lib/bpf: expose bpf_program__set_type()

2017-03-30 Thread Wangnan (F)
On 2017/3/31 9:31, Alexei Starovoitov wrote: expose bpf_program__set_type() to set program type Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/lib/bpf/libbpf.c | 3 +--

[PATCH net-next v2] net: dsa: Mock-up driver

2017-03-30 Thread Florian Fainelli
This patch adds support for a DSA mock-up driver which essentially does the following: - registers/unregisters 4 fixed PHYs to the slave network devices - uses eth0 (configurable) as the master netdev - registers the switch as a fixed MDIO device against the fixed MDIO bus at address 31 -

[PATCH net-next 5/6] selftests/bpf: add a test for basic XDP functionality

2017-03-30 Thread Alexei Starovoitov
add C test for xdp_adjust_head(), packet rewrite and map lookups Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/testing/selftests/bpf/Makefile | 2 +-

[PATCH net-next 2/6] tools/lib/bpf: add support for BPF_PROG_TEST_RUN command

2017-03-30 Thread Alexei Starovoitov
add support for BPF_PROG_TEST_RUN command to libbpf.a Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/include/uapi/linux/bpf.h | 24 tools/lib/bpf/bpf.c|

[PATCH net-next 6/6] selftests/bpf: add l4 load balancer test based on sched_cls

2017-03-30 Thread Alexei Starovoitov
this l4lb demo is a comprehensive test case for LLVM codegen and kernel verifier. It's using fully inlined jhash(), complex packet parsing and multiple map lookups of different types to stress llvm and verifier. The map sizes, map population and test vectors are artificial to exercise different

[PATCH net-next 3/6] selftests/bpf: add a test for overlapping packet range checks

2017-03-30 Thread Alexei Starovoitov
add simple C test case for llvm and verifier range check fix from commit b1977682a385 ("bpf: improve verifier packet range checks") Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau ---

[PATCH net-next 4/6] tools/lib/bpf: expose bpf_program__set_type()

2017-03-30 Thread Alexei Starovoitov
expose bpf_program__set_type() to set program type Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by: Martin KaFai Lau --- tools/lib/bpf/libbpf.c | 3 +-- tools/lib/bpf/libbpf.h | 1 + 2 files changed, 2 insertions(+), 2

[PATCH net-next 1/6] bpf: introduce BPF_PROG_TEST_RUN command

2017-03-30 Thread Alexei Starovoitov
development and testing of networking bpf programs is quite cumbersome. Despite availability of user space bpf interpreters the kernel is the ultimate authority and execution environment. Current test frameworks for TC include creation of netns, veth, qdiscs and use of various packet generators

[PATCH net-next 0/6] bpf: program testing framework

2017-03-30 Thread Alexei Starovoitov
Development and testing of networking bpf programs is quite cumbersome. Especially tricky are XDP programs that attach to real netdevices and program development feels like working on the car engine while the car is in motion. Another problem is ongoing changes to upstream llvm core that can

Re: [next-queue v6 PATCH 7/7] i40e: Add support to get switch id and port number for port netdevs

2017-03-30 Thread Jakub Kicinski
On Thu, 30 Mar 2017 15:31:01 -0700, Alexander Duyck wrote: > On Thu, Mar 30, 2017 at 2:45 PM, Jakub Kicinski > wrote: > > On Wed, 29 Mar 2017 17:22:55 -0700, Sridhar Samudrala wrote: > >> Introduce switchdev_ops to PF and port netdevs to return the switch id via >

RE: [PATCH nf-next 1/1] net: tcp: Refine the __tcp_select_window

2017-03-30 Thread Gao Feng
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of David Miller > Sent: Friday, March 31, 2017 6:42 AM > To: gfree.w...@foxmail.com > Cc: kuz...@ms2.inr.ac.ru; jmor...@namei.org; netdev@vger.kernel.org; > f...@ikuai8.com >

[PATCH net 3/3] bpf: add various verifier test cases for self-tests

2017-03-30 Thread Daniel Borkmann
Add a couple of test cases, for example, probing for xadd on a spilled pointer to packet and map_value_adj register, various other map_value_adj tests including the unaligned load/store, and trying out pointer arithmetic on map_value_adj register itself. For the unaligned load/store, we need to

[PATCH net 1/3] bpf, verifier: fix alu ops against map_value{,_adj} register types

2017-03-30 Thread Daniel Borkmann
While looking into map_value_adj, I noticed that alu operations directly on the map_value() resp. map_value_adj() register (any alu operation on a map_value() register will turn it into a map_value_adj() typed register) are not sufficiently protected against some of the operations. Two

[PATCH net 2/3] bpf, verifier: fix rejection of unaligned access checks for map_value_adj

2017-03-30 Thread Daniel Borkmann
Currently, the verifier doesn't reject unaligned access for map_value_adj register types. Commit 484611357c19 ("bpf: allow access into map value arrays") added logic to check_ptr_alignment() extending it from PTR_TO_PACKET to also PTR_TO_MAP_VALUE_ADJ, but for PTR_TO_MAP_VALUE_ADJ no enforcement

[PATCH net 0/3] BPF fixes on map_value_adj reg types

2017-03-30 Thread Daniel Borkmann
This set adds two fixes for map_value_adj register type in the verifier and user space tests along with them for the BPF self test suite. For details, please see individual patches. Thanks! Daniel Borkmann (3): bpf, verifier: fix alu ops against map_value{,_adj} register types bpf, verifier:

Re: EINVAL when using connect() for udp sockets

2017-03-30 Thread Eric Dumazet
On Thu, 2017-03-30 at 16:36 -0700, Cong Wang wrote: > On Tue, Mar 28, 2017 at 5:52 PM, Eric Dumazet wrote: > > On Tue, 2017-03-28 at 16:11 -0700, Eric Dumazet wrote: > > > >> Yes, this looks better. > >> > >> Although you probably need to change a bit later this part : >

Re: EINVAL when using connect() for udp sockets

2017-03-30 Thread Cong Wang
On Tue, Mar 28, 2017 at 5:52 PM, Eric Dumazet wrote: > On Tue, 2017-03-28 at 16:11 -0700, Eric Dumazet wrote: > >> Yes, this looks better. >> >> Although you probably need to change a bit later this part : >> >> if (!inet->inet_saddr) >> inet->inet_saddr =

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-30 Thread Bjorn Helgaas
On Mon, Mar 27, 2017 at 10:29:36AM +0200, Christoph Hellwig wrote: > Unused now that all callers switched to pci_alloc_irq_vectors. > > Signed-off-by: Christoph Hellwig Acked-by: Bjorn Helgaas I assume this will be merged with the rest via the netdev tree. >

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-30 Thread David Daney
On 03/30/2017 03:56 PM, Bjorn Helgaas wrote: On Tue, Mar 28, 2017 at 09:24:15AM -0700, David Daney wrote: On 03/27/2017 11:41 PM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: Use pci_enable_msix_{exact,range} for now, as I told you before. That

Re: [PATCH net] be2net: Fix endian issue in logical link config command

2017-03-30 Thread David Miller
From: Suresh Reddy Date: Thu, 30 Mar 2017 00:58:32 -0400 > Use cpu_to_le32() for link_config variable in set_logical_link_config > command as this variable is of type u32. > > Signed-off-by: Suresh Reddy Applied.

Re: [PATCH net 0/7] ibmvnic: Cleanup resource handling

2017-03-30 Thread David Miller
From: Nathan Fontenot Date: Thu, 30 Mar 2017 02:48:49 -0400 > In order to better manage the resources of the ibmvnic driver, this set of > patches creates a set of initialization and release routines for the > drivers resources. Additionally, some patches do some

[PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-30 Thread Joe Perches
Fix fallout too. Signed-off-by: Joe Perches --- drivers/net/wireless/ath/ath6kl/debug.h| 2 ++ drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 5/5] PCI: remove pci_enable_msix

2017-03-30 Thread Bjorn Helgaas
On Tue, Mar 28, 2017 at 09:24:15AM -0700, David Daney wrote: > On 03/27/2017 11:41 PM, Christoph Hellwig wrote: > >On Mon, Mar 27, 2017 at 10:30:46AM -0700, David Daney wrote: > >>>Use pci_enable_msix_{exact,range} for now, as I told you before. > >>> > >> > >>That still results in twice as many

Re: [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h

2017-03-30 Thread Joel Stanley
On Fri, Mar 31, 2017 at 2:30 AM, Mark Brown wrote: > This driver uses interfaces from linux/of.h and linux/property.h but > relies on implict inclusion of those headers which means that changes in > other headers could break the build, as happened in -next for arm today. > Add

Re: [PATCH nf-next 1/1] net: tcp: Refine the __tcp_select_window

2017-03-30 Thread David Miller
From: gfree.w...@foxmail.com Date: Thu, 30 Mar 2017 06:49:19 +0800 > From: Gao Feng > > 1. Move the "window = tp->rcv_wnd;" into the condition block without > tp->rx_opt.rcv_wscale. > Because it is unnecessary when enable wscale; > > 2. Use the macro ALIGN instead of two

Re: [PATCH RESEND net-next] net: dsa: mv88e6xxx: debug ATU Age Time

2017-03-30 Thread David Miller
From: Vivien Didelot Date: Wed, 29 Mar 2017 15:38:37 -0400 > The ATU ageing time value programmed in the switch is rounded up to the > nearest multiple of its coefficient (variable depending on the model.) > > Add a debug message to inform the user about the

Re: [next-queue v6 PATCH 7/7] i40e: Add support to get switch id and port number for port netdevs

2017-03-30 Thread Alexander Duyck
On Thu, Mar 30, 2017 at 2:45 PM, Jakub Kicinski wrote: > On Wed, 29 Mar 2017 17:22:55 -0700, Sridhar Samudrala wrote: >> Introduce switchdev_ops to PF and port netdevs to return the switch id via >> SWITCHDEV_ATTR_ID_PORT_PARENT_ID attribute. >> Also,

Re: [next-queue v6 PATCH 7/7] i40e: Add support to get switch id and port number for port netdevs

2017-03-30 Thread Jakub Kicinski
On Wed, 29 Mar 2017 17:22:55 -0700, Sridhar Samudrala wrote: > Introduce switchdev_ops to PF and port netdevs to return the switch id via > SWITCHDEV_ATTR_ID_PORT_PARENT_ID attribute. > Also, ndo_get_phys_port_name() support is added to port netdevs to return > the port number. > ... > +static

[PATCH net-next v2 2/9] net: dsa: mv88e6xxx: use 4-bit port for PVT data

2017-03-30 Thread Vivien Didelot
The Cross-chip Port Based VLAN Table (PVT) supports two indexing modes, one using 5-bit for device and 4-bit for port, the other using 4-bit for device and 5-bit for port, configured via the Global 2 Misc register. Only 4 bits for the source port are needed when interconnecting 88E6xxx switch

[PATCH net-next v2 8/9] net: dsa: add cross-chip bridging operations

2017-03-30 Thread Vivien Didelot
Introduce crosschip_bridge_{join,leave} operations in the dsa_switch_ops structure, which can be used by switches supporting interconnection. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 8 net/dsa/switch.c | 12 ++-- 2 files

[PATCH net-next v2 6/9] net: dsa: mv88e6xxx: factorize in-chip bridge map

2017-03-30 Thread Vivien Didelot
Factorize the code in the DSA port_bridge_{join,leave} routines used to program the port VLAN map of all local ports of a given bridge group. At the same time shorten the _mv88e6xxx_port_based_vlan_map to get rid of the old underscore prefix naming convention. Signed-off-by: Vivien Didelot

Re: [PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-30 Thread David Ahern
On 3/30/17 9:21 AM, Vladislav Yasevich wrote: > > So, something like the patch below would be better in your opinion as a > starting point. It'll can at least get the discussion strarted on whether > an event would usefull to user space or not. IMO that is a more direct, explicit statement of

[PATCH net-next v2 3/9] net: dsa: mv88e6xxx: program the PVT with all ones

2017-03-30 Thread Vivien Didelot
The Cross-chip Port Based VLAN Table (PVT) is currently initialized with all ones, allowing any external ports to egress frames on local ports. This commit implements the PVT access functions and programs the PVT with all ones for the local switch ports only, instead of using the Init operation.

[PATCH net-next v2 9/9] net: dsa: mv88e6xxx: add cross-chip bridging

2017-03-30 Thread Vivien Didelot
Implement the DSA cross-chip bridging operations by remapping the local ports an external source port can egress frames to, when this cross-chip port joins or leaves a bridge. The PVT is no longer configured with all ones allowing any external frame to egress any local port. Only DSA and CPU

[PATCH net-next v2 7/9] net: dsa: mv88e6xxx: remap existing bridge members

2017-03-30 Thread Vivien Didelot
When a local port of a switch chip becomes a member of a bridge group, we need to reprogram the Cross-chip Port Based VLAN Table (PVT) to allow existing cross-chip bridge members to egress frames on the new ports. There is no functional changes yet, since the PVT is still programmed with all

[PATCH net-next v2 4/9] net: dsa: mv88e6xxx: allocate the number of ports

2017-03-30 Thread Vivien Didelot
The current code allocates DSA_MAX_PORTS ports for a Marvell dsa_switch structure. Provide the exact number of ports so the corresponding ds->num_ports is accurate. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1

[PATCH net-next v2 0/9] net: dsa: mv88e6xxx: program cross-chip bridging

2017-03-30 Thread Vivien Didelot
The purpose of this patch series is to bring hardware cross-chip bridging configuration to the DSA layer and the mv88e6xxx DSA driver. Most recent Marvell switch chips have a Cross-chip Port Based VLAN Table (PVT) used to restrict to which internal destination port an arbitrary external source

[PATCH net-next v2 1/9] net: dsa: mv88e6xxx: move PVT description in info

2017-03-30 Thread Vivien Didelot
Not all Marvell switch chips feature a Cross-chip Port VLAN Table (PVT). Chips with a PVT use the same implementation, so a new mv88e6xxx_ops member won't be necessary yet. Add a "pvt" boolean member to the mv88e6xxx_info structure and kill the obsolete MV88E6XXX_FLAGS_PVT flag. Add a

[PATCH net-next v2 5/9] net: dsa: mv88e6xxx: rework in-chip bridging

2017-03-30 Thread Vivien Didelot
All ports -- internal and external, for chips featuring a PVT -- have a mask restricting to which internal ports a frame is allowed to egress. Now that DSA exposes the number of ports and their bridge devices, it is possible to extract the code generating the VLAN map and make it generic so that

[PATCH] net: batman-adv: use new api ethtool_{get|set}_link_ksettings

2017-03-30 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. I've only compiled this change. If someone may test it, it would be very nice. Signed-off-by: Philippe Reynes --- net/batman-adv/soft-interface.c | 25

Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

2017-03-30 Thread Rene Rebe
> On Thu, 2017-03-30 at 19:47 +0200, René Rebe wrote: > > Hi, > > > > On Mar 30, 2017, at 19:06, Dan Williams wrote: > > > > > On Tue, 2017-03-28 at 06:42 +0200, Rene Rebe wrote: > > > > Without this the generic cdc_ether grabs the device, > > > > and does not really work. > >

[PATCH] r8152: The Microsoft Surface docks also use R8152 v2

2017-03-30 Thread Rene Rebe
Without this the generic cdc_ether grabs the device, and does not really work. Signed-off-by: René Rebe diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index f5552aa..f3ae88f 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@

Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update()

2017-03-30 Thread Jiri Benc
On Thu, 30 Mar 2017 12:36:03 -0700, Yi-Hung Wei wrote: > ovs_flow_key_update() is called when the flow key is invalid, and it is > used to update and revalidate the flow key. Commit 329f45bc4f19 > ("openvswitch: add mac_proto field to the flow key") introduces mac_proto > field to flow key and use

Re: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs

2017-03-30 Thread Florian Fainelli
On 03/27/2017 04:59 AM, Roger Quadros wrote: > The Ethernet link on an interrupt driven PHY was not coming up if the > Ethernet cable was plugged before the Ethernet interface was brought up. > > The PHY state machine seems to be stuck from RUNNING to AN state > with no new interrupts from the

[PATCH net v2] openvswitch: Fix ovs_flow_key_update()

2017-03-30 Thread Yi-Hung Wei
ovs_flow_key_update() is called when the flow key is invalid, and it is used to update and revalidate the flow key. Commit 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key") introduces mac_proto field to flow key and use it to determine whether the flow key is valid. However, the

Re: [PATCH net] ibmvnic: Remove debugfs support

2017-03-30 Thread David Miller
From: Nathan Fontenot Date: Wed, 29 Mar 2017 15:14:55 -0400 > The debugfs support in the ibmvnic driver is not, and never has been, > supported. Just remove it. > > The work done in the debugfs code for the driver was part of the original > spec for the ibmvnic driver.

Re: [PATCH net-next] bonding: refine bond_fold_stats() wrap detection

2017-03-30 Thread David Miller
From: Eric Dumazet Date: Wed, 29 Mar 2017 10:45:44 -0700 > From: Eric Dumazet > > Some device drivers reset their stats at down/up events, possibly > fooling bonding stats, since they operate with relative deltas. > > It is nearly not possible to

Re: [PATCH v3] net/utils: generic inet_pton_with_scope helper

2017-03-30 Thread David Miller
From: Sagi Grimberg Date: Wed, 29 Mar 2017 20:48:44 +0300 > Several locations in the stack need to handle ipv4/ipv6 > (with scope) and port strings conversion to sockaddr. > Add a helper that takes either AF_INET, AF_INET6 or > AF_UNSPEC (for wildcard) to centralize this

Re: [PATCH 1/2] virtio: allow drivers to validate features

2017-03-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 29 Mar 2017 20:14:44 +0300 > Some drivers can't support all features in all configurations. At the > moment we blindly set FEATURES_OK and later FAILED. Support this better > by adding a callback drivers can use to do some early checks. >

Re: [PATCH net] openvswitch: Fix ovs_flow_key_update()

2017-03-30 Thread Jiri Benc
On Thu, 30 Mar 2017 11:39:35 -0700, Yi-Hung Wei wrote: > If we invalidate a flow key of a L3 packet, the flow's mac_proto is like this > (MAC_PROTO_NONE | SW_FLOW_KEY_INVALID), then key_extract() will > process the link layer of this L3 packet since mac_proto !=MAC_PROTO_NONE? > > In this case,

Re: [PATCH net] openvswitch: Fix ovs_flow_key_update()

2017-03-30 Thread Yi-Hung Wei
On Thu, Mar 30, 2017 at 6:22 AM, Jiri Benc wrote: > On Wed, 29 Mar 2017 17:14:10 -0700, Yi-Hung Wei wrote: >> ovs_flow_key_update() is called when the flow key is invalid, and it is >> used to update and revalidate the flow key. Commit 329f45bc4f19 >> ("openvswitch: add

Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

2017-03-30 Thread Dan Williams
On Thu, 2017-03-30 at 19:47 +0200, René Rebe wrote: > Hi, > > On Mar 30, 2017, at 19:06, Dan Williams wrote: > > > On Tue, 2017-03-28 at 06:42 +0200, Rene Rebe wrote: > > > Without this the generic cdc_ether grabs the device, > > > and does not really work. > > > > Does this

Re: [PATCH net] sctp: alloc stream info when initializing asoc

2017-03-30 Thread David Miller
From: Xin Long Date: Thu, 30 Mar 2017 01:00:53 +0800 > When sending a msg without asoc established, sctp will send INIT packet > first and then enqueue chunks. > > Before receiving INIT_ACK, stream info is not yet alloced. But enqueuing > chunks needs to access stream

Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value

2017-03-30 Thread David Miller
From: Colin King Date: Wed, 29 Mar 2017 16:33:55 +0100 > From: Colin Ian King > > Rather than assign the positive errno values to ret and then > checking if it is positive and flip the sign, just return the > errno value. > > Detected by

Re: [PATCH net v2 0/3] net/packet: fix multiple overflow issues in ring buffers

2017-03-30 Thread David Miller
From: Andrey Konovalov Date: Wed, 29 Mar 2017 16:11:19 +0200 > This patchset addresses multiple overflows and signedness-related issues > in packet socket ring buffers. > > Changes in v2: > - remove cleanup patches, will send in a separate patchset > - use a > UINT_MAX /

Re: bond procfs hw addr prints

2017-03-30 Thread Jarod Wilson
On 2017-03-13 11:26 PM, Jarod Wilson wrote: On 2017-03-13 10:06 PM, Jarod Wilson wrote: On 2017-03-13 8:28 PM, Jay Vosburgh wrote: Jarod Wilson wrote: I've got a bug report for someone using a Intel OPA devices in a bond, and it appears these devices have a hardware

Re: [PATCH] virtio_net: fix mergeable bufs error handling

2017-03-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 29 Mar 2017 15:37:37 +0300 > @@ -570,7 +570,7 @@ static struct sk_buff *receive_mergeable(struct > net_device *dev, > u16 num_buf; > struct page *page; > int offset; > - struct sk_buff *head_skb, *curr_skb; > +

Re: [PATCH v2] net: stmmac: dwmac-rk: Add handling for RGMII_ID/RXID/TXID

2017-03-30 Thread David Miller
From: Wadim Egorov Date: Wed, 29 Mar 2017 14:12:19 +0200 > ATM dwmac-rk will always set and enable it's internal delay lines. > Using PHY internal delays in combination with the phy-mode > rgmii-id/rxid/txid was not possible. Only rgmii was supported. > > Now we can disable

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

2017-03-30 Thread David Miller
From: Thierry Reding Date: Thu, 30 Mar 2017 16:34:36 +0200 > On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: >> > From: Arnd Bergmann >> > Date: Tue, 28 Mar 2017 11:48:21 +0200 >>

Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

2017-03-30 Thread René Rebe
Hi, On Mar 30, 2017, at 19:06, Dan Williams wrote: > On Tue, 2017-03-28 at 06:42 +0200, Rene Rebe wrote: >> Without this the generic cdc_ether grabs the device, >> and does not really work. > > Does this need a corresponding blacklist in cdc_ether then? Otherwise > you're

RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements

2017-03-30 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, March 30, 2017 6:22 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net 00/19] net:

Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements

2017-03-30 Thread David Miller
From: Salil Mehta Date: Thu, 30 Mar 2017 17:19:44 + > >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Thursday, March 30, 2017 6:09 PM >> To: Salil Mehta >> Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; >>

RE: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements

2017-03-30 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, March 30, 2017 6:09 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil@gmail.com; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net 00/19] net:

Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code Improvements

2017-03-30 Thread David Miller
From: Salil Mehta Date: Thu, 30 Mar 2017 16:30:47 +0100 > This patch set introduces various HNS bug fixes, optimizations and code > improvements. What tree are you targetting? You say "net" in your Subject lines, but this series has cleanups and all sorts of other

Re: [PATCH] r8152: The Microsoft Surface docks also use R8152.

2017-03-30 Thread Dan Williams
On Tue, 2017-03-28 at 06:42 +0200, Rene Rebe wrote: > Without this the generic cdc_ether grabs the device, > and does not really work. Does this need a corresponding blacklist in cdc_ether then? Otherwise you're really depending on driver loading order. Dan > Signed-off-by: René Rebe

[PATCH] r8152: The Microsoft Surface docks also use R8152.

2017-03-30 Thread Rene Rebe
Without this the generic cdc_ether grabs the device, and does not really work. Signed-off-by: René Rebe diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index c34df33..07f788c 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -517,6 +517,7

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

2017-03-30 Thread Joao Pinto
Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: > On 03/30/2017 04:34 PM, Thierry Reding wrote: >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann Date: Tue, 28 Mar 2017

Re: Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

2017-03-30 Thread Niklas Cassel
On 03/30/2017 04:34 PM, Thierry Reding wrote: > On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: >>> From: Arnd Bergmann >>> Date: Tue, 28 Mar 2017 11:48:21 +0200 >>> A driver must not access the

[PATCH net-next v2 2/6] net: mpls: Convert number of nexthops to u8

2017-03-30 Thread David Ahern
Number of nexthops and number of alive nexthops are tracked using an unsigned int. A route should never have more than 255 nexthops so convert both to u8. Update all references and intermediate variables to consistently use u8 as well. Shrinks the size of mpls_route from 32 bytes to 24 bytes with

[PATCH net-next v2 4/6] net: mpls: Limit memory allocation for mpls_route

2017-03-30 Thread David Ahern
Limit memory allocation size for mpls_route to 4096. Signed-off-by: David Ahern --- v2 - new patch in v2 of set net/mpls/af_mpls.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/net/mpls/af_mpls.c

[PATCH net-next v2 0/6] net: mpls: Allow users to configure more labels per route

2017-03-30 Thread David Ahern
Increase the maximum number of new labels for MPLS routes from 2 to 30. To keep memory consumption in check, the labels array is moved to the end of mpls_nh and mpls_iptunnel_encap structs as a 0-sized array. Allocations use the maximum number of labels across all nexthops in a route for LSR and

[PATCH net-next v2 6/6] net: mpls: Increase max number of labels for lwt encap

2017-03-30 Thread David Ahern
Alow users to push down more labels per MPLS encap. Similar to LSR case, move label array to the end of mpls_iptunnel_encap and allocate based on the number of labels for the route. For consistency with the LSR case, re-use the same maximum number of labels. Signed-off-by: David Ahern

  1   2   3   >