[PATCHv4] net: usbnet: support 64bit stats

2017-04-02 Thread Greg Ungerer
Add support for the net stats64 counters to the usbnet core. With that in place put the hooks into every usbnet driver to use it. This is a strait forward addition of 64bit counters for RX and TX packet and byte counts. It is done in the same style as for the other net drivers that support

Re: [PATCH net-next 2/3] virtio-net: transmit napi

2017-04-02 Thread Willem de Bruijn
On Sun, Apr 2, 2017 at 10:30 PM, Michael S. Tsirkin wrote: > On Sun, Apr 02, 2017 at 04:10:11PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> Convert virtio-net to a standard napi tx completion path. This enables >> better TCP pacing using

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-04-02 Thread kbuild test robot
Hi Sean, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: [PATCH net-next 3/3] virtio-net: clean tx descriptors from rx napi

2017-04-02 Thread Willem de Bruijn
On Sun, Apr 2, 2017 at 10:47 PM, Michael S. Tsirkin wrote: > On Sun, Apr 02, 2017 at 04:10:12PM -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> Amortize the cost of virtual interrupts by doing both rx and tx work >> on reception of a receive

Adding support for VRF traffic passed by mangle table

2017-04-02 Thread Jack Ma
Hi David, I formatted a patch to support vrf flow passed by iptables(mangle table). And previously, we lost the flow.oif which would result in a routing look-up failure. This patch wraps vrf response flow with the correct master interface by using the skb->dev, which was set to the real

Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings

2017-04-02 Thread Fengguang Wu
Hi David, On Sun, Apr 02, 2017 at 07:44:02PM -0700, David Miller wrote: From: kbuild test robot Date: Sat, 1 Apr 2017 07:50:55 +0800 drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool

Re: [PATCH net-next 3/3] virtio-net: clean tx descriptors from rx napi

2017-04-02 Thread Michael S. Tsirkin
On Sun, Apr 02, 2017 at 04:10:12PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Amortize the cost of virtual interrupts by doing both rx and tx work > on reception of a receive interrupt if tx napi is enabled. With > VIRTIO_F_EVENT_IDX, this suppresses most

Re: [PATCH] net: hns: fix boolreturn.cocci warnings

2017-04-02 Thread David Miller
From: kbuild test robot Date: Sat, 1 Apr 2017 07:50:55 +0800 > drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of > 0/1 in function 'hns_enable_serdes_lb' with return type bool > > Return statements in functions returning bool should use > true/false

Re: [PATCH] phy/ethtool: Add missing SPEED_ strings

2017-04-02 Thread Joe Perches
On Sun, 2017-04-02 at 15:29 -0700, Florian Fainelli wrote: > Le 04/02/17 à 14:30, Joe Perches a écrit : > > Add all the currently available SPEED_ strings. > > > > Signed-off-by: Joe Perches > > Considering that PHYLIB does not support anything > 10Gbs at the moment, > I am

Re: [PATCH] net: ethernet: ti: cpsw: wake tx queues on ndo_tx_timeout

2017-04-02 Thread David Miller
From: Grygorii Strashko Date: Fri, 31 Mar 2017 18:41:23 -0500 > In case, if TX watchdog is fired some or all netdev TX queues will be > stopped and as part of recovery it is required not only to drain and > reinitailize CPSW TX channeles, but also wake up stoppted TX

Re: [PATCH net-next 0/2] rds: tcp: couple of minor bug fixes

2017-04-02 Thread David Miller
From: Sowmini Varadhan Date: Fri, 31 Mar 2017 15:56:29 -0700 > A couple of minor bugfixes that showed up during testing Series applied, thanks.

Re: [PATCH net-next] sock: correctly test SOCK_TIMESTAMP in sock_recv_ts_and_drops()

2017-04-02 Thread David Miller
From: Eric Dumazet Date: Fri, 31 Mar 2017 14:59:25 -0700 > From: Eric Dumazet > > It seems the code does not match the intent. > > This broke packetdrill, and probably other programs. > > Fixes: 6c7c98bad488 ("sock: avoid dirtying sk_stamp, if

Re: [patch 2/2] drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: fix build with gcc-4.4.4

2017-04-02 Thread David Miller
From: a...@linux-foundation.org Date: Fri, 31 Mar 2017 13:09:41 -0700 > From: Andrew Morton > Subject: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: fix build with > gcc-4.4.4 > > drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function >

Re: [patch 1/2] drivers/net/ethernet/mellanox/mlx5/core/en_main.c: fix build with gcc-4.4.4

2017-04-02 Thread David Miller
From: a...@linux-foundation.org Date: Fri, 31 Mar 2017 13:09:38 -0700 > From: Andrew Morton > Subject: drivers/net/ethernet/mellanox/mlx5/core/en_main.c: fix build with > gcc-4.4.4 > > drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function >

Re: [PATCH] net: stmmac: fix cbs configuration

2017-04-02 Thread David Miller
From: Joao Pinto Date: Fri, 31 Mar 2017 14:22:02 +0100 > Sending again, because forgot to include net-dev. > > The QoS IP does not accept AVB capabilities to default/queue 0, this way we > guarantee 75% bandwidth for AVB. This patch assures that only queues >= 1 > gets

Re: [PATCH net-next 2/3] virtio-net: transmit napi

2017-04-02 Thread Michael S. Tsirkin
On Sun, Apr 02, 2017 at 04:10:11PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Convert virtio-net to a standard napi tx completion path. This enables > better TCP pacing using TCP small queues and increases single stream > throughput. > > The virtio-net

linux-next: manual merge of the net-next tree with the net tree

2017-04-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: tools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/test_verifier.c between commit: 02ea80b1850e ("bpf: add various verifier test cases for self-tests") from the net tree and commits: 6882804c916b

Re: [PATCH net-next v3 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-04-02 Thread kbuild test robot
Hi Sean, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-next-dsa-add-Mediatek-MT7530-support/20170330-135532 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH] phy/ethtool: Add missing SPEED_ strings

2017-04-02 Thread Florian Fainelli
Le 04/02/17 à 14:30, Joe Perches a écrit : > Add all the currently available SPEED_ strings. > > Signed-off-by: Joe Perches Considering that PHYLIB does not support anything > 10Gbs at the moment, I am not sure how useful that is except if we wanted to re-use

[PATCH] soreuseport: use "unsigned int" in __reuseport_alloc()

2017-04-02 Thread Alexey Dobriyan
Number of sockets is limited by 16-bit, so 64-bit allocation will never happen. 16-bit ops are the worst code density-wise on x86_64 because of additional prefix (66). Space savings: add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3) function

Re: Resend all vs. individual patch updates

2017-04-02 Thread David Miller
From: Benjamin Herrenschmidt Date: Mon, 03 Apr 2017 07:21:08 +1000 > What is your preference when a couple of patches in a series of about a > dozen get updated as a result of reviews ? Just send updates to those > few or resend the whole series ? > > In the latter

[PATCH v2 3/3] flowcache: more "unsigned int"

2017-04-02 Thread Alexey Dobriyan
Make ->hash_count, ->low_watermark and ->high_watermark unsigned int and propagate unsignedness to other variables. This change doesn't change code generation because these fields aren't used in 64-bit contexts but make it anyway: these fields can't be negative numbers. Signed-off-by: Alexey

[PATCH v2 2/3] flowcache: make flow_cache_hash_size() return "unsigned int"

2017-04-02 Thread Alexey Dobriyan
Hash size can't negative so "unsigned int" is logically correct. Propagate "unsigned int" to loop counters. Space savings: add/remove: 0/0 grow/shrink: 2/2 up/down: 6/-18 (-12) function old new delta flow_cache_flush_tasklet

[PATCH v2 1/3] flowcache: make flow_key_size() return "unsigned int"

2017-04-02 Thread Alexey Dobriyan
Flow keys aren't 4GB+ numbers so 64-bit arithmetic is excessive. Space savings (I'm not sure what CSWTCH is): add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-48 (-48) function old new delta flow_cache_lookup

Re: [PATCH] phy/ethtool: Add missing SPEED_ strings

2017-04-02 Thread Joe Perches
On Sun, 2017-04-02 at 23:40 +0200, Andrew Lunn wrote: > On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote: > > Add all the currently available SPEED_ strings. [] > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h [] > > @@ -1487,6 +1487,7 @@ enum

Re: [PATCH] phy/ethtool: Add missing SPEED_ strings

2017-04-02 Thread Andrew Lunn
On Sun, Apr 02, 2017 at 02:30:06PM -0700, Joe Perches wrote: > Add all the currently available SPEED_ strings. > > Signed-off-by: Joe Perches > --- > drivers/net/phy/phy.c| 14 ++ > include/uapi/linux/ethtool.h | 1 + > 2 files changed, 15 insertions(+) >

Re: [PATCH 05/13] ftgmac100: Cleanup speed/duplex tracking and fix duplex config

2017-04-02 Thread Benjamin Herrenschmidt
On Sun, 2017-04-02 at 20:28 +0200, Andrew Lunn wrote: > Please consider using phy_print_status(). So in a subsequent (not yet posted) patch, I add Pause support. I noticed that phy_print_status() doesn't distinguish between full and partial (asym) pause support. Is that intentional ?

Re: stmmac still supporting spear600 ?

2017-04-02 Thread Thomas Petazzoni
Hello, On Thu, 23 Mar 2017 11:33:23 +0100, Giuseppe CAVALLARO wrote: > > Further research has revealed that everything is working fine on a > > platform with a Gigabit PHY connected via GMII. > > > > However, on a different platform (which I'm using) with a 10/100 PHY > > connected via MII,

[PATCH] phy/ethtool: Add missing SPEED_ strings

2017-04-02 Thread Joe Perches
Add all the currently available SPEED_ strings. Signed-off-by: Joe Perches --- drivers/net/phy/phy.c| 14 ++ include/uapi/linux/ethtool.h | 1 + 2 files changed, 15 insertions(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index

Re: [PATCH 05/13] ftgmac100: Cleanup speed/duplex tracking and fix duplex config

2017-04-02 Thread Benjamin Herrenschmidt
On Sun, 2017-04-02 at 13:35 +1000, Benjamin Herrenschmidt wrote: > +   } else if (priv->cur_speed) { > +   /* No link, just return. Leave the HW alone so it can > +    * continue draining the tx ring. > +    */ > +   netdev_info(netdev, "Link

Re: [PATCH 10/13] ftgmac100: Add a reset task and use it for link changes

2017-04-02 Thread Benjamin Herrenschmidt
On Sun, 2017-04-02 at 20:42 +0200, Andrew Lunn wrote: > Have you run lockdep tests on this? Good idea. For some reason I run it regularly on powerpc but it never occurred to me to try it on that 800Mhz ARM11 :-) Cheers, Ben.

Resend all vs. individual patch updates

2017-04-02 Thread Benjamin Herrenschmidt
Hi Dave ! What is your preference when a couple of patches in a series of about a dozen get updated as a result of reviews ? Just send updates to those few or resend the whole series ? In the latter case I'll wait a bit longer for more comments. Cheers, Ben.

Re: [PATCH 10/13] ftgmac100: Add a reset task and use it for link changes

2017-04-02 Thread Benjamin Herrenschmidt
On Sun, 2017-04-02 at 20:42 +0200, Andrew Lunn wrote: > Have you run lockdep tests on this? I think it is normal to take the > rtnl lock first, then the phydev lock. Try some ethtool operations > and see if you get a splat. You are right. I actually realized that was wrong last night ;-) It will

Re: [PATCH 05/13] ftgmac100: Cleanup speed/duplex tracking and fix duplex config

2017-04-02 Thread Benjamin Herrenschmidt
On Sun, 2017-04-02 at 20:28 +0200, Andrew Lunn wrote: > > + if (new_speed) { > > + netdev_info(netdev, "Link up at %d Mbit/s %s > > duplex\n", > > + new_speed, > > + phydev->duplex == DUPLEX_FULL ? "full" > > : "half"); > > + } else if

Re: [PATCH 10/13] ftgmac100: Add a reset task and use it for link changes

2017-04-02 Thread Benjamin Herrenschmidt
On Sun, 2017-04-02 at 13:35 +1000, Benjamin Herrenschmidt wrote: > +   /* Block PHY polling */ > +   if (netdev->phydev) > +   mutex_lock(>phydev->lock); > + > +   rtnl_lock(); Self-given brown paper bag, those two need to be taken the other way around. I'll send an

[PATCH net-next 1/3] virtio-net: napi helper functions

2017-04-02 Thread Willem de Bruijn
From: Willem de Bruijn Prepare virtio-net for tx napi by converting existing napi code to use helper functions. This also deduplicates some logic. Signed-off-by: Willem de Bruijn Signed-off-by: Jason Wang ---

[PATCH net-next 2/3] virtio-net: transmit napi

2017-04-02 Thread Willem de Bruijn
From: Willem de Bruijn Convert virtio-net to a standard napi tx completion path. This enables better TCP pacing using TCP small queues and increases single stream throughput. The virtio-net driver currently cleans tx descriptors on transmission of new packets in

[PATCH net-next 3/3] virtio-net: clean tx descriptors from rx napi

2017-04-02 Thread Willem de Bruijn
From: Willem de Bruijn Amortize the cost of virtual interrupts by doing both rx and tx work on reception of a receive interrupt if tx napi is enabled. With VIRTIO_F_EVENT_IDX, this suppresses most explicit tx completion interrupts for bidirectional workloads. Signed-off-by:

[PATCH net-next 0/3] virtio-net tx napi

2017-04-02 Thread Willem de Bruijn
From: Willem de Bruijn Add napi for virtio-net transmit completion processing. Based on previous patchsets by Jason Wang: [RFC V7 PATCH 0/7] enable tx interrupts for virtio-net http://lkml.iu.edu/hypermail/linux/kernel/1505.3/00245.html Changes: RFC -> v1: -

Re: [PATCH net-next 1/1] net: tcp: Define the TCP_MAX_WSCALE instead of literal number 14

2017-04-02 Thread Neal Cardwell
On Sat, Apr 1, 2017 at 12:14 AM, wrote: > From: Gao Feng > > Define one new macro TCP_MAX_WSCALE instead of literal number '14', > and use U16_MAX instead of 65535 as the max value of TCP window. > There is another minor change, use rounddown(space, mss)

Re: [PATCH 10/13] ftgmac100: Add a reset task and use it for link changes

2017-04-02 Thread Andrew Lunn
> +static void ftgmac100_reset_task(struct work_struct *work) > +{ > + struct ftgmac100 *priv = container_of(work, struct ftgmac100, > + reset_task); > + struct net_device *netdev = priv->netdev; > + int err; > + > + netdev_dbg(netdev,

Re: [PATCH 05/13] ftgmac100: Cleanup speed/duplex tracking and fix duplex config

2017-04-02 Thread Andrew Lunn
> + if (new_speed) { > + netdev_info(netdev, "Link up at %d Mbit/s %s duplex\n", > + new_speed, > + phydev->duplex == DUPLEX_FULL ? "full" : "half"); > + } else if (priv->cur_speed) { > + /* No link, just return. Leave

[patch net-next] net/faraday: Add missing include of of.h

2017-04-02 Thread Andrew Lunn
Breaking the include loop netdevice.h, dsa.h, devlink.h broke this driver, it depends on includes brought in by these headers. Adding linux/of.h fixes it. Fixes: ed0e39e97d34 ("net: break include loop netdevice.h, dsa.h, devlink.h") Signed-off-by: Andrew Lunn ---

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Eric Dumazet
On Sun, 2017-04-02 at 10:14 -0700, Eric Dumazet wrote: > Could that be that netfilter does not abort earlier if TCP header is > completely wrong ? > Yes, I wonder if this patch would be better, unless we replicate the th->doff sanity check in all netfilter modules dissecting TCP frames. diff

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Eric Dumazet
On Sun, 2017-04-02 at 19:52 +0300, Denys Fedoryshchenko wrote: > On 2017-04-02 15:32, Eric Dumazet wrote: > > On Sun, 2017-04-02 at 15:25 +0300, Denys Fedoryshchenko wrote: > >> > */ > >> I will add also WARN_ON_ONCE(tcp_hdrlen >= 15 * 4) before, for > >> curiosity, if this condition are

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
On 2017-04-02 15:32, Eric Dumazet wrote: On Sun, 2017-04-02 at 15:25 +0300, Denys Fedoryshchenko wrote: > */ I will add also WARN_ON_ONCE(tcp_hdrlen >= 15 * 4) before, for curiosity, if this condition are triggered. Is it fine like that? Sure. It didnt triggered WARN_ON, and with both

[git pull] skb_copy_{,and_csum_}datagram_msg() fixes

2017-04-02 Thread Al Viro
Fixes rsync et.al. regression since 3.19... The following changes since commit c02ed2e75ef4c74e41e421acb4ef1494671585e8: Linux 4.11-rc4 (2017-03-26 14:15:16 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-davem for you

[PATCH 1/2] iptables: extensions: unnecessary cast on void pointer

2017-04-02 Thread Arushi Singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Arushi Singhal --- extensions/libarpt_mangle.c | 2 +-

[PATCH 2/2] iptables: iptables: unnecessary cast on void pointer

2017-04-02 Thread Arushi Singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: Arushi Singhal --- iptables/nft-arp.c | 4 ++-- iptables/xtables-arp.c

[PATCH rfc 3/6] RDMA/core: expose affinity mappings per completion vector

2017-04-02 Thread Sagi Grimberg
This will allow ULPs to intelligently locate threads based on completion vector cpu affinity mappings. In case the driver does not expose a get_vector_affinity callout, return NULL so the caller can maintain a fallback logic. Signed-off-by: Sagi Grimberg ---

[PATCH rfc 6/6] nvme-rdma: use intelligent affinity based queue mappings

2017-04-02 Thread Sagi Grimberg
Use the geneic block layer affinity mapping helper. Also, limit nr_hw_queues to the rdma device number of irq vectors as we don't really need more. Signed-off-by: Sagi Grimberg --- drivers/nvme/host/rdma.c | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH rfc 5/6] block: Add rdma affinity based queue mapping helper

2017-04-02 Thread Sagi Grimberg
Like pci and virtio, we add a rdma helper for affinity spreading. This achieves optimal mq affinity assignments according to the underlying rdma device affinity maps. Signed-off-by: Sagi Grimberg --- block/Kconfig | 5 block/Makefile | 1 +

[PATCH rfc 2/6] mlx5: move affinity hints assignments to generic code

2017-04-02 Thread Sagi Grimberg
generic api takes care of spreading affinity similar to what mlx5 open coded (and even handles better asymmetric configurations). Ask the generic API to spread affinity for us, and feed him pre_vectors that do not participate in affinity settings (which is an improvement to what we had before).

[PATCH rfc 4/6] mlx5: support ->get_vector_affinity

2017-04-02 Thread Sagi Grimberg
Simply refer to the generic affinity mask helper. Signed-off-by: Sagi Grimberg --- drivers/infiniband/hw/mlx5/main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index

[PATCH rfc 1/6] mlx5: convert to generic pci_alloc_irq_vectors

2017-04-02 Thread Sagi Grimberg
Now that we have a generic code to allocate an array of irq vectors and even correctly spread their affinity, correctly handle cpu hotplug events and more, were much better off using it. Signed-off-by: Sagi Grimberg --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2

[PATCH rfc 0/6] Automatic affinity settings for nvme over rdma

2017-04-02 Thread Sagi Grimberg
This patch set is aiming to automatically find the optimal queue <-> irq multi-queue assignments in storage ULPs (demonstrated on nvme-rdma) based on the underlying rdma device irq affinity settings. First two patches modify mlx5 core driver to use generic API to allocate array of irq vectors

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Eric Dumazet
On Sun, 2017-04-02 at 15:25 +0300, Denys Fedoryshchenko wrote: > > */ > I will add also WARN_ON_ONCE(tcp_hdrlen >= 15 * 4) before, for > curiosity, if this condition are triggered. Is it fine like that? Sure.

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
On 2017-04-02 15:19, Eric Dumazet wrote: On Sun, 2017-04-02 at 04:54 -0700, Eric Dumazet wrote: On Sun, 2017-04-02 at 13:45 +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i += optlen(opt,

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Eric Dumazet
On Sun, 2017-04-02 at 04:54 -0700, Eric Dumazet wrote: > On Sun, 2017-04-02 at 13:45 +0200, Florian Westphal wrote: > > Eric Dumazet wrote: > > > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i += > > > optlen(opt, i)) { > > > + for (i = sizeof(struct

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Eric Dumazet
On Sun, 2017-04-02 at 13:45 +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i += > > optlen(opt, i)) { > > + for (i = sizeof(struct tcphdr); i < tcp_hdrlen - TCPOLEN_MSS; i += > > optlen(opt,

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
On 2017-04-02 14:45, Florian Westphal wrote: Eric Dumazet wrote: - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i += optlen(opt, i)) { + for (i = sizeof(struct tcphdr); i < tcp_hdrlen - TCPOLEN_MSS; i += optlen(opt, i)) { if (opt[i]

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Florian Westphal
Eric Dumazet wrote: > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i += > optlen(opt, i)) { > + for (i = sizeof(struct tcphdr); i < tcp_hdrlen - TCPOLEN_MSS; i += > optlen(opt, i)) { > if (opt[i] == TCPOPT_MSS && opt[i+1] ==

Private Placement

2017-04-02 Thread Mr. Ernest Pinto
Good day, Welcome to our Private Placement Portfolio. I am a Staff of a Venture Capital Firm specializing in Growth Capital Investments/Loans.We seek to invest in Projects with Public and Private sectors in a broad range of areas including Real estate, Agriculture, Energy, Oil and Gas,

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Eric Dumazet
On Sun, 2017-04-02 at 10:43 +0300, Denys Fedoryshchenko wrote: > Repost, due being sleepy missed few important points. > > I am searching reasons of crashes for multiple conntrack enabled > servers, usually they point to conntrack, but i suspect use after free > might be somewhere else, > so i

[PATCH] iptables: iptables: Remove exceptional & on function name

2017-04-02 Thread Arushi Singhal
Remove & from function pointers to conform to the style found elsewhere in the file. Done using the following semantic patch // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - + f // Signed-off-by: Arushi Singhal --- iptables/ip6tables-save.c |

[PATCH 1/4] net: netfilter:Remove exceptional & on function name

2017-04-02 Thread Arushi Singhal
Remove & from function pointers to conform to the style found elsewhere in the file. Done using the following semantic patch // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - + f // Signed-off-by: Arushi Singhal ---

[PATCH 2/4] net: bridge: Remove exceptional & on function name

2017-04-02 Thread Arushi Singhal
Remove & from function pointers to conform to the style found elsewhere in the file. Done using the following semantic patch // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - + f // Signed-off-by: Arushi Singhal ---

[PATCH 4/4] net: ipv6: Remove exceptional & on function name

2017-04-02 Thread Arushi Singhal
Remove & from function pointers to conform to the style found elsewhere in the file. Done using the following semantic patch // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - + f // Signed-off-by: Arushi Singhal ---

[PATCH 3/4] net: ipv4: Remove exceptional & on function name

2017-04-02 Thread Arushi Singhal
Remove & from function pointers to conform to the style found elsewhere in the file. Done using the following semantic patch // @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - + f // Signed-off-by: Arushi Singhal ---

[PATCH net-next v4] vxlan: fix ND proxy when skb doesn't have transport header offset

2017-04-02 Thread Vincent Bernat
When an incoming frame is tagged or when GRO is disabled, the skb handled to vxlan_xmit() doesn't contain a valid transport header offset. This makes ND proxying fail. We combine two changes: replace use of skb_transport_offset() and ensure the necessary amount of skb is linear just before using

KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
Repost, due being sleepy missed few important points. I am searching reasons of crashes for multiple conntrack enabled servers, usually they point to conntrack, but i suspect use after free might be somewhere else, so i tried to enable KASAN. And seems i got something after few hours, and it

finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
I am searching reasons of crashes for multiple NAT servers, and tried to enable KASAN. It seems i got something, and it looks very possible related to all crashes, because on all that servers i have MSS. [25181.855611] ==

Re: [PATCH net-next 1/4] ixgbe: sparc: rename the ARCH_WANT_RELAX_ORDER to IXGBE_ALLOW_RELAXED_ORDER

2017-04-02 Thread Ding Tianhong
On 2017/4/2 2:26, David Miller wrote: > From: Ding Tianhong > Date: Sat, 1 Apr 2017 15:25:51 +0800 > >> Till now only the Intel ixgbe could support enable >> Relaxed ordering in the drivers for special architecture, >> but the ARCH_WANT_RELAX_ORDER is looks like a