Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

Hi Niklas patch looks ok for me, Alex any feedback? peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to

6f58284e66: BUG: kernel hang in boot stage

dev event to link messages" 6f58284e66 Merge remote-tracking branch 'net-next/master' f8c97bdb49 Add linux-next specific files for 20170410 +-++++---+ |

Re: [PATCH v2] cfg80211: Fix array-bounds warning in fragment copy

On Mon, 2017-04-10 at 14:36 -0700, Matthias Kaehlcke wrote: > Ping, any feedback on this patch? You didn't cc linux-wireless, so it fell through the cracks ... I'll try to remember it when I merge later. johannes

Re: [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA.

Re-sending as my earlier response had some HTML subparts. Let me give some background before I answer your queries. In IBM PowerVM environment, ibmveth driver supports largesend and checksum offload today, but only for virtual ethernet adapters (VEA) which are not configured in "Trunk mode".

Re: [PATCH iproute2 net-next 1/2] iproute: Add support for ttl-propagation attribute

On 4/10/17 8:36 AM, Robert Shearman wrote: > @@ -1184,6 +1192,20 @@ static int iproute_modify(int cmd, unsigned int flags, > int argc, char **argv) > > if (rta->rta_len > RTA_LENGTH(0)) > addraw_l(, 1024, RTA_DATA(rta), > RTA_PAYLOAD(rta)); >

Re: Page allocator order-0 optimizations merged

On 2017/4/10 23:10, Mel Gorman wrote: > On Mon, Apr 10, 2017 at 10:31:48PM +0800, zhong jiang wrote: >> Hi, Mel >> >> The patch I had test on arm64. I find the great degradation. I test it >> by micro-bench. >> The patrly data is as following. and it is stable. That stands for the >>

[PATCH 02/10] ftgmac100: Use device "compatible" property, not machine.

We test for aspeed chips to handle a couple of special cases, but we do that by checking the machine type which isn't right. Instead check the actual device compatible property. This also updates the dtsi files for the aspeed SoC to match. Signed-off-by: Benjamin Herrenschmidt

Re: [PATCH 00/10] ftgmac100: Rework batch 4 - Misc

On Tue, 2017-04-11 at 11:04 +1000, Benjamin Herrenschmidt wrote: > This is the fourth batch of updates to the ftgmac100 driver. > > This is a bunch of misc cleanups and fixes, such as properly > disabling HW checksum generation on AST2400 where it's known > to be broken and some chip init

[PATCH 10/10] ftgmac100: Set default ring sizes to 128 entries

I haven't seen any improvement above that size on the machines I've tested with. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/10] ftgmac100: Make ring sizes configurable via ethtool

We set an arbitrary max at 1024 since we pre-allocate the actual descriptor arrays and skb arrays to the full size to keep the code a bit simpler and avoid allocation failures in the reset task. Signed-off-by: Benjamin Herrenschmidt ---

[PATCH 08/10] ftgmac100: Add more register inits in ftgmac100_init_hw()

Clear stale interrupts on entry, configure FIFO sizes, set FIFO thresholds, configure interrupt mitigation. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 36 1 file changed, 36 insertions(+) diff

[PATCH 05/10] ftgmac100: Rename ftgmac100_set_mac to ftgmac100_write_mac_addr

To avoid confusion with the ndo callback and generally be clearer about the purpose of that function Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 04/10] ftgmac100: Set netdev->hw_features

So features can be turned on/off via ethtool Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c

[PATCH 07/10] ftgmac100: Open code remaining register writes

The helpers just take space but don't provide much value. Simple one line comments are more explanatory. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 53 1 file changed, 20 insertions(+), 33

[PATCH 06/10] ftgmac100: Rename ftgmac100_setup_mac to ftgmac100_initial_mac

To remove more confusion. This function is about obtaining the initial MAC address at driver probe time. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/10] ftgmac100: Disable HW checksum generation on AST2400, enable on others

We found out that HW checksum generation only works from AST2500 onward. This disables it on AST2400 and removes the "no-hw-checksum" properties in the device-trees. The problem we had wasn't related to NC-SI. Also rework the logic testing for that property so it can be used to disable HW

[PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

The documentation describes NETIF_F_IP_CSUM as deprecated so let's switch to NETIF_F_HW_CSUM and use the helper to handle unhandled protocols. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 7 --- 1 file changed, 4

[PATCH 00/10] ftgmac100: Rework batch 4 - Misc

This is the fourth batch of updates to the ftgmac100 driver. This is a bunch of misc cleanups and fixes, such as properly disabling HW checksum generation on AST2400 where it's known to be broken and some chip init updates. This also adds the ability to turn HW checksum on/off and configure the

Re: [PATCH v2 net-next RFC] Generic XDP

From: Michael Chan Date: Mon, 10 Apr 2017 14:47:04 -0700 > On Mon, Apr 10, 2017 at 2:30 PM, Andy Gospodarek wrote: >> On Mon, Apr 10, 2017 at 03:28:54PM -0400, David Miller wrote: >>> From: Andy Gospodarek >>> Date: Mon, 10 Apr

Re: [PATCH] net: phy: micrel: KSZ9031: fix crash when statistic requested

On 04/10/2017 04:33 PM, Grygorii Strashko wrote: > Now the command: > ethtool --phy-statistics eth0 > will cause system crash with meassage "Unable to handle kernel NULL pointer > dereference at virtual address 0010" from: > > (kszphy_get_stats) from []

[PATCH] net: phy: micrel: KSZ9031: fix crash when statistic requested

Now the command: ethtool --phy-statistics eth0 will cause system crash with meassage "Unable to handle kernel NULL pointer dereference at virtual address 0010" from: (kszphy_get_stats) from [] (ethtool_get_phy_stats+0xd8/0x210) (ethtool_get_phy_stats) from []

Re: net/ipv6: use-after-free in ipv6_sock_ac_close

On Mon, Apr 10, 2017 at 7:28 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 39da7c509acff13fc8cb12ec1bb20337c988ed36 (4.11-rc6). > > Unfortunately it's not reproducible. > >

Re: net/ipv4: use-after-free in ip_check_mc_rcu

On Mon, Apr 10, 2017 at 7:33 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 39da7c509acff13fc8cb12ec1bb20337c988ed36 (4.11-rc6). > > Unfortunately it's not reproducible. > > BUG: KASAN:

[PATCH] p54: Prevent from dereferencing null pointer when releasing SKB

Added NULL check to make __dev_kfree_skb_irq consistent with kfree family of functions. Link: https://bugzilla.kernel.org/show_bug.cgi?id=195289 Signed-off-by: Myungho Jung --- net/core/dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/dev.c

Re: WARN_ON running XDP on virtio net device

On 4/10/17 3:37 PM, Michael S. Tsirkin wrote: > On Mon, Apr 10, 2017 at 03:21:53PM -0600, David Ahern wrote: >> I'm hitting a WARN_ON running XDP with virtio net: > I just sent a pull request. Would appreciate reports on whether > it helps. > it does.

Re: [PATCH v2 net-next RFC] Generic XDP

On Mon, Apr 10, 2017 at 2:30 PM, Andy Gospodarek wrote: > On Mon, Apr 10, 2017 at 03:28:54PM -0400, David Miller wrote: >> From: Andy Gospodarek >> Date: Mon, 10 Apr 2017 14:39:35 -0400 >> >> > As promised, I did some testing today with bnxt_en's

[RFC net-next] of: mdio: Honor hints from MDIO bus drivers

A MDIO bus driver can set phy_mask to indicate which PHYs should be probed and which should not. Right now, of_mdiobus_register() always sets mdio->phy_mask to ~0 which means: don't probe anything yourself, and let the Device Tree scanning do it based on the availability of child nodes. When MDIO

Re: [PATCH v2 net-next RFC] Generic XDP

On Mon, Apr 10, 2017 at 10:12:42PM +0200, Daniel Borkmann wrote: > On 04/10/2017 08:39 PM, Andy Gospodarek wrote: > [...] > > I ran this on a desktop-class system I have (i7-6700 CPU @ 3.40GHz) > > and used pktgen_sample03_burst_single_flow.sh from another system to > > throw ~6.5Mpps as a single

Re: [PATCH] p54: add null pointer check before releasing socket buffer

On Mon, Apr 10, 2017 at 2:22 PM, Christian Lamparter wrote: > Well, the patch could be as simple as this: > --- > diff --git a/net/core/dev.c b/net/core/dev.c > index 7869ae3837ca..44f7d5a1c67c 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -2450,6 +2450,9 @@

Re: WARN_ON running XDP on virtio net device

On Mon, Apr 10, 2017 at 03:21:53PM -0600, David Ahern wrote: > I'm hitting a WARN_ON running XDP with virtio net: I just sent a pull request. Would appreciate reports on whether it helps. > [ 177.185570] [ cut here ] > [ 177.187250] WARNING: CPU: 0 PID: 880 at >

[PULL] vhost: cleanups and fixes

These changes were as in linux-next as e1c287efcd4cf688564ed1112d032b5dac29b159 - I tweaked the commit log slightly. Too many people were complaining of warnings and errors in virtio so I decided revert is the safest path forward right now. The following changes since commit

Re: [PATCH v2] cfg80211: Fix array-bounds warning in fragment copy

El Mon, Mar 27, 2017 at 12:58:22PM -0700 Matthias Kaehlcke ha dit: > __ieee80211_amsdu_copy_frag intentionally initializes a pointer to > array[-1] to increment it later to valid values. clang rightfully > generates an array-bounds warning on the initialization statement. > > Initialize the

Re: [PATCH v2 net-next RFC] Generic XDP

On Mon, Apr 10, 2017 at 03:34:56PM -0400, David Miller wrote: > From: Andy Gospodarek > Date: Mon, 10 Apr 2017 14:39:35 -0400 > > > I also noted that... > > > > xdp1 not parsing the protocol correctly. All traffic was showing up as > > protocol '0' instead of '17' in the

Re: [PATCH v2 net-next RFC] Generic XDP

On Mon, Apr 10, 2017 at 03:28:54PM -0400, David Miller wrote: > From: Andy Gospodarek > Date: Mon, 10 Apr 2017 14:39:35 -0400 > > > As promised, I did some testing today with bnxt_en's implementation > > of XDP and this one. > > Thanks a lot Andy, obviously the patch needs

Darlehen angebot 3 %

Sehr geehrte Damen und Herren, Haben Sie Interesse über einer finanziellen Darlehen zu 3%? kontaktieren Sie mich für mehr Details und Bedingungen. ich kann all jenen helfen, wer ein Darlehen benötigen. Ich kann Ihnen biete ein darlehen in hohe von 10.000.000 EUR Meine mail:

Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

On Mon, 10 Apr 2017 16:08:21 +0100 Mel Gorman wrote: > IRQ context were excluded from using the Per-Cpu-Pages (PCP) lists caching > of order-0 pages in commit 374ad05ab64d ("mm, page_alloc: only use per-cpu > allocator for irq-safe requests"). > > This

Re: WARN_ON running XDP on virtio net device

On Mon, Apr 10, 2017 at 03:21:53PM -0600, David Ahern wrote: > I'm hitting a WARN_ON running XDP with virtio net: > > [ 177.185570] [ cut here ] > [ 177.187250] WARNING: CPU: 0 PID: 880 at > /home/dsa/kernel.git/drivers/pci/msi.c:1251 pci_irq_vector+0x92/0x123 > [

WARN_ON running XDP on virtio net device

I'm hitting a WARN_ON running XDP with virtio net: [ 177.185570] [ cut here ] [ 177.187250] WARNING: CPU: 0 PID: 880 at /home/dsa/kernel.git/drivers/pci/msi.c:1251 pci_irq_vector+0x92/0x123 [ 177.190932] Modules linked in: 8021q garp mrp stp llc vrf [ 177.193473] CPU:

Re: [PATCH] p54: add null pointer check before releasing socket buffer

On Monday, April 10, 2017 1:54:14 PM CEST Myungho Jung wrote: > On Mon, Apr 10, 2017 at 02:12:54PM +0200, Christian Lamparter wrote: > > On Sunday, April 9, 2017 10:23:20 PM CEST Myungho Jung wrote: > > > Kernel panic is caused by trying to dereference null pointer. Check if > > > the pointer is

Re: [PATCH v2 net-next RFC] Generic XDP

On 04/09/2017 10:35 PM, David Miller wrote: [...] diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index cc07c3b..f8ff49c 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1892,6 +1892,7 @@ struct net_device { struct lock_class_key

Re: net: use-after-free in __ns_get_path

On Mon, Apr 10, 2017 at 7:37 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 39da7c509acff13fc8cb12ec1bb20337c988ed36 (4.11-rc6). > > Unfortunately it's not reproducible. > >

Re: [PATCH] p54: add null pointer check before releasing socket buffer

On Mon, Apr 10, 2017 at 02:12:54PM +0200, Christian Lamparter wrote: > (Added linux-wireless, since this is a wireless driver) > > On Sunday, April 9, 2017 10:23:20 PM CEST Myungho Jung wrote: > > Kernel panic is caused by trying to dereference null pointer. Check if > > the pointer is null

Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

I will appreciate review of this patch. My micro-benchmarking show we basically return to same page alloc+free cost as before 374ad05ab64d ("mm, page_alloc: only use per-cpu allocator for irq-safe requests"). Which sort of invalidates this attempt of optimizing the page allocator. But Mel's

Distinguishing between forwarded/bridged packets and locally generated packets

Hi, I'm trying to find a way to distinguish between a packet that is being forwarded/bridged and one that was locally generated by the host itself. I need to know this for a particular application at tx in an ethernet device driver. Forwarded/bridged packets are processed when received, but I

Re: [PATCH v2 net-next RFC] Generic XDP

On 04/10/2017 08:39 PM, Andy Gospodarek wrote: [...] I ran this on a desktop-class system I have (i7-6700 CPU @ 3.40GHz) and used pktgen_sample03_burst_single_flow.sh from another system to throw ~6.5Mpps as a single UDP stream towards the system running XDP. I just commented out the ndo_xdp op

Re: [PATCH net v3 0/2] bridge: Fix kernel oops during bridge creation

On Mon, 10 Apr 2017 14:59:26 +0300 ido...@idosch.org wrote: > From: Ido Schimmel > > First patch adds a missing ndo_uninit() in the bridge driver, which is a > prerequisite for the second patch that actually fixes the oops. > > Please consider both patches for 4.4.y, 4.9.y

Re: [PATCH v2 00/12] ftgmac100: Rework batch 3 - TX path

From: Benjamin Herrenschmidt Date: Mon, 10 Apr 2017 11:15:14 +1000 > This is version 2 of the third batch of updates to > the ftgmac100 driver. > > This one tackles the TX path of the driver. This provides the > bulk of the performance improvements by adding support

Re: [PATCH 0/6] mvmdio updates

Hi Russel, 2017-04-10 17:27 GMT+02:00 Russell King - ARM Linux : > This series of patches update mvmdio for Armada 8k CP110. A number of > issues were found: > > 1. The driver fails to disable an interrupt when something goes wrong >in the probe function. > > 2. The

Re: [PATCH 5/6] dt-bindings: allow up to three clocks for orion-mdio

On Mon, Apr 10, 2017 at 04:28:25PM +0100, Russell King wrote: > Armada 8040 needs three clocks to be enabled for MDIO accesses to work. > Update the binding to allow the extra clocks to be specified. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn

[PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

There are no in-tree callers. Signed-off-by: Aaron Conole --- net/netfilter/ipset/ip_set_core.c | 8 1 file changed, 8 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index c296f9b..68ba531 100644 ---

[PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

There are no in-tree callers of this function and it isn't exported. Signed-off-by: Aaron Conole --- include/net/ip_vs.h | 2 -- net/netfilter/ipvs/ip_vs_proto.c | 22 -- 2 files changed, 24 deletions(-) diff --git a/include/net/ip_vs.h

Re: [PATCH v2 net-next RFC] Generic XDP

On 04/10/2017 04:18 AM, Alexei Starovoitov wrote: [...] + xdp.data_end = xdp.data + hlen; + xdp.data_hard_start = xdp.data - skb_headroom(skb); + orig_data = xdp.data; + act = bpf_prog_run_xdp(xdp_prog, ); + + off = xdp.data - orig_data; + if (off) +

Re: [PATCH v2 net-next RFC] Generic XDP

From: Andy Gospodarek Date: Mon, 10 Apr 2017 14:39:35 -0400 > I also noted that... > > xdp1 not parsing the protocol correctly. All traffic was showing up as > protocol '0' instead of '17' in the output. > > xdp2 was not actually sending the frames back out when using

Re: [PATCH v2 net-next RFC] Generic XDP

From: Alexei Starovoitov Date: Sun, 9 Apr 2017 19:18:09 -0700 > On Sun, Apr 09, 2017 at 01:35:28PM -0700, David Miller wrote: >> +if (skb_linearize(skb)) >> +goto do_drop; > > do we need to force disable gro ? I think we do. > Otherwise if we

Re: [PATCH 6/6] net: mvmdio: allow up to three clocks to be specified for orion-mdio

On Mon, Apr 10, 2017 at 04:28:31PM +0100, Russell King wrote: > Allow up to three clocks to be specified and enabled for the orion-mdio > interface, which are required for this interface to be accessible on > Armada 8k platforms. > > Signed-off-by: Russell King

Re: Horrid balance-rr bonding udp throughput

On Mon, 2017-04-10 at 14:50 -0400, Jarod Wilson wrote: > On 2017-04-08 7:33 PM, Jarod Wilson wrote: > > I'm digging into some bug reports covering performance issues with > > balance-rr, and discovered something even worse than the reporter. My > > test setup has a pair of NICs, one e1000e, one

Re: [PATCH 4/6] net: mvmdio: disable interrupt if resource size is too small

On Mon, Apr 10, 2017 at 04:28:20PM +0100, Russell King wrote: > Disable the MDIO interrupt, falling back to polled mode, if the resource > size does not allow us to access the interrupt registers. All current > DT bindings use a size of 0x84, which allows access, but verifying it is > good

Re: [PATCH v2 net-next RFC] Generic XDP

From: Andy Gospodarek Date: Mon, 10 Apr 2017 14:39:35 -0400 > As promised, I did some testing today with bnxt_en's implementation > of XDP and this one. Thanks a lot Andy, obviously the patch needs some more work. I noticed GRO stuff in your profile, and Alexei mentioned

Re: [PATCH v2 net-next RFC] Generic XDP

On Sun, 09 Apr 2017 13:35:28 -0700 (PDT) David Miller wrote: > This provides a generic non-optimized XDP implementation when the > device driver does not provide an optimized one. > > It is arguable that perhaps I should have required something like > this as part of the

Re: [PATCH 3/6] dt-bindings: correct marvell orion MDIO binding document

On Mon, Apr 10, 2017 at 04:28:15PM +0100, Russell King wrote: > Correct the Marvell Orion MDIO binding document to properly reflect the > cases where an interrupt is present. Augment the examples to show this. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn

Re: [PATCH 2/6] net: mvmdio: fix interrupt disable in remove path

On Mon, Apr 10, 2017 at 04:28:09PM +0100, Russell King wrote: > The pre-existing write to disable interrupts on the remove path happens > whether we have an interrupt or not. While this may seem to be a good > idea, this driver is re-used in many different implementations, some > where the

Re: [PATCH 1/6] net: mvmdio: disable interrupts in driver failure path

On Mon, Apr 10, 2017 at 04:28:04PM +0100, Russell King wrote: > When the mvmdio driver has an interrupt, it enables the "done" interrupt > after requesting its interrupt handler. However, probe failure results > in the interrupt being left enabled. Disable it on the failure path. > >

Re: af_packet: use after free in prb_retire_rx_blk_timer_expired

On Mon, Apr 10, 2017 at 07:03:30PM +, alexander.le...@verizon.com wrote: > Hi all, > > I seem to be hitting this use-after-free on a -next kernel using trinity: > > [ 531.036054] BUG: KASAN: use-after-free in prb_retire_rx_blk_timer_expired > (net/packet/af_packet.c:688)

af_packet: use after free in prb_retire_rx_blk_timer_expired

Hi all, I seem to be hitting this use-after-free on a -next kernel using trinity: [ 531.036054] BUG: KASAN: use-after-free in prb_retire_rx_blk_timer_expired (net/packet/af_packet.c:688) [ 531.036961] Read of size 8 at addr 88038c1fb0e8

Re: Horrid balance-rr bonding udp throughput

On 04/10/2017 11:50 AM, Jarod Wilson wrote: On 2017-04-08 7:33 PM, Jarod Wilson wrote: I'm digging into some bug reports covering performance issues with balance-rr, and discovered something even worse than the reporter. My test setup has a pair of NICs, one e1000e, one e1000 (but dual e1000e

Re: Horrid balance-rr bonding udp throughput

On 2017-04-08 7:33 PM, Jarod Wilson wrote: I'm digging into some bug reports covering performance issues with balance-rr, and discovered something even worse than the reporter. My test setup has a pair of NICs, one e1000e, one e1000 (but dual e1000e seems the same). When I do a test run in

[PATCH net] xfrm: calculate L4 checksums also for GSO case before encrypting packets

Otherwise, if L4 checksum calculation is done after encryption, then all ESP packets end up being corrupted at the location where pre-encryption L4 checksum field resides. One of the ways to reproduce this bug is to have a VM with virtio_net driver (UFO set to ON in the guest VM); and then

Re: [PATCH v2 net-next RFC] Generic XDP

On Sun, Apr 09, 2017 at 01:35:28PM -0700, David Miller wrote: > > This provides a generic non-optimized XDP implementation when the > device driver does not provide an optimized one. > > It is arguable that perhaps I should have required something like > this as part of the initial XDP feature

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On Mon, 2017-04-10 at 17:40 +0200, Johannes Berg wrote: > > Another thought: if we add a new flag that indicates "message has > been capped", which we introduce in this same patch, then we can > disentangle this more easily, right? > > Adding a new flag for "TLVs present" won't really help, but

[PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to avoid relying on undefined behavior, set the length in TDES3. The field has a different meaning

RFC: Checksum offload and XDP

Not having checksum offload in XDP is going to get more painful once we start seeing a lot programs doing packet modifications. One nice thing we do for ILA router is pre-compute the checksum delta necessary to maintain checksum neutral property in the packet. So that after doing ILA routing in

Re: [PATCH rfc 0/6] Automatic affinity settings for nvme over rdma

On 4/2/2017 8:41 AM, Sagi Grimberg wrote: This patch set is aiming to automatically find the optimal queue <-> irq multi-queue assignments in storage ULPs (demonstrated on nvme-rdma) based on the underlying rdma device irq affinity settings. First two patches modify mlx5 core driver to use

Re: net/ipv4: use-after-free in ip_queue_xmit

On Mon, Apr 10, 2017 at 7:42 PM, Cong Wang wrote: > On Mon, Apr 10, 2017 at 7:40 AM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit

Re: net/ipv4: use-after-free in ip_queue_xmit

On Mon, Apr 10, 2017 at 7:40 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 39da7c509acff13fc8cb12ec1bb20337c988ed36 (4.11-rc6). > > Unfortunately it's not reproducible. > > BUG: KASAN:

[PATCH 2/3] netfilter: ipvs: Replace kzalloc with kcalloc.

From: Varsha Rao Replace kzalloc with kcalloc. As kcalloc is preferred for allocating an array instead of kzalloc. This patch fixes the checkpatch issue. Signed-off-by: Varsha Rao --- net/netfilter/ipvs/ip_vs_sync.c | 4 ++-- 1 file changed, 2

[PATCH 1/3] netfilter: ipvs: don't check for presence of nat extension

From: Florian Westphal Check for the NAT status bits, they are set once conntrack needs NAT in source or reply direction, this is slightly faster than nfct_nat() as that has to check the extension area. Signed-off-by: Florian Westphal ---

[PATCH 3/3] ipvs: remove unused variable

From: Arushi Singhal This patch uses the following coccinelle script to remove a variable that was simply used to store the return value of a function call before returning it: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return

[GIT 0/3] Second Round of IPVS Updates for v4.12

Hi Pablo, please consider these clean-ups and enhancements to IPVS for v4.12. * Removal unused variable * Use kzalloc where appropriate * More efficient detection of presence of NAT extension The following changes since commit 592d42ac7fd36408979e09bf2f170f2595dab7b8: Merge branch

Re: [PATCH v2 net-next RFC] Generic XDP

>> static int netif_receive_skb_internal(struct sk_buff *skb) >> { >> int ret; >> @@ -4258,6 +4336,21 @@ static int netif_receive_skb_internal(struct sk_buff >> *skb) >> >> rcu_read_lock(); >> >> + if (static_key_false(_xdp_needed)) { >> + struct bpf_prog *xdp_prog =

Re: [PATCH] ipv6: Fix idev->addr_list corruption

On 4/10/17 12:36 AM, Rabin Vincent wrote: > From: Rabin Vincent > > addrconf_ifdown() removes elements from the idev->addr_list without > holding the idev->lock. > > If this happens while the loop in __ipv6_dev_get_saddr() is handling the > same element, that function ends up

Re: [PATCH net-next v3 2/2] bpf: remove struct bpf_map_type_list

On 04/10/2017 02:44 PM, Johannes Berg wrote: From: Johannes Berg There's no need to have struct bpf_map_type_list since it just contains a list_head, the type, and the ops pointer. Since the types are densely packed and not actually dynamically registered, it's much

Re: [PATCH net-next v3 1/2] bpf: remove struct bpf_prog_type_list

On 04/10/2017 02:44 PM, Johannes Berg wrote: From: Johannes Berg There's no need to have struct bpf_prog_type_list since it just contains a list_head, the type, and the ops pointer. Since the types are densely packed and not actually dynamically registered, it's much

[PATCH net-next] cxgb4: save tid while creating server filter

Save the filter tid while creating the server filter, which is used later to retrieve the corresponding filter instance while handling the filter reply. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 1 file changed, 4

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

On 4/10/17 9:39 AM, Vlad Yasevich wrote: > OK, so this will work for the events that are generated as a result of device > state change > (like mtu, address, and others). > > However, the original event data may be needed for other events that may be > of use to userspace like

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On Mon, 2017-04-10 at 09:35 -0600, David Ahern wrote: > > Do you have any better ideas? > > NETLINK_F_CAP_ACK and NETLINK_F_EXT_ACK should be incompatible -- if > one is set the other can not be set. CAP_ACK means abbreviate the > response and EXT_ACK means give me more data. So you mean if I

Re: [PATCH net-next 1/8] rtnetlink: Do not generate notifications for MTU events

On 04/08/2017 02:18 PM, Roopa Prabhu wrote: > On 4/8/17, 11:13 AM, David Ahern wrote: >> On 4/8/17 2:06 PM, Roopa Prabhu wrote: >>> On 4/7/17, 2:25 PM, David Ahern wrote: Changing MTU on a link currently causes 3 messages to be sent to userspace: [LINK]11: dummy1:

Re: Non-standard TCP stack processing of packets with unacceptable ACK numbers

On Sat, 2017-04-08 at 22:29 +0200, Paul Fiterau Brostean wrote: > Hello, > > My name is Paul Fiterau, I am a PhD student at Radboud University whose > focus for the past few years has been among others to develop and apply > inference techniques on TCP stacks in order to obtain nice models, and

[PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

Telit LE920A4 uses the same pid 0x1201 of LE920, but modem implementation is different, since it requires DTR to be set for answering to qmi messages. This patch replaces QMI_FIXED_INTF with QMI_QUIRK_SET_DTR: tests on LE920 have been performed in order to verify backward compatibility.

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On 4/10/17 9:30 AM, Johannes Berg wrote: > On Mon, 2017-04-10 at 09:26 -0600, David Ahern wrote: >> On 4/8/17 2:24 PM, Johannes Berg wrote: >>> @@ -2300,14 +2332,35 @@ void netlink_ack(struct sk_buff *in_skb, >>> struct nlmsghdr *nlh, int err) >>> NLMSG_ERROR, payload, 0);

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On Mon, 2017-04-10 at 09:26 -0600, David Ahern wrote: > On 4/8/17 2:24 PM, Johannes Berg wrote: > > @@ -2300,14 +2332,35 @@ void netlink_ack(struct sk_buff *in_skb, > > struct nlmsghdr *nlh, int err) > >     NLMSG_ERROR, payload, 0); > >   errmsg = nlmsg_data(rep); > >  

[PATCH 6/6] net: mvmdio: allow up to three clocks to be specified for orion-mdio

Allow up to three clocks to be specified and enabled for the orion-mdio interface, which are required for this interface to be accessible on Armada 8k platforms. Signed-off-by: Russell King --- drivers/net/ethernet/marvell/mvmdio.c | 33

[PATCH 4/6] net: mvmdio: disable interrupt if resource size is too small

Disable the MDIO interrupt, falling back to polled mode, if the resource size does not allow us to access the interrupt registers. All current DT bindings use a size of 0x84, which allows access, but verifying it is good practice. Signed-off-by: Russell King ---

[PATCH 5/6] dt-bindings: allow up to three clocks for orion-mdio

Armada 8040 needs three clocks to be enabled for MDIO accesses to work. Update the binding to allow the extra clocks to be specified. Signed-off-by: Russell King --- Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 2 +- 1 file changed, 1 insertion(+),

[PATCH 3/6] dt-bindings: correct marvell orion MDIO binding document

Correct the Marvell Orion MDIO binding document to properly reflect the cases where an interrupt is present. Augment the examples to show this. Signed-off-by: Russell King --- .../devicetree/bindings/net/marvell-orion-mdio.txt | 17 +++-- 1 file

[PATCH 2/6] net: mvmdio: fix interrupt disable in remove path

The pre-existing write to disable interrupts on the remove path happens whether we have an interrupt or not. While this may seem to be a good idea, this driver is re-used in many different implementations, some where the binding only specifies four bytes of register space. This access causes us

[PATCH 1/6] net: mvmdio: disable interrupts in driver failure path

When the mvmdio driver has an interrupt, it enables the "done" interrupt after requesting its interrupt handler. However, probe failure results in the interrupt being left enabled. Disable it on the failure path. Signed-off-by: Russell King ---

[PATCH 0/6] mvmdio updates

This series of patches update mvmdio for Armada 8k CP110. A number of issues were found: 1. The driver fails to disable an interrupt when something goes wrong in the probe function. 2. The interrupt is specified in DT to be optional, but the driver unconditionally writes to the interrupt

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On 4/8/17 2:24 PM, Johannes Berg wrote: > @@ -2300,14 +2332,35 @@ void netlink_ack(struct sk_buff *in_skb, struct > nlmsghdr *nlh, int err) > NLMSG_ERROR, payload, 0); > errmsg = nlmsg_data(rep); > errmsg->error = err; > - memcpy(>msg, nlh, payload >

RE: [PATCH net-next 5/7] s390/qeth: improve endianness handling

From: Ursula Braun > Sent: 07 April 2017 13:33 > On 04/07/2017 01:25 PM, David Laight wrote: > > From: Ursula Braun > >> Sent: 05 April 2017 09:40 > >> From: Hans Wippel > >> > >> Avoid endianness warnings reported by sparse by (1) using endianness > >> conversions for

RE: [PATCH net-next V2 5/7] s390/qeth: improve endianness handling

From: Ursula Braun > Sent: 07 April 2017 08:16 > Avoid endianness warnings reported by sparse by (1) using endianness > conversions for assigning and using network packet fields, and (2) > removing unnecessary endianness conversions from qeth_l3_rebuild_skb. No > functional changes. ... > - if

  1   2   >