[PATCH next] bonding: handle link transition from FAIL to UP correctly

From: Mahesh Bandewar When link transitions from LINK_FAIL to LINK_UP, the commit phase is not called. This leads to an erroneous state causing slave-link state to get stuck in "going down" state while its speed and duplex are perfectly fine. This issue is a side-effect of

[PATCH v2 net-next] net: dwc-xlgmac: add the initial ethtool support

It is necessary to provide ethtool support for displaying and modifying parameters of dwc-xlgmac. Signed-off-by: Jie Deng --- v1->v2: - remove begin() method which is unnecessary drivers/net/ethernet/synopsys/Makefile | 3 +-

Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support

On 2017/4/11 22:47, David Miller wrote: > From: Jie Deng > Date: Tue, 11 Apr 2017 16:14:04 +0800 > >> It is necessary to provide ethtool support for displaying and >> modifying parameters of dwc-xlgmac. >> >> Signed-off-by: Jie Deng > I don't see

[PATCH v2 3/3] of: Make of_match_node() an inline stub for CONFIG_OF=n

Make of_match_node() an inline function when CONFIG_OF=n which allows the compiler to eliminate warnings about unused variables. Signed-off-by: Florian Fainelli --- include/linux/of.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v2 0/3] of: Make of_match_node() an inline stub for CONFIG_OF=n

Hi all, This patch series makes of_match_node() an inline stub for CONFIG_OF=n. kbuild reported two build errors which are fixed as preriquisite patches. This is based on Linus' master, not sure which tree would merge this, Frank's? Thanks! Florian Fainelli (3): mfd: max8998: Remove

[PATCH v2 1/3] mfd: max8998: Remove CONFIG_OF around max8998_dt_match

A subsequent patch is going to make of_match_node() an inline stub when CONFIG_OF is disabled which will properly take care of having the compiler eliminate the variable. To avoid more #ifdef/#else, just always make the match table available. Signed-off-by: Florian Fainelli

[PATCH v2 2/3] net: macb: Remove CONFIG_OF around DT match table

A subsequent patch is going to make of_match_node() an inline stub when CONFIG_OF is disabled, which will let the compiler eliminate unused variables. In order not to clutter the code more, remove the CONFIG_OF #ifdef such that macb_dt_ids and what it references are always defined. Signed-off-by:

[PATCH net-next v3 1/1] net: ipv4: Refine the ipv4_default_advmss

From: Gao Feng 1. Don't get the metric RTAX_ADVMSS of dst. There are two reasons. 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss before invoke default_advmss. 2) The ipv4_default_advmss is used to get the default mss, it should not try to get the metric

RE: [PATCH net-next v2 1/1] net: ipv4: Refine the ipv4_default_advmss

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Joe Perches > Sent: Wednesday, April 12, 2017 11:57 AM > To: gfree.w...@foxmail.com; da...@davemloft.net; kuz...@ms2.inr.ac.ru; > jmor...@namei.org; netdev@vger.kernel.org > Cc:

Re: [PATCH net-next v2 1/1] net: ipv4: Refine the ipv4_default_advmss

On Wed, 2017-04-12 at 10:32 +0800, gfree.w...@foxmail.com wrote: > diff --git a/net/ipv4/route.c b/net/ipv4/route.c more trivia: > @@ -1250,14 +1250,11 @@ static void set_class_tag(struct rtable *rt, u32 tag) > > static unsigned int ipv4_default_advmss(const struct dst_entry *dst) > { > -

[PATCH v2 06/10] ftgmac100: Rename ftgmac100_setup_mac to ftgmac100_initial_mac

To remove more confusion. This function is about obtaining the initial MAC address at driver probe time. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

RE: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()

Hi David, > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, April 12, 2017 11:03 AM > To: weiyj...@gmail.com > Cc: j...@mellanox.com; arka...@mellanox.com; weiyongjun (A) > ; netdev@vger.kernel.org > Subject: Re: [PATCH

[PATCH v2 05/10] ftgmac100: Rename ftgmac100_set_mac to ftgmac100_write_mac_addr

To avoid confusion with the ndo callback and generally be clearer about the purpose of that function Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 09/10] ftgmac100: Make ring sizes configurable via ethtool

We set an arbitrary max at 1024 since we pre-allocate the actual descriptor arrays and skb arrays to the full size to keep the code a bit simpler and avoid allocation failures in the reset task. Signed-off-by: Benjamin Herrenschmidt ---

[PATCH v2 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

The documentation describes NETIF_F_IP_CSUM as deprecated so let's switch to NETIF_F_HW_CSUM and use the helper to handle unhandled protocols. Signed-off-by: Benjamin Herrenschmidt -- v2. - Properly fallback on unknown IP protocols (side effect of fixing a

[PATCH v2 10/10] ftgmac100: Set default ring sizes to 128 entries

I haven't seen any improvement above that size on the machines I've tested with. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 08/10] ftgmac100: Add more register inits in ftgmac100_init_hw()

Clear stale interrupts on entry, configure FIFO sizes, set FIFO thresholds, configure interrupt mitigation. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 36 1 file changed, 36 insertions(+) diff

[PATCH v2 02/10] ftgmac100: Use device "compatible" property, not machine.

We test for aspeed chips to handle a couple of special cases, but we do that by checking the machine type which isn't right. Instead check the actual device compatible property. This also updates the dtsi files for the aspeed SoC to match. Signed-off-by: Benjamin Herrenschmidt

[PATCH v2 03/10] ftgmac100: Disable HW checksum generation on AST2400, enable on others

We found out that HW checksum generation only works from AST2500 onward. This disables it on AST2400 and removes the "no-hw-checksum" properties in the device-trees. The problem we had wasn't related to NC-SI. Also rework the logic testing for that property so it can be used to disable HW

[PATCH v2 07/10] ftgmac100: Open code remaining register writes

The helpers just take space but don't provide much value. Simple one line comments are more explanatory. Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 53 1 file changed, 20 insertions(+), 33

[PATCH v2 04/10] ftgmac100: Set netdev->hw_features

So features can be turned on/off via ethtool Signed-off-by: Benjamin Herrenschmidt --- drivers/net/ethernet/faraday/ftgmac100.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c

[PATCH v2 00/10] ftgmac100: Rework batch 4 - Misc

This is v2 of the fourth batch of updates to the ftgmac100 driver. This is a bunch of misc cleanups and fixes, such as properly disabling HW checksum generation on AST2400 where it's known to be broken and some chip init updates. This also adds the ability to turn HW checksum on/off and

[PATCH net-next v1 1/1] L2TP device MTU setup - tunnel socket needs a lock

The MTU overhead calculation in L2TP device set-up merged via commit b784e7ebfce8cfb16c6f95e14e8532d0768ab7ff needs to be adjusted to lock the tunnel socket while referencing the sub-data structures to derive the socket's IP overhead. --- include/linux/net.h | 2 +- net/l2tp/l2tp_eth.c | 2 ++

Re: [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put()

From: Wei Yongjun Date: Mon, 10 Apr 2017 13:11:06 + > From: Wei Yongjun > > Fix the retrn value check which testing the wrong variable > in devlink_dpipe_header_put(). > > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") >

Re: [PATCH net-next 00/10] net/smc: patches for net-next

From: Ursula Braun Date: Mon, 10 Apr 2017 14:57:55 +0200 > here are some patches for net/smc. Most important are > improvements for socket closing. Series applied to net-next, thanks.

RE: [PATCH net-next 1/1] net: ipv4: Refine the ipv4_default_advmss

> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Wednesday, April 12, 2017 10:03 AM > To: gfree.w...@foxmail.com; da...@davemloft.net; kuz...@ms2.inr.ac.ru; > jmor...@namei.org; netdev@vger.kernel.org > Cc: Gao Feng > Subject: Re: [PATCH net-next

[PATCH net-next v2 1/1] net: ipv4: Refine the ipv4_default_advmss

From: Gao Feng 1. Don't get the metric RTAX_ADVMSS of dst. There are two reasons. 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss before invoke default_advmss. 2) The ipv4_default_advmss is used to get the default mss, it should not try to get the metric

Re: [PATCH net v3 0/2] bridge: Fix kernel oops during bridge creation

From: ido...@idosch.org Date: Mon, 10 Apr 2017 14:59:26 +0300 > From: Ido Schimmel > > First patch adds a missing ndo_uninit() in the bridge driver, which is a > prerequisite for the second patch that actually fixes the oops. > > Please consider both patches for 4.4.y,

Re: [PATCH] net: stmmac: use netif_set_real_num_{rx,tx}_queues

From: Joao Pinto Date: Mon, 10 Apr 2017 11:32:14 +0100 > In the submission of the lastest multiple buffer patch set, this fix was lost. > I am sending this patch to put it right again. The fix was originally proposed > by Arnd Bergmann. > > Signed-off-by: Arnd Bergmann

Re: [PATCH] smsc95xx: Add comments to the registers definition

From: Andrew Lunn Date: Mon, 10 Apr 2017 15:52:51 +0200 > Hi Martin > >> @@ -2032,7 +2032,7 @@ static struct sk_buff *smsc95xx_tx_fixup(struct usbnet >> *dev, >> skb_push(skb, 4); >> tx_cmd_b = (u32)(skb->len - 4); >> if (csum) >> -tx_cmd_b |=

Re: [PATCH net-next,1/3] hv_netvsc: Use per socket hash when available

From: Haiyang Zhang Date: Sat, 8 Apr 2017 17:53:59 -0700 > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index f24c289..0a129cb 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -211,9

Re: [PATCH net-next v2] net: allow configuring default qdisc

From: Stephen Hemminger Date: Sat, 8 Apr 2017 15:39:46 -0400 > Since 3.12 it has been possible to configure the default queuing > discipline via sysctl. This patch adds ability to configure the > default queue discipline in kernel configuration. This is useful for >

Re: [PATCH net-next 1/1] net: ipv4: Refine the ipv4_default_advmss

On Wed, 2017-04-12 at 09:36 +0800, gfree.w...@foxmail.com wrote: > From: Gao Feng > > 1. Don't get the metric RTAX_ADVMSS of dst. > There are two reasons. > 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss > before invoke default_advmss. > 2) The

[PATCH net-next 1/1] net: ipv4: Refine the ipv4_default_advmss

From: Gao Feng 1. Don't get the metric RTAX_ADVMSS of dst. There are two reasons. 1) Its caller dst_metric_advmss has already invoke dst_metric_advmss before invoke default_advmss. 2) The ipv4_default_advmss is used to get the default mss, it should not try to get the metric

Re: Network driver "test suite"

Hi, On 04/11/2017 05:16 PM, Benjamin Herrenschmidt wrote: > Hi folks ! > > Does anybody knows of an existing kind of automated "test suite" for a > network/ethernet driver ? > > IE. Something we could run both on the "tested" driver and a cross-over > "known good" peer (possibly the latter set

linux-next: manual merge of the net-next tree with the pci tree

Hi all, Today's linux-next merge of the net-next tree got conflicts in: drivers/pci/msi.c include/linux/pci.h between commit: 688769f643bf ("PCI/MSI: Make pci_msi_shutdown() and pci_msix_shutdown() static") from the pci tree and commit: 4244de1c64de ("PCI: remove pci_enable_msix")

Network driver "test suite"

Hi folks ! Does anybody knows of an existing kind of automated "test suite" for a network/ethernet driver ? IE. Something we could run both on the "tested" driver and a cross-over "known good" peer (possibly the latter set to promisc & no offload for proper analysis), that would out the driver

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

On Tue, 2017-04-11 at 20:03 -0400, David Miller wrote: > > From: Benjamin Herrenschmidt > Date: Wed, 12 Apr 2017 09:36:05 +1000 > > > I should call the helper when I don't recognize the protocol type in > > the IP header, not just when the main skb protocol type is not

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

From: Benjamin Herrenschmidt Date: Wed, 12 Apr 2017 09:36:05 +1000 > I should call the helper when I don't recognize the protocol type in > the IP header, not just when the main skb protocol type is not IP. That's correct. > BTW. I'm not too familiar with how

[PATCH net-next v2 5/8] rtnetlink: Do not generate notifications for PRECHANGEUPPER event

PRECHANGEUPPER is an internal event; do not generate userspace notifications. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 8cfb9e3c1f6e..10df445bb818 100644 ---

[PATCH net-next v2 0/8] rtnetlink: Cleanup user notifications for netdev events

Vlad's recent patch to add the event type to rtnetlink notifications points out a number of redundant or unnecessary notifications sent to userspace for events that are essentially internal to the kernel. Trim the list to put a dent in the notification storm. v2 - rebased to top of net-next with

[PATCH net-next v2 4/8] rtnetlink: Do not generate notifications for POST_TYPE_CHANGE event

Changing the master device for a link generates many messages; the one generated for POST_TYPE_CHANGE is redundant: [LINK]11: dummy1: mtu 1500 qdisc noqueue master br1 state UNKNOWN group default link/ether 02:02:02:02:02:03 brd ff:ff:ff:ff:ff:ff [LINK]11:

[PATCH net-next v2 1/8] rtnetlink: Do not generate notifications for MTU events

Changing MTU on a link currently causes 3 messages to be sent to userspace: [LINK]11: dummy1: mtu 1490 qdisc noqueue state UNKNOWN group default link/ether f2:52:5c:6d:21:f3 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc

[PATCH net-next v2 2/8] rtnetlink: Do not generate notification for UDP_TUNNEL_PUSH_INFO

NETDEV_UDP_TUNNEL_PUSH_INFO is an internal notifier; nothing userspace can do so don't generate a netlink notification. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c

[PATCH net-next v2 8/8] rtnetlink: Do not generate notifications for NETDEV_CHANGE_TX_QUEUE_LEN event

Changing tx queue length generates identical messages: [LINK]22: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether 02:04:f4:b7:5c:d2 brd ff:ff:ff:ff:ff:ff promiscuity 0 dummy numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs

[PATCH net-next v2 7/8] rtnetlink: Do not generate notifications for NETDEV_CHANGEUPPER event

NETDEV_CHANGEUPPER is an internal event; do not generate userspace notifications. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index b70e915be66d..ef93f6c983f3 100644

[PATCH net-next v2 6/8] rtnetlink: Do not generate notifications for CHANGELOWERSTATE event

CHANGELOWERSTATE is an internal event; do not generate userspace notifications. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 10df445bb818..b70e915be66d 100644

[PATCH net-next v2 3/8] rtnetlink: Do not generate notifications for CHANGEADDR event

Changing hardware address generates redundant messages: [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN group default link/ether 02:02:02:02:02:02 brd ff:ff:ff:ff:ff:ff [LINK]11: dummy1: mtu 1500 qdisc noqueue state UNKNOWN

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

On Wed, 2017-04-12 at 08:06 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2017-04-11 at 11:27 -0400, David Miller wrote: > > > I'll fix it in a next spin if Dave wants it that way but > > > otherwise > > > I'm keen to leave it as it is. > > > > Please fix this and respin. > > > > Meanwhile get

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

On 04/11/2017 04:14 PM, Andrew Lunn wrote: >> To give some more background and rational for this change. >> >> On a platform where we have a parent MDIO bus, backed by the >> mdio-bcm-unimac.c driver, we also register a slave MII bus (through >> net/dsa/dsa2.c) which is parented to this UniMAC

Re: af_packet: use after free in prb_retire_rx_blk_timer_expired

On Mon, Apr 10, 2017 at 3:23 PM, Dave Jones wrote: > On Mon, Apr 10, 2017 at 07:03:30PM +, alexander.le...@verizon.com wrote: > > Hi all, > > > > I seem to be hitting this use-after-free on a -next kernel using trinity: > > > > [ 531.036054] BUG: KASAN:

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

> To give some more background and rational for this change. > > On a platform where we have a parent MDIO bus, backed by the > mdio-bcm-unimac.c driver, we also register a slave MII bus (through > net/dsa/dsa2.c) which is parented to this UniMAC MDIO bus through an > assignment of of_node. This

Re: [PATCH] tools: bpf_jit_disasm: Add option to dump JIT image to a file.

On 04/11/2017 02:54 PM, Daniel Borkmann wrote: On 04/11/2017 11:30 PM, David Daney wrote: When debugging the JIT on an embedded platform or cross build environment, libbfd may not be available, making it impossible to run bpf_jit_disasm natively. Add an option to emit a binary image of the JIT

Re: [PATCH v2 iproute2 net-next 2/2] iproute: Add support for MPLS LWT ttl attribute

On 4/11/17 2:37 AM, Robert Shearman wrote: > Add support for setting and displaying the ttl attribute > for MPLS IP lighweight tunnels. > > Signed-off-by: Robert Shearman > --- > ip/iproute_lwtunnel.c | 31 +-- > man/man8/ip-route.8.in | 9

Re: [PATCH v2 iproute2 net-next 1/2] iproute: Add support for ttl-propagation attribute

On 4/11/17 2:37 AM, Robert Shearman wrote: > Add support for setting and displaying the ttl-propagation attribute > initially used by MPLS to control propagation of MPLS TTL to IPv4/IPv6 > TTL/hop-limit on popping final label on a per-route basis. > > Signed-off-by: Robert Shearman

Re: [RFC net-next] of: mdio: Honor hints from MDIO bus drivers

On 04/10/2017 02:42 PM, Florian Fainelli wrote: > A MDIO bus driver can set phy_mask to indicate which PHYs should be > probed and which should not. Right now, of_mdiobus_register() always > sets mdio->phy_mask to ~0 which means: don't probe anything yourself, > and let the Device Tree scanning do

Re: [PATCH 01/10] ftgmac100: Upgrade to NETIF_F_HW_CSUM

On Tue, 2017-04-11 at 11:27 -0400, David Miller wrote: > > I'll fix it in a next spin if Dave wants it that way but otherwise > > I'm keen to leave it as it is. > > Please fix this and respin. > > Meanwhile get the coding style rules changed if you disagree with > them.  A patch series review is

Re: [PATCH] tools: bpf_jit_disasm: Add option to dump JIT image to a file.

On 04/11/2017 11:30 PM, David Daney wrote: When debugging the JIT on an embedded platform or cross build environment, libbfd may not be available, making it impossible to run bpf_jit_disasm natively. Add an option to emit a binary image of the JIT code to a file. This file can then be

[PATCH] tools: bpf_jit_disasm: Add option to dump JIT image to a file.

When debugging the JIT on an embedded platform or cross build environment, libbfd may not be available, making it impossible to run bpf_jit_disasm natively. Add an option to emit a binary image of the JIT code to a file. This file can then be disassembled off line. Typical usage in this case

[PATCH] xen/9pfs: use %d format specifier instead of %u for a signed int

From: Colin Ian King variable i is a signed int, so use the %d print format specifier instead of %u. Fixes two warnings by cppcheck. Signed-off-by: Colin Ian King --- net/9p/trans_xen.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

> +#ifdef CONFIG_NET_DSA_LEGACY > static const char *mv88e6xxx_drv_probe(struct device *dsa_dev, > struct device *host_dev, int sw_addr, > void **priv) > @@ -4256,6 +4257,7 @@ static const char *mv88e6xxx_drv_probe(struct

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

On 04/11/2017 01:52 PM, Vivien Didelot wrote: > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, > which is true by default. > > DSA drivers

Re: [PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

On Mon, Apr 10, 2017 at 03:50:44PM -0400, Aaron Conole wrote: > There are no in-tree callers of this function and it isn't exported. > > Signed-off-by: Aaron Conole Thanks, applied to ipvs-next.

[PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

This patch moves as is the legacy DSA code from dsa.c to legacy.c, except the few shared symbols which remain in dsa.c. Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, which is true by default. DSA drivers without legacy support don't need the probe function as well as

Re: vlan tagging problem

On Tue, 2017-04-11 at 15:36 -0400, carl h wrote: > Hi > > Hope this is right place to ask this. Looking for help regarding vlan > tagging done by the 8021q driver. > > I tried to manually configure a vlan on my target device. I use these > 2 vlan config commands, then I ping an IP address and

Re: [PATCH 06/12] audit: Use timespec64 to represent audit timestamps

On Sat, Apr 8, 2017 at 1:58 PM, Deepa Dinamani wrote: >> I have no problem merging this patch into audit/next for v4.12, would >> you prefer me to do that so at least this patch is merged? > > This would be fine. > But, I think whoever takes the last 2 deletion patches

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On Tue, 2017-04-11 at 13:42 -0400, David Miller wrote: > > Then, the library needs to be extended to enable this handling to > > modify the way it needs to handle errors, together with the > > setsockopt(). So I'd tend to agree, but * it was easy to solve this, with the flags I added * the

vlan tagging problem

Hi Hope this is right place to ask this. Looking for help regarding vlan tagging done by the 8021q driver. I tried to manually configure a vlan on my target device. I use these 2 vlan config commands, then I ping an IP address and sniff the packets to look for the vlan tag in the messages.

Re: [PATCH net-next v5 2/2] L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.

Hi Guillaume, Please see inline: On Tue, Apr 11, 2017 at 10:05 AM, Guillaume Nault wrote: > On Tue, Apr 11, 2017 at 09:39:58AM -0700, R Parameswaran wrote: >> Hi Guillaume, >> >> On Tue, Apr 11, 2017 at 3:40 AM, Guillaume Nault >> wrote: >> > On

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On 4/11/17 1:05 PM, David Miller wrote: > From: David Ahern > Date: Tue, 11 Apr 2017 12:57:59 -0600 > >> On 4/11/17 11:42 AM, David Miller wrote: >>> David, if you have a specific case where it's absolutely impossible >>> to resolve this when the library is converted to

Re: [PATCH v3 1/5] netlink: extended ACK reporting

From: David Ahern Date: Tue, 11 Apr 2017 12:57:59 -0600 > On 4/11/17 11:42 AM, David Miller wrote: >> David, if you have a specific case where it's absolutely impossible >> to resolve this when the library is converted to support extended >> ACKs, please mention it. >

Re: RFC: Checksum offload and XDP

From: Jakub Kicinski Date: Tue, 11 Apr 2017 11:34:25 -0700 > On Tue, 11 Apr 2017 18:43:47 +0200, Daniel Borkmann wrote: >> cls_bpf has a couple of helpers like bpf_l3_csum_replace(), >> bpf_l4_csum_replace() >> bpf_csum_diff(), bpf_csum_update(), where we (cilium at least) use

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On 4/11/17 11:42 AM, David Miller wrote: > David, if you have a specific case where it's absolutely impossible > to resolve this when the library is converted to support extended > ACKs, please mention it. I don't have a specific library in mind. It is more the disjoint nature of a socket option

Re: [PATCH net-next v2] bpf: pass sk to helper functions

From: Willem de Bruijn Date: Tue, 11 Apr 2017 14:08:08 -0400 > From: Willem de Bruijn > > BPF helper functions access socket fields through skb->sk. This is not > set in ingress cgroup and socket filters. The association is only made > in

Re: [PATCH net-next v2] devlink: fix return value check in devlink_dpipe_header_put()

From: Wei Yongjun Date: Tue, 11 Apr 2017 16:02:02 + > From: Wei Yongjun > > Fix the return value check which testing the wrong variable > in devlink_dpipe_header_put(). > > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") >

Re: [PATCH] net: stmmac: add drop transmit status feature

From: Joao Pinto Date: Tue, 11 Apr 2017 15:44:10 +0100 > +static void dwmac4_enable_tx_drop(struct mac_device_info *hw) > +{ > + void __iomem *ioaddr = hw->pcsr; > + u32 value = readl(ioaddr + MTL_OPERATION_MODE); > + > + value &= ~MTL_OPERATION_DTXSTS; > +

Re: [PATCH net-next 00/10] more s390/net updates

From: Julian Wiedmann Date: Tue, 11 Apr 2017 16:11:09 +0200 > here's a second batch of s390/net patches for net-next. > A mixed bunch of qeth cleanups, and a few patches to add support for > ETHTOOL_GLINKSETTINGS. Series applied, thanks.

Re: RFC: Checksum offload and XDP

On Tue, 11 Apr 2017 18:13:37 +0100, Edward Cree wrote: > > Note that this only applies to > > checksum_complete, if we were to allow XDP program to return > > checksum_unnecessary for instance then it's more a leap of faith that > > things are always correct. > Speaking of checksum_unnecessary,

Re: [PATCH net-next v4 1/2] bpf: remove struct bpf_prog_type_list

From: Johannes Berg Date: Tue, 11 Apr 2017 15:34:57 +0200 > From: Johannes Berg > > There's no need to have struct bpf_prog_type_list since > it just contains a list_head, the type, and the ops > pointer. Since the types are densely packed

Re: [PATCH net-next v4 2/2] bpf: remove struct bpf_map_type_list

From: Johannes Berg Date: Tue, 11 Apr 2017 15:34:58 +0200 > From: Johannes Berg > > There's no need to have struct bpf_map_type_list since > it just contains a list_head, the type, and the ops > pointer. Since the types are densely packed and

Re: [PATCH net-next 0/6] net: fec: driver code clean

From: Fugang Duan Date: Tue, 11 Apr 2017 19:13:02 +0800 > The patch series are for fec ethernet driver code clean up, each patch is > independent. > Patch #1,#4,#5 are code clean up. > Patch #2,#3 are for aarch64 platform. > Patch #6 is for i.MX6UL to add lost errata

Re: RFC: Checksum offload and XDP

On Tue, 11 Apr 2017 18:43:47 +0200, Daniel Borkmann wrote: > cls_bpf has a couple of helpers like bpf_l3_csum_replace(), > bpf_l4_csum_replace() > bpf_csum_diff(), bpf_csum_update(), where we (cilium at least) use checksum > diffs extensively. You can then also leave the option to the user to

Re: [PATCH net-next v2] bpf: pass sk to helper functions

On Tue, Apr 11, 2017 at 02:08:08PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > BPF helper functions access socket fields through skb->sk. This is not > set in ingress cgroup and socket filters. The association is only made > in skb_set_owner_r once the filter

[PATCH net-next v2] bpf: pass sk to helper functions

From: Willem de Bruijn BPF helper functions access socket fields through skb->sk. This is not set in ingress cgroup and socket filters. The association is only made in skb_set_owner_r once the filter has accepted the packet. Sk is available as socket lookup has taken place.

Re: [PATCH net-next 0/2] l2tp: drop l2tp_session_find()

From: Guillaume Nault Date: Tue, 11 Apr 2017 13:12:03 +0200 > l2tp_netlink is the last user of l2tp_session_find(), but that call is > useless. Let's remove it and drop l2tp_session_find() definitely. Series applied, thank you.

Re: [PATCH v3 1/5] netlink: extended ACK reporting

From: Pablo Neira Ayuso Date: Tue, 11 Apr 2017 19:31:43 +0200 > On Tue, Apr 11, 2017 at 08:25:57AM -0600, David Ahern wrote: >> On 4/11/17 1:02 AM, Johannes Berg wrote: >> > On Tue, 2017-04-11 at 08:59 +0200, Pablo Neira Ayuso wrote: >> >> CAP_ACK means: trim off the payload

Re: [PATCH net-next] bpf: pass sk to helper functions

On Tue, Apr 11, 2017 at 12:51 PM, Eric Dumazet wrote: > On Tue, 2017-04-11 at 12:22 -0400, Willem de Bruijn wrote: >> From: Willem de Bruijn >> >> BPF helper functions access socket fields through skb->sk. This is not >> set in ingress cgroup and

Re: [PATCH v3 1/5] netlink: extended ACK reporting

On Tue, Apr 11, 2017 at 08:25:57AM -0600, David Ahern wrote: > On 4/11/17 1:02 AM, Johannes Berg wrote: > > On Tue, 2017-04-11 at 08:59 +0200, Pablo Neira Ayuso wrote: > >> CAP_ACK means: trim off the payload that the netlink error message > >> is embedding, just like ICMP error does. > >> > >>

Re: RFC: Checksum offload and XDP

On Tue, Apr 11, 2017 at 10:13 AM, Edward Cree wrote: > On 11/04/17 17:46, Tom Herbert wrote: >> On Tue, Apr 11, 2017 at 8:55 AM, Edward Cree wrote: >>> The counter-argument, of course, is that if the XDP program edits fields >>> that are protected by

Re: [PATCH] net: phy: micrel: KSZ9031: fix crash when statistic requested

On 04/11/2017 11:36 AM, Andrew Lunn wrote: I've considered all this option, honestly, but I do not know if this phys (issue should affect KSZ886X, KSZ8873MLL, KSZ9031, KSZ9021, KSZ8061, KS8737) support fetching statistics or not and was hoping to get feedback from community. Hi Grygorii

Re: RFC: Checksum offload and XDP

On 11/04/17 17:46, Tom Herbert wrote: > On Tue, Apr 11, 2017 at 8:55 AM, Edward Cree wrote: >> The counter-argument, of course, is that if the XDP program edits fields >> that are protected by an Internet checksum (which in practice usually >> means anything but the

Re: [PATCH net-next v5 2/2] L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.

On Tue, Apr 11, 2017 at 09:39:58AM -0700, R Parameswaran wrote: > Hi Guillaume, > > On Tue, Apr 11, 2017 at 3:40 AM, Guillaume Nault wrote: > > On Wed, Apr 05, 2017 at 05:00:07PM -0700, R. Parameswaran wrote: > >> > >> Change-set here uses the new kernel function,

Re: [PATCH net-next] bpf: pass sk to helper functions

On Tue, 2017-04-11 at 12:22 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > BPF helper functions access socket fields through skb->sk. This is not > set in ingress cgroup and socket filters. The association is only made > in skb_set_owner_r once the filter has

Re: RFC: Checksum offload and XDP

On Tue, Apr 11, 2017 at 8:55 AM, Edward Cree wrote: > On 10/04/17 19:26, Tom Herbert wrote: >> Not having checksum offload in XDP is going to get more painful once >> we start seeing a lot programs doing packet modifications. One nice >> thing we do for ILA router is

Re: RFC: Checksum offload and XDP

On 04/11/2017 05:55 PM, Edward Cree wrote: On 10/04/17 19:26, Tom Herbert wrote: Not having checksum offload in XDP is going to get more painful once we start seeing a lot programs doing packet modifications. One nice thing we do for ILA router is pre-compute the checksum delta necessary to

Re: [PATCH net-next v5 2/2] L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.

Hi Guillaume, On Tue, Apr 11, 2017 at 3:40 AM, Guillaume Nault wrote: > On Wed, Apr 05, 2017 at 05:00:07PM -0700, R. Parameswaran wrote: >> >> Change-set here uses the new kernel function, kernel_sock_ip_overhead(), >> to factor the outer IP overhead on the L2TP tunnel

Re: [PATCH] net: phy: micrel: KSZ9031: fix crash when statistic requested

> I've considered all this option, honestly, but I do not know if this > phys (issue should affect KSZ886X, KSZ8873MLL, KSZ9031, KSZ9021, KSZ8061, > KS8737) > support fetching statistics or not and was hoping to get feedback from > community. Hi Grygorii Microchip are one of the good guys. All

Re: [PATCH v2 net-next RFC] Generic XDP

On Sun, 2017-04-09 at 13:35 -0700, David Miller wrote: > This provides a generic non-optimized XDP implementation when the > device driver does not provide an optimized one. > > It is arguable that perhaps I should have required something like > this as part of the initial XDP feature merge. > >

[PATCH net-next] bpf: pass sk to helper functions

From: Willem de Bruijn BPF helper functions access socket fields through skb->sk. This is not set in ingress cgroup and socket filters. The association is only made in skb_set_owner_r once the filter has accepted the packet. Sk is available as socket lookup has taken place.

Re: [PATCH] net: phy: micrel: KSZ9031: fix crash when statistic requested

On 04/10/2017 06:40 PM, Florian Fainelli wrote: > On 04/10/2017 04:33 PM, Grygorii Strashko wrote: >> Now the command: >> ethtool --phy-statistics eth0 >> will cause system crash with meassage "Unable to handle kernel NULL pointer >> dereference at virtual address 0010" from: >> >>

  1   2   3   >