Re: [RFC patch 1/1] large netlink dumps

On Sat, 2017-04-15 at 13:07 -0400, Jamal Hadi Salim wrote: > Eric, > > How does attached look instead of the 32K? > I found it helps to let user space suggest something > larger. > > cheers, > jamal Looks dangerous to me, for various reasons. 1) Memory allocations might not like it Have you

Re: TPACKET_V3 timeout bug?

On Apr 15, 2017, at 7:10 PM, Andrew Lunn wrote: > Do you think this is a kernel problem, libpcap problem, or an > application problem? An application problem. See my response on netdev; the timeout (which is provided by the kernel's capture mechanism, in most cases) is to make

Re: TPACKET_V3 timeout bug?

On Apr 15, 2017, at 4:44 PM, Andrew Lunn wrote: > Yet i'm debugging an application which expects a timeout even when > there are 0 packets. Well, you've already found a bug - it expects a timeout where there are no packets. To quote the pcap man page (this is the latest

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

It should be fixed for 4.12. Basically, __udp6_lib_demux_lookup needs to be more like __udp4_lib_demux_lookup Hi David Would it be possible for you to test this with udp_l3mdev_accept=0 diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index b793ed1..0e307e5 100644 --- a/net/ipv6/udp.c +++

Re: TPACKET_V3 timeout bug?

On Sat, Apr 15, 2017 at 06:45:36PM -0400, Sowmini Varadhan wrote: > On (04/15/17 21:40), Andrew Lunn wrote: > > > > In my case, lan3 is up and idle, there are no packets flying around to > > be captured. So i would expect pcap_next_ex() to exit once a second, > > with a return value of 0. But it

[PATCH -next] rhashtable: remove insecure_elasticity

commit 83e7e4ce9e93c3 ("mac80211: Use rhltable instead of rhashtable") removed the last user that made use of 'insecure_elasticity' parameter, i.e. the default of 16 is used everywhere. Replace it with a constant. Signed-off-by: Florian Westphal --- include/linux/rhashtable.h |

Re: [PATCH RFC (resend) net-next 5/6] virtio-net: Add support for vlan acceleration vnet header extension.

On Sat, Apr 15, 2017 at 12:38:17PM -0400, Vladislav Yasevich wrote: > This extension allows us to pass vlan ID and vlan protocol data to the > host hypervisor as part of the vnet header and lets us take advantage > of HW accelerated vlan tagging in the host. It requires support in the > host to

Re: TPACKET_V3 timeout bug?

On Sat, Apr 15, 2017 at 06:45:36PM -0400, Sowmini Varadhan wrote: > On (04/15/17 21:40), Andrew Lunn wrote: > > > > In my case, lan3 is up and idle, there are no packets flying around to > > be captured. So i would expect pcap_next_ex() to exit once a second, > > with a return value of 0. But it

Re: TPACKET_V3 timeout bug?

On (04/15/17 21:40), Andrew Lunn wrote: > > In my case, lan3 is up and idle, there are no packets flying around to > be captured. So i would expect pcap_next_ex() to exit once a second, > with a return value of 0. But it is not, it blocks and stays blocked. : > Looking at the libpcap source,

Re: 4.10.9 nok with realtek wlan, atom

On 04/14/2017 03:26 PM, rupert THURNER wrote: On Thu, Feb 9, 2017 at 9:09 PM, Larry Finger wrote: On 02/09/2017 01:43 PM, Bjorn Helgaas wrote: [+cc rtl8192ce folks in case they've seen this] On Thu, Feb 09, 2017 at 03:45:01PM +0100, rupert THURNER wrote: hi,

Re: [PATCH] Revert "mm, page_alloc: only use per-cpu allocator for irq-safe requests"

On Sat, Apr 15, 2017 at 09:28:33PM +0200, Jesper Dangaard Brouer wrote: > On Sat, 15 Apr 2017 15:53:50 +0100 > Mel Gorman wrote: > > > This reverts commit 374ad05ab64d696303cec5cc8ec3a65d457b7b1c. While the > > patch worked great for userspace allocations, the fact

Re: [PATCH v3 3/4] bluetooth: hci_uart: add LL protocol serdev driver support

Hi, On Thu, Apr 13, 2017 at 10:03:52AM -0500, Rob Herring wrote: > +static int read_local_version(struct hci_dev *hdev) > +{ > + int err = 0; > + unsigned short version = 0; > + struct sk_buff *skb; > + struct hci_rp_read_local_version *ver; > + > + skb = __hci_cmd_sync(hdev,

TPACKET_V3 timeout bug?

Hi Folks I'm running this simple program using libpcap: #include #include #include #include int main(int argc, char *argv[]) { struct pcap_pkthdr *hdr; const uint8_t *data; pcap_t *handle; int ret; handle = pcap_open_live("lan3", 65535, 1, 1000,

Re: [PATCH v3 1/4] dt-bindings: net: Add TI WiLink shared transport binding

Hi, On Thu, Apr 13, 2017 at 10:03:50AM -0500, Rob Herring wrote: > Add serial slave device binding for the TI WiLink series of Bluetooth/FM/GPS > devices. > > Signed-off-by: Rob Herring > Cc: Mark Rutland > Cc: netdev@vger.kernel.org > Cc:

Re: [PATCH] Revert "mm, page_alloc: only use per-cpu allocator for irq-safe requests"

On Sat, 15 Apr 2017 15:53:50 +0100 Mel Gorman wrote: > This reverts commit 374ad05ab64d696303cec5cc8ec3a65d457b7b1c. While the > patch worked great for userspace allocations, the fact that softirq loses > the per-cpu allocator caused problems. It needs to be redone

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

> On April 15, 2017 at 8:20 PM Cong Wang wrote: > > > On Fri, Apr 14, 2017 at 2:08 AM, Wolfgang Bumiller > wrote: > > Before I do that - trying to wrap my head around the interdependencies > > here better to be thorough - I noticed that

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

On Fri, Apr 14, 2017 at 2:08 AM, Wolfgang Bumiller wrote: > Before I do that - trying to wrap my head around the interdependencies > here better to be thorough - I noticed that tcf_hash_release() can > return ACT_P_DELETED. The ACT_P_CREATED case means tcf_hash_create() >

[RFC patch 1/1] large netlink dumps

Eric, How does attached look instead of the 32K? I found it helps to let user space suggest something larger. cheers, jamal diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 7b73c7c..bc982ef 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1849,7

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

On 17-04-15 10:12 AM, Jamal Hadi Salim wrote: On 17-04-12 09:22 PM, Cong Wang wrote: Sorry - didnt get the full thread (the OP managed to post to CC linux kernel list but not me); trying to catch up. So the issue if i understood: Policer was created but failed and we the error code

[PATCH RFC (resend) net-next 1/6] virtio-net: Remove the use the padded vnet_header structure

We can replace the structure with a properly aligned size instead. The current structure attempts to align on a 16 byte boundary, so preserve it. Signed-off-by: Vlad Yaseivch --- drivers/net/virtio_net.c | 22 -- 1 file changed, 12 insertions(+), 10

[PATCH RFC (resend) net-next 4/6] virtio-net: Add support for IPv6 fragment id vnet header extension.

This adds the ability to pass a guest generated IPv6 fragment id to the host hypervisor. The id is passed as big endian to eliminate unnecessary conversions. The host will be able to directly use this id instead of attempting to generate its own. This makes the IPv6 framgnet id sligtly harder

[PATCH RFC (resend) net-next 3/6] virtio_net: Add basic skeleton for handling vnet header extensions.

This is the basic sceleton which will be fleshed out by individiual extensions. Signed-off-by: Vladislav Yasevich --- drivers/net/virtio_net.c| 21 + include/linux/virtio_net.h | 12 include/uapi/linux/virtio_net.h | 11

[PATCH RFC (resend) net-next 5/6] virtio-net: Add support for vlan acceleration vnet header extension.

This extension allows us to pass vlan ID and vlan protocol data to the host hypervisor as part of the vnet header and lets us take advantage of HW accelerated vlan tagging in the host. It requires support in the host to negotiate the feature. When the extension is enabled, the virtio device will

[PATCH RFC (resend) net-next 6/6] virtio: Add support for UDP tunnel offload and extension.

This patch provides the ablility to negotiate UDP tunnel offload features in the virtio devices as well as the necesary extension to pass additional information to the host. This work is based on earlier work by Jarno Rajahalme

[PATCH RFC (resend) net-next 2/6] virtio-net: make header length handling uniform

Consistently use hdr_len stored in virtnet_info structure instead of direclty using specific sizes. This will be required as the size of the virtio net header grows due to future extensions. Signed-off-by: Vladislav Yasevich --- drivers/net/virtio_net.c | 8 1 file

[PATCH RFC (resend) net-next 0/6] virtio-net: Add support for virtio-net header extensions

Curreclty virtion net header is fixed size and adding things to it is rather difficult to do. This series attempt to add the infrastructure as well as some extensions that try to resolve some deficiencies we currently have. First, vnet header only has space for 16 flags. This may not be enough

Re: [PATCH v4 net-next RFC] net: Generic XDP

On 4/14/17 6:59 PM, Alexei Starovoitov wrote: > I'll test it next week unless people beat me to it. > I have run the xdp1 example from samples/bpf. I have a patch that modifies set_link_xdp_fd to take a flags argument which it adds to the request as the IFLA_XDP_FLAGS attribute. That's used by

Re: [PATCH] mm, page_alloc: re-enable softirq use of per-cpu page allocator

On Fri, Apr 14, 2017 at 12:10:27PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 10 Apr 2017 14:26:16 -0700 > Andrew Morton wrote: > > > On Mon, 10 Apr 2017 16:08:21 +0100 Mel Gorman > > wrote: > > > > > IRQ context were excluded from

[PATCH] Revert "mm, page_alloc: only use per-cpu allocator for irq-safe requests"

This reverts commit 374ad05ab64d696303cec5cc8ec3a65d457b7b1c. While the patch worked great for userspace allocations, the fact that softirq loses the per-cpu allocator caused problems. It needs to be redone taking into account that a separate list is needed for hard/soft IRQs or alternatively find

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

On 17-04-12 09:22 PM, Cong Wang wrote: On Wed, Apr 12, 2017 at 7:21 AM, Wolfgang Bumiller wrote: Commit 1045ba77a ("net sched actions: Add support for user cookies") added code to net/sched/act_api.c's tcf_action_init_1 using the `tb` nlattr array unconditionally, while

[PATCH net-next 3/3] sctp: process duplicated strreset asoc request correctly

This patch is to fix the replay attack issue for strreset asoc requests. When a duplicated strreset asoc request is received, reply it with bad seqno if it's seqno < asoc->strreset_inseq - 2, and reply it with the result saved in asoc if it's seqno >= asoc->strreset_inseq - 2. But note that if

[PATCH net-next 1/3] sctp: process duplicated strreset out and addstrm out requests correctly

Now sctp stream reconf will process a request again even if it's seqno is less than asoc->strreset_inseq. If one request has been done successfully and some data chunks have been accepted and then a duplicated strreset out request comes, the streamin's ssn will be cleared. It will cause that

[PATCH net-next 2/3] sctp: process duplicated strreset in and addstrm in requests correctly

This patch is to fix the replay attack issue for strreset and addstrm in requests. When a duplicated strreset in or addstrm in request is received, reply it with bad seqno if it's seqno < asoc->strreset_inseq - 2, and reply it with the result saved in asoc if it's seqno >= asoc->strreset_inseq -

[PATCH net-next 0/3] sctp: add proper process for duplicated stream reconf requests

Now sctp stream reconf will process a request again even if it's seqno is less than asoc->strreset_inseq. It may cause a replay attack. This patchset is to avoid it by add proper process for all duplicated stream reconf requests. Xin Long (3): sctp: process duplicated strreset out and addstrm

Re: [patch iproute2/net-next repost] devlink: Add support for pipeline debug (dpipe)

From: Jiri Pirko Date: Sat, 15 Apr 2017 10:59:03 +0200 > Sat, Apr 15, 2017 at 01:01:38AM CEST, step...@networkplumber.org wrote: >>On Thu, 13 Apr 2017 11:30:27 +0200 >>Jiri Pirko wrote: >> >>> We actually took this code from teamdctl (at least it was an

[PATCH net-next] sctp: get list_of_streams of strreset outreq earlier

Now when processing strreset out responses, it gets outreq->list_of_streams only when result is performed. But if result is not performed, str_p will be NULL. It will cause panic in sctp_ulpevent_make_stream_reset_event if nums is not 0. This patch is to fix it by getting outreq->list_of_streams

Re: ipv6 udp early demux breaks udp_l3mdev_accept=0

From: David Ahern Date: Fri, 14 Apr 2017 18:42:14 -0600 > On 4/14/17 6:38 PM, Subash Abhinov Kasiviswanathan wrote: >> On 2017-04-14 16:23, David Ahern wrote: >>> Subash: >>> >>> My understanding of early demux is that it should only match connected >>> sockets

Re: [PATCH net-next v2] Add uid and cookie bpf helper to cg_skb_func_proto

On 04/15/2017 03:25 AM, Chenbo Feng wrote: From: Chenbo Feng BPF helper functions get_socket_cookie and get_socket_uid can be used for network traffic classifications, among others. Expose them also to programs of type BPF_PROG_TYPE_CGROUP_SKB. As of commit 8f917bba0042

Re: [PATCH 06/12] audit: Use timespec64 to represent audit timestamps

On Sat, Apr 8, 2017 at 5:58 PM, Deepa Dinamani wrote: >> I have no problem merging this patch into audit/next for v4.12, would >> you prefer me to do that so at least this patch is merged? > > This would be fine. > But, I think whoever takes the last 2 deletion patches

[PATCH iproute2 net-next v2 2/3] iproute: add support for SR-IPv6 lwtunnel encapsulation

This patch adds support for SEG6 encapsulation type ("ip route add ... encap seg6 ..."). Signed-off-by: David Lebrun --- ip/iproute.c | 6 +- ip/iproute_lwtunnel.c | 154 ++ 2 files changed, 158 insertions(+),

[PATCH iproute2 net-next v2 1/3] ip: add ip sr command to control SR-IPv6 internal structures

This patch adds commands to support the tunnel source properties ("ip sr tunsrc") and the HMAC key -> secret, algorithm binding ("ip sr hmac"). Signed-off-by: David Lebrun --- ip/Makefile| 2 +- ip/ip.c| 3 +- ip/ip_common.h | 1 + ip/ipseg6.c|

[PATCH iproute2 net-next v2 3/3] man: add documentation for IPv6 SR commands

This patch adds information about seg6 encapsulation in the ip-route manual, as well as the ip-sr manual page. Signed-off-by: David Lebrun --- man/man8/ip-route.8.in | 39 +++-- man/man8/ip-sr.8 | 58

[PATCH iproute2 net-next v2 0/3] Add support for IPv6 Segment Routing

This patch series adds support and documentation in iproute2 for encapsulation with IPv6 SR, and for control of HMAC mappings. v2: fix bad types and indentation Signed-off-by: David Lebrun David Lebrun (3): ip: add ip sr command to control SR-IPv6 internal

Re: [GIT 0/3] Second Round of IPVS Updates for v4.12

On Fri, Apr 14, 2017 at 02:06:25AM +0200, Pablo Neira Ayuso wrote: > On Fri, Apr 14, 2017 at 08:51:19AM +0900, Simon Horman wrote: > > On Fri, Apr 14, 2017 at 01:01:34AM +0200, Pablo Neira Ayuso wrote: > > > Hi Simon, > > > > > > On Mon, Apr 10, 2017 at 09:58:32AM -0700, Simon Horman wrote: > > >

Re: [patch iproute2/net-next repost] devlink: Add support for pipeline debug (dpipe)

Sat, Apr 15, 2017 at 01:01:38AM CEST, step...@networkplumber.org wrote: >On Thu, 13 Apr 2017 11:30:27 +0200 >Jiri Pirko wrote: > >> We actually took this code from teamdctl (at least it was an influence). >> Devlink style is so much different in every aspect from the rest of the

Re: [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

On Fri, Apr 14, 2017 at 04:15:41PM +0200, Jozsef Kadlecsik wrote: > Hi Pablo, > > On Fri, 14 Apr 2017, Pablo Neira Ayuso wrote: > > > On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote: > > > There are no in-tree callers. > > > > @Jozsef, let me know if I should just take this to save

Re: eBPF - little-endian load instructions?

On Fri, 2017-04-14 at 11:42 -0700, Alexei Starovoitov wrote: > bpf takes endianness of the cpu it runs on. Ok, so then things are actually not as difficult as I thought. > if we said that bpf 32-bit load insn is little endian, it would have > screwed up all big-endian archs and the other way