Re: [PATCH net] net: ipv6: regenerate host route if moved to gc list

2017-04-21 Thread Martin KaFai Lau
On Fri, Apr 21, 2017 at 04:40:30PM -0700, David Ahern wrote: > Taking down the loopback device wreaks havoc on IPv6 routes. By > extension, taking a VRF device wreaks havoc on its table. > > Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 > FIB code while running syzkaller fu

Re: [PATCH] xprtrdma: use offset_in_page() macro

2017-04-21 Thread Chuck Lever
> On Apr 21, 2017, at 9:21 PM, Geliang Tang wrote: > > Use offset_in_page() macro instead of open-coding. > > Signed-off-by: Geliang Tang > --- > net/sunrpc/xprtrdma/rpc_rdma.c| 4 ++-- > net/sunrpc/xprtrdma/svc_rdma_sendto.c | 3 +-- > 2 files changed, 3 insertions(+), 4 deletions(-) >

[PATCH 1/2] sparc: Split BPF JIT into 32-bit and 64-bit.

2017-04-21 Thread David Miller
This is in preparation for adding the 64-bit eBPF JIT. Signed-off-by: David S. Miller --- arch/sparc/net/Makefile | 2 +- arch/sparc/net/{bpf_jit.h => bpf_jit_32.h} | 0 arch/sparc/net/{bpf_jit_asm.S => bpf_jit_asm_32.S} | 2 +- arch/sparc/net/bpf_jit_as

[PATCH 2/2] sparc64: Add eBPF JIT.

2017-04-21 Thread David Miller
This is an eBPF JIT for sparc64. All major features are supported. All tests under tools/testing/selftests/bpf/ pass. Signed-off-by: David S. Miller --- arch/sparc/Kconfig|3 +- arch/sparc/net/bpf_jit_32.h |2 +- arch/sparc/net/{bpf_jit_32

[PATCH v2 net-next 0/2] sparc64 eBPF JIT

2017-04-21 Thread David Miller
This series adds an eBPF JIT for sparc64. Sparc32 keeps having it's cBPF JIT after these changes. Thanks to Daniel and Alexei for their invaluable feedback and review. Signed-off-by: David S. Miller --- since v1: -- add tail call support -- fix MOD generation to not emit the same constant l

[PATCH] xprtrdma: use offset_in_page() macro

2017-04-21 Thread Geliang Tang
Use offset_in_page() macro instead of open-coding. Signed-off-by: Geliang Tang --- net/sunrpc/xprtrdma/rpc_rdma.c| 4 ++-- net/sunrpc/xprtrdma/svc_rdma_sendto.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rp

[PATCH] net: atheros: atl1: use offset_in_page() macro

2017-04-21 Thread Geliang Tang
Use offset_in_page() macro instead of open-coding. Signed-off-by: Geliang Tang --- drivers/net/ethernet/atheros/atlx/atl1.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 0

Re: [PATCH RFC] sparc64: eBPF JIT

2017-04-21 Thread David Miller
From: Alexei Starovoitov Date: Tue, 18 Apr 2017 15:57:09 -0700 > Alternative idea: can the above > 'add FP, STACK_BIAS, one_of_local_regs' be done once in prologue > and that register used as substitue for R10 ? After much consideration I think this is what I'm going to end up doing, I should ha

Re: [PATCH 2/4] dt-bindings: add binding for RTL8211E Ethernet PHY

2017-04-21 Thread icenowy
在 2017-04-22 08:22,Florian Fainelli 写道: On 04/21/2017 04:24 PM, Icenowy Zheng wrote: From: Icenowy Zheng Some RTL8211E Ethernet PHY have an issue that needs a workaround indicated with device tree. Add the binding for a property that indicates this workaround. Signed-off-by: Icenowy Zheng -

Re: [PATCH net-next 0/3] mlx5: fix warnings

2017-04-21 Thread David Miller
From: Stephen Hemminger Date: Fri, 21 Apr 2017 11:15:55 -0700 > While looking for sparse and warning output in another driver, > I saw several trivial warnings from MLX5 driver. This patch > series fixes them. Saeed, please merge the patches you are OK with into your tree. Thank you.

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Saeed Mahameed
On Sat, Apr 22, 2017 at 3:47 AM, Ian Kumlien wrote: > On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed > wrote: >> On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: >>> Sorry, >>> >>> Back again, fighting cold, hot whiskey has been consumed... >>> >>> Something like this would perhaps be a bett

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed wrote: > On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: >> Sorry, >> >> Back again, fighting cold, hot whiskey has been consumed... >> >> Something like this would perhaps be a better solution: >> >> diff --git a/drivers/net/ethernet/mellanox/m

Re: [PATCH net-next 3/3] mlx5: fix space waste from ethtool descriptions

2017-04-21 Thread Saeed Mahameed
On Fri, Apr 21, 2017 at 9:15 PM, Stephen Hemminger wrote: > The ethtool statistics descriptions were declared as static in > en_stats.h but that file is included indirectly in multiple places > causing multiple unused redundant copies. This is reported by building > with W=1. > > The solution is t

Re: [PATCH net-next v2 1/5] nfp: make use of the DMA_ATTR_SKIP_CPU_SYNC attribute

2017-04-21 Thread Jakub Kicinski
On Fri, 21 Apr 2017 12:23:06 -0700, Jakub Kicinski wrote: > DMA unmap may destroy changes CPU made to the buffer. To make XDP > run correctly on non-x86 platforms we should use the > DMA_ATTR_SKIP_CPU_SYNC attribute. > > Thanks to using the attribute we can now push the sync operation to the > co

Re: [PATCH 3/4] net: phy: realtek: add disable RX delay hack for RTL8211E

2017-04-21 Thread Florian Fainelli
On 04/21/2017 04:24 PM, Icenowy Zheng wrote: > From: Icenowy Zheng > > Some RTL8211E chips have broken GbE function, which needs a hack to > fix. It's said that this fix will affect the performance on not-buggy > PHYs, so it should only be enabled on boards with the broken PHY. > Currently only s

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Saeed Mahameed
On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: > Sorry, > > Back again, fighting cold, hot whiskey has been consumed... > > Something like this would perhaps be a better solution: > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c > b/drivers/net/ethernet/mellanox/mlx5/core/main.

Re: [PATCH net v3] net/mlx5e: Fix race in mlx5e_sw_stats and mlx5e_vport_stats

2017-04-21 Thread Saeed Mahameed
On Fri, Apr 21, 2017 at 7:40 AM, Martin KaFai Lau wrote: > We have observed a sudden spike in rx/tx_packets and rx/tx_bytes > reported under /proc/net/dev. There is a race in mlx5e_update_stats() > and some of the get-stats functions (the one that we hit is the > mlx5e_get_stats() which is called

Re: [PATCH 2/4] dt-bindings: add binding for RTL8211E Ethernet PHY

2017-04-21 Thread Florian Fainelli
On 04/21/2017 04:24 PM, Icenowy Zheng wrote: > From: Icenowy Zheng > > Some RTL8211E Ethernet PHY have an issue that needs a workaround > indicated with device tree. > > Add the binding for a property that indicates this workaround. > > Signed-off-by: Icenowy Zheng > --- > .../devicetree/bind

[PATCH 2/2] drivers:net:ethernet:3com:3c512: array char instead of char pointer

2017-04-21 Thread Karim Eshapa
char pointer creates two variables static string and pointer to it according to Jeff Garzik janitors TODO Signed-off-by: Karim Eshapa --- drivers/net/ethernet/3com/3c515.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/etherne

[PATCH net-next 5/5] bnxt_en: Restrict a PF in Multi-Host mode from changing port PHY configuration

2017-04-21 Thread Michael Chan
From: Deepak Khungar This change restricts the PF in multi-host mode from setting any port level PHY configuration. The settings are controlled by firmware in Multi-Host mode. Signed-off-by: Deepak Khungar Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 +++

[PATCH net-next 4/5] bnxt_en: Check the FW_LLDP_AGENT flag before allowing DCBX host agent.

2017-04-21 Thread Michael Chan
Check the additional flag in bnxt_hwrm_func_qcfg() before allowing DCBX to be done in host mode. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/ne

[PATCH net-next 2/5] bnxt_en: Fix VF attributes reporting.

2017-04-21 Thread Michael Chan
The .ndo_get_vf_config() is returning the wrong qos attribute. Fix the code that checks and reports the qos and spoofchk attributes. The BNXT_VF_QOS and BNXT_VF_LINK_UP flags should not be set by default during init. time. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt

[PATCH net-next 3/5] bnxt_en: Add 100G link speed reporting for BCM57454 ASIC in ethtool

2017-04-21 Thread Michael Chan
From: Deepak Khungar Added support for 100G link speed reporting for Broadcom BCM57454 ASIC in ethtool command. Signed-off-by: Deepak Khungar Signed-off-by: Ray Jui Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++-- drivers/net/ethernet/broadcom/bnx

[PATCH net-next 1/5] bnxt_en: Pass DCB RoCE app priority to firmware.

2017-04-21 Thread Michael Chan
When the driver gets the RoCE app priority set/delete call through DCBNL, the driver will send the information to the firmware to set up the priority VLAN tag for RDMA traffic. [ New version using the common ETH_P_IBOE constant in if_ether.h ] Signed-off-by: Michael Chan --- drivers/net/etherne

[PATCH net-next 0/5] bnxt_en: Updates for net-next.

2017-04-21 Thread Michael Chan
Miscellaneous updates include passing DCBX RoCE VLAN priority to firmware, checking one more new firmware flag before allowing DCBX to run on the host, adding 100Gbps speed support, adding check to disallow speed settings on Multi-host NICs, and a minor fix for reporting VF attributes. Deepak Khun

Re: [PATCH 2/2] openvswitch: Add eventmask support to CT action.

2017-04-21 Thread Jarno Rajahalme
Thanks Joe, I’ll issue a v2 with the comment fix and retain the acks, so it should be good to go. Jarno > On Apr 20, 2017, at 11:53 AM, Joe Stringer wrote: > > On 19 April 2017 at 18:49, Jarno Rajahalme wrote: >> Add a new optional conntrack action attribute OVS_CT_ATTR_EVENTMASK, >> which

[PATCH net-next v2 2/2] openvswitch: Add eventmask support to CT action.

2017-04-21 Thread Jarno Rajahalme
Add a new optional conntrack action attribute OVS_CT_ATTR_EVENTMASK, which can be used in conjunction with the commit flag (OVS_CT_ATTR_COMMIT) to set the mask of bits specifying which conntrack events (IPCT_*) should be delivered via the Netfilter netlink multicast groups. Default behavior depend

[PATCH net-next v2 1/2] openvswitch: Typo fix.

2017-04-21 Thread Jarno Rajahalme
Fix typo in a comment. Signed-off-by: Jarno Rajahalme Acked-by: Greg Rose --- net/openvswitch/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index 7b2c2fc..58de4c2 100644 --- a/net/openvswitch/conntrack.c

[PATCH 4/4] [DO NOT MERGE] arm64: allwinner: a64: enable RTL8211E PHY workaround

2017-04-21 Thread Icenowy Zheng
From: Icenowy Zheng Some Pine64+ boards are said to have broken RTL8211E PHY. Enable the workaround in Pine64+ device tree file. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-plus.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dt

[PATCH 3/4] net: phy: realtek: add disable RX delay hack for RTL8211E

2017-04-21 Thread Icenowy Zheng
From: Icenowy Zheng Some RTL8211E chips have broken GbE function, which needs a hack to fix. It's said that this fix will affect the performance on not-buggy PHYs, so it should only be enabled on boards with the broken PHY. Currently only some Pine64+ boards are known to have this issue. This ha

[PATCH net] net: ipv6: regenerate host route if moved to gc list

2017-04-21 Thread David Ahern
Taking down the loopback device wreaks havoc on IPv6 routes. By extension, taking a VRF device wreaks havoc on its table. Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 FIB code while running syzkaller fuzzer. The root cause is a dead dst that is on the garbage list gets re

[PATCH 2/4] dt-bindings: add binding for RTL8211E Ethernet PHY

2017-04-21 Thread Icenowy Zheng
From: Icenowy Zheng Some RTL8211E Ethernet PHY have an issue that needs a workaround indicated with device tree. Add the binding for a property that indicates this workaround. Signed-off-by: Icenowy Zheng --- .../devicetree/bindings/net/realtek,rtl8211e.txt | 22 ++ 1 fi

[PATCH 1/4] net: phy: realtek: change macro name for page select register

2017-04-21 Thread Icenowy Zheng
From: Icenowy Zheng The page select register also exists on RTL8211E PHY (although it behaves slightly differently). Change the register macro name to remove the F. Signed-off-by: Icenowy Zheng --- drivers/net/phy/realtek.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) d

[PATCH 0/4] RTL8211E-specified hacks

2017-04-21 Thread Icenowy Zheng
Some Pine64 boards are reported to have broken RTL8211E PHYs, which will fail to work at 1000BASE-T mode if not workarounded. The workaround is retrieved from Pine64, and is said to be from Realtek engineer. It's undocumented but effective. (Tested on my Pine64 with GbE broken) The first patch is

Re: [PATCH net-next v2 5/5] virtio-net: keep tx interrupts disabled unless kick

2017-04-21 Thread Willem de Bruijn
On Thu, Apr 20, 2017 at 10:03 AM, Willem de Bruijn wrote: >>> - if (!use_napi) >>> + if (use_napi) { >>> + if (kick) >>> + virtqueue_enable_cb_delayed(sq->vq); >>> + else >>> + virtqueue_disable_cb(sq->vq); >> >> >

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
Sorry, Back again, fighting cold, hot whiskey has been consumed... Something like this would perhaps be a better solution: diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index 60154a175bd3..fe192e247601 100644 --- a/drivers/net/ethern

[PATCH net] udp: disable inner UDP checksum offloads in IPsec case

2017-04-21 Thread Ansis Atteka
Otherwise, UDP checksum offloads could corrupt ESP packets by attempting to calculate UDP checksum when this inner UDP packet is already protected by IPsec. One way to reproduce this bug is to have a VM with virtio_net driver (UFO set to ON in the guest VM); and then encapsulate all guest's Ethern

Re: [PATCH net] xfrm: calculate L4 checksums also for GSO case before encrypting packets

2017-04-21 Thread Ansis Atteka
On 20 April 2017 at 02:47, Steffen Klassert wrote: > On Tue, Apr 18, 2017 at 07:10:03PM -0700, Ansis Atteka wrote: >> >> However, after taking pointers from your patch I came up with this one >> that may solve this problem once and for all (note, that I was seeing >> this bug only with ixgbe NIC t

[PATCH 2/2] igb: Remove useless argument

2017-04-21 Thread Benjamin Poirier
Given that all callers of igb_update_stats() pass the same two arguments: (adapter, &adapter->stats64), the second argument can be removed. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/igb/igb.h | 2 +- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- drivers/net/

[PATCH 1/2] e1000e: Don't return uninitialized stats

2017-04-21 Thread Benjamin Poirier
Some statistics passed to ethtool are garbage because e1000e_get_stats64() doesn't write them, for example: tx_heartbeat_errors. This leaks kernel memory to userspace and confuses users. Do like ixgbe and use dev_get_stats() which first zeroes out rtnl_link_stats64. Reported-by: Stefan Priebe Si

[PATCH] macsec: avoid heap overflow in skb_to_sgvec

2017-04-21 Thread Jason A. Donenfeld
While this may appear as a humdrum one line change, it's actually quite important. An sk_buff stores data in three places: 1. A linear chunk of allocated memory in skb->data. This is the easiest one to work with, but it precludes using scatterdata since the memory must be linear. 2. The arra

Re: macvlan: Fix device ref leak when purging bc_queue

2017-04-21 Thread Joe.Ghalam
> From: Mahesh Bandewar (महेश बंडेवार) > Sent: Friday, April 21, 2017 12:23 PM > To: Ghalam, Joe > Cc: herb...@gondor.apana.org.au; David Miller; Wichmann, Clifford; > linux-netdev > Subject: Re: macvlan: Fix device ref leak when purging bc_queue > May be

Re: [PATCH net-next 0/3] l3mdev: Improve use with main table

2017-04-21 Thread David Ahern
On 4/21/17 11:44 AM, Robert Shearman wrote: > > Can you send me some more details of your testing? It's a shell script that runs a long list of combinations of client, server and local traffic for ipv4 and ipv6 with addresses on the external interface, the vrf device and 127.0.0.1 on the VRF devi

[PATCH net-next 3/7] ibmvnic: Only retrieve error info if present

2017-04-21 Thread Nathan Fontenot
When handling a fatal error in the driver, there can be additional error information provided by the vios. This information is not always present, so only retrieve the additional error information when present. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 71

Re: [PATCH net v2] ipv4: Avoid caching l3mdev dst on mismatched local route

2017-04-21 Thread David Ahern
On 4/21/17 2:34 PM, Robert Shearman wrote: > David reported that doing the following: > > ip li add red type vrf table 10 > ip link set dev eth1 vrf red > ip addr add 127.0.0.1/8 dev red > ip link set dev eth1 up > ip li set red up > ping -c1 -w1 -I red 127.0.0.1 > ip l

[PATCH net v2] ipv4: Avoid caching l3mdev dst on mismatched local route

2017-04-21 Thread Robert Shearman
David reported that doing the following: ip li add red type vrf table 10 ip link set dev eth1 vrf red ip addr add 127.0.0.1/8 dev red ip link set dev eth1 up ip li set red up ping -c1 -w1 -I red 127.0.0.1 ip li del red when either policy routing IP rules are present or

Re: Heads-up: two regressions in v4.11-rc series

2017-04-21 Thread Frederic Weisbecker
On Fri, Apr 21, 2017 at 10:52:29AM -0700, Linus Torvalds wrote: > On Thu, Apr 20, 2017 at 7:30 AM, Mel Gorman > wrote: > >> The end result was a revert, and this is waiting in AKPMs quilt queue: > >> > >> http://ozlabs.org/~akpm/mmots/broken-out/revert-mm-page_alloc-only-use-per-cpu-allocator-f

Re: [Patch net] ip6mr: avoid double unregister of pim6reg device

2017-04-21 Thread Nikolay Aleksandrov
On 21/04/17 23:20, Cong Wang wrote: > On Fri, Apr 21, 2017 at 12:34 PM, Nikolay Aleksandrov > wrote: >> On 21/04/17 22:27, Cong Wang wrote: >>> If we unregister the pim6reg device via default_device_exit_batch(), >>> we will receive a notification and ip6mr_device_event() will >>> unregister it ag

Re: [Patch net] ip6mr: avoid double unregister of pim6reg device

2017-04-21 Thread Cong Wang
On Fri, Apr 21, 2017 at 12:34 PM, Nikolay Aleksandrov wrote: > On 21/04/17 22:27, Cong Wang wrote: >> If we unregister the pim6reg device via default_device_exit_batch(), >> we will receive a notification and ip6mr_device_event() will >> unregister it again. This causes a kernel BUG at net/core/de

Re: [PATCH net-next] Replace 2 jiffies with sysctl netdev_budget_usecs to enable softirq tuning

2017-04-21 Thread Eric Dumazet
On Fri, 2017-04-21 at 16:00 -0400, David Miller wrote: > That's true, I'll kill this. > Thanks !

Re: [PATCH net-next] Replace 2 jiffies with sysctl netdev_budget_usecs to enable softirq tuning

2017-04-21 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Apr 2017 12:57:02 -0700 > On Fri, 2017-04-21 at 13:22 -0400, David Miller wrote: >> From: Matthew Whitehead >> Date: Wed, 19 Apr 2017 12:37:10 -0400 >> >> > Constants used for tuning are generally a bad idea, especially as hardware >> > changes over time. Replac

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 21 Apr 2017 22:56:26 +0300 > On 21/04/17 22:50, Nikolay Aleksandrov wrote: >> On 21/04/17 22:36, David Miller wrote: >>> From: Nikolay Aleksandrov >>> Date: Fri, 21 Apr 2017 21:30:42 +0300 >>> On 21/04/17 20:42, Nikolay Aleksandrov wrote: > Andrey Ko

Re: [PATCH net-next] Replace 2 jiffies with sysctl netdev_budget_usecs to enable softirq tuning

2017-04-21 Thread Eric Dumazet
On Fri, 2017-04-21 at 13:22 -0400, David Miller wrote: > From: Matthew Whitehead > Date: Wed, 19 Apr 2017 12:37:10 -0400 > > > Constants used for tuning are generally a bad idea, especially as hardware > > changes over time. Replace the constant 2 jiffies with sysctl variable > > netdev_budget_us

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread Nikolay Aleksandrov
On 21/04/17 22:50, Nikolay Aleksandrov wrote: > On 21/04/17 22:36, David Miller wrote: >> From: Nikolay Aleksandrov >> Date: Fri, 21 Apr 2017 21:30:42 +0300 >> >>> On 21/04/17 20:42, Nikolay Aleksandrov wrote: Andrey Konovalov reported a BUG caused by the ip6mr code which is caused becau

[GIT] Networking

2017-04-21 Thread David Miller
1) Don't race in IPSEC dumps, from Yuejie Shi. 2) Verify lengths properly in IPSEC reqeusts, from Herbert Xu. 3) Fix out of bounds access in ipv6 segment routing code, from David Lebrun. 4) Don't write into the header of cloned SKBs in smsc95xx driver, from James Hughes. 5) Several other

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 21 Apr 2017 22:50:35 +0300 > On 21/04/17 22:36, David Miller wrote: >> From: Nikolay Aleksandrov >> Date: Fri, 21 Apr 2017 21:30:42 +0300 >> >>> On 21/04/17 20:42, Nikolay Aleksandrov wrote: Andrey Konovalov reported a BUG caused by the ip6mr code which

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
On Fri, Apr 21, 2017 at 9:47 PM, David Miller wrote: > From: Ian Kumlien > Date: Fri, 21 Apr 2017 21:45:00 +0200 > >> The mellanox driver supports both ethernet and infiniband, but it >> is located in the ethernet drivers - the ethernet support should >> default to 'yes'. > > I don't have that ca

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread Nikolay Aleksandrov
On 21/04/17 22:36, David Miller wrote: > From: Nikolay Aleksandrov > Date: Fri, 21 Apr 2017 21:30:42 +0300 > >> On 21/04/17 20:42, Nikolay Aleksandrov wrote: >>> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused >>> because we call unregister_netdevice_many for a device tha

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread David Miller
From: Ian Kumlien Date: Fri, 21 Apr 2017 21:45:00 +0200 > The mellanox driver supports both ethernet and infiniband, but it > is located in the ethernet drivers - the ethernet support should > default to 'yes'. I don't have that card and I therefore perhaps don't want that driver in my builds.

Re: net: cleanup_net is slow

2017-04-21 Thread Florian Westphal
Florian Westphal wrote: > Indeed. Setting net.netfilter.nf_conntrack_default_on=0 cuts time > cleanup time by 2/3 ... > > nf unregister is way too happy to issue synchronize_net(), I'll work on > a fix. I'll test this patch as a start. Maybe we can also leverage exit_batch more on netfilter si

Re: net: cleanup_net is slow

2017-04-21 Thread Dmitry Vyukov
On Fri, Apr 21, 2017 at 7:57 PM, Eric Dumazet wrote: > On Fri, Apr 21, 2017 at 10:50 AM, Andrey Konovalov > wrote: >> Hi! >> >> We're investigating some approaches to improve isolation of syzkaller >> programs. One of the ideas is run each program in it's own user/net >> namespace. However, while

Re: [PATCH v2] netpoll: Check for skb->queue_mapping

2017-04-21 Thread David Miller
From: Tushar Dave Date: Thu, 20 Apr 2017 15:57:31 -0700 > Reducing real_num_tx_queues needs to be in sync with skb queue_mapping > otherwise skbs with queue_mapping greater than real_num_tx_queues > can be sent to the underlying driver and can result in kernel panic. > > One such event is runnin

[RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
Hi, For some reason I spend some hours, two days in a row, trying to debug why a newer kernel didn't work on our machines. It worked just fine with the older kernel... And there was no network interfaces to see or try to figure out what was going on with. Playing with the infiniband tools all i

Re: [PATCH RFC] sparc64: eBPF JIT

2017-04-21 Thread David Miller
From: Alexei Starovoitov Date: Fri, 21 Apr 2017 12:26:21 -0700 > It should pick up local headers without touching /usr/include. > In the past I used to do 'make headers_install' before doing a build > in samples/bpf or selftests, but then suddenly it started working > without that step, so I figu

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread David Miller
From: Cong Wang Date: Fri, 21 Apr 2017 11:55:04 -0700 > On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds > wrote: >> On Fri, Apr 21, 2017 at 5:48 AM, Andrey Konovalov >> wrote: >>> >>> I've got the following error report while fuzzing the kernel with syzkaller. >>> >>> [ cut here ]

Re: [PATCH net-next 1/5] nfp: make use of the DMA_ATTR_SKIP_CPU_SYNC attr

2017-04-21 Thread David Miller
From: Alexander Duyck Date: Fri, 21 Apr 2017 08:07:45 -0700 > On Fri, Apr 21, 2017 at 7:20 AM, Jakub Kicinski > wrote: >> DMA unmap may destroy changes CPU made to the buffer. To make XDP >> run correctly on non-x86 platforms we should use the >> DMA_ATTR_SKIP_CPU_SYNC attribute. >> >> Thanks t

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread David Miller
From: Linus Torvalds Date: Fri, 21 Apr 2017 10:42:48 -0700 > Over to Eric and networking people. This oops is user-triggerable, and > leaves the machine in a bad state (the original BUG_ON() and the new > GP fault both happen while holding the RTNL, so networking is not > healthy afterwards. I h

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 21 Apr 2017 21:30:42 +0300 > On 21/04/17 20:42, Nikolay Aleksandrov wrote: >> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused >> because we call unregister_netdevice_many for a device that is already >> being destroyed. In IPv4's ipmr

Re: [PATCH net-next] net: dsa: LAN9303: add I2C dependency

2017-04-21 Thread David Miller
From: Arnd Bergmann Date: Fri, 21 Apr 2017 18:22:40 +0200 > With CONFIG_I2C=m and NET_DSA_SMSC_LAN9303=y, we run into a link error: > > drivers/base/regmap/regmap-i2c.o: In function `regmap_smbus_byte_reg_read': > regmap-i2c.c:(.text.regmap_smbus_byte_reg_read+0x18): undefined reference to > `i

Re: [Patch net] ip6mr: avoid double unregister of pim6reg device

2017-04-21 Thread Nikolay Aleksandrov
On 21/04/17 22:27, Cong Wang wrote: > If we unregister the pim6reg device via default_device_exit_batch(), > we will receive a notification and ip6mr_device_event() will > unregister it again. This causes a kernel BUG at net/core/dev.c:6813. > > Like commit 7dc00c82cbb0 ("ipv4: Fix ipmr unregister

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-21 Thread Alexei Starovoitov
On Fri, Apr 21, 2017 at 04:12:43PM +0200, Jiri Slaby wrote: > Do not use a custom macro FUNC for starts of the global functions, use > ENTRY instead. > > And while at it, annotate also ends of the functions by ENDPROC. > > Signed-off-by: Jiri Slaby > Cc: "David S. Miller" > Cc: Alexey Kuznetsov

Re: [GIT] [4.12] NFC update

2017-04-21 Thread David Miller
From: Samuel Ortiz Date: Thu, 20 Apr 2017 23:37:07 +0200 > This is the NFC pull request for 4.12. We have: Pulled, thanks Samuel.

Re: net: cleanup_net is slow

2017-04-21 Thread Florian Westphal
Eric Dumazet wrote: > On Fri, Apr 21, 2017 at 10:50 AM, Andrey Konovalov > wrote: > > Hi! > > > > We're investigating some approaches to improve isolation of syzkaller > > programs. One of the ideas is run each program in it's own user/net > > namespace. However, while I was experimenting with th

Re: [PATCHv2 next] bonding: fix wq initialization for links created via netlink

2017-04-21 Thread David Miller
From: Mahesh Bandewar Date: Thu, 20 Apr 2017 12:49:24 -0700 > From: Mahesh Bandewar > > Earlier patch 4493b81bea ("bonding: initialize work-queues during > creation of bond") moved the work-queue initialization from bond_open() > to bond_create(). However this caused the link those are created

Re: [PATCH] Fix values type used in test_maps

2017-04-21 Thread David Miller
From: Daniel Borkmann Date: Thu, 20 Apr 2017 23:24:53 +0200 > On 04/20/2017 09:20 PM, David Miller wrote: >> >> Maps of per-cpu type have their value element size adjusted to 8 if it >> is specified smaller during various map operations. >> >> This makes test_maps as a 32-bit binary fail, in fact

[Patch net] ip6mr: avoid double unregister of pim6reg device

2017-04-21 Thread Cong Wang
If we unregister the pim6reg device via default_device_exit_batch(), we will receive a notification and ip6mr_device_event() will unregister it again. This causes a kernel BUG at net/core/dev.c:6813. Like commit 7dc00c82cbb0 ("ipv4: Fix ipmr unregister device oops") we should avoid double-unregist

Re: [PATCH RFC] sparc64: eBPF JIT

2017-04-21 Thread Alexei Starovoitov
On Fri, Apr 21, 2017 at 03:02:26PM -0400, David Miller wrote: > From: Alexei Starovoitov > Date: Fri, 21 Apr 2017 11:49:37 -0700 > > > On Fri, Apr 21, 2017 at 12:46:40PM -0400, David Miller wrote: > >> From: Daniel Borkmann > >> Date: Mon, 17 Apr 2017 20:44:35 +0200 > >> > >> > There is samples

Re: [PATCH net] bpf, doc: update bpf maintainers entry

2017-04-21 Thread David Miller
From: Daniel Borkmann Date: Thu, 20 Apr 2017 17:27:58 +0200 > Add various related files that have been missing under > BPF entry covering essential parts of its infrastructure > and also add myself as co-maintainer. > > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Applied, th

Re: macvlan: Fix device ref leak when purging bc_queue

2017-04-21 Thread महेश बंडेवार
On Fri, Apr 21, 2017 at 7:40 AM, wrote: > That's not true. macvlan_dellink() unregisters the queue, and > macvlan_process_broadcast() will never get called. Please note that I'm not > speculating. I have traced enabled on the dev_put and dev_hold, and I'm > reporting a real, reproducible issue

Re: [PATCH net-next v6 3/3] net sched actions: add time filter for action dumping

2017-04-21 Thread Jamal Hadi Salim
On 17-04-21 09:13 AM, Jiri Pirko wrote: Fri, Apr 21, 2017 at 12:55:32PM CEST, j...@mojatatu.com wrote: From: Jamal Hadi Salim @@ -1000,6 +1008,7 @@ static int tcf_action_add(struct net *net, struct nlattr *nla, static const struct nla_policy tcaa_policy[TCA_ROOT_MAX + 1] = { [TCA_

Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-21 Thread David Miller
From: Alexander Kochetkov Date: Thu, 20 Apr 2017 16:29:34 +0300 > Currently driver use phy_start_aneg() in arc_emac_open() to bring > up PHY. But phy_start() function is more appropriate for this purposes. > Besides that it call phy_start_aneg() as part of PHY startup sequence > it also can corre

[PATCH net-next v2 5/5] nfp: remove the refresh of all ports optimization

2017-04-21 Thread Jakub Kicinski
The code refreshing the eth port state was trying to update state of all ports of the card. Unfortunately to safely walk the port list we would have to hold the port lock, which we can't due to lock ordering constraints against rtnl. Make the per-port sync refresh and async refresh of all ports c

[PATCH net-next v2 1/5] nfp: make use of the DMA_ATTR_SKIP_CPU_SYNC attribute

2017-04-21 Thread Jakub Kicinski
DMA unmap may destroy changes CPU made to the buffer. To make XDP run correctly on non-x86 platforms we should use the DMA_ATTR_SKIP_CPU_SYNC attribute. Thanks to using the attribute we can now push the sync operation to the common code path from XDP handler. A little bit of variable name reshuf

[PATCH net-next v2 2/5] nfp: parse metadata prepend before XDP runs

2017-04-21 Thread Jakub Kicinski
Calling memcpy to shift metadata out of the way for XDP to run seems like an overkill. The most common metadata contents are 8 bytes containing type and flow hash. Simply parse the metadata before we run XDP. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h

[PATCH net-next v2 3/5] nfp: add NSP routine to get static information

2017-04-21 Thread Jakub Kicinski
From: David Brunecz Retrieve identifying information from the NSP. For now it only contains versions of firmware subcomponents. Signed-off-by: David Brunecz Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/nfp_mai

[PATCH net-next v2 4/5] nfp: fix free list buffer size reporting

2017-04-21 Thread Jakub Kicinski
XDP headroom should not be included in free list buffer size. Fixes: 6fe0c3b43804 ("nfp: add support for xdp_adjust_head()") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[PATCH net-next v2 0/5] nfp: DMA flags, adjust head and fixes

2017-04-21 Thread Jakub Kicinski
Hi! This series takes advantage of Alex's DMA_ATTR_SKIP_CPU_SYNC to make XDP packet modifications "correct" from DMA API point of view. It also allows us to parse the metadata before we run XDP at no additional DMA sync cost. That way we can get rid of the metadata memcpy, and remove the last

[PATCH net-next 2/3] packet: add PACKET_FANOUT_FLAG_UNIQUEID to assign new fanout group id.

2017-04-21 Thread Willem de Bruijn
From: Mike Maloney Fanout uses a per net global namespace. A process that intends to create a new fanout group can accidentally join an existing group. It is not possible to detect this. Add socket option PACKET_FANOUT_FLAG_UNIQUEID. When specified the supplied fanout group id must be set to 0,

Re: [PATCH net-next v6 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-21 Thread Jamal Hadi Salim
On 17-04-21 11:20 AM, Eric Dumazet wrote: On Fri, 2017-04-21 at 11:12 -0400, Jamal Hadi Salim wrote: On 17-04-21 09:12 AM, Jiri Pirko wrote: Fri, Apr 21, 2017 at 12:55:31PM CEST, j...@mojatatu.com wrote: From: Jamal Hadi Salim Jiri, there is a balance between extensibility and performanc

Re: [PATCH net-next 0/2] ip_tunnel: Allow policy-based routing through tunnels

2017-04-21 Thread David Miller
From: Craig Gallek Date: Wed, 19 Apr 2017 12:30:52 -0400 > iproute2 changes to follow. Example usage: > ip link add gre-test type gre local 10.0.0.1 remote 10.0.0.2 fwmark 0x4 > ip -detail link show gre-test > ... > ip link set gre-test type gre fwmark 0 Looks good, series applied, than

Re: pull request (net-next): ipsec-next 2017-04-20

2017-04-21 Thread David Miller
From: Steffen Klassert Date: Thu, 20 Apr 2017 10:54:59 +0200 > This adds the basic infrastructure for IPsec hardware > offloading, it creates a configuration API and adjusts > the packet path. ... Looks great, pulled, thanks Steffen.

Re: [PATCH net] ipv6: sr: fix double free of skb after handling invalid SRH

2017-04-21 Thread David Miller
From: David Lebrun Date: Wed, 19 Apr 2017 16:10:19 +0200 > The icmpv6_param_prob() function already does a kfree_skb(), > this patch removes the duplicate one. > > Fixes: 1ababeba4a21f3dba3da3523c670b207fb2feb62 ("ipv6: implement dataplane > support for rthdr type 4 (Segment Routing Header)") >

Re: [PATCH net-next v6 2/3] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-21 Thread Eric Dumazet
On Fri, 2017-04-21 at 11:12 -0400, Jamal Hadi Salim wrote: > On 17-04-21 09:12 AM, Jiri Pirko wrote: > > Fri, Apr 21, 2017 at 12:55:31PM CEST, j...@mojatatu.com wrote: > >> From: Jamal Hadi Salim > > >> +#define TCA_FLAG_LARGE_DUMP_ON(1 << 0) > > > > This is u32 "flags" that could not

Re: [PATCH net-next v2 2/5] virtio-net: transmit napi

2017-04-21 Thread Willem de Bruijn
>>> Maybe I was wrong, but according to Michael's comment it looks like he >>> want >>> check affinity_hint_set just for speculative tx polling on rx napi >>> instead >>> of disabling it at all. >>> >>> And I'm not convinced this is really needed, driver only provide affinity >>> hint instead of af

Re: [PATCH net] MAINTAINERS: Add new IPsec offloading files.

2017-04-21 Thread David Miller
From: Steffen Klassert Date: Thu, 20 Apr 2017 10:36:32 +0200 > This adds two new files to IPsec maintenance scope: > > net/ipv4/esp4_offload.c > net/ipv6/ip6_offload.c > > Signed-off-by: Steffen Klassert Applied, thanks.

[PATCH net-next 3/3] selftests/net: add tests for PACKET_FANOUT_FLAG_UNIQUEID

2017-04-21 Thread Willem de Bruijn
From: Mike Maloney Create two groups with PACKET_FANOUT_FLAG_UNIQUEID, add a socket to one. Ensure that the groups can only be joined if all options are consistent with the original except for this flag. Signed-off-by: Mike Maloney Acked-by: Willem de Bruijn --- tools/testing/selftests/net/p

Re: [PATCH net-next] Replace 2 jiffies with sysctl netdev_budget_usecs to enable softirq tuning

2017-04-21 Thread David Miller
From: Matthew Whitehead Date: Wed, 19 Apr 2017 12:37:10 -0400 > Constants used for tuning are generally a bad idea, especially as hardware > changes over time. Replace the constant 2 jiffies with sysctl variable > netdev_budget_usecs to enable sysadmins to tune the softirq processing. > Also docu

new documentation: IP_TRANSPARENT, is it correct?

2017-04-21 Thread bert hubert
Hi everyone, 10 years after lartc.org I decided to document a little bit more of Linux networking, and I hope I got it right. This email asks for your help in making sure. Recently I attempted to use IP_TRANSPARENT as outlined in https://www.kernel.org/doc/Documentation/networking/tproxy.txt but

Re: [PATCH RFC] sparc64: eBPF JIT

2017-04-21 Thread David Miller
From: Alexei Starovoitov Date: Fri, 21 Apr 2017 11:49:37 -0700 > On Fri, Apr 21, 2017 at 12:46:40PM -0400, David Miller wrote: >> From: Daniel Borkmann >> Date: Mon, 17 Apr 2017 20:44:35 +0200 >> >> > There is samples/bpf/sockex3_kern.c, which exercises it. To >> > run it, it would be (clang/ll

[PATCH net-next 1/3] selftests/net: cleanup unused parameter in psock_fanout

2017-04-21 Thread Willem de Bruijn
From: Mike Maloney sock_fanout_open no longer sets the size of packet_socket ring, so stop passing the parameter. Signed-off-by: Mike Maloney Acked-by: Willem de Bruijn --- tools/testing/selftests/net/psock_fanout.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) di

  1   2   3   >