Re: [net-next 03/11] ixgbe: add support for XDP_TX action

On Sat, 22 Apr 2017 20:40:22 -0700, John Fastabend wrote: > >> @@ -9557,7 +9739,21 @@ static int ixgbe_xdp_setup(struct net_device *dev, > >> struct bpf_prog *prog) > >>return -EINVAL; > >>} > >> > >> + if (nr_cpu_ids > MAX_XDP_QUEUES) > >> + return -ENOMEM; >

Re: [net-next 00/11][pull request] 10GbE Intel Wired LAN Driver Updates 2017-04-20

On 17-04-21 11:18 AM, David Miller wrote: > From: Jeff Kirsher > Date: Thu, 20 Apr 2017 18:50:18 -0700 > >> John adds XDP support (yeah!) for ixgbe. > > As excited and eager as I am about this, I want to see the build regression > for PAGE_SIZE>=8192 fixed before I

Re: [net-next 03/11] ixgbe: add support for XDP_TX action

On 17-04-22 07:24 PM, Jakub Kicinski wrote: > On Thu, 20 Apr 2017 18:50:21 -0700, Jeff Kirsher wrote: >> +static int ixgbe_xdp_queues(struct ixgbe_adapter *adapter) >> +{ >> +if (nr_cpu_ids > MAX_XDP_QUEUES) >> +return 0; >> + >> +return adapter->xdp_prog ? nr_cpu_ids : 0; >>

[PATCH net-next v3 5/5] nfp: remove the refresh of all ports optimization

The code refreshing the eth port state was trying to update state of all ports of the card. Unfortunately to safely walk the port list we would have to hold the port lock, which we can't due to lock ordering constraints against rtnl. Make the per-port sync refresh and async refresh of all ports

[PATCH net-next v3 4/5] nfp: fix free list buffer size reporting

XDP headroom should not be included in free list buffer size. Fixes: 6fe0c3b43804 ("nfp: add support for xdp_adjust_head()") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH net-next v3 3/5] nfp: add NSP routine to get static information

From: David Brunecz Retrieve identifying information from the NSP. For now it only contains versions of firmware subcomponents. Signed-off-by: David Brunecz Signed-off-by: Jakub Kicinski ---

[PATCH net-next v3 0/5] nfp: DMA flags, adjust head and fixes

Hi! This series takes advantage of Alex's DMA_ATTR_SKIP_CPU_SYNC to make XDP packet modifications "correct" from DMA API point of view. It also allows us to parse the metadata before we run XDP at no additional DMA sync cost. That way we can get rid of the metadata memcpy, and remove the

[PATCH net-next v3 1/5] nfp: make use of the DMA_ATTR_SKIP_CPU_SYNC attr

DMA unmap may destroy changes CPU made to the buffer. To make XDP run correctly on non-x86 platforms we should use the DMA_ATTR_SKIP_CPU_SYNC attribute. Thanks to using the attribute we can now push the sync operation to the common code path from XDP handler. A little bit of variable name

[PATCH net-next v3 2/5] nfp: parse metadata prepend before XDP runs

Calling memcpy to shift metadata out of the way for XDP to run seems like an overkill. The most common metadata contents are 8 bytes containing type and flow hash. Simply parse the metadata before we run XDP. Signed-off-by: Jakub Kicinski ---

Re: [PATCH v2 net] net: ipv6: regenerate host route if moved to gc list

On Sat, Apr 22, 2017 at 07:12:34PM -0600, David Ahern wrote: > On 4/22/17 4:00 PM, Martin KaFai Lau wrote: > > On Sat, Apr 22, 2017 at 09:40:37AM -0700, David Ahern wrote: > > [...] > >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > >> index 08f9e8ea7a81..97e86158bbcb 100644 > >> ---

Re: [net-next 03/11] ixgbe: add support for XDP_TX action

On Thu, 20 Apr 2017 18:50:21 -0700, Jeff Kirsher wrote: > +static int ixgbe_xdp_queues(struct ixgbe_adapter *adapter) > +{ > + if (nr_cpu_ids > MAX_XDP_QUEUES) > + return 0; > + > + return adapter->xdp_prog ? nr_cpu_ids : 0; > +} Nit: AFAICT ixgbe_xdp_setup() will guarantee

Re: [PATCH v2 net] net: ipv6: regenerate host route if moved to gc list

On 4/22/17 4:00 PM, Martin KaFai Lau wrote: > On Sat, Apr 22, 2017 at 09:40:37AM -0700, David Ahern wrote: > [...] >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >> index 08f9e8ea7a81..97e86158bbcb 100644 >> --- a/net/ipv6/addrconf.c >> +++ b/net/ipv6/addrconf.c >> @@ -3303,14 +3303,24

Re: [PATCH v2 net] net: ipv6: regenerate host route if moved to gc list

On Sat, Apr 22, 2017 at 09:40:37AM -0700, David Ahern wrote: [...] > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 08f9e8ea7a81..97e86158bbcb 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -3303,14 +3303,24 @@ static void addrconf_gre_config(struct net_device

[PATCH net-next 2/2] cls_flower: add support for matching MPLS fields (v2)

Add support to the tc flower classifier to match based on fields in MPLS labels (TTL, Bottom of Stack, TC field, Label). Signed-off-by: Benjamin LaHaise Signed-off-by: Benjamin LaHaise Reviewed-by: Jakub Kicinski Cc:

[PATCH net-next 0/2] flower: add MPLS matching support

From: Benjamin LaHaise This patch series adds support for parsing MPLS flows in the flow dissector and the flower classifier. Each of the MPLS TTL, BOS, TC and Label fields can be used for matching. v2: incorporate style feedback, move #defines to linux/include/mpls.h Note:

[PATCH net-next 1/2] flow_dissector: add mpls support (v2)

Add support for parsing MPLS flows to the flow dissector in preparation for adding MPLS match support to cls_flower. Signed-off-by: Benjamin LaHaise Signed-off-by: Benjamin LaHaise Reviewed-by: Jakub Kicinski Cc:

Re: [PATCH] bpf: Add sparc support to tools and samples.

On 04/22/2017 10:02 PM, David Miller wrote: From: Daniel Borkmann Date: Sat, 22 Apr 2017 21:46:46 +0200 On 04/22/2017 09:38 PM, David Miller wrote: Signed-off-by: David S. Miller LGTM, thanks! Acked-by: Daniel Borkmann

Re: compile issue in latest iproute2

On 17-04-22 12:54 PM, Stephen Hemminger wrote: On Sat, 22 Apr 2017 12:43:50 -0400 Jamal Hadi Salim wrote: On 17-04-22 12:18 PM, Daniel Borkmann wrote: [..] Anything I'm missing? Let me get back to that machine (couple of hours) and try to see how i created the issue.

Re: [PATCH] bpf: Add sparc support to tools and samples.

From: Daniel Borkmann Date: Sat, 22 Apr 2017 21:46:46 +0200 > On 04/22/2017 09:38 PM, David Miller wrote: >> >> Signed-off-by: David S. Miller > > LGTM, thanks! > > Acked-by: Daniel Borkmann Great, this and the sparc64 eBPF

Re: [PATCH] bpf: Add sparc support to tools and samples.

On 04/22/2017 09:38 PM, David Miller wrote: Signed-off-by: David S. Miller LGTM, thanks! Acked-by: Daniel Borkmann

tools/testing/selftests/bpf/Makefile

Alexei, that unconditional -D__x86_64__ isn't going to work. It in fact makes the build break on sparc because the types.h asm headers explicitly check for things like __sparc__ && __arch64__ etc. There are other places that want stuff like this, so let's do it right. In every

[PATCH] bpf: Add sparc support to tools and samples.

Signed-off-by: David S. Miller --- samples/bpf/bpf_helpers.h | 19 +++ tools/build/feature/test-bpf.c | 3 +++ tools/lib/bpf/bpf.c| 2 ++ 3 files changed, 24 insertions(+) diff --git a/samples/bpf/bpf_helpers.h b/samples/bpf/bpf_helpers.h

Re: [PATCH v2] net: natsemi: ns83820: add checks for dma mapping error

Alexey Khoroshilov : [...] > diff --git a/drivers/net/ethernet/natsemi/ns83820.c > b/drivers/net/ethernet/natsemi/ns83820.c > index 729095db3e08..dfc64e1e31f9 100644 > --- a/drivers/net/ethernet/natsemi/ns83820.c > +++ b/drivers/net/ethernet/natsemi/ns83820.c [...] > @@

[net-next 3/5] net/mlx5: E-Switch, Add control for encapsulation

From: Roi Dayan Implement the devlink e-switch encapsulation control set and get callbacks. Apply the value set by the user on the switchdev offloads mode when creating the fast FDB table where offloaded rules will be set. Signed-off-by: Roi Dayan

[net-next 2/5] net/mlx5: E-Switch, Refactor fast path FDB table creation in switchdev mode

From: Or Gerlitz Refactor the creation of the fast path FDB table that holds the offloaded rules in SRIOV switchdev mode into it's own function. This will be used in the next patch to be able and re-create the table under different settings without going through legacy

[pull request][net-next 0/5] Mellanox, mlx5 updates 2017-04-22

Hi Dave, This series contains some updates to mlx5 driver. Sparse and compiler warnings fixes from Stephen Hemminger. >From Roi Dayan and Or Gerlitz, Add devlink and mlx5 support for controlling E-Switch encapsulation mode, this knob will enable HW support for applying

[net-next 4/5] mlx5: hide unused functions

From: Stephen Hemminger Fix sparse warnings in recent ipoib support. The RDMA functions are not used yet, hide behind #ifdef. Based on comment, they will eventually be local so make static. Signed-off-by: Stephen Hemminger Signed-off-by:

[net-next 5/5] mlx5: fix warning about missing prototype

From: Stephen Hemminger Fix sparse warning about missing prototypes. The rx/tx code path defines functions with prototypes in ipoib.h. Signed-off-by: Stephen Hemminger Signed-off-by: Saeed Mahameed ---

[net-next 1/5] net/devlink: Add E-Switch encapsulation control

From: Roi Dayan This is an e-switch global knob to enable HW support for applying encapsulation/decapsulation to VF traffic as part of SRIOV e-switch offloading. The actual encap/decap is carried out (along with the matching and other actions) per offloaded e-switch rules,

Re: [PATCH 2/2] sparc64: Add eBPF JIT.

From: Alexei Starovoitov Date: Sat, 22 Apr 2017 08:32:35 -0700 > On Fri, Apr 21, 2017 at 08:17:11PM -0700, David Miller wrote: >> >> This is an eBPF JIT for sparc64. All major features are supported. >> >> All tests under tools/testing/selftests/bpf/ pass. >> >>

Re: [PATCH] rtl_bt: Update firmware for BT part of rtl8822be

On Fri, Apr 14, 2017 at 12:55:52AM -0500, Larry Finger wrote: > These files were supplied by Realtek. > > Signed-off-by: Larry Finger Applied, thanks Larry. --Kyle

Re: [PATCH] net: can: usb: gs_usb: Fix buffer on stack

On Sat, Apr 22, 2017 at 1:56 PM, Maksim Salau wrote: > Allocate buffer on HEAP instead of STACK for a local structure > that is to be sent using usb_control_msg(). > > Signed-off-by: Maksim Salau > --- > drivers/net/can/usb/gs_usb.c | 17

Re: PROBLEM: IPVS incorrectly reverse-NATs traffic to LVS host

Hello, On Wed, 12 Apr 2017, Nick Moriarty wrote: > Hi, > > I've experienced a problem in how traffic returning to an LVS host is > handled in certain circumstances. Please find a bug report below - if > there's any further information you'd like, please let me know. > > [1.] One line

[PATCH] net: wireless: orinoco: usb: Fix buffer on stack

Allocate buffer on HEAP instead of STACK for a local variable that is to be sent using usb_control_msg(). Signed-off-by: Maksim Salau --- drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-)

[PATCH] net: can: usb: gs_usb: Fix buffer on stack

Allocate buffer on HEAP instead of STACK for a local structure that is to be sent using usb_control_msg(). Signed-off-by: Maksim Salau --- drivers/net/can/usb/gs_usb.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git

Re: compile issue in latest iproute2

On Sat, 22 Apr 2017 12:43:50 -0400 Jamal Hadi Salim wrote: > On 17-04-22 12:18 PM, Daniel Borkmann wrote: > [..] > > > > Anything I'm missing? > > > Let me get back to that machine (couple of hours) and try to see how i > created the issue. > Shouldve cutnpasted the error

Fw: [Bug 195495] New: unchecked return value of nla_nest_start() in function lwtunnel_fill_encap()

Begin forwarded message: Date: Sat, 22 Apr 2017 14:49:46 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 195495] New: unchecked return value of nla_nest_start() in function lwtunnel_fill_encap() https://bugzilla.kernel.org/show_bug.cgi?id=195495

Fw: [Bug 195503] New: tipc: unchecked return value of nlmsg_new() in function tipc_nl_node_get_monitor()

Begin forwarded message: Date: Sat, 22 Apr 2017 14:56:25 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 195503] New: tipc: unchecked return value of nlmsg_new() in function tipc_nl_node_get_monitor()

Fw: [Bug 195497] New: openvswitch: unchecked return value of nla_nest_start() in function queue_userspace_packet()

Begin forwarded message: Date: Sat, 22 Apr 2017 14:52:46 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 195497] New: openvswitch: unchecked return value of nla_nest_start() in function queue_userspace_packet()

Re: compile issue in latest iproute2

On 17-04-22 12:18 PM, Daniel Borkmann wrote: [..] Anything I'm missing? Let me get back to that machine (couple of hours) and try to see how i created the issue. Shouldve cutnpasted the error msg. Cant create it on this laptop. cheers, jamal

[PATCH v2 net] net: ipv6: regenerate host route if moved to gc list

Taking down the loopback device wreaks havoc on IPv6 routes. By extension, taking a VRF device wreaks havoc on its table. Dmitry and Andrey both reported heap out-of-bounds reports in the IPv6 FIB code while running syzkaller fuzzer. The root cause is a dead dst that is on the garbage list gets

[PATCH net-next] net: add rcu locking when changing early demux

systemd-sysctl is triggering a suspicious RCU usage message when net.ipv4.tcp_early_demux or net.ipv4.udp_early_demux is changed via a sysctl config file: [ 33.896184] === [ 33.899558] [ ERR: suspicious RCU usage. ] [ 33.900624] 4.11.0-rc7+ #104 Not tainted [

Re: compile issue in latest iproute2

On 04/22/2017 05:00 PM, Daniel Borkmann wrote: On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote: I dont think is a kernel uapi - but it was failing compiling when HAVE_ELF is false. - jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h diff --git a/include/bpf_util.h

[PATCH v2 net-next] net: ipv6: send unsolicited NA if enabled for all interfaces

When arp_notify is set to 1 for either a specific interface or for 'all' interfaces, gratuitous arp requests are sent. Since ndisc_notify is the ipv6 equivalent to arp_notify, it should follow the same semantics. Commit 4a6e3c5def13 ("net: ipv6: send unsolicited NA on admin up") sends the NA on

Re: Why max netlink msg size is limited to 16k

On Sat, 2017-04-22 at 19:43 +0530, prashantkumar dhotre wrote: > I am observing that max netlink msg that my kernel module can send to > user app is close to 16K. > > For larger sizes, genlmsg_unicast() succeeds but my app does not receive data. > > I have tried increasing RECV buffer size in my

Re: [PATCH 2/2] sparc64: Add eBPF JIT.

On Fri, Apr 21, 2017 at 08:17:11PM -0700, David Miller wrote: > > This is an eBPF JIT for sparc64. All major features are supported. > > All tests under tools/testing/selftests/bpf/ pass. > > Signed-off-by: David S. Miller ... > + /* tail call */ > + case BPF_JMP

Re: compile issue in latest iproute2

On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote: I dont think is a kernel uapi - but it was failing compiling when HAVE_ELF is false. - jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h diff --git a/include/bpf_util.h b/include/bpf_util.h index 5361dab..edca339

Re: [PATCH net] net: ipv6: regenerate host route if moved to gc list

On 4/22/17 3:14 AM, Dmitry Vyukov wrote: >> One small question. Why cmpxchg is needed instead >> of a ip6_rt_put() and then assign? >> Is it fixing another bug? > cmpxchg here looks fishy. > If there are no concurrent modifications, then it is not needed. > If there are and cmpxchg fails, then we

Why max netlink msg size is limited to 16k

I am observing that max netlink msg that my kernel module can send to user app is close to 16K. For larger sizes, genlmsg_unicast() succeeds but my app does not receive data. I have tried increasing RECV buffer size in my user app but that does not help. Regards

[PATCH] orinoco: fix spelling mistake: "Registerred" -> "Registered"

From: Colin Ian King trivial fix to spelling mistake in dbg_dbg message Signed-off-by: Colin Ian King --- drivers/net/wireless/intersil/orinoco/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

pull request: bluetooth-next 2017-04-22

Hi Dave, Here are some more Bluetooth patches (and one 802.15.4 patch) in the bluetooth-next tree targeting the 4.12 kernel. Most of them are pure fixes. Please let me know if there are any issues pulling. Thanks. Johan --- The following changes since commit

[PATCH v2] net: natsemi: ns83820: add checks for dma mapping error

The driver does not check if mapping dma memory succeed. The patch adds the checks and failure handling. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/ethernet/natsemi/ns83820.c | 42

[PATCH iproute2 1/1] actions: Add support for user cookies

From: Jamal Hadi Salim Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved

compile issue in latest iproute2

I dont think is a kernel uapi - but it was failing compiling when HAVE_ELF is false. - jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h diff --git a/include/bpf_util.h b/include/bpf_util.h index 5361dab..edca339 100644 --- a/include/bpf_util.h +++

Re: [PATCH 4/4] [DO NOT MERGE] arm64: allwinner: a64: enable RTL8211E PHY workaround

-macro-name-for-page-select-register/20170422-144641 config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

[PATCH] net: netcp: fix spelling mistake: "memomry" -> "memory"

From: Colin Ian King Trivial fix to spelling mistake in dev_err message and rejoin line. Signed-off-by: Colin Ian King --- drivers/net/ethernet/ti/netcp_ethss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: r8169: Long link becomes ready times

Paul Menzel : [...] > The ASRock E350M1 has a Realtek ethernet controller. > > It takes almost three seconds for the link to become ready. This is > noticeable after resume from suspend, where the user wants to continue > working but first has to wait for the

Re: [PATCH 2/2] ipv6: don't deliver packets with zero length to raw sockets

On Sat, Apr 22, 2017 at 12:53 AM, David Miller wrote: > From: Jamie Bainbridge > Date: Fri, 21 Apr 2017 21:18:00 +1000 > >> I cannot see the use in delivering a skb with zero bytes after the >> network header to a raw socket. > > Then it cannot be used

Re: [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-21 02:11 PM, Jamal Hadi Salim wrote: Please bear with me. I want to make sure to get this right. Lets say I updated the kernel today to reject transactions with bits it didnt understand. Lets call this "old kernel". A tc that understands/sets these bits and nothing else. Call it "old

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

Hello, On Thu, 20 Apr 2017, Paolo Abeni wrote: > When creating a new ipvs service, ipv6 addresses are always accepted > if CONFIG_IP_VS_IPV6 is enabled. On dest creation the address family > is not explicitly checked. > > This allows the user-space to configure ipvs services even if

[PATCH net] ravb: Double free on error in ravb_start_xmit()

If skb_put_padto() fails then it frees the skb. I shifted that code up a bit to make my error handling a little simpler. Fixes: a0d2f20650e8 ("Renesas Ethernet AVB PTP clock driver") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/renesas/ravb_main.c

r8169: Long link becomes ready times

Dear Linux folks, The ASRock E350M1 has a Realtek ethernet controller. It takes almost three seconds for the link to become ready. This is noticeable after resume from suspend, where the user wants to continue working but first has to wait for the network. This test is done with Linux 4.10.

Re: [RFC] change the default Kconfig value of mlx5_en

On Sat, Apr 22, 2017 at 3:07 AM, Saeed Mahameed wrote: > On Sat, Apr 22, 2017 at 3:47 AM, Ian Kumlien wrote: >> On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed >> wrote: >>> On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien

Re: [PATCH net] net: ipv6: regenerate host route if moved to gc list

On Sat, Apr 22, 2017 at 7:57 AM, Martin KaFai Lau wrote: > On Fri, Apr 21, 2017 at 04:40:30PM -0700, David Ahern wrote: >> Taking down the loopback device wreaks havoc on IPv6 routes. By >> extension, taking a VRF device wreaks havoc on its table. >> >> Dmitry and Andrey both

Re: [PATCH 3/4] net: phy: realtek: add disable RX delay hack for RTL8211E

-macro-name-for-page-select-register/20170422-144641 config: i386-randconfig-x070-201716 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drive