Re: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology

On Wed, 3 May 2017 14:44:35 +1000 Gavin Shan wrote: > +void ncsi_ethtool_register_dev(struct net_device *dev) > +{ > + struct ethtool_ops *ops; > + > + ops = (struct ethtool_ops *)(dev->ethtool_ops); > + if (!ops) > + return; > + > +

Re: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology

On Wed, 3 May 2017 14:44:35 +1000 Gavin Shan wrote: > +static int ethtool_get_ncsi_channels(struct net_device *dev, > + void __user *useraddr) Please don't use an opaque type for this. See how other ethtool operations take a struct.

[net-next] net: remove duplicate add_device_randomness() call

Since register_netdevice() already call add_device_randomness() and dev_set_mac_address() will call it after mac address change. It's not necessary to call at device UP. Signed-off-by: Zhang Shengju --- net/core/dev.c | 1 - 1 file changed, 1 deletion(-) diff

[Patch net] ipv6: initialize route null entry in addrconf_init()

Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev since it is always NULL. This is clearly wrong, we have code to initialize it to loopback_dev, unfortunately the order is still not correct. loopback_dev is registered very early during boot, we lose a chance to re-initialize it

[Patch net] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

For each netns (except init_net), we initialize its null entry in 3 places: 1) The template itself, as we use kmemdup() 2) Code around dst_init_metrics() in ip6_route_net_init() 3) ip6_route_dev_notify(), which is supposed to initialize it after loopback registers Unfortunately the last one

Re: new warning at net/wireless/util.c:1236

Linus Torvalds writes: > So my Dell XPS 13 seems to have grown a new warning as of the > networking merge yesterday. > > Things still work, but when it starts warning, it generates a *lot* of > noise (I got 36 of these within about ten minutes). > > I have no idea

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 9:55 PM, Cong Wang wrote: > Why not add a printk and play with my patch to see the difference? I have other things to do. If you believe your patch fixes the problem, send it and let Andrey verify.

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 7:43 PM, David Ahern wrote: > On 5/3/17 5:35 PM, Cong Wang wrote: >> Ah, we need: >> >> @@ -4024,7 +4027,7 @@ static struct pernet_operations ip6_route_net_late_ops >> = { >> >> static struct notifier_block ip6_route_dev_notifier = { >>

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

On 5/3/17 10:35 AM, David Miller wrote: From: Alexei Starovoitov Date: Wed, 3 May 2017 09:54:42 -0700 /usr/include/asm/types.h -> asm-generic/int-ll64.h as far as I can see that should be the same on most archs. Why doesn't it work for sparc? You can't assume anything about the

RE: FEC on i.MX 7 transmit queue timeout

From: Stefan Agner Sent: Thursday, May 04, 2017 9:22 AM >To: Andy Duan >Cc: fugang.d...@freescale.com; feste...@gmail.com; >netdev@vger.kernel.org; netdev-ow...@vger.kernel.org >Subject: Re: FEC on i.MX 7 transmit queue timeout > >Hi Andy, > >On 2017-04-20

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 5:35 PM, Cong Wang wrote: > Ah, we need: > > @@ -4024,7 +4027,7 @@ static struct pernet_operations ip6_route_net_late_ops > = { > > static struct notifier_block ip6_route_dev_notifier = { > .notifier_call = ip6_route_dev_notify, > - .priority = 0, > + .priority =

new warning at net/wireless/util.c:1236

So my Dell XPS 13 seems to have grown a new warning as of the networking merge yesterday. Things still work, but when it starts warning, it generates a *lot* of noise (I got 36 of these within about ten minutes). I have no idea what triggered it, because when I rebooted (not because of this

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote: > On 3-1-2017 18:59, Luis R. Rodriguez wrote: > > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: > >> > >> Right question is "should we solve it without user-space help"? > >> > >> Answer is no, too. Way too complex.

Re: Maximum MPLS labels on Linux network stack

On 5/3/17 2:21 PM, Joe Stringer wrote: >> • 8192 MPLS labels >> >> Especially interested in the figure 8192 MPLS Labels. The 8k labels has to be 8k individual routes with a single label (or a few labels in the stack for the route). In that case you can set net.mpls.platforms_labels to 10001 and

Re: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology

On Thu, May 04, 2017 at 02:49:33AM +0200, Andrew Lunn wrote: >> +void ncsi_ethtool_register_dev(struct net_device *dev) >> +{ >> +struct ethtool_ops *ops; >> + >> +ops = (struct ethtool_ops *)(dev->ethtool_ops); > >Why do you need the cast here? > >Ah, is it because net_device has: > >

Re: [4.9.13] use after free in ipv4_mtu

On 6 March 2017 at 21:45, Eric Dumazet wrote: > On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote: >> On 2 March 2017 at 21:28, Eric Dumazet wrote: >> > On Thu, 2017-03-02 at 05:08 -0800, Eric Dumazet wrote: >> > >> >> Thanks for the report

Re: FEC on i.MX 7 transmit queue timeout

Hi Andy, On 2017-04-20 19:48, Andy Duan wrote: > On 2017年04月20日 07:15, Stefan Agner wrote: >> I tested again with imx6sx-fec compatible string. I could reproduce it >> on a Colibri with i.MX 7Dual. But not always: It really depends whether >> queue 2 is counting up or not. Just after boot, I

Re: [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics

On Thu, May 04, 2017 at 02:34:52AM +0200, Andrew Lunn wrote: >On Thu, May 04, 2017 at 10:05:34AM +1000, Gavin Shan wrote: >> On Wed, May 03, 2017 at 09:18:23AM -0400, David Miller wrote: >> >From: Andrew Lunn >> >Date: Wed, 3 May 2017 14:47:22 +0200 >> > >> >> On Wed, May 03, 2017

Re: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology

> +void ncsi_ethtool_register_dev(struct net_device *dev) > +{ > + struct ethtool_ops *ops; > + > + ops = (struct ethtool_ops *)(dev->ethtool_ops); Why do you need the cast here? Ah, is it because net_device has: const struct ethtool_ops *ethtool_ops; i.e. you are casting off

Re: [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics

On Wed, May 03, 2017 at 08:16:43PM -0400, David Miller wrote: >From: Gavin Shan >Date: Thu, 4 May 2017 10:05:34 +1000 >> On Wed, May 03, 2017 at 09:18:23AM -0400, David Miller wrote: >>>From: Andrew Lunn >>>Date: Wed, 3 May 2017 14:47:22 +0200 >>>

Re: [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics

On Thu, May 04, 2017 at 10:05:34AM +1000, Gavin Shan wrote: > On Wed, May 03, 2017 at 09:18:23AM -0400, David Miller wrote: > >From: Andrew Lunn > >Date: Wed, 3 May 2017 14:47:22 +0200 > > > >> On Wed, May 03, 2017 at 02:44:37PM +1000, Gavin Shan wrote: > >>> This adds ethtool

Re: [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics

From: Gavin Shan Date: Thu, 4 May 2017 10:05:34 +1000 > On Wed, May 03, 2017 at 09:18:23AM -0400, David Miller wrote: >>From: Andrew Lunn >>Date: Wed, 3 May 2017 14:47:22 +0200 >> >>> On Wed, May 03, 2017 at 02:44:37PM +1000, Gavin Shan wrote:

Re: [PATCH v4 net-next 00/10] net/ncsi: Add debugging functionality

On Wed, May 03, 2017 at 02:58:02PM +0200, Andrew Lunn wrote: >On Wed, May 03, 2017 at 02:44:31PM +1000, Gavin Shan wrote: >> This series supports NCSI debugging infrastructure by adding several >> ethtool commands and one debugfs file. It was inspired by the reported >> issues: No available

Re: [PATCH v4 net-next 00/10] net/ncsi: Add debugging functionality

On Wed, May 03, 2017 at 01:25:18AM -0400, David Miller wrote: > >Sorry, the net-next tree is closed right now as we are in the merge >window. > >Please resubmit this when the net-next tree opens back up. > >Thank you. > Sorry that I didn't catch the merge window. Thanks for the tip. I'll resubmit

Re: [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics

On Wed, May 03, 2017 at 09:18:23AM -0400, David Miller wrote: >From: Andrew Lunn >Date: Wed, 3 May 2017 14:47:22 +0200 > >> On Wed, May 03, 2017 at 02:44:37PM +1000, Gavin Shan wrote: >>> This adds ethtool command (ETHTOOL_GNCSISTATS) to retrieve the >>> NCSI hardware statistics.

[PATCH net] netvsc: make sure napi enabled before vmbus_open

This fixes a race where vmbus callback for new packet arriving could occur before NAPI is initialized. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 8 +--- drivers/net/hyperv/rndis_filter.c | 2 +- 2 files changed, 6 insertions(+), 4

[RFC] iproute: Add support for extended ack to rtnl_talk

Add support for extended ack error reporting via libmnl. This is a better alternative to use existing library and not copy/paste code from the kernel. Also make arguments const where possible. Add a new function rtnl_talk_extack that takes a callback as an input arg. If a netlink response

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 3:09 PM, David Ahern wrote: > On 5/3/17 4:02 PM, Cong Wang wrote: >> On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: >>> On 5/3/17 11:02 AM, Cong Wang wrote: A quick glance shows we need to simply check local->rt6i_idev

Re: [PATCH net-next 00/15] netvsc: misc patches

From: Stephen Hemminger Date: Wed, 3 May 2017 16:01:02 -0700 > Mostly these are performance related. There is also one bug fix for > incorrect handling of NAPI on device removal Stephen, the net-next tree is closed as we are in the merge window. Please resubmit

[PATCH net-next 14/15] netvsc: optimize receive completions

Handle receive completions better: * format message directly in ring rather than in different bookkeeping structure * eliminate atomic operation * get rid of modulus (divide) on ring wrap * avoid potential stall if ring gets full * don't make ring element opaque Signed-off-by: Stephen

[PATCH net-next 13/15] netvsc: convert open count from atomic to refcount

Refcount provides wraparond protection. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc.c | 3 ++- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH net-next 10/15] netvsc: replace modulus with mask for alignment

Since packet alignment (pkt_align) is always a power of 2, it is safe to replace expensive divide with shift. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc.c

[PATCH 15/15] netvsc: use vzalloc_node for receive completion data

Put the receive completion ring on the NUMA node of the CPU assigned to the channel. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 3 +++ drivers/net/hyperv/netvsc.c | 30 +++--- drivers/net/hyperv/rndis_filter.c

[PATCH net-next 12/15] netvsc: size receive completion ring based on receive area

Now that receive area is parameterized, also need to adjust the size of the ring for receive completions based on receive area. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 4 +--- drivers/net/hyperv/netvsc.c | 22 ++

[PATCH net-next 11/15] netvsc: reduce unnecessary memset

Only part of the headroom maybe used on typical packet. Avoid doing memset of whole area. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c

[PATCH net-next 08/15] netvsc: allow overriding send/recv buffer size

The default value of send and receive buffer area for host DMA is much larger than it needs to be. Experimentation shows that a much smaller buffer still keeps same performance; change from 16M buffer to 4M receive and 1M send. Make the size a module parameter so that it can be adjusted as needed

[PATCH net-next 09/15] netvsc: optimize netvsc_send_pkt

Hand optimize netvsc_send_pkt by adding likely/unlikely. Also don't print pointer in warning message, instead dump info. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff

[PATCH net-next 04/15] netvsc: don't reacquire rtnl on device removal

Since rtnl_lock is already held in netvsc_remove, it is easier to just call unregister_netdevice which expects RTNL. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH net-next 05/15] netvsc: optimize avail percent calculation

Only need to look at write space (not read space) when computing percent available. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/hyperv/netvsc.c

[PATCH net-next 03/15] netvsc: make sure napi enabled before vmbus_open

This fixes a race where vmbus callback for new packet arriving could occur before NAPI is initialized. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 8 +--- drivers/net/hyperv/rndis_filter.c | 2 +- 2 files changed, 6 insertions(+), 4

[PATCH net-next 00/15] netvsc: misc patches

Mostly these are performance related. There is also one bug fix for incorrect handling of NAPI on device removal Stephen Hemminger (15): vmbus: simplify hv_ringbuffer_read vmbus: fix unnecessary signal events as result of NAPI netvsc: make sure napi enabled before vmbus_open netvsc: don't

[PATCH net-next 02/15] vmbus: fix unnecessary signal events as result of NAPI

With NAPI, the ring buffer is processed in incremental steps so the read index needs to be updated after each section. But this can lead to lots of bogus vmbus signal events which hurts performance. This patch rearranges the host incoming signalling logic to be more complete and eliminate

[PATCH net-next 06/15] netvsc: prefetch the first incoming ring element

In interrupt handler, prefetch the first incoming ring element so that it is in cache by the time NAPI poll gets to it. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 07/15] netvsc: convert ring_size to unsigned

The ring size module parameter is unsigned not integer. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 5 ++--- drivers/net/hyperv/netvsc.c | 2 +- drivers/net/hyperv/netvsc_drv.c | 8 3 files changed, 7 insertions(+), 8 deletions(-)

[PATCH net-next 01/15] vmbus: simplify hv_ringbuffer_read

With new iterator functions (and the double mapping) the ring buffer read function can be greatly simplified. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 122 +++ 1 file changed, 18 insertions(+), 104

[PATCH] rtlwifi: fix spelling mistake: "Pairwiase" -> "Pairwise"

From: Colin Ian King trivial fixes to spelling mistakes in RT_TRACE messages. Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/hw.c | 2 +- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 2 +-

Fw: [Bug 195647] New: Slab corruption with network packet poison data

Begin forwarded message: Date: Wed, 03 May 2017 13:37:39 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 195647] New: Slab corruption with network packet poison data https://bugzilla.kernel.org/show_bug.cgi?id=195647 Bug ID: 195647

Re: [PATCH net] net: ipv6: Do not duplicate DAD on link up

On Wed, May 3, 2017 at 2:29 PM, David Ahern wrote: > On 5/3/17 3:22 PM, Cong Wang wrote: >>> Andrey's reproducer program runs in a very tight loop, calling >>> 'unshare -n' and then spawning 2 sets of 14 threads running random ioctl >>> calls. The relevant networking sequence:

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 4:02 PM, Cong Wang wrote: > On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: >> On 5/3/17 11:02 AM, Cong Wang wrote: >>> A quick glance shows we need to simply check local->rt6i_idev >>> since we do the same check for sprt right above. >> >> As I recall, rt6i_idev

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: > On 5/3/17 11:02 AM, Cong Wang wrote: >> A quick glance shows we need to simply check local->rt6i_idev >> since we do the same check for sprt right above. > > As I recall, rt6i_idev is set for all routes except null_entry and

Re: Maximum MPLS labels on Linux network stack

On 3 May 2017 at 14:29, Алексей Болдырев wrote: > As I understand it, it's enough to just set the variable in the source > #define FLOW_MAX_MPLS_LABELS 3 > on > #define FLOW_MAX_MPLS_LABELS 7 > Or is there somehow still pitfalls? You'll probably need to update

Re: Maximum MPLS labels on Linux network stack

As I understand it, it's enough to just set the variable in the source #define FLOW_MAX_MPLS_LABELS 3 on #define FLOW_MAX_MPLS_LABELS 7 Or is there somehow still pitfalls? 04.05.2017, 00:22, "Joe Stringer" : > On 3 May 2017 at 14:19, Алексей Болдырев >

Re: [PATCH net] net: ipv6: Do not duplicate DAD on link up

On 5/3/17 3:22 PM, Cong Wang wrote: >> Andrey's reproducer program runs in a very tight loop, calling >> 'unshare -n' and then spawning 2 sets of 14 threads running random ioctl >> calls. The relevant networking sequence: >> >> 1. New network namespace created via unshare -n >> - ip6tnl0 device is

Re: Maximum MPLS labels on Linux network stack

Is it possible to increase this limit in OpenVswitch? 03.05.2017, 23:21, "Joe Stringer" : > On 3 May 2017 at 11:14, David Ahern wrote: >>  On 5/3/17 11:33 AM, Алексей Болдырев wrote: >>>  I watched one forum, there is listed in the properties of one license for

Re: [PATCH net] net: ipv6: Do not duplicate DAD on link up

On Tue, May 2, 2017 at 2:43 PM, David Ahern wrote: > Andrey reported a warning triggered by the rcu code: > > [ cut here ] > WARNING: CPU: 1 PID: 5911 at lib/debugobjects.c:289 > debug_print_object+0x175/0x210 > ODEBUG: activate active (active state 1)

Re: Maximum MPLS labels on Linux network stack

On 3 May 2017 at 14:19, Алексей Болдырев wrote: > Is it possible to increase this limit in OpenVswitch? Yes.

Re: [PATCH v4 net-next 05/10] net/ncsi: Ethtool operation to get NCSI channel info

Hi Gavin, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Gavin-Shan/net-ncsi-Add-debugging-functionality/20170503-185932 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce

Re: [PATCH 0/9] net: thunderx: Adds XDP support

Thanks, Sunil. >with network stack: 0.32 Mpps >with XDP (XDP_TX): 3 Mpps >and XDP_DROP: 3.8 Mpps Interesting; May I ask - which packet size did you use ? Regards, Rami Rosen

Re: Maximum MPLS labels on Linux network stack

On 3 May 2017 at 11:14, David Ahern wrote: > On 5/3/17 11:33 AM, Алексей Болдырев wrote: >> I watched one forum, there is listed in the properties of one license for >> Cisco, it says: >> >> Layer 3 VPN • Multi-VRF CE (VRF-lite); requires IP Services Feature license >> • MPLS

Re: Get amount of fast retransmissions from TCP info

On Wed, May 3, 2017 at 3:47 PM, Lars Erik Storbukås wrote: > I also want to count the amount of ECN signals received. Do anyone > have any input on where to place an ECN signal count? > > Is any of these locations a logical place to increase the ECN counter > (which I've

Re: Get amount of fast retransmissions from TCP info

2017-04-25 0:20 GMT+02:00 Andreas Petlund : > >> On 24 Apr 2017, at 23:31, Lars Erik Storbukås >> wrote: >> >> 2017-04-24 23:00 GMT+02:00 Neal Cardwell : >>> On Mon, Apr 24, 2017 at 4:20 PM, Lars Erik Storbukås >>>

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On 3-1-2017 18:59, Luis R. Rodriguez wrote: > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: >> >> Right question is "should we solve it without user-space help"? >> >> Answer is no, too. Way too complex. Yes, it would be nice if hardware >> was designed in such a way that getting

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On 03/05/17 18:58, Cong Wang wrote: > On Tue, May 2, 2017 at 11:30 AM, Mike Manning wrote: >> While this is not reproducible manually, Andrey's syzkaller program hit >> the warning "IPv6: Freeing alive inet6 address" with this part trace: >> >>

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 11:02 AM, Cong Wang wrote: > A quick glance shows we need to simply check local->rt6i_idev > since we do the same check for sprt right above. As I recall, rt6i_idev is set for all routes except null_entry and it is not set on null_entry only because of initialization order. > > diff

[PATCH v2] aquantia: Fix driver name reported by ethtool

From: Pavel Belous V2: using "aquantia" subsystem tag. The command "ethtool -i ethX" should display driver name (driver: atlantic) instead vendor name (driver: aquantia). Signed-off-by: Pavel Belous ---

Re: Maximum MPLS labels on Linux network stack

On 5/3/17 11:33 AM, Алексей Болдырев wrote: > I watched one forum, there is listed in the properties of one license for > Cisco, it says: > > Layer 3 VPN • Multi-VRF CE (VRF-lite); requires IP Services Feature license > • MPLS VPN; requires Advanced IP Feature license > • 26 VRFs There is no

Re: [PATCH] net:ethernet:aquantia:atlantic: Fix driver name reported by ethtool

From: Pavel Belous Date: Wed, 3 May 2017 21:06:04 +0300 > From: Pavel Belous > > The command "ethtool -i ethX" should display driver name (driver: atlantic) > instead vendor name (driver: aquantia). > > Signed-off-by: Pavel Belous

[PATCH] net:ethernet:aquantia:atlantic: Fix driver name reported by ethtool

From: Pavel Belous The command "ethtool -i ethX" should display driver name (driver: atlantic) instead vendor name (driver: aquantia). Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 2 +- 1 file changed,

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On Tue, May 2, 2017 at 11:30 AM, Mike Manning wrote: > While this is not reproducible manually, Andrey's syzkaller program hit > the warning "IPv6: Freeing alive inet6 address" with this part trace: > > inet6_ifa_finish_destroy+0x12e/0x190 c:894 > in6_ifa_put

Maximum MPLS labels on Linux network stack

I watched one forum, there is listed in the properties of one license for Cisco, it says: Layer 3 VPN • Multi-VRF CE (VRF-lite); requires IP Services Feature license • MPLS VPN; requires Advanced IP Feature license • 26 VRFs • 8192 MPLS labels Especially interested in the figure 8192 MPLS

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

From: Alexei Starovoitov Date: Wed, 3 May 2017 09:54:42 -0700 > /usr/include/asm/types.h -> asm-generic/int-ll64.h > as far as I can see that should be the same on most archs. > Why doesn't it work for sparc? You can't assume anything about the kernel headers installed, on my

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 9:33 AM, Andrey Konovalov wrote: > Hi David, > > Got another report related to fib6. > > I'm on 89c9fea3c8034cdb2fd745f551cde0b507fd6893 with your last patch applied. > > A reproducer and .config are attached. > > kasan: CONFIG_KASAN_INLINE enabled >

[PATCH] net:ethernet:aquantia:atlantic: Switch to use napi_gro_receive

From: Pavel Belous Add support for GRO (generic receive offload) for aQuantia Atlantic driver. This results in a perfomance improvement when GRO is enabled. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c |

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

On 5/3/17 9:06 AM, David Miller wrote: From: David Miller Date: Wed, 03 May 2017 09:52:51 -0400 (EDT) From: Alexei Starovoitov Date: Tue, 2 May 2017 21:14:43 -0700 -D__x86_64__ workaround was used to make /usr/include/features.h to follow expected path

Re: [PATCH v2 net] tcp: do not inherit fastopen_req from parent

> From: Eric Dumazet > > Under fuzzer stress, it is possible that a child gets a non NULL > fastopen_req pointer from its parent at accept() time, when/if parent > morphs from listener to active session. > > We need to make sure this can not happen, by clearing the field

Re: [iproute PATCH] man: ip.8: Document -brief flag

On Wed, 3 May 2017 11:07:58 +0200 Phil Sutter wrote: > Brief output is especially useful for new users, so at least mention > it's existence in ip man page. > > Signed-off-by: Phil Sutter Applied. thanks.

Re: sock_create_kern() and (lack of) get_net()

On Wed, May 3, 2017 at 4:39 AM, David Laight wrote: > I suspect that many of the sockets created with 'kern=1' are not 'special' > and should hold a reference to the namespace. They are special if they are created in net init, which means they have the same life-time

Re: [patch iproute2 v2 0/2] devlink: Add support for pipeline

On Wed, 3 May 2017 13:25:21 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Arkadi says: > > Add support for pipeline debug (dpipe). As a preparation step the netlink > attribute validation was changed before adding new dpipe attributes. > --- > v1->v2 > -

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

From: David Miller Date: Wed, 03 May 2017 09:52:51 -0400 (EDT) > From: Alexei Starovoitov > Date: Tue, 2 May 2017 21:14:43 -0700 > >> -D__x86_64__ workaround was used to make /usr/include/features.h >> to follow expected path through the system include

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

On Tue, May 2, 2017 at 9:30 PM, Casey Leedom wrote: > | From: Alexander Duyck > | Date: Tuesday, May 2, 2017 11:10 AM > | ... > | So for example, in the case of x86 it seems like there are multiple > | root complexes that have issues, and the gains

Re: x86: warning: kernel stack regs has bad 'bp' value

On Wed, May 3, 2017 at 3:30 PM, Josh Poimboeuf wrote: > On Wed, May 03, 2017 at 02:48:28PM +0200, Andrey Konovalov wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit 89c9fea3c8034cdb2fd745f551cde0b507fd6893

Re: [PATCH v4 net-next 00/11] ibmvnic: Updated reset handler and code fixes

From: Nathan Fontenot Date: Wed, 03 May 2017 14:04:20 -0400 > This set of patches multiple code fixes and a new rest handler > for the ibmvnic driver. In order to implement the new reset handler > for the ibmvnic driver resource initialization needed to be moved to >

Re: [PATCH] net/sched: remove redundant null check on head

Wed, May 03, 2017 at 04:21:15PM CEST, wha...@bfs.de wrote: > > >Am 03.05.2017 15:50, schrieb Colin King: >> From: Colin Ian King >> >> head is previously null checked and so the 2nd null check on head >> is redundant and therefore can be removed. >> >> Detected by

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hello Giuseppe, On Wed, 3 May 2017 10:13:56 +0200, Giuseppe CAVALLARO wrote: > this was initially set by using the hw->link.port; both the core_init > and adjust callback > should invoke the hook and tuning the PS bit according to the speed and > mode. But this doesn't work: core_init and

[PATCH] ipv4, ipv6: ensure raw socket message is big enough to hold an IP header

raw_send_hdrinc() and rawv6_send_hdrinc() expect that the buffer copied from the userspace contains the IPv4/IPv6 header, so if too few bytes are copied, parts of the header may remain uninitialized. This bug has been detected with KMSAN. Signed-off-by: Alexander Potapenko

[PATCH net] ah: use crypto_memneq to check the ICV

Signed-off-by: Sabrina Dubroca --- net/ipv4/ah4.c | 5 +++-- net/ipv6/ah6.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c index 22377c8ff14b..207350b30f88 100644 --- a/net/ipv4/ah4.c +++ b/net/ipv4/ah4.c @@ -1,5

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On Wed, May 3, 2017 at 4:16 PM, Mike Manning wrote: > On reflection, please put this on hold subject to testing with syzkaller. I > have not had a repro of the issue and so the fix even though harmless may not > be effective. Hi Mike, I didn't see your patch, you think

[PATCH v2 net] xfrm: fix stack access out of bounds with CONFIG_XFRM_SUB_POLICY

When CONFIG_XFRM_SUB_POLICY=y, xfrm_dst stores a copy of the flowi for that dst. Unfortunately, the code that allocates and fills this copy doesn't care about what type of flowi (flowi, flowi4, flowi6) gets passed. In multiple code paths (from raw_sendmsg, from TCP when replying to a FIN, in

Re: net/smc and the RDMA core

On 05/02/2017 08:39 PM, Bart Van Assche wrote: > On Tue, 2017-05-02 at 14:25 +0200, Ursula Braun wrote: >> if you can point out specific issues, we will be happy to work with you >> to get them addressed! > > Hello Ursula, > > My list of issues that I would like to see addressed can be found

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

On Wed, May 03, 2017 at 10:13:56AM +0200, Giuseppe CAVALLARO wrote: > Hello Thomas > > this was initially set by using the hw->link.port; both the core_init > and adjust callback > should invoke the hook and tuning the PS bit according to the speed and > mode. > So maybe the ->set_ps is

[PATCH] ath5k: fix memory leak on buf on failed eeprom read

From: Colin Ian King The AR5K_EEPROM_READ macro returns with -EIO if a read error occurs causing a memory leak on the allocated buffer buf. Fix this by explicitly calling ath5k_hw_nvram_read and exiting on the via the freebuf label that performs the necessary free'ing

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

From: Mike Manning Date: Wed, 3 May 2017 15:16:20 +0100 > On reflection, please put this on hold subject to testing with > syzkaller. I have not had a repro of the issue and so the fix even > though harmless may not be effective. Ok.

Re: [PATCH] net/sched: remove redundant null check on head

Am 03.05.2017 15:50, schrieb Colin King: > From: Colin Ian King > > head is previously null checked and so the 2nd null check on head > is redundant and therefore can be removed. > > Detected by CoverityScan, CID#1399505 ("Logically dead code") > > Signed-off-by:

[PATCH v4 net-next 11/11] ibmvnic: Move queue restarting in ibmvnic_tx_complete

Restart of the subqueue should occur outside of the loop processing any tx buffers instead of doing this in the middle of the loop. Signed-off-by: Nathan Fontenot --- v2: Use __netif_subqueue_stopped() instead of netif_subqueue_stopped() to avoid possible using

[PATCH v4 net-next 07/11] ibmvnic: Wait for any pending scrqs entries at driver close

When closing the ibmvnic driver we need to wait for any pending sub crq entries to ensure they are handled. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 47 +--- 1 file changed, 27 insertions(+), 20

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On reflection, please put this on hold subject to testing with syzkaller. I have not had a repro of the issue and so the fix even though harmless may not be effective. Thanks Mike On 02/05/17 19:30, Mike Manning wrote: > While this is not reproducible manually, Andrey's syzkaller program hit >

[PATCH v4 net-next 10/11] ibmvnic: Record SKB RX queue during poll

From: Thomas Falcon Map each RX SKB to the RX queue associated with the driver's RX SCRQ. This should improve the RX CPU load balancing issues seen by the performance team. Signed-off-by: Thomas Falcon ---

[PATCH v4 net-next 06/11] ibmvnic: Clean up tx pools when closing

When closing the ibmvnic driver, most notably during the reset path, the tx pools need to be cleaned to ensure there are no hanging skbs that need to be free'ed. The need for this was found during debugging a loss of network traffic after handling a driver reset. The underlying cause was some

[PATCH v4 net-next 09/11] ibmvnic: Continue skb processing after skb completion error

There is not a need to stop processing skbs if we encounter a skb that has a receive completion error. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 net-next 03/11] ibmvnic: Updated reset handling

The ibmvnic driver has multiple handlers for resetting the driver depending on the reason the reset is needed (failover, lpm, fatal erors,...). All of the reset handlers do essentially the same thing, this patch moves this work to a common reset handler. By doing this we also allow the driver to

  1   2   >