On Thu, 4 May 2017 21:02:08 +0300, Leon Romanovsky wrote:
> In order to close object model, ensure reuse of existing code and make this
> tool usable from day one, we decided to implement wrappers over legacy sysfs
> prior to implementing netlink functionality. As a nice bonus, it will allow
> to
On Thu, 4 May 2017 13:47:36 -0600, David Ahern wrote:
> On 5/4/17 1:10 PM, Florian Fainelli wrote:
> > On 05/04/2017 09:37 AM, David Ahern wrote:
> > Do you plan on submitting the LWT patch set at some point?
>
> Definitely. Maybe I can find some time this weekend.
I suggest to change the name to
On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko
wrote:
> acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16
> bytes. Instead we convert them to use uuid_le type. At the same time we
> convert current users.
>
> acpi_str_to_uuid() becomes useless after the conversion and it's safe
Hi Andy,
[auto build test ERROR on next-20170503]
[cannot apply to pm/linux-next linus/master linux/master v4.9-rc8 v4.9-rc7
v4.9-rc6 v4.11]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Andy-
Hi,
I am thinking about the possibility of using SSE in kernel for
speeding up the kernel memcpy particularly for copy to userspace
emeory, and maybe even using the string instructions (like if we
supported regex in something like eBPF). AFAIK we don't use SSE in
kernel because of xmm register sta
On Fri, 2017-05-05 at 08:57 +0530, Anand H. Krishnan wrote:
> Hello,
>
> Is skb_gro_receive doing the right thing for cloned packets?
>
> When we are merging fragments, we do not seem to be taking a reference
> to the underlying page. To me, it looks like it should work fine for
> non-cloned
> p
Hello,
Is skb_gro_receive doing the right thing for cloned packets?
When we are merging fragments, we do not seem to be taking a reference
to the underlying page. To me, it looks like it should work fine for non-cloned
packets. However, for cloned packets, when the gro-ed packet is eventually
fre
On 2017年05月05日 10:09, Stefan Agner wrote:
> On 2017-05-04 19:03, Andy Duan wrote:
>> On 2017年05月05日 05:36, Stefan Agner wrote:
>>> On 2017-05-03 20:08, Andy Duan wrote:
From: Stefan Agner Sent: Thursday, May 04, 2017 9:22 AM
> To: Andy Duan
> Cc: fugang.d...@freescale.com; feste...@g
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, May 04, 2017 11:13 PM
> To: zhangshen...@cmss.chinamobile.com
> Cc: netdev@vger.kernel.org; eduma...@google.com
> Subject: Re: [net-next] net: remove duplicate add_device_randomness() call
>
> From: Zh
From: Eric Dumazet
Whole point of randomization was to hide server uptime, but an attacker
can simply start a syn flood and TCP generates 'old style' timestamps,
directly revealing server jiffies value.
Also, TSval sent by the server to a particular remote address vary
depending on syncookies be
On 2017-05-04 19:03, Andy Duan wrote:
> On 2017年05月05日 05:36, Stefan Agner wrote:
>> On 2017-05-03 20:08, Andy Duan wrote:
>>> From: Stefan Agner Sent: Thursday, May 04, 2017 9:22 AM
To: Andy Duan
Cc: fugang.d...@freescale.com; feste...@gmail.com;
netdev@vger.kernel.org; netdev-ow.
On 2017年05月05日 05:36, Stefan Agner wrote:
> On 2017-05-03 20:08, Andy Duan wrote:
>> From: Stefan Agner Sent: Thursday, May 04, 2017 9:22 AM
>>> To: Andy Duan
>>> Cc: fugang.d...@freescale.com; feste...@gmail.com;
>>> netdev@vger.kernel.org; netdev-ow...@vger.kernel.org
>>> Subject: Re: FEC on i.
On Fri, 2017-05-05 at 02:32 +0200, Florian Westphal wrote:
> Florian Westphal wrote:
> [..]
> > This breaks syncookies w. timestamps; cookie_timestamp_decode() lacks a
> > tsoff
> > for readjustment.
> >
> > We also need to pass the (recomputed) tsoff to tcp_get_cookie_sock().
>
> This small de
Florian Westphal wrote:
[..]
> This breaks syncookies w. timestamps; cookie_timestamp_decode() lacks a tsoff
> for readjustment.
>
> We also need to pass the (recomputed) tsoff to tcp_get_cookie_sock().
This small delta makes things work for me:
diff --git a/include/net/tcp.h b/include/net/tcp.
On 5/4/17 5:07 PM, Stephen Hemminger wrote:
On Thu, 4 May 2017 14:46:34 -0700
Girish Moodalbail wrote:
Ability to change vxlan device attributes was added to kernel through
commit 8bcdc4f3a20b ("vxlan: add changelink support"), however one
cannot do the same through ip(8) command. Changing t
Eric Dumazet wrote:
> From: Eric Dumazet
>
> Whole point of randomization was to hide server uptime, but an attacker
> can simply start a syn flood and TCP generates 'old style' timestamps,
> directly revealing server jiffies value.
>
> Also, TSval sent by the server to a particular remote addr
On Thu, 4 May 2017 14:46:34 -0700
Girish Moodalbail wrote:
> Ability to change vxlan device attributes was added to kernel through
> commit 8bcdc4f3a20b ("vxlan: add changelink support"), however one
> cannot do the same through ip(8) command. Changing the allowed vxlan
> device attributes usin
On Thu, 04 May 2017 16:45:58 -0400
Doug Ledford wrote:
> On Thu, 2017-05-04 at 15:26 -0400, Dennis Dalessandro wrote:
> > On 05/04/2017 02:45 PM, Leon Romanovsky wrote:
> > >
> > > On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote:
> > > >
> > > > On Thu, 2017-05-04 at 21:25 +
On 5/4/17 6:37 AM, David Miller wrote:
From: Alexei Starovoitov
Date: Wed, 3 May 2017 20:30:22 -0700
I would buy that debian folks indeed care about multi-arch, but
what above does is making #include to be a nop
for any cross-compiler on sparc that included it.
No, if you installed cross co
On Thu, May 4, 2017 at 9:43 AM, Jiri Benc wrote:
> On Thu, 4 May 2017 09:37:00 +, Chiappero, Marco wrote:
>> This looks conceptually wrong. Yes, ipvlan works at L3 (which is an
>> implementation detail anyway), but slaves are Ethernet interfaces and
>> should behave as much as possible as such
On Thu, May 4, 2017 at 2:37 AM, Chiappero, Marco
wrote:
>> -Original Message-
>> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
>> On Behalf Of Dan Williams
>> Sent: Tuesday, May 2, 2017 5:09 PM
>> To: Chiappero, Marco ; netdev@vger.kernel.org
>> Cc: David S . Mil
From: Eric Dumazet
Whole point of randomization was to hide server uptime, but an attacker
can simply start a syn flood and TCP generates 'old style' timestamps,
directly revealing server jiffies value.
Also, TSval sent by the server to a particular remote address vary depending
on syncookies be
Ability to change vxlan device attributes was added to kernel through
commit 8bcdc4f3a20b ("vxlan: add changelink support"), however one
cannot do the same through ip(8) command. Changing the allowed vxlan
device attributes using 'ip link set dev type vxlan
' currently fails with 'operation not s
IPv4 dst could use fi->fib_metrics to store metrics but fib_info
itself is refcnt'ed, so without taking a refcnt fi and
fi->fib_metrics could be freed while dst metrics still points to
it. This triggers use-after-free as reported by Andrey twice.
This patch reverts commit 2860583fe840 ("ipv4: Kill
On 2017-05-03 20:08, Andy Duan wrote:
> From: Stefan Agner Sent: Thursday, May 04, 2017 9:22 AM
>>To: Andy Duan
>>Cc: fugang.d...@freescale.com; feste...@gmail.com;
>>netdev@vger.kernel.org; netdev-ow...@vger.kernel.org
>>Subject: Re: FEC on i.MX 7 transmit queue timeout
>>
>>Hi Andy,
>>
>>On 201
| From: Alexander Duyck
| Sent: Wednesday, May 3, 2017 9:02 AM
| ...
| It sounds like we are more or less in agreement. My only concern is
| really what we default this to. On x86 I would say we could probably
| default this to disabled for existing platforms since my understanding
| is that relax
On Thu, 2017-05-04 at 15:26 -0400, Dennis Dalessandro wrote:
> On 05/04/2017 02:45 PM, Leon Romanovsky wrote:
> >
> > On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote:
> > >
> > > On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote:
> > > >
> > > > On Thu, May 04, 2017 at 06:
Hi,
On Thu, May 04, 2017 at 09:43:56AM -0700, Stephen Hemminger wrote:
> On Thu, 04 May 2017 10:41:03 -0400 (EDT)
> David Miller wrote:
>
> > From: David Ahern
> > Date: Thu, 4 May 2017 08:27:35 -0600
> >
> > > On 5/4/17 3:36 AM, Daniel Borkmann wrote:
> > >> What is the clear benefit/ration
On 05/04/2017 04:10 PM, Pavel Belous wrote:
> From: Pavel Belous
>
> This patch fixes the crash that happens when driver tries to collect
> statistics
> from already released "aq_vec" object.
> If adapter is in "down" state we still allow user to see statistics from HW.
>
> V2: fixed braces aro
From: Markus Elfring
Date: Thu, 4 May 2017 21:40:54 +0200
Seven single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/net/ethernet/chels
From: Markus Elfring
Date: Thu, 4 May 2017 22:16:57 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix two source code places.
Signed-off-by: Markus Elfring
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 1
From: Markus Elfring
Date: Thu, 4 May 2017 21:52:32 +0200
A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drive
From: Markus Elfring
Date: Thu, 4 May 2017 21:20:25 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code pla
From: Markus Elfring
Date: Thu, 4 May 2017 21:00:20 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
.../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main
From: Markus Elfring
Date: Thu, 4 May 2017 20:02:04 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/net/ethernet/chelsio/cxg
From: Markus Elfring
Date: Thu, 4 May 2017 22:23:45 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (6):
Use seq_putc() in mboxlog_show()
Combine substrings for 24 messages
Adjust five checks for null pointers
Replace seven seq_puts
On Thu, 2017-05-04 at 23:10 +0300, Pavel Belous wrote:
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
[]
> @@ -959,8 +959,10 @@ void aq_nic_free_hot_resources(struct aq_nic_s *self)
> goto err_exit;
>
> for (
Add code comment to make it clear that the position of the arguments
req->id.idiag_dport and req->id.idiag_sport is a locked in behavior
and it should not be changed.
Addresses-Coverity-ID: 1357474
Cc: David Miller
Cc: Joe Perches
Signed-off-by: Gustavo A. R. Silva
---
net/ipv4/inet_diag.c | 6
From: Pavel Belous
This patch fixes the crash that happens when driver tries to collect statistics
from already released "aq_vec" object.
If adapter is in "down" state we still allow user to see statistics from HW.
V2: fixed braces around "aq_vec_free".
Fixes: 97bde5c4f909 ("net: ethernet: aqua
On 5/4/17 1:10 PM, Florian Fainelli wrote:
> On 05/04/2017 09:37 AM, David Ahern wrote:
>> On 5/4/17 9:15 AM, Nicolas Dichtel wrote:
>>> Le 24/02/2017 à 16:52, David Ahern a écrit :
On 2/23/17 8:12 PM, David Miller wrote:
> This really need to be a fundamental facility, so that it transpar
Quoting Joe Perches :
[]
> > +/*
> > + * Ignore the position of the arguments req->id.idiag_dport and
> > + * req->id.idiag_sport in both calls to inet_lookup() and
inet6_lookup()
> > + * functions, once this is a locked in behavior exposed to user space.
> > + * Changing this will break thi
This is a note to let you know that I've just added the patch titled
netlink: Allow direct reclaim for fallback allocation
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ne
On Thu, May 04, 2017 at 03:26:13PM -0400, Dennis Dalessandro wrote:
> On 05/04/2017 02:45 PM, Leon Romanovsky wrote:
> > On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote:
> > > On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote:
> > > > On Thu, May 04, 2017 at 06:10:54PM +,
On 5/4/17 11:36 AM, Cong Wang wrote:
> For each netns (except init_net), we initialize its null entry
> in 3 places:
>
> 1) The template itself, as we use kmemdup()
> 2) Code around dst_init_metrics() in ip6_route_net_init()
> 3) ip6_route_dev_notify(), which is supposed to initialize it after
>
On Wed, May 03, 2017 at 09:44:19AM +0100, Ross Lagerwall wrote:
> The backport of d35c99ff77ec ("netlink: do not enter direct reclaim from
> netlink_dump()") to the 4.4 branch (first in 4.4.32) mistakenly removed
> direct claim from the initial large allocation _and_ the fallback
> allocation which
On 05/04/2017 02:45 PM, Leon Romanovsky wrote:
On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote:
On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote:
On Thu, May 04, 2017 at 06:10:54PM +, Bart Van Assche wrote:
On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote:
Hi Joe,
Quoting Joe Perches :
On Thu, 2017-05-04 at 12:46 -0400, David Miller wrote:
From: "Gustavo A. R. Silva"
Date: Thu, 04 May 2017 11:07:54 -0500
> While looking into Coverity ID 1357474 I ran into the following piece
> of code at net/ipv4/inet_diag.c:392:
Because it's been this way si
On Thu, 2017-05-04 at 14:15 -0500, Gustavo A. R. Silva wrote:
> Quoting Joe Perches :
>
> > On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote:
> > > Regarding the code comments, what about the following patch:
> >
> > []
> > > diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
>
Quoting Joe Perches :
On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote:
Regarding the code comments, what about the following patch:
[]
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
[]
@@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct
sk_buff *skb,
On 05/04/2017 09:37 AM, David Ahern wrote:
> On 5/4/17 9:15 AM, Nicolas Dichtel wrote:
>> Le 24/02/2017 à 16:52, David Ahern a écrit :
>>> On 2/23/17 8:12 PM, David Miller wrote:
This really need to be a fundamental facility, so that it transparently
works for NetworkManager, router daemo
On 04.05.2017 20:37, Pavel Belous wrote:
>
> Yes, even adapter is in the down state user can still see statistics from the
> HW.
> For example (adapter is down):
>
> $ ethtool -S enp2s0
> NIC statistics:
> InPackets: 3237727
> InUCast: 3237214
> InMCast: 391
> InBCast: 122
>
On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote:
> Regarding the code comments, what about the following patch:
[]
> diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
[]
> @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct
> sk_buff *skb,
>
1) The wireless rate info fix from Johannes Berg.
2) When a RAW socket is in hdrincl mode, we need to make sure that the
user provided at least a minimally sized ipv4/ipv6 header. Fix from
Alexander Potapenko.
3) We must emit IFLA_PHYS_PORT_NAME netlink attributes using
nla_put_string(
On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote:
> On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote:
> > On Thu, May 04, 2017 at 06:10:54PM +, Bart Van Assche wrote:
> > > On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote:
> > > > Following our discussion both in
On 04.05.2017 21:17, Joe Perches wrote:
On Thu, 2017-05-04 at 20:08 +0300, Pavel Belous wrote:
I will prepare another patch with Lino and David M. comments.
I'm not submitting this because it'd just cause merge conflicts,
but
something you could do one day is remove the AQ_DIMOF macro
and ju
On 04.05.2017 21:27, David Arcari wrote:
On 05/04/2017 01:09 PM, Pavel Belous wrote:
On 04.05.2017 19:51, David Miller wrote:
From: Lino Sanfilippo
Date: Thu, 4 May 2017 18:48:12 +0200
Hi Pavel,
On 04.05.2017 18:33, Pavel Belous wrote:
From: Pavel Belous
This patch fixes the crash th
On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote:
> On Thu, May 04, 2017 at 06:10:54PM +, Bart Van Assche wrote:
> > On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote:
> > > Following our discussion both in mailing list [1] and at the LPC 2016 [2],
> > > we would like to propose
On Thu, 2017-05-04 at 17:03 +, Ilya Lesokhin wrote:
> I don't understand the need for MSG_SENDPAGE_NOTLAST and I'm hoping
> someone can enlighten me.
>
> According to commit 35f9c09 ('tcp: tcp_sendpages() should call
> tcp_push() once'):
> "We need to call tcp_flush() at the end of the last pa
On 05/04/2017 11:26 AM, Icenowy Zheng wrote:
>
>
> 于 2017年5月5日 GMT+08:00 上午2:21:29, Florian Fainelli 写到:
>> On 05/04/2017 11:10 AM, icen...@aosc.io wrote:
>>> 在 2017-04-22 08:22，Florian Fainelli 写道：
On 04/21/2017 04:24 PM, Icenowy Zheng wrote:
> From: Icenowy Zheng
>
> Some RTL
于 2017年5月5日 GMT+08:00 上午2:21:29, Florian Fainelli 写到:
>On 05/04/2017 11:10 AM, icen...@aosc.io wrote:
>> 在 2017-04-22 08:22，Florian Fainelli 写道：
>>> On 04/21/2017 04:24 PM, Icenowy Zheng wrote:
From: Icenowy Zheng
Some RTL8211E Ethernet PHY have an issue that needs a workaround
>
On 05/04/2017 01:09 PM, Pavel Belous wrote:
>
>
> On 04.05.2017 19:51, David Miller wrote:
>> From: Lino Sanfilippo
>> Date: Thu, 4 May 2017 18:48:12 +0200
>>
>>> Hi Pavel,
>>>
>>> On 04.05.2017 18:33, Pavel Belous wrote:
From: Pavel Belous
This patch fixes the crash that happens
On Thu, May 04, 2017 at 06:10:54PM +, Bart Van Assche wrote:
> On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote:
> > Following our discussion both in mailing list [1] and at the LPC 2016 [2],
> > we would like to propose this RDMA tool to be part of iproute2 package
> > and finally impr
On 05/04/2017 11:10 AM, icen...@aosc.io wrote:
> 在 2017-04-22 08:22，Florian Fainelli 写道：
>> On 04/21/2017 04:24 PM, Icenowy Zheng wrote:
>>> From: Icenowy Zheng
>>>
>>> Some RTL8211E Ethernet PHY have an issue that needs a workaround
>>> indicated with device tree.
>>>
>>> Add the binding for a pr
On Thu, 2017-05-04 at 20:08 +0300, Pavel Belous wrote:
> I will prepare another patch with Lino and David M. comments.
I'm not submitting this because it'd just cause merge conflicts,
but
something you could do one day is remove the AQ_DIMOF macro
and just use ARRAY_SIZE directly.
---
drivers/net
在 2017-04-22 08:22，Florian Fainelli 写道：
On 04/21/2017 04:24 PM, Icenowy Zheng wrote:
From: Icenowy Zheng
Some RTL8211E Ethernet PHY have an issue that needs a workaround
indicated with device tree.
Add the binding for a property that indicates this workaround.
Signed-off-by: Icenowy Zheng
-
On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote:
> Following our discussion both in mailing list [1] and at the LPC 2016 [2],
> we would like to propose this RDMA tool to be part of iproute2 package
> and finally improve this situation.
Hello Leon,
Although I really appreciate your work:
From: Leon Romanovsky
Add parsing interface for the cap_mask
$./rdma/rdma link show mlx5_2/2 cap_mask
3/2: mlx5_2/2: sm off notice off trap on opt_ipd off auto_migr off sl_map on
mkey_nvram off
pkey_nvram off led_info off sm_disabled off sys_image_guid on
pkey_sw_ext_port_trap off
From: Leon Romanovsky
The following objects (monitor, providers, stats and protocols) are not
implemented yet, however it is worth to place their stubs in the code.
This will serve as an initial starting point for other developers to
extend RDMA tool.
Signed-off-by: Leon Romanovsky
---
rdma/M
From: Leon Romanovsky
Signed-off-by: Leon Romanovsky
---
man/man8/Makefile | 3 +-
man/man8/rdma.8 | 109 ++
2 files changed, 111 insertions(+), 1 deletion(-)
create mode 100644 man/man8/rdma.8
diff --git a/man/man8/Makefile b/man/man8/M
From: Leon Romanovsky
Memory object gives to the user ability to manipulate over general
properties of memory for the specific devices. The memory properties
have broader usage than dev object can provide.
For example, on-demand-paging (ODP) configurations are mostly software related.
Signed-of
From: Leon Romanovsky
Device (dev) object represents struct ib_device to user space.
The supported commands are show, set and help.
Print all devices:
# rdma dev
1: mlx5_0: board_id MT_2190110032 fw_pages 261002 fw_ver 12.17.2046 hca_type
MT4115 hw_rev 0
node_desc hpchead HCA-1 node_g
From: Leon Romanovsky
Link object represents port of struct ib_device.
Supported commands are show, set and help.
Print all links for all devices:
# rdma link
1/1: mlx5_0/1: ifname ib0 cap_mask 0x2651e848 lid 0x13 lid_mask_count 0
link_layer InfiniBand
phys_state 5: LinkUp rate 100 Gb
From: Leon Romanovsky
IPoIB object allows configuration and presentation of information for
IP-over-Infiniband user level protocol.
Supported commands are show, set and help.
Signed-off-by: Leon Romanovsky
---
rdma/Makefile | 2 +-
rdma/ipoib.c | 54 +
From: Leon Romanovsky
This is initial phase to understand if user experience for this tool fits
RDMA and netdev communities exepectations. Also I would like to get feedback
if it is really worth to provide legacy sysfs for old kernels, or maybe I should
implement netlink from the beginning a
From: Leon Romanovsky
RDMA devices are cross-functional devices from one side,
but very tailored for the specific markets from another.
Such diversity caused to spread of RDMA related configuration
across various tools, e.g. devlink, ip, ethtool, ib specific and
vendor specific solutions.
This
On Thu, May 04, 2017 at 09:45:58AM -0700, Stephen Hemminger wrote:
> On Thu, 4 May 2017 17:37:38 +0300
> Leon Romanovsky wrote:
>
> > On Thu, May 04, 2017 at 11:36:36AM +0200, Daniel Borkmann wrote:
> > > On 05/04/2017 01:56 AM, Stephen Hemminger wrote:
> > > > Add support for extended ack error r
On Thu, 2017-05-04 at 12:46 -0400, David Miller wrote:
> From: "Gustavo A. R. Silva"
> Date: Thu, 04 May 2017 11:07:54 -0500
>
> > While looking into Coverity ID 1357474 I ran into the following piece
> > of code at net/ipv4/inet_diag.c:392:
>
> Because it's been this way since at least 2005, it
For each netns (except init_net), we initialize its null entry
in 3 places:
1) The template itself, as we use kmemdup()
2) Code around dst_init_metrics() in ip6_route_net_init()
3) ip6_route_dev_notify(), which is supposed to initialize it after
loopback registers
Unfortunately the last one st
On Thu, May 4, 2017 at 8:22 AM, David Miller wrote:
> From: Johannes Berg
>>
>> I figured I'd give Linus to a chance to try or even apply it, but I
>> have no objection to you applying it either. I don't have anything else
>> yet right now, and sending a pull request for just a single patch
>>
This function is pretty long and the skb handling is a bit long too.
Create a new function just for the skb processing.
This isolates the code and reduces indentation a bit too.
No change in object size.
$ size net/mac80211/iface.o*
textdata bss dec hex filename
15736 2
On Thu, May 4, 2017 at 7:04 AM, David Ahern wrote:
> On 5/3/17 11:07 PM, Cong Wang wrote:
>> For each netns (except init_net), we initialize its null entry
>> in 3 places:
>>
>> 1) The template itself, as we use kmemdup()
>> 2) Code around dst_init_metrics() in ip6_route_net_init()
>> 3) ip6_route
On Thu, May 4, 2017 at 10:12 AM, David Ahern wrote:
> On 5/4/17 10:51 AM, David Miller wrote:
>> From: Andrey Konovalov
>> Date: Thu, 4 May 2017 14:28:37 +0200
>>
>>> On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote:
Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev
sin
Hi David,
Quoting David Miller :
From: "Gustavo A. R. Silva"
Date: Thu, 04 May 2017 11:07:54 -0500
While looking into Coverity ID 1357474 I ran into the following piece
of code at net/ipv4/inet_diag.c:392:
Because it's been this way since at least 2005, it doesn't matter if
the order is co
From: Johannes Berg
Date: Thu, 4 May 2017 08:42:30 +0200
> From: Johannes Berg
>
> Due to the way I did the RX bitrate conversions in mac80211 with
> spatch, going setting flags to setting the value, many drivers now
> don't set the bandwidth value for 20 MHz, since with the flags it
> wasn't
On 5/4/17 10:51 AM, David Miller wrote:
> From: Andrey Konovalov
> Date: Thu, 4 May 2017 14:28:37 +0200
>
>> On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote:
>>> Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev
>>> since it is always NULL.
>>>
>>> This is clearly wrong, we have
On 04.05.2017 19:51, David Miller wrote:
From: Lino Sanfilippo
Date: Thu, 4 May 2017 18:48:12 +0200
Hi Pavel,
On 04.05.2017 18:33, Pavel Belous wrote:
From: Pavel Belous
This patch fixes the crash that happens when driver tries to collect statistics
from already released "aq_vec" object.
On 5/4/17 9:42 AM, Oleg wrote:
Hi, all.
It seems struct ip and struct iphdr are similar: struct ip, despite of
it name, doesn't contain anything but ip header.
So, my noob question, what is the difference between them?
Also, see this:
http://stackoverflow.com/questions/42840636/difference-
On 04.05.2017 20:00, David Arcari wrote:
Hi Pavel,
On 05/04/2017 12:33 PM, Pavel Belous wrote:
From: Pavel Belous
This patch fixes the crash that happens when driver tries to collect statistics
from already released "aq_vec" object.
Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support fo
I don't understand the need for MSG_SENDPAGE_NOTLAST and I'm hoping someone can
enlighten me.
According to commit 35f9c09 ('tcp: tcp_sendpages() should call tcp_push()
once'):
"We need to call tcp_flush() at the end of the last page processed in
tcp_sendpages(), or else transmits can be deferred
Hi Pavel,
On 05/04/2017 12:33 PM, Pavel Belous wrote:
> From: Pavel Belous
>
> This patch fixes the crash that happens when driver tries to collect
> statistics
> from already released "aq_vec" object.
>
> Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for NIC-specific code")
> Signed-
On (05/04/17 19:42), Oleg wrote:
>
> Hi, all.
>
> It seems struct ip and struct iphdr are similar: struct ip, despite of
> it name, doesn't contain anything but ip header.
>
> So, my noob question, what is the difference between them?
>
> Thanks.
BSD vs linux?
struct ip is a BSD-ism, intend
From: Andrey Konovalov
Date: Thu, 4 May 2017 14:28:37 +0200
> On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote:
>> Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev
>> since it is always NULL.
>>
>> This is clearly wrong, we have code to initialize it to loopback_dev,
>> unfortun
From: Lino Sanfilippo
Date: Thu, 4 May 2017 18:48:12 +0200
> Hi Pavel,
>
> On 04.05.2017 18:33, Pavel Belous wrote:
>> From: Pavel Belous
>>
>> This patch fixes the crash that happens when driver tries to collect
>> statistics
>> from already released "aq_vec" object.
>>
>> Fixes: 97bde5c4f9
Hi, all.
It seems struct ip and struct iphdr are similar: struct ip, despite of
it name, doesn't contain anything but ip header.
So, my noob question, what is the difference between them?
Thanks.
--
Олег Неманов (Oleg Nemanov)
Hi Pavel,
On 04.05.2017 18:33, Pavel Belous wrote:
> From: Pavel Belous
>
> This patch fixes the crash that happens when driver tries to collect
> statistics
> from already released "aq_vec" object.
>
> Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for NIC-specific code")
> Signed-off
Apparently IRDA is broken by VMAP_STACK
Begin forwarded message:
Date: Thu, 04 May 2017 12:16:15 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 195217] siocsifflags - irda doesn't work (MCS7780)
https://bugzilla.kernel.org/show_bug.cgi?id=195217
Je
From: "Gustavo A. R. Silva"
Date: Thu, 04 May 2017 11:07:54 -0500
> While looking into Coverity ID 1357474 I ran into the following piece
> of code at net/ipv4/inet_diag.c:392:
Because it's been this way since at least 2005, it doesn't matter if
the order is correct or not. What's there is the
On Thu, 4 May 2017 17:37:38 +0300
Leon Romanovsky wrote:
> On Thu, May 04, 2017 at 11:36:36AM +0200, Daniel Borkmann wrote:
> > On 05/04/2017 01:56 AM, Stephen Hemminger wrote:
> > > Add support for extended ack error reporting via libmnl. This
> > > is a better alternative to use existing libr
On Thu, 4 May 2017 09:37:00 +, Chiappero, Marco wrote:
> This looks conceptually wrong. Yes, ipvlan works at L3 (which is an
> implementation detail anyway), but slaves are Ethernet interfaces and
> should behave as much as possible as such regardless, with an
> individual MAC address assigned.
On Thu, 04 May 2017 10:41:03 -0400 (EDT)
David Miller wrote:
> From: David Ahern
> Date: Thu, 4 May 2017 08:27:35 -0600
>
> > On 5/4/17 3:36 AM, Daniel Borkmann wrote:
> >> What is the clear benefit/rationale of outsourcing this to
> >> libmnl? I always was the impression we should strive for
1 - 100 of 188 matches
Mail list logo
