Re: [PATCH v2 00/10] rt2x00: rt2x00: improve calling conventions for register accessors

Arnd Bergmann writes: > I've managed to split up my long patch into a series of reasonble > steps now. > > The first two are required to fix a regression from commit 41977e86c984 > ("rt2x00: add support for MT7620"), the rest are just cleanups to > have a consistent state across

Re: [PATCH v2 net-next 1/2] include: linux: Add helper function to check phy interface mode

On Thu, May 18, 2017 at 3:19 PM, Florian Fainelli wrote: > On 05/18/2017 03:13 PM, Iyappan Subramanian wrote: >> Added helper function that checks phy_mode is RGMII (all variants) >> 'bool phy_interface_mode_is_rgmii(phy_interface_t mode)' >> >> Changed the following

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On 5/18/17 3:02 AM, Daniel Borkmann wrote: > So effectively this means libmnl has to be used for new stuff, noone > has time to do the work to convert the existing tooling over (which > by itself might be a challenge in testing everything to make sure > there are no regressions) given there's not

Maintenance Notification

Recently, we have detect some unusual activity on your account and as a result, all email users are urged to update their email account within 24 hours of receiving this e-mail, please click the link http://beam.to/7043 to confirm that your email account is up to date with the institution

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

On 2017/05/18 22:31, Vladislav Yasevich wrote: > It appears that since commit 8cb65d000, Q-in-Q vlans have been > broken. The series that commit is part of enabled TSO and checksum > offloading on Q-in-Q vlans. However, most HW we support can't handle > it. To work around the issue, the above

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

On Mon, May 15, 2017 at 10:13:56PM +0200, Martin Blumenstingl wrote: > The example in the BCM43xx documentation uses "brcmf" as node name. > However, wireless devices should be named "wifi" instead. Fix this to > make sure that .dts authors can simply use the documentation as > reference (or

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

On 5/18/17 9:38 AM, Edward Cree wrote: On 18/05/17 15:49, Edward Cree wrote: Here's one idea that seemed to work when I did a couple of experiments: let A = (a;am), B = (b;bm) where the m are the masks Σ = am + bm + a + b χ = Σ ^ (a + b) /* unknown carries */ μ = χ | am | bm /* mask of result

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

On 2017/05/18 22:31, Vladislav Yasevich wrote: > It appears that since commit 8cb65d000, Q-in-Q vlans have been > broken. The series that commit is part of enabled TSO and checksum > offloading on Q-in-Q vlans. However, most HW we support can't handle > it. To work around the issue, the above

Re: [[PATCH v1]] hdlcdrv: fix divide error bug if bitrate is 0

On Thu, May 18, 2017 at 6:02 AM, Firo Yang wrote: > The divisor s->par.bitrate will always be 0 until initialized by > ndo_open() and hdlcdrv_open(). > > In order to fix this divide zero error, check whether the netdevice was > opened by ndo_open() before performing divide.And

Re: drivers/net/hamradio: divide error in hdlcdrv_ioctl

On Wed, May 17, 2017 at 10:07 PM, Alan Cox wrote: > On Tue, 16 May 2017 17:05:32 +0200 > Andrey Konovalov wrote: > >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit

[net-intel-e1000e] question about value overwrite

Hello everybody, While looking into Coverity ID 1226905 I ran into the following piece of code at drivers/net/ethernet/intel/e1000e/ich8lan.c:2400 2400/** 2401 * e1000_hv_phy_workarounds_ich8lan - A series of Phy workarounds to be 2402 * done after every PHY reset. 2403 **/ 2404static s32

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On 05/18/2017 01:36 PM, Geert Uytterhoeven wrote: > Hi Andrew, > > On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn wrote: This most certainly works fine in the simple case where you have one PHY hanging off the MDIO bus, now what happens if you have several?

Re: [PATCH v2 net-next 1/2] include: linux: Add helper function to check phy interface mode

On 05/18/2017 03:13 PM, Iyappan Subramanian wrote: > Added helper function that checks phy_mode is RGMII (all variants) > 'bool phy_interface_mode_is_rgmii(phy_interface_t mode)' > > Changed the following function, to use the above. > 'bool phy_interface_is_rgmii(struct phy_device *phydev)' > >

[PATCH v2 net-next 2/2] drivers: net: xgene: Check all RGMII phy mode variants

This patch addresses the review comment from the previous patch set, by using phy_interface_mode_is_rgmii() helper function to address all RGMII phy mode variants. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- Review comment reference:

[PATCH v2 net-next 1/2] include: linux: Add helper function to check phy interface mode

Added helper function that checks phy_mode is RGMII (all variants) 'bool phy_interface_mode_is_rgmii(phy_interface_t mode)' Changed the following function, to use the above. 'bool phy_interface_is_rgmii(struct phy_device *phydev)' Signed-off-by: Iyappan Subramanian

[PATCH v2 net-next 0/2] Check all RGMII phy mode variants

This patch set, - adds phy_interface_mode_is_rgmii() helper function - addresses review comment from previous patch set, by calling phy_interface_mode_is_rgmii() to address all RGMII variants Signed-off-by: Iyappan Subramanian --- v2: Address review

Re: [PATCH v2 2/4] arp: decompose is_garp logic into a separate function

Hello, On Thu, 18 May 2017, Ihar Hrachyshka wrote: > The code is quite involving already to earn a separate function for > itself. If anything, it helps arp_process readability. > > Signed-off-by: Ihar Hrachyshka > --- > net/ipv4/arp.c | 35

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Andrew, On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn wrote: >> > This most certainly works fine in the simple case where you have one PHY >> > hanging off the MDIO bus, now what happens if you have several? >> > >> > Presumably, the first PHY that returns EPROBE_DEFER will

Re: [PATCH v5 net-next 4/7] net: add new control message for incoming HW-timestamped packets

On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar wrote: > Add SOF_TIMESTAMPING_OPT_PKTINFO option to request a new control message > for incoming packets with hardware timestamps. It contains the index of > the real interface which received the packet and the length of the

Re: [PATCH v4 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping

On Thu, May 18, 2017 at 9:06 AM, Miroslav Lichvar wrote: > Add SOF_TIMESTAMPING_OPT_TX_SWHW option to allow an outgoing packet to > be looped to the socket's error queue with a software timestamp even > when a hardware transmit timestamp is expected to be provided by the >

Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries

On 5/17/17 1:18 AM, Alexander Alemayhu wrote: > I have looked into this but found it to be not easy and all attempts to > change the Makefile has resulted in obscure errors :/ > > Getting clang to output in a different directory was easy[0], but I guess > this is not the right approach either.

[PATCH net-next] geneve: always fill CSUM6_RX configuration

CSMU6_RX is relevant for collect_metadata as well. As such leave it outside of the dev's IPv4/IPv6 checks. Fixes: 9b4437a5b870 ("geneve: Unify LWT and netdev handling.") Signed-off-by: Eric Garver --- drivers/net/geneve.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v2 4/4] arp: always override existing neigh entries with gratuitous ARP

Currently, when arp_accept is 1, we always override existing neigh entries with incoming gratuitous ARP replies. Otherwise, we override them only if new replies satisfy _locktime_ conditional (packets arrive not earlier than _locktime_ seconds since the last update to the neigh entry). The idea

[PATCH v2 2/4] arp: decompose is_garp logic into a separate function

The code is quite involving already to earn a separate function for itself. If anything, it helps arp_process readability. Signed-off-by: Ihar Hrachyshka --- net/ipv4/arp.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff

[PATCH v2 3/4] arp: postpone addr_type calculation to as late as possible

The addr_type retrieval can be costly, so it's worth trying to avoid its calculation as much as possible. This patch makes it calculated only for gratuitous ARP packets. This is especially important since later we may want to move is_garp calculation outside of arp_accept block, at which point the

[PATCH v2 1/4] arp: fixed error in a comment

the is_garp code deals just with gratuitous ARP packets, not every unsolicited packet. This patch is a result of a discussion in netdev: http://marc.info/?l=linux-netdev=149506354216994 Suggested-by: Julian Anastasov Signed-off-by: Ihar Hrachyshka ---

[PATCH v2 0/4] arp: always override existing neigh entries with gratuitous ARP

This patchset is spurred by discussion started at https://patchwork.ozlabs.org/patch/760372/ where we figured that there is no real reason for enforcing override by gratuitous ARP packets only when arp_accept is 1. Same should happen when it's 0 (the default value). changelog v2: handled review

Re: [PATCH v5 net-next 5/7] net: fix documentation of struct scm_timestamping

On Thu, May 18, 2017 at 10:07 AM, Miroslav Lichvar wrote: > The scm_timestamping struct may return multiple non-zero fields, e.g. > when both software and hardware RX timestamping is enabled, or when the > SO_TIMESTAMP(NS) option is combined with SCM_TIMESTAMPING and a false

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

> > This most certainly works fine in the simple case where you have one PHY > > hanging off the MDIO bus, now what happens if you have several? > > > > Presumably, the first PHY that returns EPROBE_DEFER will make the entire > > bus registration return EPROB_DEFER as well, and so on, and so

Paper: A Comparison of TCP Implementations, Linux vs. lwIP

Hello, Some months ago I wrote a paper on a Comparison of TCP Implementations. (Features, Code Quality, Data Structures, etc.) https://github.com/richi235/A-Comparison-of-TCP-Implementations It's finished and the corresponding exam successfully passed. But I thought perhaps this could be

Re: [PATCH net-next] net/mlx5e: Fix possible memory leak

From: Wei Yongjun Date: Thu, 18 May 2017 15:34:41 + > From: Wei Yongjun > > 'encap_header' is malloced and should be freed before leaving from > the error handling cases, otherwise it will cause memory leak. > > Fixes: 232c001398ae ("net/mlx5e:

Re: [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

From: Wei Yongjun Date: Thu, 18 May 2017 15:24:52 + > From: Wei Yongjun > > Add the missing unlock before return from function __ibmvnic_reset() > in the error handling case. > > Fixes: ed651a10875f ("ibmvnic: Updated reset handling") >

Re: [PATCH net-next] qed: Remove unused including

From: Wei Yongjun Date: Thu, 18 May 2017 15:26:29 + > From: Wei Yongjun > > Remove including that is not needed. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Florian, On Thu, May 18, 2017 at 8:25 PM, Florian Fainelli wrote: > On 05/18/2017 05:59 AM, Geert Uytterhoeven wrote: >> If an Ethernet PHY is initialized before the interrupt controller it is >> connected to, a message like the following is printed: >> >> irq: no

Re: [PATCH] net1080: Remove unused function nc_dump_ttl()

From: Matthias Kaehlcke Date: Thu, 18 May 2017 10:57:19 -0700 > The function is not used, removing it fixes the following warning when > building with clang: > > drivers/net/usb/net1080.c:271:20: error: unused function > 'nc_dump_ttl' [-Werror,-Wunused-function] > > Also

Re: [PATCH] r8152: Remove unused function usb_ocp_read()

From: Matthias Kaehlcke Date: Thu, 18 May 2017 10:45:33 -0700 > The function is not used, removing it fixes the following warning when > building with clang: > > drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read' > [-Werror,-Wunused-function] > >

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

Implementations (still in Python for now) at https://gist.github.com/ecree-solarflare/0665d5b46c2d8d08de2377fbd527de8d (I left out division, because it's so weak.) I still can't prove + and - are correct, but they've passed every test case I've come up with so far. * seems pretty obviously

Re: [PATCH net-next] xen/9pfs: p9_trans_xen_init and p9_trans_xen_exit can be static

On Thu, 18 May 2017, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warnings: > > net/9p/trans_xen.c:528:5: warning: > symbol 'p9_trans_xen_init' was not declared. Should it be static? > net/9p/trans_xen.c:540:6: warning: > symbol

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On 05/18/2017 05:59 AM, Geert Uytterhoeven wrote: > If an Ethernet PHY is initialized before the interrupt controller it is > connected to, a message like the following is printed: > > irq: no irq domain found for /interrupt-controller@e61c ! > > However, the actual error is ignored,

[PATCH net] tcp: initialize rcv_mss to TCP_MIN_MSS instead of 0

From: Wei Wang When tcp_disconnect() is called, inet_csk_delack_init() sets icsk->icsk_ack.rcv_mss to 0. This could potentially cause tcp_recvmsg() => tcp_cleanup_rbuf() => __tcp_select_window() call path to have division by 0 issue. So this patch initializes rcv_mss to

Re: [PATCH linux-firmware] qed: Add firmware 8.20.0.0

On Wed, May 17, 2017 at 02:39:24PM +0300, Yuval Mintz wrote: > The new QED firmware has 2 main purposes - > First, it contains fixes to various initializations and firmware > logic including: > - Corrects iSCSI fast retransmit when data digest is enabled. > - Stop draining packets when receiving

[GIT] Networking

1) Don't allow negative TCP reordering values, from Soheil Hassas Yeganeh. 2) Don't overflow while parsing ipv6 header options, from Craig Gallek. 3) Handle more cleanly the case where an individual route entry during a dump will not fit into the allocated netlink SKB, from David Ahern. 4)

[PATCH] net1080: Remove unused function nc_dump_ttl()

The function is not used, removing it fixes the following warning when building with clang: drivers/net/usb/net1080.c:271:20: error: unused function 'nc_dump_ttl' [-Werror,-Wunused-function] Also remove the definition of TTL_THIS, which is only used in nc_dump_ttl() Signed-off-by: Matthias

[PATCH] r8152: Remove unused function usb_ocp_read()

The function is not used, removing it fixes the following warning when building with clang: drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- drivers/net/usb/r8152.c | 6 -- 1 file

Re: [net-intel-i40e] question about assignment overwrite

Hi Jeff, Quoting Jeff Kirsher : On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: While looking into Coverity ID 1408956 I ran into the following piece   of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807: 8807    if (pf->hw.mac.type ==

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Andrew, On Thu, May 18, 2017 at 6:33 PM, Andrew Lunn wrote: >> >> phy = get_phy_device(mdio, addr, is_c45); >> >> if (IS_ERR(phy)) >> >> - return; >> >> + return PTR_ERR(phy); >> >> >> >> - rc = irq_of_parse_and_map(child, 0); >>

Re: [Patch RFC net-next] net: usb: r8152: Fix rx_bytes/tx_bytes to include FCS

Hi Florian I agree we should define this, and we can add it to Documentation/ABI/testing/sysfs-class-net-statistics > - BQL cares about bytes sent on the wire, so that should not include > pre/appended descriptors nor the FCS (nor the Ethernet preamble), > tx_bytes should be equivalent to that

Re: [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

On 05/18/2017 10:24 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock before return from function __ibmvnic_reset() > in the error handling case. > > Fixes: ed651a10875f ("ibmvnic: Updated reset handling") > Signed-off-by: Wei Yongjun

Re: [PATCH v2 net-next] qed: Utilize FW 8.20.0.0

From: Yuval Mintz Date: Thu, 18 May 2017 19:41:04 +0300 > This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 > firmware. The changes are mostly contained in qed with minor changes > to qedi due to some HSI changes. > > Content-wise, the firmware

Re: [PATCH net-next] tcp: fix tcp_rearm_rto()

From: Eric Dumazet Date: Thu, 18 May 2017 09:15:58 -0700 > From: Eric Dumazet > > skbs in (re)transmit queue no longer have a copy of jiffies > at the time of the transmit : skb->skb_mstamp is now in usec unit, > with no correlation to

Re: [Patch RFC net-next] net: usb: r8152: Fix rx_bytes/tx_bytes to include FCS

On 05/18/2017 08:22 AM, David Miller wrote: > From: Andrew Lunn > Date: Thu, 18 May 2017 17:09:25 +0200 > >> Since these are software counters, they can be consistent. From a >> practical point of view, i doubt they ever will all be consistent, >> there are simply too many

Re: [PATCH net-next] tcp: fix tcp_rearm_rto()

On Thu, May 18, 2017 at 12:15 PM, Eric Dumazet wrote: > From: Eric Dumazet > > skbs in (re)transmit queue no longer have a copy of jiffies > at the time of the transmit : skb->skb_mstamp is now in usec unit, > with no correlation to tcp_jiffies32. > >

Re: [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

Hi David, El Thu, May 18, 2017 at 10:48:08AM -0400 David Miller ha dit: > From: Matthias Kaehlcke > Date: Wed, 17 May 2017 15:17:08 -0700 > > > The function is not used, but it looks useful for debugging. Adding the > > attribute fixes the following clang warning: > > > >

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

On 18/05/17 15:49, Edward Cree wrote: > Here's one idea that seemed to work when I did a couple of experiments: > let A = (a;am), B = (b;bm) where the m are the masks > Σ = am + bm + a + b > χ = Σ ^ (a + b) /* unknown carries */ > μ = χ | am | bm /* mask of result */ > then A + B = ((a + b) & ~μ;

Re: [PATCH 2/2] sh_eth: Do not print an error message for probe deferral

On 05/18/2017 04:01 PM, Geert Uytterhoeven wrote: EPROBE_DEFER is not an error, hence printing an error message like sh-eth ee70.ethernet: failed to initialise MDIO may confuse the user. To fix this, suppress the error message in case of probe deferral. While at it, shorten the

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

> >> phy = get_phy_device(mdio, addr, is_c45); > >> if (IS_ERR(phy)) > >> - return; > >> + return PTR_ERR(phy); > >> > >> - rc = irq_of_parse_and_map(child, 0); > >> + rc = of_irq_get(child, 0); > >> + if (rc == -EPROBE_DEFER) { > >> +

Re: [PATCH 1/2] sh_eth: Use platform device for printing before register_netdev()

On 05/18/2017 04:01 PM, Geert Uytterhoeven wrote: The MDIO initialization failure message is printed using the network device, before it has been registered, leading to: (null): failed to initialise MDIO Use the platform device instead to fix this: sh-eth ee70.ethernet: failed

[PATCH net-next] net: sched: provide stubs for tcf_chain_{get,put} for CONFIG_NET_CLS=n

This also changes tcf_chain_get() to return an error pointer instead of NULL, so that tcf_action_goto_chain_init() can differentiate memory allocation failure from lack of support. Fixes: 5bc1701881e3 ("net: sched: introduce multichain support for filters") Signed-off-by: Sabrina Dubroca

[PATCH net-next] tcp: fix tcp_rearm_rto()

From: Eric Dumazet skbs in (re)transmit queue no longer have a copy of jiffies at the time of the transmit : skb->skb_mstamp is now in usec unit, with no correlation to tcp_jiffies32. We have to convert rto from jiffies to usec, compute a time difference in usec, then

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Andrew, On Thu, May 18, 2017 at 6:09 PM, Andrew Lunn wrote: > On Thu, May 18, 2017 at 02:59:05PM +0200, Geert Uytterhoeven wrote: >> If an Ethernet PHY is initialized before the interrupt controller it is >> connected to, a message like the following is printed: >> >> irq:

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On Thu, May 18, 2017 at 02:59:05PM +0200, Geert Uytterhoeven wrote: > If an Ethernet PHY is initialized before the interrupt controller it is > connected to, a message like the following is printed: > > irq: no irq domain found for /interrupt-controller@e61c ! > > However, the actual

Re: [PATCH] xfrm: fix state migration replay sequence numbers

On 2017-05-18 16:39, Antony Antony wrote: > During xfrm migration replay and preplay sequence numbers are not > copied from the previous state. > > Here is tcpdump output showing the problem. > 10.0.10.46 is running vanilla kernel, IKE/IPsec responder. > After the migration it sent wrong

Re: [PATCH net-next] net/mlx5e: Fix possible memory leak

On Thu, May 18, 2017 at 03:34:41PM +, Wei Yongjun wrote: > From: Wei Yongjun > > 'encap_header' is malloced and should be freed before leaving from > the error handling cases, otherwise it will cause memory leak. > > Fixes: 232c001398ae ("net/mlx5e: Add support to

[PATCH net-next] xfrm: Make function xfrm_dev_register static

From: Wei Yongjun Fixes the following sparse warning: net/xfrm/xfrm_device.c:141:5: warning: symbol 'xfrm_dev_register' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/xfrm/xfrm_device.c | 2 +- 1 file changed, 1

Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

Hi Nikolay, Nikolay Aleksandrov writes: >> OK good to know. That intention wasn't obvious. I can make __br_mdb_del >> return void instead? What about the rest of the patchset if I do so? > > If you make it return void we will not be able to return proper error value

[RFC net-next PATCH 5/5] mlx5: add XDP rxhash feature for driver mlx5

--- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |3 + drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 98 ++--- 2 files changed, 70 insertions(+), 31 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c

[RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

Introducing a new XDP feature and associated bpf helper bpf_xdp_rxhash. The rxhash and type allow filtering on packets without touching packet memory. The performance difference on my system with a 100 Gbit/s mlx5 NIC is 12Mpps to 19Mpps. TODO: desc RXHASH and associated type, and how XDP

[RFC net-next PATCH 3/5] net: introduce XDP driver features interface

There is a fundamental difference between normal eBPF programs and (XDP) eBPF programs getting attached in a driver. For normal eBPF programs it is easy to add a new bpf feature, like a bpf helper, because is it strongly tied to the feature being available in the current core kernel code. When

[RFC net-next PATCH 2/5] mlx5: fix bug reading rss_hash_type from CQE

Masks for extracting part of the Completion Queue Entry (CQE) field rss_hash_type was swapped, namely CQE_RSS_HTYPE_IP and CQE_RSS_HTYPE_L4. The bug resulted in setting skb->l4_hash, even-though the rss_hash_type indicated that hash was NOT computed over the L4 (UDP or TCP) part of the packet.

[RFC net-next PATCH 0/5] XDP driver feature API and handling change to xdp_buff

I would like some comments on introducing a feature API between XDP drives and XDP/BPF core. The primary issue is when extending struct xdp_buff, today, drivers not implementing this feature can access uninitilized memory, using bpf-helper associated with the feature. --- Jesper Dangaard Brouer

[RFC net-next PATCH 1/5] samples/bpf: xdp_tx_iptunnel make use of map_data[]

There is no reason to use a compile time constant MAX_IPTNL_ENTRIES shared between the _user.c and _kern.c, when map_data[].def.max_entries can tell us dynamically what the max_entries were of the ELF map that the bpf loaded created. Signed-off-by: Jesper Dangaard Brouer ---

[PATCH net-next] net/mlx5e: Fix possible memory leak

From: Wei Yongjun 'encap_header' is malloced and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update flow") Signed-off-by: Wei Yongjun

Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path

From: Colin King Date: Thu, 18 May 2017 15:07:02 +0100 > From: Colin Ian King > > Set chain to null after the call to tcf_chain_destroy so that we don't > call tcf_chain_put on the error exit path, thus avoiding a use-after-free > error. > >

Re: [PATCH net-next 5/6] net: bridge: get msgtype from nlmsghdr in mdb ops

On 5/18/17 12:27 AM, Vivien Didelot wrote: Retrieve the message type from the nlmsghdr structure instead of hardcoding it in both br_mdb_add and br_mdb_del. Signed-off-by: Vivien Didelot --- net/bridge/br_mdb.c | 10 ++ 1 file changed, 6

RE: [PATCH net-next] qed: Utilize FW 8.20.0.0

> >> This pushes qed [and as result, all qed* drivers] into using 8.20.0.0 > >> firmware. The changes are mostly contained in qed with minor changes > >> to qedi due to some HSI changes. > >> > >> Content-wise, the firmware contains fixes to various issues exposed > >> since the release of the

Re: [patch net] mlxsw: spectrum: Avoid possible NULL pointer dereference

From: Jiri Pirko Date: Thu, 18 May 2017 13:03:52 +0200 > From: Ido Schimmel > > In case we got an FDB notification for a port that doesn't exist we > execute an FDB entry delete to prevent it from re-appearing the next > time we poll for notifications. >

[PATCH net-next] qed: Remove unused including

From: Wei Yongjun Remove including that is not needed. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/qlogic/qed/qed_fcoe.c | 1 - drivers/net/ethernet/qlogic/qed/qed_iscsi.c | 1 - drivers/net/ethernet/qlogic/qed/qed_l2.c| 1 -

Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

On 5/18/17 6:08 PM, Vivien Didelot wrote: Hi Nikolay, Nikolay Aleksandrov writes: err = __br_mdb_del(br, entry); - if (!err) - __br_mdb_notify(dev, p, entry, RTM_DELMDB); +

Re: [PATCH] liquidio: make the spinlock octeon_devices_lock static

From: Colin King Date: Thu, 18 May 2017 10:14:01 +0100 > From: Colin Ian King > > octeon_devices_lock can be made static as it does not need to be > in global scope. > > Cleans up sparse warning: "warning: symbol 'octeon_devices_lock' > was

[PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

From: Wei Yongjun Add the missing unlock before return from function __ibmvnic_reset() in the error handling case. Fixes: ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/ibm/ibmvnic.c | 1 + 1

Re: [Patch RFC net-next] net: usb: r8152: Fix rx_bytes/tx_bytes to include FCS

From: Andrew Lunn Date: Thu, 18 May 2017 17:09:25 +0200 > Since these are software counters, they can be consistent. From a > practical point of view, i doubt they ever will all be consistent, > there are simply too many drivers to test and change if > needed. However, for the

[PATCH net-next] xen/9pfs: p9_trans_xen_init and p9_trans_xen_exit can be static

From: Wei Yongjun Fixes the following sparse warnings: net/9p/trans_xen.c:528:5: warning: symbol 'p9_trans_xen_init' was not declared. Should it be static? net/9p/trans_xen.c:540:6: warning: symbol 'p9_trans_xen_exit' was not declared. Should it be static?

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

From: Geert Uytterhoeven Date: Thu, 18 May 2017 14:59:05 +0200 > If an Ethernet PHY is initialized before the interrupt controller it is > connected to, a message like the following is printed: > > irq: no irq domain found for /interrupt-controller@e61c ! > >

Re: [PATCH 1/2] sh_eth: Use platform device for printing before register_netdev()

From: Geert Uytterhoeven Date: Thu, 18 May 2017 15:01:34 +0200 > The MDIO initialization failure message is printed using the network > device, before it has been registered, leading to: > > (null): failed to initialise MDIO > > Use the platform device instead to

Re: [PATCH 2/2] sh_eth: Do not print an error message for probe deferral

From: Geert Uytterhoeven Date: Thu, 18 May 2017 15:01:35 +0200 > EPROBE_DEFER is not an error, hence printing an error message like > > sh-eth ee70.ethernet: failed to initialise MDIO > > may confuse the user. > > To fix this, suppress the error message in

Re: [PATCH] net: ieee802154: fix net_device reference release too early

Hello. On Thu, 2017-05-18 at 15:14, Stefan Schmidt wrote: > Hello. > > On Thu, 2017-05-18 at 15:50, linzhang wrote: > > This patch fixes the kernel oops when release net_device reference in > > advance. In function raw_sendmsg(i think the dgram_sendmsg has the same > > problem), there is a

Re: [PATCH net-next] geneve: add rtnl changelink support

TL DR; There is indeed a race between geneve_changelink() and geneve transmit path w.r.t attributes being changed and the old value of those attributes being used in the transmit patch. I will resubmit V2 of the patch with those issues addressed. Thanks! Please see in-line for my other

Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

Hi Nikolay, Nikolay Aleksandrov writes: >> err = __br_mdb_del(br, entry); >> -if (!err) >> -__br_mdb_notify(dev, p, entry, RTM_DELMDB); >> +if (err) >> +

Re: [Patch RFC net-next] net: usb: r8152: Fix rx_bytes/tx_bytes to include FCS

> I am afraid that we won't be able to enforce a consistent behavior, > because the HW itself is not consistent, both on the NIC and on the > switch side. Hi Florian I agree with that, for MIB counters. They tend to come direct from the hardware. However, rx_bytes and tx_bytes are not from the

Re: [PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans

On Thu, May 18, 2017 at 09:31:05AM -0400, Vladislav Yasevich wrote: > Since virtio does not provide it's own ndo_features_check handler, > TSO, and now checksum offload, are disabled for stacked vlans. > Re-enable the support and let the host take care of it. This > restores/improves

Re: [patch net 0/2] mlxsw: couple of fixes

From: Jiri Pirko Date: Thu, 18 May 2017 09:18:51 +0200 > Couple of fixes from Arkadi Series applied.

Re: [patch net-next] mlxsw: spectrum_dpipe: Fix sparse warnings

From: Jiri Pirko Date: Thu, 18 May 2017 09:22:45 +0200 > From: Arkadi Sharshevsky > > drivers/net/ethernet/mellanox/mlxsw//spectrum_dpipe.c:221:52: warning: > Using plain integer as NULL pointer >

Re: [PATCH v3] net: dsa: b53: Add compatible strings for the Cygnus-family BCM11360.

From: Eric Anholt Date: Wed, 17 May 2017 17:32:12 -0700 > Cygnus is a small family of SoCs, of which we currently have > devicetree for BCM11360 and BCM58300. The 11360's B53 is mostly the > same as 58xx, just requiring a tiny bit of setup that was previously > missing. > >

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On Thu, 18 May 2017 12:02:07 +0200 Daniel Borkmann wrote: > On 05/16/2017 06:36 PM, Stephen Hemminger wrote: > > On Sat, 13 May 2017 19:29:57 -0600 > > David Ahern wrote: > > > >> On 5/4/17 2:43 PM, Phil Sutter wrote: > >>> So in summary, given that

admin

ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Fw: [Bug 195807] New: general protection fault in ping_v4_sendmsg

Begin forwarded message: Date: Thu, 18 May 2017 03:36:33 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 195807] New: general protection fault in ping_v4_sendmsg https://bugzilla.kernel.org/show_bug.cgi?id=195807 Bug ID: 195807

Re: [PATCH v2 1/3] bpf: Use 1<<16 as ceiling for immediate alignment in verifier.

On 18/05/17 03:48, Alexei Starovoitov wrote: > Would it be easier to represent this logic via (mask_of_unknown, value) > instead of (mask0, mask1) ? Yes, I like this. > As far as upper bits we can tweak the algorithm to eat into > one or more bits of known bits due to carry. > Like > 00xx11 +

Re: [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

From: Matthias Kaehlcke Date: Wed, 17 May 2017 15:17:08 -0700 > The function is not used, but it looks useful for debugging. Adding the > attribute fixes the following clang warning: > > drivers/net/usb/net1080.c:271:20: error: unused function > 'nc_dump_ttl'

Re: [PATCH v2] e1000e: Don't return uninitialized stats

From: Benjamin Poirier Date: Wed, 17 May 2017 16:24:13 -0400 > Some statistics passed to ethtool are garbage because e1000e_get_stats64() > doesn't write them, for example: tx_heartbeat_errors. This leaks kernel > memory to userspace and confuses users. > > Do like ixgbe and

[PATCH] xfrm: fix state migration replay sequence numbers

During xfrm migration replay and preplay sequence numbers are not copied from the previous state. Here is tcpdump output showing the problem. 10.0.10.46 is running vanilla kernel, IKE/IPsec responder. After the migration it sent wrong sequence number, reset to 1. The migration is from 10.0.0.52

  1   2   >