Re: [patch net-next 2/2] net/sched: fix filter flushing

Sun, May 21, 2017 at 02:16:45AM CEST, xiyou.wangc...@gmail.com wrote: >On Sat, May 20, 2017 at 6:01 AM, Jiri Pirko wrote: >> +static void tcf_chain_destroy(struct tcf_chain *chain) >> +{ >> + list_del(>list); >> + tcf_chain_flush(chain); >> kfree(chain); >>

[PATCH iproute2] devlink: Add option to set and show eswitch encapsulation support

This is an e-switch global knob to enable HW support for applying encapsulation/decapsulation to VF traffic as part of SRIOV e-switch offloading. The actual encap/decap is carried out (along with the matching and other actions) per offloaded e-switch rules, e.g as done when offloading the TC

Re: [PATCH net-next] geneve: always fill CSUM6_RX configuration

On Sat, May 20, 2017 at 6:35 AM, Eric Garver wrote: > On Fri, May 19, 2017 at 06:57:46PM -0700, Pravin Shelar wrote: >> On Thu, May 18, 2017 at 12:59 PM, Eric Garver wrote: >> > CSMU6_RX is relevant for collect_metadata as well. As such leave it >> > outside of the

Re: BPF relocations

On Fri, 12 May 2017, David Miller wrote: > Internally, we have to emit some kind of relocation as GAS makes it's > first pass over the instructions. Not really, you can defer that until the relaxation pass, e.g. to avoid figuring out what to do about forward local symbol references, especially

Deleting a dynamic mac entry..

Hello, In 3.19 the following bridge fdb command to delete a dynamically learned entry fails.. root@net-3:~# bridge fdb show | grep 02:42:0a:ff:00:06 02:42:0a:ff:00:06 dev vxlan0 master br0 root@net-3:~# bridge fdb del 02:42:0a:ff:00:06 dev vxlan0 master RTNETLINK answers: No such file or

[PATCH net-next v6] net: ipv6: fix code style error and warning of ndisc.c

From: yuan linyu CC: Joe Perches Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 324 +-- 1 file changed, 173 insertions(+), 151 deletions(-) diff --git

Re: [RFC net-next PATCH 3/5] net: introduce XDP driver features interface

On 05/20/2017 09:53 AM, Jesper Dangaard Brouer wrote: On Fri, 19 May 2017 19:13:29 +0200 Daniel Borkmann wrote: On 05/18/2017 05:41 PM, Jesper Dangaard Brouer wrote: There is a fundamental difference between normal eBPF programs and (XDP) eBPF programs getting attached

[PATCH net-next v5] net: ipv6: fix code style error and warning of ndisc.c

From: yuan linyu diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d310dc4..5cf25bc 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -12,8 +12,7 @@ * 2 of the License, or (at your option) any later version. */ -/* - * Changes: +/*

Re: [patch net-next 2/2] net/sched: fix filter flushing

On Sat, May 20, 2017 at 6:01 AM, Jiri Pirko wrote: > +static void tcf_chain_destroy(struct tcf_chain *chain) > +{ > + list_del(>list); > + tcf_chain_flush(chain); > kfree(chain); > } > > @@ -510,7 +517,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb,

[PATCH] include stdint.h explicitly for UINT16_MAX)

Fixes | tc_core.c:190:29: error: 'UINT16_MAX' undeclared (first use in this function); did you mean '__INT16_MAX__'? |if ((sz >> s->size_log) > UINT16_MAX) { | ^~ Signed-off-by: Khem Raj --- tc/tc_core.c | 1 + 1 file changed, 1

Re: [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar wrote: > The following series introduces a new harware offload mode in tc/mqprio Wait, we have already a HW QoS model introduced by John F and Co couple of years ago, right? Please elaborate in few sentence if you are

Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

Hi Daniel and Kees, Before I send the patch, I have tested the JIT compiler on ARMv7 but not on ARMv5 or ARMv6. So can you tell me which arch versions I should test it for? Also for my testing, CONFIG_FRAME_POINTER and CONFIG_CPU_BIG_ENDIAN are both disabled. But I need to test JIT with these

Re: [RFC net-next PATCH 4/5] net: new XDP feature for reading HW rxhash from drivers

On Thu, May 18, 2017 at 8:41 AM, Jesper Dangaard Brouer wrote: > Introducing a new XDP feature and associated bpf helper bpf_xdp_rxhash. > > The rxhash and type allow filtering on packets without touching > packet memory. The performance difference on my system with a > 100

Re: [PATCH net-next v4] net: ipv6: fix code style error and warning of ndisc.c

On Sat, 2017-05-20 at 21:57 +0800, yuan linyu wrote: > From: yuan linyu [] > diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c [] > @@ -240,13 +240,15 @@ struct ndisc_options *ndisc_parse_options(const struct > net_device *dev, >

[PATCH 2/2] vhost/scsi: Delete error messages for failed memory allocations in five functions

From: Markus Elfring Date: Sat, 20 May 2017 15:50:30 +0200 Omit seven extra messages for memory allocation failures in these functions. This issue was detected by using the Coccinelle software. Link:

[PATCH 0/2] vhost/scsi: Adjustments for five function implementations

From: Markus Elfring Date: Sat, 20 May 2017 16:25:04 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Improve a size determination in four functions Delete error messages for failed memory allocations

[PATCH 1/2] vhost/scsi: Improve a size determination in four functions

From: Markus Elfring Date: Sat, 20 May 2017 13:48:44 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

[PATCH net-next v4] net: ipv6: fix code style error and warning of ndisc.c

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 310 +-- 1 file changed, 163 insertions(+), 147 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c

[PATCH net-next v3] net: ipv6: fix code style error and warning of ndisc.c

From: yuan linyu Signed-off-by: yuan linyu --- net/ipv6/ndisc.c | 310 +-- 1 file changed, 163 insertions(+), 147 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c

Re: [PATCH net-next] geneve: always fill CSUM6_RX configuration

On Fri, May 19, 2017 at 06:57:46PM -0700, Pravin Shelar wrote: > On Thu, May 18, 2017 at 12:59 PM, Eric Garver wrote: > > CSMU6_RX is relevant for collect_metadata as well. As such leave it > > outside of the dev's IPv4/IPv6 checks. > > > Can you explain it bit? is this flag used

[patch net-next 1/2] net/sched: properly assign RCU pointer in tcf_chain_tp_insert/remove

From: Jiri Pirko *p_filter_chain is rcu-dereferenced on reader path. So here in writer, property assign the pointer. Fixes: 2190d1d0944f ("net: sched: introduce helpers to work with filter chains") Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 4

[patch net-next 2/2] net/sched: fix filter flushing

From: Jiri Pirko When user instructs to remove all filters from chain, we cannot destroy the chain as other actions may hold a reference. Also the put in errout would try to destroy it again. So instead, just walk the chain and remove all existing filters. Fixes: 5bc1701881e3

[PATCH net] netfilter: do not hold dev in ipt_CLUSTERIP

It's a terrible thing to hold dev in iptables target. When the dev is being removed, unregister_netdevice has to wait for the dev to become free. dmesg will keep logging the err: kernel:unregister_netdevice: waiting for veth0_in to become free. \ Usage count = 1 until iptables rules with

Re: [RFC net-next PATCH 3/5] net: introduce XDP driver features interface

On Fri, 19 May 2017 19:13:29 +0200 Daniel Borkmann wrote: > On 05/18/2017 05:41 PM, Jesper Dangaard Brouer wrote: > > There is a fundamental difference between normal eBPF programs > > and (XDP) eBPF programs getting attached in a driver. For normal > > eBPF programs it is

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

On Sat, May 20, 2017 at 09:06:16AM +0200, Ivan Vecera wrote: > 2017-05-20 7:57 GMT+02:00 Hangbin Liu : > > On Fri, May 19, 2017 at 07:30:43PM +0200, Ivan Vecera wrote: > >> Current bridge code incorrectly handles starting/stopping of hello and > >> hold timers during STP

Re: [PATCH] net: sched: fix a use-after-free error on chain on the error exit path

Fri, May 19, 2017 at 07:17:59PM CEST, xiyou.wangc...@gmail.com wrote: >On Thu, May 18, 2017 at 7:07 AM, Colin King wrote: >> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c >> index 4020b8d932a1..82ebdc3fcb2e 100644 >> --- a/net/sched/cls_api.c >> +++

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

2017-05-20 7:57 GMT+02:00 Hangbin Liu : > On Fri, May 19, 2017 at 07:30:43PM +0200, Ivan Vecera wrote: >> Current bridge code incorrectly handles starting/stopping of hello and >> hold timers during STP enable/disable. >> >> 1. Timers are stopped in br_stp_start() during

Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping

On 5/20/17 8:57 AM, Hangbin Liu wrote: On Fri, May 19, 2017 at 07:30:43PM +0200, Ivan Vecera wrote: Current bridge code incorrectly handles starting/stopping of hello and hold timers during STP enable/disable. 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP transition. The

Re: [PATCH net-next 6/9] xfrm: make xfrm_dev_register static

On Fri, May 19, 2017 at 09:55:53AM -0700, Stephen Hemminger wrote: > This function is only used in this file and should not be global. > > Signed-off-by: Stephen Hemminger > --- > net/xfrm/xfrm_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff