[PATCHv2 iproute2 net-next] ip neigh: allow flush FAILED neighbour entry

2017-06-15 Thread Hangbin Liu
After upstream commit 5071034e4af7 ('neigh: Really delete an arp/neigh entry on "ip neigh delete" or "arp -d"'), we could delete a single FAILED neighbour entry now. But `ip neigh flush` still skip the FAILED entry. Move the filter after first round flush so we can flush FAILED entry on fixed

RE: [PATCH net-next v2 0/2] r8152: adjust runtime suspend/resume

2017-06-15 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, June 14, 2017 1:02 AM > > v2: > > For #1, replace GFP_KERNEL with GFP_NOIO for usb_submit_urb(). > > > > v1: > > Improve the flow about runtime suspend/resume and make the code > > easy to read. > > Series applied. Excuse me. I don't

Re: [PATCH net-next 00/10] mlx4 XDP performance improvements

2017-06-15 Thread David Miller
From: Tariq Toukan Date: Thu, 15 Jun 2017 14:35:30 +0300 > This patchset contains data-path improvements, mainly for XDP_DROP > and XDP_TX cases. > > Main patches: > * Patch 2 by Saeed allows enabling optimized A0 RX steering (in HW) when > setting a single RX ring. >

Re: [pull request][net 0/6] Mellanox mlx5 fixes 2017-06-14

2017-06-15 Thread David Miller
From: Saeed Mahameed Date: Thu, 15 Jun 2017 23:55:24 +0300 > This series contains some fixes for the mlx5 core and netdev driver. > > Please pull and let me know if there's any problem. Pulled. > For -stable: > ("net/mlx5: Wait for FW readiness before initializing command

Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg

2017-06-15 Thread Joe Perches
On Thu, 2017-06-15 at 18:49 -0700, Jay Vosburgh wrote: > Joe Perches wrote: > > > On Thu, 2017-06-15 at 19:14 +0100, Michael J Dilmore wrote: > > > Multiple netdev_info messages clutter kernel output. Also add netdev_dbg > > > for packets per slave. > > > > [] > > > diff

Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg

2017-06-15 Thread Jay Vosburgh
Joe Perches wrote: >On Thu, 2017-06-15 at 19:14 +0100, Michael J Dilmore wrote: >> Multiple netdev_info messages clutter kernel output. Also add netdev_dbg for >> packets per slave. >[] >> diff --git a/drivers/net/bonding/bond_options.c >> b/drivers/net/bonding/bond_options.c

Re: [PATCH v4 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-06-15 Thread Ding Tianhong
On 2017/6/13 5:28, Alexander Duyck wrote: > On Mon, Jun 12, 2017 at 4:05 AM, Ding Tianhong > wrote: ... >> /** >> + * pcie_clear_relaxed_ordering - clear PCI Express relaxed ordering bit >> + * @dev: PCI device to query >> + * >> + * If possible clear relaxed ordering

[PATCH v3 1/2] tcp: md5: add an address prefix for key lookup

2017-06-15 Thread Ivan Delalande
This allows the keys used for TCP MD5 signature to be used for whole range of addresses, specified with a prefix length, instead of only one address as it currently is. Signed-off-by: Bob Gilligan Signed-off-by: Eric Mowat Signed-off-by: Ivan Delalande

[PATCH v3 2/2] tcp: md5: add TCP_MD5SIG_EXT socket option to set a key address prefix

2017-06-15 Thread Ivan Delalande
Replace first padding in the tcp_md5sig structure with a new flag field and address prefix length so it can be specified when configuring a new key for TCP MD5 signature. The tcpm_flags field will only be used if the socket option is TCP_MD5SIG_EXT to avoid breaking existing programs, and

Re: [PATCH v3 net-next 8/9] bpf: nfp: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Jakub Kicinski
On Thu, 15 Jun 2017 17:29:16 -0700, Martin KaFai Lau wrote: > Add support to nfp to report bpf_prog ID during XDP_QUERY_PROG. > > Signed-off-by: Martin KaFai Lau > Cc: Jakub Kicinski > Acked-by: Alexei Starovoitov > Acked-by: Daniel

Re: [PATCH net-next] net: dsa: add cross-chip multicast support

2017-06-15 Thread Florian Fainelli
On 06/15/2017 01:14 PM, Vivien Didelot wrote: > Similarly to how cross-chip VLAN works, define a bitmap of multicast > group members for a switch, now including its DSA ports, so that > multicast traffic can be sent to all switches of the fabric. > > A switch may drop the frames if no user port

[PATCH v3 net-next 9/9] bpf: qede: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to qede to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Mintz Yuval Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/qlogic/qede/qede_filter.c

[PATCH v3 net-next 6/9] bpf: thunderx: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to thunderx to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Sunil Goutham Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann ---

[PATCH v3 net-next 3/9] bpf: mlx5e: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to mlx5e to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Tariq Toukan Cc: Saeed Mahameed Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann Acked-by:

[PATCH v3 net-next 4/9] bpf: virtio_net: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to virtio_net to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: John Fastabend Cc: Jason Wang Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann ---

[PATCH v3 net-next 7/9] bpf: ixgbe: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to ixgbe to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Alexander Duyck Cc: John Fastabend Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann

[PATCH v3 net-next 0/9] bpf: xdp: Report bpf_prog ID in IFLA_XDP

2017-06-15 Thread Martin KaFai Lau
This is the first usage of the new bpf_prog ID. It is for reporting the ID of a xdp_prog through netlink. It rides on the existing IFLA_XDP. This patch adds IFLA_XDP_PROG_ID for the bpf_prog ID reporting. It starts with changing the generic_xdp first. After that, the hardware driver is

[PATCH v3 net-next 2/9] bpf: mlx4: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to mlx4 to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Tariq Toukan Cc: Saeed Mahameed Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann ---

[PATCH v3 net-next 5/9] bpf: bnxt: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to bnxt to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Michael Chan Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann ---

[PATCH v3 net-next 8/9] bpf: nfp: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-15 Thread Martin KaFai Lau
Add support to nfp to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Jakub Kicinski Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann ---

[PATCH v3 net-next 1/9] net: Add IFLA_XDP_PROG_ID

2017-06-15 Thread Martin KaFai Lau
Expose prog_id through IFLA_XDP_PROG_ID. This patch makes modification to generic_xdp. The later patches will modify other xdp-supported drivers. prog_id is added to struct net_dev_xdp. iproute2 patch will be followed. Here is how the 'ip link' will look like: > ip link show eth0 3: eth0:

Re: [PATCH 31/44] hexagon: remove arch-specific dma_supported implementation

2017-06-15 Thread Richard Kuo
On Thu, Jun 08, 2017 at 03:25:56PM +0200, Christoph Hellwig wrote: > This implementation is simply bogus - hexagon only has a simple > direct mapped DMA implementation and thus doesn't care about the > address. > > Signed-off-by: Christoph Hellwig > --- >

Re: [PATCH 17/44] hexagon: switch to use ->mapping_error for error reporting

2017-06-15 Thread Richard Kuo
On Thu, Jun 08, 2017 at 03:25:42PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > arch/hexagon/include/asm/dma-mapping.h | 2 -- > arch/hexagon/kernel/dma.c | 12 +--- > arch/hexagon/kernel/hexagon_ksyms.c| 1 - > 3 files

RE: [PATCH net-next] net: dsa: add cross-chip multicast support

2017-06-15 Thread Jason Cobham
On 06/15/2017 1:15 PM, Vivien Didelot wrote: > Similarly to how cross-chip VLAN works, define a bitmap of multicast group > members for a switch, now including its DSA ports, so that multicast traffic > can be sent to all switches of the fabric. > > A switch may drop the frames if no user port is

Re: [net-next 01/15] net/mlx5: Update eqe_type_str() event names

2017-06-15 Thread Joe Perches
On Fri, 2017-06-16 at 00:42 +0300, Saeed Mahameed wrote: > From: Eli Cohen > > Add missing NIC_VPORT_CHANGE event. > > Signed-off-by: Eli Cohen > Signed-off-by: Saeed Mahameed > --- > drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2

[PATCH net-next repost] nfp: add VLAN filtering support

2017-06-15 Thread Jakub Kicinski
From: Pablo Cascón Add general use per-vNIC mailbox area and use it for VLAN filtering support. Initially proto is hardcoded to 802.1q. Signed-off-by: Pablo Cascón Signed-off-by: Jakub Kicinski ---

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Joe Perches
On Fri, 2017-06-16 at 00:17 +0200, Johannes Berg wrote: > On Wed, 2017-06-14 at 14:18 -0700, Joe Perches wrote: > > On Wed, 2017-06-14 at 22:40 +0200, Johannes Berg wrote: > > > On Wed, 2017-06-14 at 13:36 -0700, Joe Perches wrote: > > > > > > > > Given you are adding a lot of these, it might be

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Joe Perches
On Fri, 2017-06-16 at 00:23 +0200, Johannes Berg wrote: > On Thu, 2017-06-15 at 15:17 -0700, Joe Perches wrote: > > > Here's a script that does the conversion. > > > > $ /usr/bin/git grep -P --name-only > > "\*\s*skb_put\s*\(\s*([\w\.\[\]\>\-]+)\s*,\s*1\s*\)\s*=\s*([^;]+);" | > > \ > >   xargs

Re: ath9k_htc - Division by zero in kernel (as well as firmware panic)

2017-06-15 Thread Tobias Diedrich
Yeah, this is basically mostly copy-pasted from the sboot code, would need some cleaning up. I've been playing more a little with other bits of the hardware, writing some test fw from scratch, mostly without using the builtin rom (except for interrupts). Oleksij Rempel wrote: > Am 08.06.2017 um

[PATCH RFC 1/3] arm64: Gate inclusion of asm/sysreg.h by __EMITTING_BPF__

2017-06-15 Thread David Daney
Compilation to eBPF chokes on the inline asm in asm/sysreg.h, so don't include it when compiling to a BPF target. Signed-off-by: David Daney --- arch/arm64/include/asm/sysreg.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH RFC 2/3] samples/bpf: Add define __EMITTING_BPF__ when building BPF

2017-06-15 Thread David Daney
... this allows gating of inline assembly code that causes llvm to fail when emitting BPF. Signed-off-by: David Daney --- samples/bpf/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index

[PATCH RFC 0/3] bpf/arm64/mips: Avoid inline asm in BPF

2017-06-15 Thread David Daney
To build samples/bpf on MIPS we need to avoid some inline asm that causes llvm to fail. Looking at the code, it seems that arm64 had the same problem and avoided it by defining the header guard symbol. This approach does not scale, so I invented a preprocessor define to identify the case of

[PATCH RFC 3/3] MIPS: Include file changes to enable building BPF code with llvm

2017-06-15 Thread David Daney
When building for the eBPF target archecture. Inline asm cannot be used as MIPS instructions are fundamentally incompatible with eBPF bytecode. The preprocessor symbol __EMITTING_BPF__ is used to gate the inclusion of inline asm in constructs used the by the BPF programs. Also make the Makefile

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Joe Perches
On Fri, 2017-06-16 at 00:21 +0200, Johannes Berg wrote: > On Thu, 2017-06-15 at 15:17 -0700, Joe Perches wrote: > > > I suggest changing those to skb_put_char(skb, char) > > That might be something to think of, but you can't really know for sure > that they're not using len > 1 and don't yet

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Johannes Berg
On Thu, 2017-06-15 at 15:17 -0700, Joe Perches wrote: > Here's a script that does the conversion. > > $ /usr/bin/git grep -P --name-only > "\*\s*skb_put\s*\(\s*([\w\.\[\]\>\-]+)\s*,\s*1\s*\)\s*=\s*([^;]+);" | > \ >   xargs perl -p -i -e 's/\*\s*skb_put\s*\(\s*([\w\.\[\]\>\- >

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Johannes Berg
On Thu, 2017-06-15 at 15:17 -0700, Joe Perches wrote: > I suggest changing those to skb_put_char(skb, char) That might be something to think of, but you can't really know for sure that they're not using len > 1 and don't yet care about the other bytes or something. That'd probably be another

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Johannes Berg
On Wed, 2017-06-14 at 14:18 -0700, Joe Perches wrote: > On Wed, 2017-06-14 at 22:40 +0200, Johannes Berg wrote: > > On Wed, 2017-06-14 at 13:36 -0700, Joe Perches wrote: > > > > > > Given you are adding a lot of these, it might be better > > > to add an exported function that duplicates most of >

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Joe Perches
On Thu, 2017-06-15 at 23:28 +0200, Johannes Berg wrote: > On Thu, 2017-06-15 at 17:26 -0400, David Miller wrote: > > > > > *skb_put(skb, 1) = 'x'; > > >   > > > Seems pretty unlikely we have that, and in any case the compiler > > > > would > > > warn (error?) there if skb_put() becomes void. > >

[RFC 3/3] networking: make skb_push & __skb_push return void pointers

2017-06-15 Thread Johannes Berg
From: Johannes Berg It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions return void * and remove all the casts across the tree, adding a (u8 *) cast only where

[RFC 0/3] make skb accessors return void pointers

2017-06-15 Thread Johannes Berg
Hi, After some more fun with spatch, I've come up with these three patches. I couldn't figure out why spatch didn't convert one skb_put() place, and there was one inside a macro it didn't find. Otherwise, it's pretty much just spatch and changing the functions/prototypes. I've compiled x86

[RFC 2/3] networking: make skb_pull & friends return void pointers

2017-06-15 Thread Johannes Berg
From: Johannes Berg It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions return void * and remove all the casts across the tree, adding a (u8 *) cast only where

Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg

2017-06-15 Thread Joe Perches
On Thu, 2017-06-15 at 19:14 +0100, Michael J Dilmore wrote: > Multiple netdev_info messages clutter kernel output. Also add netdev_dbg for > packets per slave. [] > diff --git a/drivers/net/bonding/bond_options.c > b/drivers/net/bonding/bond_options.c [] > @@ -9,6 +9,8 @@ > * (at your option)

[net-next 03/15] net/mlx5: Avoid using multiple blank lines

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz Fixed bunch of this checkpatch complaint: CHECK: Please don't use multiple blank lines Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/alloc.c | 1 -

[net-next 06/15] net/mlx5: Avoid space after casting

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz Fix checkpatch complaints on that: CHECK: No space is necessary after a cast Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +-

[net-next 10/15] net/mlx5e: Rename physical symbol errors counter

2017-06-15 Thread Saeed Mahameed
From: Gal Pressman Rename rx_symbol_errors_phy to rx_pcs_symbol_err_phy, in order to prevent confusion with rx_symbol_err_phy counter. rx_pcs_symbol_err_phy counter counts the number of symbol errors that were detected on the PCS (regardless of traffic) and weren't corrected

[net-next 09/15] net/mlx5e: Fix typo in warning if CQ moderation is not supported

2017-06-15 Thread Saeed Mahameed
From: Itay Aveksis Signed-off-by: Itay Aveksis Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[net-next 15/15] net/mlx5: Add fast unload support in shutdown flow

2017-06-15 Thread Saeed Mahameed
From: Majd Dibbiny Adding a support to flush all HW resources with one FW command and skip all the heavy unload flows of the driver on kernel shutdown. There's no need to free all the SW context since a new fresh kernel will be loaded afterwards. Regarding the FW resources,

[net-next 01/15] net/mlx5: Update eqe_type_str() event names

2017-06-15 Thread Saeed Mahameed
From: Eli Cohen Add missing NIC_VPORT_CHANGE event. Signed-off-by: Eli Cohen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] atm: solos-pci: remove useless variable assignments

2017-06-15 Thread Gustavo A. R. Silva
Hi David, Quoting David Miller : From: "Gustavo A. R. Silva" Date: Thu, 15 Jun 2017 14:56:21 -0500 Value assigned to variable _data32_ at lines 1254 and 1257 is overwritten at line 1260 before it can be used. This makes such variable assignments

[net-next 08/15] net/mlx5e: Use function to map aRFS into traffic type

2017-06-15 Thread Saeed Mahameed
From: Tariq Toukan For a better code reuse and readability, use the existing function arfs_get_tt() to map arfs_type into mlx5e_traffic_types, instead of duplicating the switch-case logic. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed

[net-next 11/15] net/mlx5e: Reduce number of heap allocated buffers for update stats

2017-06-15 Thread Saeed Mahameed
From: Gal Pressman Allocating buffers on the heap every 200ms is something we should avoid, let's use buffers located on the stack instead. Signed-off-by: Gal Pressman Reviewed-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed

[pull request][net-next 00/15] Mellanox mlx5 updates and cleanups 2017-06-16

2017-06-15 Thread Saeed Mahameed
Hi Dave, This series provides updates and cleanups to mlx5 driver. For more details please see tag log below. Please pull and let me know if there's any problem. *This series doesn't introduce any conflict with the ongoing net pull request. Thanks, Saeed. --- The following changes since

[net-next 04/15] net/mlx5: Avoid blank lines before/after closing/opening braces

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz Fixed checkpatch complaints on that: CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Blank lines aren't necessary after an open brace '{' and one on missing blank line.. Signed-off-by: Or Gerlitz

[net-next 12/15] net/mlx5e: Move and optimize query out of buffer function

2017-06-15 Thread Saeed Mahameed
From: Gal Pressman Move "query queue counter out of buffer" helper function out of qp.c to en_main.c, since mlx5e netdev driver is the only one to use it. Also allocate the output buffer on the stack instead of the heap, to reduce number of heap allocs on update_stats work.

[net-next 13/15] net/mlx5e: Optimize update stats work

2017-06-15 Thread Saeed Mahameed
From: Gal Pressman Unlike ethtool stats, get_stats ndo provides information cached by update stats work that is running in the background without updating them explicitly. We cannot update all counters inside the ndo because some updates require firmware commands that cannot

[net-next 05/15] net/mlx5: Align to match opening parenthesis

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz Fixed checkpatch complaints of the form: CHECK: Alignment should match open parenthesis Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c

[net-next 07/15] net/mlx5: Undo LAG upon request to create virtual functions

2017-06-15 Thread Saeed Mahameed
From: Moni Shoua LAG cannot work if virtual functions are present. Therefore, if LAG is configured, the attempt to create virtual functions will fail. This gives precedence to LAG over SRIOV which is not the desired behavior as users might want to use the bonding/teaming

[net-next 02/15] net/mlx5: Fix some spelling mistakes

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz Fixed few places where endianness was misspelled and one spot whwere output was: CHECK: 'endianess' may be misspelled - perhaps 'endianness'? CHECK: 'ouput' may be misspelled - perhaps 'output'? Signed-off-by: Or Gerlitz

Re: [PATCH net-next 5/7] qed*: Set rdma generic functions prefix

2017-06-15 Thread kbuild test robot
Hi Michal, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Yuval-Mintz/qed-RDMA-and-infrastructure-for-iWARP/20170616-043925 config: i386-randconfig-x076-06120530 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

[net-next 14/15] net/mlx5: Expose command polling interface

2017-06-15 Thread Saeed Mahameed
From: Majd Dibbiny Add a new interface for commands execution that allows the caller to wait for the command's completion in a busy-wait loop (polling mode). This is useful if we want to execute a command in a polling mode while the driver is working in events mode for the

Re: [PATCH net-next 4/7] qed*: Rename qede_roce.[ch]

2017-06-15 Thread kbuild test robot
Hi Michal, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Yuval-Mintz/qed-RDMA-and-infrastructure-for-iWARP/20170616-043925 config: tile-allmodconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget

Re: [PATCH] atm: solos-pci: remove useless variable assignments

2017-06-15 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 15 Jun 2017 14:56:21 -0500 > Value assigned to variable _data32_ at lines 1254 and 1257 is > overwritten at line 1260 before it can be used. This makes > such variable assignments useless. > > Addresses-Coverity-ID: 1227049 >

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread Johannes Berg
On Thu, 2017-06-15 at 17:26 -0400, David Miller wrote: > > > *skb_put(skb, 1) = 'x'; > >  > > Seems pretty unlikely we have that, and in any case the compiler > would > > warn (error?) there if skb_put() becomes void. > > Actually I am pretty sure I've seen a pattern like that somewhere. :- > )

Re: [PATCH] skbuff: make skb_put_zero() return void

2017-06-15 Thread David Miller
From: Johannes Berg Date: Thu, 15 Jun 2017 21:28:32 +0200 > On Thu, 2017-06-15 at 12:18 -0400, David Miller wrote: > >> Although a bit disruptive, it might be nice to convert all of the >> other "char *" related data pointers in skbuff based interfaces. > > I think

Re: [PATCH net-next] net: dsa: assign default CPU port to all ports

2017-06-15 Thread David Miller
From: Vivien Didelot Date: Thu, 15 Jun 2017 15:06:54 -0400 > The current code only assigns the default cpu_dp to all user ports of > the switch to which the CPU port belongs. The user ports of the other > switches of the fabric thus don't have a default CPU

[net-next:master 1119/1146] ERROR: "tcp_rate_check_app_limited" [net/tls/tls.ko] undefined!

2017-06-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 3715c47bcda8bb56f7e2be27276282a2d0d48c09 commit: 3c4d7559159bfe1e3b94df3a657b2cda3a34e218 [1119/1146] tls: kernel TLS support config: x86_64-randconfig-u0-06160346 (attached as .config) compiler: gcc-6

Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment

2017-06-15 Thread Gustavo A. R. Silva
Hi Jesse, Quoting Jesse Brandeburg : On Wed, 14 Jun 2017 21:38:26 -0500 "Gustavo A. R. Silva" wrote: Fix incorrect variable assignment. Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be used in this instance is aq_ret

[net 6/6] net/mlx5e: Avoid doing a cleanup call if the profile doesn't have it

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz The error flow of mlx5e_create_netdev calls the cleanup call of the given profile without checking if it exists, fix that. Currently the VF reps don't register that callback and we crash if getting into error -- can be reproduced by the user doing ctrl^C

[net 3/6] net/mlx5e: Fix min inline value for VF rep SQs

2017-06-15 Thread Saeed Mahameed
From: Chris Mi The offending commit only changed the code path for PF/VF, but it didn't take care of VF representors. As a result, since params->tx_min_inline_mode for VF representors is kzalloced to 0 (MLX5_INLINE_MODE_NONE), all VF reps SQs were set to that mode. This

[net 4/6] net/mlx5: Properly check applicability of devlink eswitch commands

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz Currently we don't check that the link type is Eth and hence crash on IB ports when attempting to deref esw->xxx, fix that. To avoid repeating this check over and over, put the existing checks and the one on link type in a single helper. Fixes:

[net 5/6] net/mlx5e: Remove TC header re-write offloading of ip tos

2017-06-15 Thread Saeed Mahameed
From: Or Gerlitz Currently the firmware API is partial and allows to offload only the dscp part of the tos, also, ipv6 support isn't there yet. As such, remove the offloading option of ipv4 dscp till the FW APIs are more comprehensive. Fixes: d79b6df6b10a ('net/mlx5e:

[net 2/6] net/mlx5e: Fix timestamping capabilities reporting

2017-06-15 Thread Saeed Mahameed
From: Maor Dickman Misuse of (BIT) macro caused to report wrong flags for "Hardware Transmit Timestamp Modes" and "Hardware Receive Filter Modes" Fixes: ef9814deafd0 ('net/mlx5e: Add HW timestamping (TS) support') Signed-off-by: Maor Dickman

[pull request][net 0/6] Mellanox mlx5 fixes 2017-06-14

2017-06-15 Thread Saeed Mahameed
Hi Dave, This series contains some fixes for the mlx5 core and netdev driver. Please pull and let me know if there's any problem. For -stable: ("net/mlx5: Wait for FW readiness before initializing command interface") kernels >= 4.4 ("net/mlx5e: Fix timestamping capabilities reporting") kernels

[net 1/6] net/mlx5: Wait for FW readiness before initializing command interface

2017-06-15 Thread Saeed Mahameed
From: Eli Cohen Before attempting to initialize the command interface we must wait till the fw_initializing bit is clear. If we fail to meet this condition the hardware will drop our configuration, specifically the descriptors page address. This scenario can happen when the

Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment

2017-06-15 Thread Jesse Brandeburg
On Wed, 14 Jun 2017 21:38:26 -0500 "Gustavo A. R. Silva" wrote: > Fix incorrect variable assignment. > Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be > used in this instance is aq_ret instead of ret. Also, variable ret is > updated at line 1602

[PATCH net-next 6/7] qed: Wait for resources before FUNC_CLOSE

2017-06-15 Thread Yuval Mintz
From: Michal Kalderon Driver needs to wait for all resources to return from FW before it can send the FUNC_CLOSE ramrod. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH net-next 7/7] qed: SPQ async callback registration

2017-06-15 Thread Yuval Mintz
From: Michal Kalderon Whenever firmware indicates that there's an async indication it needs to handle, there's a switch-case where the right functionality is called based on function's personality and information. Before iWARP is added [as yet another client], switch

[PATCH net-next 5/7] qed*: Set rdma generic functions prefix

2017-06-15 Thread Yuval Mintz
From: Michal Kalderon Rename the functions common to both iWARP and RoCE to have a prefix of _rdma_ instead of _roce_. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH net-next 4/7] qed*: Rename qede_roce.[ch]

2017-06-15 Thread Yuval Mintz
From: Michal Kalderon Once we have iWARP support, the qede portion of the qedr<->qede would serve all the RDMA protocols - so rename the file to be appropriate to its function. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz

[PATCH net-next 3/7] qed: Disable RoCE dpm when DCBx change occurs

2017-06-15 Thread Yuval Mintz
If DCBx update occurs while QPs are open, stop sending edpms until all QPs are closed. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 8 +++ drivers/net/ethernet/qlogic/qed/qed_roce.c | 36 ++

[PATCH net-next 1/7] qed: Chain support for external PBL

2017-06-15 Thread Yuval Mintz
iWARP would require the chains to allocate/free their PBL memory independently, so add the infrastructure to provide it externally. Signed-off-by: Yuval Mintz --- drivers/infiniband/hw/qedr/main.c | 2 +- drivers/infiniband/hw/qedr/verbs.c| 6

[PATCH net-next 2/7] qed: RoCE EDPM to honor PFC

2017-06-15 Thread Yuval Mintz
Configure device according to DCBx results so that EDPMs made by RoCE would honor flow-control. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 16 drivers/net/ethernet/qlogic/qed/qed_reg_addr.h | 6 ++ 2 files

[PATCH net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-15 Thread Yuval Mintz
This series focuses on RDMA in general with emphasis on required changes toward adding iWARP support. The vast majority of the changes introduced are in qed/qede, with a couple of small changes to qedr [mentioned below]. The infrastructure changes: - Patch #1 adds the ability to pass PBL memory

[PATCH net-next] net: dsa: add cross-chip multicast support

2017-06-15 Thread Vivien Didelot
Similarly to how cross-chip VLAN works, define a bitmap of multicast group members for a switch, now including its DSA ports, so that multicast traffic can be sent to all switches of the fabric. A switch may drop the frames if no user port is a member. This brings support for multicast in a

[RFC PATCH net-next v2 02/15] bpf: program to load socketops BPF programs

2017-06-15 Thread Lawrence Brakmo
The program tcp_bpf can be used to remove current global sockops program and to load/replace sockops BPF programs. There is also an option to print the bpf trace buffer (for debugging purposes). USAGE: ./tcp_bpf [-r] [-l] [] WHERE: -r remove current loaded socketops BPF program

[RFC PATCH net-next v2 00/15] bpf: BPF support for socket ops

2017-06-15 Thread Lawrence Brakmo
Created a new BPF program type, BPF_PROG_TYPE_SOCKET_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.) and setting connection parameters such as buffer sizes, initial window, SYN/SYN-ACK RTOs, etc.

[RFC PATCH net-next v2 01/15] bpf: BPF support for socket ops

2017-06-15 Thread Lawrence Brakmo
Created a new BPF program type, BPF_PROG_TYPE_SOCKET_OPS, and a corresponding struct that allows BPF programs of this type to access some of the socket's fields (such as IP addresses, ports, etc.). Currently there is functionality to load one global BPF program of this type which can be called at

[RFC PATCH net-next v2 03/15] bpf: Support for per connection SYN/SYN-ACK RTOs

2017-06-15 Thread Lawrence Brakmo
This patch adds support for setting a per connection SYN and SYN_ACK RTOs from within a BPF_SOCKET_OPS program. For example, to set small RTOs when it is known both hosts are within a datacenter. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 11 +++

[RFC PATCH net-next v2 04/15] bpf: Sample bpf program to set SYN/SYN-ACK RTOs

2017-06-15 Thread Lawrence Brakmo
The sample BPF program, tcp_synrto_kern.c, sets the SYN and SYN-ACK RTOs to 10ms when both hosts are within the same datacenter (i.e. small RTTs) in an environment where common IPv6 prefixes indicate both hosts are in the same data center. Signed-off-by: Lawrence Brakmo ---

[RFC PATCH net-next v2 11/15] bpf: Sample BPF program to set congestion control

2017-06-15 Thread Lawrence Brakmo
Sample BPF program that sets congestion control to dctcp when both hosts are within the same datacenter. In this example that is assumed to be when they have the first 5.5 bytes of their IPv6 address are the same. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile|

[RFC PATCH net-next v2 15/15] bpf: Sample bpf program to set sndcwnd clamp

2017-06-15 Thread Lawrence Brakmo
Sample BPF program, tcp_clamp_kern.c, to demostrate the use of setting the sndcwnd clamp. This program assumes that if the first 5.5 bytes of the host's IPv6 addresses are the same, then the hosts are in the same datacenter and sets sndcwnd clamp to 100 packets, SYN and SYN-ACK RTOs to 10ms and

[RFC PATCH net-next v2 09/15] bpf: Sample BPF program to set buffer sizes

2017-06-15 Thread Lawrence Brakmo
This patch contains a BPF program to set initial receive window to 40 packets and send and receive buffers to 1.5MB. This would usually be done after doing appropriate checks that indicate the hosts are far enough away (i.e. large RTT). Signed-off-by: Lawrence Brakmo ---

[RFC PATCH net-next v2 07/15] bpf: Add setsockopt helper function to bpf

2017-06-15 Thread Lawrence Brakmo
Added support for calling a subset of socket setsockopts from BPF_PROG_TYPE_SOCKET_OPS programs. The code was duplicated rather than making the changes to call the socket setsockopt function because the changes required would have been larger. The ops supported are: SO_RCVBUF SO_SNDBUF

[RFC PATCH net-next v2 05/15] bpf: Support for setting initial receive window

2017-06-15 Thread Lawrence Brakmo
This patch adds suppport for setting the initial advertized window from within a BPF_SOCKET_OPS program. This can be used to support larger initial cwnd values in environments where it is known to be safe. Signed-off-by: Lawrence Brakmo --- include/net/tcp.h| 10

[RFC PATCH net-next v2 14/15] bpf: Adds support for setting sndcwnd clamp

2017-06-15 Thread Lawrence Brakmo
Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_SNDCWND_CLAMP, which sets the initial congestion window. It is useful to limit the sndcwnd when the host are close to each other (small RTT). Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 1 + net/core/filter.c

[RFC PATCH net-next v2 08/15] bpf: Add TCP connection BPF callbacks

2017-06-15 Thread Lawrence Brakmo
Added callbacks to BPF SOCKET_OPS type program before an active connection is intialized and after a passive or active connection is established. The following patch demostrates how they can be used to set send and receive buffer sizes. Signed-off-by: Lawrence Brakmo ---

[RFC PATCH net-next v2 10/15] bpf: Add support for changing congestion control

2017-06-15 Thread Lawrence Brakmo
Added support for changing congestion control for SOCKET_OPS bps programs through the setsockopt bpf helper function. It also adds a new SOCKET_OPS op, BPF_SOCKET_OPS_NEEDS_ECN, that is needed for congestion controls, like dctcp, that need to enable ECN in the SYN packets. Signed-off-by: Lawrence

[RFC PATCH net-next v2 12/15] bpf: Adds support for setting initial cwnd

2017-06-15 Thread Lawrence Brakmo
Adds a new bpf_setsockopt for TCP sockets, TCP_BPF_IW, which sets the initial congestion window. This can be used when the hosts are far apart (large RTTs) and it is safe to start with a large inital cwnd. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 2 ++

[RFC PATCH net-next v2 06/15] bpf: Sample bpf program to set initial window

2017-06-15 Thread Lawrence Brakmo
The sample bpf program, tcp_rwnd_kern.c, sets the initial advertized window to 40 packets in an environment where distinct IPv6 prefixes indicate that both hosts are not in the same data center. Signed-off-by: Lawrence Brakmo --- samples/bpf/Makefile| 1 +

[RFC PATCH net-next v2 13/15] bpf: Sample BPF program to set initial cwnd

2017-06-15 Thread Lawrence Brakmo
Sample BPF program that assumes hosts are far away (i.e. large RTTs) and sets initial cwnd and initial receive window to 40 packets, send and receive buffers to 1.5MB. In practice there would be a test to insure the hosts are actually far enough away. Signed-off-by: Lawrence Brakmo

  1   2   3   >