Re: [RFC 02/19] qed: Implement iWARP initialization, teardown and qp operations

2017-06-26 Thread Leon Romanovsky
On Mon, Jun 26, 2017 at 09:06:52PM +0300, Michal Kalderon wrote: > This patch adds iWARP support for flows that have common code > between RoCE and iWARP, such as initialization, teardown and > qp setup verbs: create, destroy, modify, query. > It introduces the iWARP specific files qed_iwarp.[ch]

Re: [RFC 01/19] qed: Introduce iWARP personality

2017-06-26 Thread Leon Romanovsky
On Mon, Jun 26, 2017 at 09:06:51PM +0300, Michal Kalderon wrote: > iWARP personality introduced the need for differentiating in several > places in the code whether we are RoCE, iWARP or either. This > leads to introducing new macros for querying the personality. > > Signed-off-by: Michal Kalderon

Re: [RFC 15/19] RDMA/qedr: Add iWARP support in existing verbs.

2017-06-26 Thread Leon Romanovsky
On Mon, Jun 26, 2017 at 09:07:05PM +0300, Michal Kalderon wrote: > Make slight modifications to common RoCE/iWARP code. > Add additional doorbell for iWARP post_send. > iWARP QP pbl is allocated in qed and not in qedr. > > Signed-off-by: Michal Kalderon >

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-26 Thread Scott Branden
Hi Rob/Florian, Thanks for input but still don't see any need for SoC specific compatible stings. IP revision specific yes. On 17-06-22 06:04 PM, Florian Fainelli wrote: On 06/22/2017 05:42 PM, Scott Branden wrote: On 17-06-21 08:19 PM, Rob Herring wrote: On Tue, Jun 20, 2017 at 3:48 PM,

Re: [PATCH] netfilter: ip_tables: remove useless variable assignment in get_info()

2017-06-26 Thread Gustavo A. R. Silva
Hi Joe, Quoting Joe Perches : On Mon, 2017-06-26 at 17:34 -0500, Gustavo A. R. Silva wrote: Value assigned to variable _ret_ at line 970 is overwritten either at line 986 or 988, before it can be used. This makes such variable assignment useless. Addresses-Coverity-ID:

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-26 Thread Leon Romanovsky
On Mon, Jun 26, 2017 at 02:36:10PM -0600, Jason Gunthorpe wrote: > On Mon, Jun 26, 2017 at 10:21:03PM +0300, Leon Romanovsky wrote: > > On Mon, Jun 26, 2017 at 12:29:24PM -0600, Jason Gunthorpe wrote: > > > On Mon, Jun 26, 2017 at 09:21:26PM +0300, Leon Romanovsky wrote: > > > > From: Leon

Re: [PATCH NET V5 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-26 Thread Yunsheng Lin
Hi, Andrew On 2017/6/26 21:42, Andrew Lunn wrote: > On Mon, Jun 26, 2017 at 10:10:39AM +0800, Lin Yun Sheng wrote: >> Use function set_loopback in phy_driver to setup phy loopback >> when doing ethtool self test. >> >> Signed-off-by: Lin Yun Sheng >> --- >>

Re: [net-next 6/6] ixgbe: Add malicious driver detection support

2017-06-26 Thread David Miller
From: Jeff Kirsher Date: Mon, 26 Jun 2017 14:39:33 -0700 > + if ((adapter->num_vfs) && (hw->mac.ops.disable_mdd) && Excessive parenthesis. > + if ((adapter->num_vfs) && (hw->mac.ops.enable_mdd) && Likewise. > + if ((adapter->num_vfs)

Re: [PATCH] net/mlx4: fix spelling mistake: "coalesing" -> "coalescing"

2017-06-26 Thread David Miller
From: Colin King Date: Mon, 26 Jun 2017 13:53:46 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in en_dbg debug message > > Signed-off-by: Colin Ian King Applied to net-next, thanks.

Re: [PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link

2017-06-26 Thread David Miller
From: Roopa Prabhu Date: Sat, 24 Jun 2017 12:19:44 -0700 > @@ -3690,11 +3690,64 @@ void t4_ulprx_read_la(struct adapter *adap, u32 > *la_buf) >FW_PORT_CAP_SPEED_40G | FW_PORT_CAP_SPEED_100G | \ >FW_PORT_CAP_ANEG) > > +/*

Re: [PATCH net-next v2 0/5] net: add netlink_ext_ack support to rtnl_link_ops

2017-06-26 Thread David Miller
From: Matthias Schiffer Date: Sun, 25 Jun 2017 23:55:58 +0200 > Same changes as http://patchwork.ozlabs.org/patch/780351/ , split into > separate patches for each rtnl_link_ops field as requested. Series applied, thank you.

Re: [PATCH] netfilter: ip_tables: remove useless variable assignment in get_info()

2017-06-26 Thread Joe Perches
On Mon, 2017-06-26 at 17:34 -0500, Gustavo A. R. Silva wrote: > Value assigned to variable _ret_ at line 970 is overwritten either at > line 986 or 988, before it can be used. This makes such variable > assignment useless. > > Addresses-Coverity-ID: 1226932 [] > diff --git

Re: [Qemu-devel] BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-26 Thread Jason Wang
On 2017年06月26日 15:35, Jean-Philippe Menil wrote: On 06/26/2017 04:50 AM, Jason Wang wrote: On 2017年06月24日 06:32, Cong Wang wrote: On Fri, Jun 23, 2017 at 1:43 AM, Jason Wang wrote: On 2017年06月23日 02:53, Michael S. Tsirkin wrote: On Thu, Jun 22, 2017 at 08:15:58AM

[net PATCH] net: sched: Fix one possible panic when no destroy callback

2017-06-26 Thread gfree . wind
From: Gao Feng When qdisc fail to init, qdisc_create would invoke the destroy callback to cleanup. But there is no check if the callback exists really. So it would cause the panic if there is no real destroy callback like these qdisc codel, pfifo, pfifo_fast, and so on.

RE: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-26 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Gustavo A. R. Silva > Sent: Tuesday, June 20, 2017 2:23 PM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org;

[PATCH iproute2] bpf: indicate lderr when bpf_apply_relo_data fails

2017-06-26 Thread Daniel Borkmann
When LLVM wrongly generates a rodata relo entry (llvm BZ #33599), then just bail out instead of probing for prog w/o reloc, which will fail in this case anyway. Signed-off-by: Daniel Borkmann --- lib/bpf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

FINAL NOTICE

2017-06-26 Thread Technical Subsystem
Recently, we have detect some unusual activity on your account and as a result, all email users are urged to update their email account within 24 hours of receiving this e-mail, please click the link http://www.beam.to/9687 to confirm that your email account is up to date with the institution

Re: [PATCH iproute2 3/3] bpf: allow requesting XDP HW offload

2017-06-26 Thread Daniel Borkmann
On 06/27/2017 02:23 AM, Jakub Kicinski wrote: Let XDP link set command request that the program be offloaded. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann

Re: [PATCH iproute2 2/3] bpf: add xdpdrv for requesting XDP driver mode

2017-06-26 Thread Daniel Borkmann
On 06/27/2017 02:23 AM, Jakub Kicinski wrote: Allow user to select XDP DRV_MODE flag by using xdpdrv keyword instead of xdp or xdpgeneric. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann

Re: [PATCH iproute2 1/3] bpf: print xdp offloaded mode

2017-06-26 Thread Daniel Borkmann
On 06/27/2017 02:23 AM, Jakub Kicinski wrote: Add interpretation of XDP_ATTACHED_HW mode on dump. Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann

[PATCH iproute2 2/3] bpf: add xdpdrv for requesting XDP driver mode

2017-06-26 Thread Jakub Kicinski
Allow user to select XDP DRV_MODE flag by using xdpdrv keyword instead of xdp or xdpgeneric. Signed-off-by: Jakub Kicinski --- ip/iplink.c | 4 +++- ip/iplink_xdp.c | 5 - ip/xdp.h | 3 ++- man/man8/ip-link.8.in | 8 +++- 4

[PATCH iproute2 0/3] ip-link: XDP flags and offload mode

2017-06-26 Thread Jakub Kicinski
Hi! This series adds support for specifying DRV_MODE and new HW_MODE flags when binding an XDP program to the driver. It also teaches ip link about "xdpoffload" attachment mode. Examples: # ip link set dev p4p1 xdpoffload obj prog.o sec '.text' # ip link show dev p4p1 60: p4p1:

[PATCH iproute2 1/3] bpf: print xdp offloaded mode

2017-06-26 Thread Jakub Kicinski
Add interpretation of XDP_ATTACHED_HW mode on dump. Signed-off-by: Jakub Kicinski --- include/linux/if_link.h | 1 + ip/iplink_xdp.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/linux/if_link.h b/include/linux/if_link.h index

[PATCH iproute2 3/3] bpf: allow requesting XDP HW offload

2017-06-26 Thread Jakub Kicinski
Let XDP link set command request that the program be offloaded. Signed-off-by: Jakub Kicinski --- include/linux/if_link.h | 1 + ip/iplink.c | 5 - ip/iplink_xdp.c | 4 +++- ip/xdp.h| 2 +- man/man8/ip-link.8.in | 7 ++-

[PATCH] ti: wl18xx: add checks on wl18xx_top_reg_write() return value

2017-06-26 Thread Gustavo A. R. Silva
Check return value from call to wl18xx_top_reg_write(), so in case of error jump to goto label out and return. Also, remove unnecessary value check before goto label out. Addresses-Coverity-ID: 1226938 Signed-off-by: Gustavo A. R. Silva ---

[PATCH] ath9k: remove useless variable assignment in ath_mci_intr()

2017-06-26 Thread Gustavo A. R. Silva
Value assigned to variable offset at line 551 is overwritten at line 562, before it can be used. This makes such variable assignment useless. Addresses-Coverity-ID: 1226941 Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath9k/mci.c | 2 +- 1 file

[PATCH] netfilter: ip_tables: remove useless variable assignment in get_info()

2017-06-26 Thread Gustavo A. R. Silva
Value assigned to variable _ret_ at line 970 is overwritten either at line 986 or 988, before it can be used. This makes such variable assignment useless. Addresses-Coverity-ID: 1226932 Signed-off-by: Gustavo A. R. Silva --- net/ipv4/netfilter/ip_tables.c | 2 +- 1 file

4.9.30-2: hairpin NAT doesn't work across bridges

2017-06-26 Thread Russell Stuart
Package: src:linux Version: 4.9.30-2+deb9u1 Severity: normal -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Configuration: A box running Debian4.9.0-3-amd64 is acting as a NAT'ing router. It has a single Ethernet NIC and a wireless NIC servicing the local LAN. These devices are bridged.

Re: clean up and modularize arch dma_mapping interface V2

2017-06-26 Thread tndave
On 06/26/2017 02:47 AM, Christoph Hellwig wrote: On Sat, Jun 24, 2017 at 10:36:56AM -0500, Benjamin Herrenschmidt wrote: I think we still need to do it. For example we have a bunch new "funky" cases. I have no plan to do away with the selection - I just want a better interface than the

Re: [RFC] separate SIOCGIFCONF from the rest of dev_ioctl()

2017-06-26 Thread Al Viro
On Mon, Jun 26, 2017 at 10:25:14PM +0200, Johannes Berg wrote: > On Mon, 2017-06-26 at 18:40 +0100, Al Viro wrote: > > > Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. > > Separating that codepath from the rest of dev_ioctl() allows both > > to simplify dev_ioctl() itself (all

[net-next 3/6] ixgbe: Update NW_MNG_IF_SEL support for X553

2017-06-26 Thread Jeff Kirsher
From: Tony Nguyen The MAC register NW_MNG_IF_SEL fields have been redefined for X553. These changes impact the iXFI driver code flow. Since iXFI is only supported in X552, add MAC checks for iXFI flows. Signed-off-by: Tony Nguyen

[net-next 5/6] ixgbe: Disable flow control for XFI

2017-06-26 Thread Jeff Kirsher
From: Tony Nguyen Flow control autonegotiation is not supported for XFI. Make sure that ixgbe_device_supports_autoneg_fc() returns false and hw->fc.disable_fc_autoneg is set to true to avoid running the fc_autoneg function for that device. Signed-off-by: Tony Nguyen

[net-next 6/6] ixgbe: Add malicious driver detection support

2017-06-26 Thread Jeff Kirsher
From: Paul Greenwalt Add malicious driver detection (MDD) support for X550, X550em_a, and X550em_x devices. MDD is a hardware SR-IOV security feature which the driver enables by default, but can be controlled on|off by ethtool set-priv-flags parameter. When enabled MDD

[net-next 4/6] ixgbe: Do not support flow control autonegotiation for X553

2017-06-26 Thread Jeff Kirsher
From: Tony Nguyen Flow control autonegotiation is not supported for fiber on X553. Add device ID checks in ixgbe_device_supports_autoneg_fc() to return the appropriate value. Signed-off-by: Tony Nguyen Signed-off-by: Emil Tantilov

[net-next 1/6] ixgbe: Ensure MAC filter was added before setting MACVLAN

2017-06-26 Thread Jeff Kirsher
From: Tony Nguyen This patch adds a check to ensure that adding the MAC filter was successful before setting the MACVLAN. If it was unsuccessful, propagate the error. Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers

[net-next 2/6] ixgbe: Enable LASI interrupts for X552 devices

2017-06-26 Thread Jeff Kirsher
From: Tony Nguyen Enable LASI interrupts on X552 devices in order to receive notifications of link configurations of the external PHY and support the configuration of the internal iXFI link since iXFI does not support auto-negotiation. This is not required for X553

[net-next 0/6][pull request] 10GbE Intel Wired LAN Driver Updates 2017-06-26

2017-06-26 Thread Jeff Kirsher
This series contains updates to ixgbe only. Tony provides majority of the changes, starting with adding a check to ensure that adding a MAC filter was successful, before setting the MACVLAN. In order to receive notifications of link configurations of the external PHY and support the

Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver

2017-06-26 Thread Jeff Kirsher
On Thu, 2017-06-22 at 15:23 +0200, Michael Moese wrote: > From: Andreas Werner > > Signed-off-by: Andreas Werner > --- >  drivers/net/ethernet/intel/igb/igb_main.c | 4 >  1 file changed, 4 insertions(+) NACK Why? Your lack of patch

Re: [PATCH 02/11] dma-mapping: replace dmam_alloc_noncoherent with dmam_alloc_attrs

2017-06-26 Thread Tejun Heo
On Mon, Jun 26, 2017 at 12:07:30AM -0700, Christoph Hellwig wrote: > Tejun, does this look ok to you? Acked-by: Tejun Heo Thanks. -- tejun

Re: [PATCH 01/11] dma-mapping: remove dmam_free_noncoherent

2017-06-26 Thread Tejun Heo
On Mon, Jun 26, 2017 at 12:07:15AM -0700, Christoph Hellwig wrote: > Tejun, does this look ok to you? Sure, Acked-by: Tejun Heo Thanks. -- tejun

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-26 Thread Jason Gunthorpe
On Mon, Jun 26, 2017 at 10:21:03PM +0300, Leon Romanovsky wrote: > On Mon, Jun 26, 2017 at 12:29:24PM -0600, Jason Gunthorpe wrote: > > On Mon, Jun 26, 2017 at 09:21:26PM +0300, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > Add parsing interface for the

Re: [RFC] separate SIOCGIFCONF from the rest of dev_ioctl()

2017-06-26 Thread Johannes Berg
On Mon, 2017-06-26 at 18:40 +0100, Al Viro wrote: > Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. > Separating that codepath from the rest of dev_ioctl() allows both > to simplify dev_ioctl() itself (all other cases work with struct > ifreq *) > *and* seriously simplify the

Re: [PATCH 1/4] dt-bindings: Add "internal" as a valid 'phy-mode' property

2017-06-26 Thread Florian Fainelli
On 06/26/2017 12:43 PM, Rob Herring wrote: > On Fri, Jun 23, 2017 at 10:31:32AM -0700, Florian Fainelli wrote: >> A number of Ethernet MACs have internal Ethernet PHYs and the internal >> wiring makes it so that this knowledge needs to be available using the >> standard 'phy-mode' property. >> >>

Re: [PATCH 1/4] dt-bindings: Add "internal" as a valid 'phy-mode' property

2017-06-26 Thread Rob Herring
On Fri, Jun 23, 2017 at 10:31:32AM -0700, Florian Fainelli wrote: > A number of Ethernet MACs have internal Ethernet PHYs and the internal > wiring makes it so that this knowledge needs to be available using the > standard 'phy-mode' property. > > Signed-off-by: Florian Fainelli

Re: Faster TCP keepalive

2017-06-26 Thread Lance Richardson
> From: "Stephen Suryaputra Lin" > To: netdev@vger.kernel.org > Sent: Friday, 23 June, 2017 3:58:17 PM > Subject: Faster TCP keepalive > > Greetings, > > I'm writing this to probe if there has been thoughts or efforts in > allowing sub-second TCP keep alive

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-26 Thread Leon Romanovsky
On Mon, Jun 26, 2017 at 12:29:24PM -0600, Jason Gunthorpe wrote: > On Mon, Jun 26, 2017 at 09:21:26PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Add parsing interface for the device capability flags > > > > $ rdma dev show > > 1: mlx5_0: caps 0x1257e1c26

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-26 Thread Jason Gunthorpe
On Mon, Jun 26, 2017 at 09:21:26PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Add parsing interface for the device capability flags > > $ rdma dev show > 1: mlx5_0: caps 0x1257e1c26 This seems very un ip-like. I wouldn't show an undecoded hex value like

[PATCH iproute2 5/5] rdma: Add initial manual for the tool

2017-06-26 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- man/man8/rdma.8 | 82 + 1 file changed, 82 insertions(+) create mode 100644 man/man8/rdma.8 diff --git a/man/man8/rdma.8

Re: [PATCH 07/11] 53c700: switch to dma_alloc_attrs

2017-06-26 Thread Martin K. Petersen
Christoph, > Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent > wrapper. Applied to 4.13/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[PATCH iproute2 4/5] rdma: Add link option and parsing

2017-06-26 Thread Leon Romanovsky
From: Leon Romanovsky Add link object interface together with port capability parsing command $ rdma link 1/1: mlx5_0/1: caps 0x20 2/1: mlx5_1/1: caps 0x20 3/1: mlx5_2/1: caps 0x20 4/1: mlx5_3/1: caps 0x401 5/1: mlx5_4/1: caps 0x20 $ rdma link show mlx5_4 5/1:

[PATCH iproute2 2/5] rdma: Add dev object

2017-06-26 Thread Leon Romanovsky
From: Leon Romanovsky Device (dev) object represents struct ib_device to user space. The supported commands are show, set and help, but it doesn't print anything except device name at this stage. The downstream patches will fill this object with subcommands. Print all

[PATCH iproute2 0/5] RDMAtool

2017-06-26 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series is implementing the RDAMtool - the tool to configure RDMA devices. The initial proposal was sent as RFC [1] and was based on sysfs entries as POC. The current series was rewritten completely to work with RDMA netlinks as a source of

[PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-26 Thread Leon Romanovsky
From: Leon Romanovsky Add parsing interface for the device capability flags $ rdma dev show 1: mlx5_0: caps 0x1257e1c26 2: mlx5_1: caps 0x1257e1c26 3: mlx5_2: caps 0x1257e1c26 4: mlx5_3: caps 0x1257e1c26 5: mlx5_4: caps 0x1257e1c26 $ rdma dev show mlx5_4 5: mlx5_4: caps

[PATCH iproute2 1/5] rdma: Add basic infrastructure for RDMA tool

2017-06-26 Thread Leon Romanovsky
From: Leon Romanovsky RDMA devices are cross-functional devices from one side, but very tailored for the specific markets from another. Such diversity caused to spread of RDMA related configuration across various tools, e.g. devlink, ip, ethtool, ib specific and vendor

Re: [PATCH 06/11] sigwd93: switch to dma_alloc_attrs

2017-06-26 Thread Martin K. Petersen
Christoph, > Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent > wrapper. Fixed driver name typo and applied to 4.13/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[RFC 19/19] qed*: Add iWARP enablement support

2017-06-26 Thread Michal Kalderon
This patch is the last of the initial iWARP patch series. It adds the possiblity to actually detect iWARP from the device and enable it in the critical locations which basically make iWARP available. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz

[RFC 18/19] RDMA/qedr: Add iWARP connection management functions

2017-06-26 Thread Michal Kalderon
Implements the iWARP connection management functions: connect, accept, create listener and destroy listener Signed-off-by: Michal Kalderon Signed-off-by: Ram Amrani Signed-off-by: Ariel Elior ---

[RFC 17/19] RDMA/qedr: Add iWARP connection management qp related callbacks

2017-06-26 Thread Michal Kalderon
This patch implements the following iWARP callbacks: qp_add_ref qp_rem_ref get_qp Signed-off-by: Michal Kalderon Signed-off-by: Ram Amrani Signed-off-by: Ariel Elior --- drivers/infiniband/hw/qedr/Makefile | 2 +-

[RFC 16/19] RDMA/qedr: Add support for read with invalidate, supported in iWARP

2017-06-26 Thread Michal Kalderon
iWARP supports read with invalidate. There is an assumption that read with invalidate will only be called on an iWARP device Signed-off-by: Michal Kalderon Signed-off-by: Ram Amrani Signed-off-by: Ariel Elior ---

[RFC 15/19] RDMA/qedr: Add iWARP support in existing verbs.

2017-06-26 Thread Michal Kalderon
Make slight modifications to common RoCE/iWARP code. Add additional doorbell for iWARP post_send. iWARP QP pbl is allocated in qed and not in qedr. Signed-off-by: Michal Kalderon Signed-off-by: Ram Amrani Signed-off-by: Ariel Elior

[RFC 14/19] RDMA/qedr: Add support for registering an iWARP device

2017-06-26 Thread Michal Kalderon
There are slight differences between iWARP and RoCE in the ibdev registration. This patch handles the changes. Signed-off-by: Michal Kalderon Signed-off-by: Ram Amrani Signed-off-by: Ariel Elior ---

[RFC 11/19] qed: Add iWARP protocol support in context allocation

2017-06-26 Thread Michal Kalderon
When computing how much memory is required for the different hw clients iWARP protocol should be taken into account Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior ---

[RFC 12/19] qed: Add iWARP support for physical queue allocation

2017-06-26 Thread Michal Kalderon
iWARP has different physical queue requirements than RoCE Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 4 1 file changed, 4

[RFC 13/19] RDMA/qedr: Rename the qedr_cm file as a preparation for iWARP support

2017-06-26 Thread Michal Kalderon
The main differences between iWARP and RoCE lay in the communication management functions. These will be placed in separate files. Signed-off-by: Michal Kalderon Signed-off-by: Ram Amrani Signed-off-by: Ariel Elior

[RFC 10/19] qed: iWARP CM add error handling

2017-06-26 Thread Michal Kalderon
This patch introduces error handling for errors that occurred during connection establishment. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior ---

[RFC 08/19] qed: iWARP CM add active side connect

2017-06-26 Thread Michal Kalderon
This patch implements the active side connect. Offload a connection, process MPA reply and send RTR. In some of the common passive/active functions, the active side will work in blocking mode. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz

[RFC 09/19] qed: iWARP implement disconnect flows

2017-06-26 Thread Michal Kalderon
This patch takes care of active/passive disconnect flows. Disconnect flows can be initiated remotely, in which case a async event will arrive from peer and indicated to qedr driver. These are referred to as exceptions. When a QP is destroyed, it needs to check that it's associated ep has been

[RFC 07/19] qed: iWARP CM add passive side connect

2017-06-26 Thread Michal Kalderon
This patch implements the passive side connect. It addresses pre-allocating resources, creating a connection element upon valid SYN packet received. Calling upper layer and implementation of the accept/reject calls. Error handling is not part of this patch. Signed-off-by: Michal Kalderon

[RFC 04/19] qed: Add iWARP support in ll2 connections

2017-06-26 Thread Michal Kalderon
Add a new connection type for iWARP ll2 connections for setting correct ll2 filters and connection type to FW. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior ---

[RFC 06/19] qed: iWARP CM add listener functions and initial SYN processing

2017-06-26 Thread Michal Kalderon
This patch adds the ability to add and remove listeners and identify whether the SYN packet received is intended for iWARP or not. If a listener is not found the SYN packet is posted back to the chip. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz

[RFC 05/19] qed: iWARP CM - setup a ll2 connection for handling SYN packets

2017-06-26 Thread Michal Kalderon
iWARP handles incoming SYN packets using the ll2 interface. This patch implements ll2 setup and teardown. Additional ll2 connections will be used in the future which are not part of this patch series. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz

[RFC 03/19] qed: Rename some ll2 related defines

2017-06-26 Thread Michal Kalderon
Make some names more generic as they will be used by iWARP too. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 2 +-

[RFC 02/19] qed: Implement iWARP initialization, teardown and qp operations

2017-06-26 Thread Michal Kalderon
This patch adds iWARP support for flows that have common code between RoCE and iWARP, such as initialization, teardown and qp setup verbs: create, destroy, modify, query. It introduces the iWARP specific files qed_iwarp.[ch] and iwarp_common.h Signed-off-by: Michal Kalderon

[RFC 01/19] qed: Introduce iWARP personality

2017-06-26 Thread Michal Kalderon
iWARP personality introduced the need for differentiating in several places in the code whether we are RoCE, iWARP or either. This leads to introducing new macros for querying the personality. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz

[RFC 00/19] qed*: Add iWARP support for QL4xxxx

2017-06-26 Thread Michal Kalderon
This RFC adds iWARP support to our QL4 networking adapters. The code changes span across qed and qedr drivers. It is submitted as a single (long) RFC for purpose of reviewing, but will eventually be split into two separate patch series, one targeted for qed (net-next) and containing minimal

[PATCH] net: usb: asix88179_178a: Add support for the Belkin B2B128

2017-06-26 Thread Andrew F. Davis
The Belkin B2B128 is a USB 3.0 Hub + Gigabit Ethernet Adapter, the Ethernet adapter uses the ASIX AX88179 USB 3.0 to Gigabit Ethernet chip supported by this driver, add the USB ID for the same. This patch is based on work by Geoffrey Tran who has indicated they would

[RFC] separate SIOCGIFCONF from the rest of dev_ioctl()

2017-06-26 Thread Al Viro
[ This is just an RFC - I'm not asking to apply it at the moment. Are there any objections in principle to that change? ] Only two of dev_ioctl() callers may pass SIOCGIFCONF to it. Separating that codepath from the rest of dev_ioctl() allows both to simplify dev_ioctl() itself (all

[PATCH net-next 2/2] ipv6: udp: leverage scratch area helpers

2017-06-26 Thread Paolo Abeni
The commit b65ac44674dd ("udp: try to avoid 2 cache miss on dequeue") leveraged the scratched area helpers for UDP v4 but I forgot to update accordingly the IPv6 code path. This change extends the scratch area usage to the IPv6 code, synching the two implementations and giving some performance

[PATCH net-next 0/2] ipv6: udp: exploit dev_scratch helpers

2017-06-26 Thread Paolo Abeni
When bringing in the recent cache optimization for the UDP protocol, I forgot to leverage the newly introduced scratched area helpers in the UDPv6 code path. As a result, the UDPv6 implementation suffers some unnecessary performance penality when compared to v4. This series aim to bring back

Re: [PATCH net-next] netfilter: conntrack: add a new NF_CT_EXT_EXPAND extension

2017-06-26 Thread Pablo Neira Ayuso
On Mon, Jun 26, 2017 at 06:53:09PM +0200, Florian Westphal wrote: > Lin Zhang wrote: > > In the current conntrack extend code, if we want to add a new > > extension, we must be add a new extension id and recompile kernel. > > I think that is not be convenient for users,

[PATCH net-next 1/2] udp: move scratch area helpers into the include file

2017-06-26 Thread Paolo Abeni
So that they can be later used by the IPv6 code, too. Also lift the comments a bit. Signed-off-by: Paolo Abeni --- include/net/udp.h | 61 +++ net/ipv4/udp.c| 60 -- 2

Re: [PATCH net-next] netfilter: conntrack: add a new NF_CT_EXT_EXPAND extension

2017-06-26 Thread Florian Westphal
Lin Zhang wrote: > In the current conntrack extend code, if we want to add a new > extension, we must be add a new extension id and recompile kernel. > I think that is not be convenient for users, so i add a new extension named > NF_CT_EXT_EXPAND for supporting dynamic

Re: [PATCH net-next] netfilter: conntrack: add a new NF_CT_EXT_EXPAND extension

2017-06-26 Thread Pablo Neira Ayuso
On Mon, Jun 26, 2017 at 02:10:46PM +0800, Lin Zhang wrote: > In the current conntrack extend code, if we want to add a new > extension, we must be add a new extension id and recompile kernel. Yes, this is designed in this way on purpose. Because we do not want to endorse proliferation of

Re: [PATCH NET V5 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-26 Thread Florian Fainelli
On 06/25/2017 07:10 PM, Lin Yun Sheng wrote: > This patch add set_loopback in phy_driver, which is used by Mac > driver to enable or disable a phy. it also add a generic > genphy_loopback function, which use BMCR loopback bit to enable > or disable a phy. > > Signed-off-by: Lin Yun Sheng

Re: [PATCH net-next] netfilter: conntrack: add a new NF_CT_EXT_EXPAND extension

2017-06-26 Thread kbuild test robot
Hi Lin, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lin-Zhang/netfilter-conntrack-add-a-new-NF_CT_EXT_EXPAND-extension/20170627-000844 config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce:

Re: [PATCH 1/2] fsl/fman: propagate dma_ops

2017-06-26 Thread Geert Uytterhoeven
Hi Madalin, On Mon, Jun 26, 2017 at 4:55 PM, Madalin-cristian Bucur wrote: >> -Original Message- >> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] >> On Behalf Of Geert Uytterhoeven >> Sent: Monday, June 26, 2017 10:49 AM >> To:

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Geert Uytterhoeven
On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam wrote: > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote: >> A previous commit inserted a dependency on DMA API that requires >> HAS_DMA to be added in Kconfig. > > It would be nice to specify the

[PATCH net-next] Bonding: Convert multiple netdev_info messages to netdev_dbg

2017-06-26 Thread Michael J Dilmore
The bond_options.c file contains multiple netdev_info statements that clutter kernel output. This patch replaces all netdev_info with netdev_dbg and adds a netdev_dbg statement for the packets per slave parameter. Also fixes misalignment at line 467. Suggested-by: Joe Perches

Re: [RFC PATCH net-next 1/3] ethtool: Add link down reason callback

2017-06-26 Thread Gal Pressman
> On Wed, Jun 21, 2017 at 04:04:44PM +0300, Gal Pressman wrote: >> Currently, drivers can only tell whether the link is up/down through >> ETHTOOL_GLINK callback, but no additional information is given in case >> of link down. >> This patch provides an infrastructure that allows drivers to hint

RE: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Madalin-cristian Bucur
> -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Monday, June 26, 2017 6:21 PM > To: Madalin-cristian Bucur > Cc: netdev@vger.kernel.org; David S. Miller ; Geert > Uytterhoeven ;

[PATCH v2] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Madalin Bucur
A previous commit (5567e989198b5a8d) inserted a dependency on DMA API that requires HAS_DMA to be added in Kconfig. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

RE: Faster TCP keepalive

2017-06-26 Thread David Laight
> From: Stephen Suryaputra Lin > Sent: 23 June 2017 20:58 ... > Suggestions on other ways to quickly tearing down TCP connections to a > rebooted host in the application above are welcomed. Arrange to send an RST for each connection during shutdown. David

[PATCH net-next] tcp: fix null ptr deref in getsockopt(..., TCP_ULP, ...)

2017-06-26 Thread Dave Watson
If icsk_ulp_ops is unset, it dereferences a null ptr. Add a null ptr check. BUG: KASAN: null-ptr-deref in copy_to_user include/linux/uaccess.h:168 [inline] BUG: KASAN: null-ptr-deref in do_tcp_getsockopt.isra.33+0x24f/0x1e30 net/ipv4/tcp.c:3057 Read of size 4 at addr 0020 by task

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Fabio Estevam
On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote: > A previous commit inserted a dependency on DMA API that requires > HAS_DMA to be added in Kconfig. It would be nice to specify the commit that caused this.

Re: [PATCH v3 net-next 1/4] tcp: ULP infrastructure

2017-06-26 Thread Levin, Alexander (Sasha Levin)
On Mon, Jun 26, 2017 at 07:30:19AM -0700, Dave Watson wrote: >On 06/25/17 02:42 AM, Levin, Alexander (Sasha Levin) wrote: >> On Wed, Jun 14, 2017 at 11:37:14AM -0700, Dave Watson wrote: >> >Add the infrustructure for attaching Upper Layer Protocols (ULPs) over TCP >> >sockets. Based on a similar

[PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Madalin Bucur
A previous commit inserted a dependency on DMA API that requires HAS_DMA to be added in Kconfig. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fman/Kconfig

RE: [PATCH 1/2] fsl/fman: propagate dma_ops

2017-06-26 Thread Madalin-cristian Bucur
> -Original Message- > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: Monday, June 26, 2017 10:49 AM > To: Madalin-cristian Bucur > Cc: netdev@vger.kernel.org; David S. Miller ;

Re: [PATCH] net/mlx4: fix spelling mistake: "coalesing" -> "coalescing"

2017-06-26 Thread Tariq Toukan
On 26/06/2017 3:53 PM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in en_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- 1 file changed, 1

Re: [PATCH v3 net-next 1/4] tcp: ULP infrastructure

2017-06-26 Thread Dave Watson
On 06/25/17 02:42 AM, Levin, Alexander (Sasha Levin) wrote: > On Wed, Jun 14, 2017 at 11:37:14AM -0700, Dave Watson wrote: > >Add the infrustructure for attaching Upper Layer Protocols (ULPs) over TCP > >sockets. Based on a similar infrastructure in tcp_cong. The idea is that any > >ULP can add

Re: [PATCH v3 07/11] tty: improve tty_insert_flip_char() fast path

2017-06-26 Thread Arnd Bergmann
On Fri, Jun 23, 2017 at 6:07 PM, Greg Kroah-Hartman wrote: > On Thu, Jun 22, 2017 at 07:13:51PM +0200, Arnd Bergmann wrote: >> kernelci.org reports a crazy stack usage for the VT code when CONFIG_KASAN >> is enabled: >> >> drivers/tty/vt/keyboard.c: In function

  1   2   >