[PATCH net-next v3 1/1] geneve: add rtnl changelink support

2017-07-20 Thread Girish Moodalbail
This patch adds changelink rtnl operation support for geneve devices and the code changes involve: - added geneve_quiesce() which quiesces the geneve device data path for both TX and RX. This lets us perform the changelink operation atomically w.r.t data path. Also added

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Keerthy
On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote: > > > On 07/20/2017 05:28 PM, David Miller wrote: >> From: Grygorii Strashko >> Date: Thu, 20 Jul 2017 11:08:09 -0500 >> >>> In general patch looks good to me, but it's really unexpected to >>> receive IRQs

[PATCHv2 net] ipv6: should not return rt->dst.error if it is prohibit or blk hole entry.

2017-07-20 Thread Hangbin Liu
After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib result when requested"). When we get a prohibit ertry, we will return -EACCES directly. Before: + ip netns exec client ip -6 route get 2003::1 prohibit 2003::1 dev lo table unspec proto kernel src 2001::1 metric 4294967295

Maintenance Notification

2017-07-20 Thread IT
Please be advised that we will be performing a scheduled email maintenance within the next 24hrs, during this maintenance you will be require to update your email account via link http://bit.ly/2ufwueh --- This email has been checked for viruses by Avast antivirus software.

Bonding driver fails to enable second interface if updelay is non-zero

2017-07-20 Thread Benjamin Gilbert
[resend] Hello, Starting with commit de77ecd4ef02ca783f7762e04e92b3d0964be66b, and through 4.12.2, the bonding driver in 802.3ad mode fails to enable the second interface on a bond device if updelay is non-zero. dmesg says: [ 35.825227] bond0: Setting xmit hash policy to layer3+4 (1) [

Re: [PATCH v3] iproute2: add support for GRE ignore-df knob

2017-07-20 Thread Philip Prindeville
> On Jul 20, 2017, at 6:26 PM, Stephen Hemminger > wrote: > > On Thu, 20 Jul 2017 13:06:10 -0600 > "Philip Prindeville" wrote: > >> From: Philip Prindeville >> >> In the presence of firewalls which

Re: [PATCH v3] iproute2: add support for GRE ignore-df knob

2017-07-20 Thread Stephen Hemminger
On Thu, 20 Jul 2017 13:06:10 -0600 "Philip Prindeville" wrote: > From: Philip Prindeville > > In the presence of firewalls which improperly block ICMP Unreachable > (including Fragmentation Required) messages, Path MTU Discovery is

Re: [PATCH v2] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)

2017-07-20 Thread Stephen Hemminger
On Thu, 20 Jul 2017 00:36:32 +0200 Matteo Croce wrote: > v2: reword commit message > > ip netns keeps track of created namespaces with bind mounts named > /var/run/netns/. No input sanitization is done, allowing creation > and > deletion of files relatives to /var/run/netns

Re: commit 16ecba59 breaks 82574L under heavy load.

2017-07-20 Thread Benjamin Poirier
On 2017/07/20 10:00, Lennart Sorensen wrote: > On Wed, Jul 19, 2017 at 05:07:47PM -0700, Benjamin Poirier wrote: > > Are you sure about this? In my testing, while triggering the overrun > > with the msleep, I read ICR when entering e1000_msix_other() and RXO is > > consistently set. > > I had

Re: [Patch net] team: use a larger struct for mac address

2017-07-20 Thread Cong Wang
On Thu, Jul 20, 2017 at 4:06 PM, Cong Wang wrote: > IPv6 tunnels use sizeof(struct in6_addr) as dev->addr_len, > but in many places especially bonding, we use struct sockaddr > to copy and set mac addr, this could lead to stack out-of-bounds > access. > > Fix it by using

Re: [Patch net] net: check mac address length for dev_set_mac_address()

2017-07-20 Thread Cong Wang
On Thu, Jul 20, 2017 at 11:27 AM, Cong Wang wrote: > dev_set_mac_address() accepts a struct sockaddr pointer as > input but we have various types of mac addresse whose lengths > are up to MAX_ADDR_LEN, this is confusing. > > Make it void like ->ndo_set_mac_address() and

[GIT] Networking

2017-07-20 Thread David Miller
1) BPF verifier signed/unsigned value tracking fix, from Daniel Borkmann, Edward Cree, and Josef Bacik. 2) Fix memory allocation length when setting up calls to ->ndo_set_mac_address, from Cong Wang. 3) Add a new cxgb4 device ID, from Ganesh Goudar. 4) Fix FIB refcount handling, we have

[Patch net] team: use a larger struct for mac address

2017-07-20 Thread Cong Wang
IPv6 tunnels use sizeof(struct in6_addr) as dev->addr_len, but in many places especially bonding, we use struct sockaddr to copy and set mac addr, this could lead to stack out-of-bounds access. Fix it by using a larger address storage like bonding. Reported-by: Andrey Konovalov

Re: [PATCH] PCI: Update ACS quirk for more Intel 10G NICs

2017-07-20 Thread Roland Dreier
On Thu, Jul 20, 2017 at 3:15 PM, Alex Williamson wrote: > Most of the ACS capabilities are worded as "Must be implemented by > devices that implement ..." Shouldn't a hard-wired ACS capability > sufficiently describe that, or is there something wrong with how >

RE: [PATCH] PCI: Update ACS quirk for more Intel 10G NICs

2017-07-20 Thread Tantilov, Emil S
>-Original Message- >From: Roland Dreier [mailto:rol...@purestorage.com] On Behalf Of Roland >Dreier >Sent: Thursday, July 20, 2017 2:41 PM >To: Bjorn Helgaas >Cc: linux-...@vger.kernel.org; netdev@vger.kernel.org; Tantilov, Emil S >

[git][98ed5bb] rvbd/rbt-kernel : banks_990_banks_trpy6_prod_feature_branch

2017-07-20 Thread steven.la
@new_changed_in [{"codename": "banks", "train": "banks_trpy6_prod", "build_number": 9, "branch": "banks_990_banks_trpy6_prod_feature_branch"}] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: banks_990_banks_trpy6_prod_feature_branch Author: Steven La

[git][a48a019] rvbd/rbt-kernel : banks_990_banks_trpy6_prod_feature_branch

2017-07-20 Thread arthur.kepner
@new_changed_in [{"codename": "banks", "train": "banks_trpy6_prod", "build_number": 9, "branch": "banks_990_banks_trpy6_prod_feature_branch"}] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: banks_990_banks_trpy6_prod_feature_branch Author: Arthur Kepner

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Grygorii Strashko
On 07/20/2017 05:28 PM, David Miller wrote: > From: Grygorii Strashko > Date: Thu, 20 Jul 2017 11:08:09 -0500 > >> In general patch looks good to me, but it's really unexpected to >> receive IRQs while CPSW is probing ;( > > This is a poor expectation. > > Boot

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

2017-07-20 Thread David Miller
From: Kosuke Tatsukawa Date: Thu, 20 Jul 2017 05:20:40 + > balance-alb mode used to have transmit dynamic load balancing feature > enabled by default. However, transmit dynamic load balancing no longer > works in balance-alb after commit 8b426dc54cf4 ("bonding: remove >

Re: [PATCH net] rds: Make sure updates to cp_send_gen can be observed

2017-07-20 Thread David Miller
From: Håkon Bugge Date: Thu, 20 Jul 2017 12:28:55 +0200 > cp->cp_send_gen is treated as a normal variable, although it may be > used by different threads. > > This is fixed by using {READ,WRITE}_ONCE when it is incremented and > READ_ONCE when it is read outside the

[git][a48a019] rvbd/rbt-kernel : master

2017-07-20 Thread arthur.kepner
@new_changed_in [{"codename": "banks", "train": "vsfed_merge_sh_mainline", "build_number": 2, "branch": "master"}, {"codename": "aether", "train": "mainline", "build_number": 146, "branch": "master"}, {"codename": "lassen", "train": "mainline", "build_number": 110, "branch": "master"},

Re: [git][98ed5bb] rvbd/rbt-kernel : devon_dps_dataplane

2017-07-20 Thread David Miller
You guys have to seriously fix your internal git scripts. Please stop spamming the mailing list with your internal commits. Thanks.

[git][a48a019] rvbd/rbt-kernel : axel_960_VSH_VCX_XX55_feature_branch

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: axel_960_VSH_VCX_XX55_feature_branch Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix'

Re: [PATCH net-next] cxgb4: display serial config and vpd versions

2017-07-20 Thread David Miller
From: Ganesh Goudar Date: Thu, 20 Jul 2017 18:28:48 +0530 > print the versions of vpd and serial configuration file, > flashed to adapter, and cleanup the relevant code. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar

[git][98ed5bb] rvbd/rbt-kernel : devon_dps_dataplane

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_dps_dataplane Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream and port

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread David Miller
From: Grygorii Strashko Date: Thu, 20 Jul 2017 11:08:09 -0500 > In general patch looks good to me, but it's really unexpected to > receive IRQs while CPSW is probing ;( This is a poor expectation. Boot loaders and other entities can leave the device in any state

[git][a48a019] rvbd/rbt-kernel : sabre_branch

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: sabre_branch Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into 'master' Apply the

[git][a48a019] rvbd/rbt-kernel : axel_trpy_ipv6_dev

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: axel_trpy_ipv6_dev Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into 'master' Apply

[git][a48a019] rvbd/rbt-kernel : devon_deterministic_ps

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_deterministic_ps Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into 'master'

[git][a48a019] rvbd/rbt-kernel : devon_dps_dataplane

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_dps_dataplane Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into 'master'

[git][a48a019] rvbd/rbt-kernel : devon_netint_integration

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_netint_integration Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into 'master'

[git][a48a019] rvbd/rbt-kernel : sabre_600_ipv6_ic_feature_branch

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: sabre_600_ipv6_ic_feature_branch Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into

[git][a48a019] rvbd/rbt-kernel : devon_netflow_ps

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_netflow_ps Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into 'master' Apply

[git][a48a019] rvbd/rbt-kernel : banks_trpy6

2017-07-20 Thread arthur.kepner
@new_changed_in [{"codename": "phantom", "train": "trpy6_ic", "build_number": 19, "branch": "banks_trpy6"}, {"codename": "banks", "train": "trpy6", "build_number": 22, "branch": "banks_trpy6"}] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: banks_trpy6 Author: Arthur

[git][a48a019] rvbd/rbt-kernel : prod_trpy6_conclusion

2017-07-20 Thread arthur.kepner
@new_changed_in [{"codename": "phantom", "train": "ic_prod_trpy6_conclusion", "build_number": 5, "branch": "prod_trpy6_conclusion"}, {"codename": "banks", "train": "prod_trpy6_conclusion", "build_number": 12, "branch": "prod_trpy6_conclusion"}] Repository:

[git][a48a019] rvbd/rbt-kernel : baker_950_264_tetra_dev_branch

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: baker_950_264_tetra_dev_branch Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into

[git][a48a019] rvbd/rbt-kernel : banks_970_bug_fix_dev_branch

2017-07-20 Thread arthur.kepner
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: banks_970_bug_fix_dev_branch Author: Arthur Kepner Date: 2017-07-20T15:22:12-07:00 New Revision: a48a019e7afe2db8e74fda96507b82bafcfebe99 Log: Merge branch 'bnx2-fix' into

[git][98ed5bb] rvbd/rbt-kernel : prod_trpy6_conclusion

2017-07-20 Thread steven.la
@new_changed_in [{"codename": "phantom", "train": "ic_prod_trpy6_conclusion", "build_number": 5, "branch": "prod_trpy6_conclusion"}, {"codename": "banks", "train": "prod_trpy6_conclusion", "build_number": 12, "branch": "prod_trpy6_conclusion"}] Repository:

[git][98ed5bb] rvbd/rbt-kernel : baker_950_264_tetra_dev_branch

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: baker_950_264_tetra_dev_branch Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from

[git][98ed5bb] rvbd/rbt-kernel : banks_trpy6

2017-07-20 Thread steven.la
@new_changed_in [{"codename": "phantom", "train": "trpy6_ic", "build_number": 19, "branch": "banks_trpy6"}, {"codename": "banks", "train": "trpy6", "build_number": 22, "branch": "banks_trpy6"}] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: banks_trpy6 Author: Steven La

[git][98ed5bb] rvbd/rbt-kernel : banks_970_bug_fix_dev_branch

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: banks_970_bug_fix_dev_branch Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream

Re: [PATCH 1/3] ipv4: initialize fib_trie prior to register_netdev_notifier call.

2017-07-20 Thread David Miller
From: Mahesh Bandewar Date: Wed, 19 Jul 2017 15:41:33 -0700 > From: Mahesh Bandewar > > Net stack initialization currently initializes fib-trie after the > first call to netdevice_notifier() call. In fact fib_trie initialization > needs to happen before

[git][98ed5bb] rvbd/rbt-kernel : axel_960_VSH_VCX_XX55_feature_branch

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: axel_960_VSH_VCX_XX55_feature_branch Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from

[git][98ed5bb] rvbd/rbt-kernel : axel_trpy_ipv6_dev

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: axel_trpy_ipv6_dev Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream and port

[git][98ed5bb] rvbd/rbt-kernel : sabre_600_ipv6_ic_feature_branch

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: sabre_600_ipv6_ic_feature_branch Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from

[git][98ed5bb] rvbd/rbt-kernel : devon_netint_integration

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_netint_integration Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream and

Re: [PATCH 1/3] ipv4: initialize fib_trie prior to register_netdev_notifier call.

2017-07-20 Thread David Miller
From: Mahesh Bandewar (महेश बंडेवार) Date: Thu, 20 Jul 2017 10:20:06 -0700 > On Wed, Jul 19, 2017 at 10:51 PM, David Miller wrote: >> >> Where are patches #2 and #3? > Oops, my bad! I wanted to detach this from the series and send it > independently but

[git][98ed5bb] rvbd/rbt-kernel : sabre_branch

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: sabre_branch Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream and port extra

[git][98ed5bb] rvbd/rbt-kernel : devon_netflow_ps

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_netflow_ps Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream and port

[git][98ed5bb] rvbd/rbt-kernel : devon_deterministic_ps

2017-07-20 Thread steven.la
@new_changed_in [] Repository: g...@gitlab.lab.nbttech.com:rvbd/rbt-kernel.git Branch: devon_deterministic_ps Author: Steven La Date: 2017-07-18T16:34:31-07:00 New Revision: 98ed5bbc446dca588ab8a1a6edbfc870dc9d6933 Log: Apply the following patches from upstream and

Re: [Patch net] rtnetlink: allocate more memory for dev_set_mac_address()

2017-07-20 Thread David Miller
From: Cong Wang Date: Thu, 20 Jul 2017 11:27:57 -0700 > virtnet_set_mac_address() interprets mac address as struct > sockaddr, but upper layer only allocates dev->addr_len > which is ETH_ALEN + sizeof(sa_family_t) in this case. > > We lack a unified definition for mac

Re: [PATCH net] net: dsa: b53: Add missing ARL entries for BCM53125

2017-07-20 Thread David Miller
From: Florian Fainelli Date: Thu, 20 Jul 2017 12:25:22 -0700 > The BCM53125 entry was missing an arl_entries member which would > basically prevent the ARL search from terminating properly. This switch > has 4 ARL entries, so add that. > > Fixes: 1da6df85c6fb ("net: dsa:

[git][98ed5bb] rvbd/rbt-kernel : master

2017-07-20 Thread steven.la
@new_changed_in [{"codename": "banks", "train": "vsfed_merge_sh_mainline", "build_number": 2, "branch": "master"}, {"codename": "aether", "train": "mainline", "build_number": 146, "branch": "master"}, {"codename": "lassen", "train": "mainline", "build_number": 110, "branch": "master"},

Re: [PATCH net 0/5] BPF map value adjust fix

2017-07-20 Thread David Miller
From: Daniel Borkmann Date: Fri, 21 Jul 2017 00:00:20 +0200 > First patch in the series is the actual fix and the remaining > patches are just updates to selftests. Series applied, thanks.

Re: [PATCH net 1/5] bpf: fix mixed signed/unsigned derived min/max value bounds

2017-07-20 Thread Alexei Starovoitov
On 7/20/17 3:00 PM, Daniel Borkmann wrote: Edward reported that there's an issue in min/max value bounds tracking when signed and unsigned compares both provide hints on limits when having unknown variables. E.g. a program such as the following should have been rejected: Thanks a lot for the

Re: [PATCH] PCI: Update ACS quirk for more Intel 10G NICs

2017-07-20 Thread Alex Williamson
On Thu, 20 Jul 2017 14:41:01 -0700 Roland Dreier wrote: > From: Roland Dreier > > Add one more variant of the 82599 plus the device IDs for X540 and X550 > variants. Intel has confirmed that none of these devices does peer-to-peer > between

[PATCH net 1/5] bpf: fix mixed signed/unsigned derived min/max value bounds

2017-07-20 Thread Daniel Borkmann
Edward reported that there's an issue in min/max value bounds tracking when signed and unsigned compares both provide hints on limits when having unknown variables. E.g. a program such as the following should have been rejected: 0: (7a) *(u64 *)(r10 -8) = 0 1: (bf) r2 = r10 2: (07) r2 +=

[PATCH net 0/5] BPF map value adjust fix

2017-07-20 Thread Daniel Borkmann
First patch in the series is the actual fix and the remaining patches are just updates to selftests. Thanks! Daniel Borkmann (4): bpf: fix mixed signed/unsigned derived min/max value bounds bpf: allow to specify log level and reduce it for test_verifier bpf: fix up test cases with mixed

[PATCH net 3/5] bpf: fix up test cases with mixed signed/unsigned bounds

2017-07-20 Thread Daniel Borkmann
Fix the few existing test cases that used mixed signed/unsigned bounds and switch them only to one flavor. Reason why we need this is that proper boundaries cannot be derived from mixed tests. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov ---

[PATCH net 4/5] bpf: add test for mixed signed and unsigned bounds checks

2017-07-20 Thread Daniel Borkmann
From: Edward Cree These failed due to a bug in verifier bounds handling. Signed-off-by: Edward Cree Acked-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.c | 52

[PATCH net 2/5] bpf: allow to specify log level and reduce it for test_verifier

2017-07-20 Thread Daniel Borkmann
For the test_verifier case, it's quite hard to parse log level 2 to figure out what's causing an issue when used to log level 1. We do want to use bpf_verify_program() in order to simulate some of the tests with strict alignment. So just add an argument to pass the level and put it to 1 for

[PATCH net 5/5] bpf: more tests for mixed signed and unsigned bounds checks

2017-07-20 Thread Daniel Borkmann
Add a couple of more test cases to BPF selftests that are related to mixed signed and unsigned checks. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.c | 418 1 file

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-20 Thread kiki good
Hi Stephen: Thanks for the suggestion of using per-cpu statistics. In this part of code, there are two major reasons not to use per-cpu variable for calculating Tx packets: 1. The update of ring->bytes and ring ->packets are protected with irq version's spin lock in the current code logic.

Re: [PATCH net] net: dsa: b53: Add missing ARL entries for BCM53125

2017-07-20 Thread Vivien Didelot
Florian Fainelli writes: > The BCM53125 entry was missing an arl_entries member which would > basically prevent the ARL search from terminating properly. This switch > has 4 ARL entries, so add that. > > Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump

[PATCH] PCI: Update ACS quirk for more Intel 10G NICs

2017-07-20 Thread Roland Dreier
From: Roland Dreier Add one more variant of the 82599 plus the device IDs for X540 and X550 variants. Intel has confirmed that none of these devices does peer-to-peer between functions. The X540 and X550 have added ACS capabilities in their PCI config space, but the ACS

Re: A buggy behavior for Linux TCP Reno and HTCP

2017-07-20 Thread Wei Sun
Hi Yuchung, Sorry for the confusion. The test case was adapted from an old DSACK test case (i.e., forget to remove something). Attached is a new and simple one. Thanks On Wed, Jul 19, 2017 at 2:31 PM, Yuchung Cheng wrote: > On Tue, Jul 18, 2017 at 2:36 PM, Wei Sun

[PATCH net] net: dsa: b53: Add missing ARL entries for BCM53125

2017-07-20 Thread Florian Fainelli
The BCM53125 entry was missing an arl_entries member which would basically prevent the ARL search from terminating properly. This switch has 4 ARL entries, so add that. Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations") Signed-off-by: Florian Fainelli

[PATCH v3] iproute2: add support for GRE ignore-df knob

2017-07-20 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit.

[Patch net] net: check mac address length for dev_set_mac_address()

2017-07-20 Thread Cong Wang
dev_set_mac_address() accepts a struct sockaddr pointer as input but we have various types of mac addresse whose lengths are up to MAX_ADDR_LEN, this is confusing. Make it void like ->ndo_set_mac_address() and let callers check its length before calling it. It is too late to fix dev_ifsioc() due

[Patch net] rtnetlink: allocate more memory for dev_set_mac_address()

2017-07-20 Thread Cong Wang
virtnet_set_mac_address() interprets mac address as struct sockaddr, but upper layer only allocates dev->addr_len which is ETH_ALEN + sizeof(sa_family_t) in this case. We lack a unified definition for mac address, so just fix the upper layer, this also allows drivers to interpret it to struct

[PATCH nf-next] netfilter: ipset: deduplicate prefixlen maps

2017-07-20 Thread Aaron Conole
The prefixlen maps used here are identical, and have been since introduction. It seems to make sense to use a single large map, that the preprocessor will fill appropriately. Signed-off-by: Aaron Conole --- net/netfilter/ipset/pfxlen.c | 395

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-20 Thread Pravin Shelar
On Thu, Jul 20, 2017 at 10:42 AM, Girish Moodalbail wrote: > Hello Pravin, > > >>> +/* Quiesces the geneve device data path for both TX and RX. */ >>> +static inline void geneve_quiesce(struct geneve_dev *geneve, >>> + struct

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-20 Thread Girish Moodalbail
Hello Pravin, +/* Quiesces the geneve device data path for both TX and RX. */ +static inline void geneve_quiesce(struct geneve_dev *geneve, + struct geneve_sock **gs4, + struct geneve_sock **gs6) +{ + *gs4 =

Re: [PATCH 1/3] ipv4: initialize fib_trie prior to register_netdev_notifier call.

2017-07-20 Thread महेश बंडेवार
On Wed, Jul 19, 2017 at 10:51 PM, David Miller wrote: > > Where are patches #2 and #3? Oops, my bad! I wanted to detach this from the series and send it independently but forgot to update the header in process. Do you want me to send it again with just the header change

Re: [PATCH 1/2] net: mvneta: remove bogus use of device_node.data ptr

2017-07-20 Thread Sergei Shtylyov
Hello! On 07/20/2017 05:27 PM, Rob Herring wrote: Nothing sets ever sets data, so it is always NULL. Remove it as this is "Sets" once is enough. :-) the only user of data ptr in the whole kernel, and it is going to be removed from struct device_node. Cc: Thomas Petazzoni

Re: [PATCH net] rds: Make sure updates to cp_send_gen can be observed

2017-07-20 Thread Santosh Shilimkar
On 7/20/2017 3:28 AM, Håkon Bugge wrote: cp->cp_send_gen is treated as a normal variable, although it may be used by different threads. This is fixed by using {READ,WRITE}_ONCE when it is incremented and READ_ONCE when it is read outside the {acquire,release}_in_xmit protection. There is

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

2017-07-20 Thread Vivien Didelot
Hi Arkadi, Arkadi Sharshevsky writes: > Hi, thanks for the test. If the fdb is marked as self its not in the > bridge at all. So before my patch it was OK because you supported the > self thing. > > Please notice that both fdbs you added are marked the same because the >

Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Grygorii Strashko
On 07/20/2017 06:29 AM, Keerthy wrote: > Push the request_irq function to the end of probe so as > to ensure all the required fields are populated in the event > of an ISR getting executed right after requesting the irq. > > Currently while loading the crash kernel a crash was seen as > soon as

Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-07-20 Thread Rob Herring
On Thu, Jul 20, 2017 at 10:06 AM, Gregory CLEMENT wrote: > Hi Rob, > > On jeu., juil. 20 2017, Rob Herring wrote: > > (Adding Marcin in CC who wrote this part of code) > >> Nothing sets ever sets data, so it is always NULL. Remove it as this

Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-07-20 Thread Marcin Wojtas
Hi Rob, I somehow missed this patch. 2017-07-20 17:06 GMT+02:00 Gregory CLEMENT : > Hi Rob, > > On jeu., juil. 20 2017, Rob Herring wrote: > > (Adding Marcin in CC who wrote this part of code) > >> Nothing sets ever sets data, so it is

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-20 Thread Franklin S Cooper Jr
On 07/20/2017 04:52 AM, Sergei Shtylyov wrote: > Hello! > > On 7/20/2017 2:36 AM, Franklin S Cooper Jr wrote: > >> Various CAN or CAN-FD IP may be able to run at a faster rate than >> what the transceiver the CAN node is connected to. This can lead to >> unexpected errors. However, CAN

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

2017-07-20 Thread Franklin S Cooper Jr
Hi Oliver On 07/20/2017 02:43 AM, Oliver Hartkopp wrote: > Hi Franklin, > > On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: > >> +#ifdef CONFIG_OF >> +void of_transceiver_is_fixed(struct net_device *dev) >> +{ > > (..) > >> +} >> +EXPORT_SYMBOL(of_transceiver_is_fixed); >> +#endif > >

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-20 Thread Stephen Hemminger
On Wed, 19 Jul 2017 01:18:40 +0100 "Jianming.qiao" wrote: > Signed-off-by: Jianming.qiao You may want to consider using per-cpu statistics.

Re: [PATCH v2 1/1] iroute2: Add support for GRE ignore-df knob

2017-07-20 Thread Stephen Hemminger
On Wed, 19 Jul 2017 23:19:33 -0600 "Philip Prindeville" wrote: > From: Philip Prindeville > > In the presence of firewalls which improperly block ICMP Unreachable > (including Fragmentation Required) messages, Path MTU Discovery is

Re: [PATCH v2 net-next] net: systemport: Support 64bit statistics

2017-07-20 Thread Florian Fainelli
On 07/20/2017 03:13 AM, kiki good wrote: > Hi David: > > I am sorry for missing the commit log message;Since I did conversation > with Florian Fainelli about this patch in another email thread > "[PATCH] net: systemport: Support 64bit statistics", i incorrectly > thought it was unnecessary to add

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-20 Thread Hangbin Liu
2017-07-20 23:06 GMT+08:00 Hangbin Liu : >> +++ b/net/ipv6/route.c >> @@ -3637,12 +3637,6 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, >> struct nlmsghdr *nlh, >> dst = ip6_route_lookup(net, , 0); >> >> rt = container_of(dst, struct

Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-07-20 Thread Gregory CLEMENT
Hi Rob, On jeu., juil. 20 2017, Rob Herring wrote: (Adding Marcin in CC who wrote this part of code) > Nothing sets ever sets data, so it is always NULL. Remove it as this is > the only user of data ptr in the whole kernel, and it is going to be > removed from struct

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-20 Thread Hangbin Liu
Hi Roopa, Cong, 2017-07-20 22:51 GMT+08:00 Hangbin Liu : > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly. > > Before: > + ip netns exec client ip -6 route get

[PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-20 Thread Hangbin Liu
After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib result when requested"). When we get a prohibit ertry, we will return -EACCES directly. Before: + ip netns exec client ip -6 route get 2003::1 prohibit 2003::1 dev lo table unspec proto kernel src 2001::1 metric 4294967295

[PATCH 2/2] of: remove unused struct device_node.data ptr

2017-07-20 Thread Rob Herring
There are no users for data pointer in the kernel, so it can be removed. Signed-off-by: Rob Herring --- include/linux/of.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/of.h b/include/linux/of.h index 4a8a70916237..7312c8ac5221 100644 --- a/include/linux/of.h

[PATCH 1/2] net: mvneta: remove bogus use of device_node.data ptr

2017-07-20 Thread Rob Herring
Nothing sets ever sets data, so it is always NULL. Remove it as this is the only user of data ptr in the whole kernel, and it is going to be removed from struct device_node. Cc: Thomas Petazzoni Signed-off-by: Rob Herring --- Probably

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

2017-07-20 Thread Andy Gospodarek
On Thu, Jul 20, 2017 at 1:20 AM, Kosuke Tatsukawa wrote: > balance-alb mode used to have transmit dynamic load balancing feature > enabled by default. However, transmit dynamic load balancing no longer > works in balance-alb after commit 8b426dc54cf4 ("bonding: remove >

Re: commit 16ecba59 breaks 82574L under heavy load.

2017-07-20 Thread Lennart Sorensen
On Wed, Jul 19, 2017 at 05:07:47PM -0700, Benjamin Poirier wrote: > Are you sure about this? In my testing, while triggering the overrun > with the msleep, I read ICR when entering e1000_msix_other() and RXO is > consistently set. I had thousands of calls to e1000_msix_other where the only bit

[PATCH net-next] cxgb4: display serial config and vpd versions

2017-07-20 Thread Ganesh Goudar
print the versions of vpd and serial configuration file, flashed to adapter, and cleanup the relevant code. Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 14 +-

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-20 Thread Måns Rullgård
Mason writes: > I will look for an inter-packet gap knob and FCS error counter. There is an FCS error counter. Use "ethtool -S" and look for rx_bad_fcs_frames. Reading the stats counters automatically resets them to zero. -- Måns Rullgård

Re: [PATCH 2/2] net: ethernet: nb8800: Fix RGMII TX clock delay setup

2017-07-20 Thread Mason
On 19/07/2017 23:34, Florian Fainelli wrote: > How about you start reading the RGMII specification so we can at least, > if nothing else agree on the terminology? It's public: > > http://web.archive.org/web/20160303171328/http://www.hp.com/rnd/pdfs/RGMIIv2_0_final_hp.pdf Thanks for linking the

[PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe

2017-07-20 Thread Keerthy
Push the request_irq function to the end of probe so as to ensure all the required fields are populated in the event of an ISR getting executed right after requesting the irq. Currently while loading the crash kernel a crash was seen as soon as devm_request_threaded_irq was called. This was due

Re: [PATCH net] rds: Make sure updates to cp_send_gen can be observed

2017-07-20 Thread Håkon Bugge
> On 20 Jul 2017, at 13:02, Sowmini Varadhan > wrote: > > On (07/20/17 12:28), H??kon Bugge wrote: >> cp->cp_send_gen is treated as a normal variable, although it may be >> used by different threads. > > I'm confused by that assertion. If you look at the comments

Re: [PATCH net] rds: Make sure updates to cp_send_gen can be observed

2017-07-20 Thread Sowmini Varadhan
On (07/20/17 12:28), H??kon Bugge wrote: > cp->cp_send_gen is treated as a normal variable, although it may be > used by different threads. I'm confused by that assertion. If you look at the comments right above the change in your patch, there is a note that acquire_in_xmit/release_in_xmit are

[PATCH net] rds: Make sure updates to cp_send_gen can be observed

2017-07-20 Thread Håkon Bugge
cp->cp_send_gen is treated as a normal variable, although it may be used by different threads. This is fixed by using {READ,WRITE}_ONCE when it is incremented and READ_ONCE when it is read outside the {acquire,release}_in_xmit protection. Normative reference from the Linux-Kernel Memory Model:

  1   2   >