Re: [PATCH net] ipv4: route: fix inet_rtm_getroute induced crash

David Ahern wrote: > On 8/13/17 4:52 PM, Florian Westphal wrote: > > "ip route get $daddr iif eth0 from $saddr" causes: > > BUG: KASAN: use-after-free in ip_route_input_rcu+0x1535/0x1b50 > > Call Trace: > > ip_route_input_rcu+0x1535/0x1b50 > >

Re: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured

On Sun, Aug 13, 2017 at 05:25:21PM -0700, David Miller wrote: > From: Ohad Oz > Date: Sun, 13 Aug 2017 15:26:56 + > > > > > > >> -Original Message- > >> From: Leon Romanovsky [mailto:l...@kernel.org] > >> Sent: Saturday, August 12, 2017 5:37 PM > >> To: Ohad Oz

Re: [PATCH net] ipv4: route: fix inet_rtm_getroute induced crash

On 8/13/17 4:52 PM, Florian Westphal wrote: > "ip route get $daddr iif eth0 from $saddr" causes: > BUG: KASAN: use-after-free in ip_route_input_rcu+0x1535/0x1b50 > Call Trace: > ip_route_input_rcu+0x1535/0x1b50 > ip_route_input_noref+0xf9/0x190 > tcp_v4_early_demux+0x1a4/0x2b0 >

Re: [PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

On Mon, 2017-08-14 at 11:39 +0930, Joel Stanley wrote: > On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas > wrote: > > Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI > > stack process new VLAN tags and configure the channel VLAN filter > >

Re: [PATCH 0/4] constify net platform_device_id

From: Arvind Yadav Date: Sun, 13 Aug 2017 16:41:44 +0530 > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by > work with const platform_device_id. So mark the non-const structs as const. Series

Re: [PATCH] tap: make struct tap_fops static

From: Colin King Date: Sat, 12 Aug 2017 22:52:31 +0100 > From: Colin Ian King > > The structure tap_fops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'tap_fops'

Re: [PATCH] virtio-net: make array guest_offloads static

From: Colin King Date: Sat, 12 Aug 2017 22:45:53 +0100 > From: Colin Ian King > > The array guest_offloads is local to the source and does not need to > be in global scope, so make it static. Also tweak formatting. > > Cleans up sparse

Re: [PATCH] of_mdio: merge branch tails in of_phy_register_fixed_link()

From: Sergei Shtylyov Date: Sun, 13 Aug 2017 00:03:06 +0300 > Looks like gcc isn't always able to figure out that 3 *if* branches in > of_phy_register_fixed_link() calling fixed_phy_register() at their ends > are similar enough and thus can be merged. The

Re: [PATCH net-next 0/2] net: vrf: Support for local traffic with sockets bound to enslaved devices

From: David Ahern Date: Fri, 11 Aug 2017 17:11:13 -0700 > This set gets local traffic working for sockets bound to enslaved > devices. The local rtable and rt6_info added in June 2016 to get > local traffic in VRFs working is no longer needed and actually > keeps local traffic

Re: [PATCH net-next] net: ipv4: remove unnecessary check on orig_oif

From: David Ahern Date: Fri, 11 Aug 2017 17:02:02 -0700 > rt_iif is going to be set to either 0 or orig_oif. If orig_oif > is 0 it amounts to the same end result so remove the check. > > Signed-off-by: David Ahern Applied, thanks David.

Re: [PATCH v2] bonding: ratelimit failed speed/duplex update warning

From: Andreas Born Date: Sat, 12 Aug 2017 00:36:55 +0200 > bond_miimon_commit() handles the UP transition for each slave of a bond > in the case of MII. It is triggered 10 times per second for the default > MII Polling interval of 100ms. For device drivers that do not

Re: [PATCH net-next v3] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

From: Girish Moodalbail Date: Fri, 11 Aug 2017 15:20:59 -0700 > The kernel log is not where users expect error messages for netlink > requests; as we have extended acks now, we can replace pr_debug() with > NL_SET_ERR_MSG_ATTR(). > > Signed-off-by: Matthias

Re: [PATCH net-next V2 0/3] XDP support for tap

From: Jason Wang Date: Fri, 11 Aug 2017 19:41:15 +0800 > Hi all: > > This series tries to implement XDP support for tap. Two path were > implemented: > > - fast path: small & non-gso packet, For performance reason we do it > at page level and use build_skb() to create

Re: [PATCHv2 net-next] gre: introduce native tunnel support for ERSPAN

From: William Tu Date: Wed, 9 Aug 2017 13:53:05 -0700 > The patch adds ERSPAN type II tunnel support. The implementation > is based on the draft at [1]. One of the purposes is for Linux > box to be able to receive ERSPAN monitoring traffic sent from > the Cisco switch, by

Re: [PATCH net-next] rtnelink: Move link dump consistency check out of the loop

From: Jakub Sitnicki Date: Wed, 9 Aug 2017 17:39:12 +0200 > Calls to rtnl_dump_ifinfo() are protected by RTNL lock. So are the > {list,unlist}_netdevice() calls where we bump the net->dev_base_seq > number. > > For this reason net->dev_base_seq can't change under out feet

Re: [PATCH net-next 8/8] liquidio: added support for ethtool --set-ring feature

From: Felix Manlunas Date: Fri, 11 Aug 2017 18:29:30 -0700 > + if ((ering->rx_mini_pending) || (ering->rx_jumbo_pending)) > + return -EINVAL; Lots of unnecessary parenthesis, please remove. > + if ((rx_count == rx_count_old) && (tx_count ==

Re: [PATCH net-next v2 3/3] ftgmac100: Support NCSI VLAN filtering when available

On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas wrote: > Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the > NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available. > This allows the VLAN core to notify the NCSI driver when changes occur > so that the remote

Re: [PATCH net-next v2 1/3] net/ncsi: Fix several packet definitions

On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas wrote: I asked Sam if these should be backported to stable and he said: > These are straight up bugs except... without my changes we never call > this code. As Ben says as time provides a lot of the current

Re: [PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas wrote: > Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI > stack process new VLAN tags and configure the channel VLAN filter > appropriately. > Several VLAN tags can be set and a "Set VLAN Filter"

[PATCH net-next v2 3/3] ftgmac100: Support NCSI VLAN filtering when available

Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available. This allows the VLAN core to notify the NCSI driver when changes occur so that the remote NCSI channel can be properly configured to filter on the set VLAN tags. Signed-off-by: Samuel

[PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI stack process new VLAN tags and configure the channel VLAN filter appropriately. Several VLAN tags can be set and a "Set VLAN Filter" packet must be sent for each one, meaning the ncsi_dev_state_config_svf state must be

[PATCH net-next v2 0/3] NCSI VLAN Filtering Support

This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. A fair amount of code already exists in the NCSI stack for VLAN filtering but none of it is actually hooked up. This goes the final mile and fixes a few bugs in the existing code found along the way (patch 1). Patch 3

[PATCH net-next v2 1/3] net/ncsi: Fix several packet definitions

Signed-off-by: Samuel Mendoza-Jonas --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c

Re: [PATCH 0/3] NCSI VLAN Filtering Support

On Fri, 2017-08-11 at 14:48 -0700, David Miller wrote: > From: Samuel Mendoza-Jonas > Date: Fri, 11 Aug 2017 16:16:45 +1000 > > > This series (mainly patch 3) adds VLAN filtering to the NCSI implementation. > > A fair amount of code already exists in the NCSI stack for

Re: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured

From: Ohad Oz Date: Sun, 13 Aug 2017 15:26:56 + > > >> -Original Message- >> From: Leon Romanovsky [mailto:l...@kernel.org] >> Sent: Saturday, August 12, 2017 5:37 PM >> To: Ohad Oz >> Cc: da...@davemloft.net; netdev@vger.kernel.org;

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Sat, Aug 12, 2017 at 10:27 AM, Paweł Staszewski wrote: > Hi and thanks for reply > > > > W dniu 2017-08-12 o 14:23, Jesper Dangaard Brouer pisze: >> >> On Fri, 11 Aug 2017 19:51:10 +0200 Paweł Staszewski >> wrote: >> >>> Hi >>> >>> I made some

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/13/17 2:56 PM, Wei Wang wrote: >> Looking at my patch to move host routes from loopback to device with the >> address, I have this: >> >> @@ -2789,7 +2808,8 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg) >> const struct arg_dev_net *adn = arg; >> const struct

[PATCH net] ipv4: route: fix inet_rtm_getroute induced crash

"ip route get $daddr iif eth0 from $saddr" causes: BUG: KASAN: use-after-free in ip_route_input_rcu+0x1535/0x1b50 Call Trace: ip_route_input_rcu+0x1535/0x1b50 ip_route_input_noref+0xf9/0x190 tcp_v4_early_demux+0x1a4/0x2b0 ip_rcv+0xbcb/0xc05 __netif_receive_skb+0x9c/0xd0

RE: [PATCH net-next v2] openvswitch: enable NSH support

> From: Jiri Benc [mailto:jb...@redhat.com] > Sent: Friday, 11 August, 2017 12:23 > > On Fri, 11 Aug 2017 10:09:36 +, Jan Scheurich wrote: > > Unless someone can explain to me why the datapath should understand the > > internal structure/format of metadata in push_nsh, I would strongly > >

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

> Looking at my patch to move host routes from loopback to device with the > address, I have this: > > @@ -2789,7 +2808,8 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg) > const struct arg_dev_net *adn = arg; > const struct net_device *dev = adn->dev; > > - if

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-12 21:30 GMT+02:00 James Feeney : > > > Andreas patch failed to address the continuous, *10-times per second* warning > which will "spam" the log file, sometimes the console, whenever the test > fails: > if (bond_update_speed_duplex(slave) &&

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

To show some difference below comparision vlan/no-vlan traffic 10Mpps forwarded traffic vith no-vlan vs 6.9Mpps with vlan (ixgbe in kernel driver kernel 4.13.0-rc4-next-20170811) ethtool settings for both tests: ethtool -K $ifc gro off tso off gso off sg on l2-fwd-offload off tx-nocache-copy

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On 8/12/17 1:42 PM, Wei Wang wrote: > Hi Ido, > >>> - if ((rt->dst.dev == dev || !dev) && >>> + if ((rt->dst.dev == dev || !dev || >>> + rt->rt6i_idev->dev == dev) && >> >> Can you please explain why this line is needed? While host routes aren't >> removed from the FIB by

Re: [PATCH net] Revert "vhost: cache used event for better performance"

Sorry I mistakenly focused on NET case, please pass it over. I will do any relevant suggestion in patch-based way. Thanks. On Sun, 2017-08-13 at 23:11 +0900, Koichiro Den wrote: > Thanks for your comments, Michael and Jason. And I'm sorry about late > response. > To be honest, I am on a summer

Re: [iproute PATCH 15/51] ipvrf: Fix error path of vrf_switch()

On 8/12/17 6:04 AM, Phil Sutter wrote: > Apart from trying to close(-1), this also leaked memory. > > Signed-off-by: Phil Sutter > --- > ip/ipvrf.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/ip/ipvrf.c b/ip/ipvrf.c > index

Re: [iproute PATCH 06/51] iplink_vrf: Complain if main table is not found

On 8/12/17 6:04 AM, Phil Sutter wrote: > Signed-off-by: Phil Sutter > --- > ip/iplink_vrf.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ip/iplink_vrf.c b/ip/iplink_vrf.c > index 917630e853375..809eda5de8f6e 100644 > --- a/ip/iplink_vrf.c > +++

Re: [iproute PATCH 14/51] ipvrf: Don't try to close an invalid fd

On 8/12/17 6:04 AM, Phil Sutter wrote: > Signed-off-by: Phil Sutter > --- > ip/ipvrf.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/ip/ipvrf.c b/ip/ipvrf.c > index 0094cf8557cd7..92e2db98ca7d7 100644 > --- a/ip/ipvrf.c > +++ b/ip/ipvrf.c > @@

RE: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured

> -Original Message- > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Saturday, August 12, 2017 5:37 PM > To: Ohad Oz > Cc: da...@davemloft.net; netdev@vger.kernel.org; j...@resnulli.us; Saeed > Mahameed ; Vadim Pasternak >

Re: [PATCH net] Revert "vhost: cache used event for better performance"

Thanks for your comments, Michael and Jason. And I'm sorry about late response. To be honest, I am on a summer vacation until next Tuesday. I noticed that what I wrote was not sufficient. Regardless of caching mechanism existence, the "event" could legitimately be at any point out of the latest

[PATCH 4/4] net: ti: cpsw:: constify platform_device_id

platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by work with const platform_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ti/cpsw.c | 2 +- 1

[PATCH 0/4] constify net platform_device_id

platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by work with const platform_device_id. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] can: constify platform_device_id [PATCH 2/4] net: dpaa_eth: constify

[PATCH 2/4] net: dpaa_eth: constify platform_device_id

platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by work with const platform_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav ---

[PATCH 3/4] net: sh_eth: constify platform_device_id

platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by work with const platform_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/renesas/sh_eth.c | 2

[PATCH 1/4] can: constify platform_device_id

platform_device_id are not supposed to change at runtime. All functions working with platform_device_id provided by work with const platform_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/can/c_can/c_can_platform.c | 2

Re: [PATCH v5 09/11] ARM: dts: rk3228-evb: Enable the integrated PHY for gmac

-the-integrated-PHY-support/20170813-163538 config: arm-omap2plus_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x

[PATCH net] openvswitch: fix skb_panic due to the incorrect actions attrlen

From: Liping Zhang For sw_flow_actions, the actions_len only represents the kernel part's size, and when we dump the actions to the userspace, we will do the convertions, so it's true size may become bigger than the actions_len. But unfortunately, for

Re: Driver profiles RFC

Fri, Aug 11, 2017 at 11:57:38PM CEST, kubak...@wp.pl wrote: >On Tue, 8 Aug 2017 16:15:41 +0300, Arkadi Sharshevsky wrote: >> Driver <--> Devlink API >> === >> Each driver will register his resources with default values at init in >> a similar way to DPIPE table registration. In