Re: linux-next: manual merge of the net-next tree with the net tree

2017-08-22 Thread Ido Schimmel
On Wed, Aug 23, 2017 at 11:31:05AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv6/ip6_fib.c > > between commit: > > c5cff8561d2d ("ipv6: add rcu grace period before freeing fib6_node") > > from the net tree and

RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

2017-08-22 Thread Madalin-cristian Bucur
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, August 23, 2017 7:47 AM > To: Madalin-cristian Bucur > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH v2 1/6]

Re: Something hitting my total number of connections to the server

2017-08-22 Thread Akshat Kakkar
On Tue, Aug 22, 2017 at 5:58 PM, Neal Cardwell wrote: > On Tue, Aug 22, 2017 at 1:42 AM, Akshat Kakkar wrote: >> There are multiple hosts/clients. All are mainly windows based. >> >> Timestamp is not used as my clients mainly are windows based and in

[PATCH v2 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-22 Thread Dexuan Cui
Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It uses VMBus ringbuffer as the transportation layer. With hv_sock, applications between the host (Windows 10, Windows Server 2016 or newer) and the guest can talk with each other using

Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

2017-08-22 Thread David Miller
From: Madalin-cristian Bucur Date: Wed, 23 Aug 2017 04:36:56 + > The struct fman is only visible in the fman file, the fman port > module uses struct fman as an opaque pointer, thus this export. Don't use that programming model. Export the datastructure properly to

[Patch net-next] net_sched: remove tc class reference counting

2017-08-22 Thread Cong Wang
For TC classes, their ->get() and ->put() are always paired, and the reference counting is completely useless, because: 1) For class modification and dumping paths, we already hold RTNL lock, so all of these ->get(),->change(),->put() are atomic. 2) For filter bindiing/unbinding, we use other

RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

2017-08-22 Thread Madalin-cristian Bucur
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of David Miller > Sent: Wednesday, August 23, 2017 12:35 AM > Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen > > From: Madalin Bucur > Date: Tue,

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

2017-08-22 Thread David Miller
From: Vallish Vaidyeshwara Date: Wed, 23 Aug 2017 00:10:25 + > I am submitting 2 patch series to enable hires timer to timeout > datagram sockets (AF_UNIX & AF_INET domain) and test code to test > timeout accuracy on these sockets. This is not reasonable. If you want

Re: [trivial] gre: fix goto statement typo

2017-08-22 Thread David Miller
From: William Tu Date: Tue, 22 Aug 2017 17:04:05 -0700 > Fix typo: pnet_tap_faied. > > Signed-off-by: William Tu Applied to net-next.

Re: [PATCH net-next 0/2] Two minor BPF cleanups

2017-08-22 Thread David Miller
From: Daniel Borkmann Date: Wed, 23 Aug 2017 01:47:52 +0200 > Two minor cleanups on devmap and redirect I still had > in my queue. Series applied.

RE: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-22 Thread Dexuan Cui
> From: Jorgen S. Hansen [mailto:jhan...@vmware.com] > > On Aug 22, 2017, at 11:54 AM, Stefan Hajnoczi > wrote: > > ... > > We *can* by looking at the destination CID. Please take a look at > > drivers/misc/vmw_vmci/vmci_route.c:vmci_route() to see how VMCI > handles > >

Re: [PATCH] drivers: net: wireless: atmel: check memory allocation failure

2017-08-22 Thread Kalle Valo
Himanshu Jha writes: > Check memory allocation failure and return -ENOMEM if failure > occurs. > > Signed-off-by: Himanshu Jha The title prefix is wrong:

Re: [PATCH v12 7/8] wireless: ipw2200: Replace PCI pool old API

2017-08-22 Thread Kalle Valo
+ linux-wireless Stanislav Yakovlev writes: > On 22 August 2017 at 07:47, Romain Perier wrote: >> The PCI pool API is deprecated. This commit replaces the PCI pool old >> API by the appropriate function with the DMA pool API. >> >>

Re: [PATCH v4 net-next] arm: eBPF JIT compiler

2017-08-22 Thread Shubham Bansal
Hi David, On Tue, Aug 22, 2017 at 10:02 PM, David Miller wrote: > > You posted this 4 times. :-( > > I hope I applied the right one. All 4 of these are the same patch. I mistakenly sent it 4 times. My apologies for that. > > Go check net-next and please send me any

Re: [PATCH net-next v7 02/10] bpf: Add eBPF program subtype and is_valid_subtype() verifier

2017-08-22 Thread Alexei Starovoitov
On Mon, Aug 21, 2017 at 02:09:25AM +0200, Mickaël Salaün wrote: > The goal of the program subtype is to be able to have different static > fine-grained verifications for a unique program type. > > The struct bpf_verifier_ops gets a new optional function: > is_valid_subtype(). This new verifier is

[PATCH net-next] ipv4: do metrics match when looking up and deleting a route

2017-08-22 Thread Xin Long
Now when ipv4 route inserts a fib_info, it memcmp fib_metrics. It means ipv4 route identifies one route also with metrics. But when removing a route, it tries to find the route without caring about the metrics. It will cause that the route with right metrics can't be removed. Thomas noticed this

Re: [PATCH net-next 3/8] bpf: Allow cgroup sock filters to use get_current_uid_gid helper

2017-08-22 Thread Alexei Starovoitov
On Tue, Aug 22, 2017 at 05:20:16PM -0700, David Ahern wrote: > Allow BPF programs run on sock create to use the get_current_uid_gid > helper. > > Signed-off-by: David Ahern as far as i understand socket creation path the context of inet_create/inet6_create should always have

Re: [PATCH net-next 2/8] bpf: Add mark and priority to sock options that can be set

2017-08-22 Thread Alexei Starovoitov
On Tue, Aug 22, 2017 at 05:20:15PM -0700, David Ahern wrote: > Add socket mark and priority to fields that can be set by > ebpf program when a socket is created. > > Signed-off-by: David Ahern lgtm Acked-by: Alexei Starovoitov

Re: [PATCH net-next 1/8] bpf: Recursively apply cgroup sock filters

2017-08-22 Thread Alexei Starovoitov
On Tue, Aug 22, 2017 at 05:20:14PM -0700, David Ahern wrote: > Recursively apply sock filters attached to a cgroup. For now, start > with the inner cgroup attached to the socket and work back to the > root. If desired the inverse can be done use an attach flag (start > with parent cgroup and go

linux-next: manual merge of the net-next tree with the net tree

2017-08-22 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv6/ip6_fib.c between commit: c5cff8561d2d ("ipv6: add rcu grace period before freeing fib6_node") from the net tree and commit: a460aa83963b ("ipv6: fib: Add helpers to hold / drop a reference on rt6_info")

Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Alexander Duyck
On Tue, Aug 22, 2017 at 1:04 PM, Michael Chan wrote: > On Tue, Aug 22, 2017 at 11:30 AM, Duyck, Alexander H > wrote: >> On Tue, 2017-08-22 at 11:17 -0700, John Fastabend wrote: >>> On 08/22/2017 11:02 AM, Michael Chan wrote: >>> > On Mon,

Re: [RFC PATCH] dt-binding: net: sfp binding documentation

2017-08-22 Thread Rob Herring
On Tue, Aug 22, 2017 at 07:49:01AM +0300, Baruch Siach wrote: > Hi Rob, > > On Mon, Aug 21, 2017 at 02:10:33PM -0500, Rob Herring wrote: > > On Sun, Aug 20, 2017 at 5:28 AM, Baruch Siach wrote: > > > Add device-tree binding documentation SFP transceivers. Support for SFP > > >

Re: [PATCH] e1000: changed some expensive calls of udelay to usleep_range

2017-08-22 Thread Jeff Kirsher
On Tue, 2017-08-22 at 16:02 -0500, nxf23276 wrote: > Calls to udelay are not preemtable by userspace so userspace > applications experience a large (~200us) latency when running on > core > 0. Instead usleep_range can be used to be more friendly to > userspace > since it is

[PATCH net-next 2/3 v8] net: arp: Add support for raw IP device

2017-08-22 Thread Subash Abhinov Kasiviswanathan
Define the raw IP type. This is needed for raw IP net devices like rmnet. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_arp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h index

[PATCH net-next 1/8] bpf: Recursively apply cgroup sock filters

2017-08-22 Thread David Ahern
Recursively apply sock filters attached to a cgroup. For now, start with the inner cgroup attached to the socket and work back to the root. If desired the inverse can be done use an attach flag (start with parent cgroup and go in). Signed-off-by: David Ahern ---

[PATCH net-next 4/8] bpf samples: Update sock test to allow setting mark and priority

2017-08-22 Thread David Ahern
Update sock test to set mark and priority on socket create. Signed-off-by: David Ahern --- samples/bpf/test_cgrp2_sock.c | 129 - samples/bpf/test_cgrp2_sock.sh | 2 +- 2 files changed, 116 insertions(+), 15 deletions(-) diff --git

[PATCH net-next 1/3 v8] net: ether: Add support for multiplexing and aggregation type

2017-08-22 Thread Subash Abhinov Kasiviswanathan
Define the multiplexing and aggregation (MAP) ether type 0x00F9. This is needed for receiving data in the MAP protocol like RMNET. This is not an officially registered ID. Signed-off-by: Subash Abhinov Kasiviswanathan --- include/uapi/linux/if_ether.h | 1 + 1 file

[PATCH net-next 3/8] bpf: Allow cgroup sock filters to use get_current_uid_gid helper

2017-08-22 Thread David Ahern
Allow BPF programs run on sock create to use the get_current_uid_gid helper. Signed-off-by: David Ahern --- net/core/filter.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index

[PATCH net-next 2/8] bpf: Add mark and priority to sock options that can be set

2017-08-22 Thread David Ahern
Add socket mark and priority to fields that can be set by ebpf program when a socket is created. Signed-off-by: David Ahern --- include/uapi/linux/bpf.h | 2 ++ net/core/filter.c| 26 ++ 2 files changed, 28 insertions(+) diff --git

[PATCH net-next 8/8] samples/bpf: Update cgroup socket examples to use uid gid helper

2017-08-22 Thread David Ahern
Signed-off-by: David Ahern --- samples/bpf/sock_flags_kern.c | 5 + samples/bpf/test_cgrp2_sock.c | 12 +++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/samples/bpf/sock_flags_kern.c b/samples/bpf/sock_flags_kern.c index

[PATCH net-next 6/8] samples/bpf: Add option to dump socket settings

2017-08-22 Thread David Ahern
Add option to dump socket settings. Will be used in the next patch to verify bpf programs are correctly setting mark, priority and device based on the cgroup attachment for the program run. Signed-off-by: David Ahern --- samples/bpf/test_cgrp2_sock.c | 75

[PATCH net-next 3/3 v8] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-22 Thread Subash Abhinov Kasiviswanathan
RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single

[PATCH net-next 0/3 v8] Add support for rmnet driver

2017-08-22 Thread Subash Abhinov Kasiviswanathan
This patch adds support for the rmnet driver which is required to support recent chipsets using Qualcomm Technologies, Inc. modems. The data from hardware follows the multiplexing and aggregation protocol (MAP). This driver can be used to register onto any physical network device in IP mode.

[PATCH net-next 0/8] bpf: Add option to set mark and priority in cgroup sock programs

2017-08-22 Thread David Ahern
Add option to set mark and priority in addition to bound device for newly created sockets. Also, allow the bpf programs to use the get_current_uid_gid helper meaning socket marks, priority and device can be set base on the uid/gid of the running process. For flexbility in deploying these

[PATCH net-next 5/8] bpf/samples: Add detach option to test_cgrp2_sock

2017-08-22 Thread David Ahern
Add option to detach programs from a cgroup. Signed-off-by: David Ahern --- samples/bpf/test_cgrp2_sock.c | 48 ++- 1 file changed, 34 insertions(+), 14 deletions(-) diff --git a/samples/bpf/test_cgrp2_sock.c

[PATCH net-next 7/8] samples/bpf: Add test case for nested socket options

2017-08-22 Thread David Ahern
Signed-off-by: David Ahern --- samples/bpf/test_cgrp2_sock3.sh | 118 1 file changed, 118 insertions(+) create mode 100755 samples/bpf/test_cgrp2_sock3.sh diff --git a/samples/bpf/test_cgrp2_sock3.sh b/samples/bpf/test_cgrp2_sock3.sh

[PATCH v2 2/2] selftests/net: add test to verify datagram socket timeout

2017-08-22 Thread Vallish Vaidyeshwara
AF_UNIX and AF_INET datagram sockets use high resolution timer to time SO_RCVTIMEO value used with setsockopt(2). This test checks for the accuracy of kernel notifying these sockets timeout to application. Test program has code to check AF_UNIX socket, however the kernel function used to timeout

[PATCH v2 0/2] enable hires timer to timeout datagram socket

2017-08-22 Thread Vallish Vaidyeshwara
v1->v2: - Cong Wang pointed out MAX_SCHEDULE_TIMEOUT wraparound, fixed the patch 1/2 to accommodate MAX_SCHEDULE_TIMEOUT wait time - Changed format of printing total time from float to long in selftests patch 2/2 Hello Dave, Resending the patch series to include netdev mailing list with

[PATCH v2 1/2] net: enable high resolution timer mode to timeout datagram sockets

2017-08-22 Thread Vallish Vaidyeshwara
Enable high resolution timer mode to time SO_RCVTIMEO value used with setsockopt(2) on AF_UNIX and AF_INET datagram sockets. By default, SO_RCVTIMEO uses low resolution timer which is good for most of socket use cases. Background: Kernel timer wheel was refactored in 4.8 to avoid drawbacks with

[trivial] gre: fix goto statement typo

2017-08-22 Thread William Tu
Fix typo: pnet_tap_faied. Signed-off-by: William Tu --- net/ipv4/ip_gre.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 6e8a62289e03..5a20ba9b9b50 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@

[PATCH net-next 0/2] Two minor BPF cleanups

2017-08-22 Thread Daniel Borkmann
Two minor cleanups on devmap and redirect I still had in my queue. Thanks! Daniel Borkmann (2): bpf: misc xdp redirect cleanups bpf: minor cleanups for dev_map kernel/bpf/devmap.c | 100 +--- net/core/filter.c | 72

[PATCH net-next 2/2] bpf: minor cleanups for dev_map

2017-08-22 Thread Daniel Borkmann
Some minor code cleanups, while going over it I also noticed that we're accounting the bitmap only for one CPU currently, so fix that up as well. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- kernel/bpf/devmap.c | 100

[PATCH net-next 1/2] bpf: misc xdp redirect cleanups

2017-08-22 Thread Daniel Borkmann
Few cleanups including: bpf_redirect_map() is really XDP only due to the return code. Move it to a more appropriate location where we do the XDP redirect handling and change it's name into bpf_xdp_redirect_map() to make it consistent to the bpf_xdp_redirect() helper. xdp_do_redirect_map() helper

linux-next: build warning after merge of the net tree

2017-08-22 Thread Stephen Rothwell
Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: net/ipv6/route.c: In function 'rt6_check': net/ipv6/route.c:1294:43: warning: 'rt_cookie' may be used uninitialized in this function [-Wmaybe-uninitialized] if (!rt6_get_cookie_safe(rt,

Re: [PATCH net] fsl/man: Inherit parent device and of_node

2017-08-22 Thread David Miller
From: Florian Fainelli Date: Tue, 22 Aug 2017 15:24:47 -0700 > Junote Cai reported that he was not able to get a DSA setup involving the > Freescale DPAA/FMAN driver to work and narrowed it down to > of_find_net_device_by_node(). This function requires the network device's

Re: [PATCH][net-next] MIPS,bpf: fix missing break in switch statement

2017-08-22 Thread David Miller
From: Colin King Date: Tue, 22 Aug 2017 23:46:06 +0100 > From: Colin Ian King > > There is a missing break causing a fall-through and setting > ctx.use_bbit_insns to the wrong value. Fix this by adding the > missing break. > > Detected with

[PATCH][net-next] MIPS,bpf: fix missing break in switch statement

2017-08-22 Thread Colin King
From: Colin Ian King There is a missing break causing a fall-through and setting ctx.use_bbit_insns to the wrong value. Fix this by adding the missing break. Detected with cppcheck: "Variable 'ctx.use_bbit_insns' is reassigned a value before the old one has been used.

Re: [PATCH net] bpf: fix map value attribute for hash of maps

2017-08-22 Thread Martin KaFai Lau
On Wed, Aug 23, 2017 at 12:06:09AM +0200, Daniel Borkmann wrote: > Currently, iproute2's BPF ELF loader works fine with array of maps > when retrieving the fd from a pinned node and doing a selfcheck > against the provided map attributes from the object file, but we > fail to do the same for hash

Re: [PATCH net-next v5] openvswitch: enable NSH support

2017-08-22 Thread kbuild test robot
Hi Yi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Yi-Yang/openvswitch-enable-NSH-support/20170822-184251 config: x86_64-randconfig-a0-08230538 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce: # save the attached

[PATCH net] fsl/man: Inherit parent device and of_node

2017-08-22 Thread Florian Fainelli
Junote Cai reported that he was not able to get a DSA setup involving the Freescale DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node(). This function requires the network device's device reference to be correctly set which is the case here, though we have lost any

[PATCH net v2 0/2] net: dsa: Fix tag_ksz.c

2017-08-22 Thread Florian Fainelli
This implements David's suggestion of providing low-level functions to control whether skb_pad() and skb_put_padto() should be freeing the passed skb. We make use of it to fix a double free in net/dsa/tag_ksz.c that would occur if we kept using skb_put_padto() in both places. Florian Fainelli

[PATCH net v2 1/2] net: core: Specify skb_pad()/skb_put_padto() SKB freeing

2017-08-22 Thread Florian Fainelli
Rename skb_pad() into __skb_pad() and make it take a third argument: free_on_error which controls whether kfree_skb() should be called or not, skb_pad() directly makes use of it and passes true to preserve its existing behavior. Do exactly the same thing with __skb_put_padto() and skb_put_padto().

[PATCH net v2 2/2] net: dsa: skb_put_padto() already frees nskb

2017-08-22 Thread Florian Fainelli
The first call of skb_put_padto() will free up the SKB on error, but we return NULL which tells dsa_slave_xmit() that the original SKB should be freed so this would lead to a double free here. The second skb_put_padto() already frees the passed sk_buff reference upon error, so calling kfree_skb()

Re: [PATCH v12 7/8] wireless: ipw2200: Replace PCI pool old API

2017-08-22 Thread Stanislav Yakovlev
On 22 August 2017 at 07:47, Romain Perier wrote: > The PCI pool API is deprecated. This commit replaces the PCI pool old > API by the appropriate function with the DMA pool API. > > Signed-off-by: Romain Perier > Reviewed-by: Peter Senna

[PATCH net] bpf: fix map value attribute for hash of maps

2017-08-22 Thread Daniel Borkmann
Currently, iproute2's BPF ELF loader works fine with array of maps when retrieving the fd from a pinned node and doing a selfcheck against the provided map attributes from the object file, but we fail to do the same for hash of maps and thus refuse to get the map from pinned node. Reason is that

Re: [PATCH net-next v7 05/10] landlock: Add LSM hooks related to filesystem

2017-08-22 Thread Mickaël Salaün
On 21/08/2017 02:09, Mickaël Salaün wrote: > Handle 33 filesystem-related LSM hooks for the Landlock filesystem > event: LANDLOCK_SUBTYPE_EVENT_FS. > > A Landlock event wrap LSM hooks for similar kernel object types (e.g. > struct file, struct path...). Multiple LSM hooks can trigger the same >

Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()

2017-08-22 Thread David Miller
From: Florian Fainelli Date: Tue, 22 Aug 2017 14:45:44 -0700 > On 08/22/2017 02:44 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Tue, 22 Aug 2017 14:26:47 -0700 >> >>> Priit reported that stmmac was crashing with the trace below. This is

RE: [PATCH v2] i40e/i40evf: fix out-of-bounds read of cpumask

2017-08-22 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Stefano Brivio > Sent: Tuesday, August 22, 2017 2:24 PM > To: Keller, Jacob E > Cc: Intel Wired LAN ; >

Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()

2017-08-22 Thread Florian Fainelli
On 08/22/2017 02:44 PM, David Miller wrote: > From: Florian Fainelli > Date: Tue, 22 Aug 2017 14:26:47 -0700 > >> Priit reported that stmmac was crashing with the trace below. This is because >> phy_attached_print() is called too early right after the PHY device has been >>

Re: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()

2017-08-22 Thread David Miller
From: Florian Fainelli Date: Tue, 22 Aug 2017 14:26:47 -0700 > Priit reported that stmmac was crashing with the trace below. This is because > phy_attached_print() is called too early right after the PHY device has been > found, but before it has a driver attached, since

Re: [patch net 0/2] net: sched: couple of chain fixes

2017-08-22 Thread David Miller
From: Jiri Pirko Date: Tue, 22 Aug 2017 22:46:48 +0200 > From: Jiri Pirko > > Jiri Pirko (2): > net: sched: fix use after free when tcf_chain_destroy is called > multiple times > net: sched: don't do tcf_chain_flush from tcf_chain_destroy Series

RE: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-22 Thread Dexuan Cui
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote: > > > > +static bool hvs_stream_allow(u32 cid, u32 port) > > > > +{ > > > > + static const u32 valid_cids[] = { > > > > + VMADDR_CID_ANY, > > > > > > Is this for

Re: [PATCH v2 net-next 2/2] selftests/net: Add a test to validate behavior of rx timestamps

2017-08-22 Thread Willem de Bruijn
On Tue, Aug 22, 2017 at 5:08 PM, Mike Maloney wrote: > From: Mike Maloney > > Validate the behavior of the combination of various timestamp socket > options, and ensure consistency across ip, udp, and tcp. > > Signed-off-by: Mike Maloney

Re: [PATCH net-next] net: sched: use kvmalloc() for class hash tables

2017-08-22 Thread David Miller
From: Eric Dumazet Date: Tue, 22 Aug 2017 12:26:46 -0700 > From: Eric Dumazet > > High order GFP_KERNEL allocations can stress the host badly. > > Use modern kvmalloc_array()/kvfree() instead of custom > allocations. > > Signed-off-by: Eric

Re: [PATCH] net: amd: constify zorro_device_id

2017-08-22 Thread David Miller
From: Arvind Yadav Date: Tue, 22 Aug 2017 23:41:12 +0530 > zorro_device_id are not supposed to change at runtime. All functions > working with zorro_device_id provided by work with > const zorro_device_id. So mark the non-const structs as const. > > Signed-off-by:

Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

2017-08-22 Thread David Miller
From: Madalin Bucur Date: Tue, 22 Aug 2017 20:31:01 +0300 > /** > + * fman_get_keygen > + * > + * @fman:A Pointer to FMan device > + * > + * Get the handle to KeyGen module part of FM driver > + * > + * Return: Handle to KeyGen > + */ > +struct fman_keygen

Re: [PATCH net-next v2 00/10] net: mvpp2: MAC/GoP configuration

2017-08-22 Thread David Miller
From: Antoine Tenart Date: Tue, 22 Aug 2017 19:08:20 +0200 > This is based on net-next (e2a7c34fb285). > > I removed the GoP interrupt and PHY optional parts in this v2 to ease > the review process as the MAC/GoP initialization seemed to start less >

Re: [PATCH v2 net-next 1/2] tcp: Extend SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg

2017-08-22 Thread Willem de Bruijn
On Tue, Aug 22, 2017 at 5:08 PM, Mike Maloney wrote: > From: Mike Maloney > > When SOF_TIMESTAMPING_RX_SOFTWARE is enabled for tcp sockets, return the > timestamp corresponding to the highest sequence number data returned. > > Previously the

Re: [PATCH net-next 5/5] xdp: get tracepoints xdp_exception and xdp_redirect in sync

2017-08-22 Thread Daniel Borkmann
On 08/22/2017 10:47 PM, Jesper Dangaard Brouer wrote: Remove the net_device string name from the xdp_exception tracepoint, like the xdp_redirect tracepoint. Align the TP_STRUCT to have common entries between these two tracepoint. Signed-off-by: Jesper Dangaard Brouer ---

Re: [PATCHv4 net-next] gre: introduce native tunnel support for ERSPAN

2017-08-22 Thread David Miller
From: William Tu Date: Tue, 22 Aug 2017 09:40:28 -0700 > The patch adds ERSPAN type II tunnel support. The implementation > is based on the draft at [1]. One of the purposes is for Linux > box to be able to receive ERSPAN monitoring traffic sent from > the Cisco switch, by

Re: [PATCH v2 net] udp: on peeking bad csum, drop packets even if not at head

2017-08-22 Thread David Miller
From: Eric Dumazet Date: Tue, 22 Aug 2017 09:39:28 -0700 > From: Eric Dumazet > > When peeking, if a bad csum is discovered, the skb is unlinked from > the queue with __sk_queue_drop_skb and the peek operation restarted. > > __sk_queue_drop_skb

Re: [PATCH net-next] udp: remove unreachable ufo branches

2017-08-22 Thread David Miller
From: Willem de Bruijn Date: Tue, 22 Aug 2017 11:39:57 -0400 > From: Willem de Bruijn > > Remove two references to ufo in the udp send path that are no longer > reachable now that ufo has been removed. > > Commit 85f1bd9a7b5a ("udp:

[PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()

2017-08-22 Thread Florian Fainelli
Priit reported that stmmac was crashing with the trace below. This is because phy_attached_print() is called too early right after the PHY device has been found, but before it has a driver attached, since that is only done in phy_probe() which occurs later. Fix this by dealing with a possibly

Re: [PATCH net] macsec: add genl family module alias

2017-08-22 Thread David Miller
From: Sabrina Dubroca Date: Tue, 22 Aug 2017 15:36:08 +0200 > This helps tools such as wpa_supplicant can start even if the macsec > module isn't loaded yet. > > Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") > Signed-off-by: Sabrina Dubroca

Re: [PATCH net v1 0/2] tipc: topology server fixes

2017-08-22 Thread David Miller
From: Parthasarathy Bhuvaragan Date: Tue, 22 Aug 2017 12:28:39 +0200 > The following commits fixes two race conditions causing general > protection faults. Series applied, thank you.

Re: [PATCH] net: mdio-gpio: make mdiobb_ops const

2017-08-22 Thread David Miller
From: Bhumika Goyal Date: Tue, 22 Aug 2017 13:43:29 +0530 > Make this const as it is only stored in a const field of a > mdiobb_ctrl structure. > > Signed-off-by: Bhumika Goyal Applied.

Re: [PATCH v2] i40e/i40evf: fix out-of-bounds read of cpumask

2017-08-22 Thread Stefano Brivio
[Fixed Cc: address for stable, Cc'ed Juergen] On Tue, 22 Aug 2017 14:04:42 -0700 Jacob Keller wrote: > When responding to an affinity hint we directly copied a cpumask value, > intsead of using cpumask_copy. According to cpumask.h this is not > correct because

Re: [patch net] mlxsw: spectrum_switchdev: Fix mrouter flag update

2017-08-22 Thread David Miller
From: Jiri Pirko Date: Tue, 22 Aug 2017 10:28:11 +0200 > From: Nogah Frankel > > Update the value of the mrouter flag in struct mlxsw_sp_bridge_port when > it is being changed. > > Fixes: c57529e1d5d8 ("mlxsw: spectrum: Replace vPorts with Port-VLAN") >

Re: [PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const

2017-08-22 Thread David Miller
From: Bhumika Goyal Date: Tue, 22 Aug 2017 13:45:59 +0530 > Make this const as it is only stored in a const field of a > mdiobb_ctrl structure. > > Signed-off-by: Bhumika Goyal Applied.

Re: [PATCH net-next 4/5] xdp: remove net_device names from xdp_redirect tracepoint

2017-08-22 Thread Daniel Borkmann
On 08/22/2017 10:47 PM, Jesper Dangaard Brouer wrote: There is too much overhead in the current trace_xdp_redirect tracepoint as it does strcpy and strlen on the net_device names. Besides, exposing the ifindex/index is actually the information that is needed in the tracepoint to diagnose

Re: [PATCH net-next 3/5] ixgbe: use return codes from ndo_xdp_xmit that are distinguishable

2017-08-22 Thread Daniel Borkmann
On 08/22/2017 10:47 PM, Jesper Dangaard Brouer wrote: For XDP_REDIRECT the use of return code -EINVAL is confusing, as it is used in three different cases. (1) When the index or ifindex lookup fails, and in the ixgbe driver (2) when link is down and (3) when XDP have not been enabled. The

Re: [PATCH net-next] net: sched: use kvmalloc() for class hash tables

2017-08-22 Thread Alexei Starovoitov
On Tue, Aug 22, 2017 at 12:26:46PM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > High order GFP_KERNEL allocations can stress the host badly. > > Use modern kvmalloc_array()/kvfree() instead of custom > allocations. > > Signed-off-by: Eric Dumazet

Re: [PATCH net-next 2/5] xdp: make generic xdp redirect use tracepoint trace_xdp_redirect

2017-08-22 Thread Daniel Borkmann
On 08/22/2017 10:47 PM, Jesper Dangaard Brouer wrote: If the xdp_do_generic_redirect() call fails, it trigger the trace_xdp_exception tracepoint. It seems better to use the same tracepoint trace_xdp_redirect, as the native xdp_do_redirect{,_map} does. Signed-off-by: Jesper Dangaard Brouer

Re: [PATCH] net: ethernet: ax88796: make mdiobb_ops const

2017-08-22 Thread David Miller
From: Bhumika Goyal Date: Tue, 22 Aug 2017 13:41:19 +0530 > Make this const as it is only stored in a const field of a > mdiobb_ctrl structure. > > Signed-off-by: Bhumika Goyal Applied.

Re: [PATCH net-next 1/5] xdp: remove bpf_warn_invalid_xdp_redirect

2017-08-22 Thread Daniel Borkmann
On 08/22/2017 10:47 PM, Jesper Dangaard Brouer wrote: Given there is a tracepoint that can track the error code of xdp_do_redirect calls, the WARN_ONCE in bpf_warn_invalid_xdp_redirect doesn't seem relevant any longer. Simply remove the function. Signed-off-by: Jesper Dangaard Brouer

Re: [PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY

2017-08-22 Thread David Miller
From: Andrew Jeffery Date: Tue, 22 Aug 2017 16:06:22 +0930 > netif_napi_del() should be paired with netif_napi_add(), however no > such call takes place in ftgmac100_probe(). This triggers a NULL > pointer dereference if e.g. no PHY is found by the MDIO probe: ... >

Re: [PATCH net-next v3 0/2] Simplify the tcp_conn_request.

2017-08-22 Thread David Miller
From: Tonghao Zhang Date: Mon, 21 Aug 2017 23:33:47 -0700 > Just simplify the tcp_conn_request function. Series applied, thanks. The explicit 'dst = NULL' in the variable declaration is probably superfluous now. And in fact it was hiding the bug that we didn't have a

Re: [PATCH 0/2] net: Fix crashes due to activity during suspend

2017-08-22 Thread Geert Uytterhoeven
Hi Florian, On Tue, Aug 22, 2017 at 8:49 PM, Florian Fainelli wrote: > On 08/22/2017 11:37 AM, Geert Uytterhoeven wrote: >> If an Ethernet device is used while the device is suspended, the system may >> crash. >> >> E.g. on sh73a0/kzm9g and r8a73a4/ape6evm, the external

RE: [PATCH v2] i40e/i40evf: fix out-of-bounds read of cpumask

2017-08-22 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Jacob Keller > Sent: Tuesday, August 22, 2017 2:05 PM > To: Intel Wired LAN > Cc: netdev@vger.kernel.org; Keller, Jacob E

[PATCH v2 net-next 2/2] selftests/net: Add a test to validate behavior of rx timestamps

2017-08-22 Thread Mike Maloney
From: Mike Maloney Validate the behavior of the combination of various timestamp socket options, and ensure consistency across ip, udp, and tcp. Signed-off-by: Mike Maloney --- .../selftests/networking/timestamping/.gitignore | 1 +

[PATCH v2 net-next 1/2] tcp: Extend SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg

2017-08-22 Thread Mike Maloney
From: Mike Maloney When SOF_TIMESTAMPING_RX_SOFTWARE is enabled for tcp sockets, return the timestamp corresponding to the highest sequence number data returned. Previously the skb->tstamp is overwritten when a TCP packet is placed in the out of order queue. While the

[PATCH v2 net-next 0/2] Add software rx timestamp for TCP.

2017-08-22 Thread Mike Maloney
From: Mike Maloney Add software rx timestamps for TCP, and a test to ensure consistency of behavior between IP, UDP, and TCP implementation. Changes since v1: -Initialize tss->ts[1] to 0 if caller requested any timestamps. -Fix test case to validate that tss->ts[1] is

Re: [PATCH net-next,0/4] hv_netvsc: Ethtool handler to change UDP hash levels

2017-08-22 Thread David Miller
From: Haiyang Zhang Date: Mon, 21 Aug 2017 19:22:36 -0700 > From: Haiyang Zhang > > The patch set adds the functions to switch UDP hash level between > L3 and L4 by ethtool command. UDP over IPv4 and v6 can be set > differently. The

[PATCH v2] i40e/i40evf: fix out-of-bounds read of cpumask

2017-08-22 Thread Jacob Keller
When responding to an affinity hint we directly copied a cpumask value, intsead of using cpumask_copy. According to cpumask.h this is not correct because cpumask_t is only guaranteed to have enough space for the number of CPUs in the system, and may not be as big as we expect. Thus a direct copy

[PATCH] e1000: changed some expensive calls of udelay to usleep_range

2017-08-22 Thread nxf23276
Calls to udelay are not preemtable by userspace so userspace applications experience a large (~200us) latency when running on core 0. Instead usleep_range can be used to be more friendly to userspace since it is preemtable. This is due to udelay using busy-wait loops while

Re: [PATCH net] net/hsr: Check skb_put_padto() return value

2017-08-22 Thread David Miller
From: Florian Fainelli Date: Mon, 21 Aug 2017 12:59:10 -0700 > skb_put_padto() will free the sk_buff passed as reference in case of > errors, but we still need to check its return value and decide what to > do. > > Detected by CoverityScan, CID#1416688 ("CHECKED_RETURN") >

[patch net 0/2] net: sched: couple of chain fixes

2017-08-22 Thread Jiri Pirko
From: Jiri Pirko Jiri Pirko (2): net: sched: fix use after free when tcf_chain_destroy is called multiple times net: sched: don't do tcf_chain_flush from tcf_chain_destroy net/sched/cls_api.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) --

[PATCH net-next 4/5] xdp: remove net_device names from xdp_redirect tracepoint

2017-08-22 Thread Jesper Dangaard Brouer
There is too much overhead in the current trace_xdp_redirect tracepoint as it does strcpy and strlen on the net_device names. Besides, exposing the ifindex/index is actually the information that is needed in the tracepoint to diagnose issues. When a lookup fails (either ifindex or devmap index)

[PATCH net-next 5/5] xdp: get tracepoints xdp_exception and xdp_redirect in sync

2017-08-22 Thread Jesper Dangaard Brouer
Remove the net_device string name from the xdp_exception tracepoint, like the xdp_redirect tracepoint. Align the TP_STRUCT to have common entries between these two tracepoint. Signed-off-by: Jesper Dangaard Brouer --- include/trace/events/xdp.h | 24

RE: [patch net-next] net/sched: Fix the logic error to decide the ingress qdisc

2017-08-22 Thread Chopra, Manish
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Chris Mi Sent: Friday, August 18, 2017 4:54 PM To: netdev@vger.kernel.org Cc: da...@davemloft.net; j...@resnulli.us Subject: [patch net-next] net/sched: Fix the logic error to decide

  1   2   3   >