Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-28 Thread Greg KH
On Mon, Aug 28, 2017 at 04:46:07PM -0700, Joe Perches wrote: > On Mon, 2017-08-28 at 16:42 -0700, David Miller wrote: > > From: Greg Kroah-Hartman > > Date: Sun, 27 Aug 2017 17:03:30 +0200 > > > > > The IRDA code has long been obsolete and broken.  So, to keep people

Re: [PATCH net 0/4] xfrm_user info leaks

2017-08-28 Thread Steffen Klassert
On Mon, Aug 28, 2017 at 03:52:32PM -0700, David Miller wrote: > From: Mathias Krause > Date: Sat, 26 Aug 2017 17:08:56 +0200 > > > Hi David, Steffen, > > > > the following series fixes a few info leaks due to missing padding byte > > initialization in the xfrm_user

Re: [PATCH net-next] hinic: don't build the module by default

2017-08-28 Thread David Miller
From: Vitaly Kuznetsov Date: Mon, 28 Aug 2017 15:16:05 +0200 > We probably don't want to enable code supporting particular hardware by > default e.g. when someone does 'make defconfig'. Other ethernet modules > don't do it. > > Signed-off-by: Vitaly Kuznetsov

Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface

2017-08-28 Thread David Miller
From: Vivien Didelot Date: Mon, 28 Aug 2017 15:17:38 -0400 > This patch series adds a generic debugfs interface for the DSA > framework, so that all switch devices benefit from it, e.g. Marvell, > Broadcom, Microchip or any other DSA driver. I've been

Re: [net-next] be2net: use shift instead of expensive divide

2017-08-28 Thread David Miller
From: Zhang Shengju Date: Tue, 29 Aug 2017 11:18:39 +0800 > Replace shift instead of expensive divide. > > Signed-off-by: Zhang Shengju The divide is more easier to understand, and it costs the same as a shift if the types

[PATCH net-next v2] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
From: Roopa Prabhu A few useful tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu --- v2 - address comments from Florian include/trace/events/bridge.h | 98 +

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread David Miller
From: 严海双 Date: Tue, 29 Aug 2017 09:04:57 +0800 > The GET_TX_COMPL_BITS comes from amap_get which also returns a 32-bit value: It never returns a value with more than 16-bits of significance for this specific call. Please stop trying to be semantically clever

Re: [PATCH net] net: dsa: Don't dereference dst->cpu_dp->netdev

2017-08-28 Thread David Miller
From: Florian Fainelli Date: Mon, 28 Aug 2017 17:10:51 -0700 > If we do not have a master network device attached dst->cpu_dp will be > NULL and accessing cpu_dp->netdev will create a trace similar to the one > below. The correct check is on dst->cpu_dp period. ... >

Re: net.ipv4.tcp_max_syn_backlog implementation

2017-08-28 Thread Eric Dumazet
On Mon, 2017-08-28 at 23:47 -0400, Harsha Chenji wrote: > So I have ubuntu 12.04 x32 in a VM with syncookies turned off. I tried > to do a syn flood (with netwox) on 3 different processes. Each of them > returns a different value with netstat -na | grep -c RECV : > > nc -l returns 16

Re: net.ipv4.tcp_max_syn_backlog implementation

2017-08-28 Thread Willy Tarreau
On Mon, Aug 28, 2017 at 11:47:41PM -0400, Harsha Chenji wrote: > So I have ubuntu 12.04 x32 in a VM with syncookies turned off. I tried > to do a syn flood (with netwox) on 3 different processes. Each of them > returns a different value with netstat -na | grep -c RECV : > > nc -l returns 16

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 08:22:31PM -0600, David Ahern wrote: > On 8/28/17 7:12 PM, Alexei Starovoitov wrote: > To consider what happens on doubling back and changing programs in the > hierarchy, start with $MNT/a/b/c from 3 above (non-recursive on 'a', > recursive on 'b' and

net.ipv4.tcp_max_syn_backlog implementation

2017-08-28 Thread Harsha Chenji
So I have ubuntu 12.04 x32 in a VM with syncookies turned off. I tried to do a syn flood (with netwox) on 3 different processes. Each of them returns a different value with netstat -na | grep -c RECV : nc -l returns 16 (netcat-traditional) apache2 port 80 returns 256 vsftpd on 21 returns 64.

Re: [net-next] be2net: use shift instead of expensive divide

2017-08-28 Thread Joe Perches
On Tue, 2017-08-29 at 11:18 +0800, Zhang Shengju wrote: > Replace shift instead of expensive divide. This change is mostly pointless. Any half-way decent compiler should produce the same object. gcc emits the same object with the old code. The AMAP_GET_BITS macro uses the "offsetof(struct,

Re: Hooking on L4 Level with process information

2017-08-28 Thread Ravish Kumar
Not convinced with this . A process open a socket and that socket is associated with that particular process unless it shares the file descriptors. Can you explain why it is not related , at a time a socket will be opened by a particular process. On Tue, Aug 29, 2017 at 8:49 AM, Stephen

RE: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Chris Mi
> -Original Message- > From: Simon Horman [mailto:simon.hor...@netronome.com] > Sent: Monday, August 28, 2017 7:37 PM > To: Chris Mi > Cc: netdev@vger.kernel.org; j...@mojatatu.com; > xiyou.wangc...@gmail.com; j...@resnulli.us; da...@davemloft.net; >

Re: Hooking on L4 Level with process information

2017-08-28 Thread Stephen Hemminger
On Tue, 29 Aug 2017 07:34:51 +0530 Ravish Kumar wrote: > Hi, > > I want to hook tcp/udp packets on L4 Layer and based on process > information , content want to deny or allow packets. > > Netfilter provides pre/post Routing hooks but not sure that will be > right place

[net-next] be2net: use shift instead of expensive divide

2017-08-28 Thread Zhang Shengju
Replace shift instead of expensive divide. Signed-off-by: Zhang Shengju --- drivers/net/ethernet/emulex/benet/be_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c

Re: [PATCH net-next 1/3 v9] net: ether: Add support for multiplexing and aggregation type

2017-08-28 Thread Subash Abhinov Kasiviswanathan
On 2017-08-28 16:22, Dan Williams wrote: On Thu, 2017-08-24 at 22:39 -0600, Subash Abhinov Kasiviswanathan wrote: Define the multiplexing and aggregation (MAP) ether type 0x00F9. This is needed for receiving data in the MAP protocol like RMNET. This is not an officially registered ID.

Re: [patch net-next 11/12] mlxsw: spectrum_dpipe: Add support for IPv4 host table dump

2017-08-28 Thread David Ahern
On 8/27/17 2:31 AM, Arkadi Sharshevsky wrote: >> Also, this dpipe capability seems to be just dumping data structures >> maintained by the driver. ie., you can compare the mlxsw view of >> networking state to IPv4 and IPv6 level tables. Any plans to offer a >> command that reads data from the h/w

[net-next:master 1466/1469] drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:48:10: error: implicit declaration of function 'bnxt_vf_rep_get_fid'

2017-08-28 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: acae4b48856838d71d548ab6610a99d8e32653e4 commit: 2ae7408fedfee979e01ed3801223c632bb124c46 [1466/1469] bnxt_en: bnxt: add TC flower filter offload support config: x86_64-randconfig-b0-08290613 (attached as

RE: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-28 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Tuesday, August 22, 2017 21:21 > > ... > > ... > > The only problem here would be the potential for a guest and a host app > to > > have a conflict wrt port numbers, even though they would be able to > > operate fine, if restricted to their appropriate transport. > > > >

linux-next: manual merge of the net-next tree with the net tree

2017-08-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/marvell/mvpp2.c between commit: 4c2286826451 ("net: mvpp2: fix the mac address used when using PPv2.2") from the net tree and commits: 09f8397553a2 ("net: mvpp2: introduce per-port nrxqs/ntxqs

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-28 Thread David Ahern
On 8/28/17 7:12 PM, Alexei Starovoitov wrote: To consider what happens on doubling back and changing programs in the hierarchy, start with $MNT/a/b/c from 3 above (non-recursive on 'a', recursive on 'b' and recursive on 'c') for each of the following cases: 1. Program

Hooking on L4 Level with process information

2017-08-28 Thread Ravish Kumar
Hi, I want to hook tcp/udp packets on L4 Layer and based on process information , content want to deny or allow packets. Netfilter provides pre/post Routing hooks but not sure that will be right place so thought of asking whether my approach is right. Also how i can get process information

Re: Permissions for eBPF objects

2017-08-28 Thread Chenbo Feng
On Mon, Aug 28, 2017 at 6:15 PM, Alexei Starovoitov wrote: > On Mon, Aug 28, 2017 at 05:47:19PM -0700, Chenbo Feng wrote: >> On Fri, Aug 25, 2017 at 6:03 PM, Alexei Starovoitov >> wrote: >> > On Fri, Aug 25, 2017 at 10:07:27PM +0200,

RE: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Chris Mi
> -Original Message- > From: Jamal Hadi Salim [mailto:j...@mojatatu.com] > Sent: Tuesday, August 29, 2017 5:56 AM > To: Chris Mi ; netdev@vger.kernel.org > Cc: xiyou.wangc...@gmail.com; j...@resnulli.us; da...@davemloft.net; > mawil...@microsoft.com > Subject: Re:

Re: Permissions for eBPF objects

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 05:47:19PM -0700, Chenbo Feng wrote: > On Fri, Aug 25, 2017 at 6:03 PM, Alexei Starovoitov > wrote: > > On Fri, Aug 25, 2017 at 10:07:27PM +0200, Daniel Borkmann wrote: > >> On 08/25/2017 09:52 PM, Chenbo Feng wrote: > >> > On Fri, Aug 25,

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-28 Thread Alexei Starovoitov
On Mon, Aug 28, 2017 at 06:43:42PM -0600, David Ahern wrote: > On 8/28/17 5:56 PM, Alexei Starovoitov wrote: > > On Sun, Aug 27, 2017 at 08:49:23AM -0600, David Ahern wrote: > >> > >> The override flag is independent of the recursive flag. If the override > >> flag does not allow an override, the

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread 严海双
> On 2017年8月29日, at 上午7:19, David Miller wrote: > > From: Haishuang Yan > Date: Sun, 27 Aug 2017 15:24:45 +0800 > >> In be_tx_compl_process, frag_index declared as u32, so it's better to >> declare last_index as u32 also. >> >> CC: Ajit

Re: Permissions for eBPF objects

2017-08-28 Thread Chenbo Feng
On Fri, Aug 25, 2017 at 6:03 PM, Alexei Starovoitov wrote: > On Fri, Aug 25, 2017 at 10:07:27PM +0200, Daniel Borkmann wrote: >> On 08/25/2017 09:52 PM, Chenbo Feng wrote: >> > On Fri, Aug 25, 2017 at 12:45 PM, Jeffrey Vander Stoep >> > wrote: >>

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-28 Thread David Ahern
On 8/28/17 5:56 PM, Alexei Starovoitov wrote: > On Sun, Aug 27, 2017 at 08:49:23AM -0600, David Ahern wrote: >> >> The override flag is independent of the recursive flag. If the override >> flag does not allow an override, the attempt to add a new program fails. >> The recursive flag brings an

[PATCH net] net: dsa: Don't dereference dst->cpu_dp->netdev

2017-08-28 Thread Florian Fainelli
If we do not have a master network device attached dst->cpu_dp will be NULL and accessing cpu_dp->netdev will create a trace similar to the one below. The correct check is on dst->cpu_dp period. [1.004650] DSA: switch 0 0 parsed [1.008078] Unable to handle kernel NULL pointer dereference

[RESEND PATCH] Allow passing tid or pid in SCM_CREDENTIALS without CAP_SYS_ADMIN

2017-08-28 Thread Prakash Sangappa
Currently passing tid(gettid(2)) of a thread in struct ucred in SCM_CREDENTIALS message requires CAP_SYS_ADMIN capability otherwise it fails with EPERM error. Some applications deal with thread id of a thread(tid) and so it would help to allow tid in SCM_CREDENTIALS message. Basically, either

Re: [PATCH net-next 00/11] bnxt_en: Updates.

2017-08-28 Thread David Miller
From: Michael Chan Date: Mon, 28 Aug 2017 13:40:24 -0400 > Various changes including updated firmware interface, improved TX ring > allocation scheme, improved out-of-memory logic in NAPI loop, reduced > default rings on multi-port devices, new PCI IDs. Of particular

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-28 Thread Alexei Starovoitov
On Sun, Aug 27, 2017 at 08:49:23AM -0600, David Ahern wrote: > > The override flag is independent of the recursive flag. If the override > flag does not allow an override, the attempt to add a new program fails. > The recursive flag brings an additional constraint: once a cgroup has a > program

Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-28 Thread David Miller
From: Samuel Mendoza-Jonas Date: Mon, 28 Aug 2017 16:18:40 +1000 > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. > A fair amount of code already exists in the NCSI stack for VLAN filtering but > none of it is actually hooked up. This goes the

Re: [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-08-27

2017-08-28 Thread David Miller
From: Jeff Kirsher Date: Sun, 27 Aug 2017 17:15:48 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-28 Thread Joe Perches
On Mon, 2017-08-28 at 16:42 -0700, David Miller wrote: > From: Greg Kroah-Hartman > Date: Sun, 27 Aug 2017 17:03:30 +0200 > > > The IRDA code has long been obsolete and broken.  So, to keep people > > from trying to use it, and to prevent people from having to

Re: [PATCH V2 net-next] net-next/hinic: Fix MTU limitation

2017-08-28 Thread David Miller
From: Aviad Krawczyk Date: Mon, 28 Aug 2017 01:20:26 +0800 > Fix the hw MTU limitation by setting max_mtu > > Signed-off-by: Aviad Krawczyk > Signed-off-by: Zhao Chen Applied.

Re: [PATCH net-next] net-next/hinic: fix comparison of a uint16_t type with -1

2017-08-28 Thread David Miller
From: Aviad Krawczyk Date: Mon, 28 Aug 2017 01:35:30 +0800 > Remove the search for index of constant buffer size > > Signed-off-by: Aviad Krawczyk > Signed-off-by: Zhao Chen Applied.

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-28 Thread David Miller
From: Greg Kroah-Hartman Date: Sun, 27 Aug 2017 17:03:30 +0200 > The IRDA code has long been obsolete and broken. So, to keep people > from trying to use it, and to prevent people from having to maintain it, > let's move it to drivers/staging/ so that we can delete

Re: [PATCH v4 0/7] Add RSS to DPAA 1.x Ethernet driver

2017-08-28 Thread David Miller
From: Madalin Bucur Date: Sun, 27 Aug 2017 16:13:36 +0300 > This patch set introduces Receive Side Scaling for the DPAA Ethernet > driver. Documentation is updated with details related to the new > feature and limitations that apply. > Added also a small fix. > > v2:

RE: [PATCH v3 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-28 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, August 28, 2017 15:39 > From: Dexuan Cui > Date: Sat, 26 Aug 2017 04:52:43 + > > > > > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > > mechanism between the host and the guest. It

Re: [PATCH] be2net: Fix some u16 fields appropriately

2017-08-28 Thread David Miller
From: Haishuang Yan Date: Sun, 27 Aug 2017 15:24:45 +0800 > In be_tx_compl_process, frag_index declared as u32, so it's better to > declare last_index as u32 also. > > CC: Ajit Khaparde > Fixes: b0fd2eb28bd4 ("be2net: Declare some

Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 06:37 PM, Stephen Hemminger wrote: On Mon, 28 Aug 2017 18:18:04 -0400 [..] @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p, NEXT_ARG(); if (get_u16(_type, *argv, 0))

Re: [PATCH] net: ethernet: broadcom: Remove null check before kfree

2017-08-28 Thread David Miller
From: Himanshu Jha Date: Sun, 27 Aug 2017 01:47:47 +0530 > Kfree on NULL pointer is a no-op and therefore checking is redundant. > > Signed-off-by: Himanshu Jha Applied.

Re: [PATCH net-next v2] sched: sfq: drop packets after root qdisc lock is released

2017-08-28 Thread David Miller
From: gfree.w...@vip.163.com Date: Sat, 26 Aug 2017 22:58:58 +0800 > From: Gao Feng > > The commit 520ac30f4551 ("net_sched: drop packets after root qdisc lock > is released) made a big change of tc for performance. But there are > some points which are not changed in

Re: [PATCH net 0/4] xfrm_user info leaks

2017-08-28 Thread David Miller
From: Mathias Krause Date: Sat, 26 Aug 2017 17:08:56 +0200 > Hi David, Steffen, > > the following series fixes a few info leaks due to missing padding byte > initialization in the xfrm_user netlink interface. > > Please apply! Steffen please pick this up if you haven't

Re: [PATCH] sni_82596: Add Thomas' email address to driver.

2017-08-28 Thread David Miller
I need this reposted with a proper commit message and a signoff before I can apply this, thanks.

Re: [PATCH net] ipv6: set dst.obsolete when a cached route has expired

2017-08-28 Thread David Miller
From: Xin Long Date: Sat, 26 Aug 2017 20:10:10 +0800 > Now it doesn't check for the cached route expiration in ipv6's > dst_ops->check(), because it trusts dst_gc that would clean the > cached route up when it's expired. > > The problem is in dst_gc, it would clean the

Re: [PATCH 3/4] i825xx: switch to switch to dma_alloc_attrs

2017-08-28 Thread David Miller
From: Christoph Hellwig Date: Sat, 26 Aug 2017 09:21:24 +0200 > This way we can always pass DMA_ATTR_NON_CONSISTENT, the SNI mips version > will simply ignore the flag. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: [PATCH 2/4] au1000_eth: switch to dma_alloc_attrs

2017-08-28 Thread David Miller
From: Christoph Hellwig Date: Sat, 26 Aug 2017 09:21:23 +0200 > Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: [PATCH 1/4] sgiseeq: switch to dma_alloc_attrs

2017-08-28 Thread David Miller
From: Christoph Hellwig Date: Sat, 26 Aug 2017 09:21:22 +0200 > Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent wrapper. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: [patch net-next 0/2] mlxsw: spectrum: Fix couple of dpipe ipv4 host table bugs

2017-08-28 Thread David Miller
From: Jiri Pirko Date: Sat, 26 Aug 2017 08:35:37 +0200 > From: Jiri Pirko > > Arkadi Sharshevsky (1): > mlxsw: spectrum_dpipe: Fix host table dump > > Jiri Pirko (1): > mlxsw: spectrum: compile-in dpipe support only if devlink is enabled Series

Re: [PATCH v3 net-next 1/1] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-28 Thread David Miller
From: Dexuan Cui Date: Sat, 26 Aug 2017 04:52:43 + > > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It uses VMBus ringbuffer as the > transportation layer. > > With hv_sock, applications between the

Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format

2017-08-28 Thread Stephen Hemminger
On Mon, 28 Aug 2017 18:18:04 -0400 Jamal Hadi Salim wrote: > Alex, > > I think we should get rid of these fprintfs instead of fixing them. > They were originally intended to be debug outputs. > > cheers, > jamal > > On 17-08-28 03:07 PM, Alexander Aring wrote: > > This

Re: [PATCH net] ipv6: fix sparse warning on rt6i_node

2017-08-28 Thread David Miller
From: Wei Wang Date: Fri, 25 Aug 2017 15:03:10 -0700 > From: Wei Wang > > Commit c5cff8561d2d adds rcu grace period before freeing fib6_node. This > generates a new sparse warning on rt->rt6i_node related code: > net/ipv6/route.c:1394:30: error:

Re: [PATCH net-next] selftests/bpf: check the instruction dumps are populated

2017-08-28 Thread David Miller
From: Jakub Kicinski Date: Fri, 25 Aug 2017 14:39:57 -0700 > Add a basic test for checking whether kernel is populating > the jited and xlated BPF images. It was used to confirm > the behaviour change from commit d777b2ddbecf ("bpf: don't > zero out the info

Re: [PATCH net] cxgb4: Fix stack out-of-bounds read due to wrong size to t4_record_mbox()

2017-08-28 Thread David Miller
From: Stefano Brivio Date: Fri, 25 Aug 2017 22:48:48 +0200 > Passing commands for logging to t4_record_mbox() with size > MBOX_LEN, when the actual command size is actually smaller, > causes out-of-bounds stack accesses in t4_record_mbox() while > copying command words here:

Re: [PATCH net-next 1/3 v9] net: ether: Add support for multiplexing and aggregation type

2017-08-28 Thread Dan Williams
On Thu, 2017-08-24 at 22:39 -0600, Subash Abhinov Kasiviswanathan wrote: > Define the multiplexing and aggregation (MAP) ether type 0x00F9. This > is needed for receiving data in the MAP protocol like RMNET. This is > not an officially registered ID. > > Signed-off-by: Subash Abhinov

Re: [PATCH net-next] bpf: fix oops on allocation failure

2017-08-28 Thread David Miller
From: Dan Carpenter Date: Fri, 25 Aug 2017 23:27:14 +0300 > "err" is set to zero if bpf_map_area_alloc() fails so it means we return > ERR_PTR(0) which is NULL. The caller, find_and_alloc_map(), is not > expecting NULL returns and will oops. > > Fixes: 174a79ff9515

Re: [PATCH 4/4] net: stmmac: sun8i: Remove the compatibles

2017-08-28 Thread David Miller
From: Maxime Ripard Date: Fri, 25 Aug 2017 21:12:17 +0200 > Since the bindings have been controversial, and we follow the DT stable ABI > rule, we shouldn't let a driver with a DT binding that might change slip > through in a stable release. > > Remove the

Re: [PATCH net 0/3] fix layer calculation and flow dissector use

2017-08-28 Thread David Miller
From: Pieter Jansen van Vuuren Date: Fri, 25 Aug 2017 19:31:00 +0200 > Previously when calculating the supported key layers MPLS, IPv4/6 > TTL and TOS were not considered. Formerly flow dissectors were referenced > without first checking that they are in use

Re: [PATCH iproute2 4/4] man: tc-ife: add default type note

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 03:07 PM, Alexander Aring wrote: This patch updates the tc-ife man page that the default IFE ethertype will be used if it's not specified. Signed-off-by: Alexander Aring Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH iproute2 3/4] tc: m_ife: report about kernels default type

2017-08-28 Thread Jamal Hadi Salim
Same comment as previous patch. cheers, jamal On 17-08-28 03:07 PM, Alexander Aring wrote: This patch will report about if the ethertype for IFE is not specified that the default IFE type is used. Signed-off-by: Alexander Aring --- tc/m_ife.c | 2 ++ 1 file changed, 2

Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format

2017-08-28 Thread Jamal Hadi Salim
Alex, I think we should get rid of these fprintfs instead of fixing them. They were originally intended to be debug outputs. cheers, jamal On 17-08-28 03:07 PM, Alexander Aring wrote: This patch uses the usually IEEE format to display an ethertype which is 4-digits and every digit in upper

Re: [PATCH net-next] xen-netback: update ubuf_info initialization to anonymous union

2017-08-28 Thread David Miller
From: Willem de Bruijn Date: Fri, 25 Aug 2017 13:10:43 -0400 > From: Willem de Bruijn > > The xen driver initializes struct ubuf_info fields using designated > initializers. I recently moved these fields inside a nested anonymous > struct

Re: [PATCH net-next] net: Add comment that early_demux can change via sysctl

2017-08-28 Thread David Miller
From: David Ahern Date: Mon, 28 Aug 2017 15:14:20 -0700 > Twice patches trying to constify inet{6}_protocol have been reverted: > 39294c3df2a8 ("Revert "ipv6: constify inet6_protocol structures"") to > revert 3a3a4e3054137 and then 03157937fe0b5 ("Revert "ipv4: make >

Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 03:07 PM, Alexander Aring wrote: This patch allows to set an ethertype for IFE which is zero. There is no kernel side validation which forbids a type to zero. Signed-off-by: Alexander Aring Acked-by: Jamal Hadi Salim cheers, jamal

Re: [PATCH net-next 3/3] tc-testing: add test for testing ife type

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 03:03 PM, Alexander Aring wrote: This patch adds a new testcase for the IFE type setting in tc. In case of user specified the type it will check if the ife is correctly configured to react on it. If it's not specified the default IFE type should be used. Signed-off-by: Alexander

[PATCH net-next] net: Add comment that early_demux can change via sysctl

2017-08-28 Thread David Ahern
Twice patches trying to constify inet{6}_protocol have been reverted: 39294c3df2a8 ("Revert "ipv6: constify inet6_protocol structures"") to revert 3a3a4e3054137 and then 03157937fe0b5 ("Revert "ipv4: make net_protocol const"") to revert aa8db499ea67. Add a comment that the structures can not be

Re: [PATCH net-next 2/3] act_ife: use registered ife_type as fallback

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 03:03 PM, Alexander Aring wrote: This patch handles a default IFE type if it's not given by user space netlink api. The default IFE type will be the registered ethertype by IEEE for IFE ForCES. Signed-off-by: Alexander Aring Acked-by: Jamal Hadi Salim

Re: [PATCH net-next 0/3] gre: add collect_md mode for ERSPAN tunnel

2017-08-28 Thread David Miller
From: William Tu Date: Fri, 25 Aug 2017 09:21:26 -0700 > This patch series provide collect_md mode for ERSPAN tunnel. The fist patch > refactors the existing gre_fb_xmit function by exacting the route cache > portion into a new function called prepare_fb_xmit. The second

Re: [PATCH net-next 1/3] if_ether: add forces ife lfb type

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 03:03 PM, Alexander Aring wrote: This patch adds the forces IFE lfb type according to IEEE registered ethertypes. See http://standards-oui.ieee.org/ethertype/eth.txt for more information. Since there exists the IFE subsystem it can be used there. This patch also use the correct word

Re: [patch net-next 3/3] net/sched: Change act_api and act_xxx modules to use IDR

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 02:41 AM, Chris Mi wrote: Typically, each TC filter has its own action. All the actions of the same type are saved in its hash table. But the hash buckets are too small that it degrades to a list. And the performance is greatly affected. For example, it takes about 0m11.914s to

Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 02:41 AM, Chris Mi wrote: Currently, all filters with the same priority are linked in a doubly linked list. Every filter should have a unique handle. To make the handle unique, we need to iterate the list every time to see if the handle exists or not when inserting a new filter. It

[PATCH v2 18/30] net: Define usercopy region in struct proto slab cache

2017-08-28 Thread Kees Cook
From: David Windsor In support of usercopy hardening, this patch defines a region in the struct proto slab cache in which userspace copy operations are allowed. Some protocols need to copy objects to/from userspace, and they can declare the region via their proto structure

[PATCH v2 23/30] net: Restrict unwhitelisted proto caches to size 0

2017-08-28 Thread Kees Cook
Now that protocols have been annotated (the copy of icsk_ca_ops->name is of an ops field from outside the slab cache): $ git grep 'copy_.*_user.*sk.*->' caif/caif_socket.c: copy_from_user(_sk->conn_req.param.data, ov, ol)) { ipv4/raw.c: if (copy_from_user(_sk(sk)->filter, optval, optlen))

[PATCH v2 22/30] sctp: Copy struct sctp_sock.autoclose to userspace using put_user()

2017-08-28 Thread Kees Cook
From: David Windsor The autoclose field can be copied with put_user(), so there is no need to use copy_to_user(). In both cases, hardened usercopy is being bypassed since the size is constant, and not open to runtime manipulation. This patch is verbatim from Brad Spengler/PaX

[PATCH v2 19/30] ip: Define usercopy region in IP proto slab cache

2017-08-28 Thread Kees Cook
From: David Windsor The ICMP filters for IPv4 and IPv6 raw sockets need to be copied to/from userspace. In support of usercopy hardening, this patch defines a region in the struct proto slab cache in which userspace copy operations are allowed. example usage trace:

[PATCH v2 21/30] sctp: Define usercopy region in SCTP proto slab cache

2017-08-28 Thread Kees Cook
From: David Windsor The SCTP socket event notification subscription information need to be copied to/from userspace. In support of usercopy hardening, this patch defines a region in the struct proto slab cache in which userspace copy operations are allowed. Additionally moves

[PATCH v2 20/30] caif: Define usercopy region in caif proto slab cache

2017-08-28 Thread Kees Cook
From: David Windsor The CAIF channel connection request parameters need to be copied to/from userspace. In support of usercopy hardening, this patch defines a region in the struct proto slab cache in which userspace copy operations are allowed. example usage trace:

Re: Get ARP/ND tables from kernel

2017-08-28 Thread Bassam Alsanie
PJ, Thank you. strace is really gonna help :) It seem using Netlink (NETLINK_ROUTE) interface is the way to get the arp/tables form kernel programmatically. Thank you, Bassam On Sun, Aug 27, 2017 at 7:53 PM, Waskiewicz Jr, Peter wrote: > On 8/27/17 9:25 PM, Bassam

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Miller
From: David Ahern Date: Mon, 28 Aug 2017 15:03:34 -0600 > On 8/28/17 3:01 PM, David Miller wrote: >> From: David Ahern >> Date: Mon, 28 Aug 2017 13:23:09 -0700 >> >>> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. >> ... >>> I think this is

Re: [PATCH] ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200"

2017-08-28 Thread Ahmed Abdelsalam
On Mon, 28 Aug 2017 19:48:15 +0100 David Lebrun wrote: > On 08/28/2017 07:20 PM, Ahmed Abdelsalam wrote: > > This patch fixes the get_srh(), so it gets the segment routing header > > regardless of its position in the chain of the extension headers in IPv6 > > packet,

Re: [PATCH 2/6] nbd: make device_attribute const

2017-08-28 Thread Jens Axboe
On 08/21/2017 05:43 AM, Bhumika Goyal wrote: > Make this const as is is only passed as an argument to the > function device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle Added for 4.14, thanks. -- Jens Axboe

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread Stephen Hemminger
On Mon, 28 Aug 2017 13:23:09 -0700 David Ahern wrote: > This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. > > Early demux structs can not be made const. Doing so results in: > [ 84.967355] BUG: unable to handle kernel paging request at 81684b10 > [

Re: Fwd: DA850-evm MAC Address is random

2017-08-28 Thread Tony Lindgren
* Adam Ford [170828 13:33]: > On Mon, Aug 28, 2017 at 1:54 PM, Grygorii Strashko > wrote: > > Cc: Sekhar > > > > On 08/28/2017 10:32 AM, Adam Ford wrote: > >> > >> The davinvi_emac MAC address seems to attempt a call to > >> ti_cm_get_macid in

Re: [PATCH 1/6] ACPI: make device_attribute const

2017-08-28 Thread Rafael J. Wysocki
On Monday, August 21, 2017 1:43:07 PM CEST Bhumika Goyal wrote: > Make these const as they are only passed as an argument to the function > device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > > Signed-off-by: Bhumika Goyal

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Ahern
On 8/28/17 3:01 PM, David Miller wrote: > From: David Ahern > Date: Mon, 28 Aug 2017 13:23:09 -0700 > >> This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. > ... >> I think this is the second time such a patch has been reverted. > > Then please add a comment, it

Re: [PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Miller
From: David Ahern Date: Mon, 28 Aug 2017 13:23:09 -0700 > This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. ... > I think this is the second time such a patch has been reverted. Then please add a comment, it will help prevent this from happening again.

RE: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-28 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Jakub Kicinski > Sent: Friday, August 25, 2017 12:34 PM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org > Subject: Re: [RFC PATCH] net: limit maximum

[PATCH net-next] ipv6: Use rt6i_idev index for echo replies to a local address

2017-08-28 Thread David Ahern
Tariq repored local pings to linklocal address is failing: $ ifconfig ens8 ens8: flags=4163 mtu 1500 inet 11.141.16.6 netmask 255.255.0.0 broadcast 11.141.255.255 inet6 fe80::7efe:90ff:fecb:7502 prefixlen 64 scopeid 0x20 ether

RE: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more

2017-08-28 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Alexander Duyck > Sent: Friday, August 25, 2017 3:34 PM > To: Stephen Hemminger > Cc: Waskiewicz Jr, Peter ; Keller,

Re: Fwd: DA850-evm MAC Address is random

2017-08-28 Thread Adam Ford
On Mon, Aug 28, 2017 at 1:54 PM, Grygorii Strashko wrote: > Cc: Sekhar > > On 08/28/2017 10:32 AM, Adam Ford wrote: >> >> The davinvi_emac MAC address seems to attempt a call to >> ti_cm_get_macid in cpsw-common.c but it returns the message >> 'davinci_emac

[PATCH net-next v1] amd-xgbe: Interrupt summary bits are h/w version dependent

2017-08-28 Thread Tom Lendacky
There is a difference in the bit position of the normal interrupt summary enable (NIE) and abnormal interrupt summary enable (AIE) between revisions of the hardware. For older revisions the NIE and AIE bits are positions 16 and 15 respectively. For newer revisions the NIE and AIE bits are

[PATCH net-next] Revert "ipv4: make net_protocol const"

2017-08-28 Thread David Ahern
This reverts commit aa8db499ea67cff1f5f049033810ffede2fe5ae4. Early demux structs can not be made const. Doing so results in: [ 84.967355] BUG: unable to handle kernel paging request at 81684b10 [ 84.969272] IP: proc_configure_early_demux+0x1e/0x3d [ 84.970544] PGD 1a0a067 [

Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

2017-08-28 Thread Andrew Lunn
On Mon, Aug 28, 2017 at 03:17:39PM -0400, Vivien Didelot wrote: > This commit adds a DEBUG_FS dependent DSA core file creating a generic > debug filesystem interface for the DSA switch devices. > > The interface can be mounted with: > > # mount -t debugfs none /sys/kernel/debug > > The dsa

Re: [PATCH net-next v2 03/10] net: dsa: debugfs: add tag_protocol

2017-08-28 Thread Andrew Lunn
On Mon, Aug 28, 2017 at 03:17:41PM -0400, Vivien Didelot wrote: > Add a debug filesystem "tag_protocol" entry to query the switch tagging > protocol through the .get_tag_protocol operation. > > # cat switch1/tag_protocol > EDSA > > To ease maintenance of tag protocols, add a

Re: [PATCH net-next v2 00/10] net: dsa: add generic debugfs interface

2017-08-28 Thread Andrew Lunn
> I see this overlaps a lot with DPIPE. Why won't you use that to expose > your hw state? We took a look at dpipe and i talked to you about using it for this sort of thing at netconf/netdev. But dpipe has issues displaying the sort of information we have. I never figured out how to do two

  1   2   3   >