Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

2017-09-20 Thread Yonghong Song
On 9/20/17 10:17 PM, Yonghong Song wrote: On 9/20/17 6:41 PM, Steven Rostedt wrote: On Mon, 18 Sep 2017 16:38:36 -0700 Yonghong Song wrote: This patch fixes a bug exhibited by the following scenario:    1. fd1 = perf_event_open with attr.config = ID1    2. attach bpf program

Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

2017-09-20 Thread Yonghong Song
On 9/20/17 6:41 PM, Steven Rostedt wrote: On Mon, 18 Sep 2017 16:38:36 -0700 Yonghong Song wrote: This patch fixes a bug exhibited by the following scenario: 1. fd1 = perf_event_open with attr.config = ID1 2. attach bpf program prog1 to fd1 3. fd2 = perf_event_open

Re:Re: [PATCH net-next ] net: Remove useless function skb_header_release

2017-09-20 Thread Gao Feng
>On Thu, 2017-09-21 at 12:39 +0800, gfree.w...@vip.163.com wrote: >> From: Gao Feng >> >> There is no one which would invokes the function skb_header_release. >> So just remove it now. > >This in incomplete. >There are other references to this function. > >$ git grep -w

Re: [PATCH net-next] net: dsa: use dedicated CPU port

2017-09-20 Thread Florian Fainelli
On 09/20/2017 09:28 AM, Vivien Didelot wrote: > Each port in DSA has its own dedicated CPU port currently available in > its parent switch's ds->ports[port].cpu_dp. Use it instead of getting > the unique tree CPU port, which will be deprecated soon. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next] net: dsa: add port fdb dump

2017-09-20 Thread Florian Fainelli
On 09/20/2017 04:32 PM, Vivien Didelot wrote: > Dumping a DSA port's FDB entries is not specific to a DSA slave, so add > a dsa_port_fdb_dump function, similarly to dsa_port_fdb_add and > dsa_port_fdb_del. > > Signed-off-by: Vivien Didelot Reviewed-by:

Re: [PATCH net-next] net: dsa: better scoping of slave functions

2017-09-20 Thread Florian Fainelli
On 09/20/2017 04:31 PM, Vivien Didelot wrote: > A few DSA slave functions take a dsa_slave_priv pointer as first > argument, whereas the scope of the slave.c functions is the slave > net_device structure. Fix this and rename dsa_netpoll_send_skb to > dsa_slave_netpoll_send_skb. > >

Re: [PATCH net-next 12/14] gtp: Configuration for zero UDP checksum

2017-09-20 Thread Harald Welte
Hi Tom, On Wed, Sep 20, 2017 at 11:09:29AM -0700, Tom Herbert wrote: > On Mon, Sep 18, 2017 at 9:24 PM, David Miller wrote: > > From: Tom Herbert > >> Add configuration to control use of zero checksums on transmit for both > >> IPv4 and IPv6, and

Re: [PATCH net-next ] net: Remove useless function skb_header_release

2017-09-20 Thread Joe Perches
On Thu, 2017-09-21 at 12:39 +0800, gfree.w...@vip.163.com wrote: > From: Gao Feng > > There is no one which would invokes the function skb_header_release. > So just remove it now. This in incomplete. There are other references to this function. $ git grep -w

[PATCH net-next ] net: Remove useless function skb_header_release

2017-09-20 Thread gfree . wind
From: Gao Feng There is no one which would invokes the function skb_header_release. So just remove it now. Signed-off-by: Gao Feng --- include/linux/skbuff.h | 16 1 file changed, 16 deletions(-) diff --git

Re: [PATCH net-next 0/5] net: introduce noref sk

2017-09-20 Thread David Miller
From: Paolo Abeni Date: Wed, 20 Sep 2017 18:54:00 +0200 > This series introduce the infrastructure to store inside the skb a socket > pointer without carrying a refcount to the socket. > > Such infrastructure is then used in the network receive path - and > specifically the

Re: [PATCH iproute2 v3] ip: ip_print: if no json obj is initialized default fp is stdout

2017-09-20 Thread Stephen Hemminger
On Wed, 20 Sep 2017 18:23:56 -0700 Julien Fortin wrote: > From: Julien Fortin > > The ip monitor didn't call `new_json_obj` (even for in non json context), > so the static FILE* _fp variable wasn't initialized, thus raising a > SIGSEGV in

Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob

2017-09-20 Thread 严海双
> On 2017年9月21日, at 上午5:22, David Miller wrote: > > From: Haishuang Yan > Date: Tue, 19 Sep 2017 17:38:14 +0800 > >> -if ((sysctl_tcp_fastopen & TFO_SERVER_WO_SOCKOPT1) && >> -(sysctl_tcp_fastopen &

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-20 Thread Roman Gushchin
> Hello. > > Since, IIRC, v4.11, there is some regression in TCP stack resulting in the > warning shown below. Most of the time it is harmless, but rarely it just > causes either freeze or (I believe, this is related too) panic in > tcp_sacktag_walk() (because sk_buff passed to this function is

Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

2017-09-20 Thread Steven Rostedt
On Mon, 18 Sep 2017 16:38:36 -0700 Yonghong Song wrote: > This patch fixes a bug exhibited by the following scenario: > 1. fd1 = perf_event_open with attr.config = ID1 > 2. attach bpf program prog1 to fd1 > 3. fd2 = perf_event_open with attr.config = ID1 > > 4. user

[PATCH iproute2 v3] ip: ip_print: if no json obj is initialized default fp is stdout

2017-09-20 Thread Julien Fortin
From: Julien Fortin The ip monitor didn't call `new_json_obj` (even for in non json context), so the static FILE* _fp variable wasn't initialized, thus raising a SIGSEGV in ipaddress.c. This patch should fix this issue for good, new paths won't have to call

Re: [PATCH iproute2 v2] ip: ip_print: if no json obj is initialized default fp is stdout

2017-09-20 Thread Julien Fortin
looks like git-mail ate all the traceback lines starting with #, will re-submit v3 On Wed, Sep 20, 2017 at 6:16 PM, Julien Fortin wrote: > From: Julien Fortin > > The ip monitor didn't call `new_json_obj` (even for in non json context), >

Re: Latest net-next from GIT panic

2017-09-20 Thread Eric Dumazet
On Wed, 2017-09-20 at 18:09 -0700, Wei Wang wrote: > > Thanks very much Pawel for the feedback. > > > > I was looking into the code (specifically IPv4 part) and found that in > > free_fib_info_rcu(), we call free_nh_exceptions() without holding the > > fnhe_lock. I am wondering if that could cause

[PATCH iproute2 v2] ip: ip_print: if no json obj is initialized default fp is stdout

2017-09-20 Thread Julien Fortin
From: Julien Fortin The ip monitor didn't call `new_json_obj` (even for in non json context), so the static FILE* _fp variable wasn't initialized, thus raising a SIGSEGV in ipaddress.c. This patch should fix this issue for good, new paths won't have to call

Re: [PATCH iproute2/net-next] tc: flower: support for matching MPLS labels

2017-09-20 Thread Stephen Hemminger
On Tue, 12 Sep 2017 16:06:15 +0200 Simon Horman wrote: > From: Benjamin LaHaise > > This patch adds support to the iproute2 tc filter command for matching MPLS > labels in the flower classifier. The ability to match the Time To Live,

Re: Latest net-next from GIT panic

2017-09-20 Thread Wei Wang
> Thanks very much Pawel for the feedback. > > I was looking into the code (specifically IPv4 part) and found that in > free_fib_info_rcu(), we call free_nh_exceptions() without holding the > fnhe_lock. I am wondering if that could cause some race condition on > fnhe->fnhe_rth_input/output so a

Re: [PATCH iproute2 v2] ip: ipaddress: fix missing space after prefixlen

2017-09-20 Thread Stephen Hemminger
On Wed, 20 Sep 2017 13:26:51 -0700 Julien Fortin wrote: > From: Julien Fortin > > Fixes: d0e720111aad2 ("ip: ipaddress.c: add support for json output") > Reported-by: Sabrina Dubroca > Reviewed-by: Roopa Prabhu

Re: [patch net-next 00/16] mlxsw: Multicast flood update

2017-09-20 Thread David Miller
From: Jiri Pirko Date: Wed, 20 Sep 2017 16:15:00 +0200 > From: Jiri Pirko > > Nogah says: > > Currently, there are four erroneous flows in MC flood: > 1. When MC is disabled it affects only the flood table for unregistered >MC packets, but packets that

Re: [PATCH 1/1] ip: ip_print: if no json obj is initialized default fp is stdout

2017-09-20 Thread Stephen Hemminger
On Wed, 20 Sep 2017 15:19:14 -0700 Julien Fortin wrote: > From: Julien Fortin > > The ip monitor didn't call `new_json_obj` (even for in non json context), > so the static FILE* _fp variable wasn't initialized, thus raising a > SIGSEGV in

Re: [PATCH iproute2] tc: fix typo in tc-tcindex man page

2017-09-20 Thread Stephen Hemminger
On Thu, 14 Sep 2017 17:00:46 +0200 Davide Caratti wrote: > fix mis-typed 'pass_on' keyword. > > Signed-off-by: Davide Caratti Applied, thanks Davide

Re: [iproute2 PATCH] tc/mirred: Clean up white-space noise

2017-09-20 Thread Stephen Hemminger
On Wed, 13 Sep 2017 03:05:13 -0700 Amritha Nambiar wrote: > Signed-off-by: Amritha Nambiar > --- > include/linux/tc_act/tc_mirred.h |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH iproute2] Add information about COLORFGBG to ip.8 man page

2017-09-20 Thread Stephen Hemminger
On Fri, 15 Sep 2017 22:04:16 +0200 Roland Hopferwieser wrote: > diff --git a/man/man8/ip.8 b/man/man8/ip.8 > index ae018fdf..2a27a56e 100644 > --- a/man/man8/ip.8 > +++ b/man/man8/ip.8 > @@ -187,7 +187,8 @@ executes specified command over all objects, it > depends if command

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 5:13 PM, Harald Welte wrote: > Hi Tom, > > On Wed, Sep 20, 2017 at 09:24:07AM -0700, Tom Herbert wrote: >> On Wed, Sep 20, 2017 at 9:07 AM, Andreas Schultz wrote: >> > GTP isn't special, I just don't like to have testing only

Re: [iproute PATCH v2] ipaddress: Fix segfault in 'addr showdump'

2017-09-20 Thread Stephen Hemminger
On Wed, 13 Sep 2017 11:20:34 +0200 Phil Sutter wrote: > Obviously, 'addr showdump' feature wasn't adjusted to json output > support. As a consequence, calls to print_string() in print_addrinfo() > tried to dereference a NULL FILE pointer. > > Cc: Julien Fortin

Re: [PATCH iproute2] tc: fq: support low_rate_threshold attribute

2017-09-20 Thread Stephen Hemminger
On Fri, 08 Sep 2017 14:12:59 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > TCA_FQ_LOW_RATE_THRESHOLD sch_fq attribute was added in linux-4.9 > > Tested: > > lpaa5:/tmp# tc -qd add dev eth1 root fq > lpaa5:/tmp# tc -s qd sh dev eth1 > qdisc fq

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-20 Thread Franklin S Cooper Jr
On 09/20/2017 04:37 PM, Mario Hüttel wrote: > > > On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: >> Hi Wenyou, >> >> On 09/17/2017 10:47 PM, Yang, Wenyou wrote: >>> >>> On 2017/9/14 13:06, Sekhar Nori wrote: On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: > On

Re: [v2,3/3] can: m_can: Add PM Runtime

2017-09-20 Thread Franklin S Cooper Jr
On 08/24/2017 03:30 AM, Sekhar Nori wrote: > + OMAP mailing list > > On Tuesday 25 July 2017 04:21 AM, Franklin Cooper wrote: >> Add support for PM Runtime which is the new way to handle managing clocks. >> However, to avoid breaking SoCs not using PM_RUNTIME leave the old clk >> management

Re: [v2,1/3] can: m_can: Make hclk optional

2017-09-20 Thread Franklin S Cooper Jr
On 08/24/2017 03:00 AM, Sekhar Nori wrote: > + some OMAP folks and Linux OMAP list > > On Tuesday 25 July 2017 04:21 AM, Franklin Cooper wrote: >> Hclk is the MCAN's interface clock. However, for OMAP based devices such as >> DRA7 SoC family the interface clock is handled by hwmod. Therefore,

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Tom Herbert
On Wed, Sep 20, 2017 at 5:04 PM, Harald Welte wrote: > Hi Tom, > > On Wed, Sep 20, 2017 at 01:40:54PM -0700, Tom Herbert wrote: >> On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote: >> > There is a socket associated with the tunnel to do the

Re: [PATCH net-next 08/14] gtp: Support encpasulating over IPv6

2017-09-20 Thread Harald Welte
Hi Tom, On Wed, Sep 20, 2017 at 01:40:54PM -0700, Tom Herbert wrote: > On Wed, Sep 20, 2017 at 12:45 PM, David Miller wrote: > > There is a socket associated with the tunnel to do the encapsulation > > and it has an address family, right? > > If fd's are set from userspace

Re: [PATCH net-next 09/14] gtp: Allow configuring GTP interface as standalone

2017-09-20 Thread Harald Welte
Hi Tom, On Wed, Sep 20, 2017 at 09:24:07AM -0700, Tom Herbert wrote: > On Wed, Sep 20, 2017 at 9:07 AM, Andreas Schultz wrote: > > GTP isn't special, I just don't like to have testing only features in there > > when the same goal can be reached without having to add extra

[PATCH v2 20/31] net/core: Collapse redundant sk_timer callback data assignments

2017-09-20 Thread Kees Cook
The core sk_timer initializer can provide the common .data assignment instead of it being set separately in users. Cc: "David S. Miller" Cc: Ralf Baechle Cc: Andrew Hendry Cc: Eric Dumazet Cc: Paolo Abeni

[PATCH v2 30/31] appletalk: Remove unneeded synchronization

2017-09-20 Thread Kees Cook
The use of del_timer_sync() will make sure a timer is not rescheduled. As such, there is no need to add external signals to kill timers. In preparation for switching the timer callback argument to the timer pointer, this drops the .data argument since it doesn't serve a meaningful purpose here.

[PATCH v2 19/31] timer: Remove open-coded casts for .data and .function

2017-09-20 Thread Kees Cook
This standardizes the callback and data prototypes in several places that perform casting, in an effort to remove more open-coded .data and .function uses in favor of setup_timer(). Cc: Samuel Ortiz Cc: Tyrel Datwyler Cc: Benjamin Herrenschmidt

[PATCH net-next] net: dsa: add port fdb dump

2017-09-20 Thread Vivien Didelot
Dumping a DSA port's FDB entries is not specific to a DSA slave, so add a dsa_port_fdb_dump function, similarly to dsa_port_fdb_add and dsa_port_fdb_del. Signed-off-by: Vivien Didelot --- net/dsa/dsa_priv.h | 1 + net/dsa/port.c | 11 +++

[PATCH net-next] net: dsa: better scoping of slave functions

2017-09-20 Thread Vivien Didelot
A few DSA slave functions take a dsa_slave_priv pointer as first argument, whereas the scope of the slave.c functions is the slave net_device structure. Fix this and rename dsa_netpoll_send_skb to dsa_slave_netpoll_send_skb. Signed-off-by: Vivien Didelot ---

Re: [PATCH v2 1/3] can: m_can: Make hclk optional

2017-09-20 Thread Franklin S Cooper Jr
On 09/20/2017 05:00 PM, Mario Hüttel wrote: >> Hclk is the MCAN's interface clock. However, for OMAP based devices such as >> DRA7 SoC family the interface clock is handled by hwmod. Therefore, this >> interface clock is managed by hwmod driver via pm_runtime_get and >> pm_runtime_put calls.

[PATCH v2 13/31] timer: Remove meaningless .data/.function assignments

2017-09-20 Thread Kees Cook
Several timer users needlessly reset their .function/.data fields during their timer callback, but nothing else changes them. Some users do not use their .data field at all. Each instance is removed here. Cc: Krzysztof Halasa Cc: Aditya Shankar Cc:

[PATCH v2 25/31] net/atm/mpc: Use separate static data field with with static timer

2017-09-20 Thread Kees Cook
In preparation for changing the timer callback argument to the timer pointer, move to a separate static data variable. Cc: "David S. Miller" Cc: Andrew Morton Cc: Alexey Dobriyan Cc: "Reshetova, Elena"

Re: [PATCH net-next 00/10] net/smc: updates 2017-09-20

2017-09-20 Thread David Miller
From: Ursula Braun Date: Wed, 20 Sep 2017 13:58:03 +0200 > here is a collection of small smc-patches built for net-next > improving the smc code in different areas. There are bug fixes in here, which should be targetted at 'net'.

[PATCH v2 31/31] timer: Switch to testing for .function instead of .data

2017-09-20 Thread Kees Cook
This is part of the work to support switching all struct timer_list callbacks to get the timer pointer as the argument (like other modern callback interfaces in the kernel) instead of from the .data field. This patch is one of several steps in removing open-coded users of the .data field: In

Re: [PATCH] net_sched: always reset qdisc backlog in qdisc_reset()

2017-09-20 Thread Cong Wang
On Wed, Sep 20, 2017 at 5:45 AM, Konstantin Khlebnikov wrote: > SKB stored in qdisc->gso_skb also counted into backlog. > > Some qdiscs don't reset backlog to zero in ->reset(), > for example sfq just dequeue and free all queued skb. > > Signed-off-by: Konstantin

Re: [PATCH v3 14/31] vxfs: Define usercopy region in vxfs_inode slab cache

2017-09-20 Thread Christoph Hellwig
On Wed, Sep 20, 2017 at 02:21:45PM -0700, Kees Cook wrote: > This is why I included several other lists on the full CC (am I > unlucky enough to have you not subscribed to any of them?). Adding a > CC for everyone can result in a huge CC list, especially for the > forth-coming 300-patch timer_list

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread Stephen Hemminger
On Wed, 20 Sep 2017 15:57:16 -0600 David Ahern wrote: > On 9/20/17 3:09 PM, David Miller wrote: > > From: Vincent Bernat > > Date: Sat, 16 Sep 2017 16:18:33 +0200 > > > > David, I am CC:'ing you because you've done work in this area over the > > past year.

Re: [PATCH net 0/9] TM related bugfixes for the HNS3 Ethernet Driver

2017-09-20 Thread David Miller
From: Yunsheng Lin Date: Wed, 20 Sep 2017 18:52:49 +0800 > This patch set contains a few bugfixes related to hclge_tm module. Series applied, thank you.

Re: [PATCH 0/2] Netfilter fixes for net

2017-09-20 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 20 Sep 2017 12:49:01 +0200 > The following patchset contains two Netfilter fixes for your net tree, > they are: > > 1) Fix NAt compilation with UP, from Geert Uytterhoeven. > > 2) Fix incorrect number of entries when dumping a set, from >

Re: [PATCH net-next v5 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

2017-09-20 Thread David Miller
From: Peter Zijlstra Date: Wed, 20 Sep 2017 19:26:51 +0200 > Dave, could we have this in a topic tree of sorts, because I have a > pending series to rework all the timekeeping and it might be nice to not > have sfr run into all sorts of conflicts. If you want to merge it

Re: [PATCH net-next] cxgb4: add new T5 pci device id's

2017-09-20 Thread David Miller
From: Ganesh Goudar Date: Wed, 20 Sep 2017 11:32:07 +0530 > Add 0x50a5, 0x50a6, 0x50a7, 0x50a8 and 0x50a9 T5 device > id's. > > Signed-off-by: Ganesh Goudar Applied, thank you.

Re: [PATCH net] net/ncsi: Don't assume last available channel exists

2017-09-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Wed, 20 Sep 2017 14:12:51 +1000 > When handling new VLAN tags in NCSI we check the maximum allowed number > of filters on the last active ("hot") channel. However if the 'add' > callback is called before NCSI has configured a channel, this

Re: [PATCH] isdn/i4l: fetch the ppp_write buffer in one shot

2017-09-20 Thread David Miller
From: Meng Xu Date: Tue, 19 Sep 2017 21:49:55 -0400 > In isdn_ppp_write(), the header (i.e., protobuf) of the buffer is > fetched twice from userspace. The first fetch is used to peek at the > protocol of the message and reset the huptimer if necessary; while the >

Re: [PATCH 0/2] blackfin: Drop non-functional DSA code

2017-09-20 Thread David Miller
From: Florian Fainelli Date: Tue, 19 Sep 2017 18:03:44 -0700 > I sent those many months ago in the hope that the bfin-linux people > would pick those patches but nobody seems to be responding, can you > queue those via net-next since this affects DSA? Ok, if they aren't

Re: [PATCH net-next] bpf: Optimize lpm trie delete

2017-09-20 Thread Daniel Mack
On 09/20/2017 08:51 PM, Craig Gallek wrote: > On Wed, Sep 20, 2017 at 12:51 PM, Daniel Mack wrote: >> Hi Craig, >> >> Thanks, this looks much cleaner already :) >> >> On 09/20/2017 06:22 PM, Craig Gallek wrote: >>> diff --git a/kernel/bpf/lpm_trie.c b/kernel/bpf/lpm_trie.c >>>

[PATCH net 1/2] net: ethtool: Add back transceiver type

2017-09-20 Thread Florian Fainelli
Commit 3f1ac7a700d0 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API") deprecated the ethtool_cmd::transceiver field, which was fine in premise, except that the PHY library was actually using it to report the type of transceiver: internal or external. Use the first word of the reserved field to

[PATCH net 2/2] net: phy: Keep reporting transceiver type

2017-09-20 Thread Florian Fainelli
With commit 2d55173e71b0 ("phy: add generic function to support ksetting support"), we lost the ability to report the transceiver type like we used to. Now that we have added back the transceiver type to ethtool_link_settings, we can report it back like we used to and have no loss of information.

[PATCH net 0/2] Bring back transceiver type for PHYLIB

2017-09-20 Thread Florian Fainelli
Hi With the introduction of the xLINKSETTINGS ethtool APIs, the transceiver type was deprecated, but in that process we lost some useful information that PHYLIB was consistently reporting about internal vs. external PHYs. This brings back transceiver as a read-only field that is only consumed in

Re: [PATCH net-next] net: dsa: Utilize dsa_slave_dev_check()

2017-09-20 Thread David Miller
From: Florian Fainelli Date: Tue, 19 Sep 2017 18:00:37 -0700 > Instead of open coding the check. > > Signed-off-by: Florian Fainelli Applied, thanks.

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

2017-09-20 Thread Vallish Vaidyeshwara
On Sat, Sep 16, 2017 at 11:47:56AM +0200, Thomas Gleixner wrote: > On Fri, 8 Sep 2017, Eric Dumazet wrote: > > On Fri, 2017-09-08 at 11:55 -0700, Eduardo Valentin wrote: > > > Hello, > > > > > > On Fri, Sep 08, 2017 at 10:26:45AM -0700, David Miller wrote: > > > > From: David Woodhouse

Re: [PATCH v4 3/3] net: fec: return IRQ_HANDLED if fec_ptp_check_pps_event handled it

2017-09-20 Thread David Miller
From: Troy Kisky Date: Tue, 19 Sep 2017 17:33:09 -0700 > fec_ptp_check_pps_event will return 1 if FEC_T_TF_MASK caused > an interrupt. Don't return IRQ_NONE in this case. > > Signed-off-by: Troy Kisky > Acked-by: Fugang Duan

Re: [PATCH v4 1/3] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set

2017-09-20 Thread David Miller
From: Troy Kisky Date: Tue, 19 Sep 2017 17:33:07 -0700 > Before queue 0 was always checked if any queue caused an interrupt. > It is better to just mark queue 0 if queue 0 has caused an interrupt. > > Signed-off-by: Troy Kisky >

Re: [PATCH v4 2/3] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

2017-09-20 Thread David Miller
From: Troy Kisky Date: Tue, 19 Sep 2017 17:33:08 -0700 > FEC_ENET_TS_TIMER is not checked in the interrupt routine > so there is no need to enable it. > > Signed-off-by: Troy Kisky > Acked-by: Fugang Duan

Re: [PATCH net] net: change skb->mac_header when Generic XDP calls adjust_head

2017-09-20 Thread David Miller
From: Edward Cree Date: Tue, 19 Sep 2017 18:45:56 +0100 > Since XDP's view of the packet includes the MAC header, moving the start- > of-packet with bpf_xdp_adjust_head needs to also update the offset of the > MAC header (which is relative to skb->head, not to the

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread David Miller
From: Vincent Bernat Date: Thu, 21 Sep 2017 00:12:53 +0200 > ❦ 20 septembre 2017 15:57 -0600, David Ahern  : > >> The DELLINK is for AF_BRIDGE family (ifi_family). Adding family to >> print_linkinfo and running the monitor I get: >> >> >> [LINK]family 0:

Re: [PATCH] net: compat: assert the size of cmsg copied in is as expected

2017-09-20 Thread David Miller
From: Meng Xu Date: Tue, 19 Sep 2017 13:19:13 -0400 > The actual length of cmsg fetched in during the second loop > (i.e., kcmsg - kcmsg_base) could be different from what we > get from the first loop (i.e., kcmlen). > > The main reason is that the two get_user() calls

[PATCH 1/1] ip: ip_print: if no json obj is initialized default fp is stdout

2017-09-20 Thread Julien Fortin
From: Julien Fortin The ip monitor didn't call `new_json_obj` (even for in non json context), so the static FILE* _fp variable wasn't initialized, thus raising a SIGSEGV in ipaddress.c. This patch should fix this issue for good, new paths won't have to call

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread Vincent Bernat
❦ 20 septembre 2017 15:57 -0600, David Ahern  : > The DELLINK is for AF_BRIDGE family (ifi_family). Adding family to > print_linkinfo and running the monitor I get: > > > [LINK]family 0: 35: dummy1: mtu 1500 qdisc > noqueue master br0 state

Re: Latest net-next from GIT panic

2017-09-20 Thread Wei Wang
>>> bisected again and same result: >>> b838d5e1c5b6e57b10ec8af2268824041e3ea911 is the first bad commit >>> commit b838d5e1c5b6e57b10ec8af2268824041e3ea911 >>> Author: Wei Wang >>> Date: Sat Jun 17 10:42:32 2017 -0700 >>> >>> ipv4: mark DST_NOGC and remove the operation

Re: [PATCH net-next 3/3] virtio-net: support XDP_REDIRECT

2017-09-20 Thread John Fastabend
On 09/19/2017 02:42 AM, Jason Wang wrote: > This patch tries to add XDP_REDIRECT for virtio-net. The changes are > not complex as we could use exist XDP_TX helpers for most of the > work. The rest is passing the XDP_TX to NAPI handler for implementing > batching. > > Cc: John Fastabend

Re: [PATCH v2 1/3] can: m_can: Make hclk optional

2017-09-20 Thread Mario Hüttel
> Hclk is the MCAN's interface clock. However, for OMAP based devices such as > DRA7 SoC family the interface clock is handled by hwmod. Therefore, this > interface clock is managed by hwmod driver via pm_runtime_get and > pm_runtime_put calls. Therefore, this interface clock isn't defined in DT >

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread David Ahern
On 9/20/17 3:09 PM, David Miller wrote: > From: Vincent Bernat > Date: Sat, 16 Sep 2017 16:18:33 +0200 > > David, I am CC:'ing you because you've done work in this area over the > past year. I'm applying this patch, it's been sitting since the 16th > and likes entirely

Re: [RFC PATCH] can: m_can: Support higher speed CAN-FD bitrates

2017-09-20 Thread Mario Hüttel
On 09/20/2017 10:19 PM, Franklin S Cooper Jr wrote: > Hi Wenyou, > > On 09/17/2017 10:47 PM, Yang, Wenyou wrote: >> >> On 2017/9/14 13:06, Sekhar Nori wrote: >>> On Thursday 14 September 2017 03:28 AM, Franklin S Cooper Jr wrote: On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote: >

Re: TSN Scorecard, was Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

2017-09-20 Thread Jesus Sanchez-Palencia
Hi, On 09/19/2017 10:49 PM, Richard Cochran wrote: (...) > > No, that is not what I meant. We need some minimal additional kernel > support in order to fully implement the TSN family of standards. Of > course, the bulk will have to be done in user space. It would be a > mistake to cram the

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-20 Thread Florian Fainelli
On 09/20/2017 02:27 PM, ros...@gmail.com wrote: > Sorry for the noise. After more testing I've found out that the cause > was that I had BBR enabled on my laptop. Switching back to CUBIC fixed > the issue. > > In other words, this patch is detrimental. Quite unsurprisingly, thanks for coming

Re: [PATCH net-next 1/3] virtio-net: remove unnecessary parameter of virtnet_xdp_xmit()

2017-09-20 Thread David Miller
From: Jason Wang Date: Tue, 19 Sep 2017 17:42:41 +0800 > CC: John Fastabend > Signed-off-by: Jason Wang Applied.

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
W dniu 2017-09-20 o 23:25, Paweł Staszewski pisze: W dniu 2017-09-20 o 23:24, Paweł Staszewski pisze: W dniu 2017-09-20 o 23:10, Paweł Staszewski pisze: W dniu 2017-09-20 o 21:23, Paweł Staszewski pisze: W dniu 2017-09-20 o 21:13, Paweł Staszewski pisze: W dniu 2017-09-20 o 

Re: [PATCH net-next] udp: do rmem bulk free even if the rx sk queue is empty

2017-09-20 Thread David Miller
From: Paolo Abeni Date: Tue, 19 Sep 2017 12:11:43 +0200 > The commit 6b229cf77d68 ("udp: add batching to udp_rmem_release()") > reduced greatly the cacheline contention between the BH and the US > reader batching the rmem updates in most scenarios. > > Such optimization is

Re: [PATCH net-next 2/3] virtio-net: add packet len average only when needed during XDP

2017-09-20 Thread David Miller
From: Jason Wang Date: Tue, 19 Sep 2017 17:42:42 +0800 > There's no need to add packet len average in the case of XDP_PASS > since it will be done soon after skb is created. > > Cc: John Fastabend > Signed-off-by: Jason Wang

Re: [PATCH net-next 3/3] virtio-net: support XDP_REDIRECT

2017-09-20 Thread David Miller
From: Jason Wang Date: Tue, 19 Sep 2017 17:42:43 +0800 > This patch tries to add XDP_REDIRECT for virtio-net. The changes are > not complex as we could use exist XDP_TX helpers for most of the > work. The rest is passing the XDP_TX to NAPI handler for implementing >

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
W dniu 2017-09-20 o 23:24, Paweł Staszewski pisze: W dniu 2017-09-20 o 23:10, Paweł Staszewski pisze: W dniu 2017-09-20 o 21:23, Paweł Staszewski pisze: W dniu 2017-09-20 o 21:13, Paweł Staszewski pisze: W dniu 2017-09-20 o 20:36, Cong Wang pisze: On Wed, Sep 20, 2017 at 11:30 AM,

Re: [PATCH] bgmac: Remove all offloading features, including GRO.

2017-09-20 Thread rosenp
Sorry for the noise. After more testing I've found out that the cause was that I had BBR enabled on my laptop. Switching back to CUBIC fixed the issue. In other words, this patch is detrimental. ~67mbps - gro off ~87mbps - gro on On Fri, 2017-09-15 at 23:04 -0700, Florian Fainelli wrote: > On

Re: [PATCH v4 2/4] samples/bpf: Enable cross compiler support

2017-09-20 Thread Daniel Borkmann
On 09/20/2017 06:11 PM, Joel Fernandes wrote: When cross compiling, bpf samples use HOSTCC for compiling the non-BPF part of the sample, however what we really want is to use the cross compiler to build for the cross target since that is what will load and run the BPF sample. Detect this and

Re: [PATCH v4 4/4] samples/bpf: Add documentation on cross compilation

2017-09-20 Thread Daniel Borkmann
On 09/20/2017 06:11 PM, Joel Fernandes wrote: Acked-by: Alexei Starovoitov Signed-off-by: Joel Fernandes (Minor typo pointed out by Randy, but rest looks fine.) Acked-by: Daniel Borkmann

Re: [PATCH v4 3/4] samples/bpf: Fix pt_regs issues when cross-compiling

2017-09-20 Thread Daniel Borkmann
On 09/20/2017 06:11 PM, Joel Fernandes wrote: BPF samples fail to build when cross-compiling for ARM64 because of incorrect pt_regs param selection. This is because clang defines __x86_64__ and bpf_headers thinks we're building for x86. Since clang is building for the BPF target, it shouldn't

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
W dniu 2017-09-20 o 23:10, Paweł Staszewski pisze: W dniu 2017-09-20 o 21:23, Paweł Staszewski pisze: W dniu 2017-09-20 o 21:13, Paweł Staszewski pisze: W dniu 2017-09-20 o 20:36, Cong Wang pisze: On Wed, Sep 20, 2017 at 11:30 AM, Eric Dumazet wrote: On Wed,

Re: [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-20 Thread David Miller
From: Haishuang Yan Date: Tue, 19 Sep 2017 17:38:15 +0800 > @@ -128,6 +130,8 @@ struct netns_ipv4 { > struct inet_timewait_death_row tcp_death_row; > int sysctl_max_syn_backlog; > int sysctl_tcp_fastopen; > + struct tcp_fastopen_context

Re: [PATCH v4 1/4] samples/bpf: Use getppid instead of getpgrp for array map stress

2017-09-20 Thread Daniel Borkmann
On 09/20/2017 06:11 PM, Joel Fernandes wrote: When cross-compiling the bpf sample map_perf_test for aarch64, I find that __NR_getpgrp is undefined. This causes build errors. This syscall is deprecated and requires defining __ARCH_WANT_SYSCALL_DEPRECATED. To avoid having to define that, just use

Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob

2017-09-20 Thread David Miller
From: Haishuang Yan Date: Tue, 19 Sep 2017 17:38:14 +0800 > - if ((sysctl_tcp_fastopen & TFO_SERVER_WO_SOCKOPT1) && > - (sysctl_tcp_fastopen & TFO_SERVER_ENABLE) && > + tcp_fastopen =

Re: [PATCH v3 14/31] vxfs: Define usercopy region in vxfs_inode slab cache

2017-09-20 Thread Kees Cook
On Wed, Sep 20, 2017 at 1:56 PM, Christoph Hellwig wrote: > Hi Kees, > > I've only got this single email from you, which on it's own doesn't > compile and seems to be part of a 31 patch series. > > So as-is NAK, doesn't work. > > Please make sure to always send every patch in

Re: ipv4 ID calculation

2017-09-20 Thread Stephen Hemminger
On Mon, 18 Sep 2017 20:43:05 -0400 Harsha Chenji wrote: > Hi all, > > Where is the ID field of the IPv4 header created when the DF flag is > set? I am looking at ip_build_and_send_pkt. The code seems to have > changed in 4.4-rc1: > > if (ip_dont_fragment(sk, >dst)) { >

Re: [PATCH net-next] net: dsa: lan9303: Add adjust_link() method

2017-09-20 Thread David Miller
From: Egil Hjelmeland Date: Tue, 19 Sep 2017 10:09:24 +0200 > Make the driver react to device tree "fixed-link" declaration on CPU port. > > - turn off autonegotiation > - force speed 10 or 100 mb/s > - force duplex mode > > Signed-off-by: Egil Hjelmeland

Re: [PATCH net] bpf: one perf event close won't free bpf program attached by another perf event

2017-09-20 Thread David Miller
From: Yonghong Song Date: Mon, 18 Sep 2017 16:38:36 -0700 > This patch fixes a bug exhibited by the following scenario: > 1. fd1 = perf_event_open with attr.config = ID1 > 2. attach bpf program prog1 to fd1 > 3. fd2 = perf_event_open with attr.config = ID1 > > 4. user

Re: Latest net-next from GIT panic

2017-09-20 Thread Paweł Staszewski
W dniu 2017-09-20 o 21:23, Paweł Staszewski pisze: W dniu 2017-09-20 o 21:13, Paweł Staszewski pisze: W dniu 2017-09-20 o 20:36, Cong Wang pisze: On Wed, Sep 20, 2017 at 11:30 AM, Eric Dumazet wrote: On Wed, 2017-09-20 at 11:22 -0700, Cong Wang wrote: but dmesg

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-20 Thread David Miller
From: Vincent Bernat Date: Sat, 16 Sep 2017 16:18:33 +0200 David, I am CC:'ing you because you've done work in this area over the past year. I'm applying this patch, it's been sitting since the 16th and likes entirely correct to me. But if you have objections just let me

Re: [PATCH net] packet: hold bind lock when rebinding to fanout hook

2017-09-20 Thread David Miller
From: Willem de Bruijn Date: Fri, 15 Sep 2017 10:07:46 -0400 > On Thu, Sep 14, 2017 at 5:14 PM, Willem de Bruijn wrote: >> Packet socket bind operations must hold the po->bind_lock. This keeps >> po->running consistent with whether the socket

[PATCH v3 03/31] usercopy: Mark kmalloc caches as usercopy caches

2017-09-20 Thread Kees Cook
From: David Windsor Mark the kmalloc slab caches as entirely whitelisted. These caches are frequently used to fulfill kernel allocations that contain data to be copied to/from userspace. Internal-only uses are also common, but are scattered in the kernel. For now, mark all the

[PATCH v3 04/31] dcache: Define usercopy region in dentry_cache slab cache

2017-09-20 Thread Kees Cook
From: David Windsor When a dentry name is short enough, it can be stored directly in the dentry itself (instead in a separate kmalloc allocation). These dentry short names, stored in struct dentry.d_iname and therefore contained in the dentry_cache slab cache, need to be coped

[PATCH v3 27/31] x86: Implement thread_struct whitelist for hardened usercopy

2017-09-20 Thread Kees Cook
This whitelists the FPU register state portion of the thread_struct for copying to userspace, instead of the default entire struct. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: Borislav Petkov

  1   2   3   4   >