Re: [PATCH v4 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-28 Thread Tom Herbert
On Thu, Sep 28, 2017 at 2:34 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > - Share tx path: gre type mpls loaded from skb->protocol. > > Decap: > - pull

Re: [net-next PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

2017-09-28 Thread Alexei Starovoitov
On Thu, Sep 28, 2017 at 02:57:08PM +0200, Jesper Dangaard Brouer wrote: > The 'cpumap' is primary used as a backend map for XDP BPF helper > call bpf_redirect_map() and XDP_REDIRECT action, like 'devmap'. > > This patch implement the main part of the map. It is not connected to > the XDP

[no subject]

2017-09-28 Thread Tina Aaron
Do you need urgent LOAN ? If yes, Contact me now via Email: mondataclas...@gmail.com CONFIDENTIALITY NOTICE: This email message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized use,

Re: [lkp-robot] [mac80211] 31e9170bde: hwsim.sta_dynamic_down_up.fail

2017-09-28 Thread Xiang Gao
Thanks, I will look into it. Xiang Gao 2017-09-28 4:06 GMT-04:00 kernel test robot : > > FYI, we noticed the following commit: > > commit: 31e9170bdeb6ebe66426337b4e2b9924683a412b ("mac80211: aead api to > reduce redundancy") > url: >

Re: linux-next: build failure after merge of the net-next tree

2017-09-28 Thread Florian Fainelli
Le 09/28/17 à 18:36, Stephen Rothwell a écrit : > Hi all, > > After merging the net-next tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > net/dsa/slave.c: In function 'dsa_slave_create': > net/dsa/slave.c:1191:18: error: 'struct dsa_slave_priv' has no member named

linux-next: build failure after merge of the net-next tree

2017-09-28 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (arm multi_v7_defconfig) failed like this: net/dsa/slave.c: In function 'dsa_slave_create': net/dsa/slave.c:1191:18: error: 'struct dsa_slave_priv' has no member named 'phy' phy_disconnect(p->phy); ^ Caused

Re: [PATCH V4] r8152: add Linksys USB3GIGV1 id

2017-09-28 Thread Doug Anderson
Grant, On Thu, Sep 28, 2017 at 11:35 AM, Grant Grundler wrote: > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > > Signed-off-by: Grant Grundler

[PATCH v4 net-next 7/8] fou: Support flow dissection

2017-09-28 Thread Tom Herbert
Populate offload flow_dissect callabck appropriately for fou and gue. Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index

[PATCH v4 net-next 6/8] udp: flow dissector offload

2017-09-28 Thread Tom Herbert
Add support to perform UDP specific flow dissection. This is primarily intended for dissecting encapsulated packets in UDP encapsulation. This patch adds a flow_dissect offload for UDP4 and UDP6. The backend function performs a socket lookup and calls the flow_dissect function if a socket is

[PATCH v4 net-next 4/8] flow_dissector: Add protocol specific flow dissection offload

2017-09-28 Thread Tom Herbert
Add offload capability for performing protocol specific flow dissection (either by EtherType or IP protocol). Specifically: - Add flow_dissect to offload callbacks - Move flow_dissect_ret enum to flow_dissector.h, cleanup names and add a couple of values - Unify handling of functions that

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

2017-09-28 Thread Doug Anderson
Hi, On Thu, Sep 28, 2017 at 3:28 PM, Rustad, Mark D wrote: > >> On Sep 27, 2017, at 9:39 AM, Grant Grundler wrote: >> >> On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote: >>> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb

[PATCH v4 net-next 8/8] vxlan: support flow dissect

2017-09-28 Thread Tom Herbert
Populate offload flow_dissect callback appropriately for VXLAN and VXLAN-GPE. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index

[PATCH v4 net-next 5/8] ip: Add callbacks to flow dissection by IP protocol

2017-09-28 Thread Tom Herbert
Populate the proto_flow_dissect function for IPv4 and IPv6 packet offloads. This allows the caller to flow dissect a packet starting at the given IP protocol (as parsed to that point by flow dissector for instance). Signed-off-by: Tom Herbert --- net/ipv4/af_inet.c | 27

[PATCH v4 net-next 3/8] udp: Check static key udp_encap_needed in udp_gro_receive

2017-09-28 Thread Tom Herbert
Currently, the only support for udp gro is provided by UDP encapsulation protocols. Since they always set udp_encap_needed we can check that in udp_gro_receive functions before performing a socket lookup. Signed-off-by: Tom Herbert --- include/net/udp.h | 2 ++

[PATCH v4 net-next 2/8] flow_dissector: Move ETH_P_TEB processing to main switch

2017-09-28 Thread Tom Herbert
Support for processing TEB is currently in GRE flow dissection as a special case. This can be moved to be a case the main proto switch in __skb_flow_dissect. Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 45 - 1 file

[PATCH v4 net-next 1/8] flow_dissector: Change skbuf argument to be non const

2017-09-28 Thread Tom Herbert
Change the skbuf argument of __skb_flow_dissect to be non constant so that the function can call functions that take non constant skbuf arguments. This is needed if we are to call socket lookup or BPF in the flow dissector path. The changes include unraveling the call chain into

[PATCH v4 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-28 Thread Tom Herbert
This patch set adds a new offload type to perform flow dissection for specific protocols (either by EtherType or by IP protocol). This is primary useful to crack open UDP encapsulations (like VXLAN, GUE) for the purposes of parsing the encapsulated packet. Items in this patch set: - Create new

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-28 Thread Yuchung Cheng
On Thu, Sep 28, 2017 at 1:14 AM, Oleksandr Natalenko wrote: > Hi. > > Won't tell about panic in tcp_sacktag_walk() since I cannot trigger it > intentionally, but setting net.ipv4.tcp_retrans_collapse to 0 *does not* fix > warning in tcp_fastretrans_alert() for me. Hi

Re: [net-next PATCH 3/5] bpf: cpumap xdp_buff to skb conversion and allocation

2017-09-28 Thread Daniel Borkmann
On 09/28/2017 02:57 PM, Jesper Dangaard Brouer wrote: [...] +/* Convert xdp_buff to xdp_pkt */ +static struct xdp_pkt *convert_to_xdp_pkt(struct xdp_buff *xdp) +{ + struct xdp_pkt *xdp_pkt; + int headroom; + + /* Assure headroom is available for storing info */ + headroom

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-28 Thread Vinicius Costa Gomes
Hi, Cong Wang writes: [...] >>> >>> I am not sure how we can solve this elegantly, perhaps you should >>> extend mqprio rather than add a new one? >> >> Is the alternative hinted in the FIXME worse? Instead of passing the >> index of the hardware queue to the driver

Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-09-28 Thread Andrew Lunn
Hi Bernd > >> + if (phy_state & BMSR_ANEGCOMPLETE) { > > > > It is worth comparing this against genphy_read_status() which is the > > reference implementation. You would normally check if auto negotiation > > is enabled, not if it has completed. If it is enabled you read the > > current

Re: [net-next PATCH 0/5] New bpf cpumap type for XDP_REDIRECT

2017-09-28 Thread Daniel Borkmann
On 09/28/2017 02:57 PM, Jesper Dangaard Brouer wrote: Introducing a new way to redirect XDP frames. Notice how no driver changes are necessary given the design of XDP_REDIRECT. This redirect map type is called 'cpumap', as it allows redirection XDP frames to remote CPUs. The remote CPU will

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

2017-09-28 Thread Cong Wang
On Wed, Sep 27, 2017 at 2:14 PM, Vinicius Costa Gomes wrote: > Hi, > > Cong Wang writes: > >> On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes >> wrote: >>> +static int cbs_init(struct Qdisc *sch, struct nlattr

Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

2017-09-28 Thread Rustad, Mark D
> On Sep 27, 2017, at 9:39 AM, Grant Grundler wrote: > > On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum wrote: >> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>> >>> I know that for at least some of the adapters in the CDC Ethernet

Re: [Patch net-next] net_sched: use idr to allocate u32 filter handles

2017-09-28 Thread Cong Wang
On Thu, Sep 28, 2017 at 12:34 AM, Simon Horman wrote: > Hi Cong, > > this looks like a nice enhancement to me. Did you measure any performance > benefit from it. Perhaps it could be described in the changelog_ I also > have a more detailed question below. No, I am

[PATCH v3 net-next 8/8] vxlan: support flow dissect

2017-09-28 Thread Tom Herbert
Populate offload flow_dissect callback appropriately for VXLAN and VXLAN-GPE. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index

[PATCH v3 net-next 5/8] ip: Add callbacks to flow dissection by IP protocol

2017-09-28 Thread Tom Herbert
Populate the proto_flow_dissect function for IPv4 and IPv6 packet offloads. This allows the caller to flow dissect a packet starting at the given IP protocol (as parsed to that point by flow dissector for instance). Signed-off-by: Tom Herbert --- net/ipv4/af_inet.c | 27

[PATCH v3 net-next 7/8] fou: Support flow dissection

2017-09-28 Thread Tom Herbert
Populate offload flow_dissect callabck appropriately for fou and gue. Signed-off-by: Tom Herbert --- net/ipv4/fou.c | 63 ++ 1 file changed, 63 insertions(+) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index

[PATCH v3 net-next 3/8] udp: Check static key udp_encap_needed in udp_gro_receive

2017-09-28 Thread Tom Herbert
Currently, the only support for udp gro is provided by UDP encapsulation protocols. Since they always set udp_encap_needed we can check that in udp_gro_receive functions before performing a socket lookup. Signed-off-by: Tom Herbert --- include/net/udp.h | 2 ++

[PATCH v3 net-next 4/8] flow_dissector: Add protocol specific flow dissection offload

2017-09-28 Thread Tom Herbert
Add offload capability for performing protocol specific flow dissection (either by EtherType or IP protocol). Specifically: - Add flow_dissect to offload callbacks - Move flow_dissect_ret enum to flow_dissector.h, cleanup names and add a couple of values - Unify handling of functions that

[PATCH v3 net-next 1/8] flow_dissector: Change skbuf argument to be non const

2017-09-28 Thread Tom Herbert
Change the skbuf argument of __skb_flow_dissect to be non constant so that the function can call functions that take non constant skbuf arguments. This is needed if we are to call socket lookup or BPF in the flow dissector path. The changes include unraveling the call chain into

[PATCH v3 net-next 2/8] flow_dissector: Move ETH_P_TEB processing to main switch

2017-09-28 Thread Tom Herbert
Support for processing TEB is currently in GRE flow dissection as a special case. This can be moved to be a case the main proto switch in __skb_flow_dissect. Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 45 - 1 file

[PATCH v3 net-next 6/8] udp: flow dissector offload

2017-09-28 Thread Tom Herbert
Add support to perform UDP specific flow dissection. This is primarily intended for dissecting encapsulated packets in UDP encapsulation. This patch adds a flow_dissect offload for UDP4 and UDP6. The backend function performs a socket lookup and calls the flow_dissect function if a socket is

[PATCH v3 net-next 0/8] flow_dissector: Protocol specific flow dissector offload

2017-09-28 Thread Tom Herbert
This patch set adds a new offload type to perform flow dissection for specific protocols (either by EtherType or by IP protocol). This is primary useful to crack open UDP encapsulations (like VXLAN, GUE) for the purposes of parsing the encapsulated packet. Items in this patch set: - Create new

linux-next: Signed-off-by missing for commit in the net-next tree

2017-09-28 Thread Stephen Rothwell
Hi all, Commit 8f1975e31d8e ("inetpeer: speed up inetpeer_invalidate_tree()") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-28 Thread Daniel Borkmann
On 09/28/2017 07:33 PM, Craig Gallek wrote: On Wed, Sep 27, 2017 at 6:03 PM, Daniel Borkmann wrote: On 09/27/2017 06:29 PM, Alexei Starovoitov wrote: On 9/27/17 7:04 AM, Craig Gallek wrote: From: Craig Gallek [...] yes it will break loading of

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-28 Thread Waskiewicz Jr, Peter
On 9/28/17 2:23 PM, John Fastabend wrote: > [...] > >> I'm pretty sure I misunderstood what you were going after with >> XDP_REDIRECT reserving the headroom. Our use case (patches coming in a >> few weeks) will populate the headroom coming out of the driver to XDP, >> and then once the XDP

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-28 Thread Daniel Borkmann
On 09/28/2017 10:52 PM, Waskiewicz Jr, Peter wrote: On 9/28/17 12:59 PM, Andy Gospodarek wrote: On Thu, Sep 28, 2017 at 1:59 AM, Waskiewicz Jr, Peter wrote: On 9/26/17 10:21 AM, Andy Gospodarek wrote: On Mon, Sep 25, 2017 at 08:50:28PM +0200, Daniel Borkmann

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-28 Thread John Fastabend
[...] > I'm pretty sure I misunderstood what you were going after with > XDP_REDIRECT reserving the headroom. Our use case (patches coming in a > few weeks) will populate the headroom coming out of the driver to XDP, > and then once the XDP program extracts whatever hints it wants via >

[PATCH net-next] ibmvnic: Set state UP

2017-09-28 Thread Mick Tarsel
State is initially reported as UNKNOWN. Before register call netif_carrier_off(). Once the device is opened, call netif_carrier_on() in order to set the state to UP. Signed-off-by: Mick Tarsel --- drivers/net/ethernet/ibm/ibmvnic.c | 2 ++ 1 file changed, 2

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-28 Thread Waskiewicz Jr, Peter
On 9/28/17 12:59 PM, Andy Gospodarek wrote: > On Thu, Sep 28, 2017 at 1:59 AM, Waskiewicz Jr, Peter > wrote: >> On 9/26/17 10:21 AM, Andy Gospodarek wrote: >>> On Mon, Sep 25, 2017 at 08:50:28PM +0200, Daniel Borkmann wrote: On 09/25/2017 08:10 PM, Andy

[PATCH net-next 07/10] sctp: add sockopt to get/set stream scheduler

2017-09-28 Thread Marcelo Ricardo Leitner
As defined per RFC Draft ndata Section 4.3.2, named as SCTP_STREAM_SCHEDULER. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 Signed-off-by: Marcelo Ricardo Leitner --- include/uapi/linux/sctp.h | 1 + net/sctp/socket.c | 75

[PATCH net-next 10/10] sctp: introduce round robin stream scheduler

2017-09-28 Thread Marcelo Ricardo Leitner
This patch introduces RFC Draft ndata section 3.2 Priority Based Scheduler (SCTP_SS_RR). Works by maintaining a list of enqueued streams and tracking the last one used to send data. When the datamsg is done, it switches to the next stream. See-also:

[PATCH net-next 04/10] sctp: introduce struct sctp_stream_out_ext

2017-09-28 Thread Marcelo Ricardo Leitner
With the stream schedulers, sctp_stream_out will become too big to be allocated by kmalloc and as we need to allocate with BH disabled, we cannot use __vmalloc in sctp_stream_init(). This patch moves out the stats from sctp_stream_out to sctp_stream_out_ext, which will be allocated only when the

[PATCH net-next 02/10] sctp: factor out stream->out allocation

2017-09-28 Thread Marcelo Ricardo Leitner
There is 1 place allocating it and 2 other reallocating. Move such procedures to a common function. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/stream.c | 52 1 file changed, 32 insertions(+), 20

[PATCH net-next 06/10] sctp: introduce stream scheduler foundations

2017-09-28 Thread Marcelo Ricardo Leitner
This patch introduces the hooks necessary to do stream scheduling, as per RFC Draft ndata. It also introduces the first scheduler, which is what we do today but now factored out: first come first served (FCFS). With stream scheduling now we have to track which chunk was enqueued on which stream

[PATCH net-next 09/10] sctp: introduce priority based stream scheduler

2017-09-28 Thread Marcelo Ricardo Leitner
This patch introduces RFC Draft ndata section 3.4 Priority Based Scheduler (SCTP_SS_PRIO). It works by having a struct sctp_stream_priority for each priority configured. This struct is then enlisted on a queue ordered per priority if, and only if, there is a stream with data queued, so that

[PATCH net-next 08/10] sctp: add sockopt to get/set stream scheduler parameters

2017-09-28 Thread Marcelo Ricardo Leitner
As defined per RFC Draft ndata Section 4.3.3, named as SCTP_STREAM_SCHEDULER_VALUE. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 Signed-off-by: Marcelo Ricardo Leitner --- include/uapi/linux/sctp.h | 7 + net/sctp/socket.c | 77

[PATCH net-next 03/10] sctp: factor out stream->in allocation

2017-09-28 Thread Marcelo Ricardo Leitner
Same idea as previous patch. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/stream.c | 36 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/net/sctp/stream.c b/net/sctp/stream.c index

[PATCH net-next 05/10] sctp: introduce sctp_chunk_stream_no

2017-09-28 Thread Marcelo Ricardo Leitner
Add a helper to fetch the stream number from a given chunk. Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/structs.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h index

[PATCH net-next 00/10] Introduce SCTP Stream Schedulers

2017-09-28 Thread Marcelo Ricardo Leitner
This patchset introduces the SCTP Stream Schedulers are defined by https://tools.ietf.org/html/draft-ietf-tsvwg-sctp-ndata-13 It provides 3 schedulers at the moment: FCFS, Priority and Round Robin. The other 3, Round Robin per packet, Fair Capacity and Weighted Fair Capacity will be added later.

[PATCH net-next 01/10] sctp: silence warns on sctp_stream_init allocations

2017-09-28 Thread Marcelo Ricardo Leitner
As SCTP supports up to 65535 streams, that can lead to very large allocations in sctp_stream_init(). As Xin Long noticed, systems with small amounts of memory are more prone to not have enough memory and dump warnings on dmesg initiated by user actions. Thus, silence them. Also, if the

Re: [PATCH 1/4] dt-bindings: net: ravb: Document optional reset-gpios property

2017-09-28 Thread Sergei Shtylyov
Hello! On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote: The optional "reset-gpios" property (part of the generic MDIO bus properties) lets us describe the GPIO used for resetting the Ethernet PHY. Signed-off-by: Geert Uytterhoeven ---

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Vivien Didelot
Hi Brandon, >> Would there be any value in implementing a proper gpiochip structure >> here such that other pieces of SW can see this GPIO controller as a >> provider and you can reference it from e.g: Device Tree using GPIO >> descriptors? > > That would be my preference as well, or maybe a

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-28 Thread Andy Gospodarek
On Thu, Sep 28, 2017 at 1:59 AM, Waskiewicz Jr, Peter wrote: > On 9/26/17 10:21 AM, Andy Gospodarek wrote: >> On Mon, Sep 25, 2017 at 08:50:28PM +0200, Daniel Borkmann wrote: >>> On 09/25/2017 08:10 PM, Andy Gospodarek wrote: >>> [...] First, thanks for this

Re: [PATCH/RFC net-next] ravb: RX checksum offload

2017-09-28 Thread Sergei Shtylyov
Hello! On 09/28/2017 01:49 PM, Simon Horman wrote: Add support for RX checksum offload. This is enabled by default and may be disabled and re-enabled using ethtool: # ethtool -K eth0 rx off # ethtool -K eth0 rx on The RAVB provides a simple checksumming scheme which appears to be

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Andrew Lunn
On Mon, Sep 18, 2017 at 08:27:13PM +, tristram...@microchip.com wrote: > > > +/** > > > + * Some counters do not need to be read too often because they are less > > likely > > > + * to increase much. > > > + */ > > > > What does comment mean? Are you caching statistics, and updating > >

Re: [PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

2017-09-28 Thread Vivien Didelot
Hi Brandon, Brandon Streiff writes: > static int dsa_slave_ioctl(struct net_device *dev, struct ifreq *ifr, int > cmd) > { > + struct dsa_slave_priv *p = netdev_priv(dev); > + struct dsa_switch *ds = p->dp->ds; > + int port = p->dp->index; > + > if

Re: [RFC PATCH v3 7/7] i40e: Enable cloud filters via tc-flower

2017-09-28 Thread Nambiar, Amritha
On 9/14/2017 1:00 AM, Nambiar, Amritha wrote: > On 9/13/2017 6:26 AM, Jiri Pirko wrote: >> Wed, Sep 13, 2017 at 11:59:50AM CEST, amritha.namb...@intel.com wrote: >>> This patch enables tc-flower based hardware offloads. tc flower >>> filter provided by the kernel is configured as driver specific

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Florian Fainelli
On 09/28/2017 11:45 AM, Geert Uytterhoeven wrote: > Hi Florian, > > On Thu, Sep 28, 2017 at 7:22 PM, Florian Fainelli > wrote: >> On 09/28/2017 08:53 AM, Geert Uytterhoeven wrote: >>> If the optional "reset-gpios" property is specified in DT, the generic >>> MDIO bus code

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Florian Fainelli
On 09/28/2017 11:40 AM, Pavel Machek wrote: > Hi! > > On Mon 2017-09-18 20:27:13, tristram...@microchip.com wrote: +/** + * Some counters do not need to be read too often because they are less >>> likely + * to increase much. + */ >>> >>> What does comment mean? Are you

Re: [PATCH 2/4] ravb: Add optional PHY reset during system resume

2017-09-28 Thread Geert Uytterhoeven
Hi Florian, On Thu, Sep 28, 2017 at 7:22 PM, Florian Fainelli wrote: > On 09/28/2017 08:53 AM, Geert Uytterhoeven wrote: >> If the optional "reset-gpios" property is specified in DT, the generic >> MDIO bus code takes care of resetting the PHY during device probe. >>

Re: [PATCH RFC 3/5] Add KSZ8795 switch driver

2017-09-28 Thread Pavel Machek
Hi! On Mon 2017-09-18 20:27:13, tristram...@microchip.com wrote: > > > +/** > > > + * Some counters do not need to be read too often because they are less > > likely > > > + * to increase much. > > > + */ > > > > What does comment mean? Are you caching statistics, and updating > > different

[PATCH V4] r8152: add Linksys USB3GIGV1 id

2017-09-28 Thread Grant Grundler
This linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ether.c | 10 ++ drivers/net/usb/r8152.c | 2 ++ 2 files

Re: [PATCH net-next v9] openvswitch: enable NSH support

2017-09-28 Thread Pravin Shelar
On Tue, Sep 26, 2017 at 6:39 PM, Yang, Yi wrote: > On Tue, Sep 26, 2017 at 06:49:14PM +0800, Jiri Benc wrote: >> On Tue, 26 Sep 2017 12:55:39 +0800, Yang, Yi wrote: >> > After push_nsh, the packet won't be recirculated to flow pipeline, so >> > key->eth.type must be set

[PATCH net-next] Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable"

2017-09-28 Thread Florian Fainelli
This reverts commit e85ec74ace29 ("net: dsa: bcm_sf2: Defer port enabling to calling port_enable") because this now makes an unbind followed by a bind to fail connecting to the ingrated PHY. What this patch missed is that we need the PHY to be enabled with bcm_sf2_gphy_enable_set() before probing

Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-09-28 Thread Bernd Edlinger
On 09/22/17 19:59, Andrew Lunn wrote: > On Fri, Sep 22, 2017 at 05:08:45PM +, Bernd Edlinger wrote: >> >> +config RENESAS_PHY >> +tristate "Driver for Renesas PHYs" >> +---help--- >> + Supports the uPD60620 and uPD60620A PHYs. >> + > > Hi Bernd > > Please call this "Reneseas

[PATCH v2] lib: fix multiple strlcpy definition

2017-09-28 Thread Baruch Siach
Some C libraries, like uClibc and musl, provide BSD compatible strlcpy(). Add check_strlcpy() to configure, and avoid defining strlcpy and strlcat when the C library provides them. This fixes the following static link error with uClibc-ng: .../sysroot/usr/lib/libc.a(strlcpy.os): In function

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Andrew Lunn
On Thu, Sep 28, 2017 at 10:45:03AM -0700, Florian Fainelli wrote: > On 09/28/2017 08:25 AM, Brandon Streiff wrote: > > The Scratch/Misc register is a windowed interface that provides access > > to the GPIO configuration. Provide a new method for configuration of > > GPIO functions. > > > >

Re: [patch net-next 3/7] ipv4: ipmr: Don't forward packets already forwarded by hardware

2017-09-28 Thread Florian Fainelli
On 09/28/2017 10:34 AM, Jiri Pirko wrote: > From: Yotam Gigi > > Change the ipmr module to not forward packets if: > - The packet is marked with the offload_mr_fwd_mark, and > - Both input interface and output interface share the same parent ID. > > This way, a packet can

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-09-28 Thread Florian Fainelli
On 09/28/2017 10:36 AM, Andrew Lunn wrote: >> - Patch #3: The GPIO config support is handled in a very simple manner. >> I suspect a longer term goal would be to use pinctrl here. > > I assume ptp already has the core code to use pinctrl and Linux > standard GPIOs? What does the device tree

Re: [patch net-next 1/7] skbuff: Add the offload_mr_fwd_mark field

2017-09-28 Thread Andrew Lunn
On Thu, Sep 28, 2017 at 07:34:09PM +0200, Jiri Pirko wrote: > From: Yotam Gigi > > Similarly to the offload_fwd_mark field, the offload_mr_fwd_mark field is > used to allow partial offloading of MFC multicast routes. > The reason why the already existing "offload_fwd_mark"

Re: [PATCH] net-ipv6: remove unused IP6_ECN_clear() function

2017-09-28 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 26 Sep 2017 20:37:22 -0700 > From: Maciej Żenczykowski > > This function is unused, and furthermore it is buggy since it suffers > from the same issue that requires IP6_ECN_set_ce() to take a pointer > to the skb so

Re: [PATCH v5 1/4] ipv4: Namespaceify tcp_fastopen knob

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:40 +0800 > Different namespace application might require enable TCP Fast Open > feature independently of the host. > > This patch series continues making more of the TCP Fast Open related > sysctl knobs be per

Re: [PATCH v5 2/4] ipv4: Remove the 'publish' logic in tcp_fastopen_init_key_once

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:41 +0800 > The 'publish' logic is not necessary after commit dfea2aa65424 ("tcp: > Do not call tcp_fastopen_reset_cipher from interrupt context"), because > in tcp_fastopen_cookie_gen,it wouldn't call

Re: [PATCH v5 3/4] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:42 +0800 > Different namespace application might require different tcp_fastopen_key > independently of the host. > > David Miller pointed out there is a leak without releasing the context > of tcp_fastopen_key

Re: [PATCH v5 4/4] ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob

2017-09-28 Thread David Miller
From: Haishuang Yan Date: Wed, 27 Sep 2017 11:35:43 +0800 > Different namespace application might require different time period in > second to disable Fastopen on active TCP sockets. > > Tested: > Simulate following similar situation that the server's data

Re: [PATCH net-next RFC 3/9] net: dsa: mv88e6xxx: add support for GPIO configuration

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:25 AM, Brandon Streiff wrote: > The Scratch/Misc register is a windowed interface that provides access > to the GPIO configuration. Provide a new method for configuration of > GPIO functions. > > Signed-off-by: Brandon Streiff > --- > +/* Offset 0x1A:

Re: [PATCH net-next RFC 6/9] net: dsa: forward timestamping callbacks to switch drivers

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:25 AM, Brandon Streiff wrote: > Forward the rx/tx timestamp machinery from the dsa infrastructure to the > switch driver. > > On the rx side, defer delivery of skbs until we have an rx timestamp. > This mimicks the behavior of skb_defer_rx_timestamp. The implementation > does

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-09-28 Thread Andrew Lunn
> - Patch #3: The GPIO config support is handled in a very simple manner. > I suspect a longer term goal would be to use pinctrl here. I assume ptp already has the core code to use pinctrl and Linux standard GPIOs? What does the device tree binding look like? How do you specify the GPIOs to

[iproute PATCH] ip-route: Fix for listing routes with RTAX_LOCK attribute

2017-09-28 Thread Phil Sutter
This fixes a corner-case for routes with a certain metric locked to zero: | ip route add 192.168.7.0/24 dev eth0 window 0 | ip route add 192.168.7.0/24 dev eth0 window lock 0 Since the kernel doesn't dump the attribute if it is zero, both routes added above would appear as if they were equal

Re: [PATCH v3 net-next 00/10] Add support for DCB feature in hns3 driver

2017-09-28 Thread David Miller
From: Yunsheng Lin Date: Wed, 27 Sep 2017 09:45:22 +0800 > The patchset contains some enhancement related to DCB before > adding support for DCB feature. Series applied, thanks.

Re: [PATCH net] net: Set sk_prot_creator when cloning sockets to the right proto

2017-09-28 Thread David Miller
From: Christoph Paasch Date: Tue, 26 Sep 2017 17:38:50 -0700 > sk->sk_prot and sk->sk_prot_creator can differ when the app uses > IPV6_ADDRFORM (transforming an IPv6-socket to an IPv4-one). > Which is why sk_prot_creator is there to make sure that sk_prot_free() > does the

[patch net-next 1/7] skbuff: Add the offload_mr_fwd_mark field

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Similarly to the offload_fwd_mark field, the offload_mr_fwd_mark field is used to allow partial offloading of MFC multicast routes. Switchdev drivers can offload MFC multicast routes to the hardware by registering to the FIB notification chain. When one of

[patch net-next 3/7] ipv4: ipmr: Don't forward packets already forwarded by hardware

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Change the ipmr module to not forward packets if: - The packet is marked with the offload_mr_fwd_mark, and - Both input interface and output interface share the same parent ID. This way, a packet can go through partial multicast forwarding in the

[patch net-next 2/7] ipv4: ipmr: Add the parent ID field to VIF struct

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi In order to allow the ipmr module to do partial multicast forwarding according to the device parent ID, add the device parent ID field to the VIF struct. This way, the forwarding path can use the parent ID field without invoking switchdev calls, which

[patch net-next 6/7] mlxsw: spectrum: mr_tcam: Add trap-and-forward multicast route

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi In addition to the current multicast route actions, which include trap route action and a forward route action, add the trap-and-forward multicast route action, and implement it in the multicast routing hardware logic. To implement that, add a

[patch net-next 7/7] mlxsw: spectrum: mr: Support trap-and-forward routes

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Add the support of trap-and-forward route action in the multicast routing offloading logic. A route will be set to trap-and-forward action if one (or more) of its output interfaces is not offload-able, i.e. does not have a valid Spectrum RIF. This way, a

[patch net-next 4/7] mlxsw: acl: Introduce ACL trap and forward action

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi Use trap/discard flex action to implement trap and forward. The action will later be used for multicast routing, as the multicast routing mechanism is done using ACL flexible actions in Spectrum hardware. Using that action, it will be possible to implement a

[patch net-next 5/7] mlxsw: spectrum: Add trap for multicast trap-and-forward routes

2017-09-28 Thread Jiri Pirko
From: Yotam Gigi When a multicast route is configured with trap-and-forward action, the packets should be marked with skb->offload_mr_fwd_mark, in order to prevent the packets from being forwarded again by the kernel ipmr module. Due to this, it is not possible to use the

[patch net-next 0/7] mlxsw: Add support for partial multicast route offload

2017-09-28 Thread Jiri Pirko
From: Jiri Pirko Yotam says: Previous patchset introduced support for offloading multicast MFC routes to the Spectrum hardware. As described in that patchset, no partial offloading is supported, i.e if a route has one output interface which is not a valid offloadable device

Re: [PATCH net-next] libbpf: use map_flags when creating maps

2017-09-28 Thread Craig Gallek
On Wed, Sep 27, 2017 at 6:03 PM, Daniel Borkmann wrote: > On 09/27/2017 06:29 PM, Alexei Starovoitov wrote: >> >> On 9/27/17 7:04 AM, Craig Gallek wrote: >>> >>> From: Craig Gallek >>> >>> This extends struct bpf_map_def to include a flags field. Note

Re: [PATCH] arp: make arp_hdr_len() return unsigned int

2017-09-28 Thread David Miller
From: Alexey Dobriyan Date: Tue, 26 Sep 2017 23:12:28 +0300 > Negative ARP header length are not a thing. > > Constify arguments while I'm at it. > > Space savings: > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3) > functionold

Re: [PATCH net v2] net: dsa: mv88e6xxx: lock mutex when freeing IRQs

2017-09-28 Thread David Miller
From: Vivien Didelot Date: Tue, 26 Sep 2017 14:57:21 -0400 > mv88e6xxx_g2_irq_free locks the registers mutex, but not > mv88e6xxx_g1_irq_free, which results in a stack trace from > assert_reg_lock when unloading the mv88e6xxx module. Fix this. > > Fixes:

Re: [PATCH net-next] net-next/hinic: Fix a case of Tx Queue is Stopped forever

2017-09-28 Thread David Miller
From: Aviad Krawczyk Date: Wed, 27 Sep 2017 02:11:33 +0800 > Fix the following scenario: > 1. tx_free_poll is running on cpu X > 2. xmit function is running on cpu Y and fails to get sq wqe > 3. tx_free_poll frees wqes on cpu X and checks the queue is not stopped > 4.

Re: [PATCH net-next] net-next/hinic: Set Rxq irq to specific cpu for NUMA

2017-09-28 Thread David Miller
From: Aviad Krawczyk Date: Wed, 27 Sep 2017 01:57:50 +0800 > Set Rxq irq to specific cpu for allocating and receiving the skb from > the same node. > > Signed-off-by: Aviad Krawczyk Applied.

Re: [PATCH net-next RFC 5/9] net: dsa: forward hardware timestamping ioctls to switch driver

2017-09-28 Thread Florian Fainelli
On 09/28/2017 08:25 AM, Brandon Streiff wrote: > This patch adds support to the dsa slave network device so that > switch drivers can implement the SIOC[GS]HWTSTAMP ioctls and the > ethtool timestamp-info interface. > > Signed-off-by: Brandon Streiff > --- > struct

Re: [PATCH net] packet: only test po->has_vnet_hdr once in packet_snd

2017-09-28 Thread David Miller
aFrom: Willem de Bruijn Date: Tue, 26 Sep 2017 12:20:17 -0400 > From: Willem de Bruijn > > Packet socket option po->has_vnet_hdr can be updated concurrently with > other operations if no ring is attached. > > Do not test the option twice in

Re: [PATCH net] packet: in packet_do_bind, test fanout with bind_lock held

2017-09-28 Thread David Miller
From: Willem de Bruijn Date: Tue, 26 Sep 2017 12:19:37 -0400 > From: Willem de Bruijn > > Once a socket has po->fanout set, it remains a member of the group > until it is destroyed. The prot_hook must be constant and identical > across

Re: [PATCH v2 net-next 0/2] bpf/verifier: disassembly improvements

2017-09-28 Thread David Miller
From: Edward Cree Date: Tue, 26 Sep 2017 16:32:15 +0100 > Fix the output of print_bpf_insn() for ALU ops that don't look like > compound assignment (i.e. BPF_END and BPF_NEG). > > Sample output for a short test program: > 0: (b4) (u32) r0 = (u32) 0 > 1: (dc) r0 = be32 r0

  1   2   3   >