Re: [PATCH net] net: fib_rules: Fix fib_rules_ops->compare implementations to support exact match

2017-10-06 Thread Shmulik Ladkani
Hi David, On Tue, 03 Oct 2017 14:54:18 -0700 (PDT) David Miller wrote: > From: Shmulik Ladkani > Date: Sat, 30 Sep 2017 11:59:09 +0300 > > > This leads to inconsistencies, depending on order of operations, e.g.: > > I don't see any inconsistency. When you insert using NLM_F_EXCL the > ins

Re: [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread David Miller
From: Roopa Prabhu Date: Fri, 6 Oct 2017 19:35:27 -0700 > On Fri, Oct 6, 2017 at 11:34 AM, Roopa Prabhu > wrote: >> From: Roopa Prabhu >> >> This series implements arp and nd suppression in the bridge >> driver for ethernet vpns. It implements rfc7432, section 10 >> https://tools.ietf.org/html

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-06 Thread kbuild test robot
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-pu

[PATCH net-next v6 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

[PATCH net-next v6 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic differenc

[PATCH net-next v6 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188 ++

[PATCH net-next v6 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11 ++ net

Re: [PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure.

2017-10-06 Thread Herbert Xu
Allen Pais wrote: > Signed-off-by: Allen Pais Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-06 Thread kbuild test robot
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-pu

Re: [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN

2017-10-06 Thread Herbert Xu
On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote: > > diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c > index 5e92bd2..3b3c154 100644 > --- a/crypto/algif_hash.c > +++ b/crypto/algif_hash.c > @@ -39,6 +39,20 @@ struct algif_hash_tfm { > bool has_key; > }; > > +/* Pre

Re: [PATCH] net: dsa: mv88e6xxx: rework in-chip bridging

2017-10-06 Thread Florian Fainelli
Le 10/03/17 à 23:20, Greg Ungerer a écrit : > Hi Vivien, > > On Wed, Mar 29, 2017 at 04:30:16PM -0400, Vivien Didelot wrote: >> All ports -- internal and external, for chips featuring a PVT -- have a >> mask restricting to which internal ports a frame is allowed to egress. >> >> Now that DSA expos

Re: [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
On Fri, Oct 6, 2017 at 11:34 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://tools.ietf.org/html/rfc7432#section-10 > for ethernet VPN deployments. It is similar to

Re: [PATCH net-next 11/16] ipv6: replace dst_hold() with dst_hold_safe() in routing code

2017-10-06 Thread David Miller
From: 吉藤英明 Date: Sat, 7 Oct 2017 08:57:49 +0900 > Hi, > > 2017-10-07 4:06 GMT+09:00 Wei Wang : >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >> index 941c062389d2..aeb349aea429 100644 >> --- a/net/ipv6/route.c >> +++ b/net/ipv6/route.c > : >> @@ -1625,12 +1643,17 @@ struct rt6_info *ip6_po

Re: [PATCH net-next 11/16] ipv6: replace dst_hold() with dst_hold_safe() in routing code

2017-10-06 Thread Wei Wang
On Fri, Oct 6, 2017 at 4:57 PM, 吉藤英明 wrote: > Hi, > > 2017-10-07 4:06 GMT+09:00 Wei Wang : >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >> index 941c062389d2..aeb349aea429 100644 >> --- a/net/ipv6/route.c >> +++ b/net/ipv6/route.c > : >> @@ -1625,12 +1643,17 @@ struct rt6_info *ip6_pol_rout

Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

2017-10-06 Thread David Miller
From: Michael Chan Date: Fri, 6 Oct 2017 18:27:31 -0700 > On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: >> There is no reason to wrap the data structures inside the ifdef. > > What's so bad about wrapping unused data structures inside #ifdef? > These structures are only used if CONFI

Re: [PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

2017-10-06 Thread David Miller
From: Michael Chan Date: Fri, 6 Oct 2017 18:01:57 -0700 > On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: >> Instead of zeroing out bnxt_tc.c with a #ifdef foo, instead don't compile >> the file when the option is not enabled. Now make and the preprocessor do >> not have to waste time c

Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

2017-10-06 Thread Michael Chan
On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: > There is no reason to wrap the data structures inside the ifdef. What's so bad about wrapping unused data structures inside #ifdef? These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is defined.

Re: [PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

2017-10-06 Thread Michael Chan
On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: > Instead of zeroing out bnxt_tc.c with a #ifdef foo, instead don't compile > the file when the option is not enabled. Now make and the preprocessor do > not have to waste time compiling a no-op. > > Signed-off-by: Jonathan Toppins Acked-b

[PATCH iproute2 2/2] ss: print MD5 signature keys configured on TCP sockets

2017-10-06 Thread Ivan Delalande
These keys are reported by kernel 4.14 and later under the INET_DIAG_MD5SIG attribute, when INET_DIAG_INFO is requested (ss -i) and we have CAP_NET_ADMIN. The additional output looks like: md5keys:fe80::/64=signing_key,10.1.2.0/24=foobar,::1/128=Test Signed-off-by: Ivan Delalande --- mi

[PATCH iproute2 1/2] utils: add print_escape_buf to format and print arbitrary bytes

2017-10-06 Thread Ivan Delalande
Keep it as simple as possible for now: just escape anything that is not isprint-able, is among the "escape" parameter or '\' as an octal escape sequence. This should be pretty easy to extend if any other user needs something more complex in the future. Signed-off-by: Ivan Delalande --- include/u

Re: [PATCH net-next 11/16] ipv6: replace dst_hold() with dst_hold_safe() in routing code

2017-10-06 Thread 吉藤英明
Hi, 2017-10-07 4:06 GMT+09:00 Wei Wang : > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 941c062389d2..aeb349aea429 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c : > @@ -1625,12 +1643,17 @@ struct rt6_info *ip6_pol_route(struct net *net, > struct fib6_table *table, >

Re: [PATCH net-next 00/16] ipv6: replace rwlock with rcu and spinlock in fib6 table

2017-10-06 Thread Eric Dumazet
On Fri, 2017-10-06 at 12:05 -0700, Wei Wang wrote: > From: Wei Wang > > Currently, fib6 table is protected by rwlock. During route lookup, > reader lock is taken and during route insertion, deletion or > modification, writer lock is taken. This is a very inefficient > implementation because the f

[pull request][for-next 0/9] Mellanox, mlx5 updates 2017-10-06

2017-10-06 Thread Saeed Mahameed
Hi Dave and Doug, This series includes some shared code updates for kernel 4.15 to both net-next and rdma-next trees. The series includes mlx5 low level flow steering updates and optimizations to support firmware command parallelism for flow steering requests from Maor Gottlieb and two other smal

[for-next 4/9] net/mlx5: Export building of matched flow groups list

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb Refactor the code and export the build of the matched flow groups list to separate function. Signed-off-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 100 ++ 1 file changed, 64 insertions(+), 36

[for-next 2/9] net/mlx5: Avoid NULL pointer dereference on steering cleanup

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb On cleanup, when the node is the last child of parent then it calls to tree_put_node on the parent, if the parent's reference count is decremented to 0 (for e.g. when deleting last destination of FTE) then we free the parent as well and vice versa. In such a case we will try t

[for-next 1/9] net/mlx5: Fix creating a new FTE when an existing but full FTE exists

2017-10-06 Thread Saeed Mahameed
From: Matan Barak Currently, when a flow steering rule is added, we look for a FTE with an identical value. If we find a match, we try to merge the required destinations with the existing ones. In a case where the existing destination list is full, the code should return an error to its consumer.

[for-next 3/9] net/mlx5: Move the entry index allocator to flow group

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb When new flow table entry is added, we search for free index in the flow group and not in the flow table, therefore we can move the allocator from flow table to flow group. In downstream patches it will enable us to lock smaller part of the steering tree. Signed-off-by: Maor

[for-next 5/9] net/mlx5: Refactor FTE and FG creation code

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb Split the creation code to two parts: 1) Object allocation - allocate the steering node and initialize its resources. 2) The firmware command execution. Adding active flag to each node - this flag indicates if the object exists in the hardware or not, if not we don't free th

[for-next 8/9] net/mlx5: Allocate FTE object without lock

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb Allocation of new FTE is a massive operation, part of it could be done without taking the flow group write lock. Split the FTE allocation to two functions of actions which need to be under lock and action which don't have. Signed-off-by: Maor Gottlieb Signed-off-by: Saeed Ma

[for-next 7/9] net/mlx5: Support multiple updates of steering rules in parallel

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb Most of the time spent on adding new flow steering rule is executing the firmware command. The most common action is adding a new flow steering entry. In order to enhance the update rate we parallelize the commands by doing the following: 1) Replace the mutex lock with reader

[for-next 9/9] net/mlx5: Add FGs and FTEs memory pool

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb Add memory pool allocation for flow groups and flow table entry. It is useful because these objects are not small and could be allocated/deallocated many times. Signed-off-by: Maor Gottlieb Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.

[for-next 6/9] net/mlx5: Replace fs_node mutex with reader/writer semaphore

2017-10-06 Thread Saeed Mahameed
From: Maor Gottlieb Currently, steering object is protected by mutex lock, replace the mutex lock with reader/writer semaphore . In this patch we still use only write semaphore. In downstream patches we will switch part of the write locks to read locks. Signed-off-by: Maor Gottlieb Signed-off-b

Re: [PATCH net-next 0/7] tcp: implement rb-tree based retransmit queue

2017-10-06 Thread David Miller
From: Eric Dumazet Date: Thu, 5 Oct 2017 22:21:20 -0700 > This patch series implement RB-tree based retransmit queue for TCP, > to better match modern BDP. Indeed, there was a lot of resistence to this due to the overhead for small retransmit queue sizes, but with today's scale this is long ove

Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread David Miller
From: Stephen Hemminger Date: Fri, 6 Oct 2017 16:12:45 -0700 > On Fri, 6 Oct 2017 18:37:01 -0400 > Willem de Bruijn wrote: > >> > It looks like you are just exporting the statistics taht are already >> > through normal path. The purpose of ethtool stats is to provide >> > statistics unique to t

Re: [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-10-06

2017-10-06 Thread David Miller
From: Jeff Kirsher Date: Fri, 6 Oct 2017 10:57:12 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Stephen Hemminger
On Fri, 6 Oct 2017 18:37:01 -0400 Willem de Bruijn wrote: > > It looks like you are just exporting the statistics taht are already > > through normal path. The purpose of ethtool stats is to provide > > statistics unique to the device, not to repeat what is available throug > > ip, ifconfig, etc.

Re: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb_xmit

2017-10-06 Thread William Tu
On Fri, Oct 6, 2017 at 3:22 PM, David Miller wrote: > From: William Tu > Date: Fri, 6 Oct 2017 15:09:29 -0700 > >> Yes, adding another field in the struct net_device can avoid the >> arithmetic operation. I'm not sure it's a good idea to add new field >> since there are already a lot in net_devic

Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Willem de Bruijn
On Fri, Oct 6, 2017 at 6:30 PM, Stephen Hemminger wrote: > On Fri, 6 Oct 2017 18:25:14 -0400 > Willem de Bruijn wrote: > >> From: Willem de Bruijn >> >> Support ethtool -S on tun devices. This interface allows exporting >> device-specific stats not present in rtnl stats. >> >> Signed-off-by: Wi

Re: [PATCH RFC 2/3] tun: expand ethtool stats with zerocopy

2017-10-06 Thread Willem de Bruijn
On Fri, Oct 6, 2017 at 6:25 PM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Add two counters to tun ethool stats to count zerocopy completions. > - tx_zerocopy counts completions that succeeded without copy. > - tx_zerocopy_err counts those that triggered a copy. > > Tun intercepts compl

Re: [PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Stephen Hemminger
On Fri, 6 Oct 2017 18:25:14 -0400 Willem de Bruijn wrote: > From: Willem de Bruijn > > Support ethtool -S on tun devices. This interface allows exporting > device-specific stats not present in rtnl stats. > > Signed-off-by: Willem de Bruijn > --- > drivers/net/tun.c | 38 +++

[PATCH RFC 1/3] tun: ethtool stats

2017-10-06 Thread Willem de Bruijn
From: Willem de Bruijn Support ethtool -S on tun devices. This interface allows exporting device-specific stats not present in rtnl stats. Signed-off-by: Willem de Bruijn --- drivers/net/tun.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/n

[PATCH RFC 2/3] tun: expand ethtool stats with zerocopy

2017-10-06 Thread Willem de Bruijn
From: Willem de Bruijn Add two counters to tun ethool stats to count zerocopy completions. - tx_zerocopy counts completions that succeeded without copy. - tx_zerocopy_err counts those that triggered a copy. Tun intercepts completions by replacing the zerocopy completion handler (ubuf_info) prepa

[PATCH RFC 0/3] tun zerocopy stats

2017-10-06 Thread Willem de Bruijn
From: Willem de Bruijn Add zerocopy transfer statistics to the vhost_net/tun zerocopy path. I've been using this to verify recent changes to zerocopy tuning [1]. Sharing more widely, as it may be useful in similar future work. Use ethtool stats as interface, as these are defined per device driv

[PATCH RFC 3/3] vhost_net: support tun zerocopy stats

2017-10-06 Thread Willem de Bruijn
From: Willem de Bruijn Allow the tun device to intercept zerocopy completions to increment its counters. Pass an array of two struct ubuf_info to the device. The first is initialized as usual and used to notify vhost_net. The second is granted to the tun device for its callback. Use the existin

Re: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb_xmit

2017-10-06 Thread David Miller
From: William Tu Date: Fri, 6 Oct 2017 15:09:29 -0700 > Yes, adding another field in the struct net_device can avoid the > arithmetic operation. I'm not sure it's a good idea to add new field > since there are already a lot in net_device. Let's wait to see how > others think. Why would you add

Re: [PATCH net-next] ip_gre: check packet length and mtu correctly in erspan_fb_xmit

2017-10-06 Thread William Tu
On Fri, Oct 6, 2017 at 2:38 AM, David Laight wrote: > From: William Tu >> Sent: 05 October 2017 22:21 > ... >> >> - if (skb->len > dev->mtu) { >> >> + if (skb->len - dev->hard_header_len > dev->mtu) { >> > >> > Can you guarantee that skb->len > dev_hard_header_len? >> > It is probably safe

Re: [PATCH net-next 4/4] selinux: bpf: Add addtional check for bpf object file receive

2017-10-06 Thread Chenbo Feng
On Thu, Oct 5, 2017 at 11:26 AM, Stephen Smalley wrote: > On Thu, 2017-10-05 at 09:37 -0400, Stephen Smalley wrote: >> On Wed, 2017-10-04 at 11:29 -0700, Chenbo Feng wrote: >> > From: Chenbo Feng >> > >> > Introduce a bpf object related check when sending and receiving >> > files >> > through uni

Re: [PATCH net-next 4/4] selinux: bpf: Add addtional check for bpf object file receive

2017-10-06 Thread Chenbo Feng
On Thu, Oct 5, 2017 at 6:37 AM, Stephen Smalley wrote: > On Wed, 2017-10-04 at 11:29 -0700, Chenbo Feng wrote: >> From: Chenbo Feng >> >> Introduce a bpf object related check when sending and receiving files >> through unix domain socket as well as binder. It checks if the >> receiving >> process

[PATCH v1 RFC 0/7] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers

2017-10-06 Thread Tristram.Ha
From: Tristram Ha This series of patches is to modify the original KSZ9477 DSA driver so that other KSZ switch drivers can be added and use the common code. There are several steps to accomplish this achievement. First is to rename some function names with a prefix to indicate chip specific fun

[PATCH v1 RFC 1/7] Replace license with GPL

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Replace license with GPL. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz_9477_reg.h | 23 --- drivers/net/dsa/microchip/ksz_common.c | 23 --- drivers/net/dsa/microchip/ksz_priv.h | 23 --- driver

[PATCH v1 RFC 2/7] Clean up code according to patch check suggestions

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Clean up code according to patch check suggestions. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz_common.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common

[PATCH v1 RFC 3/7] Rename some functions with ksz9477 prefix

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Rename some functions with ksz9477 prefix to separate chip specific code from common code. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz_common.c | 116 + 1 file changed, 59 insertions(+), 57 deletions(-) diff --git a/drivers/ne

[PATCH v1 RFC 4/7] Rename ksz_spi.c to ksz9477_spi.c

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Rename ksz_spi.c to ksz9477_spi.c and update Kconfig in preparation to add more KSZ switch drivers. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/Kconfig | 12 ++-- drivers/net/dsa/microchip/Makefile | 4 ++-- drive

[PATCH v1 RFC 5/7] Break KSZ9477 DSA driver into two files

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Break KSZ9477 DSA driver into two files in preparation to add more KSZ switch drivers. Add common functions in ksz_common.h so that other KSZ switch drivers can access code in ksz_common.c. Add ksz_spi.h for common functions used by KSZ switch SPI drivers. Signed-off-by: Tristr

[PATCH v1 RFC 0/1] Add Microchip KSZ8795 DSA driver

2017-10-06 Thread Tristram.Ha
From: Tristram Ha This patch requires the previous patches for Microchip KSZ9477 DSA driver. v1 - Return error codes instead of numbers - Add more comments to clarify operation - Use ksz8795 prefix to indicate KSZ8795 specific code - Simplify MIB counter reading code - Switch driver code is not

[PATCH RFC] Add Microchip KSZ8895 DSA driver

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Add Microchip KSZ8895 DSA driver. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/Kconfig | 17 + drivers/net/dsa/microchip/Makefile |2 + drivers/net/dsa/microchip/ksz8895.c | 1288 +++ drivers/net/dsa/microchip/ksz88

[PATCH v1 RFC 6/7] Add MIB counter reading support

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Add MIB counter reading support. Rename ksz_9477_reg.h to ksz9477_reg.h for consistency as the product name is always KSZ. Header file ksz_priv.h no longer contains any chip specific data. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz9477.c|

[PATCH RFC 0/1] Add Microchip KSZ8895 DSA driver

2017-10-06 Thread Tristram.Ha
From: Tristram Ha This patch requires the previous patch for Microchip KSZ8795 DSA driver. Tristram Ha (1): Add Microchip KSZ8895 DSA driver. drivers/net/dsa/microchip/Kconfig | 17 + drivers/net/dsa/microchip/Makefile |2 + drivers/net/dsa/microchip/ksz8895.c | 1288 +++

[PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Add Microchip KSZ8795 DSA driver. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/Kconfig | 17 + drivers/net/dsa/microchip/Makefile |2 + drivers/net/dsa/microchip/ksz8795.c | 1372 +++ drivers/net/dsa/microchip/ksz87

[PATCH RFC] Add other KSZ switch support so that patch check does not complain

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Add other KSZ switch support so that patch check does not complain. Signed-off-by: Tristram Ha --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 189 -- 1 file changed, 136 insertions(+), 53 deletions(-) diff --git a/Documentation/devicetree/binding

[PATCH v1 RFC 7/7] Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers

2017-10-06 Thread Tristram.Ha
From: Tristram Ha Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/Kconfig | 2 +- drivers/net/dsa/microchip/ksz9477.c | 2 +- include/net/dsa.h | 2 +- net/dsa/Kconfig

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-06 Thread Oliver Hartkopp
On 10/06/2017 08:18 PM, David Ahern wrote: On 10/5/17 4:19 AM, Nicolas Dichtel wrote: IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of the attribute is 1 ("\0"). However, to remove an alias, the attribute length must be 0 (see dev_set_alias()). why not add a check i

[PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

2017-10-06 Thread Jonathan Toppins
There is no reason to wrap the data structures inside the ifdef. Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.h b/drivers/net/ethernet/broadcom/

[PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

2017-10-06 Thread Jonathan Toppins
Instead of zeroing out bnxt_tc.c with a #ifdef foo, instead don't compile the file when the option is not enabled. Now make and the preprocessor do not have to waste time compiling a no-op. Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/broadcom/bnxt/Makefile | 3 ++- drivers/net/ethe

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-06 Thread Kees Cook
On Fri, Oct 6, 2017 at 12:00 PM, Paul Bolle wrote: > On Thu, 2017-10-05 at 12:31 -0700, Kees Cook wrote: >> --- a/drivers/isdn/gigaset/bas-gigaset.c >> +++ b/drivers/isdn/gigaset/bas-gigaset.c > >> -static void cmd_in_timeout(unsigned long data) >> +static void cmd_in_timeout(struct timer_list *t)

[PATCH net-next 11/16] ipv6: replace dst_hold() with dst_hold_safe() in routing code

2017-10-06 Thread Wei Wang
From: Wei Wang With rwlock, it is safe to call dst_hold() in the read thread because read thread is guaranteed to be separated from write thread. However, after we replace rwlock with rcu, it is no longer safe to use dst_hold(). A dst might already have been deleted but is waiting for the rcu gra

[PATCH net-next 05/16] ipv6: prepare rt6_clean_tohost() for exception table

2017-10-06 Thread Wei Wang
From: Wei Wang If we move all cached dst into the exception table under the main route, current rt6_clean_tohost() will no longer be able to access them. This commit makes fib6_clean_tohost() to also go through all cached routes in exception table and removes cached gateway routes to the passed i

[PATCH net-next 01/16] ipv6: introduce a new function fib6_update_sernum()

2017-10-06 Thread Wei Wang
From: Wei Wang This function takes a route as input and tries to update the sernum in the fib6_node this route is associated with. It will be used in later commit when adding a cached route into the exception table under that route. Signed-off-by: Wei Wang Signed-off-by: Martin KaFai Lau Signe

[PATCH net-next 10/16] ipv6: don't release rt->rt6i_pcpu memory during rt6_release()

2017-10-06 Thread Wei Wang
From: Wei Wang After rwlock is replaced with rcu and spinlock, route lookup can happen simultanously with route deletion. This patch removes the call to free_percpu(rt->rt6i_pcpu) from rt6_release() to avoid the race condition between rt6_release() and rt6_get_pcpu_route(). And as free_percpu(rt-

[PATCH net-next 03/16] ipv6: prepare fib6_remove_prefsrc() for exception table

2017-10-06 Thread Wei Wang
From: Wei Wang After we move cached dst entries into the exception table under its parent route, current fib6_remove_prefsrc() no longer can access them. This commit makes fib6_remove_prefsrc() also go through all routes in the exception table to remove the pref src. This is a preparation patch i

[PATCH net-next 06/16] ipv6: prepare fib6_age() for exception table

2017-10-06 Thread Wei Wang
From: Wei Wang If all dst cache entries are stored in the exception table under the main route, we have to go through them during fib6_age() when doing garbage collecting. Introduce a new function rt6_age_exception() which goes through all dst entries in the exception table and remove those entri

[PATCH net-next 09/16] ipv6: grab rt->rt6i_ref before allocating pcpu rt

2017-10-06 Thread Wei Wang
From: Wei Wang After rwlock is replaced with rcu and spinlock, ip6_pol_route() will be called with only rcu held. That means rt6 route deletion could happen simultaneously with rt6_make_pcpu_rt(). This could potentially cause memory leak if rt6_release() is called right before rt6_make_pcpu_rt()

[PATCH net-next 16/16] ipv6: take care of rt6_stats

2017-10-06 Thread Wei Wang
From: Wei Wang Currently, most of the rt6_stats are not hooked up correctly. As the last part of this patch series, hook up all existing rt6_stats and add one new stat fib_rt_uncache to indicate the number of routes in the uncached list. For details of the stats, please refer to the comments adde

[PATCH net-next 13/16] ipv6: check fn->leaf before it is used

2017-10-06 Thread Wei Wang
From: Wei Wang If rwlock is replaced with rcu and spinlock, it is possible that the reader thread will see fn->leaf as NULL in the following scenarios: 1. fib6_add() is in progress and we have already inserted a new node but not yet inserted the route. 2. fib6_del_route() is in progress and we ha

[PATCH net-next 15/16] ipv6: replace rwlock with rcu and spinlock in fib6_table

2017-10-06 Thread Wei Wang
From: Wei Wang With all the preparation work before, we are now ready to replace rwlock with rcu and spinlock in fib6_table. That means now all fib6_node in fib6_table are protected by rcu. And when freeing fib6_node, call_rcu() is used to wait for the rcu grace period before releasing the memory

[PATCH net-next 14/16] ipv6: add key length check into rt6_select()

2017-10-06 Thread Wei Wang
From: Wei Wang After rwlock is replaced with rcu and spinlock, fib6_lookup() could potentially return an intermediate node if other thread is doing fib6_del() on a route which is the only route on the node so that fib6_repair_tree() will be called on this node and potentially assigns fn->leaf to

[PATCH net-next 08/16] ipv6: hook up exception table to store dst cache

2017-10-06 Thread Wei Wang
From: Wei Wang This commit makes use of the exception hash table implementation to store dst caches created by pmtu discovery and ip redirect into the hash table under the rt_info and no longer inserts these routes into fib6 tree. This makes the fib6 tree only contain static configured routes and

[PATCH net-next 12/16] ipv6: update fn_sernum after route is inserted to tree

2017-10-06 Thread Wei Wang
From: Wei Wang fib6_add() logic currently calls fib6_add_1() to figure out what node should be used for the newly added route and then call fib6_add_rt2node() to insert the route to the node. And during the call of fib6_add_1(), fn_sernum is updated for all nodes that share the same prefix as the

[PATCH net-next 07/16] ipv6: prepare fib6_locate() for exception table

2017-10-06 Thread Wei Wang
From: Wei Wang fib6_locate() is used to find the fib6_node according to the passed in prefix address key. It currently tries to find the fib6_node with the exact match of the passed in key. However, when we move cached routes into the exception table, fib6_locate() will fail to find the fib6_node

[PATCH net-next 00/16] ipv6: replace rwlock with rcu and spinlock in fib6 table

2017-10-06 Thread Wei Wang
From: Wei Wang Currently, fib6 table is protected by rwlock. During route lookup, reader lock is taken and during route insertion, deletion or modification, writer lock is taken. This is a very inefficient implementation because the fastpath always has to do the operation to grab the reader lock.

[PATCH net-next 04/16] ipv6: prepare rt6_mtu_change() for exception table

2017-10-06 Thread Wei Wang
From: Wei Wang If we move all cached dst into the exception table under the main route, current rt6_mtu_change() will no longer be able to access them. This commit makes rt6_mtu_change_route() function to also go through all cached routes in the exception table under the main route and do proper

[PATCH net-next 02/16] ipv6: introduce a hash table to store dst cache

2017-10-06 Thread Wei Wang
From: Wei Wang Add a hash table into struct rt6_info in order to store dst caches created by pmtu discovery and ip redirect in ipv6 routing code. APIs to add dst cache, delete dst cache, find dst cache and update dst cache in the hash table are implemented and will be used in later commits. This

Re: [PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-06 Thread Paul Bolle
On Thu, 2017-10-05 at 12:31 -0700, Kees Cook wrote: > --- a/drivers/isdn/gigaset/bas-gigaset.c > +++ b/drivers/isdn/gigaset/bas-gigaset.c > -static void cmd_in_timeout(unsigned long data) > +static void cmd_in_timeout(struct timer_list *t) > { > - struct cardstate *cs = (struct cardstate *) d

[PATCH net-next v5 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188 ++

[PATCH net-next v5 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

[PATCH net-next v5 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11 ++ net

[PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic differenc

Re: [patch net-next 1/2] mlxsw: spectrum: Add extack for VLAN enslavements

2017-10-06 Thread David Ahern
On 10/5/17 3:39 PM, Jiri Pirko wrote: > From: Ido Schimmel > > Similar to physical ports, enslavement of VLAN devices can also fail. > Use extack to indicate why the enslavement failed. > > $ ip link add link enp1s0np1 name enp1s0np1.10 type vlan id 10 > $ ip link add name bond0 type bond mode 8

Re: [patch net-next 2/2] mlxsw: spectrum: Propagate extack further for bridge enslavements

2017-10-06 Thread David Ahern
On 10/5/17 3:40 PM, Jiri Pirko wrote: > From: Ido Schimmel > > The code that actually takes care of bridge offload introduces a few > more non-trivial constraints with regards to bridge enslavements. > Propagate extack there to indicate the reason. > > $ ip link add link enp1s0np1 name enp1s0np1

Re: [PATCH net] bpf: fix liveness marking

2017-10-06 Thread Daniel Borkmann
On 10/06/2017 01:20 AM, Alexei Starovoitov wrote: while processing Rx = Ry instruction the verifier does regs[insn->dst_reg] = regs[insn->src_reg] which often clears write mark (when Ry doesn't have it) that was just set by check_reg_arg(Rx) prior to the assignment. That causes mark_reg_read() to

Re: [Intel-wired-lan] [PATCH] PCI: Check/Set ARI capability before setting numVFs

2017-10-06 Thread Bjorn Helgaas
On Thu, Oct 05, 2017 at 04:07:41PM -0500, Bjorn Helgaas wrote: > On Wed, Oct 04, 2017 at 04:29:14PM -0700, Alexander Duyck wrote: > > On Wed, Oct 4, 2017 at 4:01 PM, Bjorn Helgaas wrote: > > > On Wed, Oct 04, 2017 at 08:52:58AM -0700, Tony Nguyen wrote: > > >> This fixes a bug that can occur if an

Re: [PATCH net] net: enable interface alias removal via rtnl

2017-10-06 Thread David Ahern
On 10/5/17 4:19 AM, Nicolas Dichtel wrote: > IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of > the attribute is 1 ("\0"). However, to remove an alias, the attribute > length must be 0 (see dev_set_alias()). why not add a check in dev_set_alias that if len is 1 and the 1

Re: [PATCH net-next 1/1] [net] bonding: Add NUMA notice

2017-10-06 Thread Eric Dumazet
On Fri, 2017-10-06 at 13:54 -0400, Patrick Talbert wrote: > > My goal with the patch is not to prevent some one from bonding > whichever interfaces they want, only to notify them that what they are > doing is *likely* to be less than ideal from a performance > perspective. Even if some theoretica

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-10-06

2017-10-06 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Rami fixes a typo in the code comments. Mitch adds an ethtool private flag to control source pruning to resolve an issue where our default behavior is to enable source pruning which breaks ARP monitoring in channel bonding. Fixes a couple of

[net-next 08/15] i40e: fix merge error

2017-10-06 Thread Jeff Kirsher
From: Alice Michael This patch removes some code that was accidentally added to the wrong function with a merge error. Fixes: c53934c6d1b1 ("i40e: fix: do not sleep in netdev_ops") Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/int

[net-next 03/15] i40e/i40evf: spread CPU affinity hints across online CPUs only

2017-10-06 Thread Jeff Kirsher
From: Jacob Keller Currently, when setting up the IRQ for a q_vector, we set an affinity hint based on the v_idx of that q_vector. Meaning a loop iterates on v_idx, which is an incremental value, and the cpumask is created based on this value. This is a problem in systems with multiple logical C

[net-next 02/15] i40e: add private flag to control source pruning

2017-10-06 Thread Jeff Kirsher
From: Mitch Williams By default, our devices do source pruning, that is, they drop receive packets that have the source MAC matching one of the receive filters. Unfortunately, this breaks ARP monitoring in channel bonding, as the bonding driver expects devices to receive ARPs containing their own

[net-next 04/15] i40e: re-enable PTP L4 capabilities for XL710 if FW >6.0

2017-10-06 Thread Jeff Kirsher
From: Alan Brady Starting with XL710 FW 5.3 PTP L4 was disabled for XL710 due to a bug. The bug has since been resolved in XL710 FW >6.0 and PTP L4 can now be re-enabled on those devices with updated firmware. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 13/15] i40evf: enable support for VF VLAN tag stripping control

2017-10-06 Thread Jeff Kirsher
From: Jacob Keller A recent commit 809481484e5d ("i40e/i40evf: support for VF VLAN tag stripping control") added support for VFs to negotiate the control of VLAN tag stripping. This should have allowed VFs to disable the feature. Unfortunately, the flag was set only in netdev->feature flags and n

[net-next 15/15] i40e/i40evf: organize and re-number feature flags

2017-10-06 Thread Jeff Kirsher
From: Jacob Keller Now that we've reduced the number of flags, organize similar flags together and re-number them accordingly. Since we don't yet have more than 32 flags, we'll use a u32 for both the hw_features and flag field. Should we gain more flags in the future, we may need to convert to a

  1   2   3   >