[Patch net-next] tcp: add a tracepoint for tcp_retransmit_skb()

We need a real-time notification for tcp retransmission for monitoring. Of course we could use ftrace to dynamically instrument this kernel function too, however we can't retrieve the connection information at the same time, for example perf-tools [1] reads /proc/net/tcp for socket details, which

Re: [net-next 2/3] ip_gre: fix erspan tunnel mtu calculation

On Tue, Oct 10, 2017 at 4:47 AM, William Tu wrote: > Remove the unnecessary -4 and +4 bytes at mtu and headroom calculation. > In addition, erspan uses fixed 8-byte gre header, so add ERSPAN_GREHDR_LEN > macro for better readability. > > Now tunnel->hlen = grehdr(8) +

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 2:34 PM, Florian Fainelli wrote: > > > On 10/09/2017 09:49 PM, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or higher. >> >> Signed-off-by: Joel Stanley

Re: [PATCH] net: ftgmac100: Request clock and set speed

On 10/09/2017 09:49 PM, Joel Stanley wrote: > According to the ASPEED datasheet, gigabit speeds require a clock of > 100MHz or higher. Other speeds require 25MHz or higher. > > Signed-off-by: Joel Stanley > --- > @@ -161,6 +170,9 @@ static int

Re: [PATCH] net: dsa: mv88e6xxx: rework in-chip bridging

On 09/10/17 14:00, Florian Fainelli wrote: > Le 10/08/17 à 20:23, Greg Ungerer a écrit : >> On 07/10/17 13:04, Florian Fainelli wrote: >>> Le 10/03/17 à 23:20, Greg Ungerer a écrit : On Wed, Mar 29, 2017 at 04:30:16PM -0400, Vivien Didelot wrote: > All ports -- internal and external, for

[PATCH] net: ftgmac100: Request clock and set speed

According to the ASPEED datasheet, gigabit speeds require a clock of 100MHz or higher. Other speeds require 25MHz or higher. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

Re: [PATCH net-next] openvswitch: add ct_clear action

On Fri, Oct 6, 2017 at 9:44 AM, Eric Garver wrote: > This adds a ct_clear action for clearing conntrack state. ct_clear is > currently implemented in OVS userspace, but is not backed by an action > in the kernel datapath. This is useful for flows that may modify a > packet tuple

[PATCH iproute2] iplink: new option to set neigh suppression on a bridge port

From: Roopa Prabhu neigh suppression can be used to suppress arp and nd flood to bridge ports. It maps to the recently added kernel support for bridge port flag IFLA_BRPORT_NEIGH_SUPPRESS. Signed-off-by: Roopa Prabhu --- bridge/link.c

Re: [PATCH 1/3] net/atm: Delete an error message for a failed memory allocation in five functions

On Mon, 2017-10-09 at 22:49 +0200, SF Markus Elfring wrote: > Omit extra messages for a memory allocation failure in these functions. [] > diff --git a/net/atm/mpc.c b/net/atm/mpc.c > @@ -184,10 +184,8 @@ struct atm_mpoa_qos *atm_mpoa_add_qos(__be32 dst_ip, > struct atm_qos *qos) > } > >

Re: [PATCH net-next 0/2] net: defer cgroups init to accept()

From: Eric Dumazet Date: Sun, 8 Oct 2017 21:47:49 -0700 > On Sun, Oct 8, 2017 at 9:44 PM, Eric Dumazet wrote: >> After TCP 3WHS became lockless, we should not attempt cgroup games >> from sk_clone_lock() since listener/cgroup might be already gone. >>

Re: [PATCHv2] Add a driver for Renesas uPD60620 and uPD60620A PHYs

From: Bernd Edlinger Date: Sun, 8 Oct 2017 13:40:08 + > Signed-off-by: Bernd Edlinger Applied to net-next, thanks.

Re: [PATCH net-next] openvswitch: add ct_clear action

From: Eric Garver Date: Fri, 6 Oct 2017 12:44:26 -0400 > This adds a ct_clear action for clearing conntrack state. ct_clear is > currently implemented in OVS userspace, but is not backed by an action > in the kernel datapath. This is useful for flows that may modify a > packet

Re: [PATCH RFC 0/3] tun zerocopy stats

From: Willem de Bruijn Date: Fri, 6 Oct 2017 18:25:13 -0400 > From: Willem de Bruijn > > Add zerocopy transfer statistics to the vhost_net/tun zerocopy path. > > I've been using this to verify recent changes to zerocopy tuning [1]. >

Re: [PATCH net-next v2] vhost_net: do not stall on zerocopy depletion

From: Willem de Bruijn Date: Fri, 6 Oct 2017 13:22:31 -0400 > From: Willem de Bruijn > > Vhost-net has a hard limit on the number of zerocopy skbs in flight. > When reached, transmission stalls. Stalls cause latency, as well as >

Re: [PATCHv2 net-next] openvswitch: Add erspan tunnel support.

From: William Tu Date: Wed, 4 Oct 2017 17:03:12 -0700 > Add erspan netlink interface for OVS. > > Signed-off-by: William Tu > Cc: Pravin B Shelar > --- > v1->v2: remove unnecessary compat code. Applied, thanks.

Re: [PATCH net-next] once: switch to new jump label API

From: Eric Biggers Date: Mon, 9 Oct 2017 14:30:52 -0700 > From: Eric Biggers > > Switch the DO_ONCE() macro from the deprecated jump label API to the new > one. The new one is more readable, and for DO_ONCE() it also makes the > generated code more

Re: [PATCH net-next] ipv6: use rcu_dereference_bh() in ipv6_route_seq_next()

From: Wei Wang Date: Mon, 9 Oct 2017 17:17:26 -0700 > From: Wei Wang > > This patch replaces rcu_deference() with rcu_dereference_bh() in > ipv6_route_seq_next() to avoid the following warning: ... > Fixes: 66f5d6ce53e6 ("ipv6: replace rwlock with rcu

Re: [PATCH 1/1] xdp: Sample xdp program implementing ip forward

Sorry for the late reply. I will include the suggested changes in the next revision of the patch. Please see inline for clarifications and questions. Thanks, Christina From: Daniel Borkmann Sent: Tuesday, October 3, 2017 9:24 PM To:

Re: [PATCH net-next RFC 4/9] net: dsa: mv88e6xxx: add support for event capture

On Mon, Oct 09, 2017 at 04:08:50PM -0600, Levi Pearson wrote: > Another issue related to this is that while the free-running counter > in the hardware can't be easily adjusted, the periodic event generator > *can* be finely adjusted (via picosecond and sub-picosecond > accumulators) to correct for

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 04:23:57PM -0700, Alexei Starovoitov wrote: >On Mon, Oct 09, 2017 at 11:15:40PM +, Levin, Alexander (Sasha Levin) wrote: >> On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: >> >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin)

Re: [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2017-10-09

From: Jeff Kirsher Date: Mon, 9 Oct 2017 15:38:27 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH] timer: Remove meaningless .data/.function assignments

From: Kees Cook Date: Mon, 9 Oct 2017 17:10:32 -0700 > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc:

[PATCH RFC tip/core/rcu 03/15] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

The __qed_spq_block() function expects an smp_read_barrier_depends() to order a prior READ_ONCE() against a later load that does not depend on the prior READ_ONCE(), an expectation that can fail to be met. This commit therefore replaces the READ_ONCE() with smp_load_acquire() and removes the

[PATCH RFC tip/core/rcu 14/15] netfilter: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso

[PATCH net-next] ipv6: use rcu_dereference_bh() in ipv6_route_seq_next()

From: Wei Wang This patch replaces rcu_deference() with rcu_dereference_bh() in ipv6_route_seq_next() to avoid the following warning: [ 19.431685] WARNING: suspicious RCU usage [ 19.433451] 4.14.0-rc3-00914-g66f5d6c #118 Not tainted [ 19.435509]

[PATCH] timer: Remove meaningless .data/.function assignments

Several timer users needlessly reset their .function/.data fields during their timer callback, but nothing else changes them. Some users do not use their .data field at all. Each instance is removed here. Cc: Krzysztof Halasa Cc: Aditya Shankar Cc:

ATENCIÓN

ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: [net-next 00/10][pull request] 10GbE Intel Wired LAN Driver Updates 2017-10-09

From: Jeff Kirsher Date: Mon, 9 Oct 2017 11:39:50 -0700 > This series contains updates to ixgbe only. Pulled, thanks Jeff.

Re: [PATCH net-next v2 1/5] bpf: Add file mode configuration into bpf maps

On Mon, Oct 9, 2017 at 4:07 PM, Alexei Starovoitov wrote: > On Mon, Oct 09, 2017 at 03:20:24PM -0700, Chenbo Feng wrote: >> From: Chenbo Feng >> >> Introduce the map read/write flags to the eBPF syscalls that returns the >> map fd. The flags is

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 11:15:40PM +, Levin, Alexander (Sasha Levin) wrote: > On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: > >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin) > >wrote: > >> On Mon, Oct 09, 2017 at 10:15:42AM -0700, Alexei

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

On Mon, Oct 09, 2017 at 08:56:34PM +0100, Mark Brown wrote: > On Mon, Oct 09, 2017 at 10:43:01PM +0300, Mika Westerberg wrote: > > > If possible, I would rather move this chapter to be before "Networking > > over Thunderbolt cable". Reason is that it then follows NVM flashing > > chapter which is

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

From: Alexei Starovoitov Date: Mon, 9 Oct 2017 16:06:20 -0700 >> For these archs, wouldn't it then be more efficient to use BUG_ON >> rather than BUG()? > > why more efficient? any data to prove that? It can completely eliminate a branch. For example on powerpc

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin) wrote: >> On Mon, Oct 09, 2017 at 10:15:42AM -0700, Alexei Starovoitov wrote: >> >On Mon, Oct 09, 2017 at 11:37:59AM -0400, Tim Hansen wrote: >> >> Fix

[GIT] Networking

1) Fix object leak on IPSEC offload failure, from Steffen Klassert. 2) Fix range checks in ipset address range addition operations, from Jozsef Kadlecsik. 3) Fix pernet ops unregistration order in ipset, from Florian Westphal. 4) Add missing netlink attribute policy for nl80211 packet

Re: [PATCH net-next v2 1/5] bpf: Add file mode configuration into bpf maps

On Mon, Oct 09, 2017 at 03:20:24PM -0700, Chenbo Feng wrote: > From: Chenbo Feng > > Introduce the map read/write flags to the eBPF syscalls that returns the > map fd. The flags is used to set up the file mode when construct a new > file descriptor for bpf maps. To not break

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin) wrote: > On Mon, Oct 09, 2017 at 10:15:42AM -0700, Alexei Starovoitov wrote: > >On Mon, Oct 09, 2017 at 11:37:59AM -0400, Tim Hansen wrote: > >> Fix BUG() calls to use BUG_ON(conditional) macros. > >> > >> This was found

Re: linux-next: manual merge of the cgroup tree with the net-next tree

On Mon, Oct 09, 2017 at 07:38:36PM +0100, Mark Brown wrote: > Hi Tejun, > > Today's linux-next merge of the cgroup tree got a conflict in: > > kernel/cgroup/cgroup.c > > between commit: > > 324bda9e6c5ad ("bpf: multi program support for cgroup+bpf") > > from the net-next tree and commit:

Re: [PATCH] cdc_ether: flag the u-blox TOBY-L2 and SARA-U2 as wwan

From: Aleksander Morgado Date: Mon, 9 Oct 2017 14:05:12 +0200 > The u-blox TOBY-L2 is a LTE Cat 4 module with HSPA+ and 2G fallback. > This module allows switching to different USB profiles with the > 'AT+UUSBCONF' command, and provides a ECM network interface when the

[net-next 02/14] i40e: use the safe hash table iterator when deleting mac filters

From: Lihong Yang This patch replaces hash_for_each function with hash_for_each_safe when calling __i40e_del_filter. The hash_for_each_safe function is the right one to use when iterating over a hash table to safely remove a hash entry. Otherwise, incorrect values may be

[net-next 01/14] i40e: fix flags declaration

From: Jacob Keller Since we don't yet have more than 32 flags, we'll use a u32 for both the hw_features and flag field. Should we gain more flags in the future, we may need to convert to a u64 or separate flags out into two fields. This was overlooked in the previous

[net-next 05/14] i40e/i40evf: always set the CLEARPBA flag when re-enabling interrupts

From: Jacob Keller In the past we changed driver behavior to not clear the PBA when re-enabling interrupts. This change was motivated by the flawed belief that clearing the PBA would cause a lost interrupt if a receive interrupt occurred while interrupts were disabled.

[net-next 03/14] i40evf: fix mac filter removal timing issue

From: Alan Brady Due to the asynchronous nature in which mac filters are added and deleted, there exists a bug in which filters are erroneously removed if removed then added again quickly. The events are as such: - filter marked for removal - same filter is

[net-next 07/14] i40e/i40evf: bump tail only in multiples of 8

From: Jacob Keller Hardware only fetches descriptors on cachelines of 8, essentially ignoring the lower 3 bits of the tail register. Thus, it is pointless to bump tail by an unaligned access as the hardware will ignore some of the new descriptors we allocated. Thus,

[net-next 11/14] i40e: Retry AQC GetPhyAbilities to overcome I2CRead hangs

From: Jayaprakash Shanmugam - When the I2C is busy, the PHY reads are delayed. The firmware will return EGAIN in these cases with an expectation that the SW will trigger the reads again - This patch retries the operation for a maximum period of 500ms

[net-next 13/14] i40e: fix a typo

From: Rami Rosen This patch fixes a typo in i40e_vsi_alloc_arrays() documentation. The first parameter name should be "vsi" instead of "type". Signed-off-by: Rami Rosen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 04/14] i40e/i40evf: fix incorrect default ITR values on driver load

From: Jacob Keller The ITR register expects to be programmed in units of 2 microseconds. Because of this, all of the drivers I40E_ITR_* constants are in terms of this 2 microsecond register. Unfortunately, the rx_itr_default value is expected to be programmed in

[net-next 08/14] i40e/i40evf: bundle more descriptors when allocating buffers

From: Jacob Keller Double the number of descriptors we'll bundle into one tail bump when receiving. Empirical testing has shown that we reduce CPU utilization and don't appear to reduce throughput or packet rate. 32 seems to be the sweet spot, as it's half the default

[net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2017-10-09

This series contains updates to i40e and i40evf only. Jake fixes missed flag conversion from u64 to u32. Fixes a deafult ITR value issue where the driver defaults to an ITR value of half the expected value (in terms of minimum microseconds between interrupts). So fix this by changing the

[net-next 06/14] i40e: reduce lrxqthresh from 2 to 1

From: Jacob Keller The lrxq thresh value tells hardware to immediately interrupt when there are fewer than N*64 packets left in the ring. Counter intuitively, empirical testing has shown that decreasing this value from 2 to 1, and thus changing from an immediate

[net-next 14/14] i40e: Avoid some useless variables and initializers in NVM functions

From: Stefano Brivio Fixes: 09f79fd49d94 ("i40e: avoid NVM acquire deadlock during NVM update") Signed-off-by: Stefano Brivio Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 12/14] i40e: use a local variable instead of calculating multiple times

From: Lihong Yang The computed result of I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES is used more than three times in function i40e_config_irq_link_list. Simply declare a local variable to store it to improve readability. Signed-off-by: Lihong Yang

[net-next 09/14] i40e: allow XPS with QoS enabled

From: Jacob Keller Recently, the kernel gained support for enabling XPS and QoS at the same time. Thus, we no longer need to worry about the number of traffic classes when enabling XPS. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers

[net-next 10/14] i40e: add check for return from find_first_bit call

From: Lihong Yang The find_first_bit function will return the size passed to search if the first set bit is not found. This patch adds the check in case that happens as the return value would be used as the index in an array and that would have caused the out-of-bounds

[PATCH net-next v2 2/5] bpf: Add tests for eBPF file mode

From: Chenbo Feng Two related tests are added into bpf selftest to test read only map and write only map. The tests verified the read only and write only flags are working on hash maps. Signed-off-by: Chenbo Feng --- tools/testing/selftests/bpf/test_maps.c

[PATCH net-next v2 4/5] selinux: bpf: Add selinux check for eBPF syscall operations

From: Chenbo Feng Implement the actual checks introduced to eBPF related syscalls. This implementation use the security field inside bpf object to store a sid that identify the bpf object. And when processes try to access the object, selinux will check if processes have the

[PATCH net-next v2 3/5] security: bpf: Add LSM hooks for bpf object related syscall

From: Chenbo Feng Introduce several LSM hooks for the syscalls that will allow the userspace to access to eBPF object such as eBPF programs and eBPF maps. The security check is aimed to enforce a per object security protection for eBPF object so only processes with the right

[PATCH net-next v2 5/5] selinux: bpf: Add addtional check for bpf object file receive

From: Chenbo Feng Introduce a bpf object related check when sending and receiving files through unix domain socket as well as binder. It checks if the receiving process have privilege to read/write the bpf map or use the bpf program. This check is necessary because the bpf maps

[PATCH net-next v2 1/5] bpf: Add file mode configuration into bpf maps

From: Chenbo Feng Introduce the map read/write flags to the eBPF syscalls that returns the map fd. The flags is used to set up the file mode when construct a new file descriptor for bpf maps. To not break the backward capability, the f_flags is set to O_RDWR if the flag passed

[PATCH net-next v2 0/5] bpf: security: New file mode and LSM hooks for eBPF object permission control

From: Chenbo Feng Much like files and sockets, eBPF objects are accessed, controlled, and shared via a file descriptor (FD). Unlike files and sockets, the existing mechanism for eBPF object access control is very limited. Currently there are two options for granting accessing

Re: [PATCH net-next RFC 4/9] net: dsa: mv88e6xxx: add support for event capture

On Sun, Oct 8, 2017 at 9:06 AM, Richard Cochran wrote: >> +static int mv88e6xxx_ptp_enable_perout(struct mv88e6xxx_chip *chip, >> +struct ptp_clock_request *rq, int on) >> +{ >> + struct timespec ts; >> + u64 ns; >> + int

RE: [PATCH RFC v1 0/3] Support for tap user-space access with veth interfaces

Hello, Just a reminder for feedback. Please let me know your comments. > -Original Message- > From: Grandhi, Sainath > Sent: Wednesday, September 06, 2017 5:34 PM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; Grandhi, Sainath > Subject: [PATCH

[PATCH net-next] once: switch to new jump label API

From: Eric Biggers Switch the DO_ONCE() macro from the deprecated jump label API to the new one. The new one is more readable, and for DO_ONCE() it also makes the generated code more icache-friendly: now the one-time initialization code is placed out-of-line at the jump

Re: [PATCH] once: switch to new jump label API

From: Daniel Borkmann Date: Mon, 09 Oct 2017 23:14:42 +0200 > Given original code was accepted against net-next tree as major > users of the api are networking related anyway, it should be fine > here as well to route through this tree. Maybe resend the patch with > a

Re: [PATCH net] net: enable interface alias removal via rtnl

On 10/9/17 9:25 AM, Nicolas Dichtel wrote: > Le 09/10/2017 à 16:02, David Ahern a écrit : >> On 10/9/17 2:23 AM, Nicolas Dichtel wrote: >>> Le 06/10/2017 à 22:10, Oliver Hartkopp a écrit : On 10/06/2017 08:18 PM, David Ahern wrote: > On 10/5/17 4:19 AM, Nicolas Dichtel wrote:

Re: [PATCH] once: switch to new jump label API

On 10/09/2017 10:27 PM, Eric Biggers wrote: On Fri, Sep 15, 2017 at 09:07:51PM -0700, Eric Biggers wrote: On Tue, Aug 22, 2017 at 02:44:41PM -0400, Hannes Frederic Sowa wrote: Eric Biggers writes: From: Eric Biggers Switch the DO_ONCE() macro from

Re: [PATCH v6 05/11] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

On Sun, Oct 08, 2017 at 06:33:40PM +, Corentin Labbe wrote: > On Thu, Sep 28, 2017 at 09:37:08AM +0200, Corentin Labbe wrote: > > On Wed, Sep 27, 2017 at 04:02:10PM +0200, Andrew Lunn wrote: > > > Hi Corentin > > > > > > > +Required properties for the mdio-mux node: > > > > + - compatible =

Re: [net-next V5 PATCH 1/5] bpf: introduce new bpf cpu map type BPF_MAP_TYPE_CPUMAP

On 10/09/2017 07:59 PM, Jesper Dangaard Brouer wrote: [...] +static void *cpu_map_lookup_elem(struct bpf_map *map, void *key) +{ + struct bpf_cpu_map_entry *rcpu = + __cpu_map_lookup_elem(map, *(u32 *)key); + + return rcpu ? >qsize : NULL; I still think from my prior

[PATCH 3/3] net/atm: Adjust 121 checks for null pointers

From: Markus Elfring Date: Mon, 9 Oct 2017 22:22:45 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 2/3] net/atm: Improve a size determination in 12 functions

From: Markus Elfring Date: Mon, 9 Oct 2017 22:00:19 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/3] net/atm: Delete an error message for a failed memory allocation in five functions

From: Markus Elfring Date: Mon, 9 Oct 2017 21:34:35 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/3] net-ATM: Adjustments for several function implementations

From: Markus Elfring Date: Mon, 9 Oct 2017 22:30:33 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in five functions Improve a size

[net-next 3/3] ip_gre: cache the device mtu hard_header_len calc

The patch introduces ip_tunnel->ether_mtu fields to cache the value of dev->mtu + dev->hard_header_len. This avoids the arithmetic operation on every packet. Signed-off-by: William Tu Cc: David Laight --- include/net/ip_tunnels.h | 1 +

[net-next 2/3] ip_gre: fix erspan tunnel mtu calculation

Remove the unnecessary -4 and +4 bytes at mtu and headroom calculation. In addition, erspan uses fixed 8-byte gre header, so add ERSPAN_GREHDR_LEN macro for better readability. Now tunnel->hlen = grehdr(8) + erspanhdr(8) = 16 byte. The mtu should be ETH_DATA_LEN - 16 - iph(20) = 1464. After the

[net-next 1/3] ip_gre: fix mtu and headroom size

The ip_gre_calc_hlen() already counts gre's base header len (4-byte) plus optional header's len, so tunnel->hlen has the entire gre headeri + options len. Thus, remove the -4 and +4 when calculating the needed_headroom and mtu. Fixes: 4565e9919cda ("gre: Setup and TX path for gre/UDP foo-over-udp

[net-next 0/3] ip_gre: a bunch of fixes for mtu

The first two patches are to fix some issues for mtu and needed_headroom length calculation from the gre and erspan tunnel header. The last path tries to avoid arithmetic operation for every packet when checking for erspan truncate. William Tu (3): ip_gre: fix mtu and headroom size ip_gre:

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 10:15:42AM -0700, Alexei Starovoitov wrote: >On Mon, Oct 09, 2017 at 11:37:59AM -0400, Tim Hansen wrote: >> Fix BUG() calls to use BUG_ON(conditional) macros. >> >> This was found using make coccicheck M=net/core on linux next >> tag next-2017092 >> >> Signed-off-by: Tim

Re: [PATCH] once: switch to new jump label API

On Fri, Sep 15, 2017 at 09:07:51PM -0700, Eric Biggers wrote: > On Tue, Aug 22, 2017 at 02:44:41PM -0400, Hannes Frederic Sowa wrote: > > Eric Biggers writes: > > > > > From: Eric Biggers > > > > > > Switch the DO_ONCE() macro from the deprecated jump

Re: [PATCHv4 iproute2 2/2] lib/libnetlink: update rtnl_talk to support malloc buff at run time

Hi Stephen, On Mon, Oct 02, 2017 at 10:37:08AM -0700, Stephen Hemminger wrote: > On Thu, 28 Sep 2017 21:33:46 +0800 > Hangbin Liu wrote: > > > From: Hangbin Liu > > > > This is an update for 460c03f3f3cc ("iplink: double the buffer size also in > >

RE: [net-next 14/15] i40e: ignore skb->xmit_more when deciding to set RS bit

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Alexander Duyck > Sent: Monday, October 09, 2017 9:28 AM > To: David Laight > Cc: Kirsher, Jeffrey T ; da...@davemloft.net;

Re: [PATCH v1 RFC 6/7] Add MIB counter reading support

On 10/06/2017 01:33 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Add MIB counter reading support. > Rename ksz_9477_reg.h to ksz9477_reg.h for consistency as the product > name is always KSZ. > Header file ksz_priv.h no longer contains any chip

Re: [PATCH v1 RFC 5/7] Break KSZ9477 DSA driver into two files

On 10/06/2017 01:33 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Break KSZ9477 DSA driver into two files in preparation to add more KSZ > switch drivers. > Add common functions in ksz_common.h so that other KSZ switch drivers > can access code in

Re: [PATCH v1 RFC 0/7] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers

On 10/06/2017 01:32 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > This series of patches is to modify the original KSZ9477 DSA driver so > that other KSZ switch drivers can be added and use the common code. > > There are several steps to accomplish this

RE: [PATCH v1 RFC 1/7] Replace license with GPL

> Subject: [PATCH v1 RFC 1/7] Replace license with GPL > > From: Tristram Ha > > Replace license with GPL. > > Signed-off-by: Tristram Ha Reviewed-by: Woojung Huh

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

On Mon, Oct 09, 2017 at 10:43:01PM +0300, Mika Westerberg wrote: > If possible, I would rather move this chapter to be before "Networking > over Thunderbolt cable". Reason is that it then follows NVM flashing > chapter which is typically where you need to force power in the first > place. I

Re: [PATCH v1 RFC 4/7] Rename ksz_spi.c to ksz9477_spi.c

On 10/06/2017 01:33 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Rename ksz_spi.c to ksz9477_spi.c and update Kconfig in preparation to add > more KSZ switch drivers. > > Signed-off-by: Tristram Ha Reviewed-by: Florian

Re: [PATCH v1 RFC 3/7] Rename some functions with ksz9477 prefix

On 10/06/2017 01:33 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Rename some functions with ksz9477 prefix to separate chip specific code > from common code. > > Signed-off-by: Tristram Ha Reviewed-by: Florian Fainelli

Re: [PATCH v1 RFC 1/7] Replace license with GPL

On Fri 2017-10-06 13:32:59, tristram...@microchip.com wrote: > From: Tristram Ha > > Replace license with GPL. > > Signed-off-by: Tristram Ha Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek

Re: [PATCH v1 RFC 2/7] Clean up code according to patch check suggestions

On Fri 2017-10-06 13:33:00, tristram...@microchip.com wrote: > From: Tristram Ha > > Clean up code according to patch check suggestions. > > Signed-off-by: Tristram Ha Reviewed-by: Pavel Machek -- (english)

Re: [PATCH v1 RFC 3/7] Rename some functions with ksz9477 prefix

On Fri 2017-10-06 13:33:01, tristram...@microchip.com wrote: > From: Tristram Ha > > Rename some functions with ksz9477 prefix to separate chip specific code > from common code. > > Signed-off-by: Tristram Ha Reviewed-by: Pavel Machek

Re: [PATCH v1 RFC 4/7] Rename ksz_spi.c to ksz9477_spi.c

On Fri 2017-10-06 13:33:02, tristram...@microchip.com wrote: > From: Tristram Ha > > Rename ksz_spi.c to ksz9477_spi.c and update Kconfig in preparation to add > more KSZ switch drivers. > > Signed-off-by: Tristram Ha This will ask people

Re: [PATCH v1 RFC 2/7] Clean up code according to patch check suggestions

On 10/06/2017 01:33 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Clean up code according to patch check suggestions. > > Signed-off-by: Tristram Ha Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v1 RFC 6/7] Add MIB counter reading support

Hi! > From: Tristram Ha > > Add MIB counter reading support. > Rename ksz_9477_reg.h to ksz9477_reg.h for consistency as the product > name is always KSZ. > Header file ksz_priv.h no longer contains any chip specific data. Nothing obviously wrong here, but if you

Re: [PATCH v1 RFC 5/7] Break KSZ9477 DSA driver into two files

On Fri 2017-10-06 13:33:03, tristram...@microchip.com wrote: > From: Tristram Ha > > Break KSZ9477 DSA driver into two files in preparation to add more KSZ > switch drivers. > Add common functions in ksz_common.h so that other KSZ switch drivers > can access code in

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

On Mon, Oct 09, 2017 at 06:56:33PM +0100, Mark Brown wrote: > +Networking over Thunderbolt cable > +- > +Thunderbolt technology allows software communication across two hosts > +connected by a Thunderbolt cable. > + > +It is possible to tunnel any kind of

[PATCH] wimax/i2400m: Remove VLAIS

From: Behan Webster Convert Variable Length Array in Struct (VLAIS) to valid C by converting local struct definition to use a flexible array. The structure is only used to define a cast of a buffer so the size of the struct is not used to allocate storage.

Re: [PATCH v1 RFC 1/7] Replace license with GPL

On 10/09/2017 11:40 AM, tristram...@microchip.com wrote: >> From: tristram...@microchip.com >>> Sent: 06 October 2017 21:33 >>> Replace license with GPL. >> >> Don't you need permission from all the people who have updated >> the files in order to make this change? >> >> David > > I am a

Re: [PATCH v4 1/2] net: phy: DP83822 initial driver submission

On 10/09/2017 11:59 AM, Dan Murphy wrote: > Add support for the TI DP83822 10/100Mbit ethernet phy. > > The DP83822 provides flexibility to connect to a MAC through a > standard MII, RMII or RGMII interface. > > In addition the DP83822 needs to be removed from the DP83848 driver > as the WoL

Re: [PATCH net-next 1/1] [net] bonding: Add NUMA notice

On Sat, Oct 7, 2017 at 6:20 PM, David Miller wrote: > From: Patrick Talbert > Date: Thu, 5 Oct 2017 16:23:45 -0400 > >> Network performance can suffer when a load balancing bond uses slave >> interfaces which are in different NUMA domains. >> >> This

RE: [PATCH v1 RFC 1/7] Replace license with GPL

> From: tristram...@microchip.com > > Sent: 06 October 2017 21:33 > > Replace license with GPL. > > Don't you need permission from all the people who have updated > the files in order to make this change? > > David I am a little confused by your comment. The 4 original KSZ9477 DSA driver

[net-next 02/10] ixgbe: declare ixgbe_mac_operations structures as const

From: Bhumika Goyal Declare ixgbe_mac_operations structures as const as they are only stored in the mac_ops field of ixgbe_info structure. This field is of type const and therefore ixgbe_mac_operations structure can be made const too. Signed-off-by: Bhumika Goyal

  1   2   3   >