[RFC] Support for UNARP (RFC 1868)

Add support for UNARP, as detailed in the IETF RFC 1868 (ARP Extension - UNARP). The central idea here is for a node to announce that it is leaving the network and that all the nodes on the L2 broadcast domain to update their ARP tables accordingly (i.e., mark the neighbor entry state to FAILED).

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

Jes Sorensen writes: > On 10/11/2017 04:41 AM, Kalle Valo wrote: >> Jes Sorensen writes: >> >>> On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are

[PATCH net-next] tcp: remove obsolete helpers

From: Eric Dumazet Remove three inline helpers that are no longer needed. Signed-off-by: Eric Dumazet --- include/net/tcp.h | 17 - 1 file changed, 17 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index

[PATCH v2] net: ftgmac100: Request clock and set speed

According to the ASPEED datasheet, gigabit speeds require a clock of 100MHz or higher. Other speeds require 25MHz or higher. This patch configures a 100MHz clock if the system has a direct-attached PHY, or 25MHz if the system is running NC-SI which is limited to 100MHz. There appear to be no

Re: [PATCH][bpf-next] bpf: remove redundant variable old_flags

From: Colin King Date: Wed, 11 Oct 2017 11:56:23 +0100 > From: Colin Ian King > > Variable old_flags is being assigned but is never read; it is redundant > and can be removed. > > Cleans up clang warning: Value stored to 'old_flags' is never

Re: [PATCH net-next 0/3] mlx4_en XDP TX improvements

From: Tariq Toukan Date: Wed, 11 Oct 2017 13:17:24 +0300 > This patchset contains performance improvements > to the XDP_TX use case in the mlx4 Eth driver. > > Patch 1 is a simple change in a function parameter type. > Patch 2 replaces a call to a generic function with the

Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static

From: Colin King Date: Wed, 11 Oct 2017 10:53:28 +0100 > From: Colin Ian King > > The function ipgre_mpls_encap_hlen is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol

Re: [PATCH][next] sctp: make array sctp_sched_ops static

From: Colin King Date: Wed, 11 Oct 2017 11:17:57 +0100 > From: Colin Ian King > > The array sctp_sched_ops is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol

Re: [PATCH net-next 2/2] ipv6: addrconf: don't use rtnl mutex in RTM_GETADDR

From: Florian Westphal Date: Wed, 11 Oct 2017 10:28:01 +0200 > Similar to the previous patch, use the device lookup functions > that bump device refcount and flag this as DOIT_UNLOCKED to avoid > rtnl mutex. > > Signed-off-by: Florian Westphal Applied.

Re: [PATCH net-next 1/2] ipv6: addrconf: don't use rtnl mutex in RTM_GETNETCONF

From: Florian Westphal Date: Wed, 11 Oct 2017 10:28:00 +0200 > Instead of relying on rtnl mutex bump device reference count. > After this change, values reported can change in parallel, but thats not > much different from current state, as anyone can change the settings > right

Re: [patch net-next v2 0/4] net: sched: get rid of cls_flower->egress_dev

From: Jiri Pirko Date: Wed, 11 Oct 2017 09:41:06 +0200 > From: Jiri Pirko > > Introduction of cls_flower->egress_dev was a workaround. Turned out > to be a bit ugly hack. So replace it with more generic and reusable > infrastructure. > > This is a

Re: [PATCH net] net/ncsi: Don't limit vids based on hot_channel

From: Samuel Mendoza-Jonas Date: Wed, 11 Oct 2017 16:54:27 +1100 > Currently we drop any new VLAN ids if there are more than the current > (or last used) channel can support. Most importantly this is a problem > if no channel has been selected yet, resulting in a segfault.

Re: [PATCH net-next v2 0/7] net: qualcomm: rmnet: Rewrite some existing functionality

From: Subash Abhinov Kasiviswanathan Date: Wed, 11 Oct 2017 18:43:51 -0600 > This series fixes some of the broken rmnet functionality. > Bridge mode is re-written and made useable and the muxed_ep is converted to > hlist. > > Patches 1-5 are cleanups in preparation for

[PATCH] ip: update policy routing config help

The kernel config help for policy routing was still pointing at an ancient document from 2000 that refers to Linux 2.1. Update it to point to something that is at least occasionally updated. Signed-off-by: Stephen Hemminger --- net/ipv4/Kconfig | 8 +++- 1 file

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 4:14 PM, Benjamin Herrenschmidt wrote: > On Tue, 2017-10-10 at 15:19 +1030, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or higher. > > Did you try

Re: [PATCH net-next 1/1] bridge: return error code when deleting Vlan

On 10/11/17 3:29 PM, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > net/bridge/br_netlink.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c > index f0e8268..a1e1ca8 100644 > ---

[PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

This patchset adds a new hardware offload type in mqprio before adding mqprio hardware offload support in hns3 driver. Yunsheng Lin (2): mqprio: Add a new hardware offload type in mqprio net: hns3: Add mqprio hardware offload support in hns3 driver

[PATCH net-next 1/2] mqprio: Add a new hardware offload type in mqprio

When a driver supports both dcb and hardware offloaded mqprio, and user is running mqprio and dcb tool concurrently, the configuration set by each tool may be conflicted with each other because the dcb and mqprio may be using the same hardwere offload component and share the tc system in the

[PATCH net-next 2/2] net: hns3: Add mqprio hardware offload support in hns3 driver

When using tc qdisc, dcb_ops->setup_tc is used to tell hclge_dcb module to do the tm related setup. Only TC_MQPRIO_HW_OFFLOAD_DCB offload type is supported. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 +

[PATCH net-next v4 3/5] security: bpf: Add LSM hooks for bpf object related syscall

From: Chenbo Feng Introduce several LSM hooks for the syscalls that will allow the userspace to access to eBPF object such as eBPF programs and eBPF maps. The security check is aimed to enforce a per object security protection for eBPF object so only processes with the right

[PATCH net-next v4 0/5] bpf: security: New file mode and LSM hooks for eBPF object permission control

From: Chenbo Feng Much like files and sockets, eBPF objects are accessed, controlled, and shared via a file descriptor (FD). Unlike files and sockets, the existing mechanism for eBPF object access control is very limited. Currently there are two options for granting accessing

[PATCH net-next v4 2/5] bpf: Add tests for eBPF file mode

From: Chenbo Feng Two related tests are added into bpf selftest to test read only map and write only map. The tests verified the read only and write only flags are working on hash maps. Signed-off-by: Chenbo Feng --- tools/testing/selftests/bpf/test_maps.c

[PATCH net-next v4 1/5] bpf: Add file mode configuration into bpf maps

From: Chenbo Feng Introduce the map read/write flags to the eBPF syscalls that returns the map fd. The flags is used to set up the file mode when construct a new file descriptor for bpf maps. To not break the backward capability, the f_flags is set to O_RDWR if the flag passed

[PATCH net-next v4 4/5] selinux: bpf: Add selinux check for eBPF syscall operations

From: Chenbo Feng Implement the actual checks introduced to eBPF related syscalls. This implementation use the security field inside bpf object to store a sid that identify the bpf object. And when processes try to access the object, selinux will check if processes have the

[PATCH net-next v4 5/5] selinux: bpf: Add addtional check for bpf object file receive

From: Chenbo Feng Introduce a bpf object related check when sending and receiving files through unix domain socket as well as binder. It checks if the receiving process have privilege to read/write the bpf map or use the bpf program. This check is necessary because the bpf maps

Re: [next-queue PATCH v6 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

On Wed, 2017-10-11 at 17:54 -0700, Vinicius Costa Gomes wrote: > This queueing discipline implements the shaper algorithm defined by > the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. ... > +static s64 delay_from_credits(s64 credits, s32 slope) > +{ > + s64 rate = slope *

[RFC] iproute2: reject zero length strings for matches

The ip commands use the function matches() to allow for abbreviations like: $ ip l $ ip r But the function does not check for zero length strings which is potentially error prone (but might also break some power users assumptions). For example: $ ip "" 1: lo: mtu

[next-queue PATCH v6 2/5] mqprio: Implement select_queue class_ops

From: Jesus Sanchez-Palencia When replacing a child qdisc from mqprio, tc_modify_qdisc() must fetch the netdev_queue pointer that the current child qdisc is associated with before creating the new qdisc. Currently, when using mqprio as root qdisc, the kernel

[next-queue PATCH v6 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

This queueing discipline implements the shaper algorithm defined by the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L. It's primary usage is to apply some bandwidth reservation to user defined traffic classes, which are mapped to different queues via the mqprio qdisc. Only a simple

[next-queue PATCH v6 1/5] net/sched: Check for null dev_queue on create flow

From: Jesus Sanchez-Palencia In qdisc_alloc() the dev_queue pointer was used without any checks being performed. If qdisc_create() gets a null dev_queue pointer, it just passes it along to qdisc_alloc(), leading to a crash. That happens if a root qdisc

[next-queue PATCH v6 5/5] igb: Add support for CBS offload

From: Andre Guedes This patch adds support for Credit-Based Shaper (CBS) qdisc offload from Traffic Control system. This support enable us to leverage the Forwarding and Queuing for Time-Sensitive Streams (FQTSS) features from Intel i210 Ethernet Controller. FQTSS is the

[next-queue PATCH v6 4/5] net/sched: Add support for HW offloading for CBS

This adds support for offloading the CBS algorithm to the controller, if supported. Drivers wanting to support CBS offload must implement the .ndo_setup_tc callback and handle the TC_SETUP_CBS (introduced here) type. Signed-off-by: Vinicius Costa Gomes ---

[next-queue PATCH v6 0/5] TSN: Add qdisc based config interface for CBS

Hi, Changes since v5: - Fixed comments from Jiri Pirko; Changes since v4: - Added a software implementation of the CBS algorithm; Changes since v3: - None, only a clean patchset without old patches; Changes since v2: - squashed the patch introducing the userspace API into the patch

[PATCH net-next v2 7/7] net: qualcomm: rmnet: Implement bridge mode

Add support to bridge two devices which can send multiplexing and aggregation (MAP) data. This is done only when the data itself is not going to be consumed in the stack but is being passed on to a different endpoint. This is mainly used for testing. Signed-off-by: Subash Abhinov Kasiviswanathan

[PATCH net-next v2 1/7] net: qualcomm: rmnet: Remove existing logic for bridge mode

This will be rewritten in the following patches. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 1 - .../net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 77 +++--- 2 files changed, 9

[PATCH net-next v2 5/7] net: qualcomm: rmnet: Remove duplicate setting of rmnet_devices

The rmnet_devices information is already stored in muxed_ep, so storing this in rmnet_devices[] again is redundant. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 1 -

[PATCH net-next v2 2/7] net: qualcomm: rmnet: Remove some unused defines

Most of these constants were used in the initial patchset where custom netlink configuration was used and hence are no longer relevant. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_private.h | 8 1 file changed, 8

[PATCH net-next v2 6/7] net: qualcomm: rmnet: Convert the muxed endpoint to hlist

Rather than using a static array, use a hlist to store the muxed endpoints and use the mux id to query the rmnet_device. This is useful as usually very few mux ids are used. Signed-off-by: Subash Abhinov Kasiviswanathan Cc: Dan Williams ---

[PATCH net-next v2 4/7] net: qualcomm: rmnet: Remove duplicate setting of rmnet private info

The end point is set twice in the local_ep as well as the mux_id and the real_dev in the rmnet private structure. Remove the local_ep. While these elements are equivalent, rmnet_endpoint will be used only as part of the rmnet_port for muxed scenarios in VND mode. Signed-off-by: Subash Abhinov

[PATCH net-next v2 3/7] net: qualcomm: rmnet: Move rmnet_mode to rmnet_port

Mode information on the real device makes it easier to route packets to rmnet device or bridged device based on the configuration. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 12 +---

[PATCH net-next v2 0/7] net: qualcomm: rmnet: Rewrite some existing functionality

This series fixes some of the broken rmnet functionality. Bridge mode is re-written and made useable and the muxed_ep is converted to hlist. Patches 1-5 are cleanups in preparation for these changes. Patch 6 does the hlist conversion. Patch 7 has the implementation of the rmnet bridge mode.

Re: [PATCH net-next 2/4] security: bpf: Add LSM hooks for bpf object related syscall

On Wed, 4 Oct 2017, Chenbo Feng wrote: > int bpf_map_new_fd(struct bpf_map *map, int flags) > { > + if (security_bpf_map(map, OPEN_FMODE(flags))) > + return -EPERM; > + Don't hardcode -EPERM here, return the actual error from security_bpf_map(). > + if

Re: BUG:af_packet fails to TX TSO frames

On Wed, Oct 11, 2017 at 6:01 PM, Anton Ivanov wrote: > [snip] > >> This will be tomorrow though, it is late here. >> >> The only obvious difference I can see at this point is that I am using >> iovs and sending the vnet header as iov[0] and the data in pieces

[PATCH next] ipvlan: always use the current L2 addr of the master

From: Mahesh Bandewar If the underlying master ever changes its L2 (e.g. bonding device), then make sure that the IPvlan slaves always emit packets with the current L2 of the master instead of the stale mac addr which was copied during the device creation. The problem can be

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 5/6] i40e: Clean up of cloud filters

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: Introduce the cloud filter datastructure and cleanup of cloud filters associated with the device. v2: Moved field comments in struct i40e_cloud_filter to the right. Removed hlist_empty check from i40e_cloud_filter_exit() Signed-off-by: Amritha

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 4/6] i40e: Admin queue definitions for cloud filters

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: Add new admin queue definitions and extended fields for cloud filter support. Define big buffer for extended general fields in Add/Remove Cloud filters command. v3: Shortened some lengthy struct names. v2: Added I40E_CHECK_STRUCT_LEN check to AQ

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: This patch enables tc-flower based hardware offloads. tc flower filter provided by the kernel is configured as driver specific cloud filter. The patch implements functions and admin queue commands needed to support cloud filters in the driver and

Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 3/6] i40e: Cloud filter mode for set_switch_config command

On 10/10/2017 5:24 PM, Amritha Nambiar wrote: Add definitions for L4 filters and switch modes based on cloud filters modes and extend the set switch config command to include the additional cloud filter mode. Signed-off-by: Amritha Nambiar Signed-off-by: Kiran Patil

Re: [PATCH net-next 0/7] Rewrite some existing functionality

On 2017-10-11 16:25, David Miller wrote: From: David Miller Date: Wed, 11 Oct 2017 15:22:59 -0700 (PDT) From: Subash Abhinov Kasiviswanathan Date: Tue, 10 Oct 2017 22:17:29 -0600 This series fixes some of the broken rmnet functionality. Bridge

Re: [PATCH 0/4] net: qcom/emac: various minor fixes

From: Timur Tabi Date: Wed, 11 Oct 2017 14:52:22 -0500 > A set of patches for 4.15 that clean up some code, apply minors fixes, > and so on. Some of the code also prepares the driver for a future > version of the EMAC controller. Series applied, thank you.

Re: [PATCH] i40e/i40evf: actually use u32 for feature flags

On Wed, 2017-10-11 at 16:02 +0200, Arnd Bergmann wrote: > A previous cleanup intended to change the flags variable to 32 > bit instead of 64, but accidentally left out the important > part of that change, leading to a build error: > > drivers/net/ethernet/intel/i40e/i40e_ethtool.o: In function >

Re: [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e

On 10/11/2017 5:42 AM, Jamal Hadi Salim wrote: > On 17-10-10 08:24 PM, Amritha Nambiar wrote: >> This patch series enables configuring cloud filters in i40e >> using the tc-flower classifier. The classification function >> of the filter is to match a packet to a class. cls_flower is >> extended to

Re: [PATCH v2 0/7] net: qrtr: Fixes and support receiving version 2 packets

From: Bjorn Andersson Date: Tue, 10 Oct 2017 23:45:16 -0700 > On the latest Qualcomm platforms remote processors are sending packets with > version 2 of the message header. This series starts off with some fixes and > then refactors the qrtr code to support receiving

Re: [PATCH] r8169: only enable PCI wakeups when WOL is active

From: Daniel Drake Date: Wed, 11 Oct 2017 12:56:52 +0800 > rtl_init_one() currently enables PCI wakeups if the ethernet device > is found to be WOL-capable. There is no need to do this when > rtl8169_set_wol() will correctly enable or disable the same wakeup flag > when WOL

Re: [PATCH net-next 0/7] Rewrite some existing functionality

From: David Miller Date: Wed, 11 Oct 2017 15:22:59 -0700 (PDT) > From: Subash Abhinov Kasiviswanathan > Date: Tue, 10 Oct 2017 22:17:29 -0600 > >> This series fixes some of the broken rmnet functionality. >> Bridge mode is re-written and made

Re: [PATCH net-next 0/7] Rewrite some existing functionality

From: Subash Abhinov Kasiviswanathan Date: Tue, 10 Oct 2017 22:17:29 -0600 > This series fixes some of the broken rmnet functionality. > Bridge mode is re-written and made useable and the muxed_ep is converted to > hlist. > > Patches 1-5 are cleanups in preparation for

Re: [PATCH net-next] net: hns3: make local functions static

From: Wei Yongjun Date: Wed, 11 Oct 2017 02:35:23 + > Fixes the following sparse warnings: > > drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c:464:5: warning: > symbol 'hns3_change_all_ring_bd_num' was not declared. Should it be static? >

RE: [PATCH] i40e/i40evf: actually use u32 for feature flags

> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, October 11, 2017 7:03 AM > To: Kirsher, Jeffrey T > Cc: Arnd Bergmann ; Keller, Jacob E > ; Duyck, Alexander H >

Re: [PATCH][bpf-next] bpf: remove redundant variable old_flags

On 10/11/2017 12:56 PM, Colin King wrote: From: Colin Ian King Variable old_flags is being assigned but is never read; it is redundant and can be removed. Cleans up clang warning: Value stored to 'old_flags' is never read Signed-off-by: Colin Ian King

RE: [PATCH] fm10k: mark PM functions as __maybe_unused

> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, October 11, 2017 6:58 AM > To: Kirsher, Jeffrey T > Cc: Arnd Bergmann ; Keller, Jacob E > ; Kwan, Ngai-mint

Re: [PATCH] hdlc: Convert timers to use timer_setup()

From: Kees Cook Date: Tue, 10 Oct 2017 15:08:33 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. This adds a pointer

Re: [PATCH net-next 1/1] veth: tweak creation of veth device

From: Roman Mashak Date: Tue, 10 Oct 2017 16:08:44 -0400 > When creating veth pair, at first rtnl_new_link() creates veth_dev, i.e. > one end of the veth pipe, but not registers it; then veth_newlink() gets > invoked, where peer dev is created _and_ registered, followed by

Re: BUG:af_packet fails to TX TSO frames

[snip] > This will be tomorrow though, it is late here. > > The only obvious difference I can see at this point is that I am using > iovs and sending the vnet header as iov[0] and the data in pieces after > that while your code is doing a send() for the whole frame. This should > not make any

Re: [RFC net-next 1/4] net: ipv6: Make inet6addr_validator a blocking notifier

On 10/11/17 3:13 PM, David Miller wrote: > From: David Ahern > Date: Tue, 10 Oct 2017 09:41:02 -0700 > >> +/* validator notifier needs to be blocking; >> + * do not call in softirq context >> + */ >> +if (!in_softirq()) { > > I think we can test this better.

Re: BUG:af_packet fails to TX TSO frames

[snip] > The test can be run both with and without ring: > > psock_txring_vnet -l 8000 -s $src_ip -d $dst_ip -v > psock_txring_vnet -l 8000 -s $src_ip -d $dst_ip -v -N > > both with and without qdisc bypass ('-q'). Thanks, apologies, I was being inpatient. Started reading the source, saw the

Re: [PATCH RFC 0/3] tun zerocopy stats

On Tue, Oct 10, 2017 at 11:15 PM, Jason Wang wrote: > > > On 2017年10月11日 03:11, Willem de Bruijn wrote: >> >> On Tue, Oct 10, 2017 at 1:39 PM, David Miller wrote: >>> >>> From: Willem de Bruijn >>> Date: Tue, 10 Oct 2017

Re: [next-queue PATCH v5 4/5] net/sched: Add support for HW offloading for CBS

Jiri Pirko writes: [...] >>+static void disable_cbs_offload(struct net_device *dev, >>+ struct cbs_sched_data *q) >>+{ >>+ struct tc_cbs_qopt_offload cbs = { }; >>+ const struct net_device_ops *ops; >>+ int err; >>+ >>+ if

Re: [next-queue PATCH v5 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

Jiri Pirko writes: [...] >>+struct tc_cbs_qopt_offload { >>+ u8 enable; >>+ s32 queue; >>+ s32 hicredit; >>+ s32 locredit; >>+ s32 idleslope; >>+ s32 sendslope; > > Please introduce the qdisc in one patch, then offload it in second. That > is what I

[PATCH net-next 1/1] bridge: return error code when deleting Vlan

Signed-off-by: Roman Mashak --- net/bridge/br_netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index f0e8268..a1e1ca8 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@

Re: [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e

Wed, Oct 11, 2017 at 11:19:29PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 11 Oct 2017 22:58:30 +0200 > >> Well if I see classid, I expect it should refer to qdisc instance. So >> far, this has been always a case. But for some drivers, this would mean >>

Re: [PATCH][next] sctp: make array sctp_sched_ops static

On Wed, Oct 11, 2017 at 03:44:50AM -0700, Joe Perches wrote: > On Wed, 2017-10-11 at 11:17 +0100, Colin King wrote: > > From: Colin Ian King > > > > The array sctp_sched_ops is local to the source and > > does not need to be in global scope, so make it static. > > > >

Re: [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e

From: Jiri Pirko Date: Wed, 11 Oct 2017 22:58:30 +0200 > Well if I see classid, I expect it should refer to qdisc instance. So > far, this has been always a case. But for some drivers, this would mean > something totally different and unrelated. So what should I think? > What's

Re: [PATCH RFC] Add other KSZ switch support so that patch check does not complain

On 10/06/2017 01:33 PM, tristram...@microchip.com wrote: > From: Tristram Ha > > Add other KSZ switch support so that patch check does not complain. You are not doing this just so checkpatch.pl stops complaining, what you are doing here is to properly document the

[PATCH net-next 0/4] tc-testing: Test suite updates

This patch series is a roundup of changes to the tc-testing suite: - Add test cases for police and mirred modules and some coverage in already-submitted test categories - Break the test case files down into more user-friendly sizes - Bug fix to the tdc.py script's handling of the -l

[PATCH net-next 1/4] tc-testing: Add test cases for flushing actions

Tests for flushing gact and mirred were missing. This patch adds test cases to explicitly test the flush of any installed gact/mirred actions. Signed-off-by: Lucas Bates Acked-by: Jamal Hadi Salim --- .../tc-testing/tc-tests/actions/tests.json |

[PATCH net-next 2/4] tc-testing: Split test case files into smaller chunks

The original submission had the test cases stored in one monolithic file. This can be unwieldy to edit, especially as more test cases are added. This patch removes the original tests.json file in favour of individual ones broken down by category. Signed-off-by: Lucas Bates

[PATCH net-next 3/4] tc-testing: Add test cases for police and skbmod

Add basic unit tests for police and skbmod actions in tc. Signed-off-by: Lucas Bates Acked-by: Jamal Hadi Salim --- .../tc-testing/tc-tests/actions/police.json| 527 + .../tc-testing/tc-tests/actions/skbmod.json| 372

[PATCH net-next 4/4] tc-testing: fix the -l argument bug in tdc.py script

This patch fixes a bug in the tdc script, where executing tdc with the -l argument would cause the tests to start running as opposed to listing all the known test cases. Signed-off-by: Lucas Bates Acked-by: Jamal Hadi Salim ---

[PATCH net-next 2/3] sched: act: ife: migrate to use per-cpu counters

This patch migrates the current counter handling which is protected by a spinlock to a per-cpu counter handling. This reduce the time where the spinlock is being held. Signed-off-by: Alexander Aring --- net/sched/act_ife.c | 29 +++-- 1 file changed,

[PATCH net-next 3/3] sched: act: ife: update parameters via rcu handling

This patch changes the parameter updating via RCU and not protected by a spinlock anymore. This reduce the time that the spinlock is being held. Signed-off-by: Alexander Aring --- include/net/tc_act/tc_ife.h | 10 -- net/sched/act_ife.c | 87

[PATCH net-next 0/3] sched: act: ife: UAPI checks and performance tweaks

Hi, this patch series contains at first a patch which adds a check for IFE_ENCODE and IFE_DECODE when a ife act gets created or updated and adding handling of these cases only inside the act callback only. The second patch use per-cpu counters and move the spinlock around so that the spinlock is

[PATCH net-next 1/3] sched: act: ife: move encode/decode check to init

This patch adds the check of the two possible ife handlings encode and decode to the init callback. The decode value is for usability aspect and used in userspace code only. The current code offers encode else decode only. This patch avoids any other option than this. Signed-off-by: Alexander

[PATCH] rtlwifi: Remove unused cur_rfstate variables

Clean up unused cur_rfstate variables in rtl8188ee, rtl8723ae, rtl8723be and rtl8821ae. Signed-off-by: Christos Gkekas --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 4 +--- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 4 +---

Re: [PATCH v5 2/2] net: phy: at803x: Change error to EINVAL for invalid MAC

From: Dan Murphy Date: Tue, 10 Oct 2017 12:42:56 -0500 > Change the return error code to EINVAL if the MAC > address is not valid in the set_wol function. > > Signed-off-by: Dan Murphy Applied to net-next.

Re: [PATCH 1/3] atm: idt77105: Drop needless setup_timer()

From: Kees Cook Date: Tue, 10 Oct 2017 12:25:48 -0700 > Calling setup_timer() is redundant when DEFINE_TIMER() has been used. > > Cc: Chas Williams <3ch...@gmail.com> > Cc: linux-atm-gene...@lists.sourceforge.net > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook

Re: [PATCH v5 1/2] net: phy: DP83822 initial driver submission

From: Dan Murphy Date: Tue, 10 Oct 2017 12:42:55 -0500 > Add support for the TI DP83822 10/100Mbit ethernet phy. > > The DP83822 provides flexibility to connect to a MAC through a > standard MII, RMII or RGMII interface. > > In addition the DP83822 needs to be removed from the

Re: [RFC net-next 1/4] net: ipv6: Make inet6addr_validator a blocking notifier

From: David Ahern Date: Tue, 10 Oct 2017 09:41:02 -0700 > + /* validator notifier needs to be blocking; > + * do not call in softirq context > + */ > + if (!in_softirq()) { I think we can test this better. You should be able to audit the call sites and for

Re: [PATCH net] macsec: fix memory leaks when skb_to_sgvec fails

From: Sabrina Dubroca Date: Tue, 10 Oct 2017 17:07:12 +0200 > Fixes: cda7ea690350 ("macsec: check return value of skb_to_sgvec always") > Signed-off-by: Sabrina Dubroca Applied and queued up for -stable.

Re: [PATCH net-next 1/1] net/smc: add SMC rendezvous protocol

From: Ursula Braun Date: Tue, 10 Oct 2017 16:14:19 +0200 > The goal of this patch is to leave common TCP code unmodified. Thus, > it uses netfilter hooks to intercept TCP SYN and SYN/ACK > packets. For outgoing packets originating from SMC sockets, the > experimental

Re: BUG:af_packet fails to TX TSO frames

On Wed, Oct 11, 2017 at 3:39 PM, Anton Ivanov wrote: > On 11/10/17 19:57, Willem de Bruijn wrote: >> On Wed, Oct 11, 2017 at 2:39 PM, Anton Ivanov >> wrote: >>> The check as now insists that the actual driver supports GSO_ROBUST,

Re: [PATCH RFC] Add Microchip KSZ8895 DSA driver

Hi! > +static void ksz8895_set_prio_queue(struct ksz_device *dev, int port, int > queue) > +{ > + u8 hi; > + u8 lo; > + > + /* Number of queues can only be 1, 2, or 4. */ > + switch (queue) { > + case 4: > + case 3: > + queue = PORT_QUEUE_SPLIT_4; > +

Re: [PATCH 3/4] dpaa_eth: change device used

From: Madalin Bucur Date: Tue, 10 Oct 2017 17:10:17 +0300 > @@ -2696,7 +2681,13 @@ static int dpaa_eth_probe(struct platform_device *pdev) > int err = 0, i, channel; > struct device *dev; > > - dev = >dev; > + /* device used for DMA mapping */ > +

Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

Hi! > +static void ksz8795_set_prio_queue(struct ksz_device *dev, int port, int > queue) > +{ > + u8 hi; > + u8 lo; > + > + /* Number of queues can only be 1, 2, or 4. */ > + switch (queue) { > + case 4: > + case 3: > + queue = PORT_QUEUE_SPLIT_4; > +

Re: [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e

Wed, Oct 11, 2017 at 10:46:52PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Wed, 11 Oct 2017 22:38:32 +0200 > >> Wed, Oct 11, 2017 at 07:46:27PM CEST, alexander.du...@gmail.com wrote: >>>On Wed, Oct 11, 2017 at 5:56 AM, Jiri Pirko wrote:

Re: [PATCH v2 net-next 0/2] lan9303: Add basic offloading of unicast traffic

From: Egil Hjelmeland Date: Tue, 10 Oct 2017 14:49:51 +0200 > This series add basic offloading of unicast traffic to the lan9303 > DSA driver. > > Review welcome! > > Changes v1 -> v2: > - Patch 1: Codestyle linting. > - Patch 2: Remember SWE_PORT_STATE while not

Re: Ethtool question

From: "John W. Linville" Date: Wed, 11 Oct 2017 16:44:07 -0400 > On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: >> I noticed today that setting some ethtool settings to the same value >> returns an error code. I would think this should silently return >>

Re: [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e

From: Jiri Pirko Date: Wed, 11 Oct 2017 22:38:32 +0200 > Wed, Oct 11, 2017 at 07:46:27PM CEST, alexander.du...@gmail.com wrote: >>On Wed, Oct 11, 2017 at 5:56 AM, Jiri Pirko wrote: >>> Wed, Oct 11, 2017 at 02:24:12AM CEST, amritha.namb...@intel.com wrote:

Re: [PATCH RFC] Add other KSZ switch support so that patch check does not complain

On Fri 2017-10-06 13:33:29, tristram...@microchip.com wrote: > From: Tristram Ha > > Add other KSZ switch support so that patch check does not complain. > > Signed-off-by: Tristram Ha Reviewed-by: Pavel Machek -- (english)

Re: [PATCH v1 RFC 7/7] Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers

Hi! > +#define KSZ_INGRESS_TAG_LEN 1 This define is now (or should be) unused, so you can delete it, no? > _#define KSZ_EGRESS_TAG_LEN 1 And I'd delete this define, too. Having constant for something that's variable is quite confusing :-). Plus you are really doing

Re: Ethtool question

On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: > I noticed today that setting some ethtool settings to the same value > returns an error code. I would think this should silently return > success instead? Makes it easier to call it from scripts this way: > > [root@lf0313-6477

  1   2   3   >