RE: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

2017-10-14 Thread Yuval Mintz
> Hi, Yuval > > On 2017/10/13 4:21, Yuval Mintz wrote: > >> This patchset adds a new hardware offload type in mqprio before adding > >> mqprio hardware offload support in hns3 driver. > > > > I think one of the biggest issues in tying this to DCB configuration is the > > non-immediate [and

Re: [net-next 3/3] tcp: keep tcp_collapse controllable even after processing starts

2017-10-14 Thread Koichiro Den
On Sat, 2017-10-14 at 08:46 -0700, Eric Dumazet wrote: > On Sat, 2017-10-14 at 16:27 +0900, Koichiro Den wrote: > > Combining actual collapsing with reasoning for deciding the starting > > point, we can apply its logic in a consistent manner such that we can > > avoid costly yet not much useful

Re: [net-next 2/3] tcp: do not tcp_collapse once SYN or FIN found

2017-10-14 Thread Koichiro Den
On Sat, 2017-10-14 at 08:43 -0700, Eric Dumazet wrote: > On Sat, 2017-10-14 at 16:27 +0900, Koichiro Den wrote: > > Since 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue") > > applied, we no longer need to continue to search for the starting > > point once we encounter FIN packet. Same

Re: [net-next 1/3] tcp: avoid useless copying and collapsing of just one skb

2017-10-14 Thread Koichiro Den
On Sat, 2017-10-14 at 08:42 -0700, Eric Dumazet wrote: > On Sat, 2017-10-14 at 16:27 +0900, Koichiro Den wrote: > > On the starting point chosen, it could be possible that just one skb > > remains in between the range provided, leading to copying and re-insertion > > of rb node, which is useless

[PATCH] rtlwifi: Fix typo in if ... else if ... else construct

2017-10-14 Thread Larry Finger
The kbuild test robot reports two conditions with no effect (if == else). These are the result of copy and paste typographical errors. Signed-off-by: Larry Finger Cc: Ping-Ke Shih Cc: Yan-Hsuan Chuang Cc: Birming Chiu

Re: [PATCH net 0/6] bnxt_en: bug fixes.

2017-10-14 Thread David Miller
From: Michael Chan Date: Fri, 13 Oct 2017 21:09:28 -0400 > Various bug fixes for the VF/PF link change logic, VF resource checking, > potential firmware response corruption on NVRAM and DCB parameters, > and reading the wrong register for PCIe link speed on the VF.

Re: [net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2017-10-13

2017-10-14 Thread David Miller
From: Jeff Kirsher Date: Fri, 13 Oct 2017 14:52:40 -0700 > This series contains updates to mqprio and i40e. Pulled, thanks Jeff.

Re: [PATCH net-next v2 0/4] tc-testing: Test suite updates

2017-10-14 Thread David Miller
From: Lucas Bates Date: Fri, 13 Oct 2017 17:51:21 -0400 > This patch series is a roundup of changes to the tc-testing > suite: > > - Add test cases for police and mirred modules and some coverage >in already-submitted test categories > - Break the test case files down

Re: [net-next PATCH 0/2] Minor macvlan source mode cleanups

2017-10-14 Thread David Miller
From: Alexander Duyck Date: Fri, 13 Oct 2017 13:40:18 -0700 > So this patch series is just a few minor cleanups for macvlan source mode. > The first patch addresses double receives when a packet is being routed to > the macvlan destination address, and the other

Re: [Patch net-next v3] tcp: add a tracepoint for tcp retransmission

2017-10-14 Thread David Miller
From: Cong Wang Date: Fri, 13 Oct 2017 13:03:16 -0700 > We need a real-time notification for tcp retransmission > for monitoring. > > Of course we could use ftrace to dynamically instrument this > kernel function too, however we can't retrieve the connection >

Re: [Patch net-next] net_sched: fix a compile warning in act_ife

2017-10-14 Thread David Miller
From: Cong Wang Date: Fri, 13 Oct 2017 12:58:13 -0700 > Apparently ife_meta_id2name() is only called when > CONFIG_MODULES is defined. > > This fixes: > > net/sched/act_ife.c:251:20: warning: ‘ife_meta_id2name’ defined but not used > [-Wunused-function] > static

Re: [PATCH net-next,0/3] Add init of send table and var renames

2017-10-14 Thread David Miller
From: Haiyang Zhang Date: Fri, 13 Oct 2017 12:28:02 -0700 > From: Haiyang Zhang > > Add initialization of send indirection table. Otherwise it may contain > old info of previous device with different number of channels. > > Also, did

Re: [PATCH net] l2tp: check ps->sock before running pppol2tp_session_ioctl()

2017-10-14 Thread David Miller
From: Guillaume Nault Date: Fri, 13 Oct 2017 19:22:35 +0200 > When pppol2tp_session_ioctl() is called by pppol2tp_tunnel_ioctl(), > the session may be unconnected. That is, it was created by > pppol2tp_session_create() and hasn't been connected with > pppol2tp_connect(). In

Re: [PATCH][net-next] cxgb4: fix missing break in switch and indent return statements

2017-10-14 Thread David Miller
From: Colin King Date: Fri, 13 Oct 2017 17:29:00 +0100 > From: Colin Ian King > > The break statement for the Macronix case is missing and will > fall through to the Winbond case and re-assign the size setting. > Fix this by adding the

Re: pull-request: mac80211-next 2017-10-13

2017-10-14 Thread David Miller
From: Johannes Berg Date: Fri, 13 Oct 2017 17:53:31 +0200 > Sorry for the quick succession - there were a few issues with > the last pull request that only got noticed now, so I'm fixing > those here. > > Please pull and let me know if there's any problem. No

Re: [PATCH net-next v2 0/8] cxgb4: add support to get hardware debug logs via ethtool

2017-10-14 Thread David Miller
From: Rahul Lakkireddy Date: Fri, 13 Oct 2017 18:48:12 +0530 > This series of patches add support to collect hardware debug logs > via ethtool --get-dump facility. Series applied, thank you.

Re: [PATCH] nfp: Explicitly include linux/bug.h

2017-10-14 Thread David Miller
From: Mark Brown Date: Fri, 13 Oct 2017 03:50:35 +0100 > Today's -next build encountered an error due to a missing definition of > WARN_ON(), caused by some header reorganization removing an implicit > inclusion of linux/bug.h. Fix this with an explicit inclusion. > >

Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-14 Thread David Miller
From: Vivien Didelot Date: Fri, 13 Oct 2017 14:18:04 -0400 > An Ethernet switch may support having a MAC address, which can be used > as the switch's source address in transmitted full-duplex Pause frames. > > If a DSA switch supports the related .set_addr

Re: [PATCH] atm: fore200e: mark expected switch fall-throughs

2017-10-14 Thread David Miller
From: "Gustavo A. R. Silva" Date: Thu, 12 Oct 2017 16:11:32 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Applied to net-next

Re: [PATCH] fix typo in skbuff.c

2017-10-14 Thread David Miller
From: Wenhua Shi Date: Sat, 14 Oct 2017 18:51:36 +0200 > --- > net/core/skbuff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.

Re: Linux 4.12+ memory leak on router with i40e NICs

2017-10-14 Thread Alexander Duyck
Hi Pawel, To clarify is that Dave Miller's tree or Linus's that you are talking about? If it is Dave's tree how long ago was it you pulled it since I think the fix was just pushed by Jeff Kirsher a few days ago. The issue should be fixed in the following commit:

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-10-14 Thread Michael S. Tsirkin
On Fri, Oct 13, 2017 at 11:51:40AM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Implement the reset communication request defined in the VIRTIO 1.0 > specification and introduces in Linux in commit c00bbcf862896 ("virtio: > add VIRTIO_CONFIG_S_NEEDS_RESET

Re: [patch net-next 06/34] net: core: use dev->ingress_queue instead of tp->q

2017-10-14 Thread Daniel Borkmann
On 10/13/2017 08:30 AM, Jiri Pirko wrote: Thu, Oct 12, 2017 at 11:45:43PM CEST, dan...@iogearbox.net wrote: On 10/12/2017 07:17 PM, Jiri Pirko wrote: From: Jiri Pirko In sch_handle_egress and sch_handle_ingress, don't use tp->q and use dev->ingress_queue which stores the

Re: [PATCH] Add -target to clang switch while cross compiling.

2017-10-14 Thread Daniel Borkmann
On 10/13/2017 09:24 PM, Abhijit Ayarekar wrote: Update to llvm excludes assembly instructions. llvm git revision is below commit 65fad7c26569 ("bpf: add inline-asm support") This change will be part of llvm release 6.0 __ASM_SYSREG_H define is not required for native compile. -target switch

Re: [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11

2017-10-14 Thread Parav Pandit
On Sat, Oct 14, 2017 at 1:48 PM, Saeed Mahameed wrote: > Hi Dave and Doug, > > This series includes updates for mlx5 IPoIB offloading driver from Alex > and Feras to add the support for Muli Pkey in the mlx5i ipoib offloading > netdev, In description and cover letter

Re: [OpenWrt-Devel] [PATCH v3 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2017-10-14 Thread Florian Fainelli
On October 14, 2017 2:59:22 PM PDT, Linus Walleij wrote: >On Sat, Oct 14, 2017 at 8:52 PM, Florian Fainelli > wrote: > >> The most deployed switch device drivers have been converted to DSA >> already: b53, qca8k (ar83xx in OpenWrt/LEDE) and mtk7530

Re: [OpenWrt-Devel] [PATCH v3 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2017-10-14 Thread Linus Walleij
On Sat, Oct 14, 2017 at 8:52 PM, Florian Fainelli wrote: > The most deployed switch device drivers have been converted to DSA > already: b53, qca8k (ar83xx in OpenWrt/LEDE) and mtk7530 are all in > tree, and now we are getting new submissions from Michrochip to support >

Re: [pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11

2017-10-14 Thread Doug Ledford
On 10/14/2017 2:48 PM, Saeed Mahameed wrote: > Hi Dave and Doug, > > This series includes updates for mlx5 IPoIB offloading driver from Alex > and Feras to add the support for Muli Pkey in the mlx5i ipoib offloading > netdev, > to be merged into net-next and rdma-next trees. As far as the two

Re: [PATCH v1 RFC 7/7] Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers

2017-10-14 Thread Andrew Lunn
On Fri, Oct 06, 2017 at 01:33:05PM -0700, tristram...@microchip.com wrote: > From: Tristram Ha > > Modify tag_ksz.c so that tail tag code can be used by other KSZ switch > drivers. There is multiple things going on in this patch. Please split the special_mult_addr

Re: [PATCH v1 RFC 6/7] Add MIB counter reading support

2017-10-14 Thread Andrew Lunn
> +static void ksz9477_phy_setup(struct ksz_device *dev, int port, > + struct phy_device *phy) > +{ > + if (port < dev->phy_port_cnt) { > + /* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to > + * disable flow control when rate

Re: [PATCH v1 RFC 5/7] Break KSZ9477 DSA driver into two files

2017-10-14 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/microchip/ksz9477.c > b/drivers/net/dsa/microchip/ksz9477.c > new file mode 100644 > index 000..214d380 > --- /dev/null > +++ b/drivers/net/dsa/microchip/ksz9477.c > @@ -0,0 +1,1328 @@ > +/* > + * Microchip KSZ9477 switch driver main logic > + * > + * Copyright

Re: [PATCH v1 RFC 4/7] Rename ksz_spi.c to ksz9477_spi.c

2017-10-14 Thread Andrew Lunn
On Fri, Oct 06, 2017 at 01:33:02PM -0700, tristram...@microchip.com wrote: > From: Tristram Ha > > Rename ksz_spi.c to ksz9477_spi.c and update Kconfig in preparation to add > more KSZ switch drivers. > > Signed-off-by: Tristram Ha

Re: [PATCH v1 RFC 3/7] Rename some functions with ksz9477 prefix

2017-10-14 Thread Andrew Lunn
On Fri, Oct 06, 2017 at 01:33:01PM -0700, tristram...@microchip.com wrote: > From: Tristram Ha > > Rename some functions with ksz9477 prefix to separate chip specific code > from common code. > > Signed-off-by: Tristram Ha Reviewed-by:

Re: [PATCH v1 RFC 1/7] Replace license with GPL

2017-10-14 Thread Andrew Lunn
On Mon, Oct 09, 2017 at 09:18:16AM +, David Laight wrote: > From: tristram...@microchip.com > > Sent: 06 October 2017 21:33 > > Replace license with GPL. > > Don't you need permission from all the people who have updated > the files in order to make this change? Hi David Interesting

Re: [PATCH v1 RFC 2/7] Clean up code according to patch check suggestions

2017-10-14 Thread Andrew Lunn
On Fri, Oct 06, 2017 at 01:33:00PM -0700, tristram...@microchip.com wrote: > From: Tristram Ha > > Clean up code according to patch check suggestions. > > Signed-off-by: Tristram Ha Reviewed-by: Andrew Lunn Andrew

Re: [PATCH] netconsole: make config_item_type const

2017-10-14 Thread kbuild test robot
Hi Bhumika, [auto build test WARNING on net-next/master] [also build test WARNING on v4.14-rc4 next-20171013] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] net/rose: Delete an error message for a failed memory allocation in rose_proto_init()

2017-10-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Oct 2017 20:57:28 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [OpenWrt-Devel] [PATCH v3 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2017-10-14 Thread Florian Fainelli
Hi, On 10/14/2017 04:09 AM, Linus Walleij wrote: > Top posting and resending since netdev@vger.kernel.org > is the right mail address for this. Mea culpa. > > Linus Walleij > > On Sat, Oct 14, 2017 at 11:35 AM, Linus Walleij > wrote: >> On Thu, Oct 5, 2017 at 11:16

Re: [PATCH net v2 1/2] ARM: dts: imx: name the interrupts for the fec ethernet driver

2017-10-14 Thread Andrew Lunn
On Fri, Oct 13, 2017 at 07:09:39PM -0700, Troy Kisky wrote: > imx7s/imx7d has the ptp interrupt newly added as well. Hi Troy > For imx7, "int0" is the interrupt for queue 0 and ENET_MII > "int1" is for queue 1 > "int2" is for queue 2 Thanks for adding this explanation. Please also add it to

[for-next 04/12] net/mlx5: Support for attaching multiple underlay QPs to root flow table

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker Previous support allowed connecting only a single QPN to the FT. Now using a linked list multiple QPNs can be attached to the same FT. Supporting attaching multiple underlay QPs is required for PKEY support in which child and parent share the same FT. The

[for-next 07/12] net/mlx5e: IPoIB, Support for setting PKEY index to underlay QP

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker Added a function to set PKEY index to IPoIB device driver using the already present set_id function. PKEY index is attached to the QP during state modification. Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit

[for-next 03/12] net/mlx5e: IPoIB, Move underlay QP init/uninit to separate functions

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker During the creation of the underlay QP the PKEY index is unknown, the PKEY index is known only when calling ndo_open. PKEY index attached to the QP during state modification. Splitting the functions will also make the code symmetric and more readable. This

[for-next 06/12] IB/ipoib: Add ability to set PKEY index to lower device driver

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker To support passing child interfaces to the lower device a new rdma_netdev function was used, set_id. This will allow us to attach the PKEY index lower device resources such as TIS/QP. For devices that do not support offloads in IPoIB same logic will be used,

[for-next 05/12] IB/ipoib: Grab rtnl lock on heavy flush when calling ndo_open/stop

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker When ndo_open and ndo_stop are called RTNL lock should be held. In this specific case ipoib_ib_dev_open calls the offloaded ndo_open which re-sets the number of TX queue assuming RTNL lock is held. Since RTNL lock is not held, RTNL assert will fail.

[for-next 09/12] net/mlx5e: IPoIB, Add PKEY child interface nic profile

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker Child interface profile will be called to support child interface specific behaviour. The child code is sparse compared to the parent since the RX channels are shared between the interfaces. Creating a septate profile for child and parent will make a smother

[for-next 10/12] net/mlx5e: IPoIB, Add PKEY child interface ndos

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker Child interface ndos will be called to support child interface specific behaviour. ndo_init flow: -Acquire shared QPN to net-device HT from parent -Continue with the same flow as parent interface ndo_open flow: -Initialize child underlay QP and connect to

[for-next 08/12] net/mlx5e: IPoIB, Use hash-table to map between QPN to child netdev

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker This change is needed for PKEY support, since the RQs are shared between the child interface and the parent. The parent is responsible for NAPI and the precessing of RX completions. Using the dqpn in the completion descriptor we set the corresponding child

[for-next 12/12] net/mlx5e: IPoIB, Modify rdma netdev allocate and free to support PKEY

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker Resources such as FT, QPN HT and mdev resources should be allocated only by parent netdev. Shared resources are allocated and freed by the parent interface since the parent is always present and created before the IPoIB PKEY sub-interface. Signed-off-by:

[for-next 11/12] net/mlx5e: IPoIB, Add PKEY child interface ethtool ops

2017-10-14 Thread Saeed Mahameed
From: Alex Vesker Similar to VLAN interfaces child interfaces have limited ethtool support. In current code the main limitation that does not allow child interface ethtool configuration is due to shared resources which are managed by the parent. Signed-off-by: Alex Vesker

[for-next 02/12] net/mlx5: PTP code migration to driver core section

2017-10-14 Thread Saeed Mahameed
From: Feras Daoud PTP code is moved to core section of mlx5 driver in order to share it between ethernet and infiniband. This movement involves the following changes: - Change mlx5e_ prefix to be mlx5_ - Add clock structs to Core - Add clock object to mlx5_core_dev - Call

[pull request][for-next 00/12] Mellanox, mlx5 IPoIB Muli Pkey support 2017-10-11

2017-10-14 Thread Saeed Mahameed
Hi Dave and Doug, This series includes updates for mlx5 IPoIB offloading driver from Alex and Feras to add the support for Muli Pkey in the mlx5i ipoib offloading netdev, to be merged into net-next and rdma-next trees. Doug, I am sorry I couldn't base this on rc2 since the series needs and

[for-next 01/12] net/mlx5: File renaming towards ptp core implementation

2017-10-14 Thread Saeed Mahameed
From: Feras Daoud en_clock.c renamed clock.c and moved to lib/ as first step towards relocating code to core part of the driver to allow sharing between Ethernet and Infiniband. Signed-off-by: Feras Daoud Signed-off-by: Eitan Rabin

Re: [PATCH net-next v5 0/5] bpf: security: New file mode and LSM hooks for eBPF object permission control

2017-10-14 Thread David Miller
Hmmm, this doesn't build for me: security/selinux/hooks.c: In function ‘bpf_fd_pass’: security/selinux/hooks.c:6325:40: error: ‘SECCLASS_BPF_MAP’ undeclared (first use in this function); did you mean ‘SECCLASS_BPF’? ret = avc_has_perm(sid, bpfsec->sid, SECCLASS_BPF_MAP,

Re: [PATCH net-next 00/12] nfp: bpf: support direct packet access

2017-10-14 Thread David Miller
From: Jakub Kicinski Date: Thu, 12 Oct 2017 10:34:06 -0700 > The core of this series is direct packet access support. With a > small change to the verifier, the offloaded code can now make > use of DPA. We need to be careful to use kernel (after initial >

Re: [PATCH net-next v2 0/2] net: stmmac: Improvements for multi-queuing and for AVB

2017-10-14 Thread David Miller
From: Jose Abreu Date: Fri, 13 Oct 2017 10:58:35 +0100 > Two improvements for stmmac: First one corrects the available fifo > size per queue, second one corrects enabling of AVB queues. More > info in commit log. Series applied, thanks.

Re: [PATCH net-next] icmp: don't fail on fragment reassembly time exceeded

2017-10-14 Thread David Miller
From: Matteo Croce Date: Thu, 12 Oct 2017 16:12:37 +0200 > The ICMP implementation currently replies to an ICMP time exceeded message > (type 11) with an ICMP host unreachable message (type 3, code 1). > > However, time exceeded messages can either represent "time to live

[PATCH] netrom: Delete an error message for a failed memory allocation in nr_proto_init()

2017-10-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Oct 2017 18:48:18 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [net-next V7 PATCH 4/5] bpf: cpumap add tracepoints

2017-10-14 Thread David Miller
From: Jesper Dangaard Brouer Date: Thu, 12 Oct 2017 14:27:05 +0200 > @@ -355,7 +360,10 @@ struct bpf_cpu_map_entry *__cpu_map_entry_alloc(u32 > qsize, u32 cpu, int map_id) > err = ptr_ring_init(rcpu->queue, qsize, gfp); > if (err) > goto free_queue;

[PATCH] fix typo in skbuff.c

2017-10-14 Thread Wenhua Shi
--- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 16982de6..e62476be 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -1896,7 +1896,7 @@ void *__pskb_pull_tail(struct sk_buff *skb, int delta) }

[PATCH] net/ncsi: Delete an error message for a failed memory allocation in ncsi_rsp_handler_gc()

2017-10-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Oct 2017 18:03:11 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [net-next 3/3] tcp: keep tcp_collapse controllable even after processing starts

2017-10-14 Thread Eric Dumazet
On Sat, 2017-10-14 at 16:27 +0900, Koichiro Den wrote: > Combining actual collapsing with reasoning for deciding the starting > point, we can apply its logic in a consistent manner such that we can > avoid costly yet not much useful collapsing. When collapsing to be > triggered, it's not rare that

Re: [net-next 2/3] tcp: do not tcp_collapse once SYN or FIN found

2017-10-14 Thread Eric Dumazet
On Sat, 2017-10-14 at 16:27 +0900, Koichiro Den wrote: > Since 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue") > applied, we no longer need to continue to search for the starting > point once we encounter FIN packet. Same reasoning for SYN packet > since commit 9d691539eea2d ("tcp: do

Re: [net-next 1/3] tcp: avoid useless copying and collapsing of just one skb

2017-10-14 Thread Eric Dumazet
On Sat, 2017-10-14 at 16:27 +0900, Koichiro Den wrote: > On the starting point chosen, it could be possible that just one skb > remains in between the range provided, leading to copying and re-insertion > of rb node, which is useless with respect to the rcv buf measurement. > This is rather

Re: [PATCH 3/3] ARM: dts: gr-peach: Add ETHER pin group

2017-10-14 Thread Andrew Lunn
> > So your binding whats to look something like > > > > ether: ethernet@e8203000 { > > compatible = "renesas,ether-r7s72100"; > > reg = <0xe8203000 0x800>, > > <0xe8204800 0x200>; > > interrupts = ; > >

Re: [PATCH v2] net: ftgmac100: Request clock and set speed

2017-10-14 Thread kbuild test robot
-and-set-speed/20171014-195836 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-14 Thread Dmitry Vyukov
On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka wrote: > Hi > > On Mon, Oct 09, 2017 at 07:50:53PM +0200, Andrey Konovalov wrote: >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4).

Re: Kernel Performance Tuning for High Volume SCTP traffic

2017-10-14 Thread Traiano Welcome
I've upped the value of the following sctp and udp related parameters, in the hope that this would help: sysctl -w net.core.rmem_max=9 sysctl -w net.core.wmem_max=9 sysctl -w net.sctp.sctp_mem="21 21 21" sysctl -w net.sctp.sctp_rmem="21 21

[PATCH v2] pch_gbe: Switch to new PCI IRQ allocation API

2017-10-14 Thread Andy Shevchenko
This removes custom flag handling. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h| 3 +- .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 42 +- 2 files changed, 17 insertions(+), 28 deletions(-)

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

2017-10-14 Thread icenowy
在 2017-10-05 14:58,Kalle Valo 写道: Icenowy Zheng writes: 于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard 写到: On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: On 10/4/2017 11:03 AM, Icenowy Zheng wrote: > > > 于 2017年10月4日

[RFC PATCH v2 2/5] tcp: implemented pacing_expired

2017-10-14 Thread Natale Patriciello
Inform the congestion control that the pacing timer, previously set, has expired. The commit does not consider situations in which another kind of timer has expired (e.g., a tail loss probe, a retransmission timer...) Signed-off-by: Natale Patriciello ---

[RFC PATCH v2 4/5] tcp: added segment sent

2017-10-14 Thread Natale Patriciello
Inform the congestion control of the number of segment sent in normal conditions, it means segments that left the node without involving recovery or retransmission procedures. Signed-off-by: Natale Patriciello --- include/net/tcp.h | 2 ++

[RFC PATCH v2 3/5] tcp: added get_segs_per_round

2017-10-14 Thread Natale Patriciello
Usually, the pacing time is provided per-segment. In some occasion, this time refers to the time between a group of segments. With this commit, add the possibility for the congestion control module to tell the TCP socket how many segments can be sent out before pausing and setting a pacing timer.

[RFC PATCH v2 0/5] TCP Wave

2017-10-14 Thread Natale Patriciello
Hello, after the round of review on our v1 patch (you can find the relevant thread here [1]) we have improved our code of TCP Wave, a new congestion control algorithm. Context: TCP Wave (TCPW) replaces the window-based transmission paradigm of the standard TCP with a burst-based transmission,

[RFC PATCH v2 1/5] tcp: Added a function to retrieve pacing timer

2017-10-14 Thread Natale Patriciello
Allow congestion control modules to set a custom pacing time between the transmission of segments. Moreover, it is assumed that the time returned by the congestion module in the past is firm, until the timer expires; therefore, do not re-start the timer if it is already active. Signed-off-by:

[RFC PATCH v2 5/5] wave: Added TCP Wave

2017-10-14 Thread Natale Patriciello
TCP Wave (TCPW) replaces the window-based transmission paradigm of the standard TCP with a burst-based transmission, the ACK-clock scheduling with a self-managed timer and the RTT-based congestion control loop with an Ack-based Capacity and Congestion Estimation (ACCE) module. In non-technical

Re: [PATCH v3 0/6] staging: Introduce DPAA2 Ethernet Switch driver

2017-10-14 Thread Linus Walleij
Top posting and resending since netdev@vger.kernel.org is the right mail address for this. Mea culpa. Linus Walleij On Sat, Oct 14, 2017 at 11:35 AM, Linus Walleij wrote: > On Thu, Oct 5, 2017 at 11:16 AM, Razvan Stefanescu > wrote: > >>

Re: [PATCH net-next v2 1/1] bridge: return error code when deleting Vlan

2017-10-14 Thread Nikolay Aleksandrov
On 13/10/17 19:00, Roman Mashak wrote: > Nikolay Aleksandrov writes: > > > [...] > Why do you want to return the error code here? Walking the code paths seems like ENOENT or err from switchdev_port_obj_del are the 2 error possibilities. >>> >>> For

[PATCH] ath9k: debug: Remove redundant check

2017-10-14 Thread Christos Gkekas
Variable val is unsigned, so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath9k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c

[PATCH] ath10k: spectral: Remove redundant check

2017-10-14 Thread Christos Gkekas
Variable val is unsigned, so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath10k/spectral.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c

Re: [PATCH] ath9k: debug: Simplify error checking

2017-10-14 Thread Christos Gkekas
On 13/10/17 15:49:15 +0300, Kalle Valo wrote: > Christos Gkekas writes: > > > Variable val is unsigned so checking whether it is less than zero is > > redundant. > > > > Signed-off-by: Christos Gkekas > > --- > >

Re: [PATCH] ath10k: spectral: Simplify error checking

2017-10-14 Thread Christos Gkekas
On 13/10/17 12:28:50 +, Kalle Valo wrote: > Christos Gkekas writes: > > > Variable val is unsigned so checking whether it is less than zero is > > redundant. > > > > Signed-off-by: Christos Gkekas > > --- > >

[net-next 0/3] optimisations and reorganisations of tcp_collapse

2017-10-14 Thread Koichiro Den
This patch series removes possible useless copying and collapsing while not missing the chance when it is worth the effort. Also reorganizes it and do some cleanups. Koichiro Den (3): tcp: avoid useless copying and collapsing of just one skb tcp: do not tcp_collapse once SYN or FIN found

[net-next 1/3] tcp: avoid useless copying and collapsing of just one skb

2017-10-14 Thread Koichiro Den
On the starting point chosen, it could be possible that just one skb remains in between the range provided, leading to copying and re-insertion of rb node, which is useless with respect to the rcv buf measurement. This is rather probable in ooo queue case, in which non-contiguous bloated packets

[net-next 3/3] tcp: keep tcp_collapse controllable even after processing starts

2017-10-14 Thread Koichiro Den
Combining actual collapsing with reasoning for deciding the starting point, we can apply its logic in a consistent manner such that we can avoid costly yet not much useful collapsing. When collapsing to be triggered, it's not rare that most of the skbs in the receive or ooo queue are large ones

[net-next 2/3] tcp: do not tcp_collapse once SYN or FIN found

2017-10-14 Thread Koichiro Den
Since 9f5afeae5152 ("tcp: use an RB tree for ooo receive queue") applied, we no longer need to continue to search for the starting point once we encounter FIN packet. Same reasoning for SYN packet since commit 9d691539eea2d ("tcp: do not enqueue skb with SYN flag"), that would help us with error