[PATCH net-next] bnxt_en: Fix randconfig build errors.

Fix undefined symbols when CONFIG_VLAN_8021Q or CONFIG_INET is not set. Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload") Reported-by: Jakub Kicinski Signed-off-by: Michael Chan ---

Re: [PATCH net-next] qed: Set error code for allocation failures

Hi, Dan On 2017/10/27 19:52, Dan Carpenter wrote: > On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> Hi, Dan >> >> On 2017/10/27 14:40, Dan Carpenter wrote: >>> There are several places where we accidentally return success when >>> kcalloc() fails. >>> >>> Fixes: fcb39f6c10b2

[PATCH iproute2 net-next v2 1/2] iplink: bridge: support bridge port vlan_tunnel attribute

From: Roopa Prabhu This config maps to IFLA_BRPORT_VLAN_TUNNEL bridge port netlink flag attribute. This flag enables vlan to tunnel mapping on a bridge port. It is off by default. set vlan_tunnel attribute on bridge port vxlan0: $ip link set dev vxlan0 type

[PATCH iproute2 net-next v2 2/2] bridge: vlan: support for per vlan tunnel info

From: Roopa Prabhu This patch uses kernel bridge vlan attribute IFLA_BRIDGE_VLAN_TUNNEL_INFO to set/delete/show per vlan tunnel info. $bridge vlan add dev vxlan0 vid 2000 tunnel_info id 2000 $bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001 $bridge

[PATCH iproute2 net-next v2 0/2] bridge: support for vlan to tunnel mapping

From: Roopa Prabhu This series adds the required options to iplink and bridge commands to enable per vlan tunnel info on a bridge port provided by netlink attributes IFLA_BRPORT_VLAN_TUNNEL (flag) and IFLA_BRIDGE_VLAN_TUNNEL_INFO enable vlan-tunnel mapping on a bridge

[Patch net] net_sched: avoid matching qdisc with zero handle

Davide found the following script triggers a NULL pointer dereference: ip l a name eth0 type dummy tc q a dev eth0 parent :1 handle 1: htb This is because for a freshly created netdevice noop_qdisc is attached and when passing 'parent :1', kernel actually tries to match the major handle which is

[PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit()

Remove platform_device_put() call after platform_device_unregister() from function bcmgenet_mii_exit(), otherwise, we will call platform_device_put() twice. Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver") Signed-off-by: Wei Yongjun

[PATCH net-next] net: aquantia: Make local functions static

Fixes the following sparse warnings: drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:224:5: warning: symbol 'aq_ethtool_get_coalesce' was not declared. Should it be static? drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:245:5: warning: symbol 'aq_ethtool_set_coalesce' was not declared.

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

On Fri, 27 Oct 2017 20:28:16 -0700, Michael Chan wrote: > On Fri, Oct 27, 2017 at 8:18 PM, Jakub Kicinski wrote: > > On Thu, 26 Oct 2017 11:51:29 -0400, Michael Chan wrote: > >> From: Sathya Perla > >> > >> This patch adds IPv4 vxlan encap/decap

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

On Fri, Oct 27, 2017 at 8:18 PM, Jakub Kicinski wrote: > On Thu, 26 Oct 2017 11:51:29 -0400, Michael Chan wrote: >> From: Sathya Perla >> >> This patch adds IPv4 vxlan encap/decap action support to TC-flower >> offload. >> >> For vxlan encap, the driver

Re: [PATCH net-next 11/14] bnxt_en: add support for Flower based vxlan encap/decap offload

On Thu, 26 Oct 2017 11:51:29 -0400, Michael Chan wrote: > From: Sathya Perla > > This patch adds IPv4 vxlan encap/decap action support to TC-flower > offload. > > For vxlan encap, the driver maintains a tunnel encap hash-table. > When a new flow with a tunnel encap

Re: v6/sit tunnels and VRFs

Your comments on the tunnel VRF and underlay VRF being different make sense and is more flexible. I think assigning the dev/link to the same VRF as the tunnel master accomplishes the same thing that I originally had in mind. ping v4 loopback... jeff@VM2:~$ ip route list vrf myvrf 127.0.0.0/8

Re: [RFC] please clarify local_irq_disable() in pcpu_freelist_populate()

On 10/27/17 3:23 PM, Sebastian Andrzej Siewior wrote: Hi, while looking at other things here I stumbled at this in kernel/bpf/percpu_freelist.c: |void pcpu_freelist_populate(struct pcpu_freelist *s, void *buf, u32 elem_size, |u32 nr_elems) |{ … |/* disable

Re: [PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect_map

On Fri, Oct 27, 2017 at 05:28:22PM -0700, Tushar Dave wrote: > Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. > e.g. > [root@labbpf]# ./xdp_redirect_map $( > $( failed to create a map: 1 Operation not permitted > > The failure is 100% when multiple xdp programs are running. Fix

Re: [PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp1

On Fri, Oct 27, 2017 at 04:12:30PM -0700, Tushar Dave wrote: > Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. > e.g. > [root@lab bpf]#./xdp1 -N $( failed to create a map: 1 Operation not permitted > > Fix it. > > Signed-off-by: Tushar Dave Acked-by:

Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

On Fri, Oct 27, 2017 at 3:22 PM, Subash Abhinov Kasiviswanathan wrote: >> This doesn't make sense to me, maybe I am missing something. What >> "real device" is setting the skb->destructor() and doing it to somehow >> handle recycling? The only driver I can find that is

Re: [PATCH v7 net-next 06/13] gtp: Change to use gro_cells

On Fri, 2017-10-27 at 17:09 -0700, Tom Herbert wrote: > Call gro_cells_receive instead of netif_rx. > ... > > static void gtp_link_setup(struct net_device *dev) > { > + struct gtp_dev *gtp = netdev_priv(dev); > + > dev->netdev_ops = _netdev_ops; >

Re: [PATCH v7 net-next 01/13] vxlan: Move gro_cells_init to ndo_init

On Fri, 2017-10-27 at 17:09 -0700, Tom Herbert wrote: > Move gro_cells_init to ndo_init and properly check return value. > > Signed-off-by: Tom Herbert > --- > drivers/net/vxlan.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) Reported-by: Eric

Re: [PATCH] net: systemport: Correct IPG length settings

On October 27, 2017 5:30:00 PM PDT, Florian Fainelli wrote: >Due to a documentation mistake, the IPG length was set to 0x12 while it >should have been 12 (decimal). This would affect short packet (64B >typically) performance since the IPG was bigger than necessary. >

Re: [patch net-next v2 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

On Fri, 27 Oct 2017 09:27:30 +0200, Jiri Pirko wrote: > >>> 2. Deleting the ingress qdisc fails to remove filters added in > >>> HW. Filters in SW gets deleted. > >>> > >>> We haven’t exactly root-caused this, the changes being extensive, but > >>> our guess is again something wrong with the

[PATCH v2 net-next 3/3] mlxsw: spectrum_router: Return extack message on abort due to fib rules

Adding a FIB rule on a spectrum platform silently aborts FIB offload: $ ip ru add pref 99 from all to 192.168.1.1 table 10 $ dmesg -c [ 623.144736] mlxsw_spectrum :03:00.0: FIB abort triggered. Note that FIB entries are no longer being offloaded to this device. This patch

[PATCH v2 net-next 2/3] net: Add extack to fib_notifier_info

Add extack to fib_notifier_info and plumb through stack to call_fib_rule_notifiers, call_fib_entry_notifiers and call_fib6_entry_notifiers. This allows notifer handlers to return messages to user. Signed-off-by: David Ahern --- include/net/fib_notifier.h | 1 +

[PATCH v2 net-next 1/3] netlink: Allow ext_ack to carry non-error messages

The NLMSGERR API already carries data (eg, a cookie) on the success path. Allow a message string to be returned as well. Signed-off-by: David Ahern --- net/netlink/af_netlink.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v2 net-next 0/3] net: Allow non-fatal messages to be passed in extack

There are many cases where networking subsystems throw non-fatal warning messages that end up in dmesg / kernel log to which a user making the change is completely oblivious. This set makes the extack facility usable for returning such messages. The case in point here is spectrum and adding FIB

[PATCH net-next] ipv6: prevent user from adding cached routes

From: Wei Wang Cached routes should only be created by the system when receiving pmtu discovery or ip redirect msg. Users should not be allowed to create cached routes. Furthermore, after the patch series to move cached routes into exception table, user added cached routes

[PATCH] net: systemport: Correct IPG length settings

Due to a documentation mistake, the IPG length was set to 0x12 while it should have been 12 (decimal). This would affect short packet (64B typically) performance since the IPG was bigger than necessary. Fixes: 44a4524c54af ("net: systemport: Add support for SYSTEMPORT Lite") Signed-off-by:

[PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect_map

Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. e.g. [root@labbpf]# ./xdp_redirect_map $( $( --- samples/bpf/xdp_redirect_map_user.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/samples/bpf/xdp_redirect_map_user.c b/samples/bpf/xdp_redirect_map_user.c index

Re: intel i40e buggy driver question

On Fri, Oct 27, 2017 at 3:34 PM, Paweł Staszewski wrote: > Hi > > > > > I have many problems with 40e driver > > memleaks , kernel panics , stack traces , tx hungx , tx timeouts and many > many others :) > > > But the main problem that can't be resolved in linux is resolved

[PATCH v7 net-next 10/13] gtp: Eliminate pktinfo and add port configuration

The gtp pktinfo structure is unnecessary and needs a lot of code to manage it. Remove it. Also, add per pdp port configuration for transmit. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 177 +--

[PATCH v7 net-next 13/13] gtp: Allow configuring GTP interface as standalone

Add new configuration of GTP interfaces that allow specifying a port to listen on (as opposed to having to get sockets from a userspace control plane). This allows GTP interfaces to be configured and the data path tested without requiring a GTP-C daemon. Signed-off-by: Tom Herbert

[PATCH v7 net-next 02/13] iptunnel: Add common functions to get a tunnel route

ip_tunnel_get_route and ip6_tnl_get_route are created to return routes for a tunnel. These functions are derived from the VXLAN functions. Signed-off-by: Tom Herbert --- include/net/ip6_tunnel.h | 31 +++ include/net/ip_tunnels.h | 32

[PATCH v7 net-next 06/13] gtp: Change to use gro_cells

Call gro_cells_receive instead of netif_rx. Signed-off-by: Tom Herbert --- drivers/net/Kconfig | 1 + drivers/net/gtp.c | 18 +- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index

[PATCH v7 net-next 11/13] gtp: Experimental encapsulation of IPv6 packets

Allow IPv6 mobile subscriber packets. This entails adding an IPv6 mobile subscriber address to pdp context and IPv6 specific variants to find pdp contexts by address. Note that this is experimental support of IPv6, more work is necessary to make this compliant with 3GPP standard. Signed-off-by:

[PATCH v7 net-next 12/13] gtp: Experimental support encpasulating over IPv6

Allows using GTP datapath over IPv6. Remote peers are indicated by IPv6. Note this is experimental, more work is needed to make this compliant with 3GPP standard. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 248 ++-

[PATCH v7 net-next 03/13] vxlan: Call common functions to get tunnel routes

Call ip_tunnel_get_route and ip6_tnl_get_route to handle getting a route and dealing with the dst_cache. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 84 - 1 file changed, 5 insertions(+), 79 deletions(-) diff

[PATCH v7 net-next 09/13] gtp: Call function to update path mtu

Replace mtu handling with call to __iptunnel_update_pmtu. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index

[PATCH v7 net-next 04/13] gtp: Call common functions to get tunnel routes and add dst_cache

Call ip_tunnel_get_route and dst_cache to pdp context which should improve performance by obviating the need to perform a route lookup on every packet. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 62 +++ 1 file

[PATCH v7 net-next 08/13] gtp: udp recv clean up

Create separate UDP receive functions for GTP version 0 and version 1. Set encap_rcv appropriately when configuring a socket. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 100 ++ 1 file changed, 49 insertions(+), 51

[PATCH v7 net-next 01/13] vxlan: Move gro_cells_init to ndo_init

Move gro_cells_init to ndo_init and properly check return value. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index d7c49cf1d5e9..a54dd3d2a824

[PATCH v7 net-next 05/13] iptunnel: Generalize tunnel update pmtu

Add __iptunnel_update_pmtu exported function which does not take an iptunnel argument but instead includes the fields from the iptunnel structure as arguments which are needed in the function. iptunnel_update_pmtu was modified to call __iptunnel_update_pmtu. Signed-off-by: Tom Herbert

[PATCH v7 net-next 07/13] gtp: Use goto for exceptions in gtp_udp_encap_recv funcs

Consolidate return logic to make it easier to extend. Signed-off-by: Tom Herbert --- drivers/net/gtp.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 265fa9fdbf3d..2daf434ae543

[PATCH v7 net-next 00/13] gtp: Additional feature support - Part I

This patch set builds upon the initial GTP implementation to make support closer to that enjoyed by other encapsulation protocols. The major items are: - Experimental IPv6 support - Configurable networking interfaces so that GTP kernel can be used and tested without needing GSN network

Re: [PATCH V2 net-next 1/2] liquidio: switchdev support for LiquidIO NIC

On Fri, 27 Oct 2017 12:09:17 -0700, Felix Manlunas wrote: > From: Vijaya Mohan Guvva > > Enable switchdev for SRIOV capable LiquidIO NIC. It registers > a representor netdev (with switchdev_ops) for each SRIOV VF created. > It also has changes to send representor

Re: [PATCH net-next v6 2/2] bridge: vlan: signal if anything changed on vlan add

On 17/10/27 (金) 19:19, Nikolay Aleksandrov wrote: Before this patch there was no way to tell if the vlan add operation actually changed anything, thus we would always generate a notification on adds. Let's make the notifications more precise and generate them only if anything changed, so use the

Re: [PATCH net] net/sched: fix NULL pointer dereference in qdisc_alloc()

On Thu, Oct 26, 2017 at 11:26 AM, Davide Caratti wrote: > the following script generates a NULL pointer dereference error: > > ip l a name eth0 type dummy > tc q a dev eth0 parent :1 handle 1: htb > > upon creation of classful qdiscs, qdisc_alloc() dereferences dev_queue->dev

Re: [Intel-wired-lan] Instability of i40e driver on 4.9 kernel

e1000 sourceforge is a bad place to make anything with Your problems Just checked this now if something changed :) But when I post reply to some bug that i was have same problem somebody closed the ticket and delete my message :) So rly :) W dniu 2017-10-25 o 23:49, Pavlos Parissis

[PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp1

Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. e.g. [root@lab bpf]#./xdp1 -N $( --- samples/bpf/xdp1_user.c | 8 1 file changed, 8 insertions(+) diff --git a/samples/bpf/xdp1_user.c b/samples/bpf/xdp1_user.c index 2431c03..fdaefe9 100644 --- a/samples/bpf/xdp1_user.c +++

Re: intel i40e buggy driver question

W dniu 2017-10-28 o 00:34, Paweł Staszewski pisze: Hi I have many problems with 40e driver memleaks , kernel panics , stack traces , tx hungx , tx timeouts and many many others :) But the main problem that can't be resolved in linux is resolved in freebsd problem in freebsd with

Re: [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Add programming descriptors to cleaned_count

On 28 October 2017 at 00:21, Paweł Staszewski wrote: > from today it is in net.git > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/log/?qt=grep=i40e > > It will be later in net-next > > I have to admit I am not that familiar with repo layout, I though

[PATCH net-next] net: dsa: b53: Export b53_configure_vlan()

bcm_sf2 and b53 replicate the same operations: clear all VLANs and set their ports to the default VLAN tag (1 for these devices) so export the b53 function doing just that. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 6 --

Re: v6/sit tunnels and VRFs

On 10/27/17 2:59 PM, Jeff Barnhill wrote: > w/regards to this comment: >You have a remote address with no qualification about which VRF to > use for the lookup. > > I was using this to enslave the tunnel: > sudo ip link set jtun vrf myvrf > > and assumed this would be enough to cause all

intel i40e buggy driver question

Hi I have many problems with 40e driver memleaks , kernel panics , stack traces , tx hungx , tx timeouts and many many others :) But the main problem that can't be resolved in linux is resolved in freebsd problem in freebsd with this: [2501243.181829] i40e :01:00.1 eno2: VSI_seid

[RFC] please clarify local_irq_disable() in pcpu_freelist_populate()

Hi, while looking at other things here I stumbled at this in kernel/bpf/percpu_freelist.c: |void pcpu_freelist_populate(struct pcpu_freelist *s, void *buf, u32 elem_size, |u32 nr_elems) |{ … |/* disable irq to workaround lockdep false positive | * in

Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

This doesn't make sense to me, maybe I am missing something. What "real device" is setting the skb->destructor() and doing it to somehow handle recycling? The only driver I can find that is setting skb->desctructor() is the Chelsio drivers, and they appear to be using it to just clean-up DMA

Re: [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Add programming descriptors to cleaned_count

from today it is in net.git https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/log/?qt=grep=i40e It will be later in net-next Also can You please tell me what firmware You are using with Your nics ? Those are X710 ? Thanks Paweł W dniu 2017-10-27 o 23:20, Pavlos Parissis

Re: [PATCH v2] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

Quoting Steffen Klassert : On Thu, Oct 26, 2017 at 06:31:35AM -0500, Gustavo A. R. Silva wrote: Use BUG_ON instead of if condition followed by BUG. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva

Re: [PATCH net-next 1/1] net sched qdisc: pass netlink message flags in event notification

On Thu, Oct 26, 2017 at 2:40 PM, Roman Mashak wrote: > Userland client should be able to read an event, and reflect it back to > the kernel, therefore it needs to extract complete set of netlink flags. > > For example, this will allow "tc monitor" to distinguish Add and Replace

Re: [PATCH net] sctp: reset owner sk for data chunks on out queues when migrating a sock

On Sat, Oct 28, 2017 at 02:13:29AM +0800, Xin Long wrote: > Now when migrating sock to another one in sctp_sock_migrate(), it only > resets owner sk for the data in receive queues, not the chunks on out > queues. > > It would cause that data chunks length on the sock is not consistent > with sk

Re: [PATCH net-next v2 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

On Fri, Oct 27, 2017 at 1:49 PM, Manish Kurup wrote: > static inline u32 tcf_vlan_action(const struct tc_action *a) > { > - return to_vlan(a)->tcfv_action; > + u32 tcfv_action; > + > + rcu_read_lock(); > + tcfv_action =

[PATCH net-next] liquidio: get rid of false alarm "Unknown cmd 27" in dmesg

Creating a macvtap interface with the liquidio VF driver as lower device causes this alarming message to show up in dmesg: liquidio_link_ctrl_cmd_completion Unknown cmd 27 That's actually a false alarm because cmd 27 is the value of the macro OCTNET_CMD_SET_UC_LIST which is known. It's a

Re: [PATCH net-next v4 02/10] devlink: Adding SR-IOV enablement perm config param

On Fri, Oct 27, 2017 at 5:06 PM, Jiri Pirko wrote: > Fri, Oct 27, 2017 at 10:54:06PM CEST, steven.l...@broadcom.com wrote: >>Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config >>parameter. Value is permanent, so becomes the new default > > Avoid the double space. Ok. >

Re: [PATCH net-next v4 01/10] devlink: Add permanent config parameter get/set operations

On Fri, Oct 27, 2017 at 5:04 PM, Jiri Pirko wrote: > Fri, Oct 27, 2017 at 10:54:05PM CEST, steven.l...@broadcom.com wrote: >>Add support for permanent config parameter get/set commands. Used >>for persistent device configuration parameters. >> >>Signed-off-by: Steve Lin

Re: [Intel-wired-lan] [jkirsher/net-queue PATCH] i40e: Add programming descriptors to cleaned_count

On 23 October 2017 at 01:15, Paweł Staszewski wrote: > Yes can confirm that after adding patch: > > [jkirsher/net-queue PATCH] i40e: Add programming descriptors to > cleaned_count > > > There is no memleak. > > Somehow this patch isn't present in the current net-next repo.

Re: KASAN: use-after-free Read in get_work_pool

On Thu, Oct 26, 2017 at 11:00 PM, Dmitry Vyukov wrote: > On Thu, Oct 26, 2017 at 7:58 PM, Tejun Heo wrote: >> Hello, >> >> On Thu, Oct 26, 2017 at 09:35:44AM -0700, syzbot wrote: >>> BUG: KASAN: use-after-free in __read_once_size >>>

Re: [PATCH net-next v4 02/10] devlink: Adding SR-IOV enablement perm config param

Fri, Oct 27, 2017 at 10:54:06PM CEST, steven.l...@broadcom.com wrote: >Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config >parameter. Value is permanent, so becomes the new default Avoid the double space. >value for this device. > > DEVLINK_PERM_CONFIG_DISABLE = Disable SR-IOV >

Re: [PATCH net-next v4 01/10] devlink: Add permanent config parameter get/set operations

Fri, Oct 27, 2017 at 10:54:05PM CEST, steven.l...@broadcom.com wrote: >Add support for permanent config parameter get/set commands. Used >for persistent device configuration parameters. > >Signed-off-by: Steve Lin >Acked-by: Andy Gospodarek >--- >

Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

On Fri, Oct 27, 2017 at 1:30 PM, Subash Abhinov Kasiviswanathan wrote: > For deaggregation, the real device receives a large linear skb and > passes it on to rmnet. rmnet creates new skbs from this large frame. > > If the real device supports recycling, it does not need

Re: v6/sit tunnels and VRFs

w/regards to this comment: You have a remote address with no qualification about which VRF to use for the lookup. I was using this to enslave the tunnel: sudo ip link set jtun vrf myvrf and assumed this would be enough to cause all tunnel traffic to be part of this VRF. You are right about

Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

On 10/27/17 1:38 PM, Alban Crequy wrote: Hi, On 25 October 2017 at 01:57, Song Liu wrote: This tracepoint can be used to trace synack retransmits. It maintains pointer to struct request_sock. We cannot simply reuse trace_tcp_retransmit_skb() here, because the sk here

[PATCH net-next v4 06/10] bnxt: Add devlink support for config get/set

Implements get and set of configuration parameters using new devlink config get/set API. Parameters themselves defined in later patches. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 258

[PATCH net-next v4 01/10] devlink: Add permanent config parameter get/set operations

Add support for permanent config parameter get/set commands. Used for persistent device configuration parameters. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/net/devlink.h| 7 ++ include/uapi/linux/devlink.h | 25

[PATCH net-next v4 05/10] devlink: Adding num MSI-X vectors per VF perm config param

Adding DEVLINK_PERM_CONFIG_NUM_MSIX_VECT_PER_VF permanent config parameter. Value is permanent, so becomes the new default value for this device. Value defines number of MSI-X vectors allocated per VF. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

[PATCH net-next v4 07/10] bnxt: Adding SR-IOV enablement permanent cfg param

Adding permanent config parameter for SR-IOV enablement, using devlink API for get/set operation. DEVLINK_PERM_CONFIG_DISABLE = SR-IOV disabled DEVLINK_PERM_CONFIG_ENABLE = SR-IOV enabled Signed-off-by: Steve Lin Acked-by: Andy Gospodarek ---

[PATCH net-next v4 10/10] bnxt: Adding num MSI-X vectors per VF perm config param

Adding permanent config parameter for number MSI-X vectors per VF, using devlink API for get/set operation. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4

[PATCH net-next v4 08/10] bnxt: Adding num VFs per PF perm config param

Adding permanent config parameter for number of VFs per PF, using devlink API for get/set operation. Value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek ---

[PATCH net-next v4 09/10] bnxt: Adding max PF MSI-X vectors perm config param

Adding permanent config parameter for maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH net-next v4 04/10] devlink: Adding max PF MSI-X vectors perm config param

Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config parameter. Value is permanent, so becomes the new default value for this device. Value sets the maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

[PATCH net-next v4 03/10] devlink: Adding num VFs per PF permanent config param

Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config parameter. Value is permanent, so becomes the new default value for this device. The value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

[PATCH net-next v4 00/10] Adding permanent config get/set to devlink

Changes since v3: * Using union instead of void * to pass parameter values to/from drivers. * Updated parameter comments / naming and added enum for enable/disable to add clarity. * Various code cleanup in bnxt: - change hwrm call to use mutex protected version - use roundup() macro -

[PATCH net-next v4 02/10] devlink: Adding SR-IOV enablement perm config param

Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config parameter. Value is permanent, so becomes the new default value for this device. DEVLINK_PERM_CONFIG_DISABLE = Disable SR-IOV DEVLINK_PERM_CONFIG_ENABLE = Enable SR-IOV Signed-off-by: Steve Lin Acked-by:

[PATCH net-next v2 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by:

[PATCH net-next v2 1/2] net sched act_vlan: Change stats update to use per-core stats

The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko

[PATCH net-next v2 0/2] Completed requested changes

Hi everyone, Apologies for the resend (newbie mistakes), but I made the following corrections to the cover letter and patches: * Added version and comment info to subjects of patches and all the changes (below). I used v2, since my earlier mails had no versions. * Added ACKs from Jamal and Jiri

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

On Wed, Oct 25, 2017 at 10:37 PM, Yuchung Cheng wrote: > On Wed, Oct 25, 2017 at 7:07 PM, Alexei Starovoitov > wrote: >> >> On Thu, Sep 28, 2017 at 04:36:58PM -0700, Yuchung Cheng wrote: >> > On Thu, Sep 28, 2017 at 1:14 AM, Oleksandr Natalenko >>

Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

Hi, On 25 October 2017 at 01:57, Song Liu wrote: > This tracepoint can be used to trace synack retransmits. It maintains > pointer to struct request_sock. > > We cannot simply reuse trace_tcp_retransmit_skb() here, because the > sk here is the LISTEN socket. The IP

[PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

For deaggregation, the real device receives a large linear skb and passes it on to rmnet. rmnet creates new skbs from this large frame. If the real device supports recycling, it does not need to allocate the large skbs during packet reception and can instead reuse them. Signed-off-by: Subash

[PATCH] can: Use common error handling code in vxcan_newlink()

From: Markus Elfring Date: Fri, 27 Oct 2017 22:22:24 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Adjust two condition checks. This issue was detected by using the Coccinelle software.

Re: [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

Hi David, Quoting David Ranch : Hello Gustavo, I appreciate you working on keeping up the kernel and maintaining some of the older feature areas like AX.25, Netrom, etc. Other than auditing your code changes, can you tell me what you're changing? I've been

[PATCH net-next 5/7] net: dsa: get master device at port parsing time

Fetching the master device can be done directly when a port is parsed from device tree or pdata, instead of waiting until dsa_dst_parse. Now that -EPROBE_DEFER is returned before we add the switch to the tree, there is no need to check for this error after dsa_dst_parse. Signed-off-by: Vivien

Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

On 10/26/17 10:06 PM, Song Liu wrote: On Oct 26, 2017, at 7:01 PM, Cong Wang wrote: On Thu, Oct 26, 2017 at 4:50 PM, Song Liu wrote: In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which generates warnings like:

[PATCH net-next 1/7] net: dsa: get ports within parsing code

There is no point into hiding the -EINVAL error code in ERR_PTR from a dsa_get_ports function, simply get the "ports" node directly from within the dsa_parse_ports_dn function. This also has the effect to make the pdata and device tree handling code symmetrical inside _dsa_register_switch. At

[PATCH net-next 7/7] net: dsa: remove name arg from slave create

Now that slave dsa_port always have their name set, there is no need to pass it to dsa_slave_create() anymore. Remove this argument. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 3 +-- net/dsa/dsa_priv.h | 2 +- net/dsa/legacy.c | 2 +-

[PATCH net-next 0/7] net: dsa: add port parsing functions

This patchset adds port parsing functions called early in the new bindings parsing stage, which regroup all the fetching of static data available at the port level, including the port's type, name and CPU master interface. This simplifies the rest of the code which does not need to dig into

[PATCH net-next 2/7] net: dsa: add port parse functions

Add symmetrical DSA port parsing functions for pdata and device tree, used to parse and validate a given port node or platform data. They don't do much for the moment but will be extended later on to assign a port type and get device references. Signed-off-by: Vivien Didelot

[PATCH net-next 4/7] net: dsa: check master device before put

In the case of pdata, the dsa_cpu_parse function calls dev_put() before making sure it isn't NULL. Fix this. Fixes: 71e0bbde0d88 ("net: dsa: Add support for platform data") Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli ---

[PATCH net-next 3/7] net: dsa: get port type at parse time

Assign a port's type at parsed time instead of waiting for the tree to be completed. Because this is now done earlier, we can use the port's type in dsa_port_is_* helpers instead of digging again in topology description. Signed-off-by: Vivien Didelot ---

[PATCH net-next 6/7] net: dsa: get port name at parse time

Get the optional "label" property and assign a default one directly at parse time instead of doing it when creating the slave. For legacy, simply assign the port name stored in cd->port_names. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 10

Re: [net PATCH 2/2] bpf: rename sk_actions to align with bpf infrastructure

On Fri, Oct 27, 2017 at 09:45:53AM -0700, John Fastabend wrote: > Recent additions to support multiple programs in cgroups impose > a strict requirement, "all yes is yes, any no is no". To enforce > this the infrastructure requires the 'no' return code, SK_DROP in > this case, to be 0. > > To

Re: [net PATCH 1/2] bpf: bpf_compute_data uses incorrect cb structure

On Fri, Oct 27, 2017 at 09:45:34AM -0700, John Fastabend wrote: > SK_SKB program types use bpf_compute_data to store the end of the > packet data. However, bpf_compute_data assumes the cb is stored in the > qdisc layer format. But, for SK_SKB this is the wrong layer of the > stack for this type. >

[PATCH net-next] hv_netvsc: Set tx_table to equal weight after subchannels open

From: Haiyang Zhang In some cases, like internal vSwitch, the host doesn't provide send indirection table updates. This patch sets the table to be equal weight after subchannels are all open. Otherwise, all workload will be on one TX channel. As tested, this patch has

  1   2   3   >