Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-11-11 Thread Alexei Starovoitov
On 11/11/17 4:14 PM, Ingo Molnar wrote: * Josef Bacik wrote: On Fri, Nov 10, 2017 at 10:34:59AM +0100, Ingo Molnar wrote: * Josef Bacik wrote: @@ -551,6 +578,10 @@ static const struct bpf_func_proto *kprobe_prog_func_proto(enum bpf_func_id

Re: [PATCH iproute2 2/2] devlink: add batch command support

2017-11-11 Thread Jiri Pirko
Fri, Nov 10, 2017 at 07:20:14AM CET, ivec...@redhat.com wrote: >The patch adds support to batch devlink commands. > >Cc: Jiri Pirko >Cc: Arkadi Sharshevsky >Signed-off-by: Ivan Vecera Acked-by: Jiri Pirko Thanks!

Re: [PATCH iproute2 2/2] devlink: add batch command support

2017-11-11 Thread Jiri Pirko
Fri, Nov 10, 2017 at 08:47:35PM CET, l...@kernel.org wrote: >On Fri, Nov 10, 2017 at 08:10:43AM +0100, Ivan Vecera wrote: >> On 10.11.2017 07:57, Leon Romanovsky wrote: >> > On Fri, Nov 10, 2017 at 07:20:14AM +0100, Ivan Vecera wrote: >> >> The patch adds support to batch devlink commands. >> >>

Re: gpl-only change on bpf_setsockopt

2017-11-11 Thread Alexei Starovoitov
On Sat, Nov 11, 2017 at 08:17:37PM -0700, David Ahern wrote: > Hi Lawrence: > > I noticed that commit cd86d1fd21025 ("bpf: Adding helper function > bpf_getsockops") changed the gpl_only on bpf_setsockopt. The commit log > does not specify why. Is there any reason you changed it and made both >

gpl-only change on bpf_setsockopt

2017-11-11 Thread David Ahern
Hi Lawrence: I noticed that commit cd86d1fd21025 ("bpf: Adding helper function bpf_getsockops") changed the gpl_only on bpf_setsockopt. The commit log does not specify why. Is there any reason you changed it and made both bpf_setsockopt and bpf_getsockopt available for non-gpl programs? David

Re: [net-next:master 488/665] verifier.c:undefined reference to `__multi3'

2017-11-11 Thread Florian Fainelli
Le 11/11/17 à 17:34, Fengguang Wu a écrit : > On Sun, Nov 12, 2017 at 09:23:52AM +0800, Alexei Starovoitov wrote: >> On 11/12/17 9:18 AM, Fengguang Wu wrote: >>> On Sun, Nov 12, 2017 at 09:14:14AM +0800, Alexei Starovoitov wrote: On 11/12/17 8:23 AM, kbuild test robot wrote: > tree: >

Re: [net-next:master 488/665] verifier.c:undefined reference to `__multi3'

2017-11-11 Thread Fengguang Wu
On Sun, Nov 12, 2017 at 09:23:52AM +0800, Alexei Starovoitov wrote: On 11/12/17 9:18 AM, Fengguang Wu wrote: On Sun, Nov 12, 2017 at 09:14:14AM +0800, Alexei Starovoitov wrote: On 11/12/17 8:23 AM, kbuild test robot wrote: tree:

[net-next:master 488/665] verifier.c:undefined reference to `__multi3'

2017-11-11 Thread Fengguang Wu
CC gcc list. According to Alexei: This is a known issue with gcc 7 on mips that is "optimizing" normal 64-bit multiply into 128-bit variant. Nothing to fix on the kernel side. Digging further, this function was added to arch/sparc/lib/multi3.S

Re: [net-next:master 488/665] verifier.c:undefined reference to `__multi3'

2017-11-11 Thread Alexei Starovoitov
On 11/12/17 9:18 AM, Fengguang Wu wrote: On Sun, Nov 12, 2017 at 09:14:14AM +0800, Alexei Starovoitov wrote: On 11/12/17 8:23 AM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7c5556decd0a629e9ee02e93653f75ba7b7da03c commit:

Re: [net-next:master 488/665] verifier.c:undefined reference to `__multi3'

2017-11-11 Thread Fengguang Wu
On Sun, Nov 12, 2017 at 09:14:14AM +0800, Alexei Starovoitov wrote: On 11/12/17 8:23 AM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7c5556decd0a629e9ee02e93653f75ba7b7da03c commit: 638f5b90d46016372a8e3e0a434f199cc5e12b8c

Re: [net-next:master 488/665] verifier.c:undefined reference to `__multi3'

2017-11-11 Thread Alexei Starovoitov
On 11/12/17 8:23 AM, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7c5556decd0a629e9ee02e93653f75ba7b7da03c commit: 638f5b90d46016372a8e3e0a434f199cc5e12b8c [488/665] bpf: reduce verifier memory consumption config:

[net-next:master 488/665] verifier.c:undefined reference to `__multi3'

2017-11-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 7c5556decd0a629e9ee02e93653f75ba7b7da03c commit: 638f5b90d46016372a8e3e0a434f199cc5e12b8c [488/665] bpf: reduce verifier memory consumption config: mips-64r6el_defconfig (attached as .config) compiler:

Re: [PATCH] ethernet: cavium: octeon: Switch to using netdev_info().

2017-11-11 Thread Joe Perches
On Wed, 2017-10-25 at 14:41 +0800, kbuild test robot wrote: > Hi Steven, > > [auto build test WARNING on net-next/master] > [also build test WARNING on v4.14-rc6] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

[PATCH net-next 1/3] bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics

2017-11-11 Thread Yonghong Song
For helpers, the argument type ARG_CONST_SIZE_OR_ZERO permits the access size to be 0 when accessing the previous argument (arg). Right now, it requires the arg needs to be NULL when size passed is 0 or could be 0. It also requires a non-NULL arg when the size is proved to be non-0. This patch

[PATCH net-next 2/3] bpf: change helper bpf_probe_read arg2 type to ARG_CONST_SIZE_OR_ZERO

2017-11-11 Thread Yonghong Song
The helper bpf_probe_read arg2 type is changed from ARG_CONST_SIZE to ARG_CONST_SIZE_OR_ZERO to permit size-0 buffer. Together with newer ARG_CONST_SIZE_OR_ZERO semantics which allows non-NULL buffer with size 0, this allows simpler bpf programs with verifier acceptance. The prvious commit which

[PATCH net-next 0/3] bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics

2017-11-11 Thread Yonghong Song
This patch set intends to change verifier ARG_CONST_SIZE_OR_ZERO semantics so that simpler bpf programs can be written with verifier acceptance. Patch #1 comment provided the detailed examples and the patch itself implements the new semantics. Patch #2 changes bpf_probe_read helper arg2 type from

[PATCH net-next 3/3] bpf: fix and add test cases for ARG_CONST_SIZE_OR_ZERO semantics change

2017-11-11 Thread Yonghong Song
Fix a few test cases to allow non-NULL map/packet/stack pointer with size = 0. Change a few tests using bpf_probe_read to use bpf_probe_write_user so ARG_CONST_SIZE arg can still be properly tested. One existing test case already covers size = 0 with non-NULL packet pointer, so add additional

[PATCH v2 net-next] tcp: allow drivers to tweak TSQ logic

2017-11-11 Thread Eric Dumazet
From: Eric Dumazet I had many reports that TSQ logic breaks wifi aggregation. Current logic is to allow up to 1 ms of bytes to be queued into qdisc and drivers queues. But Wifi aggregation needs a bigger budget to allow bigger rates to be discovered by various TCP

Re: [net-next] tcp: allow drivers to tweak TSQ logic

2017-11-11 Thread Eric Dumazet
On Sat, 2017-11-11 at 15:27 +0100, Johannes Berg wrote: > Thanks Eric! > > > We expect wifi drivers to set this field to smaller values (tests have > > been done with values from 6 to 9) > > I suppose we should test each driver or so. > > > They would have to use following template : > > > >

Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-11 Thread Kirill A. Shutemov
On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote: > Currently we are leaking addresses from the kernel to user space. This > script is an attempt to find some of those leakages. Script parses > `dmesg` output and /proc and /sys files for hex strings that look like > kernel

Re: [PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

2017-11-11 Thread Alexei Starovoitov
On 11/12/17 4:46 AM, Daniel Borkmann wrote: On 11/11/2017 05:06 AM, Alexei Starovoitov wrote: On 11/11/17 6:07 AM, Daniel Borkmann wrote: On 11/10/2017 08:17 PM, Vlad Dumitrescu wrote: From: Vlad Dumitrescu Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority.

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-11 Thread Matthew Rosato
>> This case should be quite similar with pkgten, if you got improvement with >> pktgen, usually it was also the same for UDP, could you please try to disable >> tso, gso, gro, ufo on all host tap devices and guest virtio-net devices? >> Currently >> the most significant tests would be like this

Re: [PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

2017-11-11 Thread Daniel Borkmann
On 11/11/2017 05:06 AM, Alexei Starovoitov wrote: On 11/11/17 6:07 AM, Daniel Borkmann wrote: On 11/10/2017 08:17 PM, Vlad Dumitrescu wrote: From: Vlad Dumitrescu Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority. Signed-off-by: Vlad Dumitrescu

DIRECTOR IN CHARGE: DR.PATRICE TEME

2017-11-11 Thread United Nations
UN Visitor Centre Department of Public Information United Nations Headquarters Room DHL-1B-154 New York, NY 10017 E-mail:un...@teewars.org United Nations Compensation Unit, In Affiliation with World Bank Our Ref: UN/WBO/042UK/2015. Congratulations Beneficiary, How are you today Hope all is

[PATCH net-next 2/3] rxrpc: Fix a null ptr deref in rxrpc_fill_out_ack()

2017-11-11 Thread David Howells
rxrpc_fill_out_ack() needs to be passed the connection pointer from its caller rather than using call->conn as the call may be disconnected in parallel with it, clearing call->conn, leading to: BUG: unable to handle kernel NULL pointer dereference at 0010 IP:

[PATCH net-next 0/3] rxrpc: Fixes

2017-11-11 Thread David Howells
with call expiration. The patches can be found here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next-2017 David --- David Howells (3

[PATCH net-next 1/3] rxrpc: Lock around calling a kernel service Rx notification

2017-11-11 Thread David Howells
Place a spinlock around the invocation of call->notify_rx() for a kernel service call and lock again when ending the call and replace the notification pointer with a pointer to a dummy function. This is required because it's possible for rxrpc_notify_socket() to be called after the call has been

[PATCH net-next 3/3] rxrpc: Fix call expiry handling

2017-11-11 Thread David Howells
Fix call expiry handling in the following ways (1) If all the request data from a client call is acked, don't send a follow up IDLE ACK with firstPacket == 1 and previousPacket == 0 as this appears to fool some servers into thinking everything has been accepted. (2) Never send

( United Nations Compensation Unit )

2017-11-11 Thread United Nations
United Nations Compensation Unit, In Affiliation with World Bank Our Ref: U.N.O/W.B.O/11/11/2017/1982/09/05. Congratulations Beneficiary, We have been working closely with the INTERPOL, CIA, FBI and other foreign international organizations as well as Western Union and Money Gram regarding

[PATCH] wcn36xx: fix iris child-node lookup

2017-11-11 Thread Johan Hovold
Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mmio node was also prematurely freed. Fixes: fd52bdae9ab0 ("wcn36xx: Disable 5GHz for wcn3620") Cc:

MUTUAL COPERATION THANK YOU

2017-11-11 Thread Auditor Mr Obama Bassole.
Dear Friend, I know that this message will come to you as a surprise. I am the Auditing and Accounting section manager with African Development Bank, Ouagadougou Burkina faso. I Hope that you will not expose or betray this trust and confident that I am about to repose on you for the mutual

Re: [PATCH net-next 4/4] net: dsa: b53: Support prepended Broadcom tags

2017-11-11 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 03:22:55PM -0800, Florian Fainelli wrote: > On BCM58xx devices (Northstar Plus), there is an accelerator attached to > port 8 which would only work if we use prepended Broadcom tags. Resolve > that difference in our get_tag_protocol() function by setting the > appropriate

Re: [PATCH net-next 3/4] net: dsa: Support prepended Broadcom tag

2017-11-11 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 03:22:54PM -0800, Florian Fainelli wrote: > Add a new type: DSA_TAG_PROTO_PREPEND which allows us to support for the > 4-bytes Broadcom tag that we already support, but in a format where it > is pre-pended to the packet instead of located between the MAC SA and > the

Re: [PATCH net-next 2/4] net: dsa: tag_brcm: Prepare for supporting prepended tag

2017-11-11 Thread Andrew Lunn
> +static struct sk_buff *brcm_tag_rcv_ll(struct sk_buff *skb, > +struct net_device *dev, > +struct packet_type *pt, > +unsigned int offset) > { > int source_port; > u8

Re: [PATCH net-next 1/4] net: dsa: Pass a port to get_tag_protocol()

2017-11-11 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 03:22:52PM -0800, Florian Fainelli wrote: > A number of drivers want to check whether the configured CPU port is a > possible configuration for enabling tagging, pass down the CPU port > number so they verify that. > > -static bool b53_can_enable_brcm_tags(struct

[PATCHv3 1/1] bnx2x: fix slowpath null crash

2017-11-11 Thread Zhu Yanjun
When "NETDEV WATCHDOG: em4 (bnx2x): transmit queue 2 timed out" occurs, BNX2X_SP_RTNL_TX_TIMEOUT is set. In the function bnx2x_sp_rtnl_task, bnx2x_nic_unload and bnx2x_nic_load are executed to shutdown and open NIC. In the function bnx2x_nic_load, bnx2x_alloc_mem allocates dma failure. The message

Re: [run_timer_softirq] BUG: unable to handle kernel paging request at 0000000000010007

2017-11-11 Thread Fengguang Wu
On Fri, Nov 10, 2017 at 10:29:59PM +0100, Thomas Gleixner wrote: On Fri, 10 Nov 2017, Linus Torvalds wrote: On Wed, Nov 8, 2017 at 9:19 PM, Fengguang Wu wrote: > > Yes it's accessing the list. Here is the faddr2line output. Ok, so it's a corrupted timer list. Which is

[PATCH net-next] net: dsa: Fix dependencies on bridge

2017-11-11 Thread Andrew Lunn
DSA now uses one of the symbols exported by the bridge, br_vlan_enabled(). This has a stub, if the bridge is not enabled. However, if the bridge is enabled, we cannot have DSA built in and the bridge as a module, otherwise we get undefined symbols at link time: net/dsa/port.o: In function

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-11 Thread Jason A. Donenfeld
On Sat, Nov 11, 2017 at 11:18 PM, Johannes Berg wrote: > >> > If you're handling this by forcing another read() to procude the >> > NLMSG_DONE, then you have no reason to WARN_ON() here. >> > >> > In fact you are adding a WARN_ON() which is trivially triggerable by >> >

Re: [net-next:master 622/639] net/dsa/port.c:255: undefined reference to `br_vlan_enabled'

2017-11-11 Thread Andrew Lunn
On Sat, Nov 11, 2017 at 06:42:21PM +0900, David Miller wrote: > From: kbuild test robot > Date: Sat, 11 Nov 2017 16:57:08 +0800 > > > All errors (new ones prefixed by >>): > > > >net/dsa/port.o: In function `dsa_port_vlan_add': > >>> net/dsa/port.c:255: undefined

Re: [net-next] tcp: allow drivers to tweak TSQ logic

2017-11-11 Thread Johannes Berg
Thanks Eric! > We expect wifi drivers to set this field to smaller values (tests have > been done with values from 6 to 9) I suppose we should test each driver or so. > They would have to use following template : > > if (skb->sk && skb->sk->sk_pacing_shift != MY_PACING_SHIFT) >

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-11 Thread David Miller
From: Johannes Berg Date: Sat, 11 Nov 2017 15:15:21 +0100 > On Sat, 2017-11-11 at 23:09 +0900, David Miller wrote: >> From: "Jason A. Donenfeld" >> Date: Thu, 9 Nov 2017 13:04:44 +0900 >> >> > @@ -2195,13 +2197,15 @@ static int netlink_dump(struct

[PATCH net-next 0/2] cxgb4: collect LE-TCAM and SGE queue contexts

2017-11-11 Thread Rahul Lakkireddy
Collect hardware dumps via ethtool --get-dump facility. Patch 1 collects LE-TCAM dump. Patch 2 collects SGE queue context dumps. Thanks, Rahul Rahul Lakkireddy (2): cxgb4: collect LE-TCAM dump cxgb4: collect SGE queue context dump drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 38

[PATCH net-next 1/2] cxgb4: collect LE-TCAM dump

2017-11-11 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 30 drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c| 175

[PATCH net-next 2/2] cxgb4: collect SGE queue context dump

2017-11-11 Thread Rahul Lakkireddy
Collect SGE freelist queue and congestion manager contexts. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 8 +++ drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1 +

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-11 Thread Johannes Berg
> > If you're handling this by forcing another read() to procude the > > NLMSG_DONE, then you have no reason to WARN_ON() here. > > > > In fact you are adding a WARN_ON() which is trivially triggerable by > > any user. > > I added this in my suggestion for how this could work, but I don't >

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-11 Thread Johannes Berg
On Sat, 2017-11-11 at 23:09 +0900, David Miller wrote: > From: "Jason A. Donenfeld" > Date: Thu, 9 Nov 2017 13:04:44 +0900 > > > @@ -2195,13 +2197,15 @@ static int netlink_dump(struct sock *sk) > > return 0; > > } > > > > - nlh = nlmsg_put_answer(skb,

[GIT] Networking

2017-11-11 Thread David Miller
1) Use after free in vlan, from Cong Wang. 2) Handle NAPI poll with a zero budget properly in mlx5 driver, from Saeed Mahameed. 3) If DMA mapping fails in mlx5 driver, NULL out page, from Inbar Karmy. 4) Handle overrun in RX FIFO of sun4i CAN driver, from Gerhard Bertelsmann. 5)

Re: pull-request: wireless-drivers-next 2017-11-11

2017-11-11 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Sat, 11 Nov 2017 15:03:14 +0200 > >> some more patches to net-next for v4.15. Even though I applied the last >> patch only on Saturday morning, all these have been tested by kbuild bot >> and most of them

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-11 Thread David Miller
From: "Jason A. Donenfeld" Date: Thu, 9 Nov 2017 13:04:44 +0900 > @@ -2195,13 +2197,15 @@ static int netlink_dump(struct sock *sk) > return 0; > } > > - nlh = nlmsg_put_answer(skb, cb, NLMSG_DONE, sizeof(len), NLM_F_MULTI); > - if (!nlh) > +

Re: pull-request: wireless-drivers-next 2017-11-11

2017-11-11 Thread David Miller
From: Kalle Valo Date: Sat, 11 Nov 2017 15:03:14 +0200 > some more patches to net-next for v4.15. Even though I applied the last > patch only on Saturday morning, all these have been tested by kbuild bot > and most of them should also be in linux-next. Please let me know if

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-11 Thread Yafang Shao
2017-11-11 3:32 GMT+00:00 Steven Rostedt : > On Sat, 11 Nov 2017 02:06:00 + > Yafang Shao wrote: > >> 2017-11-10 15:07 GMT+00:00 Steven Rostedt : >> > On Fri, 10 Nov 2017 12:56:06 +0800 >> > Yafang Shao

Re: [PATCH] net: Remove unused skb_shared_info member

2017-11-11 Thread David Miller
From: Mat Martineau Date: Fri, 10 Nov 2017 14:03:51 -0800 > ip6_frag_id was only used by UFO, which has been removed. > ipv6_proxy_select_ident() only existed to set ip6_frag_id and has no > in-tree callers. > > Signed-off-by: Mat Martineau

Re: [PATCH net-next 0/3] l2tp: avoid aliasing tunnels socket pointer

2017-11-11 Thread David Miller
From: Guillaume Nault Date: Sat, 11 Nov 2017 06:06:23 +0900 > We don't need to copy the tunnel's socket pointer in the pseudo-wire > specific session structures. This uselessly complicates the code > and hampers evolution. > > This series was part of an effort to protect

pull-request: wireless-drivers-next 2017-11-11

2017-11-11 Thread Kalle Valo
Hi Dave, some more patches to net-next for v4.15. Even though I applied the last patch only on Saturday morning, all these have been tested by kbuild bot and most of them should also be in linux-next. Please let me know if there are any problems. Kalle The following changes since commit

Re: [PATCH net-next v3 0/3] net: dsa: b53: Turn on Broadcom tags

2017-11-11 Thread David Miller
From: Florian Fainelli Date: Fri, 10 Nov 2017 11:33:24 -0800 > Hi all, > > This was long overdue, with this patch series, the b53 driver now > turns on Broadcom tags except for 5325 and 5365 which use an older > format that we do not support yet (TBD). > > First patch is

Re: pull-request: can 2017-11-10

2017-11-11 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 10 Nov 2017 14:07:26 +0100 > this is a pull request for net/master. > > The first patch by Richard Schütz for the c_can driver removes the false > indication to support triple sampling for d_can. Gerhard Bertelsmann's > patch for the sun4i

Re: [PATCH net] vxlan: fix the issue that neigh proxy blocks all icmpv6 packets

2017-11-11 Thread Vincent Bernat
❦ 11 novembre 2017 19:58 +0800, Xin Long  : > Commit f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport > header offset") removed icmp6_code and icmp6_type check before calling > neigh_reduce when doing neigh proxy. > > It means all icmpv6 packets would be

Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling

2017-11-11 Thread David Miller
From: Egil Hjelmeland Date: Fri, 10 Nov 2017 12:54:33 +0100 > Set up the HW switch to trap IGMP packets to CPU port. > And make sure skb->offload_fwd_mark is cleared for incoming IGMP packets. > > skb->offload_fwd_mark calculation is a candidate for consolidation

Re: [PATCH RFC,WIP 5/5] netfilter: nft_flow_offload: add ndo hooks for hardware offload

2017-11-11 Thread Felix Fietkau
On 2017-11-03 16:26, Pablo Neira Ayuso wrote: > This patch adds the infrastructure to offload flows to hardware, in case > the nic/switch comes with built-in flow tables capabilities. > > If the hardware comes with not hardware flow tables or they have > limitations in terms of features, this

Re: [PATCH net-next] cxgb4: collect vpd info directly from hardware

2017-11-11 Thread David Miller
From: Rahul Lakkireddy Date: Fri, 10 Nov 2017 13:03:37 +0530 > Collect vpd information directly from hardware instead of software > adapter context. Move EEPROM physical address to virtual address > translation logic to t4_hw.c and update relevant files. > > Fixes:

Re: [PATCH net v3 00/12] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

2017-11-11 Thread David Miller
From: Finn Thain Date: Sat, 11 Nov 2017 01:20:58 -0500 (EST) > This patch series adds support for the Linux Driver Model for Mac NIC > drivers, fixes some logging bugs, removes dead code, and adopts netif_* > calls to reduce code duplication. > > All up, about 100

Re: [PATCH v2 net-next 1/3] netem: convert to qdisc_watchdog_schedule_ns

2017-11-11 Thread kbuild test robot
Hi Dave, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dave-Taht/netem-convert-to-qdisc_watchdog_schedule_ns/2017-184934 config: i386-randconfig-i1-201745 (attached as .config) compiler: gcc-6

Re: [PATCH v2 net-next 1/3] netem: convert to qdisc_watchdog_schedule_ns

2017-11-11 Thread kbuild test robot
Hi Dave, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dave-Taht/netem-convert-to-qdisc_watchdog_schedule_ns/2017-184934 config: xtensa-allyesconfig (attached as .config) compiler: xtensa

[PATCH net] vxlan: fix the issue that neigh proxy blocks all icmpv6 packets

2017-11-11 Thread Xin Long
Commit f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport header offset") removed icmp6_code and icmp6_type check before calling neigh_reduce when doing neigh proxy. It means all icmpv6 packets would be blocked by this, not only ns packet. In Jianlin's env, even ping6 couldn't

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-11-11 Thread Josef Bacik
On Sat, Nov 11, 2017 at 09:14:55AM +0100, Ingo Molnar wrote: > > * Josef Bacik wrote: > > > On Fri, Nov 10, 2017 at 10:34:59AM +0100, Ingo Molnar wrote: > > > > > > * Josef Bacik wrote: > > > > > > > @@ -551,6 +578,10 @@ static const struct

[PATCH net-next 5/5] ip6_tunnel: clean up ip4ip6 and ip6ip6's err_handlers

2017-11-11 Thread Xin Long
This patch is to remove some useless codes of redirect and fix some indents on ip4ip6 and ip6ip6's err_handlers. Note that redirect icmp packet is already processed in ip6_tnl_err, the old redirect codes in ip4ip6_err actually never worked even before this patch. Besides, there's no need to send

[PATCH net-next 3/5] ip6_tunnel: add the process for redirect in ip6_tnl_err

2017-11-11 Thread Xin Long
The same process for redirect in "ip6_gre: add the process for redirect in ip6gre_err" is needed by ip4ip6 and ip6ip6 as well. Signed-off-by: Xin Long --- net/ipv6/ip6_tunnel.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

[PATCH net-next 0/5] net: improve the process of redirect and toobig for ipv6 tunnels

2017-11-11 Thread Xin Long
Now let's say there are 3 kinds of icmp packets to process for tunnels, toobig(needfrag), redirect, others, their process should be: - toobig(needfrag) update the lower dst's pmtu by route cache, also update sk dst's pmtu if possible, or it will be fine if sk dst pmtu will get updated on

[PATCH net-next 4/5] ip6_tunnel: process toobig in a better way

2017-11-11 Thread Xin Long
The same improvement in "ip6_gre: process toobig in a better way" is needed by ip4ip6 and ip6ip6 as well. Note that ip4ip6 and ip6ip6 will also update sk dst pmtu in their err_handlers. Like I said before, gre6 could not do this as it's inner proto is not certain. But for all of them, sk dst pmtu

[PATCH net-next 1/5] ip6_gre: add the process for redirect in ip6gre_err

2017-11-11 Thread Xin Long
This patch is to add redirect icmp packet process for ip6gre by calling ip6_redirect() in ip6gre_err(), as in vti6_err. Prior to this patch, there's even no route cache generated after receiving redirect. Reported-by: Jianlin Shi Signed-off-by: Xin Long

[PATCH net-next 2/5] ip6_gre: process toobig in a better way

2017-11-11 Thread Xin Long
Now ip6gre processes toobig icmp packet by setting gre dev's mtu in ip6gre_err, which would cause few things not good: - It couldn't set mtu with dev_set_mtu due to it's not in user context, which causes route cache and idev->cnf.mtu6 not to be updated. - It has to update sk dst pmtu in

Re: [pull request][net V2 0/5] Mellanox, mlx5 fixes 2017-11-08

2017-11-11 Thread David Miller
From: Saeed Mahameed Date: Fri, 10 Nov 2017 15:50:15 +0900 > The follwoing series includes some fixes for mlx5 core and etherent > driver. > > Sorry for the late submission but as you can see i have some very > critical fixes below that i would like them merged into this

Re: [Patch net] vlan: fix a use-after-free in vlan_device_event()

2017-11-11 Thread David Miller
From: Cong Wang Date: Thu, 9 Nov 2017 16:43:13 -0800 > After refcnt reaches zero, vlan_vid_del() could free > dev->vlan_info via RCU: > > RCU_INIT_POINTER(dev->vlan_info, NULL); > call_rcu(_info->rcu, vlan_info_rcu_free); > > However, the pointer 'grp'

Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix stats histogram mode

2017-11-11 Thread David Miller
From: Andrew Lunn Date: Fri, 10 Nov 2017 00:36:41 +0100 > The statistics histogram mode was not being explicitly initialized on > devices other than the 6390 family. Clearing the statistics then > overwrote the default setting, setting the histogram to a reserved > mode. > >

Re: [PATCH v3 net-next 0/6] mv88e6xxx broadcast flooding in hardware

2017-11-11 Thread David Miller
From: Andrew Lunn Date: Thu, 9 Nov 2017 22:29:50 +0100 > This patchset makes the mv88e6xxx driver perform flooding in hardware, > rather than let the software bridge perform the flooding. This is a > prerequisite for IGMP snooping on the bridge interface. > > In order to make

Re: pull-request: net-next: ieee802154 2017-11-09

2017-11-11 Thread David Miller
From: Stefan Schmidt Date: Thu, 9 Nov 2017 18:12:49 +0100 > A small update on ieee802154 patches for net-next. Nothing dramatic, but > simply > housekeeping this time around. > A fix for the correct mask to be applied in the mrf24j40 driver by Gustavo A. > R. Silva >

Re: [PATCH net-next] bindings: net: stmmac: correctify note about LPI interrupt

2017-11-11 Thread David Miller
From: Niklas Cassel Date: Thu, 9 Nov 2017 18:09:26 +0100 > There are two different combined signal for various interrupt events: > In EQOS-CORE and EQOS-MTL configurations, mci_intr_o is the interrupt > signal. > In EQOS-DMA, EQOS-AHB and EQOS-AXI configurations, these

Re: [PATCH] ipvlan: fix ipv6 outbound device

2017-11-11 Thread David Miller
From: Date: Thu, 9 Nov 2017 20:09:31 +0800 > From: Keefe Liu > > When process the outbound packet of ipv6, we should assign the master > device to output device other than input device. > > Signed-off-by: Keefe Liu Applied.

Re: [PATCH net-next] net: thunderx: fix double free error

2017-11-11 Thread David Miller
From: Aleksey Makarov Date: Thu, 9 Nov 2017 14:58:57 +0300 > This patch fixes an error in memory allocation/freeing in > ThunderX PF driver. > > I moved the allocation to the probe() function and made it managed. > > From the Colin's email: > > While running

Re: [PATCH net-next] net: thunderbolt: Clear finished Tx frame bus address in tbnet_tx_callback()

2017-11-11 Thread David Miller
From: Mika Westerberg Date: Thu, 9 Nov 2017 13:46:28 +0300 > When Thunderbolt network interface is disabled or when the cable is > unplugged the driver releases all allocated buffers by calling > tbnet_free_buffers() for each ring. This function then calls >

Re: [PATCH] netdev: add netdev_pagefrag_enabled sysctl

2017-11-11 Thread David Miller
From: Hongbo Li Date: Thu, 9 Nov 2017 16:12:27 +0800 > From: Hongbo Li > > This patch solves a memory frag issue when allocating skb. > I found this issue in a udp scenario, here is my test model: > 1. About five hundreds udp threads listen

Re: [PATCH] sock: Remove the global prot_inuse counter.

2017-11-11 Thread David Miller
From: Tonghao Zhang Date: Thu, 9 Nov 2017 00:03:15 -0800 > The per-cpu counter for init_net is prepared in core_initcall. > The patch 7d720c3e ("percpu: add __percpu sparse annotations to net") > and d6d9ca0fe ("net: this_cpu_xxx conversions") optimize the > routines.

Re: [PATCH] net: sfc: remove redundant variable start

2017-11-11 Thread David Miller
From: Colin King Date: Thu, 9 Nov 2017 08:01:22 + > From: Colin Ian King > > Variable start is assigned but never read hence it is redundant > and can be removed. Cleans up clang warning: > > drivers/net/ethernet/sfc/ptp.c:655:2:

Re: [PATCH] qlge: remove duplicated assignment to mbcp

2017-11-11 Thread David Miller
From: Colin King Date: Thu, 9 Nov 2017 07:52:15 + > From: Colin Ian King > > The assignment to mbcp is identical to the initiatialized value assigned > to mbcp at declaration time a few lines earlier, hence we can remove the > second

Re: [PATCH] net: 3com: 3c574_cs: mark expected switch fall-through

2017-11-11 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 8 Nov 2017 21:49:33 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114888 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] net: 8390: pcnet_cs: mark expected switch fall-through

2017-11-11 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 8 Nov 2017 21:44:38 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114891 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] net: decnet: dn_table: mark expected switch fall-through

2017-11-11 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 8 Nov 2017 21:38:28 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 115106 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] net: wan: x25_asy: mark expected switch fall-through

2017-11-11 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 8 Nov 2017 22:25:08 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114928 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

2017-11-11 Thread David Miller
From: William Tu Date: Wed, 8 Nov 2017 16:13:02 -0800 > +static void erspan_build_header(struct sk_buff *skb, > + __be32 id, u32 index, > + bool truncate, bool is_ipv4) > +{ Please do not put large non-inline functions

Re: [PATCH net-next] l2tp: don't close sessions in l2tp_tunnel_destruct()

2017-11-11 Thread David Miller
From: Guillaume Nault Date: Thu, 9 Nov 2017 08:29:52 +0900 > Sessions are already removed by the proto ->destroy() handlers, and > since commit f3c66d4e144a ("l2tp: prevent creation of sessions on terminated > tunnels"), > we're guaranteed that no new session can be

Re: [PATCH net-next 0/2] remove FACK loss recovery

2017-11-11 Thread David Miller
From: Yuchung Cheng Date: Wed, 8 Nov 2017 13:01:25 -0800 > This patch set removes the forward-acknowledgment (FACK) > packet-based loss and reordering detection. This simplifies TCP > loss recovery since the SACK scoreboard no longer needs to track > the number of pending

Re: [PATCH] fsl/fman_port: mark expected switch fall-throughs

2017-11-11 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 8 Nov 2017 11:57:13 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1397960 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] net: ethernet: bgmac: mark expected switch fall-through

2017-11-11 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 8 Nov 2017 11:24:57 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1397972 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH net-next] ibmvnic: Add vnic client data to login buffer

2017-11-11 Thread David Miller
From: Nathan Fontenot Date: Wed, 08 Nov 2017 11:23:56 -0600 > Update the login buffer to include client data for the vnic driver, > this includes the OS name, LPAR name, and device name. This update > alolows thius information to be available in the VIOS. ^^^

Re: [PATCH] net: mvneta: fix handling of the Tx descriptor counter

2017-11-11 Thread David Miller
From: Simon Guinot Date: Wed, 8 Nov 2017 17:58:35 +0100 > @@ -2413,8 +2416,7 @@ static int mvneta_tx(struct sk_buff *skb, struct > net_device *dev) > if (txq->count >= txq->tx_stop_threshold) > netif_tx_stop_queue(nq); > > -

Re: [net-next:master 622/639] net/dsa/port.c:255: undefined reference to `br_vlan_enabled'

2017-11-11 Thread David Miller
From: kbuild test robot Date: Sat, 11 Nov 2017 16:57:08 +0800 > All errors (new ones prefixed by >>): > >net/dsa/port.o: In function `dsa_port_vlan_add': >>> net/dsa/port.c:255: undefined reference to `br_vlan_enabled' >net/dsa/port.o: In function

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-11 Thread David Miller
From: Ingo Molnar Date: Sat, 11 Nov 2017 09:16:00 +0100 > Please don't apply it yet as the series is still under active > discussion - for now Fine, reverted.

[net-next:master 622/639] net/dsa/port.c:255: undefined reference to `br_vlan_enabled'

2017-11-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: bee955cd3ab4f1a1eb8fc16e7ed69364143df8d7 commit: 2ea7a679ca2abd251c1ec03f20508619707e1749 [622/639] net: dsa: Don't add vlans when vlan filtering is disabled config: x86_64-randconfig-s2-1208 (attached

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-11 Thread Ingo Molnar
* David Miller wrote: > From: Josef Bacik > Date: Tue, 7 Nov 2017 15:28:41 -0500 > > > I'm sending this through Dave since it'll conflict with other BPF changes > > in his > > tree, but since it touches tracing as well Dave would like a review from

  1   2   >