Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

2017-11-12 Thread Jiri Pirko
Mon, Nov 13, 2017 at 08:47:26AM CET, jakub.kicin...@netronome.com wrote: >On Sun, 12 Nov 2017 16:55:58 +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Couple of classifiers call netif_keep_dst directly on q->dev. That is >> not possible to do directly for shared blocke

Re: [patch net-next v2 06/10] net: sched: allow ingress and clsact qdiscs to share filter blocks

2017-11-12 Thread Jiri Pirko
Mon, Nov 13, 2017 at 08:54:52AM CET, jakub.kicin...@netronome.com wrote: >On Sun, 12 Nov 2017 16:56:00 +0100, Jiri Pirko wrote: >> diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c >> index 5ecc38f..ee89efc 100644 >> --- a/net/sched/sch_ingress.c >> +++ b/net/sched/sch_ingress.c >> @@

Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

2017-11-12 Thread Jiri Pirko
Mon, Nov 13, 2017 at 08:17:34AM CET, jakub.kicin...@netronome.com wrote: >On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicin...@netronome.com wrote: >> >On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: >> >> From: Jiri Pirko

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

2017-11-12 Thread Peter Zijlstra
On Mon, Nov 13, 2017 at 08:21:59AM +0100, Florian Westphal wrote: > Reason is that some places do this: > > rtnl_register(pf, RTM_FOO, doit, NULL, 0); > rtnl_register(pf, RTM_FOO, NULL, dumpit, 0); Sure, however, > (from different call sites in the stack). > > - if (doit) > > -

Re: [patch net-next v2 06/10] net: sched: allow ingress and clsact qdiscs to share filter blocks

2017-11-12 Thread Jakub Kicinski
On Sun, 12 Nov 2017 16:56:00 +0100, Jiri Pirko wrote: > diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c > index 5ecc38f..ee89efc 100644 > --- a/net/sched/sch_ingress.c > +++ b/net/sched/sch_ingress.c > @@ -60,6 +60,29 @@ static void clsact_chain_head_change(struct tcf_proto >

Re: [patch net-next v2 04/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

2017-11-12 Thread Jakub Kicinski
On Sun, 12 Nov 2017 16:55:58 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Couple of classifiers call netif_keep_dst directly on q->dev. That is > not possible to do directly for shared blocke where multiple qdiscs are > owning the block. So introduce a infrastructure to

Re: [PATCH net-next 2/8] rtnetlink: add rtnl_register_module

2017-11-12 Thread Florian Westphal
Peter Zijlstra wrote: > On Tue, Nov 07, 2017 at 10:47:51AM +0100, Florian Westphal wrote: > > I would expect this to trigger all the time, due to > > > > rtnl_register(AF_INET, RTM_GETROUTE, ... > > rtnl_register(AF_INET, RTM_GETADDR, ... > > Ah, sure, then something like

Re: [PATCH net-next] decnet: move to staging

2017-11-12 Thread Greg KH
On Mon, Nov 13, 2017 at 07:30:09AM +0100, Jiri Pirko wrote: > Sun, Nov 12, 2017 at 09:02:14PM CET, step...@networkplumber.org wrote: > >Support for Decnet has been orphaned for many years. > >In the interest of reducing the potential bug surface and pre-holiday > >cleaning, move the decnet

Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

2017-11-12 Thread Jakub Kicinski
On Mon, 13 Nov 2017 07:25:38 +0100, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicin...@netronome.com wrote: > >On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> In order to remove tp->q usage in cls_bpf, the

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Kaiwan N Billimoria
On Mon, Nov 13, 2017 at 11:38 AM, Tobin C. Harding wrote: > On Mon, Nov 13, 2017 at 11:16:28AM +0530, kaiwan.billimo...@gmail.com wrote: >> On Mon, 2017-11-13 at 09:21 +1100, Tobin C. Harding wrote: >> > On Fri, Nov 10, 2017 at 07:26:34PM +0530, kaiwan.billimo...@gmail.com >> >

Re: [PATCH net-next] decnet: move to staging

2017-11-12 Thread Jiri Pirko
Sun, Nov 12, 2017 at 09:02:14PM CET, step...@networkplumber.org wrote: >Support for Decnet has been orphaned for many years. >In the interest of reducing the potential bug surface and pre-holiday >cleaning, move the decnet protocol into staging for eventual removal. > >Signed-off-by: Stephen

Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

2017-11-12 Thread Jiri Pirko
Mon, Nov 13, 2017 at 03:14:18AM CET, jakub.kicin...@netronome.com wrote: >On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> In order to remove tp->q usage in cls_bpf, the offload->netdev check >> needs to be moved to individual drivers as only

Re: SRIOV switchdev mode BoF minutes

2017-11-12 Thread Or Gerlitz
On Sun, Nov 12, 2017 at 10:38 PM, Alexander Duyck wrote: > On Sun, Nov 12, 2017 at 11:49 AM, Or Gerlitz wrote: >> Hi Dave and all, >> >> During and after the BoF on SRIOV switchdev mode, we came into a >> consensus among the developers from four

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Tobin C. Harding
On Mon, Nov 13, 2017 at 11:16:28AM +0530, kaiwan.billimo...@gmail.com wrote: > On Mon, 2017-11-13 at 09:21 +1100, Tobin C. Harding wrote: > > On Fri, Nov 10, 2017 at 07:26:34PM +0530, kaiwan.billimo...@gmail.com > > wrote: > > > On Tue, 2017-11-07 at 21:32 +1100, Tobin C. Harding wrote: > > > >

Re: linux-next: manual merge of the tip tree with the net-next tree

2017-11-12 Thread Stephen Rothwell
Hi all, On Mon, 30 Oct 2017 20:55:47 + Mark Brown wrote: > > Today's linux-next merge of the tip tree got a conflict in: > > net/ipv4/tcp_output.c > > between commit: > > 6aa7de059173a ("locking/atomics: COCCINELLE/treewide: Convert trivial > ACCESS_ONCE()

[PATCH net] sctp: add wait_buf flag in asoc to avoid the peeloff and wait sndbuf race

2017-11-12 Thread Xin Long
Commit dfcb9f4f99f1 ("sctp: deny peeloff operation on asocs with threads sleeping on it") fixed the race between peeloff and wait sndbuf by checking waitqueue_active(>wait) in sctp_do_peeloff(). But it actually doesn't work as even if waitqueue_active returns false the waiting sndbuf thread may

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread kaiwan . billimoria
On Mon, 2017-11-13 at 09:21 +1100, Tobin C. Harding wrote: > On Fri, Nov 10, 2017 at 07:26:34PM +0530, kaiwan.billimo...@gmail.com > wrote: > > On Tue, 2017-11-07 at 21:32 +1100, Tobin C. Harding wrote: > > > Currently we are leaking addresses from the kernel to user space. > > > This > > >

[PATCH net] sctp: check stream reset info len before making reconf chunk

2017-11-12 Thread Xin Long
Now when resetting stream, if both in and out flags are set, the info len can reach: sizeof(struct sctp_strreset_outreq) + SCTP_MAX_STREAM(65535) + sizeof(struct sctp_strreset_inreq) + SCTP_MAX_STREAM(65535) even without duplicated stream no, this value is far greater than the chunk's max

Re: [kernel-hardening] Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Kaiwan N Billimoria
On Mon, Nov 13, 2017 at 10:05 AM, Tobin C. Harding wrote: > On Mon, Nov 13, 2017 at 06:37:28AM +0300, Kirill A. Shutemov wrote: >> On Mon, Nov 13, 2017 at 10:06:46AM +1100, Tobin C. Harding wrote: >> > On Sun, Nov 12, 2017 at 02:10:07AM +0300, Kirill A. Shutemov wrote: ... >> > >>

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

2017-11-12 Thread Stephen Rothwell
Hi all, On Mon, 9 Oct 2017 18:56:33 +0100 Mark Brown wrote: > > Today's linux-next merge of the drivers-x86 tree got a conflict in: > > Documentation/admin-guide/thunderbolt.rst > > between commit: > >e69b6c02b4c3b ("net: Add support for networking over Thunderbolt

Re: linux-next: manual merge of the cgroup tree with the net-next tree

2017-11-12 Thread Stephen Rothwell
Hi Mark, On Mon, 9 Oct 2017 19:38:36 +0100 Mark Brown wrote: > > Hi Tejun, > > Today's linux-next merge of the cgroup tree got a conflict in: > > kernel/cgroup/cgroup.c > > between commit: > > 324bda9e6c5ad ("bpf: multi program support for cgroup+bpf") > > from the

[PATCH net] sctp: do not free asoc when it is already dead in sctp_sendmsg

2017-11-12 Thread Xin Long
Now in sctp_sendmsg sctp_wait_for_sndbuf could schedule out without holding sock sk. It means the current asoc can be freed elsewhere, like when receiving an abort packet. If the asoc is just created in sctp_sendmsg and sctp_wait_for_sndbuf returns err, the asoc will be freed again due to

Re: [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional

2017-11-12 Thread Andrew Lunn
On Mon, Nov 13, 2017 at 12:08:49PM +0800, Phil Reid wrote: > On 12/11/2017 23:38, Pan Bian wrote: > >Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its > >return value should not be validated by a NULL check. Instead, use IS_ERR. > > > >Signed-off-by: Pan Bian

Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Tobin C. Harding
On Mon, Nov 13, 2017 at 06:37:28AM +0300, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 10:06:46AM +1100, Tobin C. Harding wrote: > > On Sun, Nov 12, 2017 at 02:10:07AM +0300, Kirill A. Shutemov wrote: > > > On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote: > > > > Currently

Re: [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional

2017-11-12 Thread Phil Reid
On 12/11/2017 23:38, Pan Bian wrote: Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its return value should not be validated by a NULL check. Instead, use IS_ERR. Signed-off-by: Pan Bian --- drivers/net/dsa/lan9303-core.c | 2 +- 1 file changed, 1

[PATCH net-next V2] vhost_net: conditionally enable tx polling

2017-11-12 Thread Jason Wang
We always poll tx for socket, this is sub optimal since this will slightly increase the waitqueue traversing time and more important, vhost could not benefit from commit 9e641bdcfa4e ("net-tun: restructure tun_do_read for better sleep/wakeup efficiency") even if we've stopped rx polling during

Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 10:06:46AM +1100, Tobin C. Harding wrote: > On Sun, Nov 12, 2017 at 02:10:07AM +0300, Kirill A. Shutemov wrote: > > On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote: > > > Currently we are leaking addresses from the kernel to user space. This > > > script is

[PATCH 1/1] net: ipv4: use BUG_ON instead of condition followed by BUG

2017-11-12 Thread Jian Wang
Signed-off-by: Jian Wang --- net/ipv4/ip_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index e8e675b..1a53553 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -769,8 +769,8 @@

Fwd: FW: [PATCH 15/31] nds32: System calls handling

2017-11-12 Thread Vincent Chen
>>On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >> From: Greentime Hu > >> +#endif /* __ASM_NDS32_SYSCALLS_H */ >> diff --git a/arch/nds32/include/asm/unistd.h >> b/arch/nds32/include/asm/unistd.h new file mode 100644 index >> 000..b30adca

Fwd: FW: [PATCH 17/31] nds32: Signal handling support

2017-11-12 Thread Vincent Chen
>> +static int restore_sigframe(struct pt_regs *regs, >> + struct rt_sigframe __user * sf) { > >[snip] > >> + err |= !valid_user_regs(regs); > >IDGI... Where do you modify ->ipsw at all and how can valid_user_regs() come >to be false here? > Thanks. This code is

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-12 Thread Fengguang Wu
[...] > Oh - and talking about "big step forward" - does the 0day robot do > any > suspend/resume testing at all? Yes, we do. CC Rui and Aaron on power testing. yes, we have added suspend/resume test in 0day, including both functionality and suspend/resume performance. It is not widely run

Re: [patch net-next v2 01/10] cls_bpf: move prog offload->netdev check into drivers

2017-11-12 Thread Jakub Kicinski
On Sun, 12 Nov 2017 16:55:55 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > In order to remove tp->q usage in cls_bpf, the offload->netdev check > needs to be moved to individual drivers as only they will have access > to appropriate struct net_device. > > Signed-off-by:

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-12 Thread Zhang Rui
On Mon, 2017-11-13 at 09:13 +0800, Fengguang Wu wrote: > CC Andi and more DEBUG_INFO_SPLIT people. > > On Sun, Nov 12, 2017 at 11:31:56AM -0800, Linus Torvalds wrote: > > > > On Wed, Nov 8, 2017 at 9:12 AM, Fengguang Wu > m> wrote: > > > > > > > > > OK. Here is the

Re: [PATCH net-next 0/5] net: improve the process of redirect and toobig for ipv6 tunnels

2017-11-12 Thread David Miller
From: Xin Long Date: Sat, 11 Nov 2017 19:06:48 +0800 > Now let's say there are 3 kinds of icmp packets to process for tunnels, > toobig(needfrag), redirect, others, their process should be: > > - toobig(needfrag) >update the lower dst's pmtu by route cache, also

Re: [PATCH net-next 1/1] forcedeth: remove redudant assignments in xmit

2017-11-12 Thread David Miller
From: Zhu Yanjun Date: Fri, 10 Nov 2017 21:10:00 -0500 > In xmit process, the variables are set many times. In fact, > it is enough for these variables to be set once. > After a long time test, the throughput performance is better > than before. > > CC: Srinivas Eeda

Re: [net-next v5 0/4] Openvswitch meter action

2017-11-12 Thread David Miller
From: Pravin Shelar Date: Sat, 11 Nov 2017 07:25:30 +0530 > On Sat, Nov 11, 2017 at 1:39 AM, Andy Zhou wrote: >> This patch series is the first attempt to add openvswitch >> meter support. We have previously experimented with adding >> metering support in

Re: [PATCH net-next 0/4] net: dsa: b53: Support prepended Broadcom tags

2017-11-12 Thread David Miller
From: Florian Fainelli Date: Fri, 10 Nov 2017 15:22:51 -0800 > This patch series adds support for prepended 4-bytes Broadcom tags that we > already support. This type of tag will typically be used when interfaced to > a SoC like BCM58xx (NorthStar Plus) which supports a

Re: [patch 1/1] net/sched/sch_red.c: work around gcc-4.4.4 anon union initializer issue

2017-11-12 Thread David Miller
From: a...@linux-foundation.org Date: Fri, 10 Nov 2017 15:09:53 -0800 > From: Andrew Morton > Subject: net/sched/sch_red.c: work around gcc-4.4.4 anon union initializer > issue > > gcc-4.4.4 (at lest) has issues with initializers and anonymous unions: > >

Re: [PATCH net-next] net/mlx4: Use Kconfig flag to remove support of old gen2 Mellanox devices

2017-11-12 Thread David Miller
From: Tariq Toukan Date: Fri, 10 Nov 2017 09:10:29 +0200 > From: Slava Shwartsman > > Since Mellanox focus is on newer adapters, we would like to have the > ability to disable the support for old gen2 adapters. > > This can be done by turning off the

Re: [PATCH net-next] tcp: Namespace-ify sysctl_tcp_default_congestion_control

2017-11-12 Thread David Miller
From: Stephen Hemminger Date: Fri, 10 Nov 2017 10:26:37 +0900 > Make default TCP default congestion control to a per namespace > value. The congestion control setting of new namespaces is inherited > from the root namespace. Modules are only autoloaded in the root

Re: [PATCH V2 net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

2017-11-12 Thread David Miller
From: Salil Mehta Date: Thu, 9 Nov 2017 16:38:13 + > This patch migrates the HNS3 driver code from use of depricated PCI > MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. > > Signed-off-by: Salil Mehta > Suggested-by:

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-12 Thread David Miller
From: David Miller Date: Sat, 11 Nov 2017 23:21:01 +0900 (KST) > Aha, that's what I missed. Indeed, it cannot happen. Applied and queued up for -stable.

Re: [PATCH v3 net-next 0/3] netem: add nsec scheduling and slot feature

2017-11-12 Thread David Miller
From: Dave Taht Date: Wed, 8 Nov 2017 15:12:25 -0800 > This patch series converts netem away from the old "ticks" interface and > userspace API, and adds support for a new "slot" feature intended to > emulate bursty macs such as WiFi and LTE better. > > Changes since v2: >

CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-12 Thread Fengguang Wu
CC Andi and more DEBUG_INFO_SPLIT people. On Sun, Nov 12, 2017 at 11:31:56AM -0800, Linus Torvalds wrote: On Wed, Nov 8, 2017 at 9:12 AM, Fengguang Wu wrote: OK. Here is the original faddr2line output: $ ~/linux/scripts/faddr2line vmlinux

Re: [PATCH net-next v2] ipv6: try not to take rtnl_lock in ip6mr_sk_done

2017-11-12 Thread David Miller
From: frugg...@arista.com (Francesco Ruggeri) Date: Wed, 08 Nov 2017 11:23:46 -0800 > Avoid traversing the list of mr6_tables (which requires the > rtnl_lock) in ip6mr_sk_done(), when we know in advance that > a match will not be found. > This can happen when rawv6_close()/ip6mr_sk_done() is

Re: [PATCH v2 net-next 00/12] tls: Add generic NIC offload infrastructure

2017-11-12 Thread David Miller
From: Ilya Lesokhin Date: Wed, 8 Nov 2017 15:38:25 +0200 > Changes from v1: > - Remove the binding of the socket to a specific netdev > through sk->sk_bound_dev_if. > Add a check in validate_xmit_skb to detect route changes > and call SW fallback code to do the crypto

Re: [PATCH] net: realtek: r8169: remove redundant assignment to giga_ctrl

2017-11-12 Thread David Miller
From: Colin King Date: Wed, 8 Nov 2017 13:23:23 + > From: Colin Ian King > > The variable giga_ctrl is being assigned to zero however this is > never read and hence the assignment is redundant, so remove it. > Cleans up clang warning: >

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Michael Ellerman
Frank Rowand writes: > Hi Michael, > > On 11/12/17 03:49, Michael Ellerman wrote: ... >> >> On our bare metal machines the device tree comes from skiboot >> (firmware), with some of the content provided by hostboot (other >> firmware), both of which are open source, so in

Re: [PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port()

2017-11-12 Thread David Miller
From: Egil Hjelmeland Date: Wed, 8 Nov 2017 11:44:36 +0100 > Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing > entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and > .port_mdb_del. > > Fixes: 0620427ea0d6 ("net: dsa:

Re: [ftrace-bpf 1/5] add BPF_PROG_TYPE_FTRACE to bpf

2017-11-12 Thread Alexei Starovoitov
On Sun, Nov 12, 2017 at 07:28:24AM +, yupeng0...@gmail.com wrote: > Add a new type BPF_PROG_TYPE_FTRACE to bpf, let bpf can be attached to > ftrace. Ftrace pass the function parameters to bpf prog, bpf prog > return 1 or 0 to indicate whether ftrace can trace this function. The > major propose

Re: [PATCH net-next] net: dsa: lan9303: Documentation: Add missing word "Mbps"

2017-11-12 Thread David Miller
From: Egil Hjelmeland Date: Wed, 8 Nov 2017 11:55:14 +0100 > Signed-off-by: Egil Hjelmeland Applied.

Re: [PATCH] ip_gre: fix ip-config error reported by lkp-robot

2017-11-12 Thread David Miller
From: William Tu Date: Tue, 7 Nov 2017 07:57:44 -0800 > lkp-robot reports the following two errors: > IP-Config: Failed to open gretap0 > IP-Config: Failed to open erspan0 > due to device's mac address is zero. Fix it by assigning > a random Ethernet address. > >

[PATCH] uapi: fix linux/rxrpc.h userspace compilation errors

2017-11-12 Thread Dmitry V. Levin
Consistently use types provided by to fix the following linux/rxrpc.h userspace compilation errors: /usr/include/linux/rxrpc.h:24:2: error: unknown type name 'u16' u16 srx_service; /* service desired */ /usr/include/linux/rxrpc.h:25:2: error: unknown type name 'u16' u16 transport_type; /*

Re: [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I

2017-11-12 Thread Tom Herbert
On Sun, Nov 12, 2017 at 12:56 PM, Harald Welte wrote: > Hi Tom, > > sorry for the delayed response. But I remain committed in pushing > the non-controversial part of your GTP patches forward. > > On Sat, Oct 28, 2017 at 06:47:59PM +0200, Harald Welte wrote: >> Thanks. As

Re: [PATCH iproute2 0/2] add batch command support to devlink

2017-11-12 Thread Stephen Hemminger
On Fri, 10 Nov 2017 07:20:12 +0100 Ivan Vecera wrote: > This patch series adds support for devlink commands batching. The first > just removes a requirement to have declared 'resolve_hosts' variable in > any command that use any function implemented in utils.c (it is really >

Re: [PATCH iproute2 2/2] devlink: add batch command support

2017-11-12 Thread Stephen Hemminger
On Fri, 10 Nov 2017 21:47:35 +0200 Leon Romanovsky wrote: > On Fri, Nov 10, 2017 at 08:10:43AM +0100, Ivan Vecera wrote: > > On 10.11.2017 07:57, Leon Romanovsky wrote: > > > On Fri, Nov 10, 2017 at 07:20:14AM +0100, Ivan Vecera wrote: > > >> The patch adds support to batch

Re: Per-CPU Queueing for QoS

2017-11-12 Thread Stephen Hemminger
On Sun, 12 Nov 2017 13:43:13 -0800 Michael Ma wrote: > Any comments? We plan to implement this as a qdisc and appreciate any early > feedback. > > Thanks, > Michael > > > On Nov 9, 2017, at 5:20 PM, Michael Ma wrote: > > > > Currently txq/qdisc

Re: [PATCH 0/7] net: core: devname allocation cleanups

2017-11-12 Thread Stephen Hemminger
On Mon, 13 Nov 2017 00:15:03 +0100 Rasmus Villemoes wrote: > It's somewhat confusing to have both dev_alloc_name and > dev_get_valid_name. I can't see why the former is less strict than the > latter, so make them (or rather dev_alloc_name_ns and > dev_get_valid_name)

Re: [PATCH 6/7] net: core: maybe return -EEXIST in __dev_alloc_name

2017-11-12 Thread Stephen Hemminger
On Mon, 13 Nov 2017 00:15:09 +0100 Rasmus Villemoes wrote: > If we're given format string with no %d, -EEXIST is a saner error code. > > Signed-off-by: Rasmus Villemoes > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH iproute2 1/1] tc: distinguish Add/Replace qdisc operations

2017-11-12 Thread Stephen Hemminger
On Thu, 26 Oct 2017 17:30:08 -0400 Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > tc/tc_qdisc.c | 10 ++ > 1 file changed, 10 insertions(+) Applied to 4.14

Re: [PATCH iproute2] man: Clarify idleslope calculation for tc-cbs

2017-11-12 Thread Stephen Hemminger
On Fri, 10 Nov 2017 14:34:36 -0800 Jesus Sanchez-Palencia wrote: > In order to calculate the idleSlope parameter of CBS correctly, users > must take into account the entire packet size, including the overhead > from all layers. > > Add some more details to the

[RFC v2 6/6] bpf: add new test test_many_kprobe

2017-11-12 Thread Song Liu
The test compares old text based kprobe API with PERF_TYPE_PROBE. Here is a sample output of this test: Creating 1000 kprobes with text-based API takes 6.979683 seconds Cleaning 1000 kprobes with text-based API takes 84.897687 seconds Creating 1000 kprobes with PERF_TYPE_PROBE (function name)

[RFC v2 0/6] enable creating [k,u]probe with perf_event_open

2017-11-12 Thread Song Liu
Changes v1 to v2: Fix build issue reported by kbuild test bot by adding ifdef of CONFIG_KPROBE_EVENTS, and CONFIG_UPROBE_EVENTS. v1 cover letter: This is to follow up the discussion over "new kprobe api" at Linux Plumbers 2017: https://www.linuxplumbersconf.org/2017/ocw/proposals/4808 With

[RFC v2 4/6] perf: implement uprobe support to PERF_TYPE_PROBE

2017-11-12 Thread Song Liu
This patch adds uprobe support to perf_probe with similar pattern as previous patch (for kprobe). Two functions, create_local_trace_uprobe() and destroy_local_trace_uprobe(), are created so a uprobe can be created and attached to the file descriptor created by perf_event_open(). Signed-off-by:

[RFC] bcc: Try use new API to create [k,u]probe with perf_event_open

2017-11-12 Thread Song Liu
New kernel API allows creating [k,u]probe with perf_event_open. This patch tries to use the new API. If the new API doesn't work, we fall back to old API. bpf_detach_probe() looks up the event being removed. If the event is not found, we skip the clean up procedure. Signed-off-by: Song Liu

[RFC v2 2/6] perf: copy new perf_event.h to tools/include/uapi

2017-11-12 Thread Song Liu
perf_event.h is updated in previous patch, this patch applies same changes to the tools/ version. This is part is put in a separate patch in case the two files are back ported separately. Signed-off-by: Song Liu Reviewed-by: Yonghong Song Reviewed-by: Josef

[RFC v2 5/6] bpf: add option for bpf_load.c to use PERF_TYPE_PROBE

2017-11-12 Thread Song Liu
Function load_and_attach() is updated to be able to create kprobes with either old text based API, or the new PERF_TYPE_PROBE API. A global flag use_perf_type_probe is added to select between the two APIs. Signed-off-by: Song Liu Reviewed-by: Josef Bacik

[RFC] perf_event_open.2: add new type PERF_TYPE_PROBE

2017-11-12 Thread Song Liu
A new type PERF_TYPE_PROBE is being added to perf_event_attr. This patch adds information about this type. Note: the following two flags are also added to the man page. They are from perf_event.h in latest kernel repo. However, they are not related to PERF_TYPE_PROBE. Therefore, their usage are

[RFC v2 1/6] perf: Add new type PERF_TYPE_PROBE

2017-11-12 Thread Song Liu
A new perf type PERF_TYPE_PROBE is added to allow creating [k,u]probe with perf_event_open. These [k,u]probe are associated with the file decriptor created by perf_event_open, thus are easy to clean when the file descriptor is destroyed. Struct probe_desc and two flags, is_uprobe and is_return,

[RFC v2 3/6] perf: implement kprobe support to PERF_TYPE_PROBE

2017-11-12 Thread Song Liu
A new pmu, perf_probe, is created for PERF_TYPE_PROBE. Based on input from perf_event_open(), perf_probe creates a kprobe (or kretprobe) for the perf_event. This kprobe is private to this perf_event, and thus not added to global lists, and not available in tracefs. Two functions,

[PATCH 0/7] net: core: devname allocation cleanups

2017-11-12 Thread Rasmus Villemoes
It's somewhat confusing to have both dev_alloc_name and dev_get_valid_name. I can't see why the former is less strict than the latter, so make them (or rather dev_alloc_name_ns and dev_get_valid_name) equivalent, hardening dev_alloc_name() a little. Obvious follow-up patches would be to only

[PATCH 1/7] net: core: improve sanity checking in __dev_alloc_name

2017-11-12 Thread Rasmus Villemoes
__dev_alloc_name is called from the public (and exported) dev_alloc_name(), so we don't have a guarantee that strlen(name) is at most IFNAMSIZ. If somebody manages to get __dev_alloc_name called with a % char beyond the 31st character, we'd be making a snprintf() call that will very easily crash

[PATCH 3/7] net: core: eliminate dev_alloc_name{,_ns} code duplication

2017-11-12 Thread Rasmus Villemoes
dev_alloc_name contained a BUG_ON(), which I moved to dev_alloc_name_ns; the only other caller of that already has the same BUG_ON. Signed-off-by: Rasmus Villemoes --- net/core/dev.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git

[PATCH 4/7] net: core: drop pointless check in __dev_alloc_name

2017-11-12 Thread Rasmus Villemoes
The only caller passes a stack buffer as buf, so it won't equal the passed-in name. Moreover, we're already using buf as a scratch buffer inside the if (p) {} block, so if buf and name were the same, that snprintf() call would be overwriting its own format string. Signed-off-by: Rasmus Villemoes

[PATCH 2/7] net: core: move dev_alloc_name_ns a little higher

2017-11-12 Thread Rasmus Villemoes
No functional change. Signed-off-by: Rasmus Villemoes --- net/core/dev.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 87e19804757b..240ae6bc1097 100644 --- a/net/core/dev.c +++

[PATCH 5/7] net: core: check dev_valid_name in __dev_alloc_name

2017-11-12 Thread Rasmus Villemoes
We currently only exclude non-sysfs-friendly names via dev_get_valid_name; there doesn't seem to be a reason to allow such names when we're called via dev_alloc_name. This does duplicate the dev_valid_name check in the dev_get_valid_name() case; we'll fix that shortly. Signed-off-by: Rasmus

[PATCH 7/7] net: core: dev_get_valid_name is now the same as dev_alloc_name_ns

2017-11-12 Thread Rasmus Villemoes
If name contains a %, it's easy to see that this patch doesn't change anything (other than eliminate the duplicate dev_valid_name call). Otherwise, we'll now just spend a little time in snprintf() copying name to the stack buffer allocated in dev_alloc_name_ns, and do the __dev_get_by_name using

[PATCH 6/7] net: core: maybe return -EEXIST in __dev_alloc_name

2017-11-12 Thread Rasmus Villemoes
If we're given format string with no %d, -EEXIST is a saner error code. Signed-off-by: Rasmus Villemoes --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index c0a92cf27566..7c08b4ca7b76 100644 ---

Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Tobin C. Harding
On Sun, Nov 12, 2017 at 02:10:07AM +0300, Kirill A. Shutemov wrote: > On Tue, Nov 07, 2017 at 09:32:11PM +1100, Tobin C. Harding wrote: > > Currently we are leaking addresses from the kernel to user space. This > > script is an attempt to find some of those leakages. Script parses > > `dmesg`

[PATCH net-next 1/3 v3] bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics

2017-11-12 Thread Yonghong Song
For helpers, the argument type ARG_CONST_SIZE_OR_ZERO permits the access size to be 0 when accessing the previous argument (arg). Right now, it requires the arg needs to be NULL when size passed is 0 or could be 0. It also requires a non-NULL arg when the size is proved to be non-0. This patch

[PATCH net-next 3/3 v3] bpf: fix and add test cases for ARG_CONST_SIZE_OR_ZERO semantics change

2017-11-12 Thread Yonghong Song
Fix a few test cases to allow non-NULL map/packet/stack pointer with size = 0. Change a few tests using bpf_probe_read to use bpf_probe_write_user so ARG_CONST_SIZE arg can still be properly tested. One existing test case already covers size = 0 with non-NULL packet pointer, so add additional

[PATCH net-next 0/3 v3] bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics

2017-11-12 Thread Yonghong Song
This patch set intends to change verifier ARG_CONST_SIZE_OR_ZERO semantics so that simpler bpf programs can be written with verifier acceptance. Patch #1 comment provided the detailed examples and the patch itself implements the new semantics. Patch #2 changes bpf_probe_read helper arg2 type from

[PATCH net-next 2/3 v3] bpf: change helper bpf_probe_read arg2 type to ARG_CONST_SIZE_OR_ZERO

2017-11-12 Thread Yonghong Song
The helper bpf_probe_read arg2 type is changed from ARG_CONST_SIZE to ARG_CONST_SIZE_OR_ZERO to permit size-0 buffer. Together with newer ARG_CONST_SIZE_OR_ZERO semantics which allows non-NULL buffer with size 0, this allows simpler bpf programs with verifier acceptance. The previous commit which

Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

2017-11-12 Thread Pavel Machek
Hi! Are there any news here? Is there new release planned? Is there a git tree somewhere? I probably should get it working, soon.. so I guess I can help with testing. Thanks and best regards, Pavel -- (english)

[PATCH net-next] net: Mention net-next status web page in netdev-FAQ.txt

2017-11-12 Thread laforge
From: Harald Welte According to https://www.mail-archive.com/netdev@vger.kernel.org/msg177411.html there is a status page available at http://vger.kernel.org/~davem/net-next.html to obtain the current status of the net-next tree. Let's add this information to the

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Tobin C. Harding
On Fri, Nov 10, 2017 at 07:26:34PM +0530, kaiwan.billimo...@gmail.com wrote: > On Tue, 2017-11-07 at 21:32 +1100, Tobin C. Harding wrote: > > Currently we are leaking addresses from the kernel to user space. > > This > > script is an attempt to find some of those leakages. Script parses > >

[PATCH net-next] net: Extend Kernel GTP-U tunneling documentation

2017-11-12 Thread laforge
From: Harald Welte * clarify specification references for v0/v1 * add section "APN vs. Network device" * add section "Local GTP-U entity and tunnel identification" Signed-off-by: Andreas Schultz Signed-off-by: Harald Welte ---

Re: Per-CPU Queueing for QoS

2017-11-12 Thread Michael Ma
Any comments? We plan to implement this as a qdisc and appreciate any early feedback. Thanks, Michael > On Nov 9, 2017, at 5:20 PM, Michael Ma wrote: > > Currently txq/qdisc selection is based on flow hash so packets from > the same flow will follow the order when they

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Tobin C. Harding
On Sun, Nov 12, 2017 at 10:02:55AM -0800, Frank Rowand wrote: > Hi Michael, > > On 11/12/17 03:49, Michael Ellerman wrote: > > Hi Frank, > > > > Frank Rowand writes: > >> Hi Michael, Tobin, > >> > >> On 11/08/17 04:10, Michael Ellerman wrote: > >>> "Tobin C. Harding"

[PATCH RfC 2/2] net: phy: core: don't disable device interrupts in phy_change

2017-11-12 Thread Heiner Kallweit
If state is not PHY_HALTED I see no need to temporarily disable interrupts on the device. As long as the current interrupt isn't acked on the device no new interrupt can happen anyway. In addition remove a unneeded enabling of interrupts in the state machine when handling state PHY_CHANGELINK.

[PATCH RfC 1/2] net: phy: core: remove now uneeded disabling of interrupts

2017-11-12 Thread Heiner Kallweit
After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow some simplification" all relevant code pieces run in process context anyway and I don't think we need the disabling of interrupts any longer.

Re: [PATCH v7 net-next 00/13] gtp: Additional feature support - Part I

2017-11-12 Thread Harald Welte
Hi Tom, sorry for the delayed response. But I remain committed in pushing the non-controversial part of your GTP patches forward. On Sat, Oct 28, 2017 at 06:47:59PM +0200, Harald Welte wrote: > Thanks. As indicated, I'm planning some testing later this weekend on > the non-IPv6 patches, and am

linux-next: Signed-off-by missing for commit in the net-next tree

2017-11-12 Thread Stephen Rothwell
Hi all, Commit cbad52e92ad7 ("sfc: don't warn on successful change of MAC") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell

Re: SRIOV switchdev mode BoF minutes

2017-11-12 Thread Alexander Duyck
On Sun, Nov 12, 2017 at 11:49 AM, Or Gerlitz wrote: > Hi Dave and all, > > During and after the BoF on SRIOV switchdev mode, we came into a > consensus among the developers from four different HW vendors (CC > audience) that a correct thing to do would be to disallow any new

[PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-12 Thread Ahmed Abdelsalam
The IPv6 Segment Routing Header (SRH) format has been updated srating from revision 6 of the SRH ietf draft. The update includes the following SRH fields (1) The "First Segment" field changed to be "Last Entry" which contains the index, in the Segment List, of the last element of the Segment

Re: [PATCH] net: phy: realtek: fix RTL8211F interrupt mode

2017-11-12 Thread Jerome Brunet
On Sun, 2017-11-12 at 21:06 +0100, Andrew Lunn wrote: > On Sun, Nov 12, 2017 at 07:36:48PM +0100, Jerome Brunet wrote: > > On Sun, 2017-11-12 at 19:25 +0100, Andrew Lunn wrote: > > > On Sun, Nov 12, 2017 at 04:16:04PM +0100, Heiner Kallweit wrote: > > > > After commit b94d22d94ad22 "ARM64: dts:

Re: [PATCH] net: phy: realtek: fix RTL8211F interrupt mode

2017-11-12 Thread Andrew Lunn
On Sun, Nov 12, 2017 at 07:36:48PM +0100, Jerome Brunet wrote: > On Sun, 2017-11-12 at 19:25 +0100, Andrew Lunn wrote: > > On Sun, Nov 12, 2017 at 04:16:04PM +0100, Heiner Kallweit wrote: > > > After commit b94d22d94ad22 "ARM64: dts: meson-gx: add external PHY > > > interrupt on some platforms"

[PATCH net-next] decnet: move to staging

2017-11-12 Thread Stephen Hemminger
Support for Decnet has been orphaned for many years. In the interest of reducing the potential bug surface and pre-holiday cleaning, move the decnet protocol into staging for eventual removal. Signed-off-by: Stephen Hemminger --- MAINTAINERS

SRIOV switchdev mode BoF minutes

2017-11-12 Thread Or Gerlitz
Hi Dave and all, During and after the BoF on SRIOV switchdev mode, we came into a consensus among the developers from four different HW vendors (CC audience) that a correct thing to do would be to disallow any new extensions to the legacy mode. The idea is to put focus on the new mode and not

[PATCH v5 13/13] xfrm6_tunnel: exit_net cleanup check added

2017-11-12 Thread Vasily Averin
Be sure that spi_byaddr and spi_byspi arrays initialized in net_init hook were return to initial state Signed-off-by: Vasily Averin --- net/ipv6/xfrm6_tunnel.c | 8 1 file changed, 8 insertions(+) diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c index

  1   2   >