Now in sctp_setsockopt_reset_streams, it only does the check
optlen < sizeof(*params) for optlen. But it's not enough, as
params->srs_number_streams should also match optlen.
If the streams in params->srs_stream_list are less than stream
nums in params->srs_number_streams, later when dereferencing
On Sat, Dec 9, 2017 at 2:37 PM, Alexander Duyck
wrote:
> On Sat, Dec 9, 2017 at 1:40 PM, Michael Chan
> wrote:
>> On Sat, Dec 9, 2017 at 10:56 AM, Alexander Duyck
>> wrote:
>>> I think these two lines are redundant in dev_disable_lro, since
>>> netdev_update_features should propagate the disabl
On Sat, Dec 9, 2017 at 2:04 PM, Alexander Duyck
wrote:
> On Sat, Dec 9, 2017 at 1:31 PM, Michael Chan
> wrote:
>> On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck
>> wrote:
>>> So I would disagree with it being a subset of NETIF_F_GRO. If anything
>>> it is an alternative to NETIF_F_GRO. It is
On Sun, 2017-12-10 at 12:38 +0800, Xin Long wrote:
> On Sun, Dec 10, 2017 at 3:36 AM, Cong Wang
> wrote:
> > On Fri, Dec 8, 2017 at 12:45 AM, Xin Long
> > wrote:
> > > This isn't a sctp problem, but mld's, seems when lo's mtu became
> > > 0,
> > > it allocs a skb without enough space in add_grec(
In xlgmac_dev_xmit():
/* Mark it as a CONTEXT descriptor */
dma_desc->desc3 = XLGMAC_SET_REG_BITS_LE(
dma_desc->desc3,
TX_CONTEXT_DESC3_CTXT_POS,
On Sun, 2017-12-10 at 12:36 +0800, Xin Long wrote:
> The new patch works to me, just two questions:
> 1. should it use "idev->cnf.mtu6" here for mld ?
No idea why some parts of IPv6 would use a different view of device
mtu. Maybe others can comment.
>
> 2. 'if (int < unsigned int)' is still not
On Sun, Dec 10, 2017 at 3:36 AM, Cong Wang wrote:
> On Fri, Dec 8, 2017 at 12:45 AM, Xin Long wrote:
>> This isn't a sctp problem, but mld's, seems when lo's mtu became 0,
>> it allocs a skb without enough space in add_grec():
>
> Shouldn't we just set its min_mtu to ETH_MIN_MTU?
No idea why ther
On Sun, Dec 10, 2017 at 12:59 AM, Eric Dumazet wrote:
> On Sat, 2017-12-09 at 19:23 +0800, Xin Long wrote:
>> On Fri, Dec 8, 2017 at 4:45 PM, Xin Long
>> wrote:
>> > On Fri, Dec 8, 2017 at 4:16 PM, syzbot
>> > > > .com>
>> > wrote:
>> > > syzkaller has found reproducer for the following crash on
On Sun, 2017-12-10 at 03:50 +, simo.ghan...@gmail.com wrote:
> From: Mohamed Ghannam
>
> inet->hdrincl is racy, and could lead to uninitialized stack pointer
> usage, so its value should be read only once.
>
> Signed-off-by: Mohamed Ghannam
> ---
> net/ipv4/raw.c | 15 ++-
> 1
From: Mohamed Ghannam
inet->hdrincl is racy, and could lead to uninitialized stack pointer
usage, so its value should be read only once.
Signed-off-by: Mohamed Ghannam
---
net/ipv4/raw.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/raw.c b/net/i
Since both tx_ring and first_tx are the head of tx ring, it not
necessary to use two structure members to statically indicate
the head of tx ring. So first_tx is removed.
CC: Srinivas Eeda
CC: Joe Jin
CC: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
drivers/net/ethernet/nvidia/forcedeth.c | 21 ++
On Sat, Dec 09, 2017 at 11:11:33AM -0800, Solio Sarabia wrote:
> GSO values are not correctly set for peer and dev. When creating
> the veth link, GSO attributes are set for peer device, propagate
> these values from peer to dev.
>
> Signed-off-by: Solio Sarabia
> ---
> drivers/net/veth.c | 4 ++
> The good news is, having read through several drivers that contain the
> caseless "page" string, there are no drivers that need anything but a
> simple paging case, so it's not a concern.
Hi Russell
Also grep for bank. rockchip.c.
Andrew
On Sat, 9 Dec 2017 15:43:15 +0100, Eric Leblond wrote:
> + for (nh = (struct nlmsghdr *)buf; NLMSG_OK(nh, len);
> + nh = NLMSG_NEXT(nh, len)) {
> + if (nh->nlmsg_pid != getpid()) {
> + ret = -LIBBPF_ERRNO__WRNGPID;
> + goto cleanup;
On Sat, Dec 09, 2017 at 10:22:58AM -0800, Florian Fainelli wrote:
> On 12/08/2017 08:44 AM, Russell King - ARM Linux wrote:
> > On Fri, Dec 08, 2017 at 05:17:14PM +0100, Andrew Lunn wrote:
> >> Hi Russell
> >>
> >>> There is an open question whether there should be generic helpers for
> >>> this.
Introduce a device-managed version of pci_set_mwi. First user is the
Realtek r8169 driver.
Signed-off-by: Heiner Kallweit
---
drivers/pci/pci.c | 29 +
include/linux/pci.h | 1 +
2 files changed, 30 insertions(+)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
Simplify probe error path and remove callback by using device-managed
functions.
rtl_disable_msi isn't needed any longer because the release callback
of pcim_enable_device does this implicitely.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/realtek/r8169.c | 80 +--
netif_napi_del is called implicitely by free_netdev, therefore we
don't have to do it explicitely.
When the probe error path is reached, the net_device isn't
registered yet. Therefore reordering the call to netif_napi_del
shouldn't cause any issues.
Signed-off-by: Heiner Kallweit
---
drivers/ne
Probe error path and remove callback can be significantly simplified
by using device-managed functions. To be able to do this in the r8169
driver we need a device-managed version of pci_set_mwi first.
Heiner Kallweit (3):
PCI: introduce device-managed version of pci_set_mwi
r8169: switch to de
On Tue, Dec 5, 2017 at 8:03 PM, Michał Mirosław wrote:
> I'm happy to see that my work didn't go to /dev/null after all.
> I haven't finished it at the time because the box I had broke down
> beyond repair.
Ooops that explains why the submission was just haning in mid-air.
Sorry man :(
> I skim
On Sat, Dec 09, 2017 at 10:22:14AM -0800, Florian Fainelli wrote:
>
>
> On 12/08/2017 07:48 AM, Russell King wrote:
> > Add unlocked versions of the bus accessors, which allows access to the
> > bus with all the tracing. These accessors validate that the bus mutex
> > is held, which is a basic re
On Sat, Dec 9, 2017 at 1:40 PM, Michael Chan wrote:
> On Sat, Dec 9, 2017 at 10:56 AM, Alexander Duyck
> wrote:
>> On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan
>> wrote:
>>> Hardware should not aggregate any packets when generic XDP is installed.
>>>
>>> Cc: Ariel Elior
>>> Cc: everest-linux.
> Hmm, RFC3376 says:
>
> 4.2.13. IP Source Addresses for Reports
>
>An IGMP report is sent with a valid IP source address for the
>destination subnet. The 0.0.0.0 source address may be used by a
>system that has not yet acquired an IP address. Note that the
>0.0.0.0 source addre
On Sat, Dec 9, 2017 at 1:31 PM, Michael Chan wrote:
> On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck
> wrote:
>> On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan
>> wrote:
>>> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware
>>> GRO. With this flag, we can now independently
On Sat, Dec 9, 2017 at 10:56 AM, Alexander Duyck
wrote:
> On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan
> wrote:
>> Hardware should not aggregate any packets when generic XDP is installed.
>>
>> Cc: Ariel Elior
>> Cc: everest-linux...@cavium.com
>> Signed-off-by: Michael Chan
>> ---
>> net/co
On Sat, 2017-12-09 at 13:03 -0800, Matt Turner wrote:
> On Fri, Dec 8, 2017 at 1:16 PM, Eric Dumazet
> wrote:
> > On Fri, 2017-12-08 at 12:26 -0800, Matt Turner wrote:
> > >
> > > Thanks for the quick reply!
> > >
> > > I tried the patch on top of master, but unfortunately the
> > > corruption
>
On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck
wrote:
> On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan
> wrote:
>> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware
>> GRO. With this flag, we can now independently turn on or off hardware
>> GRO when GRO is on. Previously, d
On Wed, Dec 06, 2017 at 02:07:44PM -0800, Yonghong Song wrote:
> Commit e87c6bc3852b ("bpf: permit multiple bpf attachments
> for a single perf event") added support to attach multiple
> bpf programs to a single perf event. Given a perf event
> (kprobe, uprobe, or kernel tracepoint), the perf ioctl
On Fri, Dec 8, 2017 at 1:16 PM, Eric Dumazet wrote:
> On Fri, 2017-12-08 at 12:26 -0800, Matt Turner wrote:
>>
>> Thanks for the quick reply!
>>
>> I tried the patch on top of master, but unfortunately the corruption
>> still occurs.
>
> You might try replacing in sbdma_add_rcvbuffer()
>
> sb_new
Add an option to configure the rmnet aggregation and command features
on device creation. This is achieved by using the vlan flags option.
Signed-off-by: Subash Abhinov Kasiviswanathan
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 16 +---
1 file changed, 13 insertions(+),
Add an option to configure the mux id, aggregation and commad feature
for existing rmnet devices. Implement the changelink netlink
operation for this.
Signed-off-by: Subash Abhinov Kasiviswanathan
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 40 ++
1 file changed,
Multiplexing is always enabled when transmiting from a rmnet device,
so remove the redundant egress macros. De-multiplexing is always
enabled when receiving packets from a rmnet device, so remove those
ingress macros.
Signed-off-by: Subash Abhinov Kasiviswanathan
---
drivers/net/ethernet/qualcom
Add support to send and receive packets over ethernet.
An example of usage is testing the data path on UML. This can be
achieved by setting up two UML instances in multicast mode and
associating rmnet over the UML ethernet device.
Signed-off-by: Subash Abhinov Kasiviswanathan
---
drivers/net/eth
Upon de-multiplexing data from one real dev, the packets can be sent
to an unique rmnet device for a given mux id.
Signed-off-by: Subash Abhinov Kasiviswanathan
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/qualcom
Only the success and consumed entries were actually in use.
Use standard error codes instead.
Signed-off-by: Subash Abhinov Kasiviswanathan
---
drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 15 +++
drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h | 9 -
2 files
This series adds support for configuring features on rmnet devices.
The rmnet specific features to be configured here are aggregation and
control commands.
Patch 1 is a cleanup of return codes in the transmit path.
Patch 2 removes some redundant ingress and egress macros.
Patch 3 restricts the cre
On Sat, Dec 9, 2017 at 8:01 AM, Andrew Lunn wrote:
> The choice of IP address for IGMP in Linux is 'interesting'. Try with
> multiple IP addresses on the interfaces, addresses with different
> scopes, etc. I've seen it reply to the querier using an address from
> a different subnet to the incomi
On Sat, 2017-12-02 at 14:59 +0200, Kalle Valo wrote:
>
> net: netlink: Update attr validation to require exact length for some types
> https://git.kernel.org/linus/28033ae4e0f5
This was reverted, more or less, to print only a warning:
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
On Sat, Dec 09, 2017 at 09:41:25AM -0700, David Ahern wrote:
> On 12/7/17 4:40 PM, Stephen Hemminger wrote:
> > diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> > index f5438d0978ca..a69ad39ee57e 100644
> > --- a/drivers/net/veth.c
> > +++ b/drivers/net/veth.c
> > @@ -410,6 +410,9 @@ static i
On Fri, Dec 8, 2017 at 9:27 PM, Tonghao Zhang wrote:
> On Sat, Dec 9, 2017 at 6:09 AM, Cong Wang wrote:
>> On Thu, Dec 7, 2017 at 9:28 PM, Tonghao Zhang
>> wrote:
>>>
>>> Release the netlink sock created in kernel(not hold the _net_ namespace):
>>>
>>
>> You can avoid counting kernel sock by te
On Fri, Dec 8, 2017 at 12:45 AM, Xin Long wrote:
> This isn't a sctp problem, but mld's, seems when lo's mtu became 0,
> it allocs a skb without enough space in add_grec():
Shouldn't we just set its min_mtu to ETH_MIN_MTU?
On Fri, Dec 08, 2017 at 03:39:43PM +, Quentin Monnet wrote:
> 2017-12-08 14:12 UTC+ ~ Roman Gushchin
> > On Fri, Dec 08, 2017 at 10:34:16AM +, Quentin Monnet wrote:
> >> 2017-12-07 18:39 UTC+ ~ Roman Gushchin
> >>> This patch adds basic cgroup bpf operations to bpftool:
> >>> cgro
GSO values are not correctly set for peer and dev. When creating
the veth link, GSO attributes are set for peer device, propagate
these values from peer to dev.
Signed-off-by: Solio Sarabia
---
drivers/net/veth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net
> You do seem to be correct that this only applies (in mainline) to the
> ZII rev C board, so I guess including a patch to update its dts for
> the inter-switch connection would at least be sensible.
Hi Russell
So lets have the backward compatible for a couple of kernel cycles,
and modify ZII rev
> > Another potential question is whether using the mdiobus lock (which
> > excludes all other MII bus access) is best - while it has the advantage
> > of also ensuring atomicity with userspace accesses, it means that no one
> > else can access an independent PHY on the same bus while a paged acces
On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan wrote:
> Hardware should not aggregate any packets when generic XDP is installed.
>
> Cc: Ariel Elior
> Cc: everest-linux...@cavium.com
> Signed-off-by: Michael Chan
> ---
> net/core/dev.c | 24
> 1 file changed, 24 insertio
On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan wrote:
> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware
> GRO. With this flag, we can now independently turn on or off hardware
> GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to
> control hardware GRO and so it
On 12/07/2017 08:17 AM, Mason wrote:
> On 07/12/2017 00:00, Florian Fainelli wrote:
>
>> On 12/06/2017 11:25 AM, Mason wrote:
>>
>>> When we detect link down, we put the ethernet HW block in reset,
>>> and repeat initialization when the link comes back up.
>>>
>>> Hmmm, however, at the moment, I
On 12/9/2017 2:20 AM, Micka�l Sala�n wrote:
> On 12/10/2017 18:33, Casey Schaufler wrote:
>> On 10/12/2017 7:14 AM, Richard Guy Briggs wrote:
>>> Containers are a userspace concept. The kernel knows nothing of them.
>>>
>>> The Linux audit system needs a way to be able to track the container
>
On 12/08/2017 08:44 AM, Russell King - ARM Linux wrote:
> On Fri, Dec 08, 2017 at 05:17:14PM +0100, Andrew Lunn wrote:
>> Hi Russell
>>
>>> There is an open question whether there should be generic helpers for
>>> this. Generic helpers would mean:
>>>
>>> - Additional couple of function pointers
On 12/08/2017 07:48 AM, Russell King wrote:
> Add unlocked versions of the bus accessors, which allows access to the
> bus with all the tracing. These accessors validate that the bus mutex
> is held, which is a basic requirement for all mii bus accesses.
>
> Signed-off-by: Russell King
Reviewe
On 12/08/2017 07:48 AM, Russell King wrote:
> Use unlocked accessors for indirect MMD accesses to clause 22 PHYs.
> This permits tracing of these accesses.
>
> Signed-off-by: Russell King
Reviewed-by: Florian Fainelli
--
Florian
On 12/08/2017 07:48 AM, Russell King wrote:
> Add unlocked versions of the bus accessors, which allows access to the
> bus with all the tracing. These accessors validate that the bus mutex
> is held, which is a basic requirement for all mii bus accesses.
>
> Signed-off-by: Russell King
Reviewe
On 12/08/2017 07:47 AM, Russell King - ARM Linux wrote:
> Hi,
>
> While doing final testing of the mvneta changes for phylink, a very
> easy to trigger race condition was found with the Marvell PHY driver
> which manifested itself as the link going down when a hibernate cycle
> terminates.
>
>
On Sat, Dec 09, 2017 at 09:34:46AM -0700, David Ahern wrote:
> On 12/9/17 7:43 AM, Eric Leblond wrote:
> > + /* started nested attribute for XDP */
> > + nla = (struct nlattr *)(((char *)&req)
> > + + NLMSG_ALIGN(req.nh.nlmsg_len));
> > + nla->nla_type = NLA_F_NESTED
On 12/08/2017 12:22 PM, Marc Kleine-Budde wrote:
Hello Oliver,
I've the corresponding slcan patch already in my queue.
Excellent :-)
Thanks,
Oliver
Marc
On 12/08/2017 12:18 PM, Marc Kleine-Budde wrote:
The first and only parameter of sl_alloc() is unused, so remove it.
Fixes: 5342b77c
On Sat, 2017-12-09 at 19:23 +0800, Xin Long wrote:
> On Fri, Dec 8, 2017 at 4:45 PM, Xin Long
> wrote:
> > On Fri, Dec 8, 2017 at 4:16 PM, syzbot
> > > .com>
> > wrote:
> > > syzkaller has found reproducer for the following crash on
> > > 82bcf1def3b5f1251177ad47c44f7e17af039b4b
> > > git://git.c
On 12/7/17 4:40 PM, Stephen Hemminger wrote:
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index f5438d0978ca..a69ad39ee57e 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -410,6 +410,9 @@ static int veth_newlink(struct net *src_net, struct
> net_device *dev,
> i
On 12/8/17 11:29 AM, Stephen Hemminger wrote:
>> - 80 columns terminal, ss -Z -f netlink
>> * before:
>> Recv-Q Send-Q Local Address:Port Peer Address:Port
>>
>> 0 0rtnl:evolution-calen/2075 *
>> pr
>> oc_ctx=unconfined_u:unconfined_
On 12/9/17 7:43 AM, Eric Leblond wrote:
> + /* started nested attribute for XDP */
> + nla = (struct nlattr *)(((char *)&req)
> + + NLMSG_ALIGN(req.nh.nlmsg_len));
> + nla->nla_type = NLA_F_NESTED | 43/*IFLA_XDP*/;
as a part of the move into libbpf can the m
On 12/8/17 4:46 PM, Jakub Kicinski wrote:
>> +argc -= 2;
>> +argv = &argv[2];
>> +prog_fd = prog_parse_fd(&argc, &argv);
>> +if (prog_fd < 0)
>> +goto exit_cgroup;
>> +
>> +for (i = 0; i < argc; i++) {
>> +if (strcmp(argv[i], "allow_multi") == 0) {
>> +
On Fri, Dec 08, 2017 at 09:25:58PM -0800, Kevin Cernekee wrote:
> Closing a multicast socket after the final IPv4 address is deleted
> from an interface will generate a membership report that uses the
> source IP from a different interface. The following test script, run
> from an isolated netns,
Most of the code is taken from set_link_xdp_fd() in bpf_load.c and
slightly modified to be library compliant.
Signed-off-by: Eric Leblond
---
tools/lib/bpf/bpf.c| 108 -
tools/lib/bpf/libbpf.c | 2 +
tools/lib/bpf/libbpf.h | 4 ++
3 files c
No need to get into the submenu to disable all PTP-related
config entries.
This makes it easier to disable all PTP config options
without entering the submenu. It will also enable one
to see that en/dis-abled state from the outside menu.
This is only intended to change menuconfig UI, not change
t
On Sat, Dec 9, 2017 at 7:35 PM, Xin Long wrote:
> On Sat, Dec 9, 2017 at 6:40 PM, syzbot
>
> wrote:
>> Hello,
>>
>> syzkaller hit the following crash on
>> 328b4ed93b69a6f2083d52f31a240a09e5de386a
>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
>> compiler: gcc (GCC) 7.
If clk_set_rate() fails, we should disable clk before return.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Branislav Radocaj
---
Changes since v2:
* Improved inconsistent failure handling of clock rate setting
* For completeness of usecase, added arc_emac_probe e
On Sat, Dec 9, 2017 at 6:40 PM, syzbot
wrote:
> Hello,
>
> syzkaller hit the following crash on
> 328b4ed93b69a6f2083d52f31a240a09e5de386a
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console output is at
On Fri, Dec 8, 2017 at 4:45 PM, Xin Long wrote:
> On Fri, Dec 8, 2017 at 4:16 PM, syzbot
>
> wrote:
>> syzkaller has found reproducer for the following crash on
>> 82bcf1def3b5f1251177ad47c44f7e17af039b4b
>> git://git.cmpxchg.org/linux-mmots.git/master
>> compiler: gcc (GCC) 7.1.1 20170620
>> .co
On 12/10/2017 18:33, Casey Schaufler wrote:
> On 10/12/2017 7:14 AM, Richard Guy Briggs wrote:
>> Containers are a userspace concept. The kernel knows nothing of them.
>>
>> The Linux audit system needs a way to be able to track the container
>> provenance of events and actions. Audit needs the
69 matches
Mail list logo
