Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-27 Thread Masami Hiramatsu
On Wed, 27 Dec 2017 19:45:42 -0800 Alexei Starovoitov wrote: > On 12/27/17 6:34 PM, Masami Hiramatsu wrote: > > On Wed, 27 Dec 2017 14:46:24 -0800 > > Alexei Starovoitov wrote: > > > >> On 12/26/17 9:56 PM, Masami Hiramatsu wrote: > >>> On Tue, 26 Dec 2017 17:57:32

Re: WARNING in strp_data_ready

2017-12-27 Thread Dmitry Vyukov
On Thu, Dec 28, 2017 at 2:19 AM, Tom Herbert wrote: > On Wed, Dec 27, 2017 at 12:20 PM, Ozgur wrote: >> >> >> 27.12.2017, 23:14, "Dmitry Vyukov" : >>> On Wed, Dec 27, 2017 at 9:08 PM, Ozgur wrote: 27.12.2017,

Re: [RFC PATCH bpf-next v2 4/4] error-injection: Support fault injection framework

2017-12-27 Thread Masami Hiramatsu
On Wed, 27 Dec 2017 19:49:28 -0800 Alexei Starovoitov wrote: > On 12/27/17 5:38 PM, Masami Hiramatsu wrote: > > On Wed, 27 Dec 2017 14:49:46 -0800 > > Alexei Starovoitov wrote: > > > >> On 12/27/17 12:09 AM, Masami Hiramatsu wrote: > >>> On Tue, 26 Dec 2017 18:12:56

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Andrew Lunn
On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > This patch enables the fourth network interface on the Marvell > > Macchiatobin. It is configured in the 2500Base-X PHY mode. > > > > Signed-off-by:

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-27 Thread Andrew Lunn
On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > This patch adds one more generic PHY mode to the phy_mode enum, to allow > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > callback. > > Signed-off-by: Antoine Tenart >

Re: [PATCH] Staging: ipx: fixed several no space before tabs coding style issues

2017-12-27 Thread Greg KH
On Wed, Dec 27, 2017 at 09:25:44PM +, Jianshen Liu wrote: > Fixed several coding style warnings of "please, no space before tabs". > > Signed-off-by: Jianshen Liu > --- > drivers/staging/ipx/af_ipx.c| 56 > - >

[PATCH net-next v9 0/2] add UniPhier AVE ethernet support

2017-12-27 Thread Kunihiko Hayashi
This series adds support for Socionext AVE ethernet controller implemented on UniPhier SoCs. This driver supports RGMII/RMII modes. v8: https://www.spinics.net/lists/netdev/msg474374.html The PHY patch included in v1 has already separated in: http://www.spinics.net/lists/netdev/msg454595.html

[PATCH net-next v9 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

2017-12-27 Thread Kunihiko Hayashi
DT bindings for the AVE ethernet controller found on Socionext's UniPhier platforms. Signed-off-by: Kunihiko Hayashi Signed-off-by: Jassi Brar Acked-by: Rob Herring Reviewed-by: Florian Fainelli

[PATCH net-next v9 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-27 Thread Kunihiko Hayashi
The UniPhier platform from Socionext provides the AVE ethernet controller that includes MAC and MDIO bus supporting RGMII/RMII modes. The controller is named AVE. Signed-off-by: Kunihiko Hayashi Signed-off-by: Jassi Brar Reviewed-by:

[PATCH net-next] cxgb4/cxgb4vf: support for XLAUI Port Type

2017-12-27 Thread Ganesh Goudar
Add support for new Backplane XLAUI port type. Signed-off-by: Casey Leedom Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 10 +- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 1 +

[PATCH net-next v6 6/6] net: dccp: Remove dccpprobe module

2017-12-27 Thread Masami Hiramatsu
Remove DCCP probe module since jprobe has been deprecated. That function is now replaced by dccp/dccp_probe trace-event. You can use it via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- Changes in v5: - Fix a conflict with previous change in Makefile. ---

[PATCH net-next v6 1/6] net: tcp: Add trace events for TCP congestion window tracing

2017-12-27 Thread Masami Hiramatsu
This adds an event to trace TCP stat variables with slightly intrusive trace-event. This uses ftrace/perf event log buffer to trace those state, no needs to prepare own ring-buffer, nor custom user apps. User can use ftrace to trace this event as below; # cd /sys/kernel/debug/tracing # echo

[PATCH net-next v6 4/6] net: sctp: Remove debug SCTP probe module

2017-12-27 Thread Masami Hiramatsu
Remove SCTP probe module since jprobe has been deprecated. That function is now replaced by sctp/sctp_probe and sctp/sctp_probe_path trace-events. You can use it via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- net/sctp/Kconfig | 12 --- net/sctp/Makefile |

[PATCH net-next v6 2/6] net: tcp: Remove TCP probe module

2017-12-27 Thread Masami Hiramatsu
Remove TCP probe module since jprobe has been deprecated. That function is now replaced by tcp/tcp_probe trace-event. You can use it via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- net/Kconfig | 17 --- net/ipv4/Makefile|1

[PATCH net-next v6 3/6] net: sctp: Add SCTP ACK tracking trace event

2017-12-27 Thread Masami Hiramatsu
Add SCTP ACK tracking trace event to trace the changes of SCTP association state in response to incoming packets. It is used for debugging SCTP congestion control algorithms, and will replace sctp_probe module. Note that this event a bit tricky. Since this consists of 2 events (sctp_probe and

[PATCH net-next v6 5/6] net: dccp: Add DCCP sendmsg trace event

2017-12-27 Thread Masami Hiramatsu
Add DCCP sendmsg trace event (dccp/dccp_probe) for replacing dccpprobe. User can trace this event via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- Changes in v5 - Fix to add local directory to include for trace.h. Thanks Steven! --- net/dccp/Makefile |

[PATCH net-next v6 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

2017-12-27 Thread Masami Hiramatsu
Hi, This series is v6 of the replacement of jprobe usage with trace events. This version fixes trace/events/tcp.h to avoid sparse warning, as same as Mat Martineau's patch. Previous version is here; https://www.spinics.net/lists/netdev/msg474057.html Changes from v5: [1/6]: Avoid

[PATCH net-next] cxgb4: display VNI correctly

2017-12-27 Thread Ganesh Goudar
Fix incorrect VNI display in mps_tcam Signed-off-by: Santosh Rastapur Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document "external" parameter handling.

2017-12-27 Thread Serhey Popovych
Stephen Hemminger wrote: > On Wed, 27 Dec 2017 13:28:13 +0200 > Serhey Popovych wrote: > >> In this series I present next set of improvements/fixes: >> >> 1) Fix noencap- option handling: we need to clear bit, instead >> of seting all, but one we expect to

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-27 Thread Alexei Starovoitov
On 12/27/17 8:16 PM, Steven Rostedt wrote: On Wed, 27 Dec 2017 19:45:42 -0800 Alexei Starovoitov wrote: I don't think that's the case. My reading of current trace_kprobe_ftrace() -> arch_check_ftrace_location() is that it will not be true for old mcount case. In the old mcount

Re: [PATCH v3 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.9

2017-12-27 Thread Jakub Kicinski
On Wed, 27 Dec 2017 19:16:29 +, Roman Gushchin wrote: > Bpftool build is broken with binutils version 2.29 and later. > The cause is commit 003ca0fd2286 ("Refactor disassembler selection") > in the binutils repo, which changed the disassembler() function > signature. > > Fix this by adding a

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-27 Thread Steven Rostedt
On Wed, 27 Dec 2017 19:45:42 -0800 Alexei Starovoitov wrote: > I don't think that's the case. My reading of current > trace_kprobe_ftrace() -> arch_check_ftrace_location() > is that it will not be true for old mcount case. In the old mcount case, you can't use ftrace to return

Re: [patch net-next v5 05/10] net: sched: keep track of offloaded filters and check tc offload feature

2017-12-27 Thread Jakub Kicinski
On Tue, 26 Dec 2017 15:15:59 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > During block bind, we need to check tc offload feature. If it is > disabled yet still the block contains offloaded filters, forbid the > bind. Also forbid to register callback for a block that already

Re: [PATCH net-next] nfp: bpf: allocate vNIC priv for keeping track of the offloaded program

2017-12-27 Thread Jakub Kicinski
On Wed, 27 Dec 2017 20:38:11 -0500 (EST), David Miller wrote: > From: Jakub Kicinski > Date: Wed, 27 Dec 2017 15:36:49 -0800 > > > After TC offloads were converted to callbacks we have no choice > > but keep track of the offloaded filter in the driver. > > > >

Re: [RFC PATCH bpf-next v2 4/4] error-injection: Support fault injection framework

2017-12-27 Thread Alexei Starovoitov
On 12/27/17 5:38 PM, Masami Hiramatsu wrote: On Wed, 27 Dec 2017 14:49:46 -0800 Alexei Starovoitov wrote: On 12/27/17 12:09 AM, Masami Hiramatsu wrote: On Tue, 26 Dec 2017 18:12:56 -0800 Alexei Starovoitov wrote: On Tue, Dec 26, 2017 at

[net-next PATCH] net: ptr_ring: otherwise safe empty checks can overrun array bounds

2017-12-27 Thread John Fastabend
When running consumer and/or producer operations and empty checks in parallel its possible to have the empty check run past the end of the array. The scenario occurs when an empty check is run while __ptr_ring_discard_one() is in progress. Specifically after the consumer_head is incremented but

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-27 Thread Alexei Starovoitov
On 12/27/17 6:34 PM, Masami Hiramatsu wrote: On Wed, 27 Dec 2017 14:46:24 -0800 Alexei Starovoitov wrote: On 12/26/17 9:56 PM, Masami Hiramatsu wrote: On Tue, 26 Dec 2017 17:57:32 -0800 Alexei Starovoitov wrote: On Tue, Dec 26, 2017 at 04:46:59PM

[PATCH bpf-next v3 1/9] bpf: offload: don't require rtnl for dev list manipulation

2017-12-27 Thread Jakub Kicinski
We don't need the RTNL lock for all operations on offload state. We only need to hold it around ndo calls. The device offload initialization doesn't require it. The soon-to-come querying of the offload info will only need it partially. We will also be able to remove the waitqueue in following

[PATCH bpf-next v3 5/9] bpf: offload: free program id when device disappears

2017-12-27 Thread Jakub Kicinski
Bound programs are quite useless after their device disappears. They are simply waiting for reference count to go to zero, don't list them in BPF_PROG_GET_NEXT_ID by freeing their ID early. Note that orphaned offload programs will return -ENODEV on BPF_OBJ_GET_INFO_BY_FD so user will never see ID

[PATCH bpf-next v3 4/9] bpf: offload: free prog->aux->offload when device disappears

2017-12-27 Thread Jakub Kicinski
All bpf offload operations should now be under bpf_devs_lock, it's safe to free and clear the entire offload structure, not only the netdev pointer. __bpf_prog_offload_destroy() will no longer be called multiple times. Suggested-by: Alexei Starovoitov Signed-off-by: Jakub

[PATCH bpf-next v3 3/9] bpf: offload: allow netdev to disappear while verifier is running

2017-12-27 Thread Jakub Kicinski
To allow verifier instruction callbacks without any extra locking NETDEV_UNREGISTER notification would wait on a waitqueue for verifier to finish. This design decision was made when rtnl lock was providing all the locking. Use the read/write lock instead and remove the workqueue. Verifier will

[PATCH bpf-next v3 9/9] selftests/bpf: test device info reporting for bound progs

2017-12-27 Thread Jakub Kicinski
Check if bound programs report correct device info. Test in local namespace, in remote one, back to the local ns, remove the device and check that information is cleared. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --

[PATCH bpf-next v3 7/9] bpf: offload: report device information for offloaded programs

2017-12-27 Thread Jakub Kicinski
Report to the user ifindex and namespace information of offloaded programs. If device has disappeared return -ENODEV. Specify the namespace using dev/inode combination. CC: Eric W. Biederman Signed-off-by: Jakub Kicinski --- v3: -

[PATCH bpf-next v3 6/9] nsfs: generalize ns_get_path() for path resolution with a task

2017-12-27 Thread Jakub Kicinski
ns_get_path() takes struct task_struct and proc_ns_ops as its parameters. For path resolution directly from a namespace, e.g. based on a networking device's net name space, we need more flexibility. Add a ns_get_path_cb() helper which will allow callers to use any method of obtaining the name

[PATCH bpf-next v3 8/9] tools: bpftool: report device information for offloaded programs

2017-12-27 Thread Jakub Kicinski
Print the just-exposed device information about device to which program is bound. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/common.c | 52 ++

[PATCH bpf-next v3 2/9] bpf: offload: don't use prog->aux->offload as boolean

2017-12-27 Thread Jakub Kicinski
We currently use aux->offload to indicate that program is bound to a specific device. This forces us to keep the offload structure around even after the device is gone. Add a bool member to struct bpf_prog_aux to indicate if offload was requested. Suggested-by: Alexei Starovoitov

[PATCH bpf-next v3 0/9] bpf: offload: report device back to user space (take 2)

2017-12-27 Thread Jakub Kicinski
Hi! This series is a redo of reporting offload device information to user space after the first attempt did not take into account name spaces. As requested by Kirill offloads are now protected by an r/w sem. This allows us to remove the workqueue and free the offload state fully when device is

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-27 Thread Masami Hiramatsu
On Wed, 27 Dec 2017 14:46:24 -0800 Alexei Starovoitov wrote: > On 12/26/17 9:56 PM, Masami Hiramatsu wrote: > > On Tue, 26 Dec 2017 17:57:32 -0800 > > Alexei Starovoitov wrote: > > > >> On Tue, Dec 26, 2017 at 04:46:59PM +0900, Masami Hiramatsu wrote:

Re: pull-request: bpf-next 2017-12-28

2017-12-27 Thread David Miller
From: Daniel Borkmann Date: Thu, 28 Dec 2017 01:18:21 +0100 > The following pull-request contains BPF updates for your *net-next* > tree. Pulled. Any progress on those tests failing on strict alignment architectures?

Re: [RFC PATCH bpf-next v2 4/4] error-injection: Support fault injection framework

2017-12-27 Thread Masami Hiramatsu
On Wed, 27 Dec 2017 14:49:46 -0800 Alexei Starovoitov wrote: > On 12/27/17 12:09 AM, Masami Hiramatsu wrote: > > On Tue, 26 Dec 2017 18:12:56 -0800 > > Alexei Starovoitov wrote: > > > >> On Tue, Dec 26, 2017 at 04:48:25PM +0900, Masami Hiramatsu wrote:

Re: [RFC PATCH net-next] net: hns3: hns3_get_channels() can be static

2017-12-27 Thread David Miller
From: kbuild test robot Date: Thu, 28 Dec 2017 09:09:59 +0800 > > Fixes: 482d2e9c1cc7 ("net: hns3: add support to query tqps number") > Signed-off-by: Fengguang Wu Applied, thanks.

Re: [PATCH net-next] nfp: bpf: allocate vNIC priv for keeping track of the offloaded program

2017-12-27 Thread David Miller
From: Jakub Kicinski Date: Wed, 27 Dec 2017 15:36:49 -0800 > After TC offloads were converted to callbacks we have no choice > but keep track of the offloaded filter in the driver. > > Since this change came a little late in the release cycle > there were a number

Re: pull-request: bpf 2017-12-28

2017-12-27 Thread David Miller
From: Daniel Borkmann Date: Thu, 28 Dec 2017 00:27:23 +0100 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Two small fixes for bpftool. Fix otherwise broken output if any of >the system calls failed when listing

Re: WARNING in strp_data_ready

2017-12-27 Thread Tom Herbert
On Wed, Dec 27, 2017 at 12:20 PM, Ozgur wrote: > > > 27.12.2017, 23:14, "Dmitry Vyukov" : >> On Wed, Dec 27, 2017 at 9:08 PM, Ozgur wrote: >>> 27.12.2017, 22:21, "Dmitry Vyukov" : On Wed, Dec 27, 2017 at 8:09 PM,

[PATCH RFC 0/2] kcm: Fix lockdep issue

2017-12-27 Thread Tom Herbert
When sock_owned_by_user returns true in strparser. Fix is to add and call sock_owned_by_user_nocheck since the check for owned by user is not an error condition in this case. Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages") Reported-by: syzbot Tom

[PATCH RFC 1/2] sock: Add sock_owned_by_user_nocheck

2017-12-27 Thread Tom Herbert
This allows checking socket lock ownership with producing lockdep warnings. Signed-off-by: Tom Herbert --- include/net/sock.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/sock.h b/include/net/sock.h index 6c1db823f8b9..66fd3951e6f3 100644 ---

[PATCH RFC 2/2] strparser: Call sock_owned_by_user_nocheck

2017-12-27 Thread Tom Herbert
strparser wants to check socket ownership without producing any warnings. As indicated by the comment in the code, it is permissible for owned_by_user to return true. Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages") Reported-by: syzbot Signed-off-by:

[net-next:master 731/763] drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:852:6: sparse: symbol 'hns3_get_channels' was not declared. Should it be static?

2017-12-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 55b07a65e15bea6e253a907dacaf89b61fe504ca commit: 482d2e9c1cc7c0e154464e3e052db09e5e62541f [731/763] net: hns3: add support to query tqps number reproduce: # apt-get install sparse git

[RFC PATCH net-next] net: hns3: hns3_get_channels() can be static

2017-12-27 Thread kbuild test robot
Fixes: 482d2e9c1cc7 ("net: hns3: add support to query tqps number") Signed-off-by: Fengguang Wu --- hns3_ethtool.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

Re: [PATCH 1/4] libbpf: add function to setup XDP

2017-12-27 Thread Toshiaki Makita
On 2017/12/28 3:02, Eric Leblond wrote: > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > slightly modified to be library compliant. > > Signed-off-by: Eric Leblond > --- ... > +int bpf_set_link_xdp_fd(int ifindex, int fd, __u32 flags) ... > + if

Re: [PATCHv3 0/2] capability controlled user-namespaces

2017-12-27 Thread महेश बंडेवार
On Wed, Dec 27, 2017 at 12:23 PM, Michael Kerrisk (man-pages) wrote: > Hello Mahesh, > > On 27 December 2017 at 18:09, Mahesh Bandewar (महेश बंडेवार) > wrote: >> Hello James, >> >> Seems like I missed your name to be added into the review of this >>

pull-request: bpf-next 2017-12-28

2017-12-27 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Fix incorrect state pruning related to recognition of zero initialized stack slots, where stacksafe exploration would mistakenly return a positive pruning verdict too early

Re: [Patch net-next] net_sched: remove the unsafe __skb_array_empty()

2017-12-27 Thread John Fastabend
On 12/27/2017 10:29 AM, Cong Wang wrote: > On Sat, Dec 23, 2017 at 10:57 PM, John Fastabend > wrote: >> On 12/22/2017 12:31 PM, Cong Wang wrote: >>> I understand why you had it, but it is just not safe. You don't want >>> to achieve performance gain by crashing system,

[PATCH net-next] nfp: bpf: allocate vNIC priv for keeping track of the offloaded program

2017-12-27 Thread Jakub Kicinski
After TC offloads were converted to callbacks we have no choice but keep track of the offloaded filter in the driver. Since this change came a little late in the release cycle there were a number of conflicts and allocation of vNIC priv structure seems to have slipped away in linux-next.

pull-request: bpf 2017-12-28

2017-12-27 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Two small fixes for bpftool. Fix otherwise broken output if any of the system calls failed when listing maps in json format and instead of bailing out, skip maps or progs that

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Russell King - ARM Linux
On Wed, Dec 27, 2017 at 11:42:52PM +0100, Antoine Tenart wrote: > Hi Russell, > > On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > > > +_eth2 { > > > + /* CPS Lane 5 */ > > > + status = "okay";

Re: [PATCH bpf-next v2 6/8] bpf: offload: report device information for offloaded programs

2017-12-27 Thread Jakub Kicinski
On Wed, 27 Dec 2017 18:26:16 +0100, Daniel Borkmann wrote: > On 12/21/2017 10:01 PM, Jakub Kicinski wrote: > > Report to the user ifindex and namespace information of offloaded > > programs. If device has disappeared return -ENODEV. Specify the > > namespace using dev/inode combination. > > > >

Re: [PATCH v2 bpf-next 0/3] bpf: two stack check fixes

2017-12-27 Thread Daniel Borkmann
On 12/25/2017 10:15 PM, Alexei Starovoitov wrote: > Jann reported an issue with stack depth tracking. Fix it and add tests. > Also fix off-by-one error in MAX_CALL_FRAMES check. > This set is on top of Jann's "selftest for late caller stack size increase" > test. > > Alexei Starovoitov (3): >

Re: [PATCH] bpf: selftest for late caller stack size increase

2017-12-27 Thread Daniel Borkmann
On 12/22/2017 07:12 PM, Jann Horn wrote: > This checks that it is not possible to bypass the total stack size check in > update_stack_depth() by calling a function that uses a large amount of > stack memory *before* using a large amount of stack memory in the caller. > > Currently, the first

Re: [PATCH 3/4] libbpf: break loop earlier

2017-12-27 Thread Daniel Borkmann
On 12/27/2017 09:30 PM, Eric Leblond wrote: > On Wed, 2017-12-27 at 11:00 -0800, Alexei Starovoitov wrote: >> On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote: >>> Get out of the loop when we have a match. >>> >>> Signed-off-by: Eric Leblond >>> --- >>>

Re: [PATCH net-next 09/10] net: qualcomm: rmnet: Add support for TX checksum offload

2017-12-27 Thread kbuild test robot
Hi Subash, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-qualcomm-rmnet-Enable-csum-offloads/20171228-041216 reproduce: # apt-get install sparse

Re: [RFC PATCH bpf-next v2 4/4] error-injection: Support fault injection framework

2017-12-27 Thread Alexei Starovoitov
On 12/27/17 12:09 AM, Masami Hiramatsu wrote: On Tue, 26 Dec 2017 18:12:56 -0800 Alexei Starovoitov wrote: On Tue, Dec 26, 2017 at 04:48:25PM +0900, Masami Hiramatsu wrote: Support in-kernel fault-injection framework via debugfs. This allows you to inject a

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-27 Thread Alexei Starovoitov
On 12/26/17 9:56 PM, Masami Hiramatsu wrote: On Tue, 26 Dec 2017 17:57:32 -0800 Alexei Starovoitov wrote: On Tue, Dec 26, 2017 at 04:46:59PM +0900, Masami Hiramatsu wrote: Check whether error injectable event is on function entry or not. Currently it checks the

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Antoine Tenart
Hi Russell, On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > +_eth2 { > > + /* CPS Lane 5 */ > > + status = "okay"; > > + phy-mode = "2500base-x"; > > + /* Generic PHY, providing serdes

[PATCH ipsec] xfrm: skip policies marked as dead while rehashing

2017-12-27 Thread Florian Westphal
syzkaller triggered following KASAN splat: BUG: KASAN: slab-out-of-bounds in xfrm_hash_rebuild+0xdbe/0xf00 net/xfrm/xfrm_policy.c:618 read of size 2 at addr 8801c8e92fe4 by task kworker/1:1/23 [..] Workqueue: events xfrm_hash_rebuild [..] __asan_report_load2_noabort+0x14/0x20

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Russell King - ARM Linux
On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > This patch enables the fourth network interface on the Marvell > Macchiatobin. It is configured in the 2500Base-X PHY mode. > > Signed-off-by: Antoine Tenart > --- >

[PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-27 Thread Antoine Tenart
This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart --- include/linux/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net-next 3/6] net: mvpp2: 1000baseX support

2017-12-27 Thread Antoine Tenart
This patch adds the 1000Base-X PHY mode support in the Marvell PPv2 driver. 1000Base-X is quite close the SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 45

[PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Antoine Tenart
This patch enables the fourth network interface on the Marvell Macchiatobin. It is configured in the 2500Base-X PHY mode. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 8 1 file changed, 8 insertions(+) diff

[PATCH net-next 0/6] net: mvpp2: 1000BaseX and 2000BaseX support

2017-12-27 Thread Antoine Tenart
Hi all, This series adds 1000BaseX and 2500BaseX support to the Marvell PPv2 driver. In order to use it, the 2.5 SGMII mode is added in the Marvell common PHY driver (cp110-comphy). Thanks to theses patches the fourth network interface can be used on the mcbin, and two patches are attached: one

[PATCH net-next 2/6] phy: cp110-comphy: 2.5G SGMII mode

2017-12-27 Thread Antoine Tenart
This patch allow the CP100 comphy to configure some lanes in the 2.5G SGMII mode. This mode is quite close to SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 17 ++--- 1

[PATCH net-next 4/6] net: mvpp2: 2500baseX support

2017-12-27 Thread Antoine Tenart
This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 40

[PATCH net-next 6/6] arm64: dts: marvell: add Ethernet aliases

2017-12-27 Thread Antoine Tenart
From: Yan Markman This patch adds Ethernet aliases in the Marvell Aramada 7040 DB, 8040 DB and 8040 mcbin device trees so that the bootloader setup the MAC addresses correctly. Signed-off-by: Yan Markman [Antoine: commit message, small fixes]

Re: [patch iproute2 v3 3/4] tc: Add -bs option to batch mode

2017-12-27 Thread Marcelo Ricardo Leitner
On Wed, Dec 27, 2017 at 01:40:24PM -0800, Stephen Hemminger wrote: > On Wed, 27 Dec 2017 18:39:29 -0200 > Marcelo Ricardo Leitner wrote: > > > > > + send = false; > > > > + else > > > > + send = true; > > > > +

Re: [PATCH v2 net-next] net/trace: fix printk format in inet_sock_set_state

2017-12-27 Thread David Miller
From: Yafang Shao Date: Sun, 24 Dec 2017 23:10:39 +0800 > There's a space character missed in the printk messages. > > Put the message into one line could simplify searching for > the messages in the kernel source. > > Fixes: 563e0bb0dc74("net: tracepoint: replace

Re: [PATCH net-next 07/10] net: qualcomm: rmnet: Add support for RX checksum offload

2017-12-27 Thread kbuild test robot
Hi Subash, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-qualcomm-rmnet-Enable-csum-offloads/20171228-041216 reproduce: # apt-get install sparse

Re: [pull request][for-next V2 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

2017-12-27 Thread David Miller
From: David Miller Date: Wed, 27 Dec 2017 17:01:22 -0500 (EST) > Pulled, thank you. Actually, I had to revert. Please fix this and resubmit: drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c: In function ‘esw_offloads_load_reps’:

Re: [pull request][for-next V2 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

2017-12-27 Thread David Miller
From: Saeed Mahameed Date: Sun, 24 Dec 2017 15:45:36 +0200 > Hi Dave and Doug, > > == > This series includes updates for mlx5 E-Switch infrastructures, > to be merged into net-next and rdma-next trees. > > Mark's patches provide E-Switch refactoring that

Re: [PATCH iproute] qdisc: Print offload indication

2017-12-27 Thread Stephen Hemminger
On Tue, 26 Dec 2017 11:48:45 +0200 Yuval Mintz wrote: > Use the newly added TCA_HW_OFFLOAD indication from kernel > to print a consistent 'offloaded' message to user when listing qdiscs. > > Signed-off-by: Yuval Mintz Applied to master (since

Re: [PATCH v2 net-next 0/2] kcm: Fix two locking issues

2017-12-27 Thread David Miller
From: Tom Herbert Date: Sat, 23 Dec 2017 09:17:14 -0800 > One issue is lockdep warnings when sock_owned_by_user returns true > in strparser. Fix is to add and call sock_owned_by_user_nocheck since > the check for owned by user is not an error condition in this case. > > The

Re: [PATCH iproute2 0/3] ip/tunnel: Fix noencap- and document "external" parameter handling.

2017-12-27 Thread Stephen Hemminger
On Wed, 27 Dec 2017 13:28:13 +0200 Serhey Popovych wrote: > In this series I present next set of improvements/fixes: > > 1) Fix noencap- option handling: we need to clear bit, instead > of seting all, but one we expect to clear. > > 2) Document "external"

Re: [PATCH net-next 0/4] zerocopy refinements

2017-12-27 Thread David Miller
From: Willem de Bruijn Date: Fri, 22 Dec 2017 19:00:16 -0500 > From: Willem de Bruijn > > 1/4 is a small optimization follow-up to the earlier fix to skb_segment: > check skb state once per skb, instead of once per frag. > 2/4 makes

Re: [PATCH net-next v2 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2017-12-27 Thread David Miller
From: Jason Baron Date: Fri, 22 Dec 2017 16:54:01 -0500 > The ability to set speed and duplex for virtio_net in useful in various > scenarios as described here: > > 16032be virtio_net: add ethtool support for set and get of settings > > However, it would be nice to be able

Re: [patch iproute2 v3 3/4] tc: Add -bs option to batch mode

2017-12-27 Thread Stephen Hemminger
On Wed, 27 Dec 2017 18:39:29 -0200 Marcelo Ricardo Leitner wrote: > > > + send = false; > > > + else > > > + send = true; > > > + > > > + ret = do_cmd(largc, largv, batch_size, msg_iov_index++, send); > > > > What

Re: lost connection to test machine (3)

2017-12-27 Thread Florian Westphal
Dmitry Vyukov wrote: > On Wed, Dec 27, 2017 at 7:18 PM, syzbot > wrote: > > Hello, > > > > syzkaller hit the following crash on > > beacbc68ac3e23821a681adb30b45dc55b17488d > >

[PATCH] Staging: ipx: fixed several no space before tabs coding style issues

2017-12-27 Thread Jianshen Liu
Fixed several coding style warnings of "please, no space before tabs". Signed-off-by: Jianshen Liu --- drivers/staging/ipx/af_ipx.c| 56 - drivers/staging/ipx/ipx_proc.c | 2 +- drivers/staging/ipx/ipx_route.c | 6 ++--- 3 files

Re: [patch iproute2 v3 3/4] tc: Add -bs option to batch mode

2017-12-27 Thread Marcelo Ricardo Leitner
On Wed, Dec 27, 2017 at 09:39:15AM -0600, David Ahern wrote: > On 12/25/17 2:46 AM, Chris Mi wrote: > > Signed-off-by: Chris Mi > > --- > > tc/m_action.c | 91 +-- > > tc/tc.c| 47 ++ > > tc/tc_common.h |

Re: [PATCH v3 1/4] security: Add support for SCTP security hooks

2017-12-27 Thread Paul Moore
On Wed, Dec 27, 2017 at 11:22 AM, Richard Haines wrote: > On Fri, 2017-12-22 at 15:45 -0200, Marcelo Ricardo Leitner wrote: >> On Fri, Dec 22, 2017 at 09:20:45AM -0800, Casey Schaufler wrote: >> > On 12/22/2017 5:05 AM, Marcelo Ricardo Leitner wrote: >> > > From:

Re: [PATCH 3/4] libbpf: break loop earlier

2017-12-27 Thread Eric Leblond
Hello, On Wed, 2017-12-27 at 11:00 -0800, Alexei Starovoitov wrote: > On Wed, Dec 27, 2017 at 07:02:28PM +0100, Eric Leblond wrote: > > Get out of the loop when we have a match. > > > > Signed-off-by: Eric Leblond > > --- > > tools/lib/bpf/libbpf.c | 1 + > > 1 file changed, 1

Re: [PATCHv3 0/2] capability controlled user-namespaces

2017-12-27 Thread Michael Kerrisk (man-pages)
Hello Mahesh, On 27 December 2017 at 18:09, Mahesh Bandewar (महेश बंडेवार) wrote: > Hello James, > > Seems like I missed your name to be added into the review of this > patch series. Would you be willing be pull this into the security > tree? Serge Hallyn has already ACKed

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-27 Thread David Ahern
On 12/27/17 1:31 PM, Andrew Lunn wrote: >> Hmm. That documents mainly sysfs. No mention of Netlink at all. But >> maybe I missed it. Also, that defines the interface as is. However we >> are talking about the data exchanged over the interface, not the >> interface itself. I don't see how ASIC/HW

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-27 Thread Arkadi Sharshevsky
On 12/27/2017 06:34 PM, David Ahern wrote: > On 12/27/17 2:09 AM, Jiri Pirko wrote: >> Wed, Dec 27, 2017 at 05:05:09AM CET, d...@cumulusnetworks.com wrote: >>> On 12/26/17 5:23 AM, Jiri Pirko wrote: From: Jiri Pirko Many of the ASIC's internal resources are

Re: WARNING in strp_data_ready

2017-12-27 Thread Dmitry Vyukov
On Wed, Dec 27, 2017 at 9:08 PM, Ozgur wrote: > > > 27.12.2017, 22:21, "Dmitry Vyukov" : >> On Wed, Dec 27, 2017 at 8:09 PM, Tom Herbert wrote: >>> Did you try the patch I posted? >> >> Hi Tom, > > Hello Dmitry, > >> No. And I didn't

Re: [patch iproute2 v3 3/4] tc: Add -bs option to batch mode

2017-12-27 Thread Marcelo Ricardo Leitner
On Mon, Dec 25, 2017 at 05:46:57PM +0900, Chris Mi wrote: > @@ -267,6 +287,7 @@ int main(int argc, char **argv) > { > int ret; > char *batch_file = NULL; > + int batch_size = 1; > > while (argc > 1) { > if (argv[1][0] != '-') > @@ -297,6 +318,14 @@ int

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-27 Thread Roopa Prabhu
On Wed, Dec 27, 2017 at 8:34 AM, David Ahern wrote: > On 12/27/17 2:09 AM, Jiri Pirko wrote: >> Wed, Dec 27, 2017 at 05:05:09AM CET, d...@cumulusnetworks.com wrote: >>> On 12/26/17 5:23 AM, Jiri Pirko wrote: From: Jiri Pirko Many of the

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-27 Thread Andrew Lunn
> Hmm. That documents mainly sysfs. No mention of Netlink at all. But > maybe I missed it. Also, that defines the interface as is. However we > are talking about the data exchanged over the interface, not the > interface itself. I don't see how ASIC/HW specific thing, like for > example KVD in our

Re: [PATCH net] sfp: fix sfp-bus oops when removing socket/upstream

2017-12-27 Thread Florian Fainelli
On 12/26/2017 03:15 PM, Russell King wrote: > When we remove a socket or upstream, and the other side isn't > registered, we dereference a NULL pointer, causing a kernel oops. > Fix this. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli

Re: [PATCH net] phylink: ensure we report link down when LOS asserted

2017-12-27 Thread Florian Fainelli
On 12/26/2017 03:15 PM, Russell King wrote: > Although we disable the netdev carrier, we fail to report in the kernel > log that the link went down. Fix this. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli Fixes: 9525ae83959b

Re: WARNING in strp_data_ready

2017-12-27 Thread Dmitry Vyukov
On Wed, Dec 27, 2017 at 8:09 PM, Tom Herbert wrote: > Did you try the patch I posted? Hi Tom, No. And I didn't know I need to. Why? If you think the patch needs additional testing, you can ask syzbot to test it. See

[PATCH v3 bpf-next 1/2] tools/bpftool: use version from the kernel source tree

2017-12-27 Thread Roman Gushchin
Bpftool determines it's own version based on the kernel version, which is picked from the linux/version.h header. It's strange to use the version of the installed kernel headers, and makes much more sense to use the version of the actual source tree, where bpftool sources are. Fix this by

  1   2   >