Re: [PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

On 2018/01/26 13:01, Alexander Duyck wrote: > On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier wrote: > > This reverts commit 16ecba59bc333d6282ee057fb02339f77a880beb. > > > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > > 7526125 do not link up

Re: [benet] possible endianness bug in be_cmd_txq_create()

On Sun, Dec 10, 2017 at 10:11 PM, Al Viro wrote: > > In be_cmd_txq_create() we have > if (req->hdr.version > 0) > req->if_id = cpu_to_le16(adapter->if_handle); > req->num_pages = PAGES_4K_SPANNED(q_mem->va, q_mem->size); >

Re: [PATCH 1/3] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

On 2018/01/26 08:50, Alexander Duyck wrote: > On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier wrote: > > This reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d. > > > > We keep the fix for the first part of the problem (1) described in the log > > of that commit however

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

Tetsuo Handa wrote: > syzbot wrote: > > syzbot hit the following crash on net-next commit > > 6bb46bc57c8e9ce947cc605e555b7204b44d2b10 (Fri Jan 26 16:00:23 2018 +) > > Merge branch 'cxgb4-fix-dump-collection-when-firmware-crashed' > > > > C reproducer is

Re: [PATCH net-next 00/12] ptr_ring fixes

On 2018年01月26日 07:36, Michael S. Tsirkin wrote: This fixes a bunch of issues around ptr_ring use in net core. One of these: "tap: fix use-after-free" is also needed on net, but can't be backported cleanly. I will post a net patch separately. Lightly tested - Jason, could you pls confirm this

Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

On 2018年01月29日 12:41, Michael S. Tsirkin wrote: On Mon, Jan 29, 2018 at 11:36:09AM +0800, Jason Wang wrote: On 2018年01月26日 10:46, Michael S. Tsirkin wrote: On 2018年01月26日 07:36, Michael S. Tsirkin wrote: Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array

Re: [PATCH stable 4.9 1/8] x86: bpf_jit: small optimization in emit_bpf_tail_call()

Hi, [ replaced stable@ and greg@ by netdev@ as my question below is not relevant to stable ] On Mon, Jan 29, 2018 at 02:48:54AM +0100, Daniel Borkmann wrote: > From: Eric Dumazet > > [ upstream commit 84ccac6e7854ebbfb56d2fc6d5bef9be49bb304c ] > > Saves 4 bytes

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

On Sun, Jan 28, 2018 at 10:09 PM, John Fastabend wrote: > On 01/28/2018 09:57 PM, Cong Wang wrote: >> On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend >> wrote: >>> On 01/25/2018 06:26 PM, Cong Wang wrote: This pathcset restores the

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

On 01/28/2018 09:57 PM, Cong Wang wrote: > On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend > wrote: >> On 01/25/2018 06:26 PM, Cong Wang wrote: >>> This pathcset restores the pfifo_fast qdisc behavior of dropping >>> packets based on latest dev->tx_queue_len. Patch 1

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend wrote: > We have time (its only in net-next) so lets do the complete fix > rather than this series IMO. Also have to remind you: this patchset fixes a regression introduced by your patchset in net-next, it is not a new

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

On Sun, Jan 28, 2018 at 9:35 PM, John Fastabend wrote: > On 01/25/2018 06:26 PM, Cong Wang wrote: >> This pathcset restores the pfifo_fast qdisc behavior of dropping >> packets based on latest dev->tx_queue_len. Patch 1 introduces >> a helper, patch 2 introduces a new

Re: [Patch net-next v3 0/3] net_sched: reflect tx_queue_len change for pfifo_fast

On 01/25/2018 06:26 PM, Cong Wang wrote: > This pathcset restores the pfifo_fast qdisc behavior of dropping > packets based on latest dev->tx_queue_len. Patch 1 introduces > a helper, patch 2 introduces a new Qdisc ops which is called when > we modify tx_queue_len, patch 3 implements this ops for

Re: [PATCH] devinet_ioctl(): Set ret to 0 when breaking out of the switch-case

On Sun, Jan 28, 2018 at 8:48 PM, Christoph Paasch wrote: > Commit 03aef17bb79b ("devinet_ioctl(): take copyin/copyout to caller") > introduced a regression when using ifconfig. ifconfig doesn't show the > address anymore. The reason is that the above patch changed the flow in >

[PATCH] devinet_ioctl(): Set ret to 0 when breaking out of the switch-case

Commit 03aef17bb79b ("devinet_ioctl(): take copyin/copyout to caller") introduced a regression when using ifconfig. ifconfig doesn't show the address anymore. The reason is that the above patch changed the flow in devinet_ioctl(), where we break; and end up returning ret. ret however is set to

Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

On Mon, Jan 29, 2018 at 11:36:09AM +0800, Jason Wang wrote: > > > On 2018年01月26日 10:46, Michael S. Tsirkin wrote: > > > On 2018年01月26日 07:36, Michael S. Tsirkin wrote: > > > > Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can > > > > overrun array bounds") a lockless use

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sun, Jan 28, 2018 at 3:02 PM, Stephen Hemminger wrote: > On Fri, 26 Jan 2018 18:30:03 -0800 > Jakub Kicinski wrote: > >> On Fri, 26 Jan 2018 15:30:35 -0800, Samudrala, Sridhar wrote: >> > On 1/26/2018 2:47 PM, Jakub Kicinski wrote: >> > > On Sat, 27

Re: [PATCH net] net_sched: gen_estimator: fix lockdep splat

On Sat, Jan 27, 2018 at 10:58 AM, Eric Dumazet wrote: > From: Eric Dumazet > > syzbot reported a lockdep splat in gen_new_estimator() / > est_fetch_counters() when attempting to lock est->stats_lock. > > Since est_fetch_counters() is called from BH

Re: [PATCH net-next 05/12] ptr_ring: disallow lockless __ptr_ring_full

On 2018年01月26日 10:46, Michael S. Tsirkin wrote: On 2018年01月26日 07:36, Michael S. Tsirkin wrote: Similar to bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array bounds") a lockless use of __ptr_ring_full might cause an out of bounds access. We can fix this, but it's

Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 2018年01月24日 00:03, Samudrala, Sridhar wrote: On 1/23/2018 2:33 AM, Jason Wang wrote: On 2018年01月12日 13:58, Sridhar Samudrala wrote:   static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)   {   struct virtnet_info *vi = netdev_priv(dev);   int qnum =

Re: [Patch net-next v3 3/3] net_sched: implement ->change_tx_queue_len() for pfifo_fast

On 2018年01月26日 12:01, Cong Wang wrote: Is __skb_array_empty() in pfifo_fast_dequeue() still safe after this change? Yes, we sync with dequeue path before calling ->change_tx_queue_len(). I already mentioned this in patch 2/3. Aha, ok, I think I get the synchronize_net() trick in

Re: [PATCH net-next,v2 2/2] net: sched: add em_ipt ematch for calling xtables matches

On Fri, Jan 26, 2018 at 11:57 AM, Eyal Birger wrote: > On Fri, Jan 26, 2018 at 8:50 PM, Pablo Neira Ayuso > wrote: >> Isn't there a way to reject the use of this from ->change()? ie. from >> control plane configuration. > > I wasn't able to find a

Re: [PATCH v2 0/4] Check size of packets before sending

Eric Dumazet writes: > On Fri, 2018-01-26 at 00:44 +1100, Daniel Axtens wrote: >> Hi Eric, >> >> > May I ask which tree are you targeting ? >> > >> > ( Documentation/networking/netdev-FAQ.txt ) >> >> I have been targeting net-next, but I haven't pulled for about two >>

Re: pull-request: wireless-drivers-next 2018-01-26

From: Kalle Valo Date: Fri, 26 Jan 2018 19:04:29 +0200 > this is a pull request to net-next for 4.16, more info in the signed > tag below. Please let me know if you have any problems. Pulled, thanks Kalle.

Re: [PATCH net-next] sfc: mark some unexported symbols as static

From: Edward Cree Date: Fri, 26 Jan 2018 17:00:39 + > From: kbuild test robot > > efx_default_channel_want_txqs() is only used in efx.c, while > efx_ptp_want_txqs() and efx_ptp_channel_type (a struct) are only used > in ptp.c. In all cases

Re: [4.15-rc9] fs_reclaim lockdep trace

On Sun, Jan 28, 2018 at 02:55:28PM +0900, Tetsuo Handa wrote: > Dave, would you try below patch? > > >From cae2cbf389ae3cdef1b492622722b4aeb07eb284 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Sun, 28 Jan 2018 14:17:14 +0900 > Subject: [PATCH]

Re: [Patch net-next v3 3/3] net_sched: implement ->change_tx_queue_len() for pfifo_fast

On Fri, Jan 26, 2018 at 6:10 AM, Michael S. Tsirkin wrote: > > This part? Yes, dev_deactivate() as you quote. > > + bool up = dev->flags & IFF_UP; > + unsigned int i; > + int ret = 0; > + > + if (up) > + dev_deactivate(dev); > + > +

Re: [Patch net-next v3 2/3] net_sched: plug in qdisc ops change_tx_queue_len

On Fri, Jan 26, 2018 at 6:16 AM, Michael S. Tsirkin wrote: > > This drops all packets in the queue. I don't think tweaking the queue > length did this previously - did it? No, because previously only enqueue reads the value. > If not this change might surprise some people. It

Re: [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2018-01-26

From: Jeff Kirsher Date: Fri, 26 Jan 2018 13:24:44 -0800 > This series contains updates to i40e and i40evf. Pulled, but please address Or's feedback for patch #7. That private flag shouldn't be necessary.

Re: pull-request: bpf-next 2018-01-26

From: Alexei Starovoitov Date: Fri, 26 Jan 2018 17:53:17 -0800 > The following pull-request contains BPF updates for your *net-next* > tree. Pulled, thanks Alexei.

net-next is CLOSED...

With the release of 4.15 final, the net-next tree is close. Please do not try to submit cleanups or new features at this time, I will immediately toss them from patchwork. Work on fixing bugs instead :-)

Re: linux-next: build failure after merge of the net-next tree

From: Stephen Rothwell Date: Mon, 29 Jan 2018 12:50:28 +1100 > I have applied the following merge fix patch for today: > > From: Stephen Rothwell > Date: Mon, 29 Jan 2018 12:34:37 +1100 > Subject: [PATCH] net: fixup for "net: tcp: close sock if net

linux-next: build failure after merge of the net-next tree

Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from /home/sfr/next/next/include/linux/init_task.h:17:0, from /home/sfr/next/next/init/init_task.c:2: /home/sfr/next/next/include/net/net_namespace.h:

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sun, Jan 28, 2018 at 1:01 PM, Samudrala, Sridhar wrote: > > > On 1/28/2018 12:18 PM, Alexander Duyck wrote: >> >> On Sun, Jan 28, 2018 at 11:18 AM, Samudrala, Sridhar >> wrote: >>> >>> On 1/28/2018 9:35 AM, Alexander Duyck wrote:

Re: kernel panic: Out of memory and no killable processes... (2)

syzbot wrote: > syzbot hit the following crash on net-next commit > 6bb46bc57c8e9ce947cc605e555b7204b44d2b10 (Fri Jan 26 16:00:23 2018 +) > Merge branch 'cxgb4-fix-dump-collection-when-firmware-crashed' > > C reproducer is attached. > syzkaller reproducer is attached. > Raw console output is

Re: [PATCH net-next v2 00/12] net: sched: propagate extack to cls offloads on destroy and only with skip_sw

On Thu, Jan 25, 2018 at 02:57:17PM -0800, Jakub Kicinski wrote: > On Thu, 25 Jan 2018 13:11:57 -0200, Marcelo Ricardo Leitner wrote: > > On Wed, Jan 24, 2018 at 12:54:12PM -0800, Jakub Kicinski wrote: > > > Hi! > > > > > > This series some of Jiri's comments and the fact that today drivers > > >

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/28/2018 03:45 PM, Greg KH wrote: > On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: >> On 01/24/2018 11:07 AM, David Woodhouse wrote: >>> On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: On 01/09/2018 07:04 PM, Alexei Starovoitov wrote: > > The BPF

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, 26 Jan 2018 18:30:03 -0800 Jakub Kicinski wrote: > On Fri, 26 Jan 2018 15:30:35 -0800, Samudrala, Sridhar wrote: > > On 1/26/2018 2:47 PM, Jakub Kicinski wrote: > > > On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: > > >> On Fri, Jan 26, 2018 at

Re: general protection fault in ip6t_do_table

syzbot wrote: > CPU: 0 PID: 3675 Comm: syzkaller168273 Not tainted 4.15.0-rc9+ #283 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01/01/2011 > RIP: 0010:ip6t_do_table+0x12de/0x19d0

Re: [PATCH net] netfilter: xt_hashlimit: do not allow empty names

Eric Dumazet wrote: > On Sun, 2018-01-28 at 07:41 -0800, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Syzbot reported a WARN() in proc_create_data() [1] > > > > Issue here is that xt_hashlimit does not check that user space provided > > an

Re: possible deadlock in do_ip_getsockopt

syzbot wrote: > syzbot hit the following crash on upstream commit > c4e0ca7fa24137e372d6135fe16e8df8e123f116 (Fri Jan 26 23:10:50 2018 +) > Merge tag 'riscv-for-linus-4.15-maintainers' of >

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/28/2018 12:18 PM, Alexander Duyck wrote: On Sun, Jan 28, 2018 at 11:18 AM, Samudrala, Sridhar wrote: On 1/28/2018 9:35 AM, Alexander Duyck wrote: On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski wrote: On Fri, 26 Jan 2018 21:33:01 -0800,

Re: [PATCH bpf-next 01/13] bpf: xor of a/x in cbpf can be done

On 01/28/2018 07:58 PM, Naveen N. Rao wrote: > in 32 bit alu > > Daniel Borkmann wrote: >> Very minor optimization; saves 1 byte per program in x86_64 >> JIT in cBPF prologue. > > ... but increases program size by 4 bytes on ppc64 :( > In general, this is an area I've been wanting to spend some

[PATCH] net: ethernet: i40e: remove i40e_fcoe files

i40e_fcoe support was removed via commit 9eed69a9147c ("i40e: Drop FCoE code from core driver files") But this left files in place but uncompilable. Let's finish the cleaning. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1571

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Sun, Jan 28, 2018 at 11:18 AM, Samudrala, Sridhar wrote: > On 1/28/2018 9:35 AM, Alexander Duyck wrote: >> >> On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski wrote: >>> >>> On Fri, 26 Jan 2018 21:33:01 -0800, Samudrala, Sridhar wrote: >> >>

Re: [PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case

On (01/28/18 19:39), Willem de Bruijn wrote: > > But the whole test program is rather simplistic, since it doesnt > > actually verify the value of the cookies (hopefully me pending : > It might be nice to at least increment the variable on each > successful send. The test is single threaded

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/28/2018 9:35 AM, Alexander Duyck wrote: On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski wrote: On Fri, 26 Jan 2018 21:33:01 -0800, Samudrala, Sridhar wrote: 3 netdev model breaks this configuration starting with the creation and naming of the 2 devices to udev needing to

Re: kernel 4.15.0-rc9+ (net-next) high cpu load at 50Gbit/s - about 6Mpps

On Sun, 2018-01-28 at 19:26 +0100, Paweł Staszewski wrote: > > W dniu 27.01.2018 o 23:23, Paweł Staszewski pisze: > > Hi > > > > > > Today I made some real life traffic tests with kernel 4.15.0-rc9 > > > > but when traffic reach 50Gbit/s and about 6Mpps cpou load rises fast > > from 48% to

Re: [PATCH bpf-next 01/13] bpf: xor of a/x in cbpf can be done

in 32 bit alu Daniel Borkmann wrote: Very minor optimization; saves 1 byte per program in x86_64 JIT in cBPF prologue. ... but increases program size by 4 bytes on ppc64 :( In general, this is an area I've been wanting to spend some time on. Powerpc doesn't have 32-bit sub-registers, so we

Re: [PATCH net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock

On Sun, Jan 28, 2018 at 5:18 PM, Sowmini Varadhan wrote: > On (01/28/18 14:51), Willem de Bruijn wrote: >> > On (01/25/18 15:44), Willem de Bruijn wrote: > ; >> >> You may alos be able to do the same as tcp zerocopy and >> >> hold an sk reference on the

Re: [PATCH bpf-next 08/13] bpf, ppc64: remove obsolete exception handling from div/mod

Daniel Borkmann wrote: Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from ppc64 JIT. Signed-off-by: Daniel Borkmann Cc: Naveen N. Rao --- arch/powerpc/net/bpf_jit_comp64.c | 8

Re: [PATCH net-next 4/7] rds: support for zcopy completion notification

On Sun, Jan 28, 2018 at 5:15 PM, Sowmini Varadhan wrote: > > thanks for taking the time to go through the code! > >> >> An alternative that does not require a timer is to batch on the sk >> error queue itself, like tcp zerocopy. That queues the first notification >>

Re: [PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case

On Sun, Jan 28, 2018 at 5:18 PM, Sowmini Varadhan wrote: > > Re-ordering review comments for selftests a bit.. > >> > + cm->cmsg_level = SOL_RDS; >> > + cm->cmsg_type = RDS_CMSG_ZCOPY_COOKIE; >> > + ++cookie; >> > + memcpy(CMSG_DATA(cm), ,

Re: kernel 4.15.0-rc9+ (net-next) high cpu load at 50Gbit/s - about 6Mpps

W dniu 27.01.2018 o 23:23, Paweł Staszewski pisze: Hi Today I made some real life traffic tests with kernel 4.15.0-rc9 but when traffic reach 50Gbit/s and about 6Mpps cpou load rises fast from 48% to 100% for all cpu cores. Here is some graph that presenting how cpu load rises when there

[PATCH net] netfilter: xt_recent: do not accept / in table name

From: Eric Dumazet proc_create_data() will issue a WARN() otherwise, lets avoid that. name 'syz/\xF5' WARNING: CPU: 1 PID: 3688 at fs/proc/generic.c:163 __xlate_proc_name+0xe6/0x110 fs/proc/generic.c:163 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 3688

Re: [PATCH net] netfilter: xt_hashlimit: do not allow empty names

On Sun, 2018-01-28 at 07:41 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > Syzbot reported a WARN() in proc_create_data() [1] > > Issue here is that xt_hashlimit does not check that user space provided > an empty table name. > Signed-off-by: Eric Dumazet

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Fri, Jan 26, 2018 at 9:58 PM, Jakub Kicinski wrote: > On Fri, 26 Jan 2018 21:33:01 -0800, Samudrala, Sridhar wrote: >> >> 3 netdev model breaks this configuration starting with the creation >> >> and naming of the 2 devices to udev needing to be aware of master and >> >> slave

Re: [PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case

Re-ordering review comments for selftests a bit.. > > + cm->cmsg_level = SOL_RDS; > > + cm->cmsg_type = RDS_CMSG_ZCOPY_COOKIE; > > + ++cookie; > > + memcpy(CMSG_DATA(cm), , sizeof(cookie)); > cookie is not initialized it's a static uint32_t in the function. It will get

Re: [PATCH net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock

On (01/28/18 14:51), Willem de Bruijn wrote: > > On (01/25/18 15:44), Willem de Bruijn wrote: ; > >> You may alos be able to do the same as tcp zerocopy and > >> hold an sk reference on the notification skb. ; > I don't quite follow. Every notification skb is created when pages refcount

Re: [PATCH net-next 4/7] rds: support for zcopy completion notification

thanks for taking the time to go through the code! > > An alternative that does not require a timer is to batch on the sk > error queue itself, like tcp zerocopy. That queues the first notification > skb on the error queue without any notification latency. > > Then, if a subsequent

[PATCH net] netfilter: xt_hashlimit: do not allow empty names

From: Eric Dumazet Syzbot reported a WARN() in proc_create_data() [1] Issue here is that xt_hashlimit does not check that user space provided an empty table name. [1] name len 0 WARNING: CPU: 0 PID: 3680 at fs/proc/generic.c:354 __proc_create+0x696/0x880

Re: [net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2018-01-26

From: Jeff Kirsher Date: Fri, 26 Jan 2018 10:26:11 -0800 > This series contains updates to ixgbe and ixgbevf. Pulled, thanks Jeff.

Re: [PATCH net-next] net/rocker: Remove unreachable return instruction

From: Leon Romanovsky Date: Sun, 28 Jan 2018 15:54:38 +0200 > From: Leon Romanovsky > > The "return 0" instruction follows other return instruction > and it makes it impossible to execute, hence remove it. > > Fixes: 00fc0c51e35b ("rocker: Change

Re: [PATCH v3 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

On Wed, Jan 24, 2018 at 11:10:50AM +0100, Daniel Borkmann wrote: > On 01/24/2018 11:07 AM, David Woodhouse wrote: > > On Tue, 2018-01-09 at 22:39 +0100, Daniel Borkmann wrote: > >> On 01/09/2018 07:04 PM, Alexei Starovoitov wrote: > >>> > >>> The BPF interpreter has been used as part of the

Re: [PATCH] ipv4: Get the address of interface correctly.

On Sun, Jan 28, 2018 at 02:19:08PM +, Al Viro wrote: > On Sun, Jan 28, 2018 at 03:38:58AM -0800, Tonghao Zhang wrote: > > When using ioctl to get address of interface, we can't > > get it anymore. For example, the command is show as below. > > > > # ifconfig eth0 > > > > In the patch

Re: [PATCH] Carrier detect ok, don't turn off negotiation

Denis Du writes: >>From the above code, I can get that only Carrier have some change, it > will restart the protocol by hdlc_proto_start(dev);and thus the timer, > the previous timer expired due to protocol fail. > > If carrier keep no change by if (hdlc->carrier == on) >   

Re: [PATCH] ipv4: Get the address of interface correctly.

On Sun, Jan 28, 2018 at 03:38:58AM -0800, Tonghao Zhang wrote: > When using ioctl to get address of interface, we can't > get it anymore. For example, the command is show as below. > > # ifconfig eth0 > > In the patch ("03aef17bb79b3"), the devinet_ioctl does not > return a suitable value,

Re: [PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case

On Wed, Jan 24, 2018 at 12:46 PM, Sowmini Varadhan wrote: > Send a cookie with sendmsg() on PF_RDS sockets, and process the > returned batched cookies in do_recv_completion() > > Signed-off-by: Sowmini Varadhan > --- >

Re: [PATCH net-next 6/7] selftests/net: add support for PF_RDS sockets

On Wed, Jan 24, 2018 at 12:46 PM, Sowmini Varadhan wrote: > Add support for basic PF_RDS client-server testing in msg_zerocopy > > Signed-off-by: Sowmini Varadhan > --- > tools/testing/selftests/net/msg_zerocopy.c | 65 >

Re: [PATCH net-next 5/7] rds: zerocopy Tx support.

On Wed, Jan 24, 2018 at 12:46 PM, Sowmini Varadhan wrote: > If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and, > if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, > application pages sent down with rds_sendmsg() are pinned. > > The

Re: [PATCH net-next 4/7] rds: support for zcopy completion notification

On Wed, Jan 24, 2018 at 12:45 PM, Sowmini Varadhan wrote: > RDS removes a datagram (rds_message) from the retransmit queue when > an ACK is received. The ACK indicates that the receiver has queued > the RDS datagram, so that the sender can safely forget the datagram.

[PATCH net-next] net/rocker: Remove unreachable return instruction

From: Leon Romanovsky The "return 0" instruction follows other return instruction and it makes it impossible to execute, hence remove it. Fixes: 00fc0c51e35b ("rocker: Change world_ops API and implementation to be switchdev independant") Signed-off-by: Leon Romanovsky

Re: [PATCH net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock

On Thu, Jan 25, 2018 at 4:35 PM, Sowmini Varadhan wrote: > On (01/25/18 15:44), Willem de Bruijn wrote: >> > This patch manages the m_rs assignment in the rds_message with >> > the necessary refcount book-keeping. >> >> You may alos be able to do the same as tcp

[PATCH] ipv4: Get the address of interface correctly.

When using ioctl to get address of interface, we can't get it anymore. For example, the command is show as below. # ifconfig eth0 In the patch ("03aef17bb79b3"), the devinet_ioctl does not return a suitable value, even though we can find it in the kernel. Then fix it now. Fixes:

Re: [bpf-next PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames

Hi, On Sat, 2018-01-27 at 18:27 +0100, Jesper Dangaard Brouer wrote: > If clang >= 4.0.1 is missing the option '-target bpf', it will cause > llc/llvm to create two ELF sections for "Exception Frames", with > section names '.eh_frame' and '.rel.eh_frame'. > > The BPF ELF loader library libbpf