Re: [net-next v3 0/2] eBPF seccomp filters

2018-02-28 Thread chris hyser
On 02/28/2018 02:56 PM, Daniel Borkmann wrote: On 02/28/2018 12:55 AM, chris hyser wrote: If you're implying that because seccomp would have it's own verifier and could therefore restrict itself to a subset of eBPF, therefore any future additions/features to eBPF would not necessarily make

Re: [RFC PATCH v2] ptr_ring: linked list fallback

2018-02-28 Thread Jason Wang
On 2018年02月28日 23:43, Michael S. Tsirkin wrote: On Wed, Feb 28, 2018 at 10:20:33PM +0800, Jason Wang wrote: On 2018年02月28日 22:01, Michael S. Tsirkin wrote: On Wed, Feb 28, 2018 at 02:28:21PM +0800, Jason Wang wrote: On 2018年02月28日 12:09, Michael S. Tsirkin wrote: Or we can add plist to a

Re: [PATCH] e1000e: Fix link status in case of error.

2018-02-28 Thread Benjamin Poirier
On 2018/02/28 08:48, Alexander Duyck wrote: > On Tue, Feb 27, 2018 at 9:20 PM, Benjamin Poirier wrote: > > Before commit 19110cfbb34d ("e1000e: Separate signaling for link check/link > > up"), errors which happen after "get_link_status = false" in the copper > > check_for_link

[PATCH v2 4/4] net: make skb_gso_*_seglen functions private

2018-02-28 Thread Daniel Axtens
They're very hard to use properly as they do not consider the GSO_BY_FRAGS case. Code should use skb_gso_validate_network_len and skb_gso_validate_mac_len as they do consider this case. Make the seglen functions static, which stops people using them outside of skbuff.c Signed-off-by: Daniel

[PATCH v2 1/4] net: rename skb_gso_validate_mtu -> skb_gso_validate_network_len

2018-02-28 Thread Daniel Axtens
If you take a GSO skb, and split it into packets, will the network length (L3 headers + L4 headers + payload) of those packets be small enough to fit within a given MTU? skb_gso_validate_mtu gives you the answer to that question. However, we recently added to add a way to validate the MAC length

[PATCH v2 2/4] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-28 Thread Daniel Axtens
tbf_enqueue() checks the size of a packet before enqueuing it. However, the GSO size check does not consider the GSO_BY_FRAGS case, and so will drop GSO SCTP packets, causing a massive drop in throughput. Use skb_gso_validate_mac_len() instead, as it does consider that case. Signed-off-by:

[PATCH v2 3/4] net: xfrm: use skb_gso_validate_network_len() to check gso sizes

2018-02-28 Thread Daniel Axtens
Replace skb_gso_network_seglen() with skb_gso_validate_network_len(), as it considers the GSO_BY_FRAGS case. Signed-off-by: Daniel Axtens --- net/ipv4/xfrm4_output.c | 3 ++- net/ipv6/xfrm6_output.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 0/4] GSO_BY_FRAGS correctness improvements

2018-02-28 Thread Daniel Axtens
As requested [1], I went through and had a look at users of gso_size to see if there were things that need to be fixed to consider GSO_BY_FRAGS, and I have tried to improve our helper functions to deal with this case. I found a few. This fixes bugs relating to the use of skb_gso_*_seglen() where

[crypto v8 11/12] chtls: Register chtls Inline TLS with net tls

2018-02-28 Thread Atul Gupta
Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 600

[crypto v8 12/12] Makefile Kconfig

2018-02-28 Thread Atul Gupta
Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16

[crypto v8 09/12] chtls: CPL handler definition

2018-02-28 Thread Atul Gupta
CPL handlers for TLS session, record transmit and receive. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 +++ net/ipv4/tcp_minisocks.c|1 + 2 files changed, 2042 insertions(+) create mode

[crypto v8 08/12] chtls: Key program

2018-02-28 Thread Atul Gupta
Program the tx and rx key on chip. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 394 1 file changed, 394 insertions(+) create mode 100644 drivers/crypto/chelsio/chtls/chtls_hw.c diff --git

[crypto v8 10/12] chtls: Inline crypto request Tx/Rx

2018-02-28 Thread Atul Gupta
TLS handler for record transmit and receive. Create Inline TLS work request and post to FW. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 1867 +++ 1 file changed, 1867 insertions(+) create mode 100644

[crypto v8 06/12] cxgb4: LLD driver changes to enable TLS

2018-02-28 Thread Atul Gupta
Read FW capability. Read key area size. Dump the TLS record count. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++ drivers/net/ethernet/chelsio/cxgb4/sge.c| 98

[crypto v8 05/12] cxgb4: Inline TLS FW Interface

2018-02-28 Thread Atul Gupta
Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 121 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 +

[crypto v8 07/12] chcr: Key Macro

2018-02-28 Thread Atul Gupta
Define macro for TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1 deletion(-) diff

[crypto v8 04/12] chtls: structure and macro definiton

2018-02-28 Thread Atul Gupta
Inline TLS state, connection management. Supporting macros definition. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h| 487 drivers/crypto/chelsio/chtls/chtls_cm.h | 202 + 2 files changed, 689

[PATCH bpf-next] samples/bpf: detach prog from cgroup

2018-02-28 Thread Prashant Bhole
test_cgrp2_sock.sh and test_cgrp2_sock2.sh tests keep the program attached to cgroup even after completion. Using detach functionality of test_cgrp2_sock in both scripts. Signed-off-by: Prashant Bhole --- samples/bpf/test_cgrp2_sock.sh | 1 +

[crypto v8 03/12] tls: support for inline tls

2018-02-28 Thread Atul Gupta
Facility to register Inline TLS drivers to net/tls. Setup TLS_FULL_HW prot to listen on offload device. Cases handled 1. Inline TLS device exists, setup prot for TLS_FULL_HW 2. Atleast one Inline TLS exists, sets TLS_FULL_HW. If non-inline capable device establish connection move to TLS_SW_TX

[crypto v8 02/12] ethtool: enable Inline TLS in HW

2018-02-28 Thread Atul Gupta
Signed-off-by: Atul Gupta --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files changed, 3 insertions(+) diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index db84c51..aacabe2 100644 ---

[crypto v8 01/12] tls: tls_device struct to register TLS drivers

2018-02-28 Thread Atul Gupta
tls_device structure to register Inline TLS drivers with net/tls Signed-off-by: Atul Gupta --- include/net/tls.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/net/tls.h b/include/net/tls.h index 4913430..9bfb91f 100644 ---

[crypto v8 00/12] Chelsio Inline TLS

2018-02-28 Thread Atul Gupta
Series for Chelsio Inline TLS driver (chtls.ko) Use tls ULP infrastructure to register chtls as Inline TLS driver. Chtls use TCP Sockets to transmit and receive TLS record. TCP proto_ops is extended to offload TLS record. T6 adapter provides the following features: -TLS record offload,

[PATCH v2] net: iucv: Free memory obtained by kzalloc

2018-02-28 Thread Arvind Yadav
Free memory, if afiucv_iucv_init is not successful. So calling put_device() before kfree(). This will decrement the last reference. Signed-off-by: Arvind Yadav --- changes in v2: Calling put_device() before kfree(). net/iucv/af_iucv.c | 5 - 1 file

[PATCH net] rds: Incorrect reference counting in TCP socket creation

2018-02-28 Thread Ka-Cheong Poon
Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the accept socket") has a reference counting issue in TCP socket creation when accepting a new connection. The code uses sock_create_lite() to create a kernel socket. But it does not do __module_get() on the socket owner. When the

Re: [PATCH] inet: add bound ports statistic

2018-02-28 Thread Eric Dumazet
On Wed, 2018-02-28 at 22:32 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 28 Feb 2018 18:28:02 -0800 > > > How useful it is to report this information ? > > > > Given REUSEADDR and REUSEPORT, I really wonder what can be derived from > > this counter. > >

[PATCH bpf-next 5/5] samples/bpf: raw tracepoint test

2018-02-28 Thread Alexei Starovoitov
empty raw_tracepoint bpf program to test overhead Signed-off-by: Alexei Starovoitov --- samples/bpf/Makefile| 1 + samples/bpf/bpf_load.c | 13 + samples/bpf/test_overhead_raw_tp_kern.c | 17 +

[PATCH bpf-next 4/5] libbpf: add bpf_raw_tracepoint_open helper

2018-02-28 Thread Alexei Starovoitov
Signed-off-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 11 +++ tools/lib/bpf/bpf.c| 10 ++ tools/lib/bpf/bpf.h| 1 + 3 files changed, 22 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h

[PATCH bpf-next 0/5] bpf, tracing: introduce bpf raw tracepoints

2018-02-28 Thread Alexei Starovoitov
This patch set is a different way to address the pressing need to access task_struct pointers in sched tracepoints from bpf programs. The first approach simply added these pointers to sched tracepoints: https://lkml.org/lkml/2017/12/14/753 which Peter nacked. Few options were discussed and

[PATCH bpf-next 1/5] treewide: remove struct-pass-by-value from tracepoints arguments

2018-02-28 Thread Alexei Starovoitov
Fix all tracepoint arguments to pass structures (large and small) by reference instead of by value. Avoiding passing large structs by value is a good coding style. Passing small structs sometimes is beneficial, but in all cases it makes no difference vs readability of the code. The subsequent

[PATCH bpf-next 2/5] tracepoint: compute num_args at build time

2018-02-28 Thread Alexei Starovoitov
add fancy macro to compute number of arguments passed into tracepoint at compile time and store it as part of 'struct tracepoint'. The number is necessary to check safety of bpf program access that is coming in subsequent patch. for_each_tracepoint_range() api has no users inside the kernel. Make

[PATCH bpf-next 3/5] bpf: introduce BPF_RAW_TRACEPOINT

2018-02-28 Thread Alexei Starovoitov
Introduce BPF_PROG_TYPE_RAW_TRACEPOINT bpf program type to access kernel internal arguments of the tracepoints in their raw form. >From bpf program point of view the access to the arguments look like: struct bpf_raw_tracepoint_args { __u64 args[0]; }; int bpf_prog(struct

Re: [PATCH v4 iproute2-next 0/3] Allow 'ip rule' command to use protocol

2018-02-28 Thread David Ahern
On 2/28/18 4:43 PM, Donald Sharp wrote: > Fix iprule.c to use the actual `struct fib_rule_hdr` and to > allow the end user to see and use the protocol keyword > for rule manipulation. > > v2: Rearrange and code changes as per David Ahern > v3: Fix some missed RTN_XXX to appropriate FR_XX and doc

Re: [PATCH] inet: add bound ports statistic

2018-02-28 Thread David Miller
From: Eric Dumazet Date: Wed, 28 Feb 2018 18:28:02 -0800 > How useful it is to report this information ? > > Given REUSEADDR and REUSEPORT, I really wonder what can be derived from > this counter. > > It seems its semantic is weak. To me none of this really matters.

Re: [PATCH] IP6 Fragment: Export ip6_fragment function

2018-02-28 Thread David Miller
From: Sheena Mira-ato Date: Thu, 1 Mar 2018 10:28:40 +1300 > Export the ip6_fragment function so other loadable kernel > modules can access it. The ipv4 version is already > exported. Missing an appropriate signoff. And there is no reason to export a

[PATCH net-next 0/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-02-28 Thread Jason Wang
Hi: This series tries to re-enable XDP_REDIRECT for mergeable buffer which was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). Main concerns are: - not enough tailroom was reserved which breaks cpumap - complex logic like EWMA and linearizing

[PATCH net-next 1/2] virtio-net: re enable XDP_REDIRECT for mergeable buffer

2018-02-28 Thread Jason Wang
XDP_REDIRECT support for mergeable buffer was removed since commit 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() case"). This is because we don't reserve enough tailroom for struct skb_shared_info which breaks XDP assumption. Other complaints are, the complex linearize

[PATCH net-next 2/2] virtio-net: simplify XDP handling in small buffer

2018-02-28 Thread Jason Wang
We used to do data copy through xdp_linearize_page() for the buffer without sufficient headroom, it brings extra complexity without helping for the performance. So this patch remove it and switch to use generic XDP routine to handle this case. Signed-off-by: Jason Wang ---

Re: [PATCH net-next 2/2] tcp_bbr: remove bbr->tso_segs_goal

2018-02-28 Thread Neal Cardwell
On Wed, Feb 28, 2018 at 5:40 PM, Eric Dumazet wrote: > Its value is computed then immediately used, > there is no need to store it. > > Signed-off-by: Eric Dumazet > --- Acked-by: Neal Cardwell This one also looks great to me.

Re: [PATCH net-next 1/2] tcp_bbr: better deal with suboptimal GSO (II)

2018-02-28 Thread Neal Cardwell
On Wed, Feb 28, 2018 at 5:40 PM, Eric Dumazet wrote: > > This is second part of dealing with suboptimal device gso parameters. > In first patch (350c9f484bde "tcp_bbr: better deal with suboptimal GSO") > we dealt with devices having low gso_max_segs > > Some devices lower

Re: [PATCH] inet: add bound ports statistic

2018-02-28 Thread Eric Dumazet
On Wed, 2018-02-28 at 18:01 -0800, Stephen Hemminger wrote: > This adds a number of bound ports in a network namespace which is > a useful for socket summary (ss) command. It adds one additional > field onto /proc/net/sockstat. > > Since collecting these kind of counters can be sensitive for

[PATCH] inet: add bound ports statistic

2018-02-28 Thread Stephen Hemminger
This adds a number of bound ports in a network namespace which is a useful for socket summary (ss) command. It adds one additional field onto /proc/net/sockstat. Since collecting these kind of counters can be sensitive for large machines, the impact is placed on the reading side which will be

[PATCH v2 net-next 1/5] dsa: Pass the port to get_sset_count()

2018-02-28 Thread Andrew Lunn
By passing the port, we allow different ports to have different statistics. This is useful since some ports have SERDES interfaces with their own statistic counters. Signed-off-by: Andrew Lunn Tested-by: Florian Fainelli Reviewed-by: Vivien Didelot

[PATCH v2 net-next 0/5] Export SERDES stats via ethtool -S

2018-02-28 Thread Andrew Lunn
The mv88e6352 family has a SERDES interface which can be used for example to connect to SFF/SFP modules. This interface has a couple of statistics counters. Add support for including these counters in the output of ethtool -S. Andrew Lunn (5): dsa: Pass the port to get_sset_count() net: dsa:

[PATCH v2 net-next 2/5] net: dsa: mv88e6xxx: Hold mutex while doing stats operations

2018-02-28 Thread Andrew Lunn
Until now, there has been no need to hold the reg mutex while getting the count of statistics, or the strings, because the hardware was not accessed. When adding support for SERDES statistics, it is necessary to access the hardware, to determine if a port is using the SERDES interface. So add

[PATCH v2 net-next 4/5] net: dsa: mv88e6xxx: Add helper to determining if port has SERDES

2018-02-28 Thread Andrew Lunn
Refactor the existing code. This helper will be used for SERDES statistics. Signed-off-by: Andrew Lunn Tested-by: Florian Fainelli --- v2: Use Boolean return value --- drivers/net/dsa/mv88e6xxx/serdes.c | 22 +- 1 file changed, 17

[PATCH v2 net-next 3/5] net: dsa: mv88e6xxx: Allow the SERDES interfaces to have statistics

2018-02-28 Thread Andrew Lunn
When gettting the number of statistics, the strings and the actual statistics, call the SERDES ops if implemented. This means the stats code needs to return the number of strings/stats they have placed into the data, so that the SERDES strings/stats can follow on. Signed-off-by: Andrew Lunn

[PATCH v2 net-next 5/5] net: dsa: mv88e6xxx: Get mv88e6352 SERDES statistics

2018-02-28 Thread Andrew Lunn
Add support for reading the SERDES statistics of the mv88e8352, using the standard ethtool -S option. The SERDES interface can be mapped to either port 4 or 5, so only return statistics on those ports, if the SERDES interface is in use. The counters are reset on read, so need to be accumulated.

Re: [PATCH 5/6] net: add and use helpers when adjusting gso_size

2018-02-28 Thread Daniel Borkmann
On 03/01/2018 01:17 AM, Daniel Axtens wrote: [...] >>> It means that a user loaded eBPF program can trigger logs full of >>> warnings merely by using this eBPF helper and generating GSO'd SCTP >>> traffic. >>> >>> Daniel and Alexei, this is a serious problem. The eBPF helpers >>> mentioned here

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-28 Thread Alexander Duyck
On Wed, Feb 28, 2018 at 2:59 PM, Alex Williamson wrote: > On Wed, 28 Feb 2018 09:49:21 -0800 > Alexander Duyck wrote: > >> On Tue, Feb 27, 2018 at 2:25 PM, Alexander Duyck >> wrote: >> > On Tue, Feb 27, 2018 at

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-28 Thread Andrew Collins
From: Cong Wang > If this is just an iproute2 issue, please fix it there rather in kernel. I'm fine with fixing this as a documentation issue (fix being change man page, MTU "Defaults to unlimited" to "Defaults to 2047"). Note however this does mean that tc-police

Re: [PATCH 5/6] net: add and use helpers when adjusting gso_size

2018-02-28 Thread Daniel Axtens
Hi Daniel, >> It means that a user loaded eBPF program can trigger logs full of >> warnings merely by using this eBPF helper and generating GSO'd SCTP >> traffic. >> >> Daniel and Alexei, this is a serious problem. The eBPF helpers >> mentioned here cannot handle SCTP GSO packets properly, and

Re: [PATCH] net: make tc-police action MTU behavior match documentation

2018-02-28 Thread Cong Wang
On Tue, Feb 27, 2018 at 9:41 AM, Andrew Collins wrote: >> I don't find such statement from the man page: >> http://man7.org/linux/man-pages/man8/tc-police.8.html > > >> What am I missing? > > Under MTU the man page states: > > mtu BYTES[/BYTES] > This is

Re: [PATCH iproute2 2/3] ss: Fix build with old libc headers without AF_VSOCK

2018-02-28 Thread Stephen Hemminger
On Tue, 27 Feb 2018 14:06:51 +0200 Serhey Popovych wrote: > diff --git a/include/compat/libc/bits/socket.h > b/include/compat/libc/bits/socket.h > new file mode 100644 > index 000..25ef0d5 > --- /dev/null > +++ b/include/compat/libc/bits/socket.h > @@ -0,0 +1,15 @@

[PATCH net-next 1/2] gre: add sequence number for collect md mode.

2018-02-28 Thread William Tu
Currently GRE sequence number can only be used in native tunnel mode. This patch adds sequence number support for gre collect metadata mode. RFC2890 defines GRE sequence number to be specific to the traffic flow identified by the key. However, this patch does not implement per-key seqno. The

[PATCH net-next 0/2] gre: add sequence number for collect md mode.

2018-02-28 Thread William Tu
Currently GRE sequence number can only be used in native tunnel mode. The first patch adds sequence number support for gre collect metadata mode, and the second patch tests it using BPF. RFC2890 defines GRE sequence number to be specific to the traffic flow identified by the key. However, this

[PATCH net-next 2/2] samples/bpf: add gre sequence number test.

2018-02-28 Thread William Tu
The patch adds tests for GRE sequence number support for metadata mode tunnel. Signed-off-by: William Tu --- samples/bpf/tcbpf2_kern.c | 6 -- samples/bpf/test_tunnel_bpf.sh | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [PATCH iproute2] devlink: Fix error reporting

2018-02-28 Thread Stephen Hemminger
On Wed, 28 Feb 2018 11:24:22 +0200 Arkadi Sharshevsky wrote: > The current code doesn't set errno in case of extended ack. > > Fixes: 049c58539f5d ("devlink: mnlg: Add support for extended ack") > Signed-off-by: Arkadi Sharshevsky > Acked-by: Jiri

[PATCH v4 iproute2-next 3/3] ip: Allow rules to accept a specified protocol

2018-02-28 Thread Donald Sharp
Allow the specification of a protocol when the user adds/modifies/deletes a rule. Signed-off-by: Donald Sharp --- ip/iprule.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ip/iprule.c b/ip/iprule.c index 8120520e..6fdc9b5e 100644 --- a/ip/iprule.c +++

[PATCH v4 iproute2-next 0/3] Allow 'ip rule' command to use protocol

2018-02-28 Thread Donald Sharp
Fix iprule.c to use the actual `struct fib_rule_hdr` and to allow the end user to see and use the protocol keyword for rule manipulation. v2: Rearrange and code changes as per David Ahern v3: Fix some missed RTN_XXX to appropriate FR_XX and doc changes v4: Cleanup some code, fix 'ip rule save' no

[PATCH v4 iproute2-next 1/3] ip: Use the `struct fib_rule_hdr` for rules

2018-02-28 Thread Donald Sharp
The iprule.c code was using `struct rtmsg` as the data type to pass into the kernel for the netlink message. While 'struct rtmsg' and `struct fib_rule_hdr` are the same size and mostly the same, we should use the correct data structure. This commit translates the data structures to have iprule.c

[PATCH v4 iproute2-next 2/3] ip: Display ip rule protocol used

2018-02-28 Thread Donald Sharp
Modify 'ip rule' command to notice when the kernel passes to us the originating protocol. Add code to allow the `ip rule flush protocol XXX` command to be accepted and properly handled. Modify the documentation to reflect these code changes. Signed-off-by: Donald Sharp

linux-next: build failure after merge of the net-next tree

2018-02-28 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: net/core/devlink.c: In function 'devlink_resource_validate_size': net/core/devlink.c:2349:34: error: invalid type argument of '->' (have 'struct devlink_resource_size_params') if (size >

[net-next PATCH] ixgbevf: fix unused variable warning

2018-02-28 Thread Arnd Bergmann
The new ixgbevf_set_rx_buffer_len() function causes a harmless warnings in configurations with large page size: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function 'ixgbevf_set_rx_buffer_len': drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:1758:15: error: unused variable

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-28 Thread Alex Williamson
On Wed, 28 Feb 2018 09:49:21 -0800 Alexander Duyck wrote: > On Tue, Feb 27, 2018 at 2:25 PM, Alexander Duyck > wrote: > > On Tue, Feb 27, 2018 at 1:40 PM, Alex Williamson > > wrote: > >> On Tue, 27 Feb 2018

Re: [PATCH RFC net-next 10/20] net/ipv6: move expires into rt6_info

2018-02-28 Thread Martin KaFai Lau
On Wed, Feb 28, 2018 at 03:25:02PM -0700, David Ahern wrote: > On 2/28/18 12:21 PM, Martin KaFai Lau wrote: > > On Mon, Feb 26, 2018 at 03:55:14PM -0700, David Ahern wrote: > >> On 2/26/18 3:28 PM, Wei Wang wrote: > @@ -213,11 +234,6 @@ static inline void rt6_set_expires(struct rt6_info >

Re: [PATCH] net/tcp/illinois: replace broken algorithm reference link

2018-02-28 Thread Joey Pabalinas
On Wed, Feb 28, 2018 at 12:03:58PM -0500, David Miller wrote: > Applied, thank you. No problem, cheers. -- Joey Pabalinas signature.asc Description: PGP signature

linux-next: manual merge of the net-next tree with the net tree

2018-02-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlxsw/spectrum.c between commit: 77d270967c5f ("mlxsw: spectrum: Fix handling of resource_size_param") from the net tree and commit: 4f4bbf7c4e3d ("devlink: Perform cleanup of

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-02-28 Thread Gregory Rose
On 2/28/2018 9:49 AM, Alexander Duyck wrote: On Tue, Feb 27, 2018 at 2:25 PM, Alexander Duyck wrote: On Tue, Feb 27, 2018 at 1:40 PM, Alex Williamson wrote: On Tue, 27 Feb 2018 11:06:54 -0800 Alexander Duyck

Re: [PATCH net-next 0/2] tcp_bbr: more GSO work

2018-02-28 Thread Soheil Hassas Yeganeh
On Wed, Feb 28, 2018 at 5:40 PM Eric Dumazet wrote: > Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots, > I found that BBR was performing poorly, because of TSO being limited to 16KB > This patch series makes sure BBR is not under estimating number > of packets

[PATCH net-next 1/2] tcp_bbr: better deal with suboptimal GSO (II)

2018-02-28 Thread Eric Dumazet
This is second part of dealing with suboptimal device gso parameters. In first patch (350c9f484bde "tcp_bbr: better deal with suboptimal GSO") we dealt with devices having low gso_max_segs Some devices lower gso_max_size from 64KB to 16 KB (r8152 is an example) In order to probe an optimal cwnd,

[PATCH net-next 2/2] tcp_bbr: remove bbr->tso_segs_goal

2018-02-28 Thread Eric Dumazet
Its value is computed then immediately used, there is no need to store it. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_bbr.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/net/ipv4/tcp_bbr.c b/net/ipv4/tcp_bbr.c index

[PATCH net-next 0/2] tcp_bbr: more GSO work

2018-02-28 Thread Eric Dumazet
Playing with r8152 USB 1Gbit NIC, on both USB2 and USB3 slots, I found that BBR was performing poorly, because of TSO being limited to 16KB This patch series makes sure BBR is not under estimating number of packets that are needed to fill the pipe when a device has suboptimal TSO limits. Eric

F.LLI PISTOLESI Snc

2018-02-28 Thread . F.LLI PISTOLESI Snc
Hello , I am looking for a reliable supplier /manufacturer of products for sell in Europe. I came across your listing and wanted to get some information regarding minimum Order Quantities, FOB pricing and also the possibility of packaging including payments terms. So could you please get

Re: [PATCH RFC net-next 10/20] net/ipv6: move expires into rt6_info

2018-02-28 Thread David Ahern
On 2/28/18 12:21 PM, Martin KaFai Lau wrote: > On Mon, Feb 26, 2018 at 03:55:14PM -0700, David Ahern wrote: >> On 2/26/18 3:28 PM, Wei Wang wrote: @@ -213,11 +234,6 @@ static inline void rt6_set_expires(struct rt6_info *rt, unsigned long expires) static inline void

Re: [PATCH iproute2] bpf: Print section name when hitting non ld64 issue

2018-02-28 Thread Daniel Borkmann
On 02/28/2018 11:16 PM, Joe Stringer wrote: > It's useful to be able to tell which section is being processed in the > ELF when this error is triggered, so print that detail. > > Signed-off-by: Joe Stringer Acked-by: Daniel Borkmann

[PATCH iproute2] bpf: Print section name when hitting non ld64 issue

2018-02-28 Thread Joe Stringer
It's useful to be able to tell which section is being processed in the ELF when this error is triggered, so print that detail. Signed-off-by: Joe Stringer --- lib/bpf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/bpf.c b/lib/bpf.c index 2db151e4dd3c..c38d92d87759

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

2018-02-28 Thread Florian Fainelli
On 02/28/2018 11:49 AM, Moritz Fischer wrote: > Florian, > > On Wed, Feb 28, 2018 at 11:44 AM, Russell King wrote: >> On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: >>> We do the same thing as the generic function: nothing, so utilize it. >>> >>>

Re: [PATCH v2 net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-28 Thread Nikolay Aleksandrov
On 28/02/18 23:29, Yuval Mintz wrote: > mfc_cache and mfc6_cache are almost identical - the main difference is > in the origin/group addresses and comparison-key. Make a common > structure encapsulating most of the multicast routing logic - mr_mfc > and convert both ipmr and ip6mr into using it.

Re: [PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

2018-02-28 Thread Nikolay Aleksandrov
On 28/02/18 23:29, Yuval Mintz wrote: > ipmr and ip6mr utilize the exact same methods for searching the > hashed resolved connections, difference being only in the construction > of the hash comparison key. > > In order to unite the flow, introduce an mr_table operation set that > would contain

[PATCH 2/2] net: usb: asix88179_178a: de-duplicate code

2018-02-28 Thread Alexander Kurz
Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 117 +++-- 1 file changed, 31 insertions(+), 86 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c

[PATCH 1/2] net: usb: asix88179_178a: set permanent address once only

2018-02-28 Thread Alexander Kurz
The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1

[PATCH v2 net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

2018-02-28 Thread Yuval Mintz
Now that both ipmr and ip6mr are using the same mr_table structure, we can have a common function to allocate & initialize a new instance. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute_base.h | 17

[PATCH v2 net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

2018-02-28 Thread Yuval Mintz
With the exception of the final dump, ipmr and ip6mr have the exact same seq logic for traversing a given mr_table. Refactor that code and make it common. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute_base.h

[PATCH v2 net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6

2018-02-28 Thread Yuval Mintz
Historically ip6mr was based [cut-n-paste] on ipmr and the two have not diverged too much. Apparently as ipv4 multicast routing is more common than its ipv6 brethren modifications since then are mostly one-way, affecting ipmr while leaving ip6mr unchanged. This series is meant to re-factor both

[PATCH v2 net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-28 Thread Yuval Mintz
mfc_cache and mfc6_cache are almost identical - the main difference is in the origin/group addresses and comparison-key. Make a common structure encapsulating most of the multicast routing logic - mr_mfc and convert both ipmr and ip6mr into using it. For easy conversion [casting, in this case]

[PATCH v2 net-next 04/11] mroute*: Make mr_table a common struct

2018-02-28 Thread Yuval Mintz
Following previous changes to ip6mr, mr_table and mr6_table are basically the same [up to mr6_table having additional '6' suffixes to its variable names]. Move the common structure definition into a common header; This requires renaming all references in ip6mr to variables that had the distinct

Re: [PATCH] selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h

2018-02-28 Thread Daniel Borkmann
On 02/28/2018 10:28 PM, Tushar Dave wrote: > On 02/28/2018 08:57 AM, Daniel Borkmann wrote: >> Hi Tushar, >> >> On 02/28/2018 01:33 AM, Tushar Dave wrote: >>> Using bpf_probe_read_str() from samples/bpf causes compiler warning. >>> e.g. >>> warning: implicit declaration of function

[PATCH v2 net-next 03/11] ip6mr: Align hash implementation to ipmr

2018-02-28 Thread Yuval Mintz
Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has been using rhashtable as a basis for its mfc routes, but ip6mr is currently still using the old private MFC hash implementation. Align ip6mr to the current ipmr implementation. Signed-off-by: Yuval Mintz

[PATCH v2 net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

2018-02-28 Thread Yuval Mintz
MFC_NOTIFY exists in ip6mr, probably as some legacy code [was already removed for ipmr in commit 06bd6c0370bb ("net: ipmr: remove unused MFC_NOTIFY flag and make the flags enum"). Remove it from ip6mr as well, and move the enum into a common file; Notice MFC_OFFLOAD is currently only used by

[PATCH v2 net-next 09/11] ipmr, ip6mr: Unite vif seq functions

2018-02-28 Thread Yuval Mintz
Same as previously done with the mfc seq, the logic for the vif seq is refactored to be shared between ipmr and ip6mr. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute_base.h | 33 ++

[PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

2018-02-28 Thread Yuval Mintz
ipmr and ip6mr utilize the exact same methods for searching the hashed resolved connections, difference being only in the construction of the hash comparison key. In order to unite the flow, introduce an mr_table operation set that would contain the protocol specific information required for

[PATCH v2 net-next 02/11] ip6mr: Make mroute_sk rcu-based

2018-02-28 Thread Yuval Mintz
In ipmr the mr_table socket is handled under RCU. Introduce the same for ip6mr. Signed-off-by: Yuval Mintz Acked-by: Nikolay Aleksandrov --- include/linux/mroute6.h | 6 +++--- net/ipv6/ip6_output.c | 2 +- net/ipv6/ip6mr.c| 45

[PATCH v2 net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

2018-02-28 Thread Yuval Mintz
The two implementations have almost identical structures - vif_device and mif_device. As a step toward uniforming the mr_tables, eliminate the mif_device and relocate the vif_device definition into a new common header file. Also, introduce a common initializing function for setting most of the

[PATCH v2 net-next 11/11] ipmr, ip6mr: Unite dumproute flows

2018-02-28 Thread Yuval Mintz
The various MFC entries are being held in the same kind of mr_tables for both ipmr and ip6mr, and their traversal logic is identical. Also, with the exception of the addresses [and other small tidbits] the major bulk of the nla setting is identical. Unite as much of the dumping as possible

[PATCH] IP6 Fragment: Export ip6_fragment function

2018-02-28 Thread Sheena Mira-ato
Export the ip6_fragment function so other loadable kernel modules can access it. The ipv4 version is already exported. --- net/ipv6/ip6_output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 997c7f19ad62..8604031f0a93 100644 ---

Re: [PATCH] selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h

2018-02-28 Thread Tushar Dave
On 02/28/2018 08:57 AM, Daniel Borkmann wrote: Hi Tushar, On 02/28/2018 01:33 AM, Tushar Dave wrote: Using bpf_probe_read_str() from samples/bpf causes compiler warning. e.g. warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99

Re: [PATCH net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

2018-02-28 Thread Yuval Mintz
On Wed, Feb 28, 2018 at 12:38:20AM +0200, Nikolay Aleksandrov wrote: > On 27/02/18 20:58, Yuval Mintz wrote: > > mfc_cache and mfc6_cache are almost identical - the main difference is > > in the origin/group addresses and comparison-key. Make a common > > structure encapsulating most of the

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-28 Thread Michael S. Tsirkin
On Wed, Feb 28, 2018 at 08:25:01PM +0100, Jiri Pirko wrote: > Wed, Feb 28, 2018 at 04:45:39PM CET, m...@redhat.com wrote: > >On Wed, Feb 28, 2018 at 04:11:31PM +0100, Jiri Pirko wrote: > >> Wed, Feb 28, 2018 at 03:32:44PM CET, m...@redhat.com wrote: > >> >On Wed, Feb 28, 2018 at 08:08:39AM +0100,

[PATCH v2 net-next 1/1] tools: tc-testing: Add notap option

2018-02-28 Thread Brenda J. Butler
Add a command line arg to suppress tap output. Handy in case all the tap output is being supplied by the plugins. Signed-off-by: Brenda J. Butler --- v2: Drop the first patch that changes the format of the tap output. The second "notap" patch is reworked to apply

pull-request: bpf 2018-02-28

2018-02-28 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Add schedule points and reduce the number of loop iterations the test_bpf kernel module is performing in order to not hog the CPU for too long, from Eric. 2) Fix an out of bounds

  1   2   3   >