Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread Ido Schimmel
On Mon, Mar 05, 2018 at 01:28:28PM +, John Hurley wrote: > To prevent sync issues between the kernel and offload device, the linux > bond driver is affectively locked when it has offloaded rules. i.e no new > ports can be enslaved and no slaves can be released until the offload > rules are

Flaw in RFC793 (Fwd: New Version Notification for draft-gont-tcpm-tcp-seq-validation-03.txt)

2018-03-05 Thread Fernando Gont
Folks, Dave Borman and me are trying to get this flaw fixed in the TCP spec -- this is of particular interest since the IETF finally agreed to revise the old spec. The working copy of our document is:

Re: [PATCH iproute2-next 3/3] macsec: support JSON

2018-03-05 Thread Stephen Hemminger
On Mon, 5 Mar 2018 22:58:30 -0800 Stephen Hemminger wrote: > From: Stephen Hemminger > > The JSON support in macsec code was mostly missing and what was > there was broken. This uses new json_print utilities to complete > output. > >

Re: [bpf-next PATCH 05/16] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-05 Thread John Fastabend
On 03/05/2018 10:42 PM, David Miller wrote: > From: John Fastabend > Date: Mon, 5 Mar 2018 22:22:21 -0800 > >> All I meant by this is if an application uses sendfile() call >> there is no good way to know when/if the kernel side will copy or >> xmit the data. So a

Re: [PATCH net-next 2/3] sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg

2018-03-05 Thread Xin Long
On Tue, Mar 6, 2018 at 7:39 AM, Marcelo Ricardo Leitner wrote: > On Mon, Mar 05, 2018 at 08:44:19PM +0800, Xin Long wrote: >> This patch is to add support for Destination IPv4/6 Address options >> for sendmsg, as described in section 5.3.9/10 of RFC6458. >> >> With this

[PATCH iproute2-next 3/3] macsec: support JSON

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger The JSON support in macsec code was mostly missing and what was there was broken. This uses new json_print utilities to complete output. Compile tested only. Signed-off-by: Stephen Hemminger --- ip/ipmacsec.c | 249

[PATCH iproute2-next 1/3] ip: macsec cleanup

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Break long lines and use const as recommended by checkpatch. Signed-off-by: Stephen Hemminger --- ip/ipmacsec.c | 46 -- 1 file changed, 24 insertions(+), 22 deletions(-)

[PATCH iproute2-next 2/3] ipmacsec: collapse common code

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Several places copy/paste same code for printing array of statistics. Signed-off-by: Stephen Hemminger --- ip/ipmacsec.c | 137 ++ 1 file changed, 51

[PATCH iproute2-next 0/3] macsec cleanup and JSON

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger The macsec code didn't really support JSON and had several pieces of copy/pasted code. Stephen Hemminger (3): ip: macsec cleanup ipmacsec: collapse common code macsec: support JSON ip/ipmacsec.c | 424

[GIT] net merged into net-next

2018-03-05 Thread David Miller
If I botched up any part of the merge, please send me fix up patches. Thank you.

Re: [bpf-next PATCH 05/16] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-05 Thread David Miller
From: John Fastabend Date: Mon, 5 Mar 2018 22:22:21 -0800 > All I meant by this is if an application uses sendfile() call > there is no good way to know when/if the kernel side will copy or > xmit the data. So a reliable user space application will need to > only

Re: [bpf-next PATCH 05/16] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-05 Thread John Fastabend
On 03/05/2018 09:42 PM, David Miller wrote: > From: John Fastabend > Date: Mon, 5 Mar 2018 14:53:08 -0800 > >> I decided to make the default no-copy to mirror the existing >> sendpage() semantics and then to add the flag later. The flag >> support is not in this series

[PATCH] cxgb3: remove VLA

2018-03-05 Thread Gustavo A. R. Silva
In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git

Re: [bpf-next PATCH 05/16] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-05 Thread David Miller
From: John Fastabend Date: Mon, 5 Mar 2018 14:53:08 -0800 > I decided to make the default no-copy to mirror the existing > sendpage() semantics and then to add the flag later. The flag > support is not in this series simply because I wanted to get the > base support in

Re: [PATCH net-next] selftests: net: Introduce first PMTU test

2018-03-05 Thread David Ahern
On 3/5/18 3:45 PM, Stefano Brivio wrote: > diff --git a/tools/testing/selftests/net/pmtu.sh > b/tools/testing/selftests/net/pmtu.sh > new file mode 100755 > index ..eb186ca3e5e4 > --- /dev/null > +++ b/tools/testing/selftests/net/pmtu.sh > @@ -0,0 +1,159 @@ > +#!/bin/sh > +#

[RFC PATCH linux-next] net: mvpp2: mvpp2_check_hw_buf_num() can be static

2018-03-05 Thread kbuild test robot
Fixes: effbf5f58d64 ("net: mvpp2: update the BM buffer free/destroy logic") Signed-off-by: Fengguang Wu --- mvpp2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index

[linux-next:master 5332/5518] drivers/net/ethernet/marvell/mvpp2.c:4288:5: sparse: symbol 'mvpp2_check_hw_buf_num' was not declared. Should it be static?

2018-03-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 9c142d8a6556f069be6278ccab701039da81ad6f commit: effbf5f58d64b1d1f93cb687d9797b42f291d5fd [5332/5518] net: mvpp2: update the BM buffer free/destroy logic reproduce: # apt-get install sparse

Re: [PATCH 2/3] vfio: Add support for unmanaged or userspace managed SR-IOV

2018-03-05 Thread kbuild test robot
Hi Alexander, Thank you for the patch! Yet something to improve: [auto build test ERROR on pci/next] [also build test ERROR on v4.16-rc4 next-20180305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Donation For Charity Work

2018-03-05 Thread Friedrich And Ann Mayrhofer
-- Good Day, My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. We await your earliest response and God Bless you. Friedrich And Ann Mayrhofer.

Re: [PATCH] tipc: bcast: use true and false for boolean values

2018-03-05 Thread Ying Xue
On 03/06/2018 05:56 AM, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Ying Xue >

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-05 Thread Stephen Hemminger
On Mon, 5 Mar 2018 14:47:20 -0800 Alexander Duyck wrote: > On Mon, Mar 5, 2018 at 2:30 PM, Jiri Pirko wrote: > > Mon, Mar 05, 2018 at 05:11:32PM CET, step...@networkplumber.org wrote: > >>On Mon, 5 Mar 2018 10:21:18 +0100 > >>Jiri Pirko

Re: [PATCH] net: qcom/emac: Use proper free methods during TX

2018-03-05 Thread Timur Tabi
On 3/5/18 8:48 PM, Hemanth Puranik wrote: This patch fixes the warning messages/call traces seen if DMA debug is enabled, In case of fragmented skb's memory was allocated using dma_map_page but freed using dma_unmap_single. This patch modifies buffer allocations in TX path to use dma_map_page in

[PATCH iproute2-next 2/7] ip: add json support to addrlabel

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Add missing json and color support to addrlabel display Signed-off-by: Stephen Hemminger --- ip/ipaddrlabel.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff

[PATCH iproute2-next 6/7] tcp_metrics; make tables const

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- ip/tcp_metrics.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ip/tcp_metrics.c b/ip/tcp_metrics.c index 7e2d9eb34b79..5f394765c62b 100644 ---

[PATCH iproute2-next 7/7] ip: jsonify tcp_metrics

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Add JSON support to the ip tcp_metrics output. $ ip -j -p tcp_metrics show [ { "dst": "192.18.1.11", "age": 23617.8, "ssthresh": 7, "cwnd": 3, "rtt": 0.039176, "rttvar": 0.039176, "source":

[PATCH iproute2-next 0/7] ip: more JSON

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger The ip command implementation of JSON was very spotty. Only address and link were originally implemented. After doing route for next, went ahead and implemented it for a bunch of the other sub commands. Hopefully will reach full coverage soon.

[PATCH iproute2-next 1/7] ip: add color and json support to neigh

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Use json_print to provide json (and color) support to ip neigh command. Signed-off-by: Stephen Hemminger --- ip/ipneigh.c | 143 --- 1 file changed, 97

[PATCH iproute2-next 3/7] ip: add json support to ip rule

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger More JSON and colorizing. Signed-off-by: Stephen Hemminger --- ip/iprule.c | 203 ++-- 1 file changed, 130 insertions(+), 73 deletions(-) diff --git

[PATCH iproute2-next 5/7] ip: add JSON support to netconf

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Basic JSON support for ip netconf command. Also cleanup some checkpatch warnings about long lines. Signed-off-by: Stephen Hemminger --- ip/ipnetconf.c | 69 +- 1

[PATCH iproute2-next 4/7] ip: add json support to ntable

2018-03-05 Thread Stephen Hemminger
From: Stephen Hemminger Add JSON (and limited color) to ip neighbor table parameter output. Signed-off-by: Stephen Hemminger --- ip/ipntable.c | 415 -- 1 file changed, 226

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-05 Thread Alexei Starovoitov
On 3/5/18 6:13 PM, Randy Dunlap wrote: Hi, On 03/05/2018 05:34 PM, Alexei Starovoitov wrote: diff --git a/kernel/module.c b/kernel/module.c index ad2d420024f6..6cfa35795741 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3669,6 +3683,17 @@ static int load_module(struct load_info

[PATCH] net: qcom/emac: Use proper free methods during TX

2018-03-05 Thread Hemanth Puranik
This patch fixes the warning messages/call traces seen if DMA debug is enabled, In case of fragmented skb's memory was allocated using dma_map_page but freed using dma_unmap_single. This patch modifies buffer allocations in TX path to use dma_map_page in all the places and dma_unmap_page while

Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread Roopa Prabhu
On Mon, Mar 5, 2018 at 2:08 PM, Jakub Kicinski wrote: > On Mon, 5 Mar 2018 13:28:28 +, John Hurley wrote: >> The linux bond itself registers a cb for offloading tc rules. Potential >> slave netdevs on offload devices can then register with the bond for a >>

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-05 Thread Randy Dunlap
Hi, On 03/05/2018 05:34 PM, Alexei Starovoitov wrote: > diff --git a/kernel/module.c b/kernel/module.c > index ad2d420024f6..6cfa35795741 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3669,6 +3683,17 @@ static int load_module(struct load_info *info, const > char __user *uargs, >

[PATCH 2/2] e1000e: Fix link check race condition

2018-03-05 Thread Benjamin Poirier
Alex reported the following race condition: /* link goes up... interrupt... schedule watchdog */ \ e1000_watchdog_task \ e1000e_has_link \ hw->mac.ops.check_for_link() === e1000e_check_for_copper_link \ e1000e_phy_has_link_generic(..., )

[PATCH 1/2] Revert "e1000e: Separate signaling for link check/link up"

2018-03-05 Thread Benjamin Poirier
This reverts commit 19110cfbb34d4af0cdfe14cd243f3b09dc95b013. This reverts commit 4110e02eb45ea447ec6f5459c9934de0a273fb91. This reverts commit d3604515c9eda464a92e8e67aae82dfe07fe3c98. Commit 19110cfbb34d ("e1000e: Separate signaling for link check/link up") changed what happens to the link

[PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-05 Thread Alexei Starovoitov
As the first step in development of bpfilter project [1] the request_module() code is extended to allow user mode helpers to be invoked. Idea is that user mode helpers are built as part of the kernel build and installed as traditional kernel modules with .ko file extension into distro specified

Re: [PATCH bpf-next 3/5] bpf: introduce BPF_RAW_TRACEPOINT

2018-03-05 Thread Alexei Starovoitov
On 3/5/18 3:56 PM, Daniel Borkmann wrote: On 03/01/2018 05:19 AM, Alexei Starovoitov wrote: Introduce BPF_PROG_TYPE_RAW_TRACEPOINT bpf program type to access kernel internal arguments of the tracepoints in their raw form. From bpf program point of view the access to the arguments look like:

Add NETIF_F_HW_VLAN_CTAG_TX to hw_enc_features

2018-03-05 Thread Seiichi Ishitsuka
Hi all, I have a problem of Ether frame corruption on using mv88e6xxx DSA driver. Could you please tell me the solving method or patch if it is a known problem? Attached is workaround patch, and it seems to works fine. Environment: kernel: linux-yocto-4.4 Hardware: Marvell 88E6182 L2SW with

Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread Jakub Kicinski
On Mon, 5 Mar 2018 23:57:18 +, John Hurley wrote: > > what is your approach for rules whose bond is their egress device > > (ingress = vf port > > representor)? > > Egress offload will be handled entirely by the NFP driver. > Basically, notifiers will track the slaves/masters and update the

Re: [PATCH bpf-next 3/5] bpf: introduce BPF_RAW_TRACEPOINT

2018-03-05 Thread Daniel Borkmann
On 03/01/2018 05:19 AM, Alexei Starovoitov wrote: > Introduce BPF_PROG_TYPE_RAW_TRACEPOINT bpf program type to access > kernel internal arguments of the tracepoints in their raw form. > > From bpf program point of view the access to the arguments look like: > struct bpf_raw_tracepoint_args { >

Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread John Hurley
On Mon, Mar 5, 2018 at 9:43 PM, Or Gerlitz wrote: > On Mon, Mar 5, 2018 at 3:28 PM, John Hurley wrote: >> This RFC patchset adds support for offloading tc ingress rules applied to >> linux bonds. The premise of these patches is that if a rule is

Re: [PATCH net-next 0/3] sctp: add support for some msg_control options from RFC6458

2018-03-05 Thread Marcelo Ricardo Leitner
On Mon, Mar 05, 2018 at 08:44:17PM +0800, Xin Long wrote: > This patchset is to add support for 3 msg_control options described > in RFC6458: > > 5.3.7. SCTP PR-SCTP Information Structure (SCTP_PRINFO) > 5.3.9. SCTP Destination IPv4 Address Structure (SCTP_DSTADDRV4) > 5.3.10. SCTP

Re: [PATCH net v3] sch_netem: fix skb leak in netem_enqueue()

2018-03-05 Thread Neil Horman
On Mon, Mar 05, 2018 at 08:52:54PM +0300, Alexey Kodanev wrote: > When we exceed current packets limit and we have more than one > segment in the list returned by skb_gso_segment(), netem drops > only the first one, skipping the rest, hence kmemleak reports: > > unreferenced object

Re: [PATCH net-next 2/3] sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg

2018-03-05 Thread Marcelo Ricardo Leitner
On Mon, Mar 05, 2018 at 08:44:19PM +0800, Xin Long wrote: > This patch is to add support for Destination IPv4/6 Address options > for sendmsg, as described in section 5.3.9/10 of RFC6458. > > With this option, you can provide more than one destination addrs > to sendmsg when creating asoc, like

Re: [RFC net-next 4/6] nfp: add ndo_set_mac_address for representors

2018-03-05 Thread John Hurley
On Mon, Mar 5, 2018 at 9:39 PM, Or Gerlitz wrote: > On Mon, Mar 5, 2018 at 3:28 PM, John Hurley wrote: >> A representor hardware address does not have any meaning outside of the >> kernel netdev/networking stack. Thus there is no need for any app

Re: [PATCH net] sch_netem: fix skb leak in netem_enqueue()

2018-03-05 Thread Neil Horman
On Mon, Mar 05, 2018 at 03:57:52PM +0300, Alexey Kodanev wrote: > On 03/03/2018 03:20 PM, Neil Horman wrote: > > On Fri, Mar 02, 2018 at 09:16:48PM +0300, Alexey Kodanev wrote: > >> When we exceed current packets limit and have more than one > >> segment in the list returned by skb_gso_segment(),

[PATCH] caif_dev: use true and false for boolean values

2018-03-05 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/caif/caif_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [bpf-next PATCH 05/16] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-05 Thread John Fastabend
On 03/05/2018 01:40 PM, David Miller wrote: > From: John Fastabend > Date: Mon, 05 Mar 2018 11:51:22 -0800 > >> BPF_PROG_TYPE_SK_MSG supports only two return codes SK_PASS and >> SK_DROP. Returning SK_DROP free's the copied data in the sendmsg >> case and in the

Re: [net-next v3 1/2] bpf, seccomp: Add eBPF filter capabilities

2018-03-05 Thread Sargun Dhillon
On Mon, Mar 5, 2018 at 8:10 AM, Tycho Andersen wrote: > Hi Andy, > > On Thu, Mar 01, 2018 at 10:05:47PM +, Andy Lutomirski wrote: >> But Tycho: would hooking user notifiers in right here work for you? >> As I see it, this would be the best justification for seccomp eBPF. > >

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-05 Thread Alexander Duyck
On Mon, Mar 5, 2018 at 2:30 PM, Jiri Pirko wrote: > Mon, Mar 05, 2018 at 05:11:32PM CET, step...@networkplumber.org wrote: >>On Mon, 5 Mar 2018 10:21:18 +0100 >>Jiri Pirko wrote: >> >>> Sun, Mar 04, 2018 at 10:58:34PM CET, alexander.du...@gmail.com wrote: >>>

[PATCH net-next] selftests: net: Introduce first PMTU test

2018-03-05 Thread Stefano Brivio
One single test implemented so far: test_pmtu_vti6_exception checks that the PMTU of a route exception, caused by a tunnel exceeding the link layer MTU, is affected by administrative changes of the tunnel MTU. Creation of the route exception is checked too. Requested-by: David Ahern

Re: [PATCH net-next] dt-bindings: net: dsa: marvell: describe compatibility string

2018-03-05 Thread Andrew Lunn
On Mon, Mar 05, 2018 at 04:05:22PM -0600, Brandon Streiff wrote: > There are two compatibility strings for mv88e6xxx, but it isn't clear > from the documentation why only those two exist when the mv88e6xxx driver > supports more than the 6085 and 6190. Briefly describe how the compatible >

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-05 Thread Jiri Pirko
Mon, Mar 05, 2018 at 05:11:32PM CET, step...@networkplumber.org wrote: >On Mon, 5 Mar 2018 10:21:18 +0100 >Jiri Pirko wrote: > >> Sun, Mar 04, 2018 at 10:58:34PM CET, alexander.du...@gmail.com wrote: >> >On Sun, Mar 4, 2018 at 10:50 AM, Jiri Pirko wrote: >>

Re: [PATCH] netfilter: ipt_ah: return boolean instead of integer

2018-03-05 Thread Gustavo A. R. Silva
On 03/05/2018 04:10 PM, Pablo Neira Ayuso wrote: On Tue, Feb 13, 2018 at 08:25:57AM -0600, Gustavo A. R. Silva wrote: Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. This one didn't get in time for the

[PATCH] tipc: bcast: use true and false for boolean values

2018-03-05 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/tipc/bcast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/bcast.c

Re: [PATCH trivial resend]] netfilter: xt_limit: Spelling s/maxmum/maximum/

2018-03-05 Thread Pablo Neira Ayuso
Applied this spelling fix, thanks.

Re: [Patch nf-next] netfilter: make xt_rateest hash table per net

2018-03-05 Thread Pablo Neira Ayuso
On Thu, Mar 01, 2018 at 08:21:52PM -0800, Eric Dumazet wrote: > On Thu, 2018-03-01 at 18:58 -0800, Cong Wang wrote: > > As suggested by Eric, we need to make the xt_rateest > > hash table and its lock per netns to reduce lock > > contentions. > > > > Cc: Florian Westphal > > Cc:

[PATCH] xfrm_policy: use true and false for boolean values

2018-03-05 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/xfrm/xfrm_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] ipv6: ndisc: use true and false for boolean values

2018-03-05 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/ipv6/ndisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ndisc.c

Re: [PATCH net] netfilter: unlock xt_table earlier in __do_replace

2018-03-05 Thread Pablo Neira Ayuso
On Fri, Feb 16, 2018 at 12:25:56PM +0100, Xin Long wrote: > On Fri, Feb 16, 2018 at 12:02 PM, Florian Westphal wrote: > > Xin Long wrote: [...] > >> Besides, all xt_target/match checkentry is called out of xt_table > >> lock. It's better also to move all

Re: [PATCH] netfilter: ipt_ah: return boolean instead of integer

2018-03-05 Thread Pablo Neira Ayuso
On Tue, Feb 13, 2018 at 08:25:57AM -0600, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. This one didn't get in time for the previous merge window. Now applied, thanks.

[PATCH net-next] dt-bindings: net: dsa: marvell: describe compatibility string

2018-03-05 Thread Brandon Streiff
There are two compatibility strings for mv88e6xxx, but it isn't clear from the documentation why only those two exist when the mv88e6xxx driver supports more than the 6085 and 6190. Briefly describe how the compatible property is used, and provide guidance on which to use. The model list comes

Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread Jakub Kicinski
On Mon, 5 Mar 2018 13:28:28 +, John Hurley wrote: > The linux bond itself registers a cb for offloading tc rules. Potential > slave netdevs on offload devices can then register with the bond for a > further callback - this code is basically the same as registering for an > egress dev offload

[PATCH] ipvs: use true and false for boolean values

2018-03-05 Thread Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipvs/ip_vs_lblc.c | 4 ++-- net/netfilter/ipvs/ip_vs_lblcr.c | 4 ++-- 2 files changed, 4

Re: [PATCH 14/36] aio: implement IOCB_CMD_POLL

2018-03-05 Thread Jeff Moyer
Christoph Hellwig writes: > Simple one-shot poll through the io_submit() interface. To poll for > a file descriptor the application should submit an iocb of type > IOCB_CMD_POLL. It will poll the fd for the events specified in the > the first 32 bits of the aio_buf field of the

Re: [PATCH 08/36] aio: implement io_pgetevents

2018-03-05 Thread Jeff Moyer
Christoph Hellwig writes: > This is the io_getevents equivalent of ppoll/pselect and allows to > properly mix signals and aio completions (especially with IOCB_CMD_POLL) > and atomically executes the following sequence: > > sigset_t origmask; > >

[PATCH V3 net] qed: Free RoCE ILT Memory on rmmod qedr

2018-03-05 Thread Michal Kalderon
Rdma requires ILT Memory to be allocated for it's QPs. Each ILT entry points to a page used by several Rdma QPs. To avoid allocating all the memory in advance, the rdma implementation dynamically allocates memory as more QPs are added, however it does not dynamically free the memory. The memory

RE: [PATCH V2 net] qed: Free RoCE ILT Memory on rmmod qedr

2018-03-05 Thread Kalderon, Michal
> From: Yuval Mintz [mailto:yuv...@mellanox.com] > Sent: Monday, March 05, 2018 11:24 PM > To: Kalderon, Michal ; > da...@davemloft.net > Cc: netdev@vger.kernel.org; dledf...@redhat.com; Jason Gunthorpe > ; linux-r...@vger.kernel.org; Elior, Ariel >

[PATCH 06/36] aio: delete iocbs from the active_reqs list in kiocb_cancel

2018-03-05 Thread Christoph Hellwig
One we cancel an iocb there is no reason to keep it on the active_reqs list, given that the list is only used to look for cancelation candidates. Signed-off-by: Christoph Hellwig Acked-by: Jeff Moyer --- fs/aio.c | 4 ++-- 1 file changed, 2 insertions(+), 2

aio poll, io_pgetevents and a new in-kernel poll API V5

2018-03-05 Thread Christoph Hellwig
Hi all, this series adds support for the IOCB_CMD_POLL operation to poll for the readyness of file descriptors using the aio subsystem. The API is based on patches that existed in RHAS2.1 and RHEL3, which means it already is supported by libaio. To implement the poll support efficiently new

[PATCH 08/36] aio: implement io_pgetevents

2018-03-05 Thread Christoph Hellwig
This is the io_getevents equivalent of ppoll/pselect and allows to properly mix signals and aio completions (especially with IOCB_CMD_POLL) and atomically executes the following sequence: sigset_t origmask; pthread_sigmask(SIG_SETMASK, , ); ret = io_getevents(ctx, min_nr,

[PATCH 07/36] aio: add delayed cancel support

2018-03-05 Thread Christoph Hellwig
The upcoming aio poll support would like to be able to complete the iocb inline from the cancellation context, but that would cause a lock order reversal. Add support for optionally moving the cancelation outside the context lock to avoid this reversal. Signed-off-by: Christoph Hellwig

Re: [RFC net-next 0/6] offload linux bonding tc ingress rules

2018-03-05 Thread Or Gerlitz
On Mon, Mar 5, 2018 at 3:28 PM, John Hurley wrote: > This RFC patchset adds support for offloading tc ingress rules applied to > linux bonds. The premise of these patches is that if a rule is applied to > a bond port then the rule should be applied to each slave of the

[PATCH 04/36] aio: sanitize ki_list handling

2018-03-05 Thread Christoph Hellwig
Instead of handcoded non-null checks always initialize ki_list to an empty list and use list_empty / list_empty_careful on it. While we're at it also error out on a double call to kiocb_set_cancel_fn instead of ignoring it. Signed-off-by: Christoph Hellwig Acked-by: Jeff Moyer

[PATCH 01/36] aio: don't print the page size at boot time

2018-03-05 Thread Christoph Hellwig
The page size is in no way related to the aio code, and printing it in the (debug) dmesg at every boot serves no purpose. Signed-off-by: Christoph Hellwig Acked-by: Jeff Moyer --- fs/aio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/aio.c b/fs/aio.c

[PATCH 03/36] aio: refactor read/write iocb setup

2018-03-05 Thread Christoph Hellwig
Don't reference the kiocb structure from the common aio code, and move any use of it into helper specific to the read/write path. This is in preparation for aio_poll support that wants to use the space for different fields. Signed-off-by: Christoph Hellwig Acked-by: Jeff Moyer

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-03-05 Thread Alexander Duyck
On Mon, Mar 5, 2018 at 12:57 PM, Don Dutile wrote: > On 03/01/2018 03:22 PM, Alex Williamson wrote: >> >> On Wed, 28 Feb 2018 16:36:38 -0800 >> Alexander Duyck wrote: >> >>> On Wed, Feb 28, 2018 at 2:59 PM, Alex Williamson >>>

Re: [net-next 4/4] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-03-05 Thread Jeff Kirsher
On Mon, 2018-03-05 at 16:20 -0500, David Miller wrote: > From: Jeff Kirsher > Date: Mon, 05 Mar 2018 11:09:29 -0800 > > > On Mon, 2018-03-05 at 10:23 -0800, Eric Dumazet wrote: > > > On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote: > > > > From: Pierre-Yves

[PATCH 05/36] aio: simplify cancellation

2018-03-05 Thread Christoph Hellwig
With the current aio code there is no need for the magic KIOCB_CANCELLED value, as a cancelation just kicks the driver to queue the completion ASAP, with all actual completion handling done in another thread. Given that both the completion path and cancelation take the context lock there is no

[net v2 0/6][pull request] Intel Wired LAN Driver Updates 2018-03-05

2018-03-05 Thread Jeff Kirsher
This series contains fixes to e1000e only. Benjamin Poirier provides all but one fix in this series, starting with workaround for a VMWare e1000e emulation issue where ICR reads 0x0 on the emulated device. Partially reverted a previous commit dealing with the "Other" interrupt throttling to

[PATCH 09/36] fs: unexport poll_schedule_timeout

2018-03-05 Thread Christoph Hellwig
No users outside of select.c. Signed-off-by: Christoph Hellwig --- fs/select.c | 3 +-- include/linux/poll.h | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/select.c b/fs/select.c index b6c36254028a..686de7b3a1db 100644 --- a/fs/select.c +++

Re: [bpf-next PATCH 05/16] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data

2018-03-05 Thread David Miller
From: John Fastabend Date: Mon, 05 Mar 2018 11:51:22 -0800 > BPF_PROG_TYPE_SK_MSG supports only two return codes SK_PASS and > SK_DROP. Returning SK_DROP free's the copied data in the sendmsg > case and in the sendpage case leaves the data untouched. Both cases > return

[net v2 3/6] e1000e: Fix queue interrupt re-raising in Other interrupt

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier Restores the ICS write for Rx/Tx queue interrupts which was present before commit 16ecba59bc33 ("e1000e: Do not read ICR in Other interrupt", v4.5-rc1) but was not restored in commit 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts",

[net v2 1/6] e1000e: Remove Other from EIAC

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier It was reported that emulated e1000e devices in vmware esxi 6.5 Build 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts", v4.15-rc1). Some tracing shows that after e1000e_trigger_lsc() is called, ICR reads

[net v2 6/6] e1000e: allocate ring descriptors with dma_zalloc_coherent

2018-03-05 Thread Jeff Kirsher
From: Pierre-Yves Kerbrat Descriptor rings were not initialized at zero when allocated When area contained garbage data, it caused skb_over_panic in e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set) This patch makes use of dma_zalloc_coherent to make sure the ring

[PATCH 10/36] fs: cleanup do_pollfd

2018-03-05 Thread Christoph Hellwig
Use straigline code with failure handling gotos instead of a lot of nested conditionals. Signed-off-by: Christoph Hellwig --- fs/select.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/fs/select.c b/fs/select.c

[net v2 2/6] Partial revert "e1000e: Avoid receiver overrun interrupt bursts"

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier This partially reverts commit 4aea7a5c5e940c1723add439f4088844cd26196d. We keep the fix for the first part of the problem (1) described in the log of that commit, that is to read ICR in the other interrupt handler. We remove the fix for the second part

[net v2 4/6] e1000e: Avoid missed interrupts following ICR read

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier The 82574 specification update errata 12 states that interrupts may be missed if ICR is read while INT_ASSERTED is not set. Avoid that problem by setting all bits related to events that can trigger the Other interrupt in IMS. The Other interrupt is

[net v2 5/6] e1000e: Fix check_for_link return value with autoneg off

2018-03-05 Thread Jeff Kirsher
From: Benjamin Poirier When autoneg is off, the .check_for_link callback functions clear the get_link_status flag and systematically return a "pseudo-error". This means that the link is not detected as up until the next execution of the e1000_watchdog_task() 2 seconds later.

[PATCH 12/36] fs: add new vfs_poll and file_can_poll helpers

2018-03-05 Thread Christoph Hellwig
These abstract out calls to the poll method in preparation for changes in how we poll. Signed-off-by: Christoph Hellwig --- drivers/staging/comedi/drivers/serial2002.c | 4 ++-- drivers/vfio/virqfd.c | 2 +- drivers/vhost/vhost.c | 2

[PATCH 15/36] net: refactor socket_poll

2018-03-05 Thread Christoph Hellwig
Factor out two busy poll related helpers for late reuse, and remove a command that isn't very helpful, especially with the __poll_t annotations in place. Signed-off-by: Christoph Hellwig --- include/net/busy_poll.h | 15 +++ net/socket.c| 21

Re: [RFC net-next 4/6] nfp: add ndo_set_mac_address for representors

2018-03-05 Thread Or Gerlitz
On Mon, Mar 5, 2018 at 3:28 PM, John Hurley wrote: > A representor hardware address does not have any meaning outside of the > kernel netdev/networking stack. Thus there is no need for any app specific > code for setting a representors hardware address, the default

[PATCH 14/36] aio: implement IOCB_CMD_POLL

2018-03-05 Thread Christoph Hellwig
Simple one-shot poll through the io_submit() interface. To poll for a file descriptor the application should submit an iocb of type IOCB_CMD_POLL. It will poll the fd for the events specified in the the first 32 bits of the aio_buf field of the iocb. Unlike poll or epoll without EPOLLONESHOT

[PATCH 13/36] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-03-05 Thread Christoph Hellwig
->get_poll_head returns the waitqueue that the poll operation is going to sleep on. Note that this means we can only use a single waitqueue for the poll, unlike some current drivers that use two waitqueues for different events. But now that we have keyed wakeups and heavily use those for poll

[PATCH 20/36] net: convert datagram_poll users tp ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/isdn/mISDN/socket.c| 2 +- drivers/net/ppp/pppoe.c| 2 +- drivers/staging/ipx/af_ipx.c | 2 +- drivers/staging/irda/net/af_irda.c | 6 +++--- include/linux/skbuff.h | 3 +-- include/net/udp.h

[PATCH 19/36] net/unix: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- net/unix/af_unix.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 2d465bdeccbc..619c6921dd46 100644 --- a/net/unix/af_unix.c +++

[PATCH 17/36] net: remove sock_no_poll

2018-03-05 Thread Christoph Hellwig
Now that sock_poll handles a NULL ->poll or ->poll_mask there is no need for a stub. Signed-off-by: Christoph Hellwig --- crypto/af_alg.c | 1 - crypto/algif_hash.c | 2 -- crypto/algif_rng.c | 1 - drivers/isdn/mISDN/socket.c | 1 -

[PATCH 18/36] net/tcp: convert to ->poll_mask

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/net/tcp.h | 4 ++-- net/ipv4/af_inet.c | 3 ++- net/ipv4/tcp.c | 31 ++- net/ipv6/af_inet6.c | 3 ++- 4 files changed, 20 insertions(+), 21 deletions(-) diff --git a/include/net/tcp.h

Re: [bpf-next PATCH 04/16] net: generalize sk_alloc_sg to work with scatterlist rings

2018-03-05 Thread David Miller
From: John Fastabend Date: Mon, 05 Mar 2018 11:51:17 -0800 > The current implementation of sk_alloc_sg expects scatterlist to always > start at entry 0 and complete at entry MAX_SKB_FRAGS. > > Future patches will want to support starting at arbitrary offset into >

  1   2   3   4   >