[PATCH] net: implement IP_RECVHDRS option to get full headers through recvmsg cmsg.

2018-03-31 Thread Maciej Żenczykowski
From: Luigi Rizzo We have all sorts of different ways to fetch pre-UDP payload metadata: IP_RECVTOS IP_RECVTTL IP_RECVOPTS IP_RETOPTS But nothing generic which simply allows you to receive the entire packet header. This is in similar vein to TCP_SAVE_SYN but for UDP

SO_TCP_NODELAY implementation in TCP stack

2018-03-31 Thread Naruto Nguyen
Hello everyone, As I know we have a socket option SO_TCP_NODELAY to disable Nagle Algorithm, and I found it is implemented in TCP/IP stack at https://elixir.bootlin.com/linux/v4.4.90/source/net/ipv4/tcp.c#L2401 . However, I do not know where the source code the Nagle Algorithm is implemented in

Re: [PATCH v15 net-next 00/12] Chelsio Inline TLS

2018-03-31 Thread David Miller
From: Atul Gupta Date: Sat, 31 Mar 2018 21:41:51 +0530 > Series for Chelsio Inline TLS driver (chtls) Series applied, thank you.

Re: pull-request: bpf-next 2018-03-31

2018-03-31 Thread David Miller
From: Daniel Borkmann Date: Sun, 1 Apr 2018 01:51:12 +0200 > The following pull-request contains BPF updates for your *net-next* tree. Pulled, thanks Daniel.

Re: [net-next V8 PATCH 13/16] xdp: allow page_pool as an allocator type in xdp_return_frame

2018-03-31 Thread David Miller
From: Jesper Dangaard Brouer Date: Sat, 31 Mar 2018 14:06:52 +0200 > diff --git a/net/core/xdp.c b/net/core/xdp.c > index 8b2cb79b5de0..d8115903e454 100644 > --- a/net/core/xdp.c > +++ b/net/core/xdp.c ... > +static inline bool __is_supported_mem_type(enum xdp_mem_type type)

Re: [net-next V8 PATCH 01/16] mlx5: basic XDP_REDIRECT forward support

2018-03-31 Thread David Miller
From: Jesper Dangaard Brouer Date: Sat, 31 Mar 2018 14:05:52 +0200 > +static inline void mlx5e_page_dma_unmap(struct mlx5e_rq *rq, > + struct mlx5e_dma_info *dma_info) Please do not use the inline keyword in foo.c files, let the compiler

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-03-31 Thread David Miller
From: Eric Dumazet Date: Sat, 31 Mar 2018 12:58:41 -0700 > IP defrag processing is one of the remaining problematic layer in linux. > > It uses static hash tables of 1024 buckets, and up to 128 items per bucket. > > A work queue is supposed to garbage collect items when

Re: [PATCH net-next 00/16] bnxt_en: Update for net-next.

2018-03-31 Thread David Miller
From: Michael Chan Date: Sat, 31 Mar 2018 13:54:05 -0400 > Misc. updates including updated firmware interface, some additional > port statistics, a new IRQ assignment scheme for the RDMA driver, support > for VF trust, and other changes and improvements for SRIOV.

Re: [PATCH net-next] vlan: vlan_hw_filter_capable() can be static

2018-03-31 Thread David Miller
From: Wei Yongjun Date: Sat, 31 Mar 2018 06:11:41 + > Fixes the following sparse warning: > > net/8021q/vlan_core.c:168:6: warning: > symbol 'vlan_hw_filter_capable' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun

Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation to net DIM

2018-03-31 Thread David Miller
From: David Miller Date: Sat, 31 Mar 2018 22:02:55 -0400 (EDT) > From: Tal Gilboa > Date: Fri, 30 Mar 2018 09:37:29 +0300 > >> Net DIM is a library designed for dynamic interrupt moderation. It was >> implemented and optimized with receive side

Re: [PATCH v4 net-next 17/19] inet: frags: get rid of ipfrag_skb_cb/FRAG_CB

2018-03-31 Thread kbuild test robot
Hi Eric, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/inet-frags-bring-rhashtables-to-IP-defrag/20180401-053614 reproduce: make htmldocs All warnings (new ones prefixed by >>):

Re: [pull request][net-next 00/15] Mellanox, mlx5 updates 2018-03-30

2018-03-31 Thread David Miller
From: Saeed Mahameed Date: Fri, 30 Mar 2018 17:02:37 -0700 > This series contains updates to mlx5 core and mlx5e netdev drivers. > The main highlight of this series is the RX optimizations for striding RQ > path, > introduced by Tariq. > > For more information please see

Re: [PATCH net-next 00/12] rxrpc: Fixes and more traces

2018-03-31 Thread David Miller
From: David Howells Date: Fri, 30 Mar 2018 22:14:04 +0100 > Here are some patches that add some more tracepoints to AF_RXRPC and fix > some issues therein: ... > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git >

Re: [PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

2018-03-31 Thread David Miller
From: Haiyang Zhang Date: Fri, 30 Mar 2018 13:57:59 -0700 > From: Haiyang Zhang > > The variables, msg and data, have the same value. This patch removes > the extra one. > > Signed-off-by: Haiyang Zhang Applied.

Re: [PATCH] ethernet: hisilicon: hns: hns_dsaf_mac: Use generic eth_broadcast_addr

2018-03-31 Thread David Miller
From: Joe Perches Date: Fri, 30 Mar 2018 12:37:30 -0700 > Rather than use an on-stack array to copy a broadcast address, use > the generic eth_broadcast_addr function to save a trivial amount of > object code. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH RESEND net-next 0/2] net_rwsem fixes

2018-03-31 Thread David Miller
From: Kirill Tkhai Date: Fri, 30 Mar 2018 19:38:16 +0300 > there is wext_netdev_notifier_call()->wireless_nlevent_flush() > netdevice notifier, which takes net_rwsem, so we can't take > net_rwsem in {,un}register_netdevice_notifier(). > > Since

Re: [PATCH net-next 00/11] mlxsw: Various cleanups

2018-03-31 Thread David Miller
From: David Miller Date: Sat, 31 Mar 2018 21:54:50 -0400 (EDT) > From: Ido Schimmel > Date: Thu, 29 Mar 2018 23:33:23 +0300 > >> The first 10 patches from Jiri perform small and unrelated cleanups. The >> largest being the conversion of the KVD linear

Re: [PATCH v2 0/7] net: thunderx: implement DMAC filtering support

2018-03-31 Thread David Miller
From: Vadim Lomovtsev Date: Fri, 30 Mar 2018 04:59:46 -0700 > From: Vadim Lomovtsev > > By default CN88XX BGX accepts all incoming multicast and broadcast > packets and filtering is disabled. The nic driver doesn't provide > an

Re: [PATCH net-next] netdevsim: Change nsim_devlink_setup to return error to caller

2018-03-31 Thread David Miller
From: David Ahern Date: Fri, 30 Mar 2018 09:28:51 -0700 > Change nsim_devlink_setup to return any error back to the caller and > update nsim_init to handle it. > > Requested-by: Jakub Kicinski > Signed-off-by: David Ahern

Re: [PATCH net-next 0/2] net: bridge: MTU handling changes

2018-03-31 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 30 Mar 2018 13:46:17 +0300 > As previously discussed the recent changes break some setups and could lead > to packet drops. Thus the first patch reverts the behaviour for the bridge > to follow the minimum MTU but also keeps the

Re: [PATCH net-next 0/4] Introduce adaptive TX interrupt moderation to net DIM

2018-03-31 Thread David Miller
From: Tal Gilboa Date: Fri, 30 Mar 2018 09:37:29 +0300 > Net DIM is a library designed for dynamic interrupt moderation. It was > implemented and optimized with receive side interrupts in mind, since these > are usually the CPU expensive ones. This patch-set introduces

Re: [net-next v2 0/5] tipc: slim down name table

2018-03-31 Thread David Miller
From: Jon Maloy Date: Thu, 29 Mar 2018 23:20:40 +0200 > We clean up and improve the name binding table: > > - Replace the memory consuming 'sub_sequence/service range' array with >an RB tree. > - Introduce support for overlapping service sequences/ranges > > v2:

Re: [PATCH net-next v1 0/2] Meson8m2 support for dwmac-meson8b

2018-03-31 Thread David Miller
From: Martin Blumenstingl Date: Fri, 30 Mar 2018 01:00:33 +0200 > The Meson8m2 SoC is an updated version of the Meson8 SoC. Some of the > peripherals are shared with Meson8b (for example the watchdog registers > and the internal temperature sensor calibration

Re: [PATCH net-next 00/11] mlxsw: Various cleanups

2018-03-31 Thread David Miller
From: Ido Schimmel Date: Thu, 29 Mar 2018 23:33:23 +0300 > The first 10 patches from Jiri perform small and unrelated cleanups. The > largest being the conversion of the KVD linear partitions from a list to > an array, which simplifies the code. > > The last patch from Petr

Re: [PATCH] net: phy: marvell10g: add thermal hwmon device

2018-03-31 Thread David Miller
From: Russell King Date: Wed, 28 Mar 2018 11:20:26 +0100 > + > /* > * Resetting the MV88X3310 causes it to become non-responsive. Avoid > * setting the reset bit(s). This comment doesn't exist in the net-next copy of this file.

Re: [PATCH net-next v3 1/3] vmcore: add API to collect hardware dump in second kernel

2018-03-31 Thread kbuild test robot
Hi Rahul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Rahul-Lakkireddy/kernel-add-support-to-collect-hardware-logs-in-crash-recovery-kernel/20180401-060904 reproduce: # apt-get

[RFC PATCH] vmcore: __vmcore_add_device_dump() can be static

2018-03-31 Thread kbuild test robot
Fixes: 6bf7e2b7f850 ("vmcore: add API to collect hardware dump in second kernel") Signed-off-by: Fengguang Wu --- vmcore.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index b53698f..fe788dd 100644 ---

Re: [PATCH net-next v3 3/3] cxgb4: collect hardware dump in second kernel

2018-03-31 Thread kbuild test robot
Hi Rahul, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Rahul-Lakkireddy/kernel-add-support-to-collect-hardware-logs-in-crash-recovery-kernel/20180401-060904 config: tile-allyesconfig (attached as

Re: [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread kbuild test robot
Hi Joe, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH net-next v3 3/3] cxgb4: collect hardware dump in second kernel

2018-03-31 Thread kbuild test robot
Hi Rahul, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Rahul-Lakkireddy/kernel-add-support-to-collect-hardware-logs-in-crash-recovery-kernel/20180401-060904 config: sparc64-allyesconfig (attached

Re: [PATCH] net: bond: skip vlan header when do layer 3+4 hash policy

2018-03-31 Thread kbuild test robot
Hi liujian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on v4.16-rc7 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

pull-request: bpf-next 2018-03-31

2018-03-31 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Add raw BPF tracepoint API in order to have a BPF program type that can access kernel internal arguments of the tracepoints in their raw form similar to kprobes based BPF programs.

Re:

2018-03-31 Thread Ms Gloria Chow
How are you? I would like to discuss a possible collaboration on my projects that I have been operating over some years, hence please advice. I am Gloria Chow, the Head of Client Relationships of Standard Chartered Bank (Hong Kong) Ltd. I contacted you on LinkedIn with a disguise account,

general protection fault in __list_del_entry_valid (3)

2018-03-31 Thread syzbot
Hello, syzbot hit the following crash on net-next commit c0b6edef0bf0e33c12eaf80c676ff09def011518 (Thu Mar 29 19:58:10 2018 +) tc-testing: Add newline when writing test case files syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=0bb443b74ce09197e970 So far this crash

WARNING in refcount_inc (3)

2018-03-31 Thread syzbot
Hello, syzbot hit the following crash on bpf-next commit 1379ef828a18d8f81c526b25e4d5685caa2cfd65 (Thu Mar 29 22:09:44 2018 +) Merge branch 'bpf-sockmap-ingress' syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=6eaf536fd743f5e119c5 So far this crash happened 6 times on

Re: [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support

2018-03-31 Thread Florian Fainelli
Le 03/30/18 à 07:50, Andrew Lunn a écrit : > On Fri, Mar 30, 2018 at 04:16:34PM +0200, Alexandre Belloni wrote: >> On 30/03/2018 at 15:54:22 +0200, Andrew Lunn wrote: > All of this sounds like it should be moved into the br_join/leave, this > does not appear to be the right place to do

[PATCH net-next v1] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms

2018-03-31 Thread Vincent Bernat
The sh/dh/lblc/lblcr algorithms are using Knuth's multiplicative hashing incorrectly. This results in uneven distribution. To fix this, the result has to be shifted by a constant. In "Lecture 21: Hash functions" [1], it is said: In the fixed-point version, The division by 2^q is crucial. The

Re: [PATCH net-next 1/2] sh_eth: add sh_eth_cpu_data::no_xdfar flag

2018-03-31 Thread Sergei Shtylyov
On 04/01/2018 12:22 AM, Sergei Shtylyov wrote: > The commit 6ded286555c2 ("sh_eth: Fix RX recovery on R-Car in case of RX > ring underrun") added a check for an bad RDFAR offset in sh_eth_rx(), so > that the code could work on the R-Car Ether controllers which don't have > this register (and

[PATCH net-next 2/2] sh_eth: kill useless check in __sh_eth_get_regs()

2018-03-31 Thread Sergei Shtylyov
Iff TSU registers exist on a given [G]Ether controller, they always include the CAM entry table registers (TSU_ADR{H|L}), thus the check for invalid TSU_ADRH0 offset in __sh_eth_get_regs() is useless... Signed-off-by: Sergei Shtylyov ---

Re: [PATCH v3 bpf-next 0/9] bpf: introduce cgroup-bpf bind, connect, post-bind hooks

2018-03-31 Thread Daniel Borkmann
On 03/31/2018 12:07 AM, Alexei Starovoitov wrote: > v2->v3: > - rebase due to conflicts > - fix ipv6=m build > > v1->v2: > - support expected_attach_type at prog load time so that prog (incl. > context accesses and calls to helpers) can be validated with regard to > specific attach point it

[PATCH net-next 1/2] sh_eth: add sh_eth_cpu_data::no_xdfar flag

2018-03-31 Thread Sergei Shtylyov
The commit 6ded286555c2 ("sh_eth: Fix RX recovery on R-Car in case of RX ring underrun") added a check for an bad RDFAR offset in sh_eth_rx(), so that the code could work on the R-Car Ether controllers which don't have this register (and TDFAR), then the commit 3365711df02 ("sh_eth: WARN on access

[PATCH 0/2] sh_eth: remove SH_ETH_OFFSET_INVALID abuses

2018-03-31 Thread Sergei Shtylyov
Hello! Here's a set of 2 patches against DaveM's 'net-next.git' repo. They get rid of the abuse of SH_ETH_OFFSET_INVALID for the register existence checks, so that only its necessary uses would remain... [1/2] sh_eth: add sh_eth_cpu_data::no_xdfar flag [2/2] sh_eth: kill useless check in

[PATCH net-next 1/2] ipv4: factorize sk_wmem_alloc updates done by __ip_append_data()

2018-03-31 Thread Eric Dumazet
While testing my inet defrag changes, I found that the senders could spend ~20% of cpu cycles in skb_set_owner_w() updating sk->sk_wmem_alloc for every fragment they cook. The solution to this problem is to use alloc_skb() instead of sock_wmalloc() and manually perform a single sk_wmem_alloc

[PATCH net-next 0/2] inet: factorize sk_wmem_alloc updates

2018-03-31 Thread Eric Dumazet
While testing my inet defrag changes, I found that senders could spend ~20% of cpu cycles in skb_set_owner_w() updating sk->sk_wmem_alloc for every fragment they cook, competing with TX completion of prior skbs possibly happening on another cpus. One solution to this problem is to use alloc_skb()

[PATCH net-next 2/2] ipv6: factorize sk_wmem_alloc updates done by __ip6_append_data()

2018-03-31 Thread Eric Dumazet
While testing my inet defrag changes, I found that the senders could spend ~20% of cpu cycles in skb_set_owner_w() updating sk->sk_wmem_alloc for every fragment they cook, competing with TX completion of prior skbs possibly happening on another cpus. The solution to this problem is to use

[PATCH v4 net-next 11/19] inet: frags: remove inet_frag_maybe_warn_overflow()

2018-03-31 Thread Eric Dumazet
This function is obsolete, after rhashtable addition to inet defrag. Signed-off-by: Eric Dumazet --- include/net/inet_frag.h | 2 -- net/ieee802154/6lowpan/reassembly.c | 5 ++--- net/ipv4/inet_fragment.c| 11 ---

[PATCH v4 net-next 18/19] ipv6: frags: get rid of ip6frag_skb_cb/FRAG6_CB

2018-03-31 Thread Eric Dumazet
ip6_frag_queue uses skb->cb[] to store the fragment offset, meaning that we could use two cache lines per skb when finding the insertion point, if for some reason inet6_skb_parm size is increased in the future. By using skb->ip_defrag_offset instead of skb->cb[], we pack all the fields in a

[PATCH v4 net-next 04/19] inet: frags: refactor ipv6_frag_init()

2018-03-31 Thread Eric Dumazet
We want to call inet_frags_init() earlier. This is a prereq to "inet: frags: use rhashtables for reassembly units" Signed-off-by: Eric Dumazet --- net/ipv6/reassembly.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git

[PATCH v4 net-next 16/19] inet: frags: reorganize struct netns_frags

2018-03-31 Thread Eric Dumazet
Put the read-mostly fields in a separate cache line at the beginning of struct netns_frags, to reduce false sharing noticed in inet_frag_kill() Signed-off-by: Eric Dumazet --- include/net/inet_frag.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v4 net-next 19/19] inet: frags: get rid of nf_ct_frag6_skb_cb/NFCT_FRAG6_CB

2018-03-31 Thread Eric Dumazet
nf_ct_frag6_queue() uses skb->cb[] to store the fragment offset, meaning that we could use two cache lines per skb when finding the insertion point, if for some reason inet6_skb_parm size is increased in the future. By using skb->ip_defrag_offset instead of skb->cb[] we pack all the fields in a

[PATCH v4 net-next 09/19] inet: frags: remove some helpers

2018-03-31 Thread Eric Dumazet
Remove sum_frag_mem_limit(), ip_frag_mem() & ip6_frag_mem() Also since we use rhashtable we can bring back the number of fragments in "grep FRAG /proc/net/sockstat /proc/net/sockstat6" that was removed in commit 434d305405ab ("inet: frag: don't account number of fragment queues") Signed-off-by:

[PATCH v4 net-next 17/19] inet: frags: get rid of ipfrag_skb_cb/FRAG_CB

2018-03-31 Thread Eric Dumazet
ip_defrag uses skb->cb[] to store the fragment offset, and unfortunately this integer is currently in a different cache line than skb->next, meaning that we use two cache lines per skb when finding the insertion point. By aliasing skb->ip_defrag_offset and skb->dev, we pack all the fields in a

[PATCH v4 net-next 15/19] rhashtable: reorganize struct rhashtable layout

2018-03-31 Thread Eric Dumazet
While under frags DDOS I noticed unfortunate false sharing between @nelems and @params.automatic_shrinking Move @nelems at the end of struct rhashtable so that first cache line is shared between all cpus, because almost never dirtied. Signed-off-by: Eric Dumazet ---

[PATCH v4 net-next 14/19] ipv6: frags: rewrite ip6_expire_frag_queue()

2018-03-31 Thread Eric Dumazet
Make it similar to IPv4 ip_expire(), and release the lock before calling icmp functions. Signed-off-by: Eric Dumazet --- net/ipv6/reassembly.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/net/ipv6/reassembly.c

[PATCH v4 net-next 13/19] inet: frags: do not clone skb in ip_expire()

2018-03-31 Thread Eric Dumazet
An skb_clone() was added in commit ec4fbd64751d ("inet: frag: release spinlock before calling icmp_send()") While fixing the bug at that time, it also added a very high cost for DDOS frags, as the ICMP rate limit is applied after this expensive operation (skb_clone() + consume_skb(), implying

[PATCH v4 net-next 10/19] inet: frags: get rif of inet_frag_evicting()

2018-03-31 Thread Eric Dumazet
This refactors ip_expire() since one indentation level is removed. Note: in the future, we should try hard to avoid the skb_clone() since this is a serious performance cost. Under DDOS, the ICMP message wont be sent because of rate limits. Fact that ip6_expire_frag_queue() does not use

[PATCH v4 net-next 12/19] inet: frags: break the 2GB limit for frags storage

2018-03-31 Thread Eric Dumazet
Some users are willing to provision huge amounts of memory to be able to perform reassembly reasonnably well under pressure. Current memory tracking is using one atomic_t and integers. Switch to atomic_long_t so that 64bit arches can use more than 2GB, without any cost for 32bit arches. Note

[PATCH v4 net-next 06/19] inet: frags: refactor ipfrag_init()

2018-03-31 Thread Eric Dumazet
We need to call inet_frags_init() before register_pernet_subsys(), as a prereq for following patch ("inet: frags: use rhashtables for reassembly units") Signed-off-by: Eric Dumazet --- net/ipv4/ip_fragment.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v4 net-next 08/19] inet: frags: use rhashtables for reassembly units

2018-03-31 Thread Eric Dumazet
Some applications still rely on IP fragmentation, and to be fair linux reassembly unit is not working under any serious load. It uses static hash tables of 1024 buckets, and up to 128 items per bucket (!!!) A work queue is supposed to garbage collect items when host is under memory pressure, and

[PATCH v4 net-next 05/19] inet: frags: refactor lowpan_net_frag_init()

2018-03-31 Thread Eric Dumazet
We want to call lowpan_net_frag_init() earlier. Similar to commit "inet: frags: refactor ipv6_frag_init()" This is a prereq to "inet: frags: use rhashtables for reassembly units" Signed-off-by: Eric Dumazet --- net/ieee802154/6lowpan/reassembly.c | 20 +++-

[PATCH v4 net-next 07/19] rhashtable: add schedule points

2018-03-31 Thread Eric Dumazet
Rehashing and destroying large hash table takes a lot of time, and happens in process context. It is safe to add cond_resched() in rhashtable_rehash_table() and rhashtable_free_and_destroy() Signed-off-by: Eric Dumazet Acked-by: Herbert Xu ---

[PATCH v4 net-next 02/19] inet: frags: change inet_frags_init_net() return value

2018-03-31 Thread Eric Dumazet
We will soon initialize one rhashtable per struct netns_frags in inet_frags_init_net(). This patch changes the return value to eventually propagate an error. Signed-off-by: Eric Dumazet --- include/net/inet_frag.h | 3 ++-

[PATCH v4 net-next 03/19] inet: frags: add a pointer to struct netns_frags

2018-03-31 Thread Eric Dumazet
In order to simplify the API, add a pointer to struct inet_frags. This will allow us to make things less complex. These functions no longer have a struct inet_frags parameter : inet_frag_destroy(struct inet_frag_queue *q /*, struct inet_frags *f */) inet_frag_put(struct inet_frag_queue *q /*,

[PATCH v4 net-next 01/19] ipv6: frag: remove unused field

2018-03-31 Thread Eric Dumazet
csum field in struct frag_queue is not used, remove it. Signed-off-by: Eric Dumazet --- include/net/ipv6.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/ipv6.h b/include/net/ipv6.h index

[PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-03-31 Thread Eric Dumazet
IP defrag processing is one of the remaining problematic layer in linux. It uses static hash tables of 1024 buckets, and up to 128 items per bucket. A work queue is supposed to garbage collect items when host is under memory pressure, and doing a hash rebuild, changing seed used in hash

Re: [PATCH 04/12] bridge: netfilter: Use the new global ether__addr arrays

2018-03-31 Thread Joe Perches
On Sat, 2018-03-31 at 20:28 +0200, Pablo Neira Ayuso wrote: > Hi Joe, Hi Pablo. > On Sat, Mar 31, 2018 at 12:05:19AM -0700, Joe Perches wrote: > > Remove the local consts and use the new globals. > > This one is already upstream: > >

[PATCH V2] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread Joe Perches
eth_stp_addr is not in the same form as the other global ether__addr addresses like ether_broadcast_addr. Convert it treewide. Miscellanea: o Add comment to the ether_stp_addr define to show it's for spanning-tree Signed-off-by: Joe Perches --- V2: Remove gg from initial

Re: [PATCH 04/12] bridge: netfilter: Use the new global ether__addr arrays

2018-03-31 Thread Pablo Neira Ayuso
Hi Joe, On Sat, Mar 31, 2018 at 12:05:19AM -0700, Joe Perches wrote: > Remove the local consts and use the new globals. This one is already upstream: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git/commit/?id=9124a20d8794663a396b5d6f91f66903848a042b I can see you're using

Re: [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread Joe Perches
On Sat, 2018-03-31 at 19:36 +0200, Andrew Lunn wrote: > On Sat, Mar 31, 2018 at 12:05:17AM -0700, Joe Perches wrote: > > --- a/net/bridge/br_device.c > > +++ b/net/bridge/br_device.c > > @@ -1,4 +1,4 @@ > > -/* > > +gg/* > > Hi Joe > > This does not look good. Definitely agree with that.

[PATCH net-next 04/16] bnxt_en: fix clear flags in ethtool reset handling

2018-03-31 Thread Michael Chan
From: Scott Branden Clear flags when reset command processed successfully for components specified. Fixes: 6502ad5963a5 ("bnxt_en: Add ETH_RESET_AP support") Signed-off-by: Scott Branden Signed-off-by: Michael Chan

[PATCH net-next 03/16] bnxt_en: Use a dedicated VNIC mode for RDMA.

2018-03-31 Thread Michael Chan
If the RDMA driver is registered, use a new VNIC mode that allows RDMA traffic to be seen on the netdev in promiscuous mode. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 18 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h |

[PATCH net-next 10/16] bnxt_en: Improve valid bit checking in firmware response message.

2018-03-31 Thread Michael Chan
When firmware sends a DMA response to the driver, the last byte of the message will be set to 1 to indicate that the whole response is valid. The driver waits for the message to be valid before reading the message. The firmware spec allows these response messages to increase in length by adding

[PATCH net-next 05/16] bnxt_en: Add support for ndo_set_vf_trust

2018-03-31 Thread Michael Chan
From: Vasundhara Volam Trusted VFs are allowed to modify MAC address, even when PF has assigned one. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan ---

[PATCH net-next 15/16] bnxt_en: Reserve completion rings and MSIX for bnxt_re RDMA driver.

2018-03-31 Thread Michael Chan
Add additional logic to reserve completion rings for the bnxt_re driver when it requests MSIX vectors. The function bnxt_cp_rings_in_use() will return the total number of completion rings used by both drivers that need to be reserved. If the network interface in up, we will close and open the

[PATCH net-next 06/16] bnxt_en: Include additional hardware port statistics in ethtool -S.

2018-03-31 Thread Michael Chan
From: Vasundhara Volam Include additional hardware port statistics in ethtool -S, which are useful for debugging. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan ---

[PATCH net-next 12/16] bnxt_en: Change IRQ assignment for RDMA driver.

2018-03-31 Thread Michael Chan
In the current code, the range of MSIX vectors allocated for the RDMA driver is disjoint from the network driver. This creates a problem for the new firmware ring reservation scheme. The new scheme requires the reserved completion rings/MSIX vectors to be in a contiguous range. Change the logic

[PATCH net-next 07/16] bnxt_en: Add extended port statistics support

2018-03-31 Thread Michael Chan
From: Vasundhara Volam Gather periodic extended port statistics, if the device is PF and link is up. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan ---

[PATCH net-next 11/16] bnxt_en: Improve ring allocation logic.

2018-03-31 Thread Michael Chan
Currently, the driver code makes some assumptions about the group index and the map index of rings. This makes the code more difficult to understand and less flexible. Improve it by adding the grp_idx and map_idx fields explicitly to the bnxt_ring_struct as a union. The grp_idx is initialized

[PATCH net-next 08/16] bnxt_en: Check max_tx_scheduler_inputs value from firmware.

2018-03-31 Thread Michael Chan
When checking for the maximum pre-set TX channels for ethtool -l, we need to check the current max_tx_scheduler_inputs parameter from firmware. This parameter specifies the max input for the internal QoS nodes currently available to this function. The function's TX rings will be capped by this

[PATCH net-next 14/16] bnxt_en: Refactor bnxt_need_reserve_rings().

2018-03-31 Thread Michael Chan
Refactor bnxt_need_reserve_rings() slightly so that __bnxt_reserve_rings() can call it and remove some duplicated code. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 57 ++- 1 file changed, 25 insertions(+), 32

[PATCH net-next 13/16] bnxt_en: Add IRQ remapping logic.

2018-03-31 Thread Michael Chan
Add remapping logic so that bnxt_en can use any arbitrary MSIX vectors. This will allow the driver to reserve one range of MSIX vectors to be used by both bnxt_en and bnxt_re. bnxt_en can now skip over the MSIX vectors used by bnxt_re. Signed-off-by: Michael Chan ---

[PATCH net-next 02/16] bnxt_en: Adjust default rings for multi-port NICs.

2018-03-31 Thread Michael Chan
Change the default ring logic to select default number of rings to be up to 8 per port if the default rings x NIC ports <= total CPUs. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 +--- 1 file changed, 9 insertions(+), 3

[PATCH net-next 09/16] bnxt_en: Improve resource accounting for SRIOV.

2018-03-31 Thread Michael Chan
When VFs are created, the current code subtracts the maximum VF resources from the PF's pool. This under-estimates the resources remaining in the PF pool. Instead, we should subtract the minimum VF resources. The VF minimum resources are guaranteed to the VFs and only these should be subtracted

[PATCH net-next 16/16] bnxt_en: Add ULP calls to stop and restart IRQs.

2018-03-31 Thread Michael Chan
When the driver needs to re-initailize the IRQ vectors, we make the new ulp_irq_stop() call to tell the RDMA driver to disable and free the IRQ vectors. After IRQ vectors have been re-initailized, we make the ulp_irq_restart() call to tell the RDMA driver that IRQs can be restarted.

[PATCH net-next 01/16] bnxt_en: Update firmware interface to 1.9.1.15.

2018-03-31 Thread Michael Chan
Minor changes, such as new extended port statistics. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 15 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h | 5 +-

[PATCH net-next 00/16] bnxt_en: Update for net-next.

2018-03-31 Thread Michael Chan
Misc. updates including updated firmware interface, some additional port statistics, a new IRQ assignment scheme for the RDMA driver, support for VF trust, and other changes and improvements for SRIOV. Michael Chan (12): bnxt_en: Update firmware interface to 1.9.1.15. bnxt_en: Adjust default

Re: [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread Andrew Lunn
On Sat, Mar 31, 2018 at 12:05:17AM -0700, Joe Perches wrote: > --- a/net/bridge/br_device.c > +++ b/net/bridge/br_device.c > @@ -1,4 +1,4 @@ > -/* > +gg/* Hi Joe This does not look good. Andrew

Re: [PATCH v4 0/2] of_net: Implement of_get_nvmem_mac_address helper

2018-03-31 Thread Andrew Lunn
On Sat, Mar 31, 2018 at 07:20:30PM +0200, Mike Looijmans wrote: > On 30-03-18 16:40, David Miller wrote: > >From: Mike Looijmans > >Date: Thu, 29 Mar 2018 07:29:47 +0200 > > > >>Posted this as a small set now, with an (optional) second patch that shows > >>how the changes

Re: [PATCH net-next 0/9] devlink: Add support for region access

2018-03-31 Thread David Ahern
On 3/31/18 9:53 AM, Andrew Lunn wrote: >> I want to be able to login to a customer and accessing this snapshot >> without any previous configuration from the user and not asking for >> enabling the feature and then waiting for a repro...this will help >> debugging issues that are hard to

Re: [PATCH v4 0/2] of_net: Implement of_get_nvmem_mac_address helper

2018-03-31 Thread Mike Looijmans
On 30-03-18 16:40, David Miller wrote: From: Mike Looijmans Date: Thu, 29 Mar 2018 07:29:47 +0200 Posted this as a small set now, with an (optional) second patch that shows how the changes work and what I've used to test the code on a Topic Miami board. I've taken the

Re: INFO: task hung in fib6_rules_net_exit

2018-03-31 Thread Dmitry Vyukov
#syz dup: INFO: task hung in netdev_run_todo On Sat, Mar 31, 2018 at 6:14 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 18845557fd6fc1998f2d0d8c30467f86db587529 (Thu Mar 29 20:24:06 2018 +) > Merge

[PATCH v15 net-next 12/12] crypto: chtls - Makefile Kconfig

2018-03-31 Thread Atul Gupta
Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16

INFO: task hung in fib6_rules_net_exit

2018-03-31 Thread syzbot
Hello, syzbot hit the following crash on net-next commit 18845557fd6fc1998f2d0d8c30467f86db587529 (Thu Mar 29 20:24:06 2018 +) Merge tag 'wireless-drivers-next-for-davem-2018-03-29' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next syzbot dashboard link:

[PATCH v15 net-next 10/12] crypto: chtls - Inline TLS record Rx

2018-03-31 Thread Atul Gupta
handler for record receive. plain text copied to user buffer Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_io.c | 602 +- drivers/crypto/chelsio/chtls/chtls_main.c | 1 +

[PATCH v15 net-next 07/12] crypto: chtls - Register chtls with net tls

2018-03-31 Thread Atul Gupta
Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta Reviewed-by: Casey Leedom Reviewed-by: Michael Werner

[PATCH v15 net-next 00/12] Chelsio Inline TLS

2018-03-31 Thread Atul Gupta
Thanks everyone for reviewing the series. Dave, this should apply clean on net-next tree and I think it is ready to merge. Series for Chelsio Inline TLS driver (chtls) Use tls ULP infrastructure to register chtls as Inline TLS driver. Chtls use TCP Sockets to Tx/Rx TLS records. TCP sk_proto

[PATCH v15 net-next 11/12] crypto: chtls - Program the TLS session Key

2018-03-31 Thread Atul Gupta
Initialize the space reserved for storing the TLS keys, get and free the location where key is stored for the TLS connection. Program the Tx and Rx key as received from user in struct tls12_crypto_info_aes_gcm_128 and understood by hardware. added socket option TLS_RX Signed-off-by: Atul Gupta

[PATCH v15 net-next 09/12] crypto: chtls - Inline TLS record Tx

2018-03-31 Thread Atul Gupta
TLS handler for record transmit. Create Inline TLS work request and post to FW. Create Inline TLS record CPLs for hardware Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_io.c | 1222

[PATCH v15 net-next 05/12] crypto: chcr - Inline TLS Key Macros

2018-03-31 Thread Atul Gupta
Define macro for programming the TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1

[PATCH v15 net-next 08/12] crypto : chtls - CPL handler definition

2018-03-31 Thread Atul Gupta
Exchange messages with hardware to program the TLS session CPL handlers for messages received from chip. Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2126 +++

  1   2   >