Re: [PATCH ipsec] vti6: Change minimum MTU to IPV4_MIN_MTU, vti6 can carry IPv4 too

2018-04-29 Thread Steffen Klassert
On Thu, Apr 26, 2018 at 07:39:09PM +0200, Stefano Brivio wrote: > A vti6 interface can carry IPv4 as well, so it makes no sense to > enforce a minimum MTU of IPV6_MIN_MTU. > > If the user sets an MTU below IPV6_MIN_MTU, IPv6 will be > disabled on the interface, courtesy of addrconf_notify(). > >

Product Inquiry

2018-04-29 Thread Gerhard Kahmann
?Dear Sir, We recently visited your website, we were recommended by one of your customer and we are interested in your models, We will like to place an order from the list of your products. However, we would like to see your company's latest catalogs with the; minimum order quantity, delivery t

Re: [PATCH bpf-next v2] samples/bpf: fix kprobe attachment issue on x64

2018-04-29 Thread Alexei Starovoitov
On Sun, Apr 29, 2018 at 07:27:48PM -0700, Yonghong Song wrote: > Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename > struct pt_regs-based sys_*() to __x64_sys_*()") renamed a lot > of syscall function sys_*() to __x64_sys_*(). > This caused several kprobe based samples/bpf tests failing. >

Re: [PATCH net-next v9 2/4] net: Introduce generic failover module

2018-04-29 Thread Samudrala, Sridhar
On 4/28/2018 2:06 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:58PM CEST, sridhar.samudr...@intel.com wrote: This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their da

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-29 Thread Samudrala, Sridhar
On 4/28/2018 1:24 AM, Jiri Pirko wrote: Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF withou

Re: [RFC net-next 0/5] Support for PHY test modes

2018-04-29 Thread David Miller
From: Florian Fainelli Date: Fri, 27 Apr 2018 17:32:30 -0700 > This patch series adds support for specifying PHY test modes through > ethtool and paves the ground for adding support for more complex > test modes that might require data to be exchanged between user and > kernel space. > > As an e

Re: [PATCH net-next] net: core: Assert the size of netdev_featres_t

2018-04-29 Thread David Miller
From: Florian Fainelli Date: Fri, 27 Apr 2018 13:11:14 -0700 > We have about 53 netdev_features_t bits defined and counting, add a > build time check to catch when an u64 type will not be enough and we > will have to convert that to a bitmap. This is done in > register_netdevice() for convenience

Re: [PATCH net] MAINTAINERS: add myself as SCTP co-maintainer

2018-04-29 Thread David Miller
From: Marcelo Ricardo Leitner Date: Fri, 27 Apr 2018 16:46:11 -0300 > Signed-off-by: Marcelo Ricardo Leitner Applied.

Re: [PATCH] net: systemport: fix spelling mistake: "asymetric" -> "asymmetric"

2018-04-29 Thread David Miller
From: Colin King Date: Fri, 27 Apr 2018 20:09:25 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in netdev_warn warning message > > Signed-off-by: Colin Ian King Applied, thank you.

Greetings

2018-04-29 Thread Zeliha Omer faruk
Hello Dear Greetings to you, please I have a very important business proposal for our mutual benefit, please let me know if you are interested please i asked you before. Best Regards, Miss. Zeliha ömer Faruk Caddesi Kristal Kule Binasi No:215

Re: [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-04-29 Thread Marcelo Ricardo Leitner
On Mon, Apr 30, 2018 at 10:14:06AM +0800, kbuild test robot wrote: > Hi Marcelo, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Marcelo-Ricardo-Leitner/sctp-allow-sctp_init_cause-to-return

[PATCH bpf-next v2] samples/bpf: fix kprobe attachment issue on x64

2018-04-29 Thread Yonghong Song
Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()") renamed a lot of syscall function sys_*() to __x64_sys_*(). This caused several kprobe based samples/bpf tests failing. This patch fixed the problem in bpf_load.c. For x86_64 architecture, fun

Re: [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-04-29 Thread kbuild test robot
Hi Marcelo, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Marcelo-Ricardo-Leitner/sctp-allow-sctp_init_cause-to-return-errors/20180430-073613 config: x86_64-randconfig-x006-201817 (attached as .conf

Re: [PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-04-29 Thread kbuild test robot
Hi Marcelo, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Marcelo-Ricardo-Leitner/sctp-allow-sctp_init_cause-to-return-errors/20180430-073613 config: i386-randconfig-s1-201817 (attached as .config)

Re: [PATCH 0/3] Clean up users of skb_tx_hash and __skb_tx_hash

2018-04-29 Thread David Miller
From: Alexander Duyck Date: Fri, 27 Apr 2018 14:06:22 -0400 > I am in the process of doing some work to try and enable macvlan Tx queue > selection without using ndo_select_queue. As a part of that I will likely > need to make changes to skb_tx_hash. As such this is a clean up or refactor > of th

[PATCH net] tcp: fix TCP_REPAIR_QUEUE bound checking

2018-04-29 Thread Eric Dumazet
syzbot is able to produce a nasty WARN_ON() in tcp_verify_left_out() with following C-repro : socket(PF_INET, SOCK_STREAM, IPPROTO_IP) = 3 setsockopt(3, SOL_TCP, TCP_REPAIR, [1], 4) = 0 setsockopt(3, SOL_TCP, TCP_REPAIR_QUEUE, [-1], 4) = 0 bind(3, {sa_family=AF_INET, sin_port=htons(20002), sin_ad

[PATCH] ethtool: fix a potential missing-check bug

2018-04-29 Thread Wenwen Wang
In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has new definition, as mentioned in the comment. H

Re: [PATCH v6 net-next 0/3] lan78xx updates along with Fixed phy Support

2018-04-29 Thread David Miller
From: Raghuram Chary J Date: Sat, 28 Apr 2018 11:33:13 +0530 > These series of patches handle few modifications in driver > and adds support for fixed phy. Series applied, thank you.

Re: [PATCH] vhost: make msg padding explicit

2018-04-29 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 27 Apr 2018 19:02:05 +0300 > There's a 32 bit hole just after type. It's best to > give it a name, this way compiler is forced to initialize > it with rest of the structure. > > Reported-by: Kevin Easton > Signed-off-by: Michael S. Tsirkin Who applied thi

Re: [PATCH v4 net-next 0/2] tcp: mmap: rework zerocopy receive

2018-04-29 Thread David Miller
From: Eric Dumazet Date: Fri, 27 Apr 2018 08:58:07 -0700 > syzbot reported a lockdep issue caused by tcp mmap() support. > > I implemented Andy Lutomirski nice suggestions to resolve the > issue and increase scalability as well. > > First patch is adding a new getsockopt() operation and changes

Re: [RFC v2 bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

2018-04-29 Thread David Ahern
On 4/29/18 5:36 PM, Alexei Starovoitov wrote: >> +if (flags & BPF_FIB_LOOKUP_DIRECT) { >> +u32 tbid = l3mdev_fib_table_rcu(dev) ? : RT_TABLE_MAIN; >> +struct fib_table *tb; >> + >> +tb = fib_get_table(net, tbid); >> +if (unlikely(!tb)) >> +

Re: [PATCHv2 net] bridge: check iface upper dev when setting master via ioctl

2018-04-29 Thread David Miller
From: Hangbin Liu Date: Fri, 27 Apr 2018 20:59:24 +0800 > When we set a bond slave's master to bridge via ioctl, we only check > the IFF_BRIDGE_PORT flag. Although we will find the slave's real master > at netdev_master_upper_dev_link() later, it already does some settings > and allocates some re

Re: [PATCH net-next 0/3] net: dsa: mv88e6xxx: remove Global 2 setup

2018-04-29 Thread David Miller
From: Vivien Didelot Date: Thu, 26 Apr 2018 21:56:43 -0400 > Parts of the mv88e6xxx driver still write arbitrary registers of > different banks at setup time, which is misleading especially when > supporting multiple device models. > > This patchset moves two features setup into the top lovel >

Re: [PATCH bpf-next] samples/bpf: fix kprobe attachment issue on x64

2018-04-29 Thread Yonghong Song
On 4/29/18 5:06 PM, Alexei Starovoitov wrote: On Sun, Apr 29, 2018 at 05:00:23PM -0700, Yonghong Song wrote: On 4/29/18 4:20 PM, Alexei Starovoitov wrote: On Sun, Apr 29, 2018 at 03:06:31PM -0700, Yonghong Song wrote: Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs

linux-next: manual merge of the ipsec-next tree with the net-next tree

2018-04-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the ipsec-next tree got a conflict in: net/ipv4/ip_output.c between commit: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT") from the net-next tree and commit: cd027a5433d6 ("udp: enable UDP checksum offload for ESP") from the ipsec-next tree. I

Re: [PATCH net-next v9 0/4] Prerequisites for Cavium OCTEON-III network driver.

2018-04-29 Thread David Miller
From: "Steven J. Hill" Date: Thu, 26 Apr 2018 18:30:10 -0500 > We want to add the Cavium OCTEON-III network driver. But since > interacting with the input and output queues is done via special CPU > local memory, we also need to add support to the MIPS/Octeon > architecture code. Aren't SoCs ni

Re: [PATCH net-next 1/1] inet_diag: fetch cong algo info when socket is destroyed

2018-04-29 Thread David Miller
From: Jamal Hadi Salim Date: Thu, 26 Apr 2018 13:58:05 -0400 > From: Jamal Hadi Salim > > When a user dumps an existing established tcp socket state > via inet diag, it is possible to retrieve the congestion control > details. > When an the sock is destroyed, the generated event has all the > d

linux-next: manual merge of the net-next tree with the net tree

2018-04-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: tools/testing/selftests/net/Makefile between commit: 9faedd643fd9 ("selftests: net: add in_netns.sh TEST_GEN_PROGS_EXTENDED") from the net tree and commit: a160725780e3 ("selftests: udp gso") from the net-next tre

Re: [PATCH bpf-next] samples/bpf: fix kprobe attachment issue on x64

2018-04-29 Thread Alexei Starovoitov
On Sun, Apr 29, 2018 at 05:00:23PM -0700, Yonghong Song wrote: > > > On 4/29/18 4:20 PM, Alexei Starovoitov wrote: > > On Sun, Apr 29, 2018 at 03:06:31PM -0700, Yonghong Song wrote: > > > Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename > > > struct pt_regs-based sys_*() to __x64_sys_*()

Re: [PATCH bpf-next] samples/bpf: fix kprobe attachment issue on x64

2018-04-29 Thread Yonghong Song
On 4/29/18 4:20 PM, Alexei Starovoitov wrote: On Sun, Apr 29, 2018 at 03:06:31PM -0700, Yonghong Song wrote: Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()") renamed a lot of syscall function sys_*() to __x64_sys_*(). This caused several

Re: [RFC v2 bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

2018-04-29 Thread Alexei Starovoitov
On Sun, Apr 29, 2018 at 11:07:51AM -0700, David Ahern wrote: > Provide a helper for doing a FIB and neighbor lookup in the kernel > tables from an XDP program. The helper provides a fastpath for forwarding > packets. If the packet is a local delivery or for any reason is not a > simple lookup and f

Re: [PATCH bpf-next] samples/bpf: fix kprobe attachment issue on x64

2018-04-29 Thread Alexei Starovoitov
On Sun, Apr 29, 2018 at 03:06:31PM -0700, Yonghong Song wrote: > Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename > struct pt_regs-based sys_*() to __x64_sys_*()") renamed a lot > of syscall function sys_*() to __x64_sys_*(). > This caused several kprobe based samples/bpf tests failing. >

[PATCH bpf-next] samples/bpf: fix kprobe attachment issue on x64

2018-04-29 Thread Yonghong Song
Commit d5a00528b58c ("syscalls/core, syscalls/x86: Rename struct pt_regs-based sys_*() to __x64_sys_*()") renamed a lot of syscall function sys_*() to __x64_sys_*(). This caused several kprobe based samples/bpf tests failing. This patch fixed the problem by using __x64_sys_*(), instead of sys_*(),

Re: Representing cpu-port of a switch

2018-04-29 Thread Florian Fainelli
On April 29, 2018 11:43:50 AM PDT, "sk.syed2" wrote: >Hi, > Sorry if this has been discussed elsewhere. The relevant discussion >is here: https://www.spinics.net/lists/netdev/msg407313.html. > But I have few questions in addition to those answered above. We >have simple 3-port switch, with two

[PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-29 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20

linux-next: Signed-off-by missing for commit in the net tree

2018-04-29 Thread Stephen Rothwell
Hi all, Commit 6082d9c9c94a ("net/mlx5: Fix mlx5_get_vector_affinity function") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgp_WA4LdP8dY.pgp Description: OpenPGP digital signature

Greetings

2018-04-29 Thread Zeliha Omer faruk
Hello Dear Greetings to you, please I have a very important business proposal for our mutual benefit, please let me know if you are interested please i asked you before. Best Regards, Miss. Zeliha ömer Faruk Caddesi Kristal Kule Binasi No:215

[PATCH] ipv6: remove min MTU check for tunnel destinations

2018-04-29 Thread Ashwanth Goli
With 749439bfac "fix udpv6 sendmsg crash caused by too small MTU" tunnel dst's that report a MTU less than IPV6_MIN_MTU are broken even for packets that are smaller than IPV6_MIN_MTU. According to rfc2473#section-7.1 if the original IPv6 packet is equal or smaller than the IPv6 minimum

Re: [PATCH net] MAINTAINERS: add myself as SCTP co-maintainer

2018-04-29 Thread Neil Horman
On Fri, Apr 27, 2018 at 04:46:11PM -0300, Marcelo Ricardo Leitner wrote: > Signed-off-by: Marcelo Ricardo Leitner > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index > 92be777d060a7df333a17d69e71bfd01760fa8f2..5bac32b545607933ea41fe9a56

Representing cpu-port of a switch

2018-04-29 Thread sk.syed2
Hi, Sorry if this has been discussed elsewhere. The relevant discussion is here: https://www.spinics.net/lists/netdev/msg407313.html. But I have few questions in addition to those answered above. We have simple 3-port switch, with two ports(connected via phys to external(front panel)) and one

[RFC v2 bpf-next 9/9] samples/bpf: Add examples of ipv4 and ipv6 forwarding in XDP

2018-04-29 Thread David Ahern
Signed-off-by: David Ahern --- samples/bpf/Makefile | 4 + samples/bpf/xdp_fwd_kern.c| 110 samples/bpf/xdp_fwd_user.c| 136 ++ tools/testing/selftests/bpf/bpf_helpers.h | 3 + 4 files ch

[RFC v2 bpf-next 1/9] net/ipv6: Rename fib6_lookup to fib6_node_lookup

2018-04-29 Thread David Ahern
Rename fib6_lookup to fib6_node_lookup to better reflect what it returns. The fib6_lookup name will be used in a later patch for an IPv6 equivalent to IPv4's fib_lookup. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 6 +++--- net/ipv6/ip6_fib.c| 14 -- net/ipv6/route.c

[RFC v2 bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

2018-04-29 Thread David Ahern
Provide a helper for doing a FIB and neighbor lookup in the kernel tables from an XDP program. The helper provides a fastpath for forwarding packets. If the packet is a local delivery or for any reason is not a simple lookup and forward, the packet continues up the stack. If it is to be forwarded,

[RFC v2 bpf-next 4/9] net/ipv6: Refactor fib6_rule_action

2018-04-29 Thread David Ahern
Move source address lookup from fib6_rule_action to a helper. It will be used in a later patch by a second variant for fib6_rule_action. Signed-off-by: David Ahern --- net/ipv6/fib6_rules.c | 52 ++- 1 file changed, 31 insertions(+), 21 deletions(-

[RFC v2 bpf-next 3/9] net/ipv6: Extract table lookup from ip6_pol_route

2018-04-29 Thread David Ahern
ip6_pol_route is used for ingress and egress FIB lookups. Refactor it moving the table lookup into a separate fib6_table_lookup that can be invoked separately and export the new function. ip6_pol_route now calls fib6_table_lookup and uses the result to generate a dst based rt6_info. Signed-off-by

[RFC v2 bpf-next 2/9] net/ipv6: Rename rt6_multipath_select

2018-04-29 Thread David Ahern
Rename rt6_multipath_select to fib6_multipath_select and export it. A later patch wants access to it similar to IPv4's fib_select_path. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 5 + net/ipv6/route.c | 17 + 2 files changed, 14 insertions(+), 8 deletions(-)

[RFC v2 bpf-next 7/9] net/ipv6: Add fib lookup stubs for use in bpf helper

2018-04-29 Thread David Ahern
Add stubs to retrieve a handle to an IPv6 FIB table, fib6_get_table, a stub to do a lookup in a specific table, fib6_table_lookup, and a stub for a full route lookup. The stubs are needed for core bpf code to handle the case when the IPv6 module is not builtin. Signed-off-by: David Ahern --- in

[RFC v2 bpf-next 0/9] bpf: Add helper to do FIB lookups

2018-04-29 Thread David Ahern
Provide a helper for doing a FIB and neighbor lookups in the kernel tables from an XDP program. The helper provides a fastpath for forwarding packets. If the packet is a local delivery or for any reason is not a simple lookup and forward, the packet is expected to continue up the stack for full pro

[RFC v2 bpf-next 5/9] net/ipv6: Add fib6_lookup

2018-04-29 Thread David Ahern
Add IPv6 equivalent to fib_lookup. Does a fib lookup, including rules, but returns a FIB entry, fib6_info, rather than a dst based rt6_info. fib6_lookup is on the order of 40% faster than any of the dst based lookup methods without custom rules and 25% faster with custom rules. Since the lookup fu

[RFC v2 bpf-next 6/9] net/ipv6: Update fib6 tracepoint to take fib6_info

2018-04-29 Thread David Ahern
Similar to IPv4, IPv6 should use the FIB lookup result in the tracepoint. Signed-off-by: David Ahern --- include/trace/events/fib6.h | 14 +++--- net/ipv6/route.c| 14 ++ 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/include/trace/events/fib6.h

[PATCH net] ipv6: fix uninit-value in ip6_multipath_l3_keys()

2018-04-29 Thread Eric Dumazet
syzbot/KMSAN reported an uninit-value in ip6_multipath_l3_keys(), root caused to a bad assumption of ICMP header being already pulled in skb->head ip_multipath_l3_keys() does the correct thing, so it is an IPv6 only bug. BUG: KMSAN: uninit-value in ip6_multipath_l3_keys net/ipv6/route.c:1830 [inl

Re: [PATCH bpf-next v3 2/4] bpf: sockmap, add hash map support

2018-04-29 Thread John Fastabend
On 04/29/2018 09:16 AM, Alexei Starovoitov wrote: > On Sat, Apr 28, 2018 at 08:41:28PM -0700, John Fastabend wrote: >> Sockmap is currently backed by an array and enforces keys to be >> four bytes. This works well for many use cases and was originally >> modeled after devmap which also uses four by

INFO: rcu detected stall in skb_free_head

2018-04-29 Thread syzbot
Hello, syzbot hit the following crash on upstream commit a27fc14219f2e3c4a46ba9177b04d9b52c875532 (Mon Apr 16 21:07:39 2018 +) Merge branch 'parisc-4.17-3' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=c

[PATCH net-next 2/2] sctp: add sctp_make_op_error_limited and reuse inner functions

2018-04-29 Thread Marcelo Ricardo Leitner
The idea is quite similar to the old functions, but note that the _fixed function wasn't "fixed" as in that it would generate a packet with a fixed size, but rather limited/bounded to PMTU. Also, now with sctp_mtu_payload(), we have a more accurate limit. Signed-off-by: Marcelo Ricardo Leitner -

[PATCH net-next 1/2] sctp: allow sctp_init_cause to return errors

2018-04-29 Thread Marcelo Ricardo Leitner
And do so if the skb doesn't have enough space for the payload. This is a preparation for the next patch. Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/sm.h| 2 +- net/sctp/sm_make_chunk.c | 12 +--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/inclu

[PATCH net-next 0/2] sctp: unify sctp_make_op_error_fixed and sctp_make_op_error_space

2018-04-29 Thread Marcelo Ricardo Leitner
These two variants are very close to each other and can be merged to avoid code duplication. That's what this patchset does. First, we allow sctp_init_cause to return errors, which then allow us to add sctp_make_op_error_limited that handles both situations. Marcelo Ricardo Leitner (2): sctp: a

KMSAN: uninit-value in _decode_session4

2018-04-29 Thread syzbot
Hello, syzbot hit the following crash on https://github.com/google/kmsan.git/master commit d2d741e5d1898dfde1a75ea3d29a9a3e2edf0617 (Sun Apr 22 15:05:22 2018 +) kmsan: add initialization for shmem pages syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=e7fec512bc2eb4ae0781

WARNING: ODEBUG bug in __sk_destruct

2018-04-29 Thread syzbot
Hello, syzbot hit the following crash on net-next commit af201bab50a89aa6cf4df952b2c3bf55895c8eee (Fri Apr 27 15:12:10 2018 +) udp: remove stray export symbol syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=92209502e7aab127c75f So far this crash happened 5 times on net-next

Re: [PATCH bpf-next v2] bpf: Allow bpf_current_task_under_cgroup in interrupt

2018-04-29 Thread Alexei Starovoitov
On Sat, Apr 28, 2018 at 11:39:29PM -0700, Teng Qin wrote: > Currently, the bpf_current_task_under_cgroup helper has a check where if > the BPF program is running in_interrupt(), it will return -EINVAL. This > prevents the helper to be used in many useful scenarios, particularly > BPF programs attac

Re: [PATCH bpf-next v3 2/4] bpf: sockmap, add hash map support

2018-04-29 Thread Alexei Starovoitov
On Sat, Apr 28, 2018 at 08:41:28PM -0700, John Fastabend wrote: > Sockmap is currently backed by an array and enforces keys to be > four bytes. This works well for many use cases and was originally > modeled after devmap which also uses four bytes keys. However, > this has become limiting in larger

WARNING: ODEBUG bug in del_timer

2018-04-29 Thread syzbot
Hello, syzbot hit the following crash on net-next commit af201bab50a89aa6cf4df952b2c3bf55895c8eee (Fri Apr 27 15:12:10 2018 +) udp: remove stray export symbol syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=03faa2dc16b8b64be396 So far this crash happened 26 times on net-nex

Re: [PATCH bpf-next 0/2] Fix BPF helpers documentation

2018-04-29 Thread Alexei Starovoitov
On Sun, Apr 29, 2018 at 10:49:40AM +0100, Quentin Monnet wrote: > On 29 April 2018 at 00:06, Andrey Ignatov wrote: > > BPF helpers documentation in UAPI refers to kernel ctx structures when it > > has to refer to user visible ones. Fix it. > > > > Andrey Ignatov (2): > > bpf: Fix helpers ctx str

Re: [PATCH bpf-next v9 00/10] bpf: add bpf_get_stack helper

2018-04-29 Thread Alexei Starovoitov
On Sat, Apr 28, 2018 at 10:28:06PM -0700, Yonghong Song wrote: > Currently, stackmap and bpf_get_stackid helper are provided > for bpf program to get the stack trace. This approach has > a limitation though. If two stack traces have the same hash, > only one will get stored in the stackmap table re

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-29 Thread Jiri Pirko
Sun, Apr 29, 2018 at 10:56:30AM CEST, losewe...@gmail.com wrote: >On Sat, Apr 28, 2018 at 2:42 AM, Jiri Pirko wrote: >> Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: >>>This patch enables virtio_net to switch over to a VF datapath when a VF >>>netdev is present with the

[PATCH v5] bpf, x86_32: add eBPF JIT compiler for ia32

2018-04-29 Thread Wang YanQing
The JIT compiler emits ia32 bit instructions. Currently, It supports eBPF only. Classic BPF is supported because of the conversion by BPF core. Almost all instructions from eBPF ISA supported except the following: BPF_ALU64 | BPF_DIV | BPF_K BPF_ALU64 | BPF_DIV | BPF_X BPF_ALU64 | BPF_MOD | BPF_K

Re: [llc_ui_release] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004

2018-04-29 Thread Fengguang Wu
On Sun, Apr 29, 2018 at 03:30:48AM +, Linus Torvalds wrote: On Sat, Apr 28, 2018 at 7:12 PM Fengguang Wu wrote: FYI this happens in mainline kernel 4.17.0-rc2. It looks like a new regression. It occurs in 5 out of 5 boots. [main] 375 sockets created based on info from socket cachefil

[PATCH net-next 1/2 v5] uevent: add alloc_uevent_skb() helper

2018-04-29 Thread Christian Brauner
This patch adds alloc_uevent_skb() in preparation for follow up patches. Signed-off-by: Christian Brauner --- v4->v5: * patch unchanged v3->v4: * non-functional changes: initialize some variables again explicitly to make it obvious to readers that they are correctly set v2->v3: * new approach

[PATCH net-next 0/2 v5] netns: uevent filtering

2018-04-29 Thread Christian Brauner
Hey everyone, This is the new approach to uevent filtering as discussed (see the threads in [1], [2], and [3]). It only contains *non-functional changes*. This series deals with with fixing up uevent filtering logic: - uevent filtering logic is simplified - locking time on uevent_sock_list is min

[PATCH net-next 2/2 v5] netns: restrict uevents

2018-04-29 Thread Christian Brauner
commit 07e98962fa77 ("kobject: Send hotplug events in all network namespaces") enabled sending hotplug events into all network namespaces back in 2010. Over time the set of uevents that get sent into all network namespaces has shrunk. We have now reached the point where hotplug events for all devi

Re: [PATCH net-next 2/2 v4] netns: restrict uevents

2018-04-29 Thread Christian Brauner
On Sat, Apr 28, 2018 at 11:23:58PM -0500, Eric W. Biederman wrote: > > > + /* fix credentials */ > > + if (owning_user_ns != &init_user_ns) { > > + struct netlink_skb_parms *parms = &NETLINK_CB(skb); > > + kuid_t root_uid; > > + kgid_t root_gid; > > + > > +

Re: [PATCH bpf-next 0/2] Fix BPF helpers documentation

2018-04-29 Thread Quentin Monnet
On 29 April 2018 at 00:06, Andrey Ignatov wrote: > BPF helpers documentation in UAPI refers to kernel ctx structures when it > has to refer to user visible ones. Fix it. > > Andrey Ignatov (2): > bpf: Fix helpers ctx struct types in uapi doc > bpf: Sync bpf.h to tools/ > > include/uapi/linux/

Re: [PATCH net-next v9 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-29 Thread Siwei Liu
On Sat, Apr 28, 2018 at 2:42 AM, Jiri Pirko wrote: > Fri, Apr 27, 2018 at 07:06:59PM CEST, sridhar.samudr...@intel.com wrote: >>This patch enables virtio_net to switch over to a VF datapath when a VF >>netdev is present with the same MAC address. It allows live migration >>of a VM with a direct at

Re: [PATCH V9 net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads

2018-04-29 Thread Sergei Shtylyov
Hello! On 4/29/2018 11:06 AM, Boris Pismenny wrote: From: Ilya Lesokhin With socket dependent offloads we rely on the netdev to transform the transmitted packets before sending them to the wire. When a packet from an offloaded socket is rerouted to a different device we need to detect it and

Re: [PATCH net-next v3 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

2018-04-29 Thread Nikolay Aleksandrov
On 29/04/18 10:56, Ido Schimmel wrote: From: Petr Machata When handling mirroring to a gretap or ip6gretap netdevice in mlxsw, the underlay address (i.e. the remote address of the tunnel) may be routed to a bridge. In that case, look up the resolved neighbor Ethernet address in that bridge's F

RE: [PATCH net-next] net: sch: prio: Set bands to default on delete instead of noop

2018-04-29 Thread Nogah Frankel
> > When a band is created, it is set to the default qdisc, which is > > "invisible" pfifo. > > However, if a band is set to a qdisc that is later being deleted, it will > > be set to noop qdisc. This can cause a packet loss, while there is no clear > > user indication for it. ("invisible" qdisc ar

Re: [PATCH net-next v3 1/6] net: bridge: Publish bridge accessor functions

2018-04-29 Thread Nikolay Aleksandrov
On 29/04/18 10:56, Ido Schimmel wrote: From: Petr Machata Add a couple new functions to allow querying FDB and vlan settings of a bridge. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- include/linux/if_bridge.h | 28 net/bridge/br_fdb.c | 22

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-29 Thread Dmitry Vyukov
On Fri, Apr 27, 2018 at 9:36 PM, Michael S. Tsirkin wrote: >> >> The struct vhost_msg within struct vhost_msg_node is copied to userspace, >> >> so it should be allocated with kzalloc() to ensure all structure padding >> >> is zeroed. >> >> >> >> Signed-off-by: Kevin Easton >> >> Reported-by: syz

[PATCH V9 net-next 07/14] net/tls: Add generic NIC offload infrastructure

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin This patch adds a generic infrastructure to offload TLS crypto to a network device. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path. Leaving those computationally expensive operations to the NIC. The NIC

[PATCH V9 net-next 14/14] MAINTAINERS: Update TLS maintainers

2018-04-29 Thread Boris Pismenny
Signed-off-by: Boris Pismenny Signed-off-by: Saeed Mahameed --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8f0fc25..4ee8bec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9839,7 +9839,7 @@ F:net/netfilter/xt_CONNSECMARK

[PATCH V9 net-next 09/14] net/mlx5: Accel, Add TLS tx offload interface

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin Add routines for manipulating TLS TX offload contexts. In Innova TLS, TLS contexts are added or deleted via a command message over the SBU connection. The HW then sends a response message over the same connection. Add implementation for Innova TLS (FPGA-based) hardware. The

[PATCH V9 net-next 06/14] net/tls: Split conf to rx + tx

2018-04-29 Thread Boris Pismenny
In TLS inline crypto, we can have one direction in software and another in hardware. Thus, we split the TLS configuration to separate structures for receive and transmit. Signed-off-by: Boris Pismenny --- include/net/tls.h | 51 +--- net/tls/tls_main.c | 103 +++

[PATCH V9 net-next 11/14] net/mlx5e: TLS, Add Innova TLS TX offload data path

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin Implement the TLS tx offload data path according to the requirements of the TLS generic NIC offload infrastructure. Special metadata ethertype is used to pass information to the hardware. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Acked-by: Saeed Mahameed

[PATCH V9 net-next 01/14] tcp: Add clean acked data hook

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the stream data. This is required by TLS device offload to release metadata associated with acknowledged TLS records. Signed-off-by: Ilya Lesokhin

[PATCH V9 net-next 02/14] net: Rename and export copy_skb_header

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin copy_skb_header is renamed to skb_copy_header and exported. Exposing this function give more flexibility in copying SKBs. skb_copy and skb_copy_expand do not give enough control over which parts are copied. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny --- inc

[PATCH V9 net-next 08/14] net/mlx5e: Move defines out of ipsec code

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin The defines are not IPSEC specific. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Acked-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +++ drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.h | 3 --- drivers/net/ethe

[PATCH V9 net-next 13/14] MAINTAINERS: Update mlx5 innova driver maintainers

2018-04-29 Thread Boris Pismenny
Signed-off-by: Boris Pismenny Signed-off-by: Saeed Mahameed --- MAINTAINERS | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a528008..8f0fc25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9037,26 +9037,17 @@ W: http://ww

[PATCH V9 net-next 04/14] net: Add TLS offload netdev ops

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin Add new netdev ops to add and delete tls context Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- include/linux/netdevice.h | 24 1 file changed, 24 insertions(+) diff --git a/include/linux/netdevice.h

[PATCH V9 net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin With socket dependent offloads we rely on the netdev to transform the transmitted packets before sending them to the wire. When a packet from an offloaded socket is rerouted to a different device we need to detect it and do the transformation in software. Signed-off-by: Ilya

[PATCH V9 net-next 05/14] net: Add TLS TX offload features

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin This patch adds a netdev feature to configure TLS TX offloads. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Signed-off-by: Aviad Yehezkel --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files changed, 3 insertions(+) dif

[PATCH V9 net-next 10/14] net/mlx5e: TLS, Add Innova TLS TX support

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin Add NETIF_F_HW_TLS_TX capability and expose tlsdev_ops to work with the TLS generic NIC offload infrastructure. The NETIF_F_HW_TLS_TX capability will be added in the next patch. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Acked-by: Saeed Mahameed --- driver

[PATCH V9 net-next 12/14] net/mlx5e: TLS, Add error statistics

2018-04-29 Thread Boris Pismenny
From: Ilya Lesokhin Add statistics for rare TLS related errors. Since the errors are rare we have a counter per netdev rather then per SQ. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny Acked-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- drive

[PATCH V9 net-next 00/14] TLS offload, netdev & MLX5 support

2018-04-29 Thread Boris Pismenny
Hi Dave, The following series provides TLS TX inline crypto offload. v1->v2: - Added IS_ENABLED(CONFIG_TLS_DEVICE) and a STATIC_KEY for icsk_clean_acked - File license fix - Fix spelling, comment by DaveW - Move memory allocations out of tls_set_device_offload and other misc fixes,

[PATCH net-next v3 3/6] mlxsw: spectrum_switchdev: Publish two functions

2018-04-29 Thread Ido Schimmel
From: Petr Machata Publish the existing function mlxsw_sp_bridge_port_find(), and add another service accessor mlxsw_sp_bridge_port_stp_state(). Publish both in a new file spectrum_switchdev.h. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- .../ethernet/mellanox/mlxsw/spectrum_sw

[PATCH net-next v3 6/6] mlxsw: spectrum_span: Allow bridge for gretap mirror

2018-04-29 Thread Ido Schimmel
From: Petr Machata When handling mirroring to a gretap or ip6gretap netdevice in mlxsw, the underlay address (i.e. the remote address of the tunnel) may be routed to a bridge. In that case, look up the resolved neighbor Ethernet address in that bridge's FDB. Then configure the offload to direct

[PATCH net-next v3 1/6] net: bridge: Publish bridge accessor functions

2018-04-29 Thread Ido Schimmel
From: Petr Machata Add a couple new functions to allow querying FDB and vlan settings of a bridge. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- include/linux/if_bridge.h | 28 net/bridge/br_fdb.c | 22 ++ net/bridge/br_priv

[PATCH net-next v3 4/6] mlxsw: spectrum: Register SPAN before switchdev

2018-04-29 Thread Ido Schimmel
From: Petr Machata Since switchdev events can trigger SPAN respin, it is necessary that the data structures are available. Register SPAN first, with a commentary on what the dependencies are. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spect

[PATCH net-next v3 5/6] mlxsw: Respin SPAN on switchdev events

2018-04-29 Thread Ido Schimmel
From: Petr Machata Changes to switchdev artifact can make a SPAN entry offloadable or unoffloadable. To that end: - Listen to SWITCHDEV_FDB_*_TO_BRIDGE notifications in addition to the *_TO_DEVICE ones, to catch whatever activity is sent to the bridge (likely by mlxsw itself). On each FDB

[PATCH net-next v3 0/6] mlxsw: SPAN: Support routes pointing at bridges

2018-04-29 Thread Ido Schimmel
Petr says: When mirroring to a gretap or ip6gretap netdevice, the route that directs the encapsulated packets can reference a bridge. In that case, in the software model, the packet is switched. Thus when offloading mirroring like that, take into consideration FDB, STP, PVID configured at the bri

[PATCH net-next v3 2/6] mlxsw: spectrum: Extract mlxsw_sp_stp_spms_state()

2018-04-29 Thread Ido Schimmel
From: Petr Machata Instead of duplicating the decision regarding port forwarding state made by mlxsw_sp_port_vid_stp_set(), extract the decision-making into a new function and reuse. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2

[PATCH] change the comment of vti6_ioctl

2018-04-29 Thread Sun Lianwen
The comment of vti6_ioctl() is wrong. which use vti6_tnl_ioctl instead of vti6_ioctl. Signed-off-by: Sun Lianwen --- net/ipv6/ip6_vti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c index c214ffec02f0..deadc4c3703b 100644 --- a/net/ip

  1   2   >