Re: [PATCH net-next v2 1/3] ipv4: support sport and dport in RTM_GETROUTE

Hi Roopa, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/fib-rule-selftest/20180507-094538 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig

Re: linux-next: manual merge of the tip tree with the bpf-next tree

Hi all, On Mon, 7 May 2018 12:09:09 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the tip tree got a conflict in: > > arch/x86/net/bpf_jit_comp.c > > between commit: > > e782bdcf58c5 ("bpf, x64: remove ld_abs/ld_ind") > > from the bpf-next tree and

Re: [RFC PATCH 3/3] arcnet: com20020: Add ethtool support

On Sat, May 05, 2018 at 11:35:29PM +0200, Andrea Greco wrote: > From: Andrea Greco > > Setup ethtols for export com20020 diag register > > Signed-off-by: Andrea Greco > --- > drivers/net/arcnet/com20020-isa.c| 1 + >

Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote: > From: Andrea Greco > > If com20020 clock is major of 40Mhz SLOWARB bit is requested. > > Signed-off-by: Andrea Greco > --- > drivers/net/arcnet/com20020.c | 4 > 1 file changed, 4

Re: [RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

On Sat, May 05, 2018 at 11:34:45PM +0200, Andrea Greco wrote: > From: Andrea Greco Hi Andrea, Here are some (mostly stylistic) suggestions to help you get your driver merged. > Add support for com20022I/com20020, memory mapped chip version. > Support bus: Intel 80xx and

[PATCH net] net/tls: Fix connection stall on partial tls record

In the case of writing a partial tls record we forgot to clear the ctx->in_tcp_sendpages flag, causing some connections to stall. Fixes: c212d2c7fc47 ("net/tls: Don't recursively call push_record during tls_write_space callbacks") Signed-off-by: Andre Tomt ---

linux-next: manual merge of the tip tree with the bpf-next tree

Hi all, Today's linux-next merge of the tip tree got a conflict in: arch/x86/net/bpf_jit_comp.c between commit: e782bdcf58c5 ("bpf, x64: remove ld_abs/ld_ind") from the bpf-next tree and commit: 5f26c50143f5 ("x86/bpf: Clean up non-standard comments, to make the code more readable")

Re: [PATCH 00/51] Netfilter/IPVS updates for net-next

From: Pablo Neira Ayuso Date: Mon, 7 May 2018 00:46:18 +0200 > > The following patchset contains Netfilter/IPVS updates for your net-next > tree, more relevant updates in this batch are: ... > You can pull these changes from: > >

Re: [PATCH net-next v2 2/3] ipv6: support sport and dport in RTM_GETROUTE

On 5/6/18 6:59 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This is a followup to fib6 rules sport and dport > match support. Having them supported in getroute > makes it easier to test fib6 rule lookups. Used by fib6 rule > self tests. > > Signed-off-by: Roopa

Re: [PATCH net-next v2 1/3] ipv4: support sport and dport in RTM_GETROUTE

On 5/6/18 6:59 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This is a followup to fib rules sport, dport match support. > Having them supported in getroute makes it easier to test > fib rule lookups. Used by fib rule self tests. Before this patch > getroute used

Re: [PATCH] isdn: eicon: fix a missing-check bug

Hello, I am just notice your subject line.There are missing something i think On Sat, May 05, 2018 at 02:32:46PM -0500, Wenwen Wang wrote: In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number

Re: [PATCH bpf-next v3 0/6] ipv6: sr: introduce seg6local End.BPF action

On Sun, May 06, 2018 at 06:27:28PM +0100, Mathieu Xhonneux wrote: > As of Linux 4.14, it is possible to define advanced local processing for > IPv6 packets with a Segment Routing Header through the seg6local LWT > infrastructure. This LWT implements the network programming principles > defined in

[PATCH net-next v2 2/3] ipv6: support sport and dport in RTM_GETROUTE

From: Roopa Prabhu This is a followup to fib6 rules sport and dport match support. Having them supported in getroute makes it easier to test fib6 rule lookups. Used by fib6 rule self tests. Signed-off-by: Roopa Prabhu --- net/ipv6/route.c

[PATCH net-next v2 3/3] selftests: net: initial fib rule tests

From: Roopa Prabhu This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action lookup table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by: Roopa

[PATCH net-next v2 1/3] ipv4: support sport and dport in RTM_GETROUTE

From: Roopa Prabhu This is a followup to fib rules sport, dport match support. Having them supported in getroute makes it easier to test fib rule lookups. Used by fib rule self tests. Before this patch getroute used same skb to pass through the route lookup and for the

[PATCH net-next v2 0/3] fib rule selftest

From: Roopa Prabhu This series adds a new test to test fib rules. ip route get is used to test fib rule matches. This series also extends ip route get to match on sport and dport to test recent support of sport and dport fib rule match. v2 - address ido's commemt to

RE: [RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

Hi Florian, > Well, the way the code is structure is that if you call that function > with a test mode value that is not part of the standard set, it returns > -EOPNOTSUPP, so if your particular PHY driver wants to "overlay" > standard and non-standard modes, it can by using that hint. > > This

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/syscall.c between commit: 9ef09e35e521 ("bpf: fix possible spectre-v1 in find_and_alloc_map()") from the net tree and commit: a26ca7c982cb ("bpf: btf: Add pretty print support to the basic arraymap")

Re: [PATCH bpf-next v3 3/6] bpf: Add IPv6 Segment Routing helpers

Hi Mathieu, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Mathieu-Xhonneux/ipv6-sr-introduce-seg6local-End-BPF-action/20180506-233046 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf

Re: [PATCH bpf-next v3 3/6] bpf: Add IPv6 Segment Routing helpers

Hi Mathieu, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Mathieu-Xhonneux/ipv6-sr-introduce-seg6local-End-BPF-action/20180506-233046 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf

[PATCH 03/51] netfilter: ipvs: Add Maglev hashing scheduler

From: Inju Song Implements the Google's Maglev hashing algorithm as a IPVS scheduler. Basically it provides consistent hashing but offers some special features about disruption and load balancing. 1) minimal disruption: when the set of destinations changes, a

[PATCH 00/51] Netfilter/IPVS updates for net-next

Hi David, The following patchset contains Netfilter/IPVS updates for your net-next tree, more relevant updates in this batch are: 1) Add Maglev support to IPVS. Moreover, store lastest server weight in IPVS since this is needed by maglev, patches from from Inju Song. 2) Preparation works to

[PATCH 10/51] netfilter: nf_flow_table: cache mtu in struct flow_offload_tuple

From: Felix Fietkau Reduces the number of cache lines touched in the offload forwarding path. This is safe because PMTU limits are bypassed for the forwarding path (see commit f87c10a8aa1e for more details). Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira

[PATCH 09/51] ipv6: make ip6_dst_mtu_forward inline

From: Felix Fietkau Just like ip_dst_mtu_maybe_forward(), to avoid a dependency with ipv6.ko. Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- include/net/ip6_route.h | 21 + include/net/ipv6.h | 2

[PATCH 04/51] netfilter: ipvs: Add configurations of Maglev hashing

From: Inju Song To build the maglev hashing scheduler, add some configuration to Kconfig and Makefile. - The compile configurations of MH are added to the Kconfig. - The MH build rule is added to the Makefile. Signed-off-by: Inju Song

[PATCH 08/51] netfilter: nf_flow_table: clean up flow_offload_alloc

From: Felix Fietkau Reduce code duplication and make it much easier to read Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_flow_table.c | 93 --- 1 file changed, 34

[PATCH 14/51] netfilter: nf_flow_table: move ipv6 offload hook code to nf_flow_table

From: Felix Fietkau Useful as preparation for adding iptables support for offload. Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/nf_flow_table_ipv6.c | 232

[PATCH 11/51] netfilter: nf_flow_table: rename nf_flow_table.c to nf_flow_table_core.c

From: Felix Fietkau Preparation for adding more code to the same module Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Makefile | 2 ++ net/netfilter/{nf_flow_table.c =>

[PATCH 13/51] netfilter: nf_flow_table: move ip header check out of nf_flow_exceeds_mtu

From: Felix Fietkau Allows the function to be shared with the IPv6 hook code Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_flow_table_ip.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 12/51] netfilter: nf_flow_table: move ipv4 offload hook code to nf_flow_table

From: Felix Fietkau Allows some minor code sharing with the ipv6 hook code and is also useful as preparation for adding iptables support for offload Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso ---

[PATCH 15/51] netfilter: nf_flow_table: relax mixed ipv4/ipv6 flowtable dependencies

From: Felix Fietkau Since the offload hook code was moved, this table no longer depends on the IPv4 and IPv6 flowtable modules Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Kconfig | 3 +-- 1 file changed, 1

[PATCH 06/51] netfilter: xt_NFLOG: use nf_log_packet instead of nfulnl_log_packet.

From: Taehee Yoo The nfulnl_log_packet() is added to make sure that the NFLOG target works as only user-space logger. but now, nf_log_packet() can find proper log function using NF_LOG_TYPE_ULOG and NF_LOG_TYPE_LOG. Signed-off-by: Taehee Yoo

[PATCH 17/51] netfilter: nf_flow_table: fix priv pointer for netdev hook

From: Felix Fietkau The offload ip hook expects a pointer to the flowtable, not to the rhashtable. Since the rhashtable is the first member, this is safe for the moment, but breaks as soon as the structure layout changes Signed-off-by: Felix Fietkau Signed-off-by:

[PATCH 21/51] netfilter: nf_flow_table: in flow_offload_lookup, skip entries being deleted

From: Felix Fietkau Preparation for sending flows back to the slow path Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_flow_table_core.c | 17 +++-- 1 file changed, 15 insertions(+), 2

[PATCH 16/51] netfilter: nf_flow_table: move init code to nf_flow_table_core.c

From: Felix Fietkau Reduces duplication of .gc and .params in flowtable type definitions and makes the API clearer Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_flow_table.h | 6 +-

[PATCH 26/51] netfilter: nf_tables: simplify lookup functions

Replace the nf_tables_ prefix by nft_ and merge code into single lookup function whenever possible. In many cases we go over the 80-chars boundary function names, this save us ~50 LoC. Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 12 +-

[PATCH 33/51] netfilter: x_tables: remove duplicate ip6t_get_target function call

From: Taehee Yoo In the check_target, ip6t_get_target is called twice. Signed-off-by: Taehee Yoo Signed-off-by: Pablo Neira Ayuso --- net/ipv6/netfilter/ip6_tables.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 29/51] netfilter: add NAT support for shifted portmap ranges

From: Thierry Du Tre This is a patch proposal to support shifted ranges in portmaps. (i.e. tcp/udp incoming port 5000-5100 on WAN redirected to LAN 192.168.1.5:2000-2100) Currently DNAT only works for single port or identical port ranges. (i.e. ports 5000-5100 on WAN

[PATCH 31/51] netfilter: ebtables: add ebt_free_table_info function

From: Taehee Yoo A ebt_free_table_info frees all of chainstacks. It similar to xt_free_table_info. this inline function reduces code line. Signed-off-by: Taehee Yoo Signed-off-by: Pablo Neira Ayuso ---

[PATCH 30/51] netfilter: add __exit mark to helper modules

From: Taehee Yoo There are no __exit mark in the helper modules. because these exit functions used to be called by init function but now that is not. so we can add __exit mark. Signed-off-by: Taehee Yoo Signed-off-by: Pablo Neira Ayuso

[PATCH 18/51] netfilter: nf_flow_table: track flow tables in nf_flow_table directly

From: Felix Fietkau Avoids having nf_flow_table depend on nftables (useful for future iptables backport work) Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_flow_table.h | 1 +

[PATCH 28/51] netfilter: nf_tables: Simplify set backend selection

From: Phil Sutter Drop nft_set_type's ability to act as a container of multiple backend implementations it chooses from. Instead consolidate the whole selection logic in nft_select_set_ops() and the actual backend provided estimate() callback. This turns nf_tables_set_types into a

[PATCH 32/51] netfilter: ebtables: remove EBT_MATCH and EBT_NOMATCH

From: Taehee Yoo EBT_MATCH and EBT_NOMATCH are used to change return value. match functions(ebt_xxx.c) return false when received frame is not matched and returns true when received frame is matched. but, EBT_MATCH_ITERATE understands oppositely. so, to change return value,

[PATCH 37/51] netfilter: nf_tables: always use an upper set size for dynsets

From: Florian Westphal nft rejects rules that lack a timeout and a size limit when they're used to add elements from packet path. Pick a sane upperlimit instead of rejecting outright. The upperlimit is visible to userspace, just as if it would have been given during set

[PATCH 36/51] netfilter: nf_tables: support timeouts larger than 23 days

From: Florian Westphal Marco De Benedetto says: I would like to use a timeout of 30 days for elements in a set but it seems there is a some kind of problem above 24d20h31m23s. Fix this by using 'jiffies64' for timeout handling to get same behaviour on 32 and 64bit systems.

[PATCH 35/51] netfilter: xtables: use ipt_get_target_c instead of ipt_get_target

From: Taehee Yoo ipt_get_target is used to get struct xt_entry_target and ipt_get_target_c is used to get const struct xt_entry_target. However in the ipt_do_table, ipt_get_target is used to get const struct xt_entry_target. it should be replaced by ipt_get_target_c.

[PATCH 40/51] netfilter: nf_tables: merge rt expression into nft core

From: Florian Westphal before: textdata bss dec hex filename 2657 844 03501 dad net/netfilter/nft_rt.ko 1008262240 401 103467 1942b net/netfilter/nf_tables.ko after: 2657 844 03501 dad

[PATCH 42/51] ipvs: initialize tbl->entries after allocation

From: Cong Wang tbl->entries is not initialized after kmalloc(), therefore causes an uninit-value warning in ip_vs_lblc_check_expire() as reported by syzbot. Reported-by: Cc: Simon Horman Cc:

[PATCH 34/51] netfilter: ebtables: add ebt_get_target and ebt_get_target_c

From: Taehee Yoo ebt_get_target similar to {ip/ip6/arp}t_get_target. and ebt_get_target_c similar to {ip/ip6/arp}t_get_target_c. Signed-off-by: Taehee Yoo Signed-off-by: Pablo Neira Ayuso ---

[PATCH 39/51] netfilter: nf_tables: make meta expression builtin

From: Florian Westphal size net/netfilter/nft_meta.ko textdata bss dec hex filename 5826 936 167631a6b net/netfilter/nft_meta.ko 964072064 400 98871 18237 net/netfilter/nf_tables.ko after: 1008262240 401 103467

[PATCH 41/51] netfilter: nf_tables: merge exthdr expression into nft core

From: Florian Westphal before: textdata bss dec hex filename 5056 844 05900170c net/netfilter/nft_exthdr.ko 1024562316 401 105173 19ad5 net/netfilter/nf_tables.ko after: 1064102392 401 109203 1aa93

[PATCH 38/51] netfilter: merge meta_bridge into nft_meta

From: Florian Westphal It overcomplicates things for no reason. nft_meta_bridge only offers retrieval of bridge port interface name. Because of this being its own module, we had to export all nft_meta functions, which we can then make static again (which even reduces the size of

[PATCH 24/51] netfilter: nf_flow_table: add missing condition for TCP state check

From: Felix Fietkau Avoid looking at unrelated fields in UDP packets Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_flow_table_ip.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

[PATCH 46/51] netfilter: ip6t_srh: extend SRH matching for previous, next and last SID

From: Ahmed Abdelsalam IPv6 Segment Routing Header (SRH) contains a list of SIDs to be crossed by SR encapsulated packet. Each SID is encoded as an IPv6 prefix. When a Firewall receives an SR encapsulated packet, it should be able to identify which node previously processed

[PATCH 50/51] netfilter: ctnetlink: export nf_conntrack_max

From: Florent Fourcot IPCTNL_MSG_CT_GET_STATS netlink command allow to monitor current number of conntrack entries. However, if one wants to compare it with the maximum (and detect exhaustion), the only solution is currently to read sysctl value. This patch add

[PATCH 43/51] ipvs: initialize tbl->entries in ip_vs_lblc_init_svc()

From: Cong Wang Similarly, tbl->entries is not initialized after kmalloc(), therefore causes an uninit-value warning in ip_vs_lblc_check_expire(), as reported by syzbot. Reported-by: Cc: Simon Horman

[PATCH 47/51] netfilter: nf_nat: remove unused ct arg from lookup functions

From: Florian Westphal Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_nat_l3proto.h | 24 net/ipv4/netfilter/iptable_nat.c | 3 +--

[PATCH 48/51] netfilter: nf_tables: Provide NFT_{RT,CT}_MAX for userspace

From: Phil Sutter These macros allow conveniently declaring arrays which use NFT_{RT,CT}_* values as indexes. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/nf_tables.h | 4 1 file changed, 4

[PATCH 51/51] netfilter: nft_dynset: fix timeout updates on 32bit

From: Florian Westphal This must now use a 64bit jiffies value, else we set a bogus timeout on 32bit. Fixes: 8e1102d5a1596 ("netfilter: nf_tables: support timeouts larger than 23 days") Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso

[PATCH 49/51] netfilter: extract Passive OS fingerprint infrastructure from xt_osf

From: Fernando Fernandez Mancera Add nf_osf_ttl() and nf_osf_match() into nf_osf.c to prepare for nf_tables support. Signed-off-by: Fernando Fernandez Mancera Signed-off-by: Pablo Neira Ayuso ---

[PATCH 44/51] netfilter: nft_numgen: add map lookups for numgen statements

From: Laura Garcia Liebana This patch includes a new attribute in the numgen structure to allow the lookup of an element based on the number generator as a key. For this purpose, different ops have been included to extend the current numgen inc functions. Currently, only

[PATCH 27/51] netfilter: nf_tables: initial support for extended ACK reporting

Keep it simple to start with, just report attribute offsets that can be useful to userspace when representating errors to users. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 299 +- 1 file changed, 206

[PATCH 45/51] netfilter: nft_numgen: enable hashing of one element

From: Laura Garcia Liebana The modulus in the hash function was limited to > 1 as initially there was no sense to create a hashing of just one element. Nevertheless, there are certain cases specially for load balancing where this case needs to be addressed. This patch fixes

[PATCH 19/51] netfilter: nf_flow_table: make flow_offload_dead inline

From: Felix Fietkau It is too trivial to keep as a separate exported function Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_flow_table.h | 5 - net/netfilter/nf_flow_table_core.c| 6 --

[PATCH 25/51] netfilter: nf_flow_table: fix offloading connections with SNAT+DNAT

From: Felix Fietkau Pass all NAT types to the flow offload struct, otherwise parts of the address/port pair do not get translated properly, causing connection stalls Signed-off-by: Felix Fietkau Signed-off-by: Pablo Neira Ayuso ---

[PATCH 23/51] netfilter: nf_flow_table: tear down TCP flows if RST or FIN was seen

From: Felix Fietkau Allow the slow path to handle the shutdown of the connection with proper timeouts. The packet containing RST/FIN is also sent to the slow path and the TCP conntrack module will update its state. Signed-off-by: Felix Fietkau Signed-off-by: Pablo

[PATCH 02/51] netfilter: ipvs: Keep latest weight of destination

From: Inju Song The hashing table in scheduler such as source hash or maglev hash should ignore the changed weight to 0 and allow changing the weight from/to non-0 values. So, struct ip_vs_dest needs to keep weight with latest non-0 weight. Signed-off-by: Inju Song

[PATCH 05/51] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms

From: Vincent Bernat The sh/dh/lblc/lblcr algorithms are using Knuth's multiplicative hashing incorrectly. Replace its use by the hash_32() macro, which correctly implements this algorithm. It doesn't use the same constant, but it shouldn't matter. Signed-off-by: Vincent

[PATCH 20/51] netfilter: nf_flow_table: add a new flow state for tearing down offloading

From: Felix Fietkau On cleanup, this will be treated differently from FLOW_OFFLOAD_DYING: If FLOW_OFFLOAD_DYING is set, the connection is going away, so both the offload state and the connection tracking entry will be deleted. If FLOW_OFFLOAD_TEARDOWN is set, the connection

[PATCH 22/51] netfilter: nf_flow_table: add support for sending flows back to the slow path

From: Felix Fietkau Since conntrack hasn't seen any packets from the offloaded flow in a while, and the timeout for offloaded flows is set to an extremely long value, we need to fix up the state before we can send a flow back to the slow path. For TCP, reset td_maxwin in both

[PATCH 01/51] netfilter: ipvs: Fix space before '[' error.

From: Arvind Yadav Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++-- 1 file

Re: [net-next PATCH v2 4/8] udp: Do not pass checksum as a parameter to GSO segmentation

On Sun, May 6, 2018 at 10:17 AM, Willem de Bruijn wrote: > On Sat, May 5, 2018 at 7:39 PM, Alexander Duyck > wrote: >> On Sat, May 5, 2018 at 3:01 AM, Willem de Bruijn >> wrote: >>> On Fri, May 4, 2018

Re: [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion.

On Sun, May 06 2018, Herbert Xu wrote: > On Sun, May 06, 2018 at 08:00:49AM +1000, NeilBrown wrote: >> >> The insert function must (and does) take the lock on the bucket before >> testing if there is a "next" table. >> If one inserter finds that it has locked the "last" table (because there >> is

Re: [PATCH 7/8] rhashtable: add rhashtable_walk_prev()

On Sat, May 05 2018, Tom Herbert wrote: > On Sat, May 5, 2018 at 2:43 AM, Herbert Xu > wrote: >> On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >>> rhashtable_walk_prev() returns the object returned by >>> the previous rhashtable_walk_next(), providing

Re: [net-next PATCH v2 6/8] udp: Add support for software checksum and GSO_PARTIAL with GSO offload

On Sun, May 6, 2018 at 2:50 PM, Willem de Bruijn wrote: > On Sat, May 5, 2018 at 3:31 AM, Alexander Duyck > wrote: >> From: Alexander Duyck >> >> This patch adds support for a software provided checksum and

Re: [PATCH 4/8] rhashtable: fix race in nested_table_alloc()

On Sun, May 06 2018, Herbert Xu wrote: > On Sun, May 06, 2018 at 07:48:20AM +1000, NeilBrown wrote: >> >> The spinlock protects 2 or more buckets. The nested table contains at >> least 512 buckets, maybe more. >> It is quite possible for two insertions into 2 different buckets to both >> get

Re: [net-next PATCH v2 6/8] udp: Add support for software checksum and GSO_PARTIAL with GSO offload

On Sat, May 5, 2018 at 3:31 AM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch adds support for a software provided checksum and GSO_PARTIAL > segmentation support. With this we can offload UDP segmentation on devices > that

Re: BUG?: receiving on a packet socket with .sll_protocoll and bridging

>> > If now I add veth0 to a bridge (e.g. >> > >> > ip link add br0 type bridge >> > ip link set dev veth0 master br0 >> > >> > ) and continue to send on veth1 and receive on veth0 I don't receive >> > the packets any more. The other direction (veth0 sending, veth1 >> > receiving)

Re: BUG?: receiving on a packet socket with .sll_protocoll and bridging

Hello Willem, On Sun, May 06, 2018 at 06:58:34PM +0200, Willem de Bruijn wrote: > On Sat, May 5, 2018 at 10:57 AM, Uwe Kleine-König > wrote: > > For testing purposes I created a veth device pair (veth0 veth1), open a > > socket for each of the devices and send

Re: simplify procfs code for seq_file instances V2

On Sun, May 06, 2018 at 08:19:49PM +0300, Alexey Dobriyan wrote: > +++ b/fs/proc/internal.h > @@ -48,8 +48,8 @@ struct proc_dir_entry { > const struct seq_operations *seq_ops; > int (*single_show)(struct seq_file *, void *); > }; > - unsigned int state_size; >

Re: [PATCH net-next 7/9] net: dsa: mv88e6xxx: add PHYLINK support

On May 6, 2018 10:26:37 AM PDT, Andrew Lunn wrote: >On Sat, May 05, 2018 at 12:04:23PM -0700, Florian Fainelli wrote: >> From: Russell King >> >> Add rudimentary phylink support to mv88e6xxx. This allows the driver >> using user ports with fixed links

INFO: task hung in tls_push_record

Hello, syzbot found the following crash on: HEAD commit:8fb11a9a8d51 net/ipv6: rename rt6_next to fib6_next git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=108e923780 kernel config: https://syzkaller.appspot.com/x/.config?x=c416c61f3cd96be dashboard

Re: [PATCH net-next 7/9] net: dsa: mv88e6xxx: add PHYLINK support

On Sat, May 05, 2018 at 12:04:23PM -0700, Florian Fainelli wrote: > From: Russell King > > Add rudimentary phylink support to mv88e6xxx. This allows the driver > using user ports with fixed links to keep operating normally. User ports > with normal PHYs are not

Re: simplify procfs code for seq_file instances V2

On Wed, Apr 25, 2018 at 05:47:47PM +0200, Christoph Hellwig wrote: > Changes since V1: > - open code proc_create_data to avoid setting not fully initialized >entries live > - use unsigned int for state_size Need this to maintain sizeof(struct proc_dir_entry): Otherwise ACK fs/proc/ part.

Re: [net-next PATCH v2 4/8] udp: Do not pass checksum as a parameter to GSO segmentation

On Sat, May 5, 2018 at 7:39 PM, Alexander Duyck wrote: > On Sat, May 5, 2018 at 3:01 AM, Willem de Bruijn > wrote: >> On Fri, May 4, 2018 at 8:30 PM, Alexander Duyck >> wrote: >>> From: Alexander Duyck

Re: BUG?: receiving on a packet socket with .sll_protocoll and bridging

On Sat, May 5, 2018 at 10:57 AM, Uwe Kleine-König wrote: > Hello, > > my eventual goal is to implement MRP and for that I started to program a > bit and stumbled over a problem I don't understand. > > For testing purposes I created a veth device pair (veth0 veth1),

Re: [RFC PATCH ghak32 V2 01/13] audit: add container id

On 2018-04-18 19:47, Paul Moore wrote: > On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > > Implement the proc fs write to set the audit container ID of a process, > > emitting an AUDIT_CONTAINER record to document the event. > > > > This is a write from the container

Re: Locking in network code

On Sun, May 6, 2018 at 6:43 AM, Jacob S. Moroni wrote: > Hello, > > I have a stupid question regarding which variant of spin_lock to use > throughout the network stack, and inside RX handlers specifically. > > It's my understanding that skbuffs are normally passed into the

[PATCH bpf-next v3 4/6] bpf: Split lwt inout verifier structures

The new bpf_lwt_push_encap helper should only be accessible within the LWT BPF IN hook, and not the OUT one, as this may lead to a skb under panic. At the moment, both LWT BPF IN and OUT share the same list of helpers, whose calls are authorized by the verifier. This patch separates the verifier

[PATCH bpf-next v3 1/6] ipv6: sr: make seg6.h includable without IPv6

include/net/seg6.h cannot be included in a source file if CONFIG_IPV6 is not enabled: include/net/seg6.h: In function 'seg6_pernet': >> include/net/seg6.h:52:14: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'? return

[PATCH bpf-next v3 2/6] ipv6: sr: export function lookup_nexthop

The function lookup_nexthop is essential to implement most of the seg6local actions. As we want to provide a BPF helper allowing to apply some of these actions on the packet being processed, the helper should be able to call this function, hence the need to make it public. Moreover, if one

[PATCH bpf-next v3 6/6] selftests/bpf: test for seg6local End.BPF action

Add a new test for the seg6local End.BPF action. The following helpers are also tested : - bpf_lwt_push_encap within the LWT BPF IN hook - bpf_lwt_seg6_action - bpf_lwt_seg6_adjust_srh - bpf_lwt_seg6_store_bytes A chain of End.BPF actions is built. The SRH is injected through a LWT BPF IN hook

[PATCH bpf-next v3 3/6] bpf: Add IPv6 Segment Routing helpers

The BPF seg6local hook should be powerful enough to enable users to implement most of the use-cases one could think of. After some thinking, we figured out that the following actions should be possible on a SRv6 packet, requiring 3 specific helpers : - bpf_lwt_seg6_store_bytes: Modify

[PATCH bpf-next v3 0/6] ipv6: sr: introduce seg6local End.BPF action

As of Linux 4.14, it is possible to define advanced local processing for IPv6 packets with a Segment Routing Header through the seg6local LWT infrastructure. This LWT implements the network programming principles defined in the IETF “SRv6 Network Programming” draft. The implemented operations are

[PATCH bpf-next v3 5/6] ipv6: sr: Add seg6local action End.BPF

This patch adds the End.BPF action to the LWT seg6local infrastructure. This action works like any other seg6local End action, meaning that an IPv6 header with SRH is needed, whose DA has to be equal to the SID of the action. It will also advance the SRH to the next segment, the BPF program does

Locking in network code

Hello, I have a stupid question regarding which variant of spin_lock to use throughout the network stack, and inside RX handlers specifically. It's my understanding that skbuffs are normally passed into the stack from soft IRQ context if the device is using NAPI, and hard IRQ context if it's not

[PATCH 8/9] net: flow_dissector: fix typo 'can by' to 'can be'

Signed-off-by: Wolfram Sang --- include/net/flow_dissector.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h index 9a074776f70b66..d1fcf2442a423b 100644 ---

[PATCH 0/9] tree-wide: fix typo 'can by' to 'can be'

I found this kind of typo when reading the documentation for device_remove(). So, I checked the tree for it. CCing all the subsystems directly, and I'd think the leftover ones could be picked up by the trivial tree. Or would it be more convenient if trivial would pick up all? I don't mind. Based

[PATCH] mwifiex: delete unneeded include

Nothing that is defined in 11ac.h is referenced in cmdevt.c. Signed-off-by: Julia Lawall --- drivers/net/wireless/marvell/mwifiex/cmdevt.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c

Re: [PATCH] net/mlx5: Fix mlx5_get_vector_affinity function

On Sun, 6 May 2018, Thomas Gleixner wrote: > On Sat, 5 May 2018, Guenter Roeck wrote: > > > -#ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK > > > - mask = irq_data_get_effective_affinity_mask(>irq_data); > > > -#else > > > - mask = desc->irq_common_data.affinity; > > > -#endif > > > - return mask; >

  1   2   >