Re: safe skb resetting after decapsulation and encapsulation

I'm not an expert on this, but it looks about right. You can take a look at build_skb() or __build_skb(). It shows the fields that needs to be set before passing to netif_receive_skb/netif_rx. On Fri, May 11, 2018 at 6:56 PM, Jason A. Donenfeld wrote: > Hey Netdev, > > A UDP skb

Re: [RFC bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

On 11 May 2018 at 14:41, Martin KaFai Lau wrote: > On Fri, May 11, 2018 at 02:08:01PM -0700, Joe Stringer wrote: >> On 10 May 2018 at 22:00, Martin KaFai Lau wrote: >> > On Wed, May 09, 2018 at 02:07:05PM -0700, Joe Stringer wrote: >> >> This patch adds a new BPF

Re: KASAN: null-ptr-deref Read in rds_ib_get_mr

On 2018/5/12 0:58, Santosh Shilimkar wrote: On 5/11/2018 12:48 AM, Yanjun Zhu wrote: On 2018/5/11 13:20, DaeRyong Jeong wrote: We report the crash: KASAN: null-ptr-deref Read in rds_ib_get_mr Note that this bug is previously reported by syzkaller.

Re: [GIT] Networking

On Fri, May 11, 2018 at 5:10 PM David Miller wrote: > I guess this is my reward for trying to break the monotony of > pull requests :-) I actually went back and checked a few older pull requests to see if this had been going on for a while and I just hadn't noticed. It

[PATCH bpf-next 2/4] samples: bpf: rename libbpf.h to bpf_insn.h

The libbpf.h file in samples is clashing with libbpf's header. Since it only includes a subset of filter.h instruction helpers rename it to bpf_insn.h. Drop the unnecessary include of bpf/bpf.h. Signed-off-by: Jakub Kicinski --- samples/bpf/{libbpf.h =>

[PATCH bpf-next 3/4] samples: bpf: fix build after move to compiling full libbpf.a

There are many ways users may compile samples, some of them got broken by commit 5f9380572b4b ("samples: bpf: compile and link against full libbpf"). Improve path resolution and make libbpf building a dependency of source files to force its build. Samples should now again build with any of: cd

[PATCH bpf-next 4/4] samples: bpf: move libbpf from object dependencies to libs

Make complains that it doesn't know how to make libbpf.a: scripts/Makefile.host:106: target 'samples/bpf/../../tools/lib/bpf/libbpf.a' doesn't match the target pattern Now that we have it as a dependency of the sources simply add libbpf.a to libraries not objects. Signed-off-by: Jakub Kicinski

[PATCH bpf-next 0/4] samples: bpf: fix build after move to full libbpf

Hi! Following patches address build issues after recent move to libbpf. For out-of-tree builds we would see the following error: gcc: error: samples/bpf/../../tools/lib/bpf/libbpf.a: No such file or directory Mini-library called libbpf.h in samples is renamed to bpf_insn.h, using linux/filter.h

[PATCH bpf-next 1/4] samples: bpf: include bpf/bpf.h instead of local libbpf.h

There are two files in the tree called libbpf.h which is becoming problematic. Most samples don't actually need the local libbpf.h they simply include it to get to bpf/bpf.h. Include bpf/bpf.h directly instead. Signed-off-by: Jakub Kicinski ---

Re: [GIT] Networking

From: Linus Torvalds Date: Fri, 11 May 2018 14:25:59 -0700 > David, is there something you want to tell us? > > Drugs are bad, m'kay.. I guess this is my reward for trying to break the monotony of pull requests :-)

Re: [PATCH net] net: dsa: bcm_sf2: Fix RX_CLS_LOC_ANY overwrite for last rule

From: Florian Fainelli Date: Fri, 11 May 2018 16:38:02 -0700 > David, please discard that for now, the IPv4 part is correct, but I am > not fixing the bug correctly for the IPv6 part. v2 coming some time next > week. Thank you! Ok.

Re: [PATCH net] net: dsa: bcm_sf2: Fix RX_CLS_LOC_ANY overwrite for last rule

On 05/11/2018 04:24 PM, Florian Fainelli wrote: > When we let the kernel pick up a rule location with RX_CLS_LOC_ANY, we > would be able to overwrite the last rules because of a number of issues: > > - the IPv4 code path would not be checking that rule_index is within > bounds, the IPv6 code

Proposal

-- Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

[PATCH net-next 0/3] sctp: Introduce sctp_flush_ctx

This struct will hold all the context used during the outq flush, so we don't have to pass lots of pointers all around. Checked on x86_64, the compiler inlines all these functions and there is no derreference added because of the struct. Marcelo Ricardo Leitner (3): sctp: add sctp_flush_ctx, a

[PATCH net-next 3/3] sctp: checkpatch fixups

A collection of fixups from previous patches, left for later to not introduce unnecessary changes while moving code around. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff

[PATCH net-next 2/3] sctp: add asoc and packet to sctp_flush_ctx

Pre-compute these so the compiler won't reload them (due to no-strict-aliasing). Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 99 - 1 file changed, 45 insertions(+), 54 deletions(-) diff --git

[PATCH net-next 1/3] sctp: add sctp_flush_ctx, a context struct on outq_flush routines

With this struct we avoid passing lots of variables around and taking care of updating the current transport/packet. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 182 +--- 1 file changed, 88

[PATCH net] net: dsa: bcm_sf2: Fix RX_CLS_LOC_ANY overwrite for last rule

When we let the kernel pick up a rule location with RX_CLS_LOC_ANY, we would be able to overwrite the last rules because of a number of issues: - the IPv4 code path would not be checking that rule_index is within bounds, the IPv6 code path would only be checking the second index and not the

[PATCH net-next 8/8] sctp: rework switch cases in sctp_outq_flush_data

Remove an inner one, which tended to be error prone due to the cascading and it can be replaced by a simple if (). Rework the outer one so that the actual flush code is not inside it. Now we first validate if we can or cannot send data, return if not, and then the flush code. Suggested-by: Xin

[PATCH net-next 5/8] sctp: move flushing of data chunks out of sctp_outq_flush

To the new sctp_outq_flush_data. Again, smaller functions and with well defined objectives. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 144 ++-- 1 file changed, 73 insertions(+), 71 deletions(-)

[PATCH net-next 2/8] sctp: factor out sctp_outq_select_transport

We had two spots doing such complex operation and they were very close to each other, a bit more tailored to here or there. This patch unifies these under the same function, sctp_outq_select_transport, which knows how to handle control chunks and original transmissions (but not retransmissions).

[PATCH net-next 4/8] sctp: move outq data rtx code out of sctp_outq_flush

This patch renames current sctp_outq_flush_rtx to __sctp_outq_flush_rtx and create a new sctp_outq_flush_rtx, with the code that was on sctp_outq_flush. Again, the idea is to have functions with small and defined objectives. Yes, there is an open-coded path selection in the now

[PATCH net-next 3/8] sctp: move the flush of ctrl chunks into its own function

Named sctp_outq_flush_ctrl and, with that, keep the contexts contained. One small fix embedded is the reset of one_packet at every iteration. This allows bundling of some control chunks in case they were preceded by another control chunk that cannot be bundled. Other than this, it has the same

[PATCH net-next 6/8] sctp: move transport flush code out of sctp_outq_flush

To the new sctp_outq_flush_transports. Comment on Nagle is outdated and removed. Nagle is performed earlier, while checking if the chunk fits the packet: if the outq length is not enough to fill the packet, it returns SCTP_XMIT_DELAY. So by when it gets to sctp_outq_flush_transports, it has to

[PATCH net-next 7/8] sctp: make use of gfp on retransmissions

Retransmissions may be triggered when in user context, so lets make use of gfp. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/sctp/outqueue.c

[PATCH net-next 1/8] sctp: add sctp_packet_singleton

Factor out the code for generating singletons. It's used only once, but helps to keep the context contained. The const variables are to ease the reading of subsequent calls in there. Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/outqueue.c | 22

[PATCH net-next 0/8] sctp: refactor sctp_outq_flush

Currently sctp_outq_flush does many different things and arguably unrelated, such as doing transport selection and outq dequeueing. This patchset refactors it into smaller and more dedicated functions. The end behavior should be the same. The next patchset will rework the function parameters.

Re: [PATCH net-next] udp: Fix kernel panic in UDP GSO path

On Thu, May 10, 2018 at 8:51 PM, Eric Dumazet wrote: > > > On 05/10/2018 05:38 PM, Sean Tranchetti wrote: >> Using GSO in the UDP path on a device with >> scatter-gather netdevice feature disabled will result in a kernel >> panic with the following call stack: >> >> This

safe skb resetting after decapsulation and encapsulation

Hey Netdev, A UDP skb comes in via the encap_rcv interface. I do a lot of wild things to the bytes in the skb -- change where the head starts, modify a few fragments, decrypt some stuff, trim off some things at the end, etc. In other words, I'm decapsulating the skb in a pretty intense way. I

Re: [PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask()

Hi Andrew, On Fri, May 11, 2018 at 09:24:46PM +0200, Andrew Lunn wrote: > > I could reorder the probe function a little to initialize the PHY before > > performing the MAC reset, drop this patch and the AR803X hibernation > > stuff from patch 2 if you like. But again, I can't actually test the >

Re: [PATCH ghak81 RFC V1 1/5] audit: normalize loginuid read access

On 2018-05-10 17:21, Richard Guy Briggs wrote: > On 2018-05-09 11:13, Paul Moore wrote: > > On Fri, May 4, 2018 at 4:54 PM, Richard Guy Briggs wrote: > > > Recognizing that the loginuid is an internal audit value, use an access > > > function to retrieve the audit loginuid value

Re: [PATCH net-next 4/4] bonding: allow carrier and link status to determine link state

Debabrata Banerjee wrote: >In a mixed environment it may be difficult to tell if your hardware >support carrier, if it does not it can always report true. With a new >use_carrier option of 2, we can check both carrier and link status >sequentially, instead of one or the

Re: [PATCH net] macmace: Set platform device coherent_dma_mask

Hi Finn, Am 11.05.2018 um 22:06 schrieb Finn Thain: >> You would have to be careful not to overwrite a pdev->dev.dma_mask and >> pdev->dev.dma_coherent_mask that might have been set in a platform >> device passed via platform_device_register here. Coldfire is the only >> m68k platform

Re: [PATCH net-next 3/4] bonding: allow use of tx hashing in balance-alb

Debabrata Banerjee wrote: >The rx load balancing provided by balance-alb is not mutually >exclusive with using hashing for tx selection, and should provide a decent >speed increase because this eliminates spinlocks and cache contention. > >Signed-off-by: Debabrata Banerjee

Re: [PATCH net v2] rps: Correct wrong skb_flow_limit check when enable RPS

On Thu, May 10, 2018 at 6:09 PM, wrote: > From: Gao Feng > > The skb flow limit is implemented for each CPU independently. In the > current codes, the function skb_flow_limit gets the softnet_data by > this_cpu_ptr. But the target cpu of

Re: [PATCH bpf-next 3/7] samples: bpf: compile and link against full libbpf

On Thu, 10 May 2018 10:24:39 -0700, Jakub Kicinski wrote: > samples/bpf currently cherry-picks object files from tools/lib/bpf > to link against. Just compile the full library and link statically > against it. > > Signed-off-by: Jakub Kicinski > Reviewed-by:

Re: [RFC bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

On Fri, May 11, 2018 at 02:08:01PM -0700, Joe Stringer wrote: > On 10 May 2018 at 22:00, Martin KaFai Lau wrote: > > On Wed, May 09, 2018 at 02:07:05PM -0700, Joe Stringer wrote: > >> This patch adds a new BPF helper function, sk_lookup() which allows BPF > >> programs to find out

Re: [PATCH net-next 2/4] bonding: use common mac addr checks

Banerjee, Debabrata wrote: >> From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >> Debabrata Banerjee wrote: > >> >- if >> (!ether_addr_equal_64bits(rx_hash_table[index].mac_dst, >> >-

Re: [GIT] Networking

David, is there something you want to tell us? Drugs are bad, m'kay.. Linus On Fri, May 11, 2018 at 2:00 PM David Miller wrote: > "from Kevin Easton", "Thanks to Bhadram Varka", "courtesy of Gustavo A. > R. Silva", "To Eric Dumazet we are most grateful for

RE: [PATCH net-next 2/4] bonding: use common mac addr checks

> From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] > Debabrata Banerjee wrote: > >-if > (!ether_addr_equal_64bits(rx_hash_table[index].mac_dst, > >- mac_bcast) && > >- >

[PATCH net-next 2/3] net: dsa: mv88e6xxx: add IEEE and IP mapping ops

All Marvell switch families except 88E6390 have direct registers in Global 1 for IEEE and IP priorities override mapping. The 88E6390 uses indirect tables instead. Add .ieee_pri_map and .ip_pri_map ops to distinct that and call them from a mv88e6xxx_pri_setup helper. Only non-6390 are concerned

[PATCH net-next 0/3] net: dsa: mv88e6xxx: remove Global 1 setup

The mv88e6xxx driver is still writing arbitrary registers at setup time, e.g. priority override bits. Add ops for them and provide specific setup functions for priority and stats before getting rid of the erroneous mv88e6xxx_g1_setup code, as previously done with Global 2. Vivien Didelot (3):

[PATCH net-next 1/3] net: dsa: mv88e6xxx: use helper for 6390 histogram

The Marvell 88E6390 model has its histogram mode bits moved in the Global 1 Control 2 register. Use the previously introduced mv88e6xxx_g1_ctl2_mask helper to set them. At the same time complete the documentation of the said register. Signed-off-by: Vivien Didelot

[PATCH net-next 3/3] net: dsa: mv88e6xxx: add a stats setup function

Now that the Global 1 specific setup function only setup the statistics unit, kill it in favor of a mv88e6xxx_stats_setup function. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 27 ++- 1 file changed, 10

Re: [bpf-next V2 PATCH 4/4] xdp: change ndo_xdp_xmit API to support bulking

On Fri, 11 May 2018 20:12:12 +0200 Jesper Dangaard Brouer wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 03ed492c4e14..debdb6286170 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1185,9 +1185,13 @@ struct

Re: [RFC bpf-next 07/11] bpf: Add helper to retrieve socket in BPF

On 10 May 2018 at 22:00, Martin KaFai Lau wrote: > On Wed, May 09, 2018 at 02:07:05PM -0700, Joe Stringer wrote: >> This patch adds a new BPF helper function, sk_lookup() which allows BPF >> programs to find out if there is a socket listening on this host, and >> returns a socket

[GIT] Networking

1) Verify lengths of keys provided by the user is AF_KEY, from Kevin Easton. 2) Add device ID for BCM89610 PHY. Thanks to Bhadram Varka. 3) Add Spectre guards to some ATM code, courtesy of Gustavo A. R. Silva. 4) Fix infinite loop in NSH protocol code. To Eric Dumazet we are most

Re: [PATCH net-next 2/4] bonding: use common mac addr checks

Debabrata Banerjee wrote: >Replace homegrown mac addr checks with faster defs from etherdevice.h > >Signed-off-by: Debabrata Banerjee >--- > drivers/net/bonding/bond_alb.c | 28 +--- > 1 file changed, 9 insertions(+), 19

Re: INFO: rcu detected stall in kfree_skbmem

On Fri, May 11, 2018 at 12:08:33PM -0700, Eric Dumazet wrote: > > > On 05/11/2018 11:41 AM, Marcelo Ricardo Leitner wrote: > > > But calling ip6_xmit with rcu_read_lock is expected. tcp stack also > > does it. > > Thus I think this is more of an issue with IPv6 stack. If a host has > > an

Re: [PATCH net 1/1] net sched actions: fix refcnt leak in skbmod

From: Roman Mashak Date: Fri, 11 May 2018 14:35:33 -0400 > When application fails to pass flags in netlink TLV when replacing > existing skbmod action, the kernel will leak refcnt: > > $ tc actions get action skbmod index 1 > total acts 0 > > action order 0: skbmod

Re: [PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy

From: Dan Murphy Date: Fri, 11 May 2018 13:08:19 -0500 > Add support for the DP83811 phy. > > The DP83811 supports both rgmii and sgmii interfaces. > There are 2 part numbers for this the DP83TC811R does not > reliably support the SGMII interface but the DP83TC811S will. > >

Re: [patch net] net: sched: fix error path in tcf_proto_create() when modules are not configured

From: Jiri Pirko Date: Fri, 11 May 2018 17:45:32 +0200 > From: Jiri Pirko > > In case modules are not configured, error out when tp->ops is null > and prevent later null pointer dereference. > > Fixes: 33a48927c193 ("sched: push TC filter protocol creation

Re: [PATCH net-next 1/3] cxgb4: Fix {vxlan/geneve}_port initialization

From: Ganesh Goudar Date: Fri, 11 May 2018 18:34:43 +0530 > From: Arjun Vynipadath > > adapter->rawf_cnt was not initialized, thereby > ndo_udp_tunnel_{add/del} was returning immediately > without initializing {vxlan/geneve}_port. > Also initializes

Re: [PATCH net-next 2/3] cxgb4: enable inner header checksum calculation

From: Ganesh Goudar Date: Fri, 11 May 2018 18:35:33 +0530 > set cntrl bits to indicate whether inner header checksum > needs to be calculated whenever the packet is an encapsulated > packet and enable supported encap features. > > Fixes: d0a1299c6bf7 ("cxgb4: add support

Re: [PATCH net-next 3/3] cxgb4: avoid schedule while atomic

From: Ganesh Goudar Date: Fri, 11 May 2018 18:36:16 +0530 > do not sleep while adding or deleting udp tunnel. > > Fixes: 846eac3fccec ("cxgb4: implement udp tunnel callbacks") > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] cxgb4: Add new T5 device id

From: Ganesh Goudar Date: Fri, 11 May 2018 18:37:34 +0530 > Add 0x50ad device id for new T5 card. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH 1/3] bonding: replace the return value type

From: Tonghao Zhang Date: Fri, 11 May 2018 02:52:32 -0700 > The method ndo_start_xmit is defined as returning a > netdev_tx_t, which is a typedef for an enum type, > but the implementation in this driver returns an int. > > Signed-off-by: Tonghao Zhang

Re: [PATCH 2/3] bonding: use the skb_get/set_queue_mapping

From: Tonghao Zhang Date: Fri, 11 May 2018 02:53:11 -0700 > Use the skb_get_queue_mapping, skb_set_queue_mapping > and skb_rx_queue_recorded for skb queue_mapping in bonding > driver, but not use it directly. > > Signed-off-by: Tonghao Zhang

Re: [PATCH 3/3] net: doc: fix spelling mistake: "modrobe.d" -> "modprobe.d"

From: Tonghao Zhang Date: Fri, 11 May 2018 02:53:12 -0700 > Signed-off-by: Tonghao Zhang Applied to net-next.

Re: [PATCH net-next] erspan: auto detect truncated ipv6 packets.

From: William Tu Date: Fri, 11 May 2018 05:49:47 -0700 > Currently the truncated bit is set only when 1) the mirrored packet > is larger than mtu and 2) the ipv4 packet tot_len is larger than > the actual skb->len. This patch adds another case for detecting > whether ipv6

Re: [PATCH v2 1/3] selinux: add AF_UNSPEC and INADDR_ANY checks to selinux_socket_bind()

On Fri, 2018-05-11 at 20:15 +0300, Alexey Kodanev wrote: > Commit d452930fd3b9 ("selinux: Add SCTP support") breaks > compatibility > with the old programs that can pass sockaddr_in structure with > AF_UNSPEC > and INADDR_ANY to bind(). As a result, bind() returns EAFNOSUPPORT > error. > This was

Re: [PATCH net-next 0/2] mlxsw: spectrum_span: Two minor adjustments

From: Ido Schimmel Date: Fri, 11 May 2018 11:57:29 +0300 > Petr says: > > This patch set fixes a couple of nits in mlxsw's SPAN implementation: > two counts of inaccurate variable name and one count of unsuitable error > code, fixed, respectively, in patches #1 and #2.

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

From: Yoshihiro Shimoda Date: Fri, 11 May 2018 12:18:56 +0900 > Add documentation for r8a77990 compatible string to renesas ravb device > tree bindings documentation. > > Signed-off-by: Yoshihiro Shimoda I'm assuming this

Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2018-05-11

From: Jeff Kirsher Date: Fri, 11 May 2018 12:47:18 -0700 > This series contains fixes to the ice, ixgbe and ixgbevf drivers. ... > The following are changes since commit > 5ae4bbf76928b401fe467e837073d939300adbf0: > Merge tag 'mlx5-fixes-2018-05-10' of >

Re: [PATCH net 0/5] rxrpc: Fixes

From: David Howells Date: Thu, 10 May 2018 23:45:17 +0100 > Here are three fixes for AF_RXRPC and two tracepoints that were useful for > finding them: ... > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git >

Re: [PATCH v2 net 1/1] net sched actions: fix invalid pointer dereferencing if skbedit flags missing

From: Roman Mashak Date: Fri, 11 May 2018 10:55:09 -0400 > When application fails to pass flags in netlink TLV for a new skbedit action, > the kernel results in the following oops: ... > The caller calls action's ->init() and passes pointer to "struct tc_action > *a", >

[PATCH net-next 0/4] bonding: performance and reliability

Series of fixes to how rlb updates are handled, code cleanup, allowing higher performance tx hashing in balance-alb mode, and reliability of link up/down monitoring. Debabrata Banerjee (4): bonding: don't queue up extraneous rlb updates bonding: use common mac addr checks bonding: allow use

Re: [PATCH] isdn: eicon: fix a missing-check bug

From: Wenwen Wang Date: Sat, 5 May 2018 14:32:46 -0500 > To avoid such issues, this patch adds a check after the second copy in the > function diva_xdi_write(). If the adapter number is not equal to the one > obtained in the first copy, (-4) will be returned to divas_write(),

[PATCH net-next 4/4] bonding: allow carrier and link status to determine link state

In a mixed environment it may be difficult to tell if your hardware support carrier, if it does not it can always report true. With a new use_carrier option of 2, we can check both carrier and link status sequentially, instead of one or the other Signed-off-by: Debabrata Banerjee

[net 2/4] ixgbe: return error on unsupported SFP module when resetting

From: Emil Tantilov Add check for unsupported module and return the error code. This fixes a Coverity hit due to unused return status from setup_sfp. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net 1/4] ice: Set rq_last_status when cleaning rq

From: Jeff Shaw Prior to this commit, the rq_last_status was only set when hardware responded with an error. This leads to rq_last_status being invalid in the future when hardware eventually responds without error. This commit resolves the issue by unconditionally

[net 3/4] ixgbevf: fix ixgbevf_xmit_frame()'s return type

From: Luc Van Oostenryck The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc

[net 4/4] ixgbe: fix memory leak on ipsec allocation

From: Colin Ian King The error clean up path kfree's adapter->ipsec and should be instead kfree'ing ipsec. Fix this. Also, the err1 error exit path does not need to kfree ipsec because this failure path was for the failed allocation of ipsec. Detected by CoverityScan,

[PATCH net-next 1/4] bonding: don't queue up extraneous rlb updates

arps for incomplete entries can't be sent anyway. Signed-off-by: Debabrata Banerjee --- drivers/net/bonding/bond_alb.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c

[net 0/4][pull request] Intel Wired LAN Driver Updates 2018-05-11

This series contains fixes to the ice, ixgbe and ixgbevf drivers. Jeff Shaw provides a fix to ensure rq_last_status gets set, whether or not the hardware responds with an error in the ice driver. Emil adds a check for unsupported module during the reset routine for ixgbe. Luc Van Oostenryck

[PATCH net-next 3/4] bonding: allow use of tx hashing in balance-alb

The rx load balancing provided by balance-alb is not mutually exclusive with using hashing for tx selection, and should provide a decent speed increase because this eliminates spinlocks and cache contention. Signed-off-by: Debabrata Banerjee ---

[PATCH net-next 2/4] bonding: use common mac addr checks

Replace homegrown mac addr checks with faster defs from etherdevice.h Signed-off-by: Debabrata Banerjee --- drivers/net/bonding/bond_alb.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/drivers/net/bonding/bond_alb.c

Re: [PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask()

> I could reorder the probe function a little to initialize the PHY before > performing the MAC reset, drop this patch and the AR803X hibernation > stuff from patch 2 if you like. But again, I can't actually test the > result on the affected hardware. Hi Paul I don't like a MAC driver poking

[PATCH V2] mlx4_core: allocate ICM memory in page size chunks

When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory allocations. When that happens, user processes

Re: [PATCH] mlx4_core: allocate 4KB ICM chunks

On 5/11/2018 3:27 AM, Håkon Bugge wrote: On 11 May 2018, at 01:31, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory

Re: [PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy

From: Andrew Lunn Date: Fri, 11 May 2018 21:10:11 +0200 > Humm, i thought i had given one. But i cannot find it in the mail > archive. Going senile :-( You aren't going senile, there is just are a huge number of patches being submitted since net-next openned up.

Re: [PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy

On 05/11/2018 11:08 AM, Dan Murphy wrote: > Add support for the DP83811 phy. > > The DP83811 supports both rgmii and sgmii interfaces. > There are 2 part numbers for this the DP83TC811R does not > reliably support the SGMII interface but the DP83TC811S will. > > There is not a way to

Re: [PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy

On Fri, May 11, 2018 at 01:51:28PM -0500, Dan Murphy wrote: > Andrew > > On 05/11/2018 01:30 PM, Andrew Lunn wrote: > > On Fri, May 11, 2018 at 01:08:19PM -0500, Dan Murphy wrote: > >> Add support for the DP83811 phy. > >> > >> The DP83811 supports both rgmii and sgmii interfaces. > >> There are

Re: [PATCH net 1/1] net sched actions: fix refcnt leak in skbmod

On Fri, May 11, 2018 at 11:35 AM, Roman Mashak wrote: > When application fails to pass flags in netlink TLV when replacing > existing skbmod action, the kernel will leak refcnt: > > $ tc actions get action skbmod index 1 > total acts 0 > > action order 0: skbmod pipe

Re: INFO: rcu detected stall in kfree_skbmem

On 05/11/2018 11:41 AM, Marcelo Ricardo Leitner wrote: > But calling ip6_xmit with rcu_read_lock is expected. tcp stack also > does it. > Thus I think this is more of an issue with IPv6 stack. If a host has > an extensive ip6tables ruleset, it probably generates this more > easily. > >>>

Re: [PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy

Andrew On 05/11/2018 01:30 PM, Andrew Lunn wrote: > On Fri, May 11, 2018 at 01:08:19PM -0500, Dan Murphy wrote: >> Add support for the DP83811 phy. >> >> The DP83811 supports both rgmii and sgmii interfaces. >> There are 2 part numbers for this the DP83TC811R does not >> reliably support the

Re: INFO: rcu detected stall in kfree_skbmem

On Fri, May 11, 2018 at 12:00:38PM +0200, Dmitry Vyukov wrote: > On Mon, Apr 30, 2018 at 8:09 PM, syzbot > wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:5d1365940a68 Merge > >

Re: [PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask()

On Fri, May 11, 2018 at 11:25:02AM -0700, Paul Burton wrote: > Hi Andrew, > > On Fri, May 11, 2018 at 02:26:19AM +0200, Andrew Lunn wrote: > > On Thu, May 10, 2018 at 04:16:52PM -0700, Paul Burton wrote: > > > From: Andrew Lunn > > > > > > On some boards, this PHY has a problem

Re: [PATCH v6 1/6] net: phy: at803x: Export at803x_debug_reg_mask()

Hi Andrew, On Fri, May 11, 2018 at 02:26:19AM +0200, Andrew Lunn wrote: > On Thu, May 10, 2018 at 04:16:52PM -0700, Paul Burton wrote: > > From: Andrew Lunn > > > > On some boards, this PHY has a problem when it hibernates. Export this > > function to a board can register a PHY

[PATCH net 1/1] net sched actions: fix refcnt leak in skbmod

When application fails to pass flags in netlink TLV when replacing existing skbmod action, the kernel will leak refcnt: $ tc actions get action skbmod index 1 total acts 0 action order 0: skbmod pipe set smac 00:11:22:33:44:55 index 1 ref 1 bind 0 For example, at this point a

Re: possible deadlock in sk_diag_fill

On Sat, May 05, 2018 at 10:59:02AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=12164c9780 >

Re: [PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy

On Fri, May 11, 2018 at 01:08:19PM -0500, Dan Murphy wrote: > Add support for the DP83811 phy. > > The DP83811 supports both rgmii and sgmii interfaces. > There are 2 part numbers for this the DP83TC811R does not > reliably support the SGMII interface but the DP83TC811S will. > > There is not a

Re: [PATCH net V2] tun: fix use after free for ptr_ring

On Fri, May 11, 2018 at 10:49:25AM +0800, Jason Wang wrote: > We used to initialize ptr_ring during TUNSETIFF, this is because its > size depends on the tx_queue_len of netdevice. And we try to clean it > up when socket were detached from netdevice. A race were spotted when > trying to do uninit

[bpf-next V2 PATCH 1/4] bpf: devmap introduce dev_map_enqueue

Functionality is the same, but the ndo_xdp_xmit call is now simply invoked from inside the devmap.c code. V2: Fix compile issue reported by kbuild test robot Signed-off-by: Jesper Dangaard Brouer --- include/linux/bpf.h| 14 +++---

[bpf-next V2 PATCH 0/4] xdp: introduce bulking for ndo_xdp_xmit API

This patchset change ndo_xdp_xmit API to take a bulk of xdp frames. When kernel is compiled with CONFIG_RETPOLINE, every indirect function pointer (branch) call hurts performance. For XDP this have a huge negative performance impact. This patchset reduce the needed (indirect) calls to

[bpf-next V2 PATCH 4/4] xdp: change ndo_xdp_xmit API to support bulking

This patch change the API for ndo_xdp_xmit to support bulking xdp_frames. When kernel is compiled with CONFIG_RETPOLINE, XDP sees a huge slowdown. Most of the slowdown is caused by DMA API indirect function calls, but also the net_device->ndo_xdp_xmit() call. Benchmarked patch with

[bpf-next V2 PATCH 2/4] bpf: devmap prepare xdp frames for bulking

Like cpumap create queue for xdp frames that will be bulked. For now, this patch simply invoke ndo_xdp_xmit foreach frame. This happens, either when the map flush operation is envoked, or when the limit DEV_MAP_BULK_SIZE is reached. Signed-off-by: Jesper Dangaard Brouer ---

[bpf-next V2 PATCH 3/4] xdp: add tracepoint for devmap like cpumap have

Notice how this allow us get XDP statistic without affecting the XDP performance, as tracepoint is no-longer activated on a per packet basis. The xdp_monitor sample/tool is updated to use this new tracepoint. Signed-off-by: Jesper Dangaard Brouer --- include/linux/bpf.h

Re: [PATCH net-next v10 2/4] net: Introduce generic failover module

On Mon, May 07, 2018 at 03:39:19PM -0700, Randy Dunlap wrote: > Hi, > > On 05/07/2018 03:10 PM, Sridhar Samudrala wrote: > > > > Signed-off-by: Sridhar Samudrala > > --- > > MAINTAINERS|7 + > > include/linux/netdevice.h | 16 + > >

[PATCH v3] net: phy: DP83TC811: Introduce support for the DP83TC811 phy

Add support for the DP83811 phy. The DP83811 supports both rgmii and sgmii interfaces. There are 2 part numbers for this the DP83TC811R does not reliably support the SGMII interface but the DP83TC811S will. There is not a way to differentiate these parts from the hardware or register set. So

  1   2   3   >