[PATCH rdma-next 0/3] Dump and fill MKEY

2018-06-18 Thread Leon Romanovsky
From: Leon Romanovsky MLX5 IB HCA offers the memory key, dump_fill_mkey to increase performance, when used in a send or receive operations. It is used to force local HCA operations to skip the PCI bus access, while keeping track of the processed length in the ibv_sge handling. In this three

[PATCH mlx5-next 1/3] net/mlx5: Limit scope of dump_fill_mkey function

2018-06-18 Thread Leon Romanovsky
From: Yonatan Cohen mlx5_core_dump_fill_mkey() is going to be used in next patch in IB and doesn't need to be visible to whole mlx5_core. Move that command to mlx5_ib. Signed-off-by: Yonatan Cohen Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/cmd.c | 15

[PATCH mlx5-next 2/3] net/mlx5: Add hardware definitions for dump_fill_mkey

2018-06-18 Thread Leon Romanovsky
From: Leon Romanovsky MLX5 IB HCA offers the memory key, dump_fill_mkey to boost performance by forcing local HCA operations to skip the PCI bus access, This patch adds needed hardware definitions. Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 4 +++- 1 file changed, 3

[PATCH rdma-next 3/3] IB/mlx5: Expose dump and fill memory key

2018-06-18 Thread Leon Romanovsky
From: Yonatan Cohen MLX5 IB HCA offers the memory key, dump_fill_mkey to boost performance, when used in a send or receive operations. It is used to force local HCA operations to skip the PCI bus access, while keeping track of the processed length in the ibv_sge handling. Meaning, instead of a

[PATCH v2 2/4] net/ncsi: Drop no more channels message

2018-06-18 Thread Joel Stanley
This does not provide useful information. As the ncsi maintainer said: > either we get a channel or broadcom has gone out to lunch Acked-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- net/ncsi/ncsi-manage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c

[PATCH v2 3/4] net/ncsi: Use netdev_dbg for debug messages

2018-06-18 Thread Joel Stanley
This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to netdev_dbg. As Joe explains: > netdev_dbg is not included in object code unless > DEBUG is defined or CONFIG_DYNAMIC_DEBUG is set. > And then, it is not emitted into the log unless > DEBUG is set or this specific netdev_dbg is

[PATCH v2 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI

2018-06-18 Thread Joel Stanley
Sam has been handing the maintenance of NCSI for a number release cycles now. Acked-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9d5eeff51b5f..44851f7c46fc 100644 --- a/MAINTAINERS

[PATCH v2 1/4] net/ncsi: Silence debug messages

2018-06-18 Thread Joel Stanley
In normal operation we see this series of messages as the host drives the network device: ftgmac100 1e66.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e66.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e66.ethernet eth0: NCSI: configuring channel 0 ftgmac100

[PATCH v2 0/4] Slience NCSI logging

2018-06-18 Thread Joel Stanley
v2: Fix indent issue and commit message based on Joe's feedback Add Sam's acks Here are three changes to silence unnecessary warnings in the ncsi code. The final patch adds Sam as the maintainer for NCSI. Joel Stanley (4): net/ncsi: Silence debug messages net/ncsi: Drop no more channels

[PATCH net 1/3] qed: Fix possible memory leak in Rx error path handling.

2018-06-18 Thread Sudarsana Reddy Kalluru
Memory for packet buffers need to be freed in the error paths as there is no consumer (e.g., upper layer) for such packets and that memory will never get freed. The issue was uncovered when port was attacked with flood of isatap packets, these are multicast packets hence were directed at all the

Re: [PATCH rdma-next v2 00/20] Introduce mlx5 DEVX interface

2018-06-18 Thread Leon Romanovsky
On Mon, Jun 18, 2018 at 04:05:04PM -0600, Jason Gunthorpe wrote: > On Sun, Jun 17, 2018 at 12:59:46PM +0300, Leon Romanovsky wrote: > > > Leon Romanovsky (2): > > drm/i915: Move u64-to-ptr helpers to general header > > kernel.h: Reuse u64_to_ptr macro to cast __user pointers > > I dropped

[PATCH net 3/3] qed: Do not advertise DCBX_LLD_MANAGED capability.

2018-06-18 Thread Sudarsana Reddy Kalluru
Do not advertise DCBX_LLD_MANAGED capability i.e., do not allow external agent to manage the dcbx/lldp negotiation. MFW acts as lldp agent for qed* devices, and no other lldp agent is allowed to coexist with mfw. Also updated a debug print, to not to display the redundant info. Fixes: a1d8d8a51

[PATCH net 2/3] qed: Add sanity check for SIMD fastpath handler.

2018-06-18 Thread Sudarsana Reddy Kalluru
Avoid calling a SIMD fastpath handler if it is NULL. The check is needed to handle an unlikely scenario where unsolicited interrupt is destined to a PF in INTa mode. Fixes: fe56b9e6a ("qed: Add module with basic common support") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior

[PATCH net 0/3] qed*: Fix series.

2018-06-18 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The patch series fixes few issues in the qed/qede drivers. Please consider applying this series to "net". Sudarsana Reddy Kalluru (3): qed: Fix possible memory leak in Rx error path handling. qed: Add sanity check for SIMD fastpath handler. qed: Do not

[PATCH net] xfrm_user: prevent leaking 2 bytes of kernel memory

2018-06-18 Thread Eric Dumazet
struct xfrm_userpolicy_type has two holes, so we should not use C99 style initializer. KMSAN report: BUG: KMSAN: kernel-infoleak in copyout lib/iov_iter.c:140 [inline] BUG: KMSAN: kernel-infoleak in _copy_to_iter+0x1b14/0x2800 lib/iov_iter.c:571 CPU: 1 PID: 4520 Comm: syz-executor841 Not tainted

Re: [PATCH][ipsec] xfrm: replace NR_CPU with num_possible_cpus()

2018-06-18 Thread Li RongQing
sorry, please drop this patch. I should replace NR_CPUS with nr_cpu_ids, i will resend it -R On 6/15/18, Li RongQing wrote: > The default NR_CPUS can be very large, but actual possible nr_cpu_ids > usually is very small. For some x86 distribution, the NR_CPUS is 8192 > and nr_cpu_ids is 4. > >

Re: [PATCH 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI

2018-06-18 Thread Samuel Mendoza-Jonas
On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote: > Sam has been handing the maintenance of NCSI for a number release cycles > now. > > Signed-off-by: Joel Stanley I'm exposed! Acked-by: Samuel Mendoza-Jonas > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH 3/4] net/ncsi: Use netdev_dbg for debug messages

2018-06-18 Thread Samuel Mendoza-Jonas
On Mon, 2018-06-18 at 13:53 -0700, Joe Perches wrote: > On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote: > > This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to > > netdev_dbg. There is no change in behaviour. > > Not quite, but I think the patch is fine anyway. > >

[PATCH net] enic: do not overwrite error code

2018-06-18 Thread Govindarajulu Varadarajan
In failure path, we overwrite err to what vnic_rq_disable() returns. In case it returns 0, enic_open() returns success in case of error. Reported-by: Ben Hutchings Fixes: e8588e268509 ("enic: enable rq before updating rq descriptors") Signed-off-by: Govindarajulu Varadarajan ---

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-18 Thread Grygorii Strashko
On 06/18/2018 03:19 PM, Ilias Apalodimas wrote: On Mon, Jun 18, 2018 at 06:16:27PM +0200, Andrew Lunn wrote: @@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data, if (of_property_read_bool(node, "dual_emac")) data->switch_mode =

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-18 Thread Grygorii Strashko
On 06/14/2018 06:43 AM, Ilias Apalodimas wrote: > On Thu, Jun 14, 2018 at 01:39:58PM +0200, Jiri Pirko wrote: >> Thu, Jun 14, 2018 at 01:34:04PM CEST, ilias.apalodi...@linaro.org wrote: >>> On Thu, Jun 14, 2018 at 01:30:28PM +0200, Jiri Pirko wrote: Thu, Jun 14, 2018 at 01:11:30PM CEST,

Re: [PATCH rdma-next v2 00/20] Introduce mlx5 DEVX interface

2018-06-18 Thread Jason Gunthorpe
On Sun, Jun 17, 2018 at 12:59:46PM +0300, Leon Romanovsky wrote: > Leon Romanovsky (2): > drm/i915: Move u64-to-ptr helpers to general header > kernel.h: Reuse u64_to_ptr macro to cast __user pointers I dropped these since they are not needed by this series when using a union. > Matan

Re: [PATCH] tc, bpf: add option to dump bpf verifier as C program fragment

2018-06-18 Thread David Ahern
On 6/18/18 2:18 PM, Jakub Kicinski wrote: > On Sun, 17 Jun 2018 08:48:41 +, Ophir Munk wrote: >> Similar to cbpf used within tcpdump utility with a "-d" option to dump >> the compiled packet-matching code in a human readable form - tc has the >> "verbose" option to dump ebpf verifier output.

Re: [PATCH bpf-net] bpf: Change bpf_fib_lookup to return lookup status

2018-06-18 Thread David Ahern
On 6/18/18 2:55 PM, Martin KaFai Lau wrote: >> /* rc > 0 case */ >> switch(rc) { >> case BPF_FIB_LKUP_RET_BLACKHOLE: >> case BPF_FIB_LKUP_RET_UNREACHABLE: >> case BPF_FIB_LKUP_RET_PROHIBIT: >> return XDP_DROP; >> } >> >> For the others it becomes a

Debido al no el pago de sus impuestos se hara efectivo un embargo bancario

2018-06-18 Thread Dian
Estimado contribuyente: Es nuestro deber informarle que debido al no pago de sus impuestos se hara efectivo un embargo bancario en el dia de hoy. Por la seguridad de sus datos hemos adjuntado un documento con su deuda a la fecha con una clave la cual es : 421e68dd993c4a8bb9e3d5e6c066946r

Re: [bpf PATCH v2 2/6] bpf: sockmap only allow ESTABLISHED sock state

2018-06-18 Thread Martin KaFai Lau
On Mon, Jun 18, 2018 at 07:50:19AM -0700, John Fastabend wrote: > On 06/14/2018 05:18 PM, Martin KaFai Lau wrote: > > On Thu, Jun 14, 2018 at 09:44:52AM -0700, John Fastabend wrote: > >> Per the note in the TLS ULP (which is actually a generic statement > >> regarding ULPs) > >> > >> /* The TLS

Re: [PATCH bpf-net] bpf: Change bpf_fib_lookup to return lookup status

2018-06-18 Thread Martin KaFai Lau
On Mon, Jun 18, 2018 at 12:27:07PM -0600, David Ahern wrote: > On 6/18/18 12:11 PM, Martin KaFai Lau wrote: > > On Sun, Jun 17, 2018 at 08:18:19AM -0700, dsah...@kernel.org wrote: > >> From: David Ahern > >> > >> For ACLs implemented using either FIB rules or FIB entries, the BPF > >> program

Re: [PATCH 3/4] net/ncsi: Use netdev_dbg for debug messages

2018-06-18 Thread Joe Perches
On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote: > This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to > netdev_dbg. There is no change in behaviour. Not quite, but I think the patch is fine anyway. netdev_printk(KERN_DEBUG ... is always emitted as long as the console

[PATCH v5 1/3] bitfield: fix *_encode_bits()

2018-06-18 Thread Johannes Berg
There's a bug in *_encode_bits() in using ~field_multiplier() for the check whether or not the constant value fits into the field, this is wrong and clearly ~field_mask() was intended. This was triggering for me for both constant and non-constant values. Additionally, make this case actually into

Re: [PATCH 1/4] net/ncsi: Silence debug messages

2018-06-18 Thread Joe Perches
On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote: > In normal operation we see this series of messages as the host drives > the network device: > > ftgmac100 1e66.ethernet eth0: NCSI: LSC AEN - channel 0 state down > ftgmac100 1e66.ethernet eth0: NCSI: suspending channel 0 [...] >

[PATCH v5 3/3] bitfield: add tests

2018-06-18 Thread Johannes Berg
Add tests for the bitfield helpers. The constant ones will all be folded to nothing by the compiler (if everything is correct in the header file), and the variable ones do some tests against open-coding the necessary shifts. A few test cases that should fail/warn compilation are provided under

Re: [PATCH rdma-next v2 06/20] IB/uverbs: Add PTR_IN attributes that are allocated/copied automatically

2018-06-18 Thread Jason Gunthorpe
On Sun, Jun 17, 2018 at 12:59:52PM +0300, Leon Romanovsky wrote: > From: Matan Barak > > Adding UVERBS_ATTR_SPEC_F_ALLOC_AND_COPY flag to PTR_IN attributes. > By using this flag, the parse automatically allocates and copies the > user-space data. This data is accessible by using

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-18 Thread Ilias Apalodimas
On Mon, Jun 18, 2018 at 06:16:27PM +0200, Andrew Lunn wrote: > > @@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data > > *data, > > if (of_property_read_bool(node, "dual_emac")) > > data->switch_mode = CPSW_DUAL_EMAC; > > > > + /* switchdev overrides DTS

Re: [PATCH] tc, bpf: add option to dump bpf verifier as C program fragment

2018-06-18 Thread Jakub Kicinski
On Sun, 17 Jun 2018 08:48:41 +, Ophir Munk wrote: > Similar to cbpf used within tcpdump utility with a "-d" option to dump > the compiled packet-matching code in a human readable form - tc has the > "verbose" option to dump ebpf verifier output. > Another useful option of cbpf using tcpdump

[PATCH net] net/tcp: Fix socket lookups with SO_BINDTODEVICE

2018-06-18 Thread dsahern
From: David Ahern Similar to 69678bcd4d2d ("udp: fix SO_BINDTODEVICE"), TCP socket lookups need to fail if dev_match is not true. Currently, a packet to a given port can match a socket bound to device when it should not. In the VRF case, this causes the lookup to hit a VRF socket and not a

Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch_hfsc]

2018-06-18 Thread Cong Wang
On Mon, Jun 4, 2018 at 11:39 PM, Marco Berizzi wrote: >> Il 8 marzo 2018 alle 17.02 Marco Berizzi ha scritto: >> >> > Marco Berizzi wrote: >> > >> > Hello everyone, >> > >> > Yesterday I got this error on a slackware linux 4.16-rc4 system >> > running as a traffic shaping gateway and netfilter

[PATCH iproute2-next 1/1] tc: jsonify nat action

2018-06-18 Thread Keara Leibovitz
Add json output support for nat action Example output: ~$ $TC actions add action nat egress 10.10.10.1 20.20.20.2 index 2 ~$ $TC actions add action nat ingress 100.100.100.1/32 200.200.200.2 \ continue index 99 ~$ $TC -j actions ls action nat [{ "total acts": 2 }, {

Re: [PATCH bpf-net] bpf: Change bpf_fib_lookup to return lookup status

2018-06-18 Thread David Ahern
On 6/18/18 12:11 PM, Martin KaFai Lau wrote: > On Sun, Jun 17, 2018 at 08:18:19AM -0700, dsah...@kernel.org wrote: >> From: David Ahern >> >> For ACLs implemented using either FIB rules or FIB entries, the BPF >> program needs the FIB lookup status to be able to drop the packet. > Except

Re: [PATCH] ptp: replace getnstimeofday64() with ktime_get_real_ts64()

2018-06-18 Thread Richard Cochran
On Mon, Jun 18, 2018 at 04:20:39PM +0200, Arnd Bergmann wrote: > getnstimeofday64() is deprecated and getting replaced throughout > the kernel with ktime_get_*() based helpers for a more consistent > interface. > > The two functions do the exact same thing, so this is just > a cosmetic change.

Re: [PATCH bpf-net] bpf: Change bpf_fib_lookup to return lookup status

2018-06-18 Thread Martin KaFai Lau
On Sun, Jun 17, 2018 at 08:18:19AM -0700, dsah...@kernel.org wrote: > From: David Ahern > > For ACLs implemented using either FIB rules or FIB entries, the BPF > program needs the FIB lookup status to be able to drop the packet. Except BPF_FIB_LKUP_RET_SUCCESS and BPF_FIB_LKUP_RET_NO_NEIGH, can

array bounds warning in xfrm_output_resume

2018-06-18 Thread David Ahern
Florian: I am seeing this warning: $ make O=kbuild/perf -j 24 -s In file included from /home/dsa/kernel-3.git/include/linux/kernel.h:10:0, from /home/dsa/kernel-3.git/include/linux/list.h:9, from /home/dsa/kernel-3.git/include/linux/module.h:9,

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-18 Thread Ilias Apalodimas
On Mon, Jun 18, 2018 at 07:30:25PM +0200, Andrew Lunn wrote: > On Mon, Jun 18, 2018 at 07:46:02PM +0300, Ilias Apalodimas wrote: > > On Mon, Jun 18, 2018 at 06:28:36PM +0200, Andrew Lunn wrote: > > > > Yes, if the CPU port is added on the VLAN then unregistered multicast > > > > traffic > > > >

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-18 Thread Andrew Lunn
On Mon, Jun 18, 2018 at 07:46:02PM +0300, Ilias Apalodimas wrote: > On Mon, Jun 18, 2018 at 06:28:36PM +0200, Andrew Lunn wrote: > > > Yes, if the CPU port is added on the VLAN then unregistered multicast > > > traffic > > > (and thus IGMP joins) will reach the CPU port and everything will work

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-18 Thread Ilias Apalodimas
On Mon, Jun 18, 2018 at 06:28:36PM +0200, Andrew Lunn wrote: > > Yes, if the CPU port is added on the VLAN then unregistered multicast > > traffic > > (and thus IGMP joins) will reach the CPU port and everything will work as > > expected. I think we should not consider this as a "problem" as long

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-18 Thread Andrew Lunn
> Yes, if the CPU port is added on the VLAN then unregistered multicast traffic > (and thus IGMP joins) will reach the CPU port and everything will work as > expected. I think we should not consider this as a "problem" as long as it's > descibed properly in Documentation. This switch is excected

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

2018-06-18 Thread Andrew Lunn
> @@ -2711,6 +2789,10 @@ static int cpsw_probe_dt(struct cpsw_platform_data > *data, > if (of_property_read_bool(node, "dual_emac")) > data->switch_mode = CPSW_DUAL_EMAC; > > + /* switchdev overrides DTS */ > + if (IS_ENABLED(CONFIG_TI_CPSW_SWITCHDEV)) > +

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-18 Thread Ilias Apalodimas
On Mon, Jun 18, 2018 at 05:04:24PM +0200, Andrew Lunn wrote: > Hi Ilias > > Thanks for removing the CPU port. That helps a lot moving forward. > > > - Multicast testing client-port1(tagged on vlan 100) server-port1 > > switch-config is provided by TI (https://git.ti.com/switch-config) > > and is

Re: [PATCH net] net/ipv6: respect rcu grace period before freeing fib6_info

2018-06-18 Thread David Ahern
On 6/18/18 6:24 AM, Eric Dumazet wrote: > syzbot reported use after free that is caused by fib6_info being > freed without a proper RCU grace period. > ... > Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers") > Signed-off-by: Eric Dumazet > Cc: David Ahern > Reported-by:

Re: [PATCH net-next 0/10] xfrm: remove flow cache

2018-06-18 Thread Kristian Evensen
Hi, On Wed, Jun 13, 2018 at 3:43 PM, Kristian Evensen wrote: > Thanks! I will prepare a firmware for one of my devices tonight, start > testing tomorrow and report back when I have some results. We have been testing this patch over the weekend and it has a significant impact on performance. In

Re: Link modes representation in phylib

2018-06-18 Thread Andrew Lunn
On Mon, Jun 18, 2018 at 05:02:24PM +0200, Maxime Chevallier wrote: > Hello everyone, > > I'm currently working on adding support for 2.5GBaseT on some Marvell > PHYs (the marvell10g family, including the 88X3310). > > However, phylib doesn't quite support these modes yet. Its stores the >

Re: [RFC v2, net-next, PATCH 0/4] Add switchdev on TI-CPSW

2018-06-18 Thread Andrew Lunn
Hi Ilias Thanks for removing the CPU port. That helps a lot moving forward. > - Multicast testing client-port1(tagged on vlan 100) server-port1 > switch-config is provided by TI (https://git.ti.com/switch-config) > and is used to verify correct switch configuration. > 1. switch-config output >

Link modes representation in phylib

2018-06-18 Thread Maxime Chevallier
Hello everyone, I'm currently working on adding support for 2.5GBaseT on some Marvell PHYs (the marvell10g family, including the 88X3310). However, phylib doesn't quite support these modes yet. Its stores the different supported and advertised modes in u32 fields, which can't contain the

Re: [bpf PATCH v2 2/6] bpf: sockmap only allow ESTABLISHED sock state

2018-06-18 Thread John Fastabend
On 06/14/2018 05:18 PM, Martin KaFai Lau wrote: > On Thu, Jun 14, 2018 at 09:44:52AM -0700, John Fastabend wrote: >> Per the note in the TLS ULP (which is actually a generic statement >> regarding ULPs) >> >> /* The TLS ulp is currently supported only for TCP sockets >> * in ESTABLISHED state.

[PATCH net] ipvlan: call dev_change_flags when reset ipvlan mode

2018-06-18 Thread Hangbin Liu
After we change the ipvlan mode from l3 to l2, or vice versa. We only reset IFF_NOARP flag, but don't flush the ARP table cache, which will cause eth->h_dest to be equal to eth->h_source in ipvlan_xmit_mode_l2(). Then the message will not come out of host. Here is the reproducer on local host:

[PATCH net] net/ipv6: respect rcu grace period before freeing fib6_info

2018-06-18 Thread Eric Dumazet
syzbot reported use after free that is caused by fib6_info being freed without a proper RCU grace period. CPU: 0 PID: 1407 Comm: udevd Not tainted 4.17.0+ #39 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77

Re: [PATCH rdma-next v2 09/20] IB/core: Improve uverbs_cleanup_ucontext algorithm

2018-06-18 Thread Yishai Hadas
On 6/17/2018 10:51 PM, Jason Gunthorpe wrote: On Sun, Jun 17, 2018 at 12:59:55PM +0300, Leon Romanovsky wrote: +void uverbs_cleanup_ucontext(struct ib_ucontext *ucontext, bool device_removed) +{ /* * Waits for all remove_commit and alloc_commit to finish. Logically, We

Re: [PATCH] net: Fix device name resolving crash in default_device_exit()

2018-06-18 Thread Kirill Tkhai
On 18.06.2018 14:21, Kirill Tkhai wrote: > On 17.06.2018 21:58, David Ahern wrote: >> On 6/15/18 3:44 AM, Kirill Tkhai wrote: >>> Hm, but is this a likely case, when real device is moved to net ns, so it >>> requires moving to init_net back? It seems the most devices moved to >>> !init_net >>>

Re: [PATCH] net: Fix device name resolving crash in default_device_exit()

2018-06-18 Thread Kirill Tkhai
On 17.06.2018 21:58, David Ahern wrote: > On 6/15/18 3:44 AM, Kirill Tkhai wrote: >> Hm, but is this a likely case, when real device is moved to net ns, so it >> requires moving to init_net back? It seems the most devices moved to >> !init_net >> are virtual and they just destroyed in

[PATCH 1/1] tcp: tcp_mtup_probe -> tcp_mtu_probe

2018-06-18 Thread Wang Jian
Comment correction. Signed-off-by: Jian Wang --- net/ipv4/tcp_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 355d3df..fd7b766 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -2862,7 +2862,7 @@ static

[PATCH net] ipvlan: use ETH_MAX_MTU as max mtu

2018-06-18 Thread Xin Long
Similar to the fixes on team and bonding, this restores the ability to set an ipvlan device's mtu to anything higher than 1500. Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra") Signed-off-by: Xin Long --- drivers/net/ipvlan/ipvlan_main.c | 1 + 1 file changed, 1

Re: [PATCH 1/2] eth phy: add mdio bus char device interface

2018-06-18 Thread Andrew Lunn
1;5202;0cOn Mon, Jun 18, 2018 at 11:32:12AM +0800, Wei Li wrote: > Add the char device interface of mdio bus, like what i2c-dev or spidev do. > They make it possible for user-space programs to access the bus directly. > Hi Wei What is your real use case here? What we don't want to do is add

[PATCH 0/4] Slience NCSI logging

2018-06-18 Thread Joel Stanley
Here are three changes to silence unnecessary warnings in the ncsi code. The final patch adds Sam as the maintainer for NCSI. Joel Stanley (4): net/ncsi: Silence debug messages net/ncsi: Drop no more channels message net/ncsi: Use netdev_dbg for debug messages MAINTAINERS: Add Sam as the

[PATCH 3/4] net/ncsi: Use netdev_dbg for debug messages

2018-06-18 Thread Joel Stanley
This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to netdev_dbg. There is no change in behaviour. Signed-off-by: Joel Stanley --- net/ncsi/ncsi-aen.c| 6 +++--- net/ncsi/ncsi-manage.c | 33 +++-- 2 files changed, 18 insertions(+), 21

[PATCH 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI

2018-06-18 Thread Joel Stanley
Sam has been handing the maintenance of NCSI for a number release cycles now. Signed-off-by: Joel Stanley --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9d5eeff51b5f..44851f7c46fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9756,6

[PATCH 2/4] net/ncsi: Drop no more channels message

2018-06-18 Thread Joel Stanley
This does not provide useful information. As the ncsi maintainer said: > either we get a channel or broadcom has gone out to lunch Signed-off-by: Joel Stanley --- net/ncsi/ncsi-manage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index

[PATCH 1/4] net/ncsi: Silence debug messages

2018-06-18 Thread Joel Stanley
In normal operation we see this series of messages as the host drives the network device: ftgmac100 1e66.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e66.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e66.ethernet eth0: NCSI: configuring channel 0 ftgmac100

Re: [PATCH 2/2] eth phy: add mdio bus char device interface

2018-06-18 Thread kbuild test robot
/20180618-115206 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux