rmnet_data multicast support

2018-08-04 Thread Harsha Chenji
Hi all, We are using the rmnet_data interface on a Google Pixel phone connected to our LTE network. The aim is to send/receive multicast traffic (224.0.0.1) over this point-to-point, NOARP link between the phone and (effectively) the LTE EPC which acts as the IP router for the phone. Since there

Linux kernel error stack

2018-08-04 Thread Satish Patel
Folks, I am installing openstack and as you know i have lots of bridges and vlan interface on my Linux CentOS 7.5 I was getting following error stack on 3.10 kernel and found this is kernel bug which required kernel upgrade so now i have upgraded my kernel to 4.17.12 but i am still seeing same

Re: consequences of setting net_device_ops ndo_change_carrier()?

2018-08-04 Thread Andrew Lunn
On Sat, Aug 04, 2018 at 07:06:58AM -0400, Robert P. J. Day wrote: > > i'll try to keep this (relatively) short as there may be a simple > answer to this, or it could just be a stupid question -- sort of > related to previous question (thank you, florian). > > currently messing with

Re: pull-request: bpf 2018-08-05

2018-08-04 Thread David Miller
From: Daniel Borkmann Date: Sun, 5 Aug 2018 02:26:11 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix bpftool percpu_array dump by using correct roundup to next >multiple of 8 for the value size, from Yonghong. > > 2) Fix

pull-request: bpf 2018-08-05

2018-08-04 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix bpftool percpu_array dump by using correct roundup to next multiple of 8 for the value size, from Yonghong. 2) Fix in AF_XDP's __xsk_rcv_zc() to not returning frames back to

Re: [PATCH net-next] ethtool: Remove trailing semicolon for static inline

2018-08-04 Thread David Miller
From: Florian Fainelli Date: Sat, 4 Aug 2018 14:20:40 -0700 > Android's header sanitization tool chokes on static inline functions having a > trailing semicolon, leading to an incorrectly parsed header file. While the > tool should obviously be fixed, also fix the header files for the two

[PATCH][mwifiex] fix braino in mwifiex_fw_dump_info_event()

2018-08-04 Thread Al Viro
... and on little-endian host it even worked ;-) Signed-off-by: Al Viro --- diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c index 03a6492662ca..1cd42a6a25c9 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_event.c +++

[PATCH net-next] ethtool: Remove trailing semicolon for static inline

2018-08-04 Thread Florian Fainelli
Android's header sanitization tool chokes on static inline functions having a trailing semicolon, leading to an incorrectly parsed header file. While the tool should obviously be fixed, also fix the header files for the two affected functions: ethtool_get_flow_spec_ring() and

[PATCH] mellanox: fix the dport endianness in call of __inet6_lookup_established()

2018-08-04 Thread Al Viro
__inet6_lookup_established() expect th->dport passed in host-endian, not net-endian. The reason is microoptimization in __inet6_lookup(), but if you use the lower-level helpers, you have to play by their rules... Signed-off-by: Al Viro --- diff --git

Re: [PATCH][net-next] tun: not use hardcoded mask value

2018-08-04 Thread David Miller
From: Li RongQing Date: Fri, 3 Aug 2018 15:50:02 +0800 > 0x3ff in tun_hashfn is mask of TUN_NUM_FLOW_ENTRIES, instead > of hardcode, define a macro to setup the relationship with > TUN_NUM_FLOW_ENTRIES > > Signed-off-by: Li RongQing Applied, thank you.

Re: [PATCH bpf-next] nfp: bpf: xdp_adjust_tail support

2018-08-04 Thread Daniel Borkmann
On 08/04/2018 07:06 AM, Jakub Kicinski wrote: > Add support for adjust_tail. There are no FW changes needed but add > a FW capability just in case there would be any issue with previously > released FW, or we will have to change the ABI in the future. > > The helper is trivial and shouldn't be

Re: for newbies, it would be useful to document values of netdev_state_t

2018-08-04 Thread Florian Fainelli
On 08/04/2018 08:30 AM, Robert P. J. Day wrote: > > i'm sure this is second nature for the experts here, but in > netdevice.h: > > /* These flag bits are private to the generic network queueing > * layer; they may not be explicitly referenced by any other > * code. > */ > > enum

Re: consequences of setting net_device_ops ndo_change_carrier()?

2018-08-04 Thread Robert P. J. Day
On Sat, 4 Aug 2018, Stephen Hemminger wrote: ... big snip ... > ndo_change_carrier is not the droid your looking for. > > The purpose of ndo_change_carrier was for testing network devices > (ie dummy), and also for cases like network tunnels where the > sofrware carrier state may be controlled

Re: consequences of setting net_device_ops ndo_change_carrier()?

2018-08-04 Thread Stephen Hemminger
On Sat, 4 Aug 2018 07:57:56 -0400 (EDT) "Robert P. J. Day" wrote: > On Sat, 4 Aug 2018, Jiri Pirko wrote: > > > Sat, Aug 04, 2018 at 01:06:58PM CEST, rpj...@crashcourse.ca wrote: > > > > > > i'll try to keep this (relatively) short as there may be a simple > > >answer to this, or it could

for newbies, it would be useful to document values of netdev_state_t

2018-08-04 Thread Robert P. J. Day
i'm sure this is second nature for the experts here, but in netdevice.h: /* These flag bits are private to the generic network queueing * layer; they may not be explicitly referenced by any other * code. */ enum netdev_state_t { __LINK_STATE_START, __LINK_STATE_PRESENT,

Re: [PATCH 3.18.y] Fix compilation error backporting upstream commit 9fc12023d6f5

2018-08-04 Thread Lorenzo Bianconi
> On Sat, Aug 04, 2018 at 02:27:41PM +0200, Lorenzo Bianconi wrote: > > Fix following compilation error backporting upstream commit > > 9fc12023d6f5 ("ipv4: remove BUG_ON() from fib_compute_spec_dst) > > > > net/ipv4/fib_frontend.c: In function 'fib_compute_spec_dst': > >

Re: [PATCH 3.18.y] Fix compilation error backporting upstream commit 9fc12023d6f5

2018-08-04 Thread Greg KH
On Sat, Aug 04, 2018 at 02:27:41PM +0200, Lorenzo Bianconi wrote: > Fix following compilation error backporting upstream commit > 9fc12023d6f5 ("ipv4: remove BUG_ON() from fib_compute_spec_dst) > > net/ipv4/fib_frontend.c: In function 'fib_compute_spec_dst': > net/ipv4/fib_frontend.c:225:3:

[PATCH 3.18.y] Fix compilation error backporting upstream commit 9fc12023d6f5

2018-08-04 Thread Lorenzo Bianconi
Fix following compilation error backporting upstream commit 9fc12023d6f5 ("ipv4: remove BUG_ON() from fib_compute_spec_dst) net/ipv4/fib_frontend.c: In function 'fib_compute_spec_dst': net/ipv4/fib_frontend.c:225:3: error: expected expression before 'if' if (!fib_lookup(net, , ))

Re: consequences of setting net_device_ops ndo_change_carrier()?

2018-08-04 Thread Robert P. J. Day
On Sat, 4 Aug 2018, Jiri Pirko wrote: > Sat, Aug 04, 2018 at 01:06:58PM CEST, rpj...@crashcourse.ca wrote: > > > > i'll try to keep this (relatively) short as there may be a simple > >answer to this, or it could just be a stupid question -- sort of > >related to previous question (thank you,

Re: consequences of setting net_device_ops ndo_change_carrier()?

2018-08-04 Thread Jiri Pirko
Sat, Aug 04, 2018 at 01:06:58PM CEST, rpj...@crashcourse.ca wrote: > > i'll try to keep this (relatively) short as there may be a simple >answer to this, or it could just be a stupid question -- sort of >related to previous question (thank you, florian). > > currently messing with networking

consequences of setting net_device_ops ndo_change_carrier()?

2018-08-04 Thread Robert P. J. Day
i'll try to keep this (relatively) short as there may be a simple answer to this, or it could just be a stupid question -- sort of related to previous question (thank you, florian). currently messing with networking device involving FPGA and some quad-port transceivers, and noticed that,

[PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper

2018-08-04 Thread David Woodhouse
From: Eric Dumazet commit 58152ecbbcc6a0ce7fddd5bf5f6ee535834ece0c upstream. In case skb in out_or_order_queue is the result of multiple skbs coalescing, we would like to get a proper gso_segs counter tracking, so that future tcp_drop() can report an accurate number. I chose to not implement

Re: [PATCH net 0/5] tcp: more robust ooo handling

2018-08-04 Thread David Woodhouse
On Sat, 2018-08-04 at 09:05 +0200, Greg KH wrote: > > Ok, then it's my fault :) > > Odds are it did not apply and so I didn't backport it.  If you think it > should be there, please provide a working backport. It has whitespace issues but that's about it. Will send a version which applies

Re: [PATCH net 0/5] tcp: more robust ooo handling

2018-08-04 Thread Greg KH
On Fri, Aug 03, 2018 at 04:53:27PM -0700, David Miller wrote: > From: David Woodhouse > Date: Fri, 03 Aug 2018 11:55:37 +0100 > > > I see the first four in 4.9.116 but not the fifth (adding > > tcp_ooo_try_coalesce()). > > > > Is that intentional?  > > I don't work on the 4.9 -stable