Re: [PATCH bpf] bpf: btf: Change tools/lib/bpf/btf to LGPL

2018-08-05 Thread Alexei Starovoitov
On Sun, Aug 05, 2018 at 05:19:13PM -0700, Martin KaFai Lau wrote: > This patch changes the tools/lib/bpf/btf.[ch] to LGPL which > is inline with libbpf also. > > Signed-off-by: Martin KaFai Lau technically it's bpf tree material, but since it changes "comment" only and we're very late into the

[net-next:master 457/471] ptp_qoriq.c:undefined reference to `__aeabi_uldivmod'

2018-08-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 981467033a37d916649647fa3afe1fe99bba1817 commit: 91305f2812624c0cf7ccbb44133b66d3b24676e4 [457/471] ptp_qoriq: support automatic configuration for ptp timer config: arm-multi_v7_defconfig (attached as

[net-next:master 1709/1739] drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2989:1: warning: the frame size of 1156 bytes is larger than 1024 bytes

2018-08-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 981467033a37d916649647fa3afe1fe99bba1817 commit: 6c5657d085ae8c13a8565b98e6a23fe68f0bede4 [1709/1739] bnxt_en: Add support for ethtool get dump. config: microblaze-allmodconfig (attached as .config)

[PATCH] checkpatch: warn on unnecessary int declarations

2018-08-05 Thread Joe Perches
On Sun, 2018-08-05 at 08:52 -0700, Linus Torvalds wrote: > "long unsigned int" isn't _technically_ wrong. But we normally > call that type "unsigned long". So add a checkpatch test for it. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 20 1 file changed, 20

Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

2018-08-05 Thread zhong jiang
On 2018/8/6 8:33, David Miller wrote: > From: zhong jiang > Date: Sun, 5 Aug 2018 22:18:43 +0800 > >> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br, >> struct sk_buff *skb_trimmed = NULL; >> const unsigned char *src; >> struct igmphdr *ih; >> -int

linux-next: build failure after merge of the net-next tree

2018-08-05 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/ptp/ptp_qoriq.o: In function `qoriq_ptp_probe': ptp_qoriq.c:(.text+0xd0c): undefined reference to `__aeabi_uldivmod' Caused by commit 91305f281262 ("ptp_qoriq: support

[net-next:master 1709/1739] drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2863:2: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length

2018-08-05 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 981467033a37d916649647fa3afe1fe99bba1817 commit: 6c5657d085ae8c13a8565b98e6a23fe68f0bede4 [1709/1739] bnxt_en: Add support for ethtool get dump. config: ia64-allmodconfig (attached as .config) compiler:

Re: [PATCH net-next] net: report netlink extack only if set

2018-08-05 Thread Willem de Bruijn
On Sun, Aug 5, 2018 at 8:37 PM David Miller wrote: > > From: Willem de Bruijn > Date: Sun, 5 Aug 2018 15:48:01 -0400 > > > From: Willem de Bruijn > > > > Initialize extack in dev_set_mtu and report only if set. > > > > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") >

Re: [PATCH net-next] tc-testing: fix ip address in u32 test

2018-08-05 Thread David Miller
From: Vlad Buslov Date: Sun, 5 Aug 2018 22:35:56 +0300 > Fix expected ip address to actually match configured ip address. > Fix test to expect single matched filter. > > Signed-off-by: Vlad Buslov > Acked-by: Jamal Hadi Salim Applied.

Re: [PATCH net-next] tc-testing: remove duplicate spaces in skbedit match patterns

2018-08-05 Thread David Miller
From: Vlad Buslov Date: Sun, 5 Aug 2018 22:37:09 +0300 > Match patterns for some skbedit tests contain duplicate whitespace that is > not present in actual tc output. This causes tests to fail because they > can't match required action, even when it was successfully created. > > Signed-off-by:

Re: [PATCH net-next] tc-testing: flush gact actions on test teardown

2018-08-05 Thread David Miller
From: Vlad Buslov Date: Sun, 5 Aug 2018 22:36:25 +0300 > Test 6fb4 creates one mirred and one pipe action, but only flushes mirred > on teardown. Leaking pipe action causes failures in other tests. > > Add additional teardown command to also flush gact actions. > > Signed-off-by: Vlad Buslov

Re: [PATCH net-next] tc-testing: remove duplicate spaces in connmark match patterns

2018-08-05 Thread David Miller
From: Vlad Buslov Date: Sun, 5 Aug 2018 22:36:44 +0300 > Match patterns for some connmark tests contain duplicate whitespace that is > not present in actual tc output. This causes tests to fail because they > can't match required action, even when it was successfully created. > > Fixes:

Re: [PATCH net-next 00/13] bnxt_en: Updates for net-next.

2018-08-05 Thread David Miller
From: Michael Chan Date: Sun, 5 Aug 2018 16:51:45 -0400 > This series includes the usual firmware spec update. The driver has > added external phy loopback test and phy setup retry logic that is > needed during hotplug. In the SRIOV space, the driver has added a > new VF resource allocation

Re: pull-request: wireless-drivers-next 2018-08-05

2018-08-05 Thread David Miller
From: Kalle Valo Date: Sun, 05 Aug 2018 20:07:16 +0300 > a pull request to net-next tree for 4.19. If the merge window doesn't > open today I'm planning to submit one more pull request later next week. > > Please let me know if you have any problems. Pulled, thanks Kalle.

Re: [PATCH net-next] net: report netlink extack only if set

2018-08-05 Thread David Miller
From: Willem de Bruijn Date: Sun, 5 Aug 2018 15:48:01 -0400 > From: Willem de Bruijn > > Initialize extack in dev_set_mtu and report only if set. > > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") > Reported-by: syzbot > Signed-off-by: Willem de Bruijn Someone

Re: [PATCH net] ip6_tunnel: use the right value for ipv4 min mtu check in ip6_tnl_xmit

2018-08-05 Thread David Miller
From: Xin Long Date: Sun, 5 Aug 2018 22:46:07 +0800 > According to RFC791, 68 bytes is the minimum size of IPv4 datagram every > device must be able to forward without further fragmentation while 576 > bytes is the minimum size of IPv4 datagram every device has to be able > to receive, so in

Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

2018-08-05 Thread David Miller
From: zhong jiang Date: Sun, 5 Aug 2018 22:18:43 +0800 > @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br, > struct sk_buff *skb_trimmed = NULL; > const unsigned char *src; > struct igmphdr *ih; > - int err; > + int err = 0; > > err =

Re: pull request: bluetooth-next 2018-08-05

2018-08-05 Thread David Miller
From: Johan Hedberg Date: Sun, 5 Aug 2018 09:14:30 +0300 > Here's the main bluetooth-next pull request for the 4.19 kernel. > > - Added support for Bluetooth Advertising Extensions > - Added vendor driver support to hci_h5 HCI driver > - Added serdev support to hci_h5 driver > - Added

Re: [PATCH net-next 0/3] mlxsw: Enable MC-aware mode for mlxsw ports

2018-08-05 Thread David Miller
From: Ido Schimmel Date: Sun, 5 Aug 2018 09:03:05 +0300 > Petr says: > > Due to an issue in Spectrum chips, when unicast traffic shares the same > queue as BUM traffic, and there is a congestion, the BUM traffic is > admitted to the queue anyway, thus pushing out all UC traffic. In order > to

Re: [PATCH net-next] virtio-net: mark expected switch fall-throughs

2018-08-05 Thread David Miller
From: "Gustavo A. R. Silva" Date: Sat, 4 Aug 2018 21:42:05 -0500 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1402059 ("Missing break in switch") > Addresses-Coverity-ID: 1402060 ("Missing break in

Re: [PATCH] mellanox: fix the dport endianness in call of __inet6_lookup_established()

2018-08-05 Thread David Miller
From: Al Viro Date: Sat, 4 Aug 2018 21:41:27 +0100 > __inet6_lookup_established() expect th->dport passed in host-endian, > not net-endian. The reason is microoptimization in __inet6_lookup(), > but if you use the lower-level helpers, you have to play by their > rules... > > Signed-off-by:

Re: [PATCH net-next] net: sched: cls_flower: Fix an error code in fl_tmplt_create()

2018-08-05 Thread David Miller
From: Dan Carpenter Date: Fri, 3 Aug 2018 22:27:55 +0300 > We forgot to set the error code on this path, so we return NULL instead > of an error pointer. In the current code kzalloc() won't fail for small > allocations so this doesn't really affect runtime. > > Fixes: b95ec7eb3b4d ("net:

Re: [PATCH][net-next] net: check extack._msg before print

2018-08-05 Thread David Miller
From: Li RongQing Date: Fri, 3 Aug 2018 15:45:21 +0800 > dev_set_mtu_ext is able to fail with a valid mtu value, at that > condition, extack._msg is not set and random since it is in stack, > then kernel will crash when print it. > > Fixes: 7a4c53bee3324a ("net: report invalid mtu value via

Re: [PATCH bpf-next 12/13] docs: net: Fix various minor typos

2018-08-05 Thread Tobin C. Harding
On Fri, Aug 03, 2018 at 10:41:12AM +0200, Daniel Borkmann wrote: > On 08/01/2018 07:09 AM, Tobin C. Harding wrote: > > There are a few minor typos and grammatical issues. We should however > > try to keep the current flavour of the document. > > > > Fix typos and grammar if glaringly required. >

Re: [Patch net] ipv6: fix double refcount of fib6_metrics

2018-08-05 Thread David Miller
From: Cong Wang Date: Thu, 2 Aug 2018 23:20:38 -0700 > All the callers of ip6_rt_copy_init()/rt6_set_from() hold refcnt > of the "from" fib6_info, so there is no need to hold fib6_metrics > refcnt again, because fib6_metrics refcnt is only released when > fib6_info is gone, that is, they have

Re: [PATCH bpf-next 05/13] docs: net: Fix indentation issues for code snippets

2018-08-05 Thread Tobin C. Harding
On Fri, Aug 03, 2018 at 10:44:23AM +0200, Daniel Borkmann wrote: > On 08/01/2018 07:09 AM, Tobin C. Harding wrote: > [...] > > -Starting bpf_dbg is trivial and just requires issuing: > > +Starting bpf_dbg is trivial and just requires issuing:: > > > > -# ./bpf_dbg > > + # ./bpf_dbg > > > >

Re: [PATCH net-next v3] ipv6: defrag: drop non-last frags smaller than min mtu

2018-08-05 Thread David Miller
From: Florian Westphal Date: Fri, 3 Aug 2018 02:22:20 +0200 > don't bother with pathological cases, they only waste cycles. > IPv6 requires a minimum MTU of 1280 so we should never see fragments > smaller than this (except last frag). > > v3: don't use awkward "-offset + len" > v2: drop IPv4

Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

2018-08-05 Thread Stephen Hemminger
On Sun, 5 Aug 2018 22:18:43 +0800 zhong jiang wrote: > The err is not used after initalization, So remove it and make > it void function. > > Signed-off-by: zhong jiang Makes sense to me. Acked-by: Stephen Hemminger

[PATCH bpf] bpf: btf: Change tools/lib/bpf/btf to LGPL

2018-08-05 Thread Martin KaFai Lau
This patch changes the tools/lib/bpf/btf.[ch] to LGPL which is inline with libbpf also. Signed-off-by: Martin KaFai Lau --- tools/lib/bpf/btf.c | 2 +- tools/lib/bpf/btf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c index

Re: Linux kernel error stack

2018-08-05 Thread Florian Westphal
Michal Kubecek wrote: > On Mon, Aug 06, 2018 at 01:15:37AM +0200, Florian Westphal wrote: > > Michal Kubecek wrote: > > > Oops, exactly this issue was already discussed almost a year ago: > > > > > > http://lkml.kernel.org/r/20170824104824.2c318a0...@unicorn.suse.cz > > > > > > But something

Re: [PATCH net-next 0/3] ip: Use rb trees for IP frag queue.

2018-08-05 Thread David Miller
From: Peter Oskolkov Date: Thu, 2 Aug 2018 22:45:57 + > This patchset > * changes IPv4 defrag behavior to match that of IPv6: overlapping >fragments now cause the whole IP datagram to be discarded (suggested >by David Miller): there are no legitimate use cases for overlapping >

Re: [PATCH net-next] net/tls: Mark the end in scatterlist table

2018-08-05 Thread David Miller
From: Vakul Garg Date: Thu, 2 Aug 2018 20:43:10 +0530 > Function zerocopy_from_iter() unmarks the 'end' in input sgtable while > adding new entries in it. The last entry in sgtable remained unmarked. > This results in KASAN error report on using apis like sg_nents(). Before > returning, the

Re: [v2, 1/3] arm64: dts: fsl: add clocks property for fman ptp timer node

2018-08-05 Thread David Miller
From: Yangbo Lu Date: Wed, 1 Aug 2018 18:05:52 +0800 > This patch is to add clocks property for fman ptp timer node. > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - None. Applied.

Re: [PATCH] ipv6: icmp: Updating pmtu for link local route

2018-08-05 Thread David Miller
From: Georg Kohmann Date: Thu, 2 Aug 2018 13:56:58 +0200 > When a ICMPV6_PKT_TOOBIG is received from a link local address the pmtu will > be updated on a route with an arbitrary interface index. Subsequent packets > sent back to the same link local address may therefore end up not > considering

Re: [v2, 3/3] ptp_qoriq: support automatic configuration for ptp timer

2018-08-05 Thread David Miller
From: Yangbo Lu Date: Wed, 1 Aug 2018 18:05:54 +0800 > This patch is to support automatic configuration for ptp timer. > If required ptp dts properties are not provided, driver could > try to calculate a set of default configurations to initialize > the ptp timer. This makes the driver work for

Re: [v2, 2/3] powerpc/mpc85xx: add clocks property for fman ptp timer node

2018-08-05 Thread David Miller
From: Yangbo Lu Date: Wed, 1 Aug 2018 18:05:53 +0800 > This patch is to add clocks property for fman ptp timer node. > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - None. Applied.

Re: Linux kernel error stack

2018-08-05 Thread Michal Kubecek
On Mon, Aug 06, 2018 at 01:15:37AM +0200, Florian Westphal wrote: > Michal Kubecek wrote: > > Oops, exactly this issue was already discussed almost a year ago: > > > > http://lkml.kernel.org/r/20170824104824.2c318a0...@unicorn.suse.cz > > > > But something more urgent came and I forgot to get

Re: [PATCH 00/21] Netfilter updates for net-next

2018-08-05 Thread David Miller
From: Pablo Neira Ayuso Date: Sun, 5 Aug 2018 23:21:20 +0200 > The following patchset contains Netfilter updates for your net-next tree: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git Pulled, thanks Pablo.

Re: KCM - recvmsg() mangles packets?

2018-08-05 Thread Dominique Martinet
Dominique Martinet wrote on Sun, Aug 05, 2018: > It's getting late but I'll try adding a pskb_pull in there tomorrow, it > would be better to make the bpf program start with an offset but I don't > think that'll be easy to change... I can confirm the following patch fixes the issue for me:

Re: Linux kernel error stack

2018-08-05 Thread Florian Westphal
Michal Kubecek wrote: > Oops, exactly this issue was already discussed almost a year ago: > > http://lkml.kernel.org/r/20170824104824.2c318a0...@unicorn.suse.cz > > But something more urgent came and I forgot to get back to it. :-( I did not even remeber, thanks for the pointer. So I think

Re: Linux kernel error stack

2018-08-05 Thread Michal Kubecek
On Sun, Aug 05, 2018 at 11:03:42PM +0200, Florian Westphal wrote: > Satish Patel wrote: > > Florian, > > > > It seems those rules coming from here > > https://github.com/openstack/openstack-ansible-os_neutron/blob/master/files/post-up-metadata-checksum > > This is crazy, and, as you found, it

Re: Linux kernel error stack

2018-08-05 Thread Florian Westphal
Satish Patel wrote: > Florian, > > It seems those rules coming from here > https://github.com/openstack/openstack-ansible-os_neutron/blob/master/files/post-up-metadata-checksum This is crazy, and, as you found, it doesn't even do what they seem to think it does. I see no reason for these rules

Re: Linux kernel error stack

2018-08-05 Thread Florian Westphal
Satish Patel wrote: > After reading further related DHCP checksum issue, it seems we need > that rules when you running DHCP on same host machine where your guest > using host DHCP service, in that case virtual nic won't do checksum. > If your DHCP running on different host then your physical nic

[PATCH net-next 02/13] bnxt_en: Adjust timer based on ethtool stats-block-usecs settings.

2018-08-05 Thread Michael Chan
The driver gathers statistics using 2 mechanisms. Some stats are DMA'ed directly from hardware and others are polled from the driver's timer. Currently, we only adjust the DMA frequency based on the ethtool stats-block-usecs setting. This patch adjusts the driver's timer frequency as well to

[PATCH net-next 05/13] bnxt_en: Add new VF resource allocation strategy mode.

2018-08-05 Thread Michael Chan
The new mode is "minimal-static" to be used when resources are more limited to support a large number of VFs, for example The PF driver will provision guaranteed minimum resources of 0. Each VF has no guranteed resources until it tries to reserve resources during device open. Signed-off-by:

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
After reading further related DHCP checksum issue, it seems we need that rules when you running DHCP on same host machine where your guest using host DHCP service, in that case virtual nic won't do checksum. If your DHCP running on different host then your physical nic perform checksum. On Sun,

[PATCH net-next 04/13] bnxt_en: Add PHY retry logic.

2018-08-05 Thread Michael Chan
During hotplug, the driver's open function can be called almost immediately after power on reset. The PHY may not be ready and the firmware may return failure when the driver tries to update PHY settings. Add retry logic fired from the driver's timer to retry the operation for 5 seconds.

[PATCH net-next 13/13] bnxt_en: Do not use the CNP CoS queue for networking traffic.

2018-08-05 Thread Michael Chan
The CNP CoS queue is reserved for internal RDMA Congestion Notification Packets (CNP) and should not be used for a TC. Modify the CoS queue discovery code to skip over the CNP CoS queue and to reduce bp->max_tc accordingly. However, if RDMA is disabled in NVRAM, the the CNP CoS queue can be used

[PATCH net-next 10/13] bnxt_en: Notify firmware about IF state changes.

2018-08-05 Thread Michael Chan
Use latest firmware API to notify firmware about IF state changes. Firmware has the option to clean up resources during IF down and to require the driver to reserve resources again during IF up. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 53

[PATCH net-next 06/13] bnxt_en: Update RSS setup and GRO-HW logic according to the latest spec.

2018-08-05 Thread Michael Chan
Set the default hash mode flag in HWRM_VNIC_RSS_CFG to signal to the firmware that the driver is compliant with the latest spec. With that, the firmware can return expanded RSS profile IDs that the driver checks to setup the proper gso_type for GRO-HW packets. But instead of checking for the new

[PATCH net-next 07/13] bnxt_en: Add support for ethtool get dump.

2018-08-05 Thread Michael Chan
From: Vasundhara Volam Add support to collect live firmware coredump via ethtool. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.h | 66 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 333 +

[PATCH net-next 03/13] bnxt_en: Add external loopback test to ethtool selftest.

2018-08-05 Thread Michael Chan
Add code to detect firmware support for external loopback and the extra test entry for external loopback. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++

[PATCH net-next 01/13] bnxt_en: Update firmware interface version to 1.9.2.25.

2018-08-05 Thread Michael Chan
New interface has firmware core dump support, new extended port statistics, and IF state change notifications to the firmware. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h |4 +- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c |8 +-

[PATCH net-next 12/13] bnxt_en: Add DCBNL DSCP application protocol support.

2018-08-05 Thread Michael Chan
Expand the .ieee_setapp() and ieee_delapp() DCBNL methods to support DSCP. This allows DSCP values to user priority mappings instead of using VLAN priorities. Each DSCP mapping is added or deleted one entry at a time using the firmware API. The firmware call can only be made from a PF.

[PATCH net-next 11/13] bnxt_en: Add hwmon sysfs support to read temperature

2018-08-05 Thread Michael Chan
From: Vasundhara Volam Export temperature sensor reading via hwmon sysfs. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/Kconfig | 8 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 62 +++

[PATCH net-next 00/13] bnxt_en: Updates for net-next.

2018-08-05 Thread Michael Chan
This series includes the usual firmware spec update. The driver has added external phy loopback test and phy setup retry logic that is needed during hotplug. In the SRIOV space, the driver has added a new VF resource allocation mode that requires the VF driver to reserve resources during IFUP.

[PATCH net-next 08/13] bnxt_en: Add BNXT_NEW_RM() macro.

2018-08-05 Thread Michael Chan
The BNXT_FLAG_NEW_RM flag is checked a lot in the code to determine if the new resource manager is in effect. Define a macro to perform this check. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 +++

[PATCH net-next 09/13] bnxt_en: Move firmware related flags to a new fw_cap field in struct bnxt.

2018-08-05 Thread Michael Chan
The flags field is almost getting full. Move firmware capability flags to a new fw_cap field to better organize these firmware flags. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 13

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
Florian, I have removed those port 80 CHECKSUM rules and everything looks good i didn't see kernel WARN mesg. Thank you so much! You just nailed it :) On Sun, Aug 5, 2018 at 4:15 PM, Satish Patel wrote: > Florian, > > It seems those rules coming from here >

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
Florian, It seems those rules coming from here https://github.com/openstack/openstack-ansible-os_neutron/blob/master/files/post-up-metadata-checksum On Sun, Aug 5, 2018 at 4:09 PM, Satish Patel wrote: > Yes this is openstack-ansible deployment tool which set them up. I am > wondering where are

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
Yes this is openstack-ansible deployment tool which set them up. I am wondering where are these rules saved? I believe openstack-ansible use LXC container to deploy services so must be part of LXC startup scripts. I have checked there is no firewalld and iptables service running on system.. You

Re: Linux kernel error stack

2018-08-05 Thread Florian Westphal
Satish Patel wrote: > > [84166:59495417] -A POSTROUTING -p tcp -m tcp --sport 80 -j CHECKSUM > > --checksum-fill > > [68739:5153476] -A POSTROUTING -p tcp -m tcp --sport 8000 -j CHECKSUM > > --checksum-fill These rules make no sense to me, and are also source of your backtrace. Who set this up?

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
I am configured where are those rules stored why iptables -L -n -t nat not showing them? On Sun, Aug 5, 2018 at 3:56 PM, Satish Patel wrote: > Oh wait!! I think you are right there i didn't notice that iptables > has following setting. > > "CHECKSUM --checksum-fill" > > On Sun, Aug 5, 2018 at

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
Oh wait!! I think you are right there i didn't notice that iptables has following setting. "CHECKSUM --checksum-fill" On Sun, Aug 5, 2018 at 3:54 PM, Satish Patel wrote: > I have following kernel logging set. > > [root@ostack-infra-02 tools]# cat /proc/sys/kernel/printk > 3 4 1 3 > > > iptables

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
I have following kernel logging set. [root@ostack-infra-02 tools]# cat /proc/sys/kernel/printk 3 4 1 3 iptables output [root@ostack-infra-02 tools]# iptables-save -c # Generated by iptables-save v1.4.21 on Sun Aug 5 15:52:56 2018 *raw :PREROUTING ACCEPT [42284573:38782693391] :OUTPUT ACCEPT

[PATCH net-next] net: report netlink extack only if set

2018-08-05 Thread Willem de Bruijn
From: Willem de Bruijn Initialize extack in dev_set_mtu and report only if set. Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack") Reported-by: syzbot Signed-off-by: Willem de Bruijn --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: Linux kernel error stack

2018-08-05 Thread Florian Westphal
Satish Patel wrote: > Thanks Florian, > > FYI, I don't have any CHECKSUM configure in my iptables, You have, according to WARN stacktrace you provided. iptables-save -c ip6tables-save -c

[PATCH net-next] tc-testing: remove duplicate spaces in skbedit match patterns

2018-08-05 Thread Vlad Buslov
Match patterns for some skbedit tests contain duplicate whitespace that is not present in actual tc output. This causes tests to fail because they can't match required action, even when it was successfully created. Signed-off-by: Vlad Buslov Acked-by: Jamal Hadi Salim ---

[PATCH net-next] tc-testing: remove duplicate spaces in connmark match patterns

2018-08-05 Thread Vlad Buslov
Match patterns for some connmark tests contain duplicate whitespace that is not present in actual tc output. This causes tests to fail because they can't match required action, even when it was successfully created. Fixes: 1dad0f97 ("tc-testing: add connmark action tests") Signed-off-by: Vlad

[PATCH net-next] tc-testing: flush gact actions on test teardown

2018-08-05 Thread Vlad Buslov
Test 6fb4 creates one mirred and one pipe action, but only flushes mirred on teardown. Leaking pipe action causes failures in other tests. Add additional teardown command to also flush gact actions. Signed-off-by: Vlad Buslov Acked-by: Jamal Hadi Salim ---

[PATCH net-next] tc-testing: fix ip address in u32 test

2018-08-05 Thread Vlad Buslov
Fix expected ip address to actually match configured ip address. Fix test to expect single matched filter. Signed-off-by: Vlad Buslov Acked-by: Jamal Hadi Salim --- tools/testing/selftests/tc-testing/tc-tests/filters/tests.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[RFC] weirdness in cxgb3_main.c:init_tp_parity()

2018-08-05 Thread Al Viro
for (i = 0; i < 2048; i++) { ... req->l2t_idx = htonl(V_L2T_W_IDX(i)); ... in there is very odd; l2t_idx is a 16bit field, and #define V_L2T_W_IDX(x) ((x) << S_L2T_W_IDX) #define S_L2T_W_IDX0 IOW, we are taking htonl(something in range 0..2047) and shove it

[endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

2018-08-05 Thread Al Viro
Unlike fs.val.lport and fs.val.fport, cxgb4_process_flow_match() sets fs.val.{l,f}ip to net-endian values without conversion - they come straight from flow_dissector_key_ipv4_addrs ->dst and ->src resp. So the assignment in mk_act_open_req() ought to be a straigh copy. As far as

Re: [endianness bug?] cxgb4_next_header .match_val/.match_mask should be net-endian

2018-08-05 Thread Al Viro
On Sun, Aug 05, 2018 at 04:28:11PM +0100, Al Viro wrote: > On little-endian host those do yield the right values - e.g. 0x1100 is > {0, 17, 0, 0}, etc. On big-endian, though, these will end up checking > in IPv4 case the octet at offset 10 (i.e. upper 16 bits of checksum) and for > IPv6 > - the

[endianness bug?] cxgb4_next_header .match_val/.match_mask should be net-endian

2018-08-05 Thread Al Viro
AFAICS, cxgb4_next_header() expects to find match_val/match_mask in struct cxgb4_next_header stored as big-endian: /* Found a possible candidate. Find a key that * matches the corresponding offset, value, and *

Re: consequences of setting net_device_ops ndo_change_carrier()?

2018-08-05 Thread Andrew Lunn
> > You should have a PHY device of some sort. Either a traditional > > copper PHY, or an SFP module. There should be a driver for this PHY. > > This could be one of those in drivers/net/phy. Or it could be > > firmware running, running on a little microcontroller inside your > > FPGA? > > in

[PATCH net] ip6_tunnel: use the right value for ipv4 min mtu check in ip6_tnl_xmit

2018-08-05 Thread Xin Long
According to RFC791, 68 bytes is the minimum size of IPv4 datagram every device must be able to forward without further fragmentation while 576 bytes is the minimum size of IPv4 datagram every device has to be able to receive, so in ip6_tnl_xmit(), 68(IPV4_MIN_MTU) should be the right value for

Re: KCM - recvmsg() mangles packets?

2018-08-05 Thread Dominique Martinet
Dominique Martinet wrote on Sun, Aug 05, 2018: > (I'm not sure about offset, since we pass the full skb to parse message, > wouldn't it look at the start of the buffer everytime? Well, offset > seems to be 0 everytime the first time that check fails so I can > probably ignore that for now...) Oh,

Re: Linux kernel error stack

2018-08-05 Thread Satish Patel
Thanks Florian, FYI, I don't have any CHECKSUM configure in my iptables, i have following rules, also do you think this kernel WARNNING is just warning and not impacting my performance, based on that i have to decided criticality of this issue. [root@ostack-infra-02 ~]# iptables -L -n Chain

Re: [PATCH net] l2tp: fix missing refcount drop in pppol2tp_tunnel_ioctl()

2018-08-05 Thread Guillaume Nault
On Fri, Aug 03, 2018 at 12:42:22PM -0700, David Miller wrote: > From: Guillaume Nault > Date: Fri, 3 Aug 2018 17:00:11 +0200 > > > If 'session' is not NULL and is not a PPP pseudo-wire, then we fail to > > drop the reference taken by l2tp_session_get(). > > > > Fixes: ecd012e45ab5 ("l2tp:

Re: consequences of setting net_device_ops ndo_change_carrier()?

2018-08-05 Thread Robert P. J. Day
On Sun, 5 Aug 2018, Andrew Lunn wrote: > On Sat, Aug 04, 2018 at 07:06:58AM -0400, Robert P. J. Day wrote: > > > > i'll try to keep this (relatively) short as there may be a > > simple answer to this, or it could just be a stupid question -- > > sort of related to previous question (thank you,

Re: Linux kernel error stack

2018-08-05 Thread Florian Westphal
Satish Patel wrote: > I am installing openstack and as you know i have lots of bridges and > vlan interface on my Linux CentOS 7.5 > > I was getting following error stack on 3.10 kernel and found this is > kernel bug which required kernel upgrade so now i have upgraded my > kernel to 4.17.12 but

Re: KCM - recvmsg() mangles packets?

2018-08-05 Thread Dominique Martinet
Dominique Martinet wrote on Sat, Aug 04, 2018: > I talked too fast, I can get this to fail on later packets e.g. > Got 18, expected 31 on 452nd message: 453453453453453453; flags: 80 > > The content is 453 in a loop so this really is the 453rd packet... > > But being slower e.g. doing that

pull request: bluetooth-next 2018-08-05

2018-08-05 Thread Johan Hedberg
Hi Dave, Here's the main bluetooth-next pull request for the 4.19 kernel. - Added support for Bluetooth Advertising Extensions - Added vendor driver support to hci_h5 HCI driver - Added serdev support to hci_h5 driver - Added support for Qualcomm wcn3990 controller - Added support for

[PATCH net-next 3/3] mlxsw: spectrum: Configure MC-aware mode on mlxsw ports

2018-08-05 Thread Ido Schimmel
From: Petr Machata In order to give unicast traffic precedence over BUM traffic, configure multicast-aware mode on all ports. Under multicast-aware regime, when assigning traffic class to a packet, the switch doesn't merely take the value prescribed by the QTCT register. For BUM traffic, it

[PATCH net-next 2/3] mlxsw: spectrum: Fix a typo

2018-08-05 Thread Ido Schimmel
From: Petr Machata Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c

[PATCH net-next 0/3] mlxsw: Enable MC-aware mode for mlxsw ports

2018-08-05 Thread Ido Schimmel
Petr says: Due to an issue in Spectrum chips, when unicast traffic shares the same queue as BUM traffic, and there is a congestion, the BUM traffic is admitted to the queue anyway, thus pushing out all UC traffic. In order to give unicast traffic precedence over BUM traffic, configure

[PATCH net-next 1/3] mlxsw: reg: Add QoS Switch Traffic Class Table is Multicast-Aware Register

2018-08-05 Thread Ido Schimmel
From: Petr Machata This register configures if the Switch Priority to Traffic Class mapping is based on Multicast packet indication. If so, then multicast packets will get a Traffic Class that is plus (cap_max_tclass_data/2) the value configured by QTCT. Signed-off-by: Petr Machata