Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread maowenan
On 2018/8/17 0:06, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at 05:24:09PM +0200, Greg KH wrote: >> On Thu, Aug 16, 2018 at 02:33:56PM +0200, Michal Kubecek wrote: >>> >>> Anyway, even at this rate, I only get ~10% of one core (Intel E5-2697). >>> >>> What I can see, though, is that with

Re: bnxt: card intermittently hanging and dropping link

2018-08-16 Thread Michael Chan
On Thu, Aug 16, 2018 at 2:09 AM, Daniel Axtens wrote: > Hi Michael, > >> The main issue is the TX timeout. >> . >> >>> [ 2682.911693] bnxt_en :3b:00.0 eth4: TX timeout detected, starting >>> reset task! >>> [ 2683.782496] bnxt_en :3b:00.0 eth4: Resp cmpl intr err msg: 0x51 >>> [

KINDLY REPLY diplmos...@gmail.com URGENTLY

2018-08-16 Thread MR MOSES
KINDLY REPLY diplmos...@gmail.com URGENTLY

Re: [PATCH] r8169: don't use MSI-X on RTL8106e

2018-08-16 Thread Jian-Hong Pan
2018-08-17 2:59 GMT+08:00 Heiner Kallweit : >> From: Jian-Hong Pan >> >> Found the ethernet network on ASUS X441UAR doesn't come back on resume >> from suspend when using MSI-X. The chip is RTL8106e - version 39. >> > The patch itself looks good, just the commit message is wrong in one > place

Re: Under what conditions is phy_device "adjust_link()" called?

2018-08-16 Thread Andrew Lunn
On Thu, Aug 16, 2018 at 11:59:19AM -0700, Florian Fainelli wrote: > On 08/16/2018 10:26 AM, rpj...@crashcourse.ca wrote: > > > > I can see from the documentation that the callback adjust_link() is invoked > > "for the enet controller to respond to changes in the link state." Is there > > a

Re: [bpf-next RFC 1/3] flow_dissector: implements flow dissector BPF hook

2018-08-16 Thread Petar Penkov
On Thu, Aug 16, 2018 at 3:40 PM, Song Liu wrote: > > On Thu, Aug 16, 2018 at 9:44 AM, Petar Penkov wrote: > > From: Petar Penkov > > > > Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and > > attach type BPF_FLOW_DISSECTOR that is executed in the flow dissector > > path. The BPF

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

2018-08-16 Thread Russell King - ARM Linux
On Thu, Aug 16, 2018 at 10:35:16PM +0200, Marc Haber wrote: > On Mon, Jun 25, 2018 at 05:41:27PM +0100, Peter Robinson wrote: > > So with that and the other fix there was no improvement, with those > > and the BPF JIT disabled it works, I'm not sure if the two patches > > have any effect with the

Re: [bpf-next RFC 1/3] flow_dissector: implements flow dissector BPF hook

2018-08-16 Thread Song Liu
On Thu, Aug 16, 2018 at 9:44 AM, Petar Penkov wrote: > From: Petar Penkov > > Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and > attach type BPF_FLOW_DISSECTOR that is executed in the flow dissector > path. The BPF program is kept as a global variable so it is > accessible to

Re: [bpf-next RFC 1/3] flow_dissector: implements flow dissector BPF hook

2018-08-16 Thread Willem de Bruijn
On Thu, Aug 16, 2018 at 2:51 PM Edward Cree wrote: > > On 16/08/18 17:44, Petar Penkov wrote: > > From: Petar Penkov > > > > Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and > > attach type BPF_FLOW_DISSECTOR that is executed in the flow dissector > > path. The BPF program is

Re: [PATCH bpf 0/5] BPF sockmap and ulp fixes

2018-08-16 Thread Alexei Starovoitov
On Thu, Aug 16, 2018 at 09:49:05PM +0200, Daniel Borkmann wrote: > Batch of various fixes related to BPF sockmap and ULP, including > adding module alias to restrict module requests, races and memory > leaks in sockmap code. For details please refer to the individual > patches. Thanks! Applied to

Re: [PATCH bpf 5/5] bpf, sockmap: fix sock_map_ctx_update_elem race with exist/noexist

2018-08-16 Thread Song Liu
On Thu, Aug 16, 2018 at 12:49 PM, Daniel Borkmann wrote: > The current code in sock_map_ctx_update_elem() allows for BPF_EXIST > and BPF_NOEXIST map update flags. While on array-like maps this approach > is rather uncommon, e.g. bpf_fd_array_map_update_elem() and others > enforce map update flags

KINDLY REPLY diplmos...@gmail.com URGENTLY

2018-08-16 Thread MR MOSES
KINDLY REPLY diplmos...@gmail.com URGENTLY

Re: [Intel-wired-lan] [PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

2018-08-16 Thread Shannon Nelson
On 8/16/2018 2:15 PM, Alexander Duyck wrote: On Tue, Aug 14, 2018 at 10:10 AM Shannon Nelson wrote: On 8/14/2018 8:30 AM, Alexander Duyck wrote: On Mon, Aug 13, 2018 at 11:43 AM Shannon Nelson wrote: This set of patches implements IPsec hardware offload for VF devices in Intel's 10Gbe

RE: [PATCH v2 net-next 0/8] net: dsa: microchip: Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers

2018-08-16 Thread Tristram.Ha
> -Original Message- > From: Florian Fainelli > Sent: Wednesday, August 15, 2018 5:29 PM > To: Tristram Ha - C24268 ; Andrew Lunn > ; Pavel Machek ; Ruediger Schmitt > > Cc: Arkadi Sharshevsky ; UNGLinuxDriver > ; netdev@vger.kernel.org > Subject: Re: [PATCH v2 net-next 0/8] net: dsa:

Re: [PATCH bpf 4/5] bpf, sockmap: fix map elem deletion race with smap_stop_sock

2018-08-16 Thread Song Liu
On Thu, Aug 16, 2018 at 12:49 PM, Daniel Borkmann wrote: > The smap_start_sock() and smap_stop_sock() are each protected under > the sock->sk_callback_lock from their call-sites except in the case > of sock_map_delete_elem() where we drop the old socket from the map > slot. This is racy because

Re: [PATCH bpf 3/5] bpf, sockmap: fix leakage of smap_psock_map_entry

2018-08-16 Thread Song Liu
On Thu, Aug 16, 2018 at 12:49 PM, Daniel Borkmann wrote: > While working on sockmap I noticed that we do not always kfree the > struct smap_psock_map_entry list elements which track psocks attached > to maps. In the case of sock_hash_ctx_update_elem(), these map entries > are allocated outside of

Re: [PATCH bpf 2/5] tcp, ulp: fix leftover icsk_ulp_ops preventing sock from reattach

2018-08-16 Thread Song Liu
On Thu, Aug 16, 2018 at 12:49 PM, Daniel Borkmann wrote: > I found that in BPF sockmap programs once we either delete a socket > from the map or we updated a map slot and the old socket was purged > from the map that these socket can never get reattached into a map > even though their related

Re: [PATCH bpf 1/5] tcp, ulp: add alias for all ulp modules

2018-08-16 Thread Song Liu
On Thu, Aug 16, 2018 at 12:49 PM, Daniel Borkmann wrote: > Lets not turn the TCP ULP lookup into an arbitrary module loader as > we only intend to load ULP modules through this mechanism, not other > unrelated kernel modules: > > [root@bar]# cat foo.c > #include > #include > #include >

Re: [Intel-wired-lan] [PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

2018-08-16 Thread Alexander Duyck
On Tue, Aug 14, 2018 at 10:10 AM Shannon Nelson wrote: > > On 8/14/2018 8:30 AM, Alexander Duyck wrote: > > On Mon, Aug 13, 2018 at 11:43 AM Shannon Nelson > > wrote: > >> > >> This set of patches implements IPsec hardware offload for VF devices in > >> Intel's 10Gbe x540 family of Ethernet

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-08-16 Thread Stefano Brivio
Pravin, On Wed, 15 Aug 2018 00:19:39 -0700 Pravin Shelar wrote: > My argument is not about proposed fairness algorithm. It is about cost > of the fairness and I do not see it is addressed in any of the follow > ups. We are still working on it (especially on the points that you mentioned

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

2018-08-16 Thread Marc Haber
On Mon, Jun 25, 2018 at 05:41:27PM +0100, Peter Robinson wrote: > So with that and the other fix there was no improvement, with those > and the BPF JIT disabled it works, I'm not sure if the two patches > have any effect with the JIT disabled though. I can confirm the crash with the released

[PATCH] Revert "net/smc: Replace ib_query_gid with rdma_get_gid_attr"

2018-08-16 Thread Jason Gunthorpe
This reverts commit ddb457c6993babbcdd41fca638b870d2a2fc3941. The include rdma/ib_cache.h is kept, and we have to add a memset to the compat wrapper to avoid compiler warnings in gcc-7 This revert is done to avoid extensive merge conflicts with SMC changes in netdev during the 4.19 merge window.

[PATCH bpf 4/5] bpf, sockmap: fix map elem deletion race with smap_stop_sock

2018-08-16 Thread Daniel Borkmann
The smap_start_sock() and smap_stop_sock() are each protected under the sock->sk_callback_lock from their call-sites except in the case of sock_map_delete_elem() where we drop the old socket from the map slot. This is racy because the same sock could be part of multiple sock maps, so we run

[PATCH bpf 2/5] tcp, ulp: fix leftover icsk_ulp_ops preventing sock from reattach

2018-08-16 Thread Daniel Borkmann
I found that in BPF sockmap programs once we either delete a socket from the map or we updated a map slot and the old socket was purged from the map that these socket can never get reattached into a map even though their related psock has been dropped entirely at that point. Reason is that

[PATCH bpf 1/5] tcp, ulp: add alias for all ulp modules

2018-08-16 Thread Daniel Borkmann
Lets not turn the TCP ULP lookup into an arbitrary module loader as we only intend to load ULP modules through this mechanism, not other unrelated kernel modules: [root@bar]# cat foo.c #include #include #include #include int main(void) { int sock = socket(PF_INET,

[PATCH bpf 5/5] bpf, sockmap: fix sock_map_ctx_update_elem race with exist/noexist

2018-08-16 Thread Daniel Borkmann
The current code in sock_map_ctx_update_elem() allows for BPF_EXIST and BPF_NOEXIST map update flags. While on array-like maps this approach is rather uncommon, e.g. bpf_fd_array_map_update_elem() and others enforce map update flags to be BPF_ANY such that xchg() can be used directly, the current

[PATCH bpf 0/5] BPF sockmap and ulp fixes

2018-08-16 Thread Daniel Borkmann
Batch of various fixes related to BPF sockmap and ULP, including adding module alias to restrict module requests, races and memory leaks in sockmap code. For details please refer to the individual patches. Thanks! Daniel Borkmann (5): tcp, ulp: add alias for all ulp modules tcp, ulp: fix

[PATCH bpf 3/5] bpf, sockmap: fix leakage of smap_psock_map_entry

2018-08-16 Thread Daniel Borkmann
While working on sockmap I noticed that we do not always kfree the struct smap_psock_map_entry list elements which track psocks attached to maps. In the case of sock_hash_ctx_update_elem(), these map entries are allocated outside of __sock_map_ctx_update_elem() with their linkage to the socket

Re: phylib: Any PHY which reports link up during autoneg ?

2018-08-16 Thread Heiner Kallweit
On 16.08.2018 21:21, Florian Fainelli wrote: > On 08/16/2018 12:15 PM, Heiner Kallweit wrote: >> When reading through the state machine code in phy.c I wondered whether >> there is any PHY which reports the link as up during autonegotiation. >> (It's about handling PHY_AN in the state machine,

Re: [PATCH v3] net/mlx5e: Delete unneeded function argument

2018-08-16 Thread David Miller
From: Yuval Shaia Date: Thu, 16 Aug 2018 12:02:20 +0300 > priv argument is not used by the function, delete it. > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > Signed-off-by: Yuval Shaia > --- > v1 -> v2: > * Remove blank line as pointed by Leon. > > v2 -> v3:

Re: [PATCH] net: dsa: add support for ksz9897 ethernet switch

2018-08-16 Thread David Miller
From: Lad Prabhakar Date: Wed, 15 Aug 2018 16:51:23 +0100 > From: "Lad, Prabhakar" > > ksz9477 is superset of ksz9xx series, driver just works > out of the box for ksz9897 chip with this patch. > > Signed-off-by: Lad, Prabhakar Since this is just adding chip IDs and such, this can go in

Re: [PATCH v3 net-next] veth: Free queues on link delete

2018-08-16 Thread David Miller
From: Toshiaki Makita Date: Wed, 15 Aug 2018 17:07:29 +0900 > David Ahern reported memory leak in veth. ... > veth_rq allocated in veth_newlink() was not freed on dellink. > > We need to free up them after veth_close() so that any packets will not > reference the queues afterwards. Thus free

Re: phylib: Any PHY which reports link up during autoneg ?

2018-08-16 Thread Florian Fainelli
On 08/16/2018 12:15 PM, Heiner Kallweit wrote: > When reading through the state machine code in phy.c I wondered whether > there is any PHY which reports the link as up during autonegotiation. > (It's about handling PHY_AN in the state machine, once we know the link > is up we still check whether

Re: [PATCH] r8169: don't use MSI-X on RTL8106e

2018-08-16 Thread Heiner Kallweit
On 16.08.2018 20:59, Heiner Kallweit wrote: >> From: Jian-Hong Pan >> >> Found the ethernet network on ASUS X441UAR doesn't come back on resume >> from suspend when using MSI-X. The chip is RTL8106e - version 39. >> > The patch itself looks good, just the commit message is wrong in one > place

[PATCH] net: nixge: Add support for 64-bit platforms

2018-08-16 Thread Moritz Fischer
Add support for 64-bit platforms to driver. The hardware only supports 32-bit register accesses so the accesses need to be split up into two writes when setting the current and tail descriptor values. Cc: Florian Fainelli Signed-off-by: Moritz Fischer --- Changes from RFC: - Work around

phylib: Any PHY which reports link up during autoneg ?

2018-08-16 Thread Heiner Kallweit
When reading through the state machine code in phy.c I wondered whether there is any PHY which reports the link as up during autonegotiation. (It's about handling PHY_AN in the state machine, once we know the link is up we still check whether aneg was completed. Is this needed?) At least the

Re: [Patch net-next] ila: make lockdep happy again

2018-08-16 Thread David Miller
From: Cong Wang Date: Tue, 14 Aug 2018 15:21:31 -0700 > Previously, alloc_ila_locks() and bucket_table_alloc() call > spin_lock_init() separately, therefore they have two different > lock names and lock class keys. However, after commit b893281715ab > ("ila: Call library function

Re: [PATCH net-next] net: sched: act_ife: always release ife action on init error

2018-08-16 Thread David Miller
From: Vlad Buslov Date: Tue, 14 Aug 2018 20:29:56 +0300 > Action init API was changed to always take reference to action, even when > overwriting existing action. Substitute conditional action release, which > was executed only if action is newly created, with unconditional release in >

Re: [PATCH net] cls_matchall: fix tcf_unbind_filter missing

2018-08-16 Thread David Miller
From: Hangbin Liu Date: Tue, 14 Aug 2018 17:28:26 +0800 > Fix tcf_unbind_filter missing in cls_matchall as this will trigger > WARN_ON() in cbq_destroy_class(). > > Fixes: fd62d9f5c575f ("net/sched: matchall: Fix configuration race") > Reported-by: Li Shuang > Signed-off-by: Hangbin Liu

Re: Under what conditions is phy_device "adjust_link()" called?

2018-08-16 Thread Florian Fainelli
On 08/16/2018 10:26 AM, rpj...@crashcourse.ca wrote: > > I can see from the documentation that the callback adjust_link() is invoked > "for the enet controller to respond to changes in the link state." Is there > a specific list of the events that would generate such a change? Are we > talking

Re: [PATCH] r8169: don't use MSI-X on RTL8106e

2018-08-16 Thread Heiner Kallweit
> From: Jian-Hong Pan > > Found the ethernet network on ASUS X441UAR doesn't come back on resume > from suspend when using MSI-X. The chip is RTL8106e - version 39. > The patch itself looks good, just the commit message is wrong in one place and a little bit long. > asus@endless:~$ dmesg |

Re: [PATCH ethtool v2 0/3] ethtool: Wake-on-LAN using filters

2018-08-16 Thread John W. Linville
On Thu, Aug 09, 2018 at 11:03:59AM -0700, Florian Fainelli wrote: > Hi John, > > This patch series syncs up ethtool-copy.h to get the new definitions > required for supporting wake-on-LAN using filters: WAKE_FILTER and > RX_CLS_FLOW_WAKE and then updates the rxclass.c code to allow us to >

Re: [bpf-next RFC 1/3] flow_dissector: implements flow dissector BPF hook

2018-08-16 Thread Edward Cree
On 16/08/18 17:44, Petar Penkov wrote: > From: Petar Penkov > > Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and > attach type BPF_FLOW_DISSECTOR that is executed in the flow dissector > path. The BPF program is kept as a global variable so it is > accessible to all flow

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-08-16 Thread Steve Wise
On 8/16/2018 1:26 PM, Sagi Grimberg wrote: > >> Let me know if you want me to try this or any particular fix. > > Steve, can you test this one? Yes!  I'll try it out tomorrow.  Stevo > -- > [PATCH rfc] block: fix rdma queue mapping > > nvme-rdma attempts to map queues based on irq vector

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-08-16 Thread Sagi Grimberg
Let me know if you want me to try this or any particular fix. Steve, can you test this one? -- [PATCH rfc] block: fix rdma queue mapping nvme-rdma attempts to map queues based on irq vector affinity. However, for some devices, completion vector irq affinity is configurable by the user which

Re: [iproute PATCH 00/10] Review help texts and man pages

2018-08-16 Thread Stephen Hemminger
On Thu, 16 Aug 2018 12:27:52 +0200 Phil Sutter wrote: > This series fixes a number of issues identified by an automated scan > over man pages and help texts. > > Phil Sutter (10): > man: bridge.8: Document -oneline option > bridge: trivial: Make help text consistent > devlink: trivial:

Under what conditions is phy_device "adjust_link()" called?

2018-08-16 Thread rpjday
I can see from the documentation that the callback adjust_link() is invoked "for the enet controller to respond to changes in the link state." Is there a specific list of the events that would generate such a change? Are we talking initially opening the device, ifup/ifdown, physically

[bpf-next RFC 1/3] flow_dissector: implements flow dissector BPF hook

2018-08-16 Thread Petar Penkov
From: Petar Penkov Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and attach type BPF_FLOW_DISSECTOR that is executed in the flow dissector path. The BPF program is kept as a global variable so it is accessible to all flow dissectors. Signed-off-by: Petar Penkov Signed-off-by:

[bpf-next RFC 2/3] flow_dissector: implements eBPF parser

2018-08-16 Thread Petar Penkov
From: Petar Penkov This eBPF program extracts basic/control/ip address/ports keys from incoming packets. It supports recursive parsing for IP encapsulation, MPLS, GUE, and VLAN, along with IPv4/IPv6 and extension headers. This program is meant to show how flow dissection and key extraction can

[bpf-next RFC 3/3] selftests/bpf: test bpf flow dissection

2018-08-16 Thread Petar Penkov
From: Petar Penkov Adds a test that sends different types of packets over multiple tunnels and verifies that valid packets are dissected correctly. To do so, a tc-flower rule is added to drop packets on UDP src port 9, and packets are sent from ports 8, 9, and 10. Only the packets on port 9

[bpf-next RFC 0/3] Introduce eBPF flow dissector

2018-08-16 Thread Petar Penkov
From: Petar Penkov This patch series hardens the RX stack by allowing flow dissection in BPF, as previously discussed [1]. Because of the rigorous checks of the BPF verifier, this provides significant security guarantees. In particular, the BPF flow dissector cannot get inside of an infinite

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Greg KH
On Thu, Aug 16, 2018 at 06:06:16PM +0200, Michal Kubecek wrote: > > If not, we can go from there and evaluate this much larger patch > > series. But let's try the simple thing first. > > At high packet rates (say 30K pkt/s and more), we can still saturate the > CPU. This is also mentioned in the

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Michal Kubecek
On Thu, Aug 16, 2018 at 05:24:09PM +0200, Greg KH wrote: > On Thu, Aug 16, 2018 at 02:33:56PM +0200, Michal Kubecek wrote: > > > > Anyway, even at this rate, I only get ~10% of one core (Intel E5-2697). > > > > What I can see, though, is that with current stable 4.4 code, modified > > testcase

RE: TJA1100 100Base-T1 PHY features via ethtool?

2018-08-16 Thread Woojung.Huh
Hi Florian & Michael, > > ethtool is being converted to netlink, and that will be a much more > > flexible interface to work with since it is basically easily extensible > > (unlike the current ethtool + ioctl approach). > > Yes, netlink sounds absolutely more useful here. Is ethtool + netlink

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Greg KH
On Thu, Aug 16, 2018 at 02:33:56PM +0200, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at 08:05:50PM +0800, maowenan wrote: > > On 2018/8/16 19:39, Michal Kubecek wrote: > > > > > > I suspect you may be doing something wrong with your tests. I checked > > > the segmentsmack testcase and the CPU

Re: [iproute PATCH v4] Make colored output configurable

2018-08-16 Thread Phil Sutter
On Thu, Aug 16, 2018 at 07:06:07AM -0600, David Ahern wrote: > On 8/16/18 3:37 AM, Phil Sutter wrote: > > Allow for -color={never,auto,always} to have colored output disabled, > > enabled only if stdout is a terminal or enabled regardless of stdout > > state. > > > > Signed-off-by: Phil Sutter >

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-16 Thread Andrew Lunn
On Thu, Aug 16, 2018 at 08:54:40AM +0200, Ahmad Fatoum wrote: > On 08/15/2018 04:32 AM, Andrew Lunn wrote: > > Ahmed, where is the device tree for the EVB-KSZ9477? > > I've attached it [1]. It's still work-in-progress (DSA doesn't work yet for > example), but Ethernet is usable with Linux v4.18

Re: [iproute PATCH v4] Make colored output configurable

2018-08-16 Thread David Ahern
On 8/16/18 3:37 AM, Phil Sutter wrote: > Allow for -color={never,auto,always} to have colored output disabled, > enabled only if stdout is a terminal or enabled regardless of stdout > state. > > Signed-off-by: Phil Sutter > --- > Changes since v1: > - Allow to override isatty() check by

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Michal Kubecek
On Thu, Aug 16, 2018 at 08:05:50PM +0800, maowenan wrote: > On 2018/8/16 19:39, Michal Kubecek wrote: > > > > I suspect you may be doing something wrong with your tests. I checked > > the segmentsmack testcase and the CPU utilization on receiving side > > (with sending 10 times as many packets as

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread maowenan
On 2018/8/16 19:39, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at 03:55:16PM +0800, maowenan wrote: >> On 2018/8/16 15:44, Michal Kubecek wrote: >>> On Thu, Aug 16, 2018 at 03:39:14PM +0800, maowenan wrote: On 2018/8/16 15:23, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-16 Thread Eelco Chaudron
On 11 Aug 2018, at 21:06, David Miller wrote: From: Jakub Kicinski Date: Thu, 9 Aug 2018 20:26:08 -0700 It is not immediately clear why this is needed. The memory and updating two sets of counters won't come for free, so perhaps a stronger justification than troubleshooting is due? :S

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Michal Kubecek
On Thu, Aug 16, 2018 at 03:55:16PM +0800, maowenan wrote: > On 2018/8/16 15:44, Michal Kubecek wrote: > > On Thu, Aug 16, 2018 at 03:39:14PM +0800, maowenan wrote: > >> > >> > >> On 2018/8/16 15:23, Michal Kubecek wrote: > >>> On Thu, Aug 16, 2018 at 03:19:12PM +0800, maowenan wrote: > On

Re: [PATCH v3] net/mlx5e: Delete unneeded function argument

2018-08-16 Thread Leon Romanovsky
On Thu, Aug 16, 2018 at 12:02:20PM +0300, Yuval Shaia wrote: > priv argument is not used by the function, delete it. > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > Signed-off-by: Yuval Shaia > --- > v1 -> v2: > * Remove blank line as pointed by Leon. > > v2 -> v3:

Re: [PATCH v2] net/mlx5: Delete unneeded function argument

2018-08-16 Thread Gal Pressman
On 16-Aug-18 12:00, Yuval Shaia wrote: > On Thu, Aug 16, 2018 at 09:41:34AM +0300, Gal Pressman wrote: >> On 15-Aug-18 18:08, Yuval Shaia wrote: >>> priv argument is not used by the function, delete it. >>> >>> Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") >>> Signed-off-by:

[iproute PATCH 04/10] man: devlink.8: Document -verbose option

2018-08-16 Thread Phil Sutter
This was the only bit missing in comparison to devlink help text. Signed-off-by: Phil Sutter --- man/man8/devlink.8 | 4 1 file changed, 4 insertions(+) diff --git a/man/man8/devlink.8 b/man/man8/devlink.8 index ac61b6add7fba..360031f77c165 100644 --- a/man/man8/devlink.8 +++

[iproute PATCH 00/10] Review help texts and man pages

2018-08-16 Thread Phil Sutter
This series fixes a number of issues identified by an automated scan over man pages and help texts. Phil Sutter (10): man: bridge.8: Document -oneline option bridge: trivial: Make help text consistent devlink: trivial: Make help text consistent man: devlink.8: Document -verbose option

[iproute PATCH 02/10] bridge: trivial: Make help text consistent

2018-08-16 Thread Phil Sutter
Change curly braces into brackets for -json option in help text to be consistent with the rest. Signed-off-by: Phil Sutter --- bridge/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bridge/bridge.c b/bridge/bridge.c index e35e5bdf7fb30..04d84163e68c4 100644 ---

[iproute PATCH 05/10] genl: Fix help text

2018-08-16 Thread Phil Sutter
The '| help' part was misleading: In fact, 'genl help' does not work but 'genl help' does. Fix the help text to make that clear. In addition to that, list -Version and -help flags as well. Signed-off-by: Phil Sutter --- genl/genl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[iproute PATCH 10/10] man: ss.8: Describe --events option

2018-08-16 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/ss.8 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/man/man8/ss.8 b/man/man8/ss.8 index 28033d8f01dda..7a6572b173648 100644 --- a/man/man8/ss.8 +++ b/man/man8/ss.8 @@ -242,6 +242,9 @@ Print summary statistics. This option does not parse socket

[iproute PATCH 09/10] rtmon: List options in help text

2018-08-16 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/rtmon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ip/rtmon.c b/ip/rtmon.c index acc11df49b423..0e795f740e627 100644 --- a/ip/rtmon.c +++ b/ip/rtmon.c @@ -63,7 +63,9 @@ static int dump_msg2(const struct sockaddr_nl *who, static

[iproute PATCH 03/10] devlink: trivial: Make help text consistent

2018-08-16 Thread Phil Sutter
Typically the part of the flag in brackets completes the leading part instead of repeating it. Signed-off-by: Phil Sutter --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index 784bb84bf7ad6..519ee2577cc4c 100644 ---

[iproute PATCH 07/10] ip: Add missing -M flag to help text

2018-08-16 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/ip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ip.c b/ip/ip.c index 893c3c43ef99a..93382d671f467 100644 --- a/ip/ip.c +++ b/ip/ip.c @@ -55,7 +55,7 @@ static void usage(void) " OPTIONS := { -V[ersion] | -s[tatistics] |

[iproute PATCH 01/10] man: bridge.8: Document -oneline option

2018-08-16 Thread Phil Sutter
Copied the description from ip.8. Signed-off-by: Phil Sutter --- man/man8/bridge.8 | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index 6dfd4178a19cc..53cd3d0a3d933 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8

[iproute PATCH 06/10] man: ifstat.8: Document --json and --pretty options

2018-08-16 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/ifstat.8 | 8 1 file changed, 8 insertions(+) diff --git a/man/man8/ifstat.8 b/man/man8/ifstat.8 index 3ba0088d8940a..8cd164dda6d72 100644 --- a/man/man8/ifstat.8 +++ b/man/man8/ifstat.8 @@ -48,6 +48,14 @@ Report average over the last SECS

[iproute PATCH 08/10] man: rtacct.8: Fix nstat options

2018-08-16 Thread Phil Sutter
Add missing --pretty and --json options, correct --zero to --zeros and correct the mess around --scan/--interval including broken man page formatting. Signed-off-by: Phil Sutter --- man/man8/rtacct.8 | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git

[PATCH net-next v1] net/tls: Add support for async decryption of tls records

2018-08-16 Thread Vakul Garg
When tls records are decrypted using asynchronous acclerators such as NXP CAAM engine, the crypto apis return -EINPROGRESS. Presently, on getting -EINPROGRESS, the tls record processing stops till the time the crypto accelerator finishes off and returns the result. This incurs a context switch and

[iproute PATCH v4] Make colored output configurable

2018-08-16 Thread Phil Sutter
Allow for -color={never,auto,always} to have colored output disabled, enabled only if stdout is a terminal or enabled regardless of stdout state. Signed-off-by: Phil Sutter --- Changes since v1: - Allow to override isatty() check by specifying '-color' flag more than once. - Document new

Re: [iproute PATCH v3] Make colored output configurable

2018-08-16 Thread Phil Sutter
On Thu, Aug 16, 2018 at 10:19:50AM +0200, Phil Sutter wrote: > Allow for -color={never,auto,always} to have colored output disabled, > enabled only if stdout is a terminal or enabled regardless of stdout > state. > > Signed-off-by: Phil Sutter Argh, please ignore this one - it doesn't even

Re: bnxt: card intermittently hanging and dropping link

2018-08-16 Thread Daniel Axtens
Hi Michael, > The main issue is the TX timeout. > . > >> [ 2682.911693] bnxt_en :3b:00.0 eth4: TX timeout detected, starting >> reset task! >> [ 2683.782496] bnxt_en :3b:00.0 eth4: Resp cmpl intr err msg: 0x51 >> [ 2683.783061] bnxt_en :3b:00.0 eth4: hwrm_ring_free tx failed.

[PATCH v3] net/mlx5e: Delete unneeded function argument

2018-08-16 Thread Yuval Shaia
priv argument is not used by the function, delete it. Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") Signed-off-by: Yuval Shaia --- v1 -> v2: * Remove blank line as pointed by Leon. v2 -> v3: * Change prefix to mlx5e ---

Re: [PATCH v2] net/mlx5: Delete unneeded function argument

2018-08-16 Thread Yuval Shaia
On Thu, Aug 16, 2018 at 09:41:34AM +0300, Gal Pressman wrote: > On 15-Aug-18 18:08, Yuval Shaia wrote: > > priv argument is not used by the function, delete it. > > > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > > Signed-off-by: Yuval Shaia > > nit: prefix should be

[iproute PATCH v3] Make colored output configurable

2018-08-16 Thread Phil Sutter
Allow for -color={never,auto,always} to have colored output disabled, enabled only if stdout is a terminal or enabled regardless of stdout state. Signed-off-by: Phil Sutter --- Changes since v1: - Allow to override isatty() check by specifying '-color' flag more than once. - Document new

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread maowenan
On 2018/8/16 15:44, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at 03:39:14PM +0800, maowenan wrote: >> >> >> On 2018/8/16 15:23, Michal Kubecek wrote: >>> On Thu, Aug 16, 2018 at 03:19:12PM +0800, maowenan wrote: On 2018/8/16 14:52, Michal Kubecek wrote: > > My point is that

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Michal Kubecek
On Thu, Aug 16, 2018 at 03:39:14PM +0800, maowenan wrote: > > > On 2018/8/16 15:23, Michal Kubecek wrote: > > On Thu, Aug 16, 2018 at 03:19:12PM +0800, maowenan wrote: > >> On 2018/8/16 14:52, Michal Kubecek wrote: > >>> > >>> My point is that backporting all this into stable 4.4 is quite

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread maowenan
On 2018/8/16 15:23, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at 03:19:12PM +0800, maowenan wrote: >> On 2018/8/16 14:52, Michal Kubecek wrote: >>> >>> My point is that backporting all this into stable 4.4 is quite intrusive >>> so that if we can achieve similar results with a simple fix of

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Michal Kubecek
On Thu, Aug 16, 2018 at 03:19:12PM +0800, maowenan wrote: > On 2018/8/16 14:52, Michal Kubecek wrote: > > > > My point is that backporting all this into stable 4.4 is quite intrusive > > so that if we can achieve similar results with a simple fix of an > > obvious omission, it would be

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread maowenan
On 2018/8/16 14:52, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at 02:42:32PM +0800, maowenan wrote: >> On 2018/8/16 14:16, Michal Kubecek wrote: >>> On Thu, Aug 16, 2018 at 10:50:01AM +0800, Mao Wenan wrote: There are five patches to fix CVE-2018-5390 in latest mainline branch, but

Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

2018-08-16 Thread Ahmad Fatoum
On 08/15/2018 04:32 AM, Andrew Lunn wrote: > Ahmed, where is the device tree for the EVB-KSZ9477? I've attached it [1]. It's still work-in-progress (DSA doesn't work yet for example), but Ethernet is usable with Linux v4.18 and my patch applied. Cheers Ahmad [1]

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Michal Kubecek
On Thu, Aug 16, 2018 at 02:42:32PM +0800, maowenan wrote: > On 2018/8/16 14:16, Michal Kubecek wrote: > > On Thu, Aug 16, 2018 at 10:50:01AM +0800, Mao Wenan wrote: > >> There are five patches to fix CVE-2018-5390 in latest mainline > >> branch, but only two patches exist in stable 4.4 and 3.18:

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread maowenan
On 2018/8/16 14:16, Michal Kubecek wrote: > On Thu, Aug 16, 2018 at 10:50:01AM +0800, Mao Wenan wrote: >> There are five patches to fix CVE-2018-5390 in latest mainline >> branch, but only two patches exist in stable 4.4 and 3.18: >> dc6ae4d tcp: detect malicious patterns in

Re: [PATCH v2] net/mlx5: Delete unneeded function argument

2018-08-16 Thread Gal Pressman
On 15-Aug-18 18:08, Yuval Shaia wrote: > priv argument is not used by the function, delete it. > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > Signed-off-by: Yuval Shaia nit: prefix should be net/mlx5e. > --- > v1 -> v2: > * Remove blank line as pointed by Leon.

Re: bnxt: card intermittently hanging and dropping link

2018-08-16 Thread Michael Chan
On Wed, Aug 15, 2018 at 10:29 PM, Daniel Axtens wrote: > [ 2682.911295] [ cut here ] > [ 2682.911319] NETDEV WATCHDOG: eth4 (bnxt_en): transmit queue 0 timed out The main issue is the TX timeout. . > [ 2682.911693] bnxt_en :3b:00.0 eth4: TX timeout detected,

Re: [PATCH stable 4.4 0/9] fix SegmentSmack in stable branch (CVE-2018-5390)

2018-08-16 Thread Michal Kubecek
On Thu, Aug 16, 2018 at 10:50:01AM +0800, Mao Wenan wrote: > There are five patches to fix CVE-2018-5390 in latest mainline > branch, but only two patches exist in stable 4.4 and 3.18: > dc6ae4d tcp: detect malicious patterns in tcp_collapse_ofo_queue() > 5fbec48 tcp: avoid collapses in

Re: [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()"

2018-08-16 Thread Greg KH
On Thu, Aug 16, 2018 at 09:55:42AM +0800, maowenan wrote: > > > On 2018/8/15 21:18, Greg KH wrote: > > On Wed, Aug 15, 2018 at 09:21:00PM +0800, Mao Wenan wrote: > >> This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. > > > > I need a reason why, and a signed-off-by line :( > >